1174 Commits (6cd8e4e4584cc2a3423a64dd8d5d62c32a8c5b89)

Author	SHA1	Message	Date
John Ralls	3d30e5978a	Merge Richard Cohen's 'define-boxed' into stable.	3 years ago
Richard Cohen	ae9304efb0	Remove unused boxed type gnc_value_list	3 years ago
Richard Cohen	f9efbf86c6	Remove unused Qofbook::ab-templates property	3 years ago
Mike Alexander	6bdaa161eb	Redo 71afa3e0 and 71afa3e0 so powten(max_leg_digits) is 1e18 ... This is what it was before 71afa3e0. This is the largest power of ten that fits in an int64.	3 years ago
Richard Cohen	eb2d5df778	Refactor: DEFINE_BOXED GncGUID	3 years ago
Richard Cohen	c514f61a7a	Refactor: DEFINE_BOXED Time64	3 years ago
Richard Cohen	14f2efcfb7	Refactor: DEFINE_BOXED gnc_numeric	3 years ago
John Ralls	bba49a6d09	Fix test-gnc-euro failure. ... Fixing the pow[] array required also adjusting the number of denominator digits when converting doubles to gnc_numerics.	3 years ago
Mike Alexander	71afa3e0fc	Make the GncNumeric string constructtor work for long decimal numbers. ... It was failing to produce a correct representation for input with more than 14 digits after the decimal poin. Fixes Bug 798916. The bug was in powten so this fix may corect other problems too. For example conversion of GncNumeric back to a string also failed in certain circumsances.	3 years ago
John Ralls	8ccc6da87e	Merge Richard Cohen's 'fix-test-engine-crash' into stable.	3 years ago
John Ralls	26162da450	Merge Richard Cohen's 'cleanup-build' into stable.	3 years ago
Richard Cohen	81fba56bbb	Initialise guids in test-engine-kvp-properties.c ... Valgrind: Conditional jump or move depends on uninitialised value(s)	3 years ago
Richard Cohen	bed43c7f3b	Fix potential crash in test-engine ... ==515314== Invalid read of size 1 ==515314== at 0x484AD67: __strcmp_sse42 (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x171D36: do_test_list_handler (unittest-support.c:181) ==515314== by 0x171DCE: test_list_handler (unittest-support.c:197) ==515314== by 0x51BD4C1: g_logv (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51BD7A2: g_log (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x4D5D0D9: xaccSplitEqualCheckBal (Split.c:753) ==515314== by 0x4D5D841: xaccSplitEqual (Split.c:869) ==515314== by 0x4D647A5: xaccTransEqual (Transaction.c:981) ==515314== by 0x15C0E8: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:901) ... ==515314== Address 0x8725260 is 0 bytes inside a block of size 59 free'd ==515314== at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x15BDB1: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:883) ... ==515314== Block was alloc'd at ==515314== at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x5618677: __vasprintf_internal (vasprintf.c:116) ==515314== by 0x520E8C1: g_vasprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51DBBE0: g_strdup_vprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51DBC9C: g_strdup_printf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x15BBAC: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:879) ... ok 78 /engine/Transaction/xaccTransEqual	3 years ago
Richard Cohen	dc62959553	Fix crash in test-engine on Arch ... Thanks, Valgrind: ==515314== Invalid read of size 8 ==515314== at 0x4ED46F3: gncInvoiceRemoveEntries (gncInvoice.c:767) ==515314== by 0x142B35: teardown_with_invoice (utest-Invoice.c:274) ... ==515314== Address 0x8557b98 is 8 bytes inside a block of size 24 free'd ==515314== at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x51B565D: g_list_remove (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x4ED42EF: gncInvoiceRemoveEntry (gncInvoice.c:688) ==515314== by 0x4ED46A2: gncInvoiceRemoveEntries (gncInvoice.c:781) ==515314== by 0x142B35: teardown_with_invoice (utest-Invoice.c:274) ... ==515314== Block was alloc'd at ==515314== at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x51BD948: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51B1CB9: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x4ED4271: gncInvoiceAddEntry (gncInvoice.c:676) ==515314== by 0x142401: setup_with_invoice (utest-Invoice.c:142) ... ok 57 /engine/gncInvoice/post trans - vendor bill	3 years ago
Richard Cohen	80e9d9c35d	scanf supports %lld since C++11, C99	3 years ago
Richard Cohen	3957272ef0	Fix some typos in comments	3 years ago
John Ralls	bb423e4484	Merge CrfzdPQM6's 'b_betterCurrencyBudgetReporting' into stable.	3 years ago
Daniel Johnson	04b0317119	Demonstrate fx handling in budget report	3 years ago
John Ralls	df878c6a3d	Merge Maarten Bosmans's 'memleak-fixes' into stable.	3 years ago
Maarten Bosmans	6be682b645	Store allocated temporaries in a variable so they can be freed ... If a function that returns an allocated pointer is passed directly into something that does not take ownership of the pointer, the allocation is leaked. This can be fixed by assigning the pointer to a new variable and freeing it after operation on the memory.	3 years ago
Christopher Lam	1a7fcb69c0	[gnc-features.cpp] remove_if requires <algorithm>	3 years ago
John Ralls	8481f062d4	Create obsolete features list with first member book_currency. ... Obsolete features set in the book will be removed from the book's KVP and ignored. Note the warning in the comment!	3 years ago
John Ralls	0d175dce12	Refactor gnc-features. ... * type aliases to gnc-features.h * string_views to avoid copying (all of the strings are static) * qof_book_get_unknown_features returns a FeatureSet	3 years ago
John Ralls	e8c80f2f5c	Restore existence, but not implementation, of GNC_FEATURE_BOOK_CURRENCY. ... At least one user has managed to get it set on their book so even though it was supposed to be unimplemented it got through somehow. Restoring it allows books with it set to load.	3 years ago
Muhammadyusuf	02e24ccf96	edit: use &apos; instead of ` symbol	3 years ago
Muhammadyusuf	dca596ac84	edit: Fix local symbol of uzbek sum	3 years ago
Vincent Dawans	761d7f29a5	Bug 765920 - Running balance not accurate when sorted different ways ... - Renamed option to "Account Balance" to avoid confusion with running total. - Added helper function to ensure running balance and balance forward are only shown when transaction are grouped by account and sorted as in register. In that case column heading remains "Running Balance" and balance forward is shown. Otherwwise column heading is renamed "Account Balance" and balance forward is not shown. - Also added missing code for Common Currency conversion.	3 years ago
John Ralls	4a5b897d89	Bug 798863 - Crash on clicking Settings button second time ... Ensure that dialog resources stored in options are freed when the dialog is destroyed. The crash happened when a new dialog replaced the old one on the options and the old one's destructors tried to access a dangling reference to a GtkWidget.	3 years ago
John Ralls	f4f481fe38	Bug 798812 - crashes after I open a customer report and select… ... Edit/Report Options As a result of auto instead of auto& in a std::visit call which resulted in a temporary option whose GncOwner* was destroyed before we could use it.	3 years ago
Robert Fewell	0d84506a5e	Bug 798851 - Account Balance 'include subaccounts' not saved ... The defaults for the account were removed by mistake in a previous commit, added them back.	3 years ago
Maarten Bosmans	0d86be6d2a	[test] Properly destroy resources on end of tests ... This fixes memory leaks that are only present in testing code. Not very useful on itself, but it does make it easier to fix memory leaks and other AddressSanitizer problems in actual gnucash code later.	3 years ago
Maarten Bosmans	ed3fe00880	[test] Use test fixture to initialize and destroy resources	3 years ago
Maarten Bosmans	35aeed45ec	[engine] Remove two replace functions from KvpValue ... These were not used outside a test. And that test was not leak free, as a result of the functions not doing what they are supposed to do when the current value is not of the type that is expected. (NULL is returned, but the value is not replaced)	3 years ago
Richard Cohen	6ba5bb326a	Fix dereference of expired temporaries. ... Reported by clang 15.0.7, which will be in Ubuntu 23.04, -Wdangling-gsl	3 years ago
Richard Cohen	9fa2a48fe1	Fix build on gcc-8 & 9. ... See https://lists.gnucash.org/pipermail/gnucash-devel/2023-March/046617.html	3 years ago
John Ralls	00c560d8f5	Move operator==(const GncGUID&, const GncGUID&) to guid.[ch]pp.	3 years ago
John Ralls	352ab8a0e5	Merge Richard Cohen's 'minor-options-fixes' into master.	3 years ago
Richard Cohen	24f52d9b17	Remove incorrect operator!= for GncItem ... It's better to use the default std::pair implementation - spotted by clang-tidy bugprone-suspicious-string-compare - will always return false, because type is the same Also, - remove redundant "using GncItem ..."	3 years ago
Richard Cohen	b5f3f99035	Fix incorrect use of remove_if() ... - spotted by clang-tidy bugprone - probably no visible effects because of uniqueness, and other checks libgnucash/engine/gnc-optiondb.cpp:149:5: warning: this call will remove at most one item even when multiple items should be removed [bugprone-inaccurate-erase] m_options.erase(std::remove_if(m_options.begin(), m_options.end(), ^ libgnucash/engine/gnc-optiondb.cpp:358:5: warning: the value returned by this function should be used [bugprone-unused-return-value] std::remove_if(m_callbacks.begin(), m_callbacks.end(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libgnucash/engine/gnc-optiondb.cpp:358:5: note: cast the expression to void to silence this warning	3 years ago
John Ralls	b4b8431984	Bug 798778 - GnuCashquits abruptly when attempting to edit options… ... for certain reports. Those reports being ones using complex options, apparently because the callbacks weren't protected from Guile's garbage collector. So replace the anyway ugly hack of a void* with a std::any wrapping a class holding a std::unique_ptr with a custom deleter. The constructor calls scm_gc_protect_object on the SCM containing the callback and the custom deleter calls scm_gc_unprotect_object. The copy constructor, required for std::any, makes a new std::unique_ptr and calls scm_gc_protect_object again ensuring that the protect and unprotect calls are symmetrical. Meanwhile std::any hides the Guile dependency from all the classes that don't need to know about it. The only ugliness is that there's no good place to put a common implementation of SCNCallbackWrapper so it's repeated in gnc-optiondb.i and dialog-options.cpp.	3 years ago
John Ralls	a44b3664e2	[c++options] Implement GncOptionGncOwnerValue class. ... GncOwners aren't QofInstances and have limited lifetimes so an option must hold its own, wrapped in std::unique_ptr for memory management.	3 years ago
John Ralls	8db8105850	[c++options] Warn when an option variant type's set_value isn't found.	3 years ago
John Ralls	83829e6513	Merge branch 'maint'	3 years ago
John Ralls	1020bde89c	Fix crashes in test-engine on Arch Linux. ... Root cause is mutating a list while it's iterating. We're able to protect it in two cases, have to copy it in xaccTransScrubGainsDate.	3 years ago
Geert Janssens	d75ab275f1	Eliminate gnc-csv-account-map.[ch] ... The code is was only used by the csv import assistant and forced gtk as a dependency on gnc-imp-props-tx Part has been moved to Account, other bits have been moved to the importer code where they were used.	3 years ago
Richard Cohen	329a2f7d42	Guard against some possible null pointer dereferences ... Found by gcc 12 when compiling with "-O2 -Wnull-dereference"	3 years ago
John Ralls	cdb674ebf1	[c++options]Really fix the gnc_option_db_lookup_string_value leak ... By deleting the function and using GncOptionDbImpl::lookup_string_option directly. It returns a string that we don't have to worry about memory-managing. Also create a new GncOptionDbImpl::set_string_option to replace gnc_option_db_set_string_value.	3 years ago
John Ralls	92071e8844	[c++options] Fix leak.	3 years ago
John Ralls	f735c64cac	Merge Richard Cohen's 'extern-c-part2' into master.	3 years ago
Richard Cohen	7b47c07f8e	Don't use extern "C" around #includes ... Some I missed the first time. Some are new.	3 years ago
John Ralls	bbfa378783	Don't crash and do pass tests.	3 years ago
John Ralls	af02dae286	Fixups for merging into master instead of maint.	3 years ago
John Ralls	1eecb9f5c0	[c++ options] Fix locale dependency in test-gnc-option-scheme-output. ... Created by using std::to_string() in GncOptionRangeValue::serialize. It wraps sprintf that reads the locale. Use ostringstream instead.	3 years ago
Christopher Lam	76014f18a0	[account.cpp] don't cache char* [fails]	3 years ago
Christopher Lam	3d381eb6fd	[gnc-lot] don't cache char*	3 years ago
Christopher Lam	50f998fad8	[gncInvoice] don't cache char*	3 years ago
Christopher Lam	c9dc71978b	[gnc-commodity] don't cache char*	3 years ago
Christopher Lam	57fcaabd8f	[Split.c] don't cache char*	3 years ago
John Ralls	675d894128	Merge Richard Cohen's 'cleanup-options' into master.	3 years ago
John Ralls	ca73b00039	Merge Richard Cohen's 'cleanup-boost' into master.	3 years ago
John Ralls	3d5e27982f	Merge branch 'maint'	3 years ago
John Ralls	7f0353adc4	Fix a missed g_value_dup_string and some no longer used variables.	3 years ago
John Ralls	8a7c539258	Bug 798748 - Transaction Notes field's value does not appear in... ... reverse transaction. The proximate cause was that xaccTransBeginEdit put the KVP cache variable of the new transaction in a state that prevented the value from being copied. More generally the KVP cache variables didn't handle any invalidating events. With the change to GValue usage in qof_instance_get_kvp it's now a simple memory dereference with no copying except for POD types so caching is no longer useful. This commit removes caching from Transaction, eliminating the notes problem.	3 years ago
John Ralls	ddc3f28899	[kvp] Use static strings and boxed in gvalue_from_kvp_value. ... Saves allocating and copying complex values, avoiding potential memory leaks.	3 years ago
Richard Cohen	9f06859390	Remove references to old boost versions ... we already require 1.67	3 years ago
Richard Cohen	3d995de2ab	Refactor: use default GncOptionValue copy constructor	3 years ago
Richard Cohen	1b0af4246a	Refactor: remove extra template parameter from member functions	3 years ago
Richard Cohen	87c52f53fa	Update some references to hello-world.scm	3 years ago
Richard Cohen	ec169e6e24	Fix some non-translatable typos	3 years ago
John Ralls	6ab7b16d62	[c++options] Restore the ability to set plot sizes in pixels. ... Enable and fix the previously untested GtkOptionGtkUIItem::PLOTSIZE. This has the potentially unfortunate side effect that integer range options are assumed to be plot sizes. That's correct for now, but if some report comes along that needs an integer range option for something else it will have to be differentiated.	3 years ago
Geert Janssens	549c93e005	Fix test for import-backend ... Another split function needed mocking	3 years ago
Richard Cohen	bddb4468fa	Import GLIB2 as a target, and use it to simplify the CMakeLists	3 years ago
Robert Fewell	ec7cc27d6d	Add tests for default invoice report book property	3 years ago
Robert Fewell	76f0e3a97e	Add some PWARN messages to the default invoice report ... book functions	3 years ago
Richard Cohen	9c6ad222a9	[-Wunused-function] - remove	3 years ago
Richard Cohen	0dd406de10	[-Wunused-lambda-capture] (clang) - remove	3 years ago
Richard Cohen	d4dfe4e279	[-Wunused-local-typedef] - remove ... libgnucash/engine/test/utest-Account.cpp:2414:11: warning: typedef ‘using AcctTypeType = struct std::underlying_type<GNCAccountType>’ locally defined but not used [-Wunused-local-typedefs] 2414 | using AcctTypeType = std::underlying_type<GNCAccountType>; | ^~~~~~~~~~~~	3 years ago
Richard Cohen	0798bce2a6	[-Wunused-value] - remove ... borrowed/jenny/jenny.c: In function ‘next_builder’: borrowed/jenny/jenny.c:1164:5: warning: statement with no effect [-Wunused-value] 1164 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c:1172:5: warning: statement with no effect [-Wunused-value] 1172 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c: In function ‘confirm’: borrowed/jenny/jenny.c:1797:7: warning: statement with no effect [-Wunused-value] 1797 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c:1805:7: warning: statement with no effect [-Wunused-value] 1805 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ libgnucash/backend/xml/io-gncxml-v2.cpp: In function ‘gboolean qof_session_load_from_xml_file_v2_full(GncXmlBackend*, QofBook*, sixtp_push_handler, gpointer, QofBookFileType)’: libgnucash/backend/xml/io-gncxml-v2.cpp:806:40: warning: value computed is not used [-Wunused-value] 806 | g_thread_join (thread) != nullptr; | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp: In function ‘void xaccFreeAccount(Account*)’: libgnucash/engine/Account.cpp:1428:17: warning: statement has no effect [-Wunused-value] 1428 | priv->color == nullptr; | ~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1429:22: warning: statement has no effect [-Wunused-value] 1429 | priv->sort_order == nullptr; | ~~~~~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1430:17: warning: statement has no effect [-Wunused-value] 1430 | priv->notes == nullptr; | ~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1431:18: warning: statement has no effect [-Wunused-value] 1431 | priv->filter == nullptr; | ~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/gnc-int128.cpp: In function ‘void decimal_from_binary(uint64_t*, uint64_t, uint64_t)’: libgnucash/engine/gnc-int128.cpp:898:36: warning: right operand of comma operator has no effect [-Wunused-value] 898 | d[3] = (hi >> 32) & bin_mask, 0; | ^	3 years ago
Richard Cohen	1c6679720b	Use some unused variables	3 years ago
Richard Cohen	78ec20515b	Remove some unused variables - and the initialization ... - checked that any side effects were irrelevant	3 years ago
Richard Cohen	c819b03a17	Remove some unused variables - leave the side effect	3 years ago
Richard Cohen	ea2d3be217	Remove some unused variables with obviously no side effects	3 years ago
Robert Fewell	45a07463fb	Change max timeout to 20 seconds for default invoice report	3 years ago
Geert Janssens	60209a766f	Merge branch 'csv_import'	3 years ago
Geert Janssens	2d8bb6f62f	Bug 796955 - Import CSV - Single-line two-currency transactions can't be imported ... Behaviour is as follows: If single line provides a price And at some point in the import process we get into a situation where the base account and transfer account have a different commodity Then transfer_acct amount = base_acct amount * price If on the other hand base_acct and transfer_acct turn out to have the same commodity, price is ignored.	3 years ago
Geert Janssens	99506d331a	Reduce GncImportMatchMap to just the account ... There is no added value in storing the book and account together The book is easily retrieved from the account (as was illustrated in the gnc_account_imap_new function). I looked through the commit history to understand why this struct was originally created and a long time ago it also had a reference to a kvp frame.	3 years ago
Geert Janssens	51706f289c	Minor corrections in comments	3 years ago
John Ralls	7bb14b9caa	Merge Richard Cohen's 'use-reference-for-loop' into master	3 years ago
Robert Fewell	07f3f536cc	Allow to select saved report on print invoice button ... This change was inspired by mildred's #PR1247 and uses the new GncReportCombo to allow selection of 'Saved Invoice reports' when the invoice print button is used or when printing multiple invoices. This change presents a dialog with the default for the report combo set to the properties setting. This dialog has a timeout which is adjustable under properties and will stop if a key is pressed or combo popped so that a different report template can be selected and used. There is also an 'OK' button that stops the time out and prints and a 'Cancel' button which cancels the print.	3 years ago
Robert Fewell	019214f1c2	Bug753307 - Custom Report be selectable as default Report for Printing ... This commit changes the preference in Business->'Report for Printing' to be saved as a book property and allow the selection of any Invoice Report to be used as the default.	3 years ago
Richard Cohen	d8f45f2443	Use const references for for-loops to avoid unnecessary copies ... Found by clazy - clazy-range-loop-reference	3 years ago
Christopher Lam	119356752f	Merge branch 'maint'	3 years ago
Geert Janssens	894f8241e1	Revisit invoice payment in multi-currency context ... - Show proper amount in dialog when applying or editing an existing transaction as payment - Be more careful not to waste the existing payment split - If the user changed the payment amount while starting from an existing transaction unreconcile the changed payment split - Avoid needlessly changing transaction currency (only do so if the user chose a new transfer account and the old currency is neither the new transfer account's currency nor the post account's currency)	3 years ago
luzpaz	67ab9e90d2	Fix some typos	3 years ago
Christopher Lam	17820ec261	Merge branch 'maint'	3 years ago
John Ralls	f4c6d65395	Merge Bob Fewell's 'nofree' into maint.	3 years ago
John Ralls	f6919e60a7	Merge Richard Cohen's 'cleanup' into master.	3 years ago
John Ralls	46f9fb01c9	Simplify gnc_commodity equality and compare functions. ... gnc_commodity_compare is used for sorting and so needs to have a less-than return value. The only place it's used presents nothing to the UI; a GncGUID ordering is fast and stable. GnuCash allows only one commodity per book for any namespace/mnemonic pair, so the exhaustive string comparisons are superflous. While the current engine design allows only one instance of any object, meaning that a pointer comparison is sufficient to determine equality, that may not be true in the future, but the GncGUID is guaranteed to sufficiently identify a single commodity. Note that gnc_commodity_equiv is used to enforce that single-commodity rule and so cannot use GncGUID comparison.	3 years ago
Richard Cohen	6927535a0a	Remove unused test function get_object_is_initialized in qofobject.cpp	3 years ago
Richard Cohen	e83c91050c	Remove unneeded dummy.cpp	3 years ago
Richard Cohen	d6ac56ce5f	Re-enable -Waddress - gncInvoiceLookup etc. are now inline functions, not macros ... - Remove outdated comments	3 years ago
Richard Cohen	3360a6d13b	Remove extra semicolons ... Courtesy of gcc -pedantic	3 years ago
John Ralls	046e4a156e	Silence Clang deprecation warnings about sprintf.	3 years ago
John Ralls	dd2497416c	Merge Richard Cohen's 'internal-extern-c' into master.	3 years ago
John Ralls	60c06debce	[c++options] Don't crash when find_option returns nullopt.	3 years ago
Richard Cohen	1cec0cb3f3	Use internal extern "C" { ... } for C++ ... - removes warnings compiling swig engine ... [ 10%] Generating swig-engine.cpp .../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored), .../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'. .../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".	3 years ago
Richard Cohen	19bbde7000	Fix some typos	3 years ago
John Ralls	9a1a90d8d0	Merge branch 'maint'	3 years ago
richardcohen	f3cc223f5f	Fix some bad code formatting	3 years ago
Christopher Lam	fd007a0af1	Merge branch 'maint'	3 years ago
Robert Fewell	6df866f876	Add tests for the reconcile account functions	3 years ago
Robert Fewell	fd37ee997d	Fix getting xaccAccountGetReconcilePostponeBalance ... Change the G_VALUE from a INT64 to BOXED.	3 years ago
John Ralls	fb9947b7b6	Rename GncDateTime's ymd to gnc_ymd to avoid a name conflict with Carbon.	3 years ago
Christopher Lam	c65b36490a	Merge branch 'master-progress'	3 years ago
Frank H. Ellenberger	506a1b3c5e	Merge branch 'maint'	3 years ago
John Ralls	b922cfd78d	Bug 798679 - Unicode normalization should be used for comparison but not stored. ... Change to NFC normalization for all comparisons because the Unicode meaning of compatible might collide with the user's intent.	3 years ago
John Ralls	31d79e3004	Merge Bob Fewell's 'bug798673' into master.	3 years ago
Christopher Lam	259881f940	[gnc-optiondb] add some more renamed options ... following ab13b01f8c Replace ... with … in all translatable strings.	3 years ago
John Ralls	ab13b01f8c	Replace ... with … in all translatable strings. ... Also a few other places like translator comments and report options. Replaces https://github.com/Gnucash/gnucash/pull/1033.	3 years ago
John Ralls	b8c0673526	Merge branch 'maint'	3 years ago
Robert Fewell	3be25ff0a9	Add some tests for the account functions	3 years ago
Robert Fewell	a15c6f81b3	Allow the balances of sub accounts to be used in limits	3 years ago
John Ralls	73a134730f	Bug 798680 - Not able to match a reverse transaction of a... ... previously matched transaction. Cloned transactions and copied splits shouldn't keep the online-id slot.	3 years ago
Robert Fewell	518ecfe041	Add some functions that would allow adding a balance limit to accounts	3 years ago
Christopher Lam	bfc325f63c	Merge branch 'maint'	3 years ago
Marco Scardovi	6fe2028bca	Fix test ... Signed-off-by: Marco Scardovi <mscardovi@icloud.com>	3 years ago
Robert Fewell	59d95a4ce6	Bug 798545 - Crash when updating document link on vendor bill ... There were two issues here, the first one was that the copied doclink was pointing to the original doclink which lead to a double-free. The second is the setting of the doclink on the copied invoice needs to be done with gncInvoiceSetDocLink otherwise on closure the doclink value will disappear.	3 years ago
Christopher Lam	3d8a28898d	[gnc-budget] gnc_budget_get_account_period_note returns a const ... to harmonize with all other char getters	3 years ago
Christopher Lam	2ee0c98200	[gnc-budget] use operator[] instead of find() and insert() ... - avoid hashing Account* twice. one call to operator[] is sufficient. - don't need use std::move with better constructors - sanity check - can't have a budget with num_periods = 0 - remove unused headers	3 years ago
Christopher Lam	3e5fcc8709	Merge branch 'maint'	4 years ago
Christopher Lam	6f80c548e6	[gtest-qofevent.cpp] comprehensive tests for qofevent	4 years ago
Christopher Lam	05ffd3d4eb	[budget-feature] move unset_feature call to gnc_budget_gui_delete_budget ... because gnc_budget_gui_delete_budget is a more general function to delete a budget.	4 years ago
Christopher Lam	b87aa004f9	[test-qofbook] add tests for unknown features ... tests that gnc_features_test_unknown returns a suitable error message	4 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	4 years ago
Christopher Lam	fc94b41c81	Merge branch 'maint'	4 years ago
Christopher Lam	4716af24e4	Merge branch 'maint'	4 years ago
Christopher Lam	f2354d6b2a	[test-qofbook.c] add test for gnc_features_set_unused	4 years ago
Christopher Lam	1516bb18b0	[gnc-features.cpp] backport gnc_features_set_unused from master	4 years ago
Christopher Lam	a078921a33	[qofbook.cpp] backport qof_book_unset_feature from master	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
Christopher Lam	093aa81ed1	[qofbook.cpp] deprecate qof_book_get_features	4 years ago
Christopher Lam	8192deff37	[gnc-features.cpp] convert to cpp ... - don't need to create/destroy GHashTable for each feature query - plugs leak: g_hash_table_unref (features_used) not always called properly - to check 1 feature, don't need to traverse whole GHashTable	4 years ago
Christopher Lam	6f6d2fef48	[test-qofbook] basic features test ... sets a feature and tests it's set. it's impossible to design a book with unknown features using the API.	4 years ago
Geert Janssens	e97fc3e408	Drop price-quotes.scm, gnc-fq-helper.in and gnc-fq-check.in - no longer used	4 years ago
Geert Janssens	a6771754d5	GncQuotes - start implementation of fetch/fetch_all	4 years ago
John Ralls	b0ae402c23	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	3c75d212ab	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	8cb8f5067d	Remove non-ISO4217 currency codes from gnc-euro table. ... They're not reachable because they don't have commodities associated with them.	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	3949821da6	Merge branch 'maint'	4 years ago
John Ralls	2505955ab9	Fix test failure from Bug 798616 fix.	4 years ago
John Ralls	7c350c3ae5	Bug 798616 - Can't register amount greater than 9,000,000,000 ... Because when loading the value the split in the xml backend doesn't yet have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION and if the numerator was larger than 10^10 that would overflow. To fix it this changes the "don't know" response to get_currency_denom and get_commodity_denom to GNC_DENOM_AUTO which will normally leave the denominator alone.	4 years ago
Christopher Lam	161b07b241	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	47fa8b281e	Merge PR #1425 into maint	4 years ago
John Ralls	a807d3e6b7	Create function gnc_tm_get_today_neutral. ... To complement gnc_tm_get_today_begin and gnc_tm_get_today_end.	4 years ago
luz paz	ba94730a23	Fix various typos ... Found via `codespell`	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. ... Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago
Christopher Lam	0b5a4cd298	Merge branch 'maint'	4 years ago
Christopher Lam	d1aefc851d	[sx-book] free sx_list before g_object_unreffing sxes	4 years ago
John Ralls	688832b5f8	Bug 798585 - segfault running sample script ... The root cause of which is that on recent releases of GLib (recent meaning 2.66 in the current Debian stable!) g_type_instance_get_private looks in the wrong place for the private data. When running the script in question it returned NULL and since the code didn't check for a valid pointer, it crashed. So this change replaces all calls to g_type_instance_get_private with the function [type_prefix]_get_instance_private() added in glib-2.36 except for two register2 files that have been removed from master; those are ignored to avoid unnecessary merge conflicts.	4 years ago
Christopher Lam	7880f9b16f	[SchedXaction.c] free list of recurrences	4 years ago
Christopher Lam	f1adb5da34	Merge branch 'TXN_TYPE-is-dynamic' xaccTransGetTxnType into maint #1201	4 years ago
Christopher Lam	ec3e996f92	tests xaccTransGetTxnType heuristics ... tests TXN_TYPE_NONE in utest-Transaction.c testing TXN_TYPE_INVOICE, TXN_TYPE_PAYMENT, and TXN_TYPE_LINK will require valid posted invoices, so, are best tested in utest-Invoice.c	4 years ago
Christopher Lam	fd12d3900c	[Transaction.c] use heuristics to determine txn->txn_type	4 years ago
Robert Fewell	ce4768c357	Bug 798565 - Import map editor entry deletion ... When a top level bayesian entry is deleted, the book is not marked dirty and so the save button is not highlighted. Deleting individual entries did mark book dirty. Fixed in gnc_account_delete_all_bayes_maps by wrapping the deletion with xaccAccountBeginEdit/CommitEdit block.	4 years ago
John Ralls	3fd8bd9ddf	Merge branch 'maint'	4 years ago
Christopher Lam	aa43c198c6	[Transaction.c] don't set TxnType kvp if it is the same as before ... will avoid dirtying the transaction.	4 years ago
John Ralls	9f6d495ca1	Fix use-after-free crash in utest-Invoice.	4 years ago
John Ralls	1e6c679e71	Merge branch 'maint'	4 years ago
John Ralls	903cbdcad3	Bug 798547 - Calculated Due Date is short 1 day when posting on... ... day of fall change from Daylight Time to Standard Time. Really any day where the period crosses the dst->std change, and since the date dialog returns local midnight for the time that includes the day of the change. Convert both the parameter time and the return time to neutral time to ensure that the interval is handled correctly.	4 years ago
Christopher Lam	670902d5a8	Bug 798535 - Crash when increasing the number of periods in a budget ... because in the SQL backend, gnc_budget_commit_edit will update the sql by reading from vectors with an increased priv->num_periods.	4 years ago
Robert Fewell	27cab58bf2	Correct some text describing some date functions.	4 years ago
Robert Fewell	c000a890ad	Bug 798501 - Balance wrong date end of account period ... With the accounting period preference settings set to 'Start/End of previous quarter' and balance sheet report using 'End of accounting period' the date is wrong, currently is 30/03/2022 when it should be 31/03/2022. Simplify gnc_gdate_set_quarter_end to get correct last day and subtract the 3 months befor calling said function.	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Christopher Lam	e1d52963ed	[account.cpp] restore breadth-first search for 2 functions ... gnc_account_lookup_by_name and gnc_account_lookup_by_code were searching breadth-first and accidentally changed to depth-first in 4.7. as reported in https://github.com/Gnucash/gnucash/pull/1101#issuecomment-1098146573	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' ... # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
Christopher Lam	fae7ea02cd	[account.cpp] gnc_accounts_and_all_descendants converted from scm ... much more efficient than guile algorithm, avoids numerous repeated GList<->SCM conversions, and traversals of account descendants.	4 years ago
Frank H. Ellenberger	2298590316	Merge PR #1309 into maint	4 years ago
Christopher Lam	736d223198	Merge branch 'maint-progress3' into maint #1312	4 years ago
Christopher Lam	0c4d438a0e	[kvp-frame.cpp] expose iterator, skip inexistent frame	4 years ago
Christopher Lam	aab33954e7	[gnc-numeric.cpp] Reduce logging level of gnc_numeric exception message ... Exceptions are expected in some use cases.	4 years ago
luz paz	8adedc2248	Fix various typos ... Found via `codespell -q 3 -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./borrowed,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,ba,cas,dragable,gae,iff,iif,mut,nd,numer,parm,parms,startd,stoll`	4 years ago
Christopher Lam	6a668df168	[qofutil.h] don't recurse includes	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	26b009c0f4	Bug 798500 - FTBFS (tests failure) on armhf ... Ensure the transition_times are correctly aligned for their sizes before attempting to copy them into the transitions vector.	4 years ago
Christopher Lam	ee8729dfb6	[account.cpp] char* must be freed	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	03cbbd1cd1	Merge branch 'maint'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
Christopher Lam	5388cc8e2c	[kvp-frame.cpp] minor speedups ... reserve vector, cache iterator from m_valuemap.find for reuse immediately afterwards.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Christopher Lam	0052e3e483	[gnc-pricedb] add user:stock-transaction price source	4 years ago
John Ralls	c1001e6641	Better wording for tax table changed info message.	4 years ago
John Ralls	d841b322d0	Merge Frank Ellenberger's 'Bug684507' into maint.	4 years ago
John Ralls	ce2b89fd8c	[business]Add diagnostic messages to GncEntry and GncInvoice.	4 years ago
John Ralls	9ad24321b4	Remove investment-type namespaces. ... Leave it to users to categorize their non-currency commodities. In the QIF importer default non-classifiable commodities to GNC_COMMODITY_NS_NONCURRENCY.	4 years ago
Frank H. Ellenberger	c7f842c081	Bug 684507 - commodity namespace should be localized	4 years ago
Christopher Lam	bd4a457040	Merge branch 'maint-lightning-budget' into maint #1248	4 years ago
Christopher Lam	a47413860a	Factor out GValue access for setters and getters	4 years ago
Christopher Lam	8f845df934	Factor out make_period_[data|note]_path	4 years ago
Christopher Lam	919f392c7a	Use kvp C++ interface rather than GValue	4 years ago
Christopher Lam	6c4c2512db	Use C++ STL instead of GLib	4 years ago
Christopher Lam	9088acabd8	[gnc-budget.cpp] convert to c++	4 years ago
Christopher Lam	c1c198c9ff	Merge branch 'maint'	4 years ago
Christopher Lam	f0de54ac7a	Merge branch 'maint-798406' into maint #1240	4 years ago
Christopher Lam	8bc080b96d	[gnc-budget] store budget kvp data onto memory upon first call. ... then each getter will retrieve from memory rather than backend's kvp.	4 years ago
Christopher Lam	ef8d812d3f	[utest-Budget] test data retention when modifying budget num_periods	4 years ago
Christopher Lam	87b0a41e9b	[Split.c] return price==0 instead of 1, if !split, or amt==0	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" ... The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
Christopher Lam	f7ee644695	Amendment to 73822f97a [1/2] use heuristics to scrub budget signs ... Testing income<0 to conclude "none reversal" is likely a more sound strategy than testing liability>0.	4 years ago
Christopher Lam	c3eaff9bb2	[account.cpp] gnc_account_and_descendants_empty: don't copy children	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	5c7967c4a5	Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint." ... This reverts commit 17a3f7fef2, reversing changes made to b8458d0732.	4 years ago
John Ralls	ae7eaad018	Merge Chris Good's 'maintBug797678OfxAppend' into maint.	4 years ago
John Ralls	17a3f7fef2	Merge Stefan Bayer's 'SepaInternalTransfer' into maint.	4 years ago
Christopher Lam	73822f97a9	[1/2][Scrubbudget.c] use heuristics to scrub budget signs ... If book has budgets, and GNC_FEATURE_BUDGET_UNREVERSED isn't set, check and fix budget amount signs. Previously budgets were created with assumption that sign reversal was set to credit amounts. A heuristic approach is used: - if budgeted expense is negative, conclude sign reversal is "Income and Expense" - if budgeted liability is positive, conclude sign reversal is "None" - otherwise conclude sign reversal is "Credit Accounts" The above is calibrated to (hopefully) prefer sign reversal of Credit Accounts.	4 years ago
Christopher Lam	6070aecd69	[2/3][gnc-features.c] add & expose gnc_features_set_unused ... same as gnc_features_set_used but removes feature	4 years ago
Christopher Lam	5dab33694f	[1/3][qofbook.cpp] add & expose qof_book_unset_feature ... same as qof_book_set_feature but removes feature item	4 years ago
Christopher Lam	88ecf8dd17	Merge branch 'maint'	4 years ago
John Ralls	d1fe359e47	gnc_numeric_to_decimal: Change can't round warning to a debug. ... Routinely used as a check so a warning isn't appropriate.	5 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	ff04ad3785	Bug 798346 - crashes when running check & repair ... Don't scrub trading accounts for imbalances, see the comment in the commit for why.	5 years ago
Christopher Lam	984d816a58	Merge branch 'maint'	5 years ago
Christopher Lam	79d8ef0299	Revert b5f5129f7 using gnc_list_length_cmp	5 years ago
Christopher Lam	b5f5129f7d	Shortcut g_list_length comparison against small numbers ... It's more efficient to test node && node->next etc when testing GList length against small numbers	5 years ago
goodvibes2	8ad29feaba	Bug797678 OFX import should append not replace, existing Notes & Desc ... Add an "Append" checkbox to the bottom of the "Generic import transaction matcher" window to the left of the "Reconcile after match" checkbox. When ticked, this causes the imported Description/Notes to be appended to the matched transaction Description/Notes respectively. The selected ticked/unticked state of the "Append" checkbox is saved in a key value pair for the import account, so the next import for that account will automatically default it to the saved state. As these mods are limited to the code for the matcher window, this should work for all the imports that use it - ie ofx & csv file imports (both tested) & aqbanking (cannot test).	5 years ago
John Ralls	5a8cbf4193	Bug 798325 - New Currency for Venezuela (VED) ... Add latest Venezuelan revaluation of the Bolivar Soberano, following the ISO notation replacing VES (which the Venezualan central bank is keeping) with VED and the exchange code (ditto) with 926.	5 years ago
Christopher Lam	f40dbb8c28	Avoid unnecessary g_list_length in equality functions	5 years ago
Christopher Lam	f0970c8eb4	[gnc-features] don't repeatedly g_strconcat gchars*	5 years ago
Christopher Lam	31a0300abe	[Recurrence.c] avoid repeated calls to g_list_length	5 years ago
Christopher Lam	b480600dc8	[gnc-pricedb] gnc_price_list_equal: avoid 4 g_list_length calls	5 years ago
Christopher Lam	23e528f51a	[utest-gnc-pricedb] add tests for gnc_price_list_equal ... Also need to change PWARN which causes test failure, to PINFO	5 years ago
John Ralls	2f4438ab28	Bug 798335 - No longer possible to change trading account ... Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so.	5 years ago
Christopher Lam	9eaa3eb23a	Merge branch 'maint'	5 years ago
John Ralls	7c9c2eba3c	Bug 798320 - Error message indicating a crash of GNUcash when closing... ... application - MacOS 10.15.7 (19H1419) Destruction order problem: The SX template accounts can't be destroyed until after the template splts and transactions are. Register them before the transactions and splits, as destruction occurs in reverse order of registration.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason ... tests in 128c8d6f88	5 years ago
Christopher Lam	128c8d6f88	[utest-Transaction] add tests for xaccTransGetReadOnly	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions ... GValue in DxaccAccount[Set|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in 4309469730.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset ... already have comprehensive tests in 15852031d	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry ... Have comprehensive tests in a5d101d1b	5 years ago
Christopher Lam	4309469730	[utest-Account] test old dxaccAccount* functions ... dxaccAccountGetPriceSrc and dxaccAccountGetQuoteTZ. DxaccAccountSetCurrency remains untested - unsure how to retrieve an ISO4217 currency to use as parameter.	5 years ago
Christopher Lam	a5d101d1be	[utest-Account] test gnc_account_get_map_entry	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" ... This reverts commit d290c3c45d. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path ... exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago