Fix use-after-free crash in utest-Invoice.

4 years ago · 9f6d495ca1
parent e9df8d41d2
commit 9f6d495ca1
1 changed files with 5 additions and 4 deletions
--- a/libgnucash/engine/test/utest-Invoice.c
+++ b/libgnucash/engine/test/utest-Invoice.c
@ -86,6 +86,11 @@ teardown( Fixture *fixture, gconstpointer pData )
    gncInvoiceBeginEdit(fixture->invoice);
    gncInvoiceDestroy(fixture->invoice);

+    xaccAccountBeginEdit(fixture->account);
+    xaccAccountDestroy(fixture->account);
+    xaccAccountBeginEdit(fixture->account2);
+    xaccAccountDestroy(fixture->account2);
+
    if (data->is_cust_doc)
    {
        gncCustomerBeginEdit(fixture->customer);
@ -97,10 +102,6 @@ teardown( Fixture *fixture, gconstpointer pData )
        gncVendorDestroy(fixture->vendor);
    }

-    xaccAccountBeginEdit(fixture->account);
-    xaccAccountDestroy(fixture->account);
-    xaccAccountBeginEdit(fixture->account2);
-    xaccAccountDestroy(fixture->account2);
    gnc_commodity_destroy(fixture->commodity);

    qof_book_destroy( fixture->book );