2443 Commits (341f2102635c73858d2abba05ab0e0990c47ecaf)

Author	SHA1	Message	Date
Richard Cohen	3957272ef0	Fix some typos in comments	3 years ago
John Ralls	9b95419608	Fix glib include.	3 years ago
John Ralls	d696f0cfcb	Bug 798885 - Accented character in folder name on Account Export (bis) ... Pass a boost::filesystem's c_str() rv to the ofstream constructor to keep libstdc++ from transcoding it back to UTF8 and creating a broken name or failing to match the directory name. Implemented in gnc-filepath-utils to avoid spreading the boost::filesystem dependency throughout the code base. See https://github.com/boostorg/filesystem/issues/181 for why other approaches don't work.	3 years ago
John Ralls	bb423e4484	Merge CrfzdPQM6's 'b_betterCurrencyBudgetReporting' into stable.	3 years ago
Daniel Johnson	04b0317119	Demonstrate fx handling in budget report	3 years ago
John Ralls	df878c6a3d	Merge Maarten Bosmans's 'memleak-fixes' into stable.	3 years ago
Maarten Bosmans	71802b5627	[test] Fix memory leak in test-gnc-quotes ... When the commodity table is registered, the current book will get a default table assigned. When later setting the table explicitly using qof_book_set_data() the exisiting table gets overwritten and is thus leaked. There is no way of removing or freeing a currency table from a book, so the best we can do here is to set our own table on the book before calling gnc_commodity_table_register().	3 years ago
Maarten Bosmans	6be682b645	Store allocated temporaries in a variable so they can be freed ... If a function that returns an allocated pointer is passed directly into something that does not take ownership of the pointer, the allocation is leaked. This can be fixed by assigning the pointer to a new variable and freeing it after operation on the memory.	3 years ago
Christopher Lam	1a7fcb69c0	[gnc-features.cpp] remove_if requires <algorithm>	3 years ago
John Ralls	8481f062d4	Create obsolete features list with first member book_currency. ... Obsolete features set in the book will be removed from the book's KVP and ignored. Note the warning in the comment!	3 years ago
John Ralls	0d175dce12	Refactor gnc-features. ... * type aliases to gnc-features.h * string_views to avoid copying (all of the strings are static) * qof_book_get_unknown_features returns a FeatureSet	3 years ago
John Ralls	e8c80f2f5c	Restore existence, but not implementation, of GNC_FEATURE_BOOK_CURRENCY. ... At least one user has managed to get it set on their book so even though it was supposed to be unimplemented it got through somehow. Restoring it allows books with it set to load.	3 years ago
John Ralls	9ff2362bb0	Merge Muhammadyusuf Kurbanov's 'uz-currency-fix' into stable.	3 years ago
Robert Fewell	fb58959f9a	Bug 798885 - Accented character in folder name on Account Export ... Changed export_coa to use g_fopen instead of fopen	3 years ago
Muhammadyusuf	02e24ccf96	edit: use &apos; instead of ` symbol	3 years ago
Muhammadyusuf	dca596ac84	edit: Fix local symbol of uzbek sum	3 years ago
Christopher Lam	e26c3d6cf4	[gnc-ui-balances.c] gnc_ui_account_get_balance_limit_explanation ... returns a char* explanation, or NULL	3 years ago
Vincent Dawans	761d7f29a5	Bug 765920 - Running balance not accurate when sorted different ways ... - Renamed option to "Account Balance" to avoid confusion with running total. - Added helper function to ensure running balance and balance forward are only shown when transaction are grouped by account and sorted as in register. In that case column heading remains "Running Balance" and balance forward is shown. Otherwwise column heading is renamed "Account Balance" and balance forward is not shown. - Also added missing code for Common Currency conversion.	3 years ago
John Ralls	4a5b897d89	Bug 798863 - Crash on clicking Settings button second time ... Ensure that dialog resources stored in options are freed when the dialog is destroyed. The crash happened when a new dialog replaced the old one on the options and the old one's destructors tried to access a dangling reference to a GtkWidget.	3 years ago
John Ralls	f4f481fe38	Bug 798812 - crashes after I open a customer report and select… ... Edit/Report Options As a result of auto instead of auto& in a std::visit call which resulted in a temporary option whose GncOwner* was destroyed before we could use it.	3 years ago
Robert Fewell	0d84506a5e	Bug 798851 - Account Balance 'include subaccounts' not saved ... The defaults for the account were removed by mistake in a previous commit, added them back.	3 years ago
John Ralls	2f471e65a7	Bug 798802 - Online Price quote - Stocks not working GNU 5.0 Windows Bis ... The previous change of the delimiter between namespace and symbol is needed in both overloads of GncQuoteImpl::query_fq. Also log the query json string to ease future troubleshooting.	3 years ago
Maarten Bosmans	0d86be6d2a	[test] Properly destroy resources on end of tests ... This fixes memory leaks that are only present in testing code. Not very useful on itself, but it does make it easier to fix memory leaks and other AddressSanitizer problems in actual gnucash code later.	3 years ago
Maarten Bosmans	ed3fe00880	[test] Use test fixture to initialize and destroy resources	3 years ago
Maarten Bosmans	35aeed45ec	[engine] Remove two replace functions from KvpValue ... These were not used outside a test. And that test was not leak free, as a result of the functions not doing what they are supposed to do when the current value is not of the type that is expected. (NULL is returned, but the value is not replaced)	3 years ago
Maarten Bosmans	bd94965d9b	[backend/xml] Remove unused string copy	3 years ago
Richard Cohen	6ba5bb326a	Fix dereference of expired temporaries. ... Reported by clang 15.0.7, which will be in Ubuntu 23.04, -Wdangling-gsl	3 years ago
Richard Cohen	9fa2a48fe1	Fix build on gcc-8 & 9. ... See https://lists.gnucash.org/pipermail/gnucash-devel/2023-March/046617.html	3 years ago
John Ralls	0d598d51ed	Fix Finance::Quote use on Win32. ... By dealing with Win32 \r\n newlines on return from finance-quote-wrapper.	3 years ago
John Ralls	a587dfff2c	Bug 798802 - Online Price quote - Stocks not working GNU 5.0 Windows ... Change the property-tree path delimiter for constructing paths from '.' that's commonly used in stock symbols, to '|' that isn't.	3 years ago
Christopher Lam	bdf79f7721	Merge branch 'master-fileopen-filter' into stable #1576	3 years ago
John Ralls	89f41a305c	Merge new potfile reflecting string changes.	3 years ago
John Ralls	576fc9b52c	Fix quotes on Windows. ... Boost process wchar_t conversion chokes if it's fed an empty string. This would happen when the user had no alphavantage key. Separate the process invocation to not present the empty value to boost process.	3 years ago
John Ralls	90e1e2d1c3	Merge Bob Fewell's 'bug798558' into master.	3 years ago
John Ralls	0c3e85404d	Avoid crash from trying to free an unallocated char*.	3 years ago
Christopher Lam	97f0653238	[gnc-quotes] g_free a char* from gnc_prefs_get_string ... ultimately gets char* from g_settings_get_string and must be freed	3 years ago
Robert Fewell	a576dd87a4	Bug798558 - Irregular line spacing in Account Tree View ... When securities are in the list, the rows look twice as high as though there is a linefeed at the end. This is partly due to commit for bug 797501 which worked at the time but a change in pango 50.4 to do with wrapping has highlighted this bug. To fix this only wrap currencies with ltr bidi isolate characters in gnc_print_amount_with_bidi_ltr_isolate	3 years ago
John Ralls	00c560d8f5	Move operator==(const GncGUID&, const GncGUID&) to guid.[ch]pp.	3 years ago
John Ralls	352ab8a0e5	Merge Richard Cohen's 'minor-options-fixes' into master.	3 years ago
John Ralls	d192be5307	Merge Richard Cohen's 'cleanup-cflags-deprecated' into master.	3 years ago
Richard Cohen	24f52d9b17	Remove incorrect operator!= for GncItem ... It's better to use the default std::pair implementation - spotted by clang-tidy bugprone-suspicious-string-compare - will always return false, because type is the same Also, - remove redundant "using GncItem ..."	3 years ago
Richard Cohen	b5f3f99035	Fix incorrect use of remove_if() ... - spotted by clang-tidy bugprone - probably no visible effects because of uniqueness, and other checks libgnucash/engine/gnc-optiondb.cpp:149:5: warning: this call will remove at most one item even when multiple items should be removed [bugprone-inaccurate-erase] m_options.erase(std::remove_if(m_options.begin(), m_options.end(), ^ libgnucash/engine/gnc-optiondb.cpp:358:5: warning: the value returned by this function should be used [bugprone-unused-return-value] std::remove_if(m_callbacks.begin(), m_callbacks.end(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libgnucash/engine/gnc-optiondb.cpp:358:5: note: cast the expression to void to silence this warning	3 years ago
John Ralls	b4b8431984	Bug 798778 - GnuCashquits abruptly when attempting to edit options… ... for certain reports. Those reports being ones using complex options, apparently because the callbacks weren't protected from Guile's garbage collector. So replace the anyway ugly hack of a void* with a std::any wrapping a class holding a std::unique_ptr with a custom deleter. The constructor calls scm_gc_protect_object on the SCM containing the callback and the custom deleter calls scm_gc_unprotect_object. The copy constructor, required for std::any, makes a new std::unique_ptr and calls scm_gc_protect_object again ensuring that the protect and unprotect calls are symmetrical. Meanwhile std::any hides the Guile dependency from all the classes that don't need to know about it. The only ugliness is that there's no good place to put a common implementation of SCNCallbackWrapper so it's repeated in gnc-optiondb.i and dialog-options.cpp.	3 years ago
Christopher Lam	dd0d65d861	[1/2] [gnc-filepath-utils.cpp] gnc_filename_is_backup|datafile ... uses std::regex to test filename	3 years ago
Richard Cohen	30586ac3e6	Push -Wno-error=deprecated-declarations from C*_FLAGS down to the target	3 years ago
Geert Janssens	1f0a69a804	Properly parse plus signs while importing numbers ... Silly copy/paste error.	3 years ago
John Ralls	a44b3664e2	[c++options] Implement GncOptionGncOwnerValue class. ... GncOwners aren't QofInstances and have limited lifetimes so an option must hold its own, wrapped in std::unique_ptr for memory management.	3 years ago
John Ralls	8db8105850	[c++options] Warn when an option variant type's set_value isn't found.	3 years ago
John Ralls	83829e6513	Merge branch 'maint'	3 years ago
John Ralls	1020bde89c	Fix crashes in test-engine on Arch Linux. ... Root cause is mutating a list while it's iterating. We're able to protect it in two cases, have to copy it in xaccTransScrubGainsDate.	3 years ago
Geert Janssens	d75ab275f1	Eliminate gnc-csv-account-map.[ch] ... The code is was only used by the csv import assistant and forced gtk as a dependency on gnc-imp-props-tx Part has been moved to Account, other bits have been moved to the importer code where they were used.	3 years ago
Geert Janssens	13ec4bb594	xaccParseAmount... - some code cleanups ... - declare at first use - compact tests - reduce use of {}	3 years ago
Geert Janssens	8010d9646c	Restore proper indentation ... It got mixed up while refactoring the various xaccParseAmountXYZ functions	3 years ago
John Ralls	07d8ebd90c	Add JSON::Parse to gnc-fq-update. ... Required by finance-quote-wrapper to interpret quoter output.	3 years ago
Richard Cohen	329a2f7d42	Guard against some possible null pointer dereferences ... Found by gcc 12 when compiling with "-O2 -Wnull-dereference"	3 years ago
Richard Cohen	3a7464a312	Remove redundant uses of cmake -E env ... - In GncAddTest, set_tests_properties() is already setting the env - In the other uses, there is no change to the environment	3 years ago
John Ralls	cdb674ebf1	[c++options]Really fix the gnc_option_db_lookup_string_value leak ... By deleting the function and using GncOptionDbImpl::lookup_string_option directly. It returns a string that we don't have to worry about memory-managing. Also create a new GncOptionDbImpl::set_string_option to replace gnc_option_db_set_string_value.	3 years ago
John Ralls	92071e8844	[c++options] Fix leak.	3 years ago
John Ralls	f735c64cac	Merge Richard Cohen's 'extern-c-part2' into master.	3 years ago
Richard Cohen	7b47c07f8e	Don't use extern "C" around #includes ... Some I missed the first time. Some are new.	3 years ago
Frank H. Ellenberger	bdb12fd94f	I18N: Change TaxTable to "Tax Table" for consistency	3 years ago
John Ralls	bbfa378783	Don't crash and do pass tests.	3 years ago
John Ralls	af02dae286	Fixups for merging into master instead of maint.	3 years ago
John Ralls	1eecb9f5c0	[c++ options] Fix locale dependency in test-gnc-option-scheme-output. ... Created by using std::to_string() in GncOptionRangeValue::serialize. It wraps sprintf that reads the locale. Use ostringstream instead.	3 years ago
Christopher Lam	76014f18a0	[account.cpp] don't cache char* [fails]	3 years ago
Christopher Lam	3d381eb6fd	[gnc-lot] don't cache char*	3 years ago
Christopher Lam	50f998fad8	[gncInvoice] don't cache char*	3 years ago
Christopher Lam	c9dc71978b	[gnc-commodity] don't cache char*	3 years ago
Christopher Lam	57fcaabd8f	[Split.c] don't cache char*	3 years ago
Richard Cohen	be41bde58a	Add missing MAKE_LINKS, and the local scm directory to %load-path ... Before this change, "make check" would fail after rm -rf ${build}/share/guile/site/*/gnucash/	3 years ago
John Ralls	675d894128	Merge Richard Cohen's 'cleanup-options' into master.	3 years ago
John Ralls	ca73b00039	Merge Richard Cohen's 'cleanup-boost' into master.	3 years ago
John Ralls	3d5e27982f	Merge branch 'maint'	3 years ago
John Ralls	7f0353adc4	Fix a missed g_value_dup_string and some no longer used variables.	3 years ago
John Ralls	8a7c539258	Bug 798748 - Transaction Notes field's value does not appear in... ... reverse transaction. The proximate cause was that xaccTransBeginEdit put the KVP cache variable of the new transaction in a state that prevented the value from being copied. More generally the KVP cache variables didn't handle any invalidating events. With the change to GValue usage in qof_instance_get_kvp it's now a simple memory dereference with no copying except for POD types so caching is no longer useful. This commit removes caching from Transaction, eliminating the notes problem.	3 years ago
John Ralls	ddc3f28899	[kvp] Use static strings and boxed in gvalue_from_kvp_value. ... Saves allocating and copying complex values, avoiding potential memory leaks.	3 years ago
Richard Cohen	9f06859390	Remove references to old boost versions ... we already require 1.67	3 years ago
Richard Cohen	3d995de2ab	Refactor: use default GncOptionValue copy constructor	3 years ago
Richard Cohen	1b0af4246a	Refactor: remove extra template parameter from member functions	3 years ago
Richard Cohen	87c52f53fa	Update some references to hello-world.scm	3 years ago
Richard Cohen	ec169e6e24	Fix some non-translatable typos	3 years ago
Christopher Lam	47b85d3b2f	[gnc-xml-backend.cpp] g_free char* from g_path_get_dirname	3 years ago
Christopher Lam	89e2bef427	Merge branch 'maint'	3 years ago
Christopher Lam	89e63ef672	Bug 798754 - Build fails with gcc 13 and glib > 2.76, ter	3 years ago
John Ralls	6ab7b16d62	[c++options] Restore the ability to set plot sizes in pixels. ... Enable and fix the previously untested GtkOptionGtkUIItem::PLOTSIZE. This has the potentially unfortunate side effect that integer range options are assumed to be plot sizes. That's correct for now, but if some report comes along that needs an integer range option for something else it will have to be differentiated.	3 years ago
Christopher Lam	abcce5000c	Bug 798754 - Build fails with gcc 13 and glib > 2.76, bis	3 years ago
Geert Janssens	26482f397b	Bug 797033 - The CSV Importer should not obey with the "automatic digital point" setting ... Expose variations of xaccParseAmount and xaccParseAmountExtended that will ignore the automatic decimal point user preference. This preference is really only useful for manual number entering in the register. The xaccParseAmountImport variant replaces xaccParseAmountPosSign which was used exclusively by the csv importers. Like xaccParseAmountPosSign, this replacement has the flag to ignore or parse the positive number indicator.	3 years ago
Frank H. Ellenberger	fcbda57a6b	Merge branch 'maint'	3 years ago
John Ralls	184669f517	Bug 798754 - Build fails with gcc 13 and glib > 2.76 ... GLib 2.76 introduced a no-discard warning on g_string_free if the second parameter is FALSE. This revealed a string leak and a correct usage that didn't use the return value.	3 years ago
Geert Janssens	549c93e005	Fix test for import-backend ... Another split function needed mocking	3 years ago
Richard Cohen	bddb4468fa	Import GLIB2 as a target, and use it to simplify the CMakeLists	3 years ago
Robert Fewell	ec7cc27d6d	Add tests for default invoice report book property	3 years ago
Robert Fewell	76f0e3a97e	Add some PWARN messages to the default invoice report ... book functions	3 years ago
Geert Janssens	8a23304283	GncGSettings - use bool as return type for static function	3 years ago
Geert Janssens	64329414e9	GncGSettings - cosmetic: NULL->nullptr	3 years ago
Geert Janssens	32ae47980c	GncGSettings - some minor cleanups ... - remove unused macros - avoid manual counters	3 years ago
Geert Janssens	03aff5642a	GncGSettings - rework signal handler manipulation ... Use ref-counting to manage GSettings object lifecycle Use g_signal_handler_handlers_[un]block_matched to block or unblock handlers rather than tracking them in our own hash table.	3 years ago
Geert Janssens	4761aa414c	GncGSettings - reduce code duplication ... Most getters and setters are identical with the exception of the actual function to call into GSettings. Extract boilerplate in two template functions and make all getters/setters wrappers of these two functions.	3 years ago
Geert Janssens	edab41f23a	GncGSettings - basic c++ cleanups ... - declare at first use - gboolean->bool (TRUE/true, FALSE/false)	3 years ago
Robert Fewell	a1d17518a8	Add a function to dump the schema entries when in debug ... mode.	3 years ago
Robert Fewell	2306ef8ca6	On a new install, the gnc_gsettings_version_upgrade ... would not run When doing a new install, set the GNC_PREF_VERSION to the current version.	3 years ago
Robert Fewell	57f874bd3f	Change the behaviour of the gseettings migration ... function In the pref_transformations.xml file, when the release version is greater than the current GnuCash version, do not process those changes.	3 years ago
Robert Fewell	ac0532bf5c	Change the alignment of a function in gnc_gsettings.cpp	3 years ago
Robert Fewell	308c609904	Fix comment typo in gnc-gsettings.cpp	3 years ago
Geert Janssens	286e1afa41	Bug 798749 - Fails to read gsettings on startup ... Only cache GSettings objects we need to keep track of callback functions. This means a bit more overhead per GSettings interaction, but as typical interactions are only a few objects at once at best, this overhead is unnoticeable.	3 years ago
Richard Cohen	9c6ad222a9	[-Wunused-function] - remove	3 years ago
Richard Cohen	4eb022c7a2	[-Wunused-variable] - remove	3 years ago
Richard Cohen	8a20bcadb0	[-Wunused-variable] - remove unused translatable string	3 years ago
Richard Cohen	0dd406de10	[-Wunused-lambda-capture] (clang) - remove	3 years ago
Richard Cohen	0f3813e0fd	[-Wunused-private-field] (clang) - remove ... In file included from gnucash/gnome-utils/dialog-options.cpp:34: gnucash/gnome-utils/dialog-options.hpp:55:10: warning: private field 'toplevel' is not used [-Wunused-private-field] bool toplevel; ^ In file included from gnucash/import-export/csv-imp/gnc-imp-props-price.cpp:42: gnucash/import-export/csv-imp/gnc-imp-props-price.hpp:113:10: warning: private field 'created' is not used [-Wunused-private-field] bool created = false; ^ libgnucash/backend/dbi/gnc-dbisqlconnection.cpp:53:29: warning: private field 'm_conn' is not used [-Wunused-private-field] const GncSqlConnection* m_conn = nullptr; ^ libgnucash/backend/sql/test/utest-gnc-backend-sql.cpp:81:33: warning: private field 'm_conn' is not used [-Wunused-private-field] const GncMockSqlConnection* m_conn; ^	3 years ago
Richard Cohen	d4dfe4e279	[-Wunused-local-typedef] - remove ... libgnucash/engine/test/utest-Account.cpp:2414:11: warning: typedef ‘using AcctTypeType = struct std::underlying_type<GNCAccountType>’ locally defined but not used [-Wunused-local-typedefs] 2414 | using AcctTypeType = std::underlying_type<GNCAccountType>; | ^~~~~~~~~~~~	3 years ago
Richard Cohen	0798bce2a6	[-Wunused-value] - remove ... borrowed/jenny/jenny.c: In function ‘next_builder’: borrowed/jenny/jenny.c:1164:5: warning: statement with no effect [-Wunused-value] 1164 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c:1172:5: warning: statement with no effect [-Wunused-value] 1172 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c: In function ‘confirm’: borrowed/jenny/jenny.c:1797:7: warning: statement with no effect [-Wunused-value] 1797 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c:1805:7: warning: statement with no effect [-Wunused-value] 1805 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ libgnucash/backend/xml/io-gncxml-v2.cpp: In function ‘gboolean qof_session_load_from_xml_file_v2_full(GncXmlBackend*, QofBook*, sixtp_push_handler, gpointer, QofBookFileType)’: libgnucash/backend/xml/io-gncxml-v2.cpp:806:40: warning: value computed is not used [-Wunused-value] 806 | g_thread_join (thread) != nullptr; | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp: In function ‘void xaccFreeAccount(Account*)’: libgnucash/engine/Account.cpp:1428:17: warning: statement has no effect [-Wunused-value] 1428 | priv->color == nullptr; | ~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1429:22: warning: statement has no effect [-Wunused-value] 1429 | priv->sort_order == nullptr; | ~~~~~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1430:17: warning: statement has no effect [-Wunused-value] 1430 | priv->notes == nullptr; | ~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1431:18: warning: statement has no effect [-Wunused-value] 1431 | priv->filter == nullptr; | ~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/gnc-int128.cpp: In function ‘void decimal_from_binary(uint64_t*, uint64_t, uint64_t)’: libgnucash/engine/gnc-int128.cpp:898:36: warning: right operand of comma operator has no effect [-Wunused-value] 898 | d[3] = (hi >> 32) & bin_mask, 0; | ^	3 years ago
Richard Cohen	bd8e81f35c	Move an unused variable into an #ifdef where it is used	3 years ago
Richard Cohen	1c6679720b	Use some unused variables	3 years ago
Richard Cohen	78ec20515b	Remove some unused variables - and the initialization ... - checked that any side effects were irrelevant	3 years ago
Richard Cohen	c819b03a17	Remove some unused variables - leave the side effect	3 years ago
Richard Cohen	ea2d3be217	Remove some unused variables with obviously no side effects	3 years ago
Richard Cohen	4e25bbfc43	Mark some QofLogModules as potentially unused ... - __attribute__((unused)) for C - [[maybe_unused]] for cpp	3 years ago
Robert Fewell	45a07463fb	Change max timeout to 20 seconds for default invoice report	3 years ago
Christopher Lam	85c2491664	Merge branch 'maint'	3 years ago
Geert Janssens	60209a766f	Merge branch 'csv_import'	3 years ago
Geert Janssens	2d8bb6f62f	Bug 796955 - Import CSV - Single-line two-currency transactions can't be imported ... Behaviour is as follows: If single line provides a price And at some point in the import process we get into a situation where the base account and transfer account have a different commodity Then transfer_acct amount = base_acct amount * price If on the other hand base_acct and transfer_acct turn out to have the same commodity, price is ignored.	3 years ago
Geert Janssens	99506d331a	Reduce GncImportMatchMap to just the account ... There is no added value in storing the book and account together The book is easily retrieved from the account (as was illustrated in the gnc_account_imap_new function). I looked through the commit history to understand why this struct was originally created and a long time ago it also had a reference to a kvp frame.	3 years ago
Geert Janssens	51706f289c	Minor corrections in comments	3 years ago
John Ralls	7bb14b9caa	Merge Richard Cohen's 'use-reference-for-loop' into master	3 years ago
Robert Fewell	07f3f536cc	Allow to select saved report on print invoice button ... This change was inspired by mildred's #PR1247 and uses the new GncReportCombo to allow selection of 'Saved Invoice reports' when the invoice print button is used or when printing multiple invoices. This change presents a dialog with the default for the report combo set to the properties setting. This dialog has a timeout which is adjustable under properties and will stop if a key is pressed or combo popped so that a different report template can be selected and used. There is also an 'OK' button that stops the time out and prints and a 'Cancel' button which cancels the print.	3 years ago
Robert Fewell	019214f1c2	Bug753307 - Custom Report be selectable as default Report for Printing ... This commit changes the preference in Business->'Report for Printing' to be saved as a book property and allow the selection of any Invoice Report to be used as the default.	3 years ago
Richard Cohen	d8f45f2443	Use const references for for-loops to avoid unnecessary copies ... Found by clazy - clazy-range-loop-reference	3 years ago
John Ralls	ce3447e6ea	Bug 798740 - Build fails with gcc 13 ... Protect against passing an lseek failure rv to read().	3 years ago
Christopher Lam	119356752f	Merge branch 'maint'	3 years ago
Geert Janssens	894f8241e1	Revisit invoice payment in multi-currency context ... - Show proper amount in dialog when applying or editing an existing transaction as payment - Be more careful not to waste the existing payment split - If the user changed the payment amount while starting from an existing transaction unreconcile the changed payment split - Avoid needlessly changing transaction currency (only do so if the user chose a new transfer account and the old currency is neither the new transfer account's currency nor the post account's currency)	3 years ago
John Ralls	44f4b55927	Merge Richard Cohen's 'fix-memleaks' into master.	3 years ago
Richard Cohen	846e75146a	Fix some typos so that the correct tests are run ... - test_gnc_txn_to_float_txn_cut_semantics - test_dbi_business_store_and_reload	3 years ago
Richard Cohen	a2ffc7fe75	Fix memory leak in binreloc function _br_find_exe() ... Ironically, it seems to be in a code path that is only followed when using valgrind	3 years ago
luzpaz	67ab9e90d2	Fix some typos	3 years ago
Christopher Lam	17820ec261	Merge branch 'maint'	3 years ago
John Ralls	f4c6d65395	Merge Bob Fewell's 'nofree' into maint.	3 years ago
John Ralls	f6919e60a7	Merge Richard Cohen's 'cleanup' into master.	3 years ago
John Ralls	46f9fb01c9	Simplify gnc_commodity equality and compare functions. ... gnc_commodity_compare is used for sorting and so needs to have a less-than return value. The only place it's used presents nothing to the UI; a GncGUID ordering is fast and stable. GnuCash allows only one commodity per book for any namespace/mnemonic pair, so the exhaustive string comparisons are superflous. While the current engine design allows only one instance of any object, meaning that a pointer comparison is sufficient to determine equality, that may not be true in the future, but the GncGUID is guaranteed to sufficiently identify a single commodity. Note that gnc_commodity_equiv is used to enforce that single-commodity rule and so cannot use GncGUID comparison.	3 years ago
Richard Cohen	6927535a0a	Remove unused test function get_object_is_initialized in qofobject.cpp	3 years ago
Richard Cohen	925fcbc3fd	Remove unused gnc-jalali.{c,h}	3 years ago
Richard Cohen	e83c91050c	Remove unneeded dummy.cpp	3 years ago
Richard Cohen	d6ac56ce5f	Re-enable -Waddress - gncInvoiceLookup etc. are now inline functions, not macros ... - Remove outdated comments	3 years ago
Richard Cohen	3360a6d13b	Remove extra semicolons ... Courtesy of gcc -pedantic	3 years ago
John Ralls	046e4a156e	Silence Clang deprecation warnings about sprintf.	3 years ago
John Ralls	dd2497416c	Merge Richard Cohen's 'internal-extern-c' into master.	3 years ago
John Ralls	60c06debce	[c++options] Don't crash when find_option returns nullopt.	3 years ago
Richard Cohen	1cec0cb3f3	Use internal extern "C" { ... } for C++ ... - removes warnings compiling swig engine ... [ 10%] Generating swig-engine.cpp .../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored), .../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'. .../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".	3 years ago
Richard Cohen	19bbde7000	Fix some typos	3 years ago
John Ralls	432f2d4bb8	Merge Richard Cohen's suppress-boost-warning into master.	3 years ago
John Ralls	9a1a90d8d0	Merge branch 'maint'	3 years ago
richardcohen	f3cc223f5f	Fix some bad code formatting	3 years ago
richardcohen	8044f79f75	Silence the boost (<1.76) warning message ... from .../gnucash-4.8/libgnucash/app-utils/gnc-quotes.cpp:33: /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’ The issue was fixed in boost 1.76, but, e.g ubuntu 22.04 has boost 1.74	3 years ago
Christopher Lam	fd007a0af1	Merge branch 'maint'	3 years ago
Robert Fewell	6df866f876	Add tests for the reconcile account functions	3 years ago
Robert Fewell	fd37ee997d	Fix getting xaccAccountGetReconcilePostponeBalance ... Change the G_VALUE from a INT64 to BOXED.	3 years ago
John Ralls	fb9947b7b6	Rename GncDateTime's ymd to gnc_ymd to avoid a name conflict with Carbon.	3 years ago
John Ralls	fed4daf4e7	[c++ quotes] Make sure to include all of the required Boost libraries. ... Also Boost-iostreams needs winsock but doesn't tell Cmake, so explicitly add it to the link list.	3 years ago
Christopher Lam	c65b36490a	Merge branch 'master-progress'	3 years ago
Frank H. Ellenberger	506a1b3c5e	Merge branch 'maint'	3 years ago
Alex Aycinena	1085d8920b	Update Form/Schedule line references for 2022 for the US Income Tax Report	3 years ago
John Ralls	b922cfd78d	Bug 798679 - Unicode normalization should be used for comparison but not stored. ... Change to NFC normalization for all comparisons because the Unicode meaning of compatible might collide with the user's intent.	3 years ago
John Ralls	31d79e3004	Merge Bob Fewell's 'bug798673' into master.	3 years ago
John Ralls	5c17950a59	Merge Bob Fewell's 'mainwin2' into master.	3 years ago
Christopher Lam	259881f940	[gnc-optiondb] add some more renamed options ... following ab13b01f8c Replace ... with … in all translatable strings.	3 years ago
John Ralls	ab13b01f8c	Replace ... with … in all translatable strings. ... Also a few other places like translator comments and report options. Replaces https://github.com/Gnucash/gnucash/pull/1033.	3 years ago
Geert Janssens	734f90bd36	Replace string literal 'gnucash' with PROJECT_NAME parameter where it makes sense ... The idea behind this is to not assume the project is always built as "gnucash" exactly. One example where it can be useful to use a different project name would be when building multiple development versions of the project on the same system and don't want these different versions share the same settings in GSettings or the same stored passwords.	3 years ago
John Ralls	b8c0673526	Merge branch 'maint'	3 years ago
Robert Fewell	7536fcaf2f	Change the balance limit icon if both limits are zero ... When higher and lower limits are zero, when used for a a suspense account, change the icon to 'dialog-warning'. This type of use is to indicate that a non zero balance exists.	3 years ago
John Ralls	091d4aff22	Bug 798657 - Import Summary language is wrong ... Root cause is using boost::locale::translate because it ignores the LANGUAGES environment variable and doesn't support different values for LC_MESSAGES, LC_DATE, LC_MONETARY, and LC_NUMERIC. That makes it impossible to configure a user environment that presents translated strings in a different locale from the one applied to formatting dates and numbers. To correct this replace all use of boost::locale::translate with GNU gettext.	3 years ago
Robert Fewell	3be25ff0a9	Add some tests for the account functions	3 years ago
Robert Fewell	a15c6f81b3	Allow the balances of sub accounts to be used in limits	3 years ago
Robert Fewell	60ab654d2b	Add account balance test functions to gnc-ui-balance	3 years ago
John Ralls	73a134730f	Bug 798680 - Not able to match a reverse transaction of a... ... previously matched transaction. Cloned transactions and copied splits shouldn't keep the online-id slot.	3 years ago
John Ralls	b4bab92da2	Bug 798664 - Result of 'gnucash --nofile' is marked dirty ... Don't create a new book in the new-user dialog unless the user says to. Don't automatically create a new book when retrieving default commodities because the retrieve might be requested in a context like the Preferences dialog when there is no book. Some report tests relied on requesting the default commodity creating the book, so in those tests ensure that the book is created first.	3 years ago
John Ralls	fae5de80d3	Undo unintended change in Bug 798679 commit.	3 years ago
John Ralls	fd2761bd68	Bug 798679 - Fullwidth characters cannot be pasted as-is in register fields ... Control character check doesn't need normalization, the control character codepoints aren't graphic and so can't be composed nor have compatible equivalents.	3 years ago
Robert Fewell	518ecfe041	Add some functions that would allow adding a balance limit to accounts	3 years ago
Geert Janssens	98251d59a6	Bug 798672 - Preferences are not saved nor loaded, ERROR <GLib-GIO> g_settings_new_full: assertion 'schema != NULL' failed ... Apparently it was a failure on our side to properly look up requested gsettings schema.	3 years ago
Christopher Lam	bfc325f63c	Merge branch 'maint'	3 years ago
Marco Scardovi	6fe2028bca	Fix test ... Signed-off-by: Marco Scardovi <mscardovi@icloud.com>	3 years ago
Robert Fewell	59d95a4ce6	Bug 798545 - Crash when updating document link on vendor bill ... There were two issues here, the first one was that the copied doclink was pointing to the original doclink which lead to a double-free. The second is the setting of the doclink on the copied invoice needs to be done with gncInvoiceSetDocLink otherwise on closure the doclink value will disappear.	3 years ago
Christopher Lam	3d8a28898d	[gnc-budget] gnc_budget_get_account_period_note returns a const ... to harmonize with all other char getters	3 years ago
Christopher Lam	2ee0c98200	[gnc-budget] use operator[] instead of find() and insert() ... - avoid hashing Account* twice. one call to operator[] is sufficient. - don't need use std::move with better constructors - sanity check - can't have a budget with num_periods = 0 - remove unused headers	3 years ago
Christopher Lam	3e5fcc8709	Merge branch 'maint'	4 years ago
Robert Fewell	4f8643674b	Remove all references to GncDisplayItem	4 years ago
Robert Fewell	078d7875d3	Change all references to plugin_class->actionsb ... Change all references to plugin_class->actionsb and n_actionsb to plugin_class->actions and n_actions	4 years ago
Christopher Lam	6f80c548e6	[gtest-qofevent.cpp] comprehensive tests for qofevent	4 years ago
Christopher Lam	05ffd3d4eb	[budget-feature] move unset_feature call to gnc_budget_gui_delete_budget ... because gnc_budget_gui_delete_budget is a more general function to delete a budget.	4 years ago
Christopher Lam	b87aa004f9	[test-qofbook] add tests for unknown features ... tests that gnc_features_test_unknown returns a suitable error message	4 years ago
Robert Fewell	0f70143c55	Initial change to plugin source files	4 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	4 years ago
Christopher Lam	fc94b41c81	Merge branch 'maint'	4 years ago
Christopher Lam	4716af24e4	Merge branch 'maint'	4 years ago
Christopher Lam	ba44f720c1	Merge branch 'maint'	4 years ago
Christopher Lam	f2354d6b2a	[test-qofbook.c] add test for gnc_features_set_unused	4 years ago
Christopher Lam	1516bb18b0	[gnc-features.cpp] backport gnc_features_set_unused from master	4 years ago
Christopher Lam	a078921a33	[qofbook.cpp] backport qof_book_unset_feature from master	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
Christopher Lam	093aa81ed1	[qofbook.cpp] deprecate qof_book_get_features	4 years ago
Christopher Lam	8192deff37	[gnc-features.cpp] convert to cpp ... - don't need to create/destroy GHashTable for each feature query - plugs leak: g_hash_table_unref (features_used) not always called properly - to check 1 feature, don't need to traverse whole GHashTable	4 years ago
Christopher Lam	6f6d2fef48	[test-qofbook] basic features test ... sets a feature and tests it's set. it's impossible to design a book with unknown features using the API.	4 years ago
John Ralls	14a0ea4ed3	[price-quotes] Sort and format source list.	4 years ago
John Ralls	1a906b00aa	[price-quotes] Enable gnucash-cli to retrieve preferences on macOS. ... By embedding a minimal Info.plist with a bundle ID into the executable. This necessitated a change to binreloc because the unix-style install depended on there being a bundle ID only when the program was run from an application bundle.	4 years ago
John Ralls	2767587874	[price-quotes] Fix setting alphavantage API key.	4 years ago
John Ralls	939a77407c	Merge branch 'price-quotes-cpp'	4 years ago
John Ralls	7f2a09a69f	[price-quotes] Handle short error strings from finance-quote-wrapper. ... This keeps the translation work in GnuCash and improves the error signalling in gnc-quotes.	4 years ago
John Ralls	fe9b23ff2b	[price quotes] Pass short errors to gnc-quotes. ... And wordier but not translated messages when STDERR is a tty.	4 years ago
John Ralls	88d658fef0	[price-quotes] Date::Manip is no longer required.	4 years ago
John Ralls	50c72b4f88	[price-quotes] Remove m_ready and usable() from GncQuoteSource. ... GncQuoteSource ctor throws if something is wrong so usable is always true.	4 years ago
John Ralls	7d93774dd2	[price-quotes] Throw instead of returning if there aren't any commodities to quote. ... So that the user gets sees an error instead of silent failure.	4 years ago
John Ralls	81d4ea9550	[price-quotes] Remove F::Q version format check. ... We don't care what the version string looks like as long as there is one.	4 years ago
John Ralls	c78fe37ff7	[price-quotes] General typo fixes and code cleanup.	4 years ago
John Ralls	70c9d4c9e3	[price-quotes] Fix version retrieval. ... Plus there's no need for a "not found" version string because GncQuotes construction will throw if Finance::Quote isn't correctly installed. No object, nothing to call version() on.	4 years ago
John Ralls	97e730b8d8	[price-quotes] Reformat test quote response strings to one line per quote.	4 years ago
John Ralls	f24c2c8bdd	Instrument failure to set the account when creating a split.	4 years ago
Mike Alexander	3c306eae65	Merge branch 'maint'	4 years ago
Mike Alexander	2d3e80ea08	Compatibility with XCode's "new build system" ... With XCode 14 or newer CMake tries to use the "new build system" which has a requirement that if two targets depend on the same generated file one of them must depend on the other. This commit adds reduntant dependencies to satisfy this requirement.	4 years ago
John Ralls	c7d1b6ab26	Bug 798633 - 4.12 build failure on 32-bit Linux: "No code for module"	4 years ago
John Ralls	673a925554	[price-quotes] Remove superseded gnc-fq-dump and Quotes-example.pl	4 years ago
John Ralls	e817091de1	[price-quotes] Warn only once if the AlphaVantage Key isn't set. ... And check the environment if it's not in preferences.	4 years ago
John Ralls	d97ea77762	[price quotes] Add report member function to display quote information to stdout. ... Instead of creating price instances in the database.	4 years ago
John Ralls	6ffb0bb633	[price-quotes] Report quote fetch failures to the user.	4 years ago
John Ralls	4c47e91180	[price-quotes] Implement error codes for currency and quote failures.	4 years ago
John Ralls	6db7800ca5	[price-quotes] Doxygen docs.	4 years ago
John Ralls	29ce925646	[price-quotes] Test the other fetch overloads and quote values.	4 years ago
John Ralls	b5bc6463a3	[price-quotes] Rework date-time handling. ... A check of the F::Q modules found that the only ones that return a quote time return a bogus one and do so only to mollify GnuCash. Since there's no good way to determine the TZ of the exchange originating the quote there's no good way to decide if the quote is current or from a previous market session, so we just punt and use a time of 16:00 for all quotes.	4 years ago
John Ralls	19064093d2	[price-quotes] Remove m_comm_vec and m_fq_answer. ... Passing the intermediate values comm_vec and quote_str on the stack instead.	4 years ago
John Ralls	734fb6ce2a	[price-quotes] Switch error handling to exceptions. ... Allows for cleaner code with less state, less coupling of the GncQuotes class, and better transfer of error messages to client code. Also translates some error messages for presentation to users.	4 years ago
John Ralls	d307295076	[price-quotes] Paramaterize GncMockQuoteSource construction. ... So we can have different results passed back for different tests.	4 years ago
John Ralls	2b87066687	[price-quotes] Extract some static functions. ... To get GncQuoteImpl::parse_one_quote to a reasonable size.	4 years ago
John Ralls	a82c72cfb9	[price-quotes] Remove level of indirection when parsing quote data.	4 years ago
John Ralls	37dfab7f31	[price-quotes] Convert long quote parsing lambda to a regular function. ... To begin separating price parsing from inserting in the price db.	4 years ago
John Ralls	dd8316714b	[price-quotes] Extract function GncQuotesImpl::comm_vec_to_json_string.	4 years ago
John Ralls	e3ab384504	[price-quotes] Log messages instead of writing them to std::streams.	4 years ago
John Ralls	b8642e55d9	[price-quotes] Implement mock quote source. ... Note that because the non-default constructor exists only on GncQuotesImpl we must use that directly and violate the pimpl.	4 years ago
John Ralls	4dd3922871	[price-quotes] Make wiggle test conditional on F::Q being installed.	4 years ago
John Ralls	784aca5a4c	[price-quotes] Extract class GncQuoteSource. ... Provide a specialization GncFQQuoteSource and move the F::Q command construction and query functions to GncFQQuoteSource. This allows for dependency injection to provide testing that doesn't need F::Q to be installed.	4 years ago
John Ralls	e9577b7996	[price-quotes] Basic wiggle test.	4 years ago
Geert Janssens	277f299ad6	GncQuotes - cleanups ... - make more use of auto - mark user visible strings as translatable - return early on input errors - fix date conversion fallback to actually fall back to today	4 years ago
Geert Janssens	585de5d134	GncQuotes - break actual interaction with Finance::Quote out into a separate function query_fq ... That allows for later reuse and easier testing.	4 years ago
Geert Janssens	70ab8a8a46	GncQuotes - drop parameterized constructor ... The book parameter is only needed while fetching quotes. In case the user passes one or more commodities to process the book can be readily derived from the commodity/commodities. In the other case (fetch all quotes) the user now is required to pass a book to the call.	4 years ago
Geert Janssens	4c2863966b	GncQuotes - rename fetch_all to be an overload of fetch ... And add a third overload to fetch only a single quote	4 years ago
Geert Janssens	7765e13704	Bindings - move log wrappers into the swig interface files ... They are only used for guile (and possibly python, so there's no need to carry them around in core-utils.	4 years ago
Geert Janssens	e5c6f6026b	Remove support code that was only used by price-quotes.scm	4 years ago
Geert Janssens	e97fc3e408	Drop price-quotes.scm, gnc-fq-helper.in and gnc-fq-check.in - no longer used	4 years ago
Geert Janssens	bf357315fd	finance-quote-wrapper - implement check and fetch in one file via command line switches ... This obsoletes gnc-fq-check as the same function can now be performed with 'finance-quote-wrapper -v'	4 years ago
Geert Janssens	fbf9aecd25	Use GncQuotes in transfer dialog	4 years ago
Geert Janssens	a00bce168c	GncQuotes - cache default currency	4 years ago
Geert Janssens	fcbe6cf10c	Add code to parse json data returned by our F::Q wrapper ... This code will convert the json data into GncPrice objects and add them to the pricedb, effectively doing what price-quotes.scm does. A few notable remarks: - still requires plenty of cleaning up. This is the first proof of concept - like the original scm based code, this parser completely ignores timezone information. As it wasn't used before and nobody complained, it may not be that important. Or it can be implemented later. - price-quotes.scm would first check if a price already existed in the pricedb and try to update that one instead of adding one (only if the old price's type is inferior). However that is redundant as gnc_pricedb_add_price does the same check. So I have omitted this extra check from GncQuotes. - currency quotes can be inverted. I have slightly changed the way to handle this. The perl wrapper code will simply set an "inverted" flag in that case, but will otherwise not swap currency and commodity as it used to be the case. On parsing, the inversion flag will cause the GncNumeric that's parsed from the price to be inverted. As it's still a GncNumeric that shouldn't result in any loss of precision, while keeping prices in the db always in the default currency.	4 years ago
Geert Janssens	6ecc1ef73f	GncQuotes - switch to Pimpl idiom ... That allows the private implementation to pass a number of variables based on various boost libraries. It's better to not have them in the public interface to keep compilation times down.	4 years ago
Geert Janssens	65ae46426b	GncQuotes - add parameterized construction ... For all but the basic check a book is required. Might as well be able to pass it directly and store a reference to it. That will simplify member function declarations.	4 years ago
Geert Janssens	3685e5de73	Factor out the async call to perl ... This will allow us to reuse it for several F::Q commands, like check, fetch,...	4 years ago
Geert Janssens	6ce91d7f49	Drop the single quotes instance code for now ... I have been reading on singleton implementations and there appears to be a lot of pushback against those. We can revisit this if it turns out performance degrades significantly by running the F::Q check multiple times.	4 years ago
Geert Janssens	616a672d52	Rewrite boost::process call to properly capture both stdout and stderr ... The previous version of the code could only capture one but not both at the same time.	4 years ago
Geert Janssens	a6771754d5	GncQuotes - start implementation of fetch/fetch_all	4 years ago
Geert Janssens	f3fdc5de12	Rewrite gnc-fq-helper as finance-quote-wrapper ... This rewritten version takes JSON input and spits out JSON. Additionally inverted currency quotes will only be flagged. The old code also swapped currencies in the result. GncQuotes will be written towards these new implementation choices.	4 years ago
Geert Janssens	1d94887a0b	Rewrite gnc_commodity_table_get_quotable_commodities as gnc_quotes_get_quotable_commodities ... It only makes sense in that context.	4 years ago
Geert Janssens	466db526b2	Move source files for GncQuotes to app-utils ... It will depend on functions in that library. This can probably be fixed by cleaning up app-utils, but that's not the topic of this feature.	4 years ago
Geert Janssens	9d62755b4a	Make GncQuotes::check() a private function, returning nothing ... At the same time do an explicit reinstantiation of quotes_cached at first use to work around what seems to be a race condition between static instantiation and binreloc.	4 years ago
Geert Janssens	32df095d4f	Catch potential boost::process exceptions ... Could happen if the perl executable isn't found and perhaps also if there's a stream exception.	4 years ago
Geert Janssens	d79306f7db	Protect boost process output read loop from deadlock ... As per the boost::process tutorials	4 years ago
Geert Janssens	8b772384cd	Various performance fixes based on feedback ... - const correctnes - avoid unnecessary copying - avoid need to reverse GList	4 years ago
Geert Janssens	2f7ed7f25d	Initial version of libgnc-quotes ... This library intends to wrap Finance::Quote the way price-quotes.scm currently does. In this first commit the library replaces price-quotes.scm's library to install quote sources. In addition it exposes a new command line parameter in gnucash-cli to show which version of Finance::Quote is installed on the system (if any) and which quotes sources that verions exposes.	4 years ago
John Ralls	eb24099a91	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	23ca899a77	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	b0ae402c23	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	3c75d212ab	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	283a5b7ce9	Fix dist, files moved	4 years ago
John Ralls	8cb8f5067d	Remove non-ISO4217 currency codes from gnc-euro table. ... They're not reachable because they don't have commodities associated with them.	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	3949821da6	Merge branch 'maint'	4 years ago
John Ralls	2505955ab9	Fix test failure from Bug 798616 fix.	4 years ago
John Ralls	7c350c3ae5	Bug 798616 - Can't register amount greater than 9,000,000,000 ... Because when loading the value the split in the xml backend doesn't yet have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION and if the numerator was larger than 10^10 that would overflow. To fix it this changes the "don't know" response to get_currency_denom and get_commodity_denom to GNC_DENOM_AUTO which will normally leave the denominator alone.	4 years ago
Christopher Lam	161b07b241	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	47fa8b281e	Merge PR #1425 into maint	4 years ago
John Ralls	a807d3e6b7	Create function gnc_tm_get_today_neutral. ... To complement gnc_tm_get_today_begin and gnc_tm_get_today_end.	4 years ago
luz paz	ba94730a23	Fix various typos ... Found via `codespell`	4 years ago
Christopher Lam	ecd2cdf425	[gnc-glib-utils] gnc_g_list_stringjoin skips NULL data	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. ... Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago
John Ralls	f24f29830b	[options] Change std::cerr stream output to PWARN. ... Remove temporary diagnostic.	4 years ago
Christopher Lam	3e02859277	Merge branch 'maint'	4 years ago
Christopher Lam	b7a3652de7	[date-utilities] avoid report crash if start>end date	4 years ago
John Ralls	087501d316	Bug 798262 - Scheduled transactions with blank amounts do not get created. ... Handle template transactions that don't have any splits with empty credit and debit strings and those having no set transaction account. Set the concrete transaction commodity to the first found of: The template transaction's commodity The commodity of the first split with a credit or debit string The commodity of the first split.	4 years ago
John Ralls	410db42df0	Test case where the template txn doesn't have a set currency.	4 years ago
John Ralls	229f6f5e85	Fix gdate adjustments.	4 years ago
Simon Arlott	4c1fc1d555	Bug 798262 - Add test case for basic scheduled transactions ... Test these scheduled transactions: * 2 splits with fixed amounts "123" * 2 splits with fixed amounts "0" * 2 splits with empty amounts "" Verify that automatically created scheduled transactions exist.	4 years ago
Christopher Lam	6ba912ee0d	Merge branch 'maint'	4 years ago
Christopher Lam	de7a63082b	[gnc-sx-instance-model] leaks: free temporal_state ... it's a simple struct containing GDate and int	4 years ago
Christopher Lam	ad27be333e	[gnc-sx-instance-model] prepend GList loops instead of append	4 years ago
John Ralls	8b07ac88cd	[options] Add "key" to the register-option documentation blocks.	4 years ago
John Ralls	e29ab5336f	[options] Remove key and doc_string from gnc_register_query_option. ... It's always used as an internal option with no UI component so it doesn't use them.	4 years ago
John Ralls	6faaf3b427	[options] Provide a const char* value flavor for register_commodity ... And register_currency_option	4 years ago
John Ralls	1ff844c195	[options] Fix implementation of gnc_register_owner_option ... To take an owner-type parameter and to set the UIType accordingly.	4 years ago
John Ralls	aa0b0921f4	[options] Add a function to check if an option is internal. ... Instead of relying on the legacy underscore-section-name hack.	4 years ago
John Ralls	da0eff2cac	[options] Implement widget-changed callbacks. ... Enables full functionality for complex-boolean and multichoice-callback options. Note that setter-function callback isn't used in any GnuCash code so it is not implemented and is not present in the register-callback functions.	4 years ago
John Ralls	552aa438ff	[options] Implement gnc_register_internal_option.	4 years ago
John Ralls	0e9ed8cf0a	[options] Provide float variants to gnc_register_plot_size_option.	4 years ago
John Ralls	0213787a2f	[options] Enable registering an absolute date option.	4 years ago
John Ralls	cf2870b71a	[options] Change RelativeDate and Multichoice index type to uint16_t. ... From size_t because clang thinks that std::is_same_v<size_t, time64> is true and we need to differentiate the handling of the two.	4 years ago
John Ralls	0b2d14ee72	Fix distribution for expressions target.	4 years ago
Christopher Lam	b94440b16a	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	ea56d67797	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	bfa0fd1819	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	f0ac8d69b2	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	0b5a4cd298	Merge branch 'maint'	4 years ago
Christopher Lam	d1aefc851d	[sx-book] free sx_list before g_object_unreffing sxes	4 years ago
John Ralls	688832b5f8	Bug 798585 - segfault running sample script ... The root cause of which is that on recent releases of GLib (recent meaning 2.66 in the current Debian stable!) g_type_instance_get_private looks in the wrong place for the private data. When running the script in question it returned NULL and since the code didn't check for a valid pointer, it crashed. So this change replaces all calls to g_type_instance_get_private with the function [type_prefix]_get_instance_private() added in glib-2.36 except for two register2 files that have been removed from master; those are ignored to avoid unnecessary merge conflicts.	4 years ago
Christopher Lam	67a1b7a873	[gnc-sx-instance-model] free GHashTable keys when destroying	4 years ago
Christopher Lam	ebf3439558	[gnc-sx-instance-model] free some GHashTable keys & Values	4 years ago
Christopher Lam	7c2a249511	[gnc-sx-instance-model.c] refactor Scrub function ... This scrubbing function calls xaccTransRollbackEdit which is leaky. Instead of trying to fix xaccTransRollbackEdit which requires superhuman skills, it's easiest to track the changes separately in a GList, and use xaccTransBeginEdit/xaccTransCommitEdit only if necessary.	4 years ago
Christopher Lam	7880f9b16f	[SchedXaction.c] free list of recurrences	4 years ago
Christopher Lam	c16840b840	more leaks because qof_instance_get returns a new char*	4 years ago
Christopher Lam	f1adb5da34	Merge branch 'TXN_TYPE-is-dynamic' xaccTransGetTxnType into maint #1201	4 years ago
Christopher Lam	ec3e996f92	tests xaccTransGetTxnType heuristics ... tests TXN_TYPE_NONE in utest-Transaction.c testing TXN_TYPE_INVOICE, TXN_TYPE_PAYMENT, and TXN_TYPE_LINK will require valid posted invoices, so, are best tested in utest-Invoice.c	4 years ago
Christopher Lam	fd12d3900c	[Transaction.c] use heuristics to determine txn->txn_type	4 years ago
John Ralls	f4c27d4494	Move gnc_ui_account_get_tax_info_string to gnc-locale-tax.c ... To prevent a circular dependency between libgnc-app-utils and libgnucash-guile.	4 years ago
Robert Fewell	ce4768c357	Bug 798565 - Import map editor entry deletion ... When a top level bayesian entry is deleted, the book is not marked dirty and so the save button is not highlighted. Deleting individual entries did mark book dirty. Fixed in gnc_account_delete_all_bayes_maps by wrapping the deletion with xaccAccountBeginEdit/CommitEdit block.	4 years ago
Robert Fewell	d688a17ef6	Merge 'luzpaz' branch 'source-typos' into maint PR #1364	4 years ago
John Ralls	3e2f7bc66a	Create separate shared library for expression parser and SX instance model. ... These functions depend on both libgnc-app-utils and libgnucash-guile, creating a circular dependency when the app-utils bindings are added to libgnucash-guile.	4 years ago
John Ralls	47904a858e	Fix distcheck in master. ... Several gnc-optiondb dependencies left out of tarball.	4 years ago
John Ralls	3fd8bd9ddf	Merge branch 'maint'	4 years ago
Christopher Lam	263f007d5c	[gnc-filepath-utils] new: gnc_list_all_paths	4 years ago
Christopher Lam	aa43c198c6	[Transaction.c] don't set TxnType kvp if it is the same as before ... will avoid dirtying the transaction.	4 years ago
John Ralls	9f6d495ca1	Fix use-after-free crash in utest-Invoice.	4 years ago
luz paz	cfc6e9d7e0	Fix source typo begining->beginning	4 years ago
John Ralls	1e6c679e71	Merge branch 'maint'	4 years ago
John Ralls	903cbdcad3	Bug 798547 - Calculated Due Date is short 1 day when posting on... ... day of fall change from Daylight Time to Standard Time. Really any day where the period crosses the dst->std change, and since the date dialog returns local midnight for the time that includes the day of the change. Convert both the parameter time and the return time to neutral time to ensure that the interval is handled correctly.	4 years ago
John Ralls	564d73a553	Bug 798531 - Selecting "Print" from the file menu on a report... ... crashes gnucash Ensure that every call to gnc_prefs_get_string correctly handles both a NULL or empty string return value without crashing or leaking.	4 years ago
Christopher Lam	670902d5a8	Bug 798535 - Crash when increasing the number of periods in a budget ... because in the SQL backend, gnc_budget_commit_edit will update the sql by reading from vectors with an increased priv->num_periods.	4 years ago
Robert Fewell	27cab58bf2	Correct some text describing some date functions.	4 years ago
Robert Fewell	c000a890ad	Bug 798501 - Balance wrong date end of account period ... With the accounting period preference settings set to 'Start/End of previous quarter' and balance sheet report using 'End of accounting period' the date is wrong, currently is 30/03/2022 when it should be 31/03/2022. Simplify gnc_gdate_set_quarter_end to get correct last day and subtract the 3 months befor calling said function.	4 years ago
Christopher Lam	a5cae6c5eb	Don't export undefined functions	4 years ago
Christopher Lam	fcc3b27f92	Merge branch 'maint'	4 years ago
Robert Fewell	ee7ed89b68	This partly fixes the currency and commodity combos ... With these changes the currency works but the commodity allows you to set the commodity but will crash if you save config or leave report open, this was tested on the 'Price scatter plot' report. Fixed with John's commit a8e6a59	4 years ago
Robert Fewell	db6a8f809b	Tax Tables combo does not set the active one ... Fixed by correcting spelling of tax table qof type, should 'gncTaxTable'. Also fixed setting tax table combo to 'none' when page reset button used.	4 years ago
Robert Fewell	0b67a91217	Fix the option GncOptionRangeValue ... The GncOptionRangeValue can be used with integers or doubles, the default being doubles. When used for setting the plot width/height, integers are used so all ValueTypes need to be integers other wise the when create_range_spinner is used you end up with the upper_bound value being G_MAXDOUBLE, a 309 character wide spin button. To differentiate the two, use 'set_alternate(true)' for integers.	4 years ago
Robert Fewell	506eb38493	Update Chart Width/Height Plot setting ... The new plot setting does both settings, values above 100 are treated as pixels and ones below are treated as a percentage. This means the maximum valid setting must be higher and also the tooltip needs to be changed.	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. ... Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. ... In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
Alex Aycinena	e381e70638	reverse commit d48937c. See discussion in Bug #79769.	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Alex Aycinena	d48937cf9c	Bug #79769 - Allow US Income Tax txf code 296 (Returns and allowances) to be shown and assignable for both income and expense type accounts.	4 years ago
Christopher Lam	394e0a4b71	[gnc-sx-instance-model.c] leak: don't strdup char* for xaccTransSetNotes ... For a while now, xaccTransSetNotes would strdup the notes. Don't need to strdup it beforehand.	4 years ago
Christopher Lam	e1d52963ed	[account.cpp] restore breadth-first search for 2 functions ... gnc_account_lookup_by_name and gnc_account_lookup_by_code were searching breadth-first and accidentally changed to depth-first in 4.7. as reported in https://github.com/Gnucash/gnucash/pull/1101#issuecomment-1098146573	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' ... # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
Christopher Lam	fae7ea02cd	[account.cpp] gnc_accounts_and_all_descendants converted from scm ... much more efficient than guile algorithm, avoids numerous repeated GList<->SCM conversions, and traversals of account descendants.	4 years ago
Frank H. Ellenberger	2298590316	Merge PR #1309 into maint	4 years ago
Christopher Lam	736d223198	Merge branch 'maint-progress3' into maint #1312	4 years ago
Christopher Lam	0c4d438a0e	[kvp-frame.cpp] expose iterator, skip inexistent frame	4 years ago
Christopher Lam	aab33954e7	[gnc-numeric.cpp] Reduce logging level of gnc_numeric exception message ... Exceptions are expected in some use cases.	4 years ago
luz paz	8adedc2248	Fix various typos ... Found via `codespell -q 3 -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./borrowed,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,ba,cas,dragable,gae,iff,iif,mut,nd,numer,parm,parms,startd,stoll`	4 years ago
Christopher Lam	6a668df168	[qofutil.h] don't recurse includes	4 years ago
Robert Fewell	ae220b86a4	[C++options] Fix Ubuntu test failure.	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	26b009c0f4	Bug 798500 - FTBFS (tests failure) on armhf ... Ensure the transition_times are correctly aligned for their sizes before attempting to copy them into the transitions vector.	4 years ago
Christopher Lam	ee8729dfb6	[account.cpp] char* must be freed	4 years ago
John Ralls	29bdd9b526	[C++options] Fix Ubuntu test failure.	4 years ago
John Ralls	1fddf70e21	[C++options] Fix previous month and previous quarter at the end of March ... . Because March has more days than February the previous month offset was getting normalized back to the current month--th 29 February this year is really 1 March, so normalizing before setting the day caused begin/end previous month to return the begin/end of the current month. That probably happened on the 31st of May, July, October, and December as well, I just hadn't managed to test on those days. Switching the normalization to after calculating the day of the month broke the previous quarter calculation because now the month was out of range, so normalize month & year first.	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	03cbbd1cd1	Merge branch 'maint'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
John Ralls	4fe83c3b32	[C++options] Remove GncOptionValue<SCM>. ... No longer needed.	4 years ago
John Ralls	278aa484d7	[C++options] Implement new GncOptionValue type GncOptionReportPlacement. ... For multicolumn reports so that we don't have to pass Scheme values.	4 years ago
Christopher Lam	4a75baa4c6	[gnc-xml-backend.cpp] gchar* must be freed after use. ... It is used as a constructor for std::string which makes a copy but doesn't take ownership.	4 years ago
Christopher Lam	cf1282501e	Use original guile variable names changed in #1073 ... The changes 09296dfb96, 1373233cd0 and 189db58e6 had caused inconsistencies. Best restore original guile variable names using underscore, bound to strings instead of functions returning strings.	4 years ago
Christopher Lam	5993ebf4d4	Merge branch 'maint'	4 years ago
Christopher Lam	5388cc8e2c	[kvp-frame.cpp] minor speedups ... reserve vector, cache iterator from m_valuemap.find for reuse immediately afterwards.	4 years ago
John Ralls	30e6c8ab11	[gnc-optiondb.i]Explicitly include array. ... Xcode-13.3 errors without it.	4 years ago
John Ralls	572cb6b1d1	Banish gnc_get_optiondb_from_dispatcher to gnc-report.cpp. ... Puts it closer to its points of use and removes it with its Scheme dependency from libgnucash.	4 years ago
John Ralls	e63baa6270	Merge Bob Fewell's 'rtl' into maint.	4 years ago
Robert Fewell	f8fc796c95	Bug797501 - Currency symbols in Hebrew (RTL) language ... When Gnucash is run in Hebrew which is a RTL language, on the accounts page the tree view is displaying the required number as the following... TreeView entry is '1,500.00 ₪' or '-1,500.00 ₪' TreeModel string is '₪ 1,500.00‬' or '₪ 1,500.00-‬' This seems to be down to the GTK 'Unicode Bidirectional Text Algorithm' which is changing the representation of the model string based on the first strongly typed character, in this case the Israeli shekel sign. To fix this, when creating the displayed monetary amount insert a BiDi ltr isolate uni-character at the start of the string.	4 years ago
John Ralls	d4c3c30b1a	Use GUIDs to represent QofInstances instead of pointers. ... Converting them to pointers for Scheme to use. Prevents dangling pointers when the user deletes a QofInstance as long as the Scheme report code re-fetches its pointers from the options when it's regenerated.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Christopher Lam	0052e3e483	[gnc-pricedb] add user:stock-transaction price source	4 years ago
John Ralls	c1001e6641	Better wording for tax table changed info message.	4 years ago
John Ralls	d841b322d0	Merge Frank Ellenberger's 'Bug684507' into maint.	4 years ago
John Ralls	ce2b89fd8c	[business]Add diagnostic messages to GncEntry and GncInvoice.	4 years ago
John Ralls	916caa25f2	Integrate Windows gzopen differences so that only one ifdef is needed. ... Clarifies code.	4 years ago
John Ralls	250b4ed733	Remove stray line left from earlier refactoring.	4 years ago
Robert Fewell	7e299cb2b0	Remove print statement left in commit c3f8daa	4 years ago
John Ralls	8ef8d3807c	Silence spurious conditional uninitialized warning in gnc-owner-sql.cpp.	4 years ago
John Ralls	93f5e23cf5	Open gzfile if thread creation fails.	4 years ago
John Ralls	9ad24321b4	Remove investment-type namespaces. ... Leave it to users to categorize their non-currency commodities. In the QIF importer default non-classifiable commodities to GNC_COMMODITY_NS_NONCURRENCY.	4 years ago
Frank H. Ellenberger	09296dfb96	Drop commodity-table.scm, no longer required after adjusting qif-dialog-utils	4 years ago
Frank H. Ellenberger	c7f842c081	Bug 684507 - commodity namespace should be localized	4 years ago
Christopher Lam	bd4a457040	Merge branch 'maint-lightning-budget' into maint #1248	4 years ago
Christopher Lam	a47413860a	Factor out GValue access for setters and getters	4 years ago
Christopher Lam	8f845df934	Factor out make_period_[data|note]_path	4 years ago
Christopher Lam	919f392c7a	Use kvp C++ interface rather than GValue	4 years ago
Christopher Lam	6c4c2512db	Use C++ STL instead of GLib	4 years ago
Christopher Lam	9088acabd8	[gnc-budget.cpp] convert to c++	4 years ago
John Ralls	81b9a02235	Bug 798458 - Build failure with gcc 12 ... Refactor try_gz_open to return a std::pair<FILE*, thread>. That removes the need for the threads hash-table and wait_for_gzip(). The cause of the gcc12 error was that we were using the thread's pipe's FILE* as the key to the hash-table and had to close it before calling wait_for_gzip(file) to remove the thread from the hash-table. gcc12 considers that a use-after-free. It happens to be wrong, but removing the need for it results in a cleaner implementation as well as silencing the warning.	4 years ago
John Ralls	67e8c317da	[xml backend] Extract functions to make gz_trhead_func more readable.	4 years ago
Christopher Lam	56cc021d33	Merge branch 'maint'	4 years ago
Alex Aycinena	a2825d33a1	Update Form/Schedule line references for 2021 for the US Income Tax Report	4 years ago
Christopher Lam	c1c198c9ff	Merge branch 'maint'	4 years ago
Christopher Lam	f0de54ac7a	Merge branch 'maint-798406' into maint #1240	4 years ago
Christopher Lam	8bc080b96d	[gnc-budget] store budget kvp data onto memory upon first call. ... then each getter will retrieve from memory rather than backend's kvp.	4 years ago
Christopher Lam	ef8d812d3f	[utest-Budget] test data retention when modifying budget num_periods	4 years ago
Christopher Lam	87b0a41e9b	[Split.c] return price==0 instead of 1, if !split, or amt==0	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" ... The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
Christopher Lam	f7ee644695	Amendment to 73822f97a [1/2] use heuristics to scrub budget signs ... Testing income<0 to conclude "none reversal" is likely a more sound strategy than testing liability>0.	4 years ago
John Ralls	a7a643f7f2	Store option commodities and namespace and mnemonic instead of pointer. ... Protects against crashes caused by the user deleting the commodity and allows the option to work if a deleted commodity is recreated.	4 years ago
John Ralls	65bd860249	Fix relative_date_to_time64 calculations. ... Where the date requested extends beyond the start or end of the year.	4 years ago
John Ralls	6841e5b5c8	Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue. ... That stores its values as a pair of <QofIdType, gncGUID> so that it won't have dangling ptrs if the instance gets deleted.	4 years ago
John Ralls	11225d9741	c++options: Remove gnc:options-data	4 years ago
John Ralls	16dc15964c	c++options: Remove the callback registration functions.	4 years ago
John Ralls	759376eb13	c++options: Fix multicolumn report	4 years ago
John Ralls	18edc17541	c++options remove stray debugging comment.	4 years ago
John Ralls	b5d0c42505	c++options: Put copyright and FSF header comment on gnc-optiondb.i.	4 years ago
John Ralls	a700701cd3	c++options: Remove three unused test functions. ... Scheme serialization is now tested in test-option-gnc-scheme-output.scm.	4 years ago
John Ralls	eb0bd4f998	c++options: Remove unneeded C++20 header and resolve ambiguous call.	4 years ago
John Ralls	a3f50586df	c++options: More thorough testing of scheme serialization.	4 years ago
John Ralls	6cd88c230c	c++options: Create bool or string internal options when possible. ... There's no need to save internal options as SCM when we support the underlying type in C++.	4 years ago
John Ralls	e9b850cca5	c++options: Correct Scheme serialization of type bool.	4 years ago
John Ralls	66f9fc81c7	c++options: Implement serialization for GncOwner.	4 years ago
John Ralls	0ce841d4ce	c++options Fix Scheme bindings for QofQuery options.	4 years ago
John Ralls	216b483e26	c++options SCM bindings Rewrite save_scm_value to branch on type. ... Instead of GncOptionUIType, mostly. We still need to do that to tell apart commodities and currencies from other QofInstances. Allows compile-time dispatch for most types.	4 years ago
Christopher Lam	c3eaff9bb2	[account.cpp] gnc_account_and_descendants_empty: don't copy children	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	947c061989	C++options: Create QofQueryValue trait.	4 years ago
John Ralls	f26014a04e	c++options: QofInstanceValue: Protect against crashes when m_value is nullptr.	4 years ago
John Ralls	95b973f792	Bug 798352 - Decimal Precision when Entering Mutual Fund Transaction ... Let xaccParseAmount parse up to 12 decimal places instead of 8.	4 years ago
Christopher Lam	33b6dfc6ce	[options.scm] addendum ca6604c93 gnc:make-budget-option ... selection-budget changed from budget object to guid, handle other uses as appropriate.	4 years ago
Christopher Lam	ca6604c93c	[options.scm] Addon previous commit... need to initialize with guid	4 years ago
Christopher Lam	d740ac1cb0	Merge branch 'budget-option-stores-guid' into maint PR #1207	4 years ago
John Ralls	5c7967c4a5	Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint." ... This reverts commit 17a3f7fef2, reversing changes made to b8458d0732.	4 years ago
John Ralls	ae7eaad018	Merge Chris Good's 'maintBug797678OfxAppend' into maint.	4 years ago
John Ralls	17a3f7fef2	Merge Stefan Bayer's 'SepaInternalTransfer' into maint.	4 years ago
Christopher Lam	5a812ca1eb	[options.scm] gnc:make-budget-option stores guid instead of object ... because object may become stale if UI is used to delete it, leading to stale pointer and segfault. storing guid is safer, and will return null if budget is deleted.	4 years ago
Christopher Lam	91b1d291a5	[3/3][gnc-ui-util.c] Remove unused functions ... These functions were used to (optionally) reverse amounts according to whether the feature GNC_FEATURE_BUDGET_UNREVERSED was set. They are now obsolete because code will now assume feature is set for all loaded datafiles.	4 years ago
Christopher Lam	73822f97a9	[1/2][Scrubbudget.c] use heuristics to scrub budget signs ... If book has budgets, and GNC_FEATURE_BUDGET_UNREVERSED isn't set, check and fix budget amount signs. Previously budgets were created with assumption that sign reversal was set to credit amounts. A heuristic approach is used: - if budgeted expense is negative, conclude sign reversal is "Income and Expense" - if budgeted liability is positive, conclude sign reversal is "None" - otherwise conclude sign reversal is "Credit Accounts" The above is calibrated to (hopefully) prefer sign reversal of Credit Accounts.	4 years ago
Christopher Lam	6070aecd69	[2/3][gnc-features.c] add & expose gnc_features_set_unused ... same as gnc_features_set_used but removes feature	4 years ago
Christopher Lam	5dab33694f	[1/3][qofbook.cpp] add & expose qof_book_unset_feature ... same as qof_book_set_feature but removes feature item	4 years ago
John Ralls	269249378f	c++options fix setting account-selection widget from option.	4 years ago
John Ralls	6f93a68bad	c++options: Serialize and deserialize to strings instead of streams. ... And use serialize to create values for gnc:generate-restore-forms and both of them for the meat of the stream functions. This fixes in particular QofInstance serialization where passing the option value directly to scheme format resulted in a notation about a swig pointer instead of the desired GUID string or commodity namespace and mnemonic strings.	4 years ago
Christopher Lam	88ecf8dd17	Merge branch 'maint'	4 years ago
John Ralls	dd7feb9988	options.scm: Remove second license comment.	5 years ago
John Ralls	d1fe359e47	gnc_numeric_to_decimal: Change can't round warning to a debug. ... Routinely used as a check so a warning isn't appropriate.	5 years ago
John Ralls	74fd716afb	Clarify gnc_relative_date_to_time64 helper functions.	5 years ago
John Ralls	f6c9e63e3d	Fix PR comments so far. ... Except for gnc-option-date's normalize_tm and set_day_and_time.	5 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	96b09ded9f	Doxygen documentation for new options classes.	5 years ago
John Ralls	00a982d97d	Use Scheme to generate and parse saved option files. ... The saved option files being Scheme executables.	5 years ago
John Ralls	ff04ad3785	Bug 798346 - crashes when running check & repair ... Don't scrub trading accounts for imbalances, see the comment in the commit for why.	5 years ago
Christopher Lam	984d816a58	Merge branch 'maint'	5 years ago
Christopher Lam	79d8ef0299	Revert b5f5129f7 using gnc_list_length_cmp	5 years ago
Christopher Lam	3dfdf60608	[gnc-glib-utils] Define and export gnc_list_length_cmp	5 years ago
Christopher Lam	b5f5129f7d	Shortcut g_list_length comparison against small numbers ... It's more efficient to test node && node->next etc when testing GList length against small numbers	5 years ago
Christopher Lam	f813f7cd14	[gnc-autoclear] Move autoclear algorithm into gnome-utils	5 years ago
goodvibes2	8ad29feaba	Bug797678 OFX import should append not replace, existing Notes & Desc ... Add an "Append" checkbox to the bottom of the "Generic import transaction matcher" window to the left of the "Reconcile after match" checkbox. When ticked, this causes the imported Description/Notes to be appended to the matched transaction Description/Notes respectively. The selected ticked/unticked state of the "Append" checkbox is saved in a key value pair for the import account, so the next import for that account will automatically default it to the saved state. As these mods are limited to the code for the matcher window, this should work for all the imports that use it - ie ofx & csv file imports (both tested) & aqbanking (cannot test).	5 years ago
Geert Janssens	bdb06479e8	GSettings - fix GObject warning when old prefs-version is unset ... This will happen when current master (future 5.0) has been run at least once.	5 years ago
John Ralls	5a8cbf4193	Bug 798325 - New Currency for Venezuela (VED) ... Add latest Venezuelan revaluation of the Bolivar Soberano, following the ISO notation replacing VES (which the Venezualan central bank is keeping) with VED and the exchange code (ditto) with 926.	5 years ago
Christopher Lam	f40dbb8c28	Avoid unnecessary g_list_length in equality functions	5 years ago
Christopher Lam	f0970c8eb4	[gnc-features] don't repeatedly g_strconcat gchars*	5 years ago
Christopher Lam	31a0300abe	[Recurrence.c] avoid repeated calls to g_list_length	5 years ago
Christopher Lam	b480600dc8	[gnc-pricedb] gnc_price_list_equal: avoid 4 g_list_length calls	5 years ago
Christopher Lam	23e528f51a	[utest-gnc-pricedb] add tests for gnc_price_list_equal ... Also need to change PWARN which causes test failure, to PINFO	5 years ago
Geert Janssens	09b3ce2382	Revert "Add structure to map migrated preferences to old ones" ... This reverts commit c6103a5c17.	5 years ago
Geert Janssens	806d0b3157	Revert "GSettings - make most of the api private" ... This reverts commit 26b2d7ca78.	5 years ago
Geert Janssens	1d4673ed2a	Revert "GSettings - rework internal helper functions to use more C++" ... This reverts commit 24fa289952.	5 years ago
Geert Janssens	24fa289952	GSettings - rework internal helper functions to use more C++	5 years ago
Geert Janssens	26b2d7ca78	GSettings - make most of the api private ... All preference calls should happen via the gnc_prefs_... apis. The gnc_gsettings_... apis are an internal implementation of this.	5 years ago
Geert Janssens	c6103a5c17	Add structure to map migrated preferences to old ones ... This can be used to keep both in sync in the period between initial migration and eventual obsolence. Note only non-obsoleted, migrated preferences are tracked. We don't want to resync preferences that have been obsoleted (reset). That would nullify the whole idea of making them obsolete for future removal. This commit only adds the mapping, synching will follow in a future commit.	5 years ago
John Ralls	2f4438ab28	Bug 798335 - No longer possible to change trading account ... Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so.	5 years ago
Christopher Lam	9eaa3eb23a	Merge branch 'maint'	5 years ago
John Ralls	7c9c2eba3c	Bug 798320 - Error message indicating a crash of GNUcash when closing... ... application - MacOS 10.15.7 (19H1419) Destruction order problem: The SX template accounts can't be destroyed until after the template splts and transactions are. Register them before the transactions and splits, as destruction occurs in reverse order of registration.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
Geert Janssens	9a465fc359	GSettings - add 'deprecate' and 'obsolete' conversions for user preferences ... 'deprecate' is technically a noop. It serves to remind maintainers the 'deprecated' preference is to be obsoleted in the next major release. 'obsolete' goes one step further in that it will cause gnucash to reset the preference, effectively clearing the value stored in the preferences backend. This is the final phase of a preference. Following this it will be completely removed from the GSettings schema in the next major release. Notes * 'deprecate' and 'migrate' are related. Both are a reminder the preference is to be obsoleted in the next major release. 'deprecate' does only that though while 'migrate' will also trigger a copy of the old value to a new location in the databse. * This commit readds a couple of preferences that had been removed in the past to be able to properly obsolete them (and to test the obsoleting code)	5 years ago
Geert Janssens	64576f7d27	GSettings - widen scope from 'migration' to 'transformation' ... This commit mostly changes descriptions and variable names to use the more generic terms 'transformations' or 'conversions'. 'migration' is only one possible transform, future commits will add others. There are no functional changes in this commit other than a logic inversion in parse_one_release_node. It now checks for nodes named 'migrate' rather than for nodes not named 'migrate' (the code is adapted accordingly to match this logic change).	5 years ago
John Ralls	29e7b07ed3	Remove superflous schema_source left over from pasting.	5 years ago
John Ralls	8bfa5a63f2	[gsettings] Avoid crash from settings schema not being registered.	5 years ago
Christopher Lam	10c1223df2	Merge branch 'maint-progress' into maint #1150	5 years ago
Geert Janssens	2a7566cc40	Win32 - drop conditional code never reached ... We had hardcoded HAVE_HTMLHELPW to always be true so the fallback code that's only reached when it is false was never reached. Time to drop this dead code.	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason ... tests in 128c8d6f88	5 years ago
Christopher Lam	128c8d6f88	[utest-Transaction] add tests for xaccTransGetReadOnly	5 years ago
Geert Janssens	8ea52ae212	GSettings - run data model transations while setting up ... This makes sure all schema changes are in effect before the first consumer can query them. For example this will prevent a one-time re-occurrence of the tip of the day dialog the first time the new migrations are run.	5 years ago
Christopher Lam	c0736a1a04	Merge branch 'maint-leaks' into maint #1135	5 years ago
Geert Janssens	f1802b6fdf	GSettings Upgrade - add code to migrate settings ... The rules for migration are read from an xml file. This file was prepared in a previous commit. Future settings 'data model' changes can reuse this code by simply adding migration rules in the xml file. This replaces the hardcoded rules that were currently in place to migrate a few settings from 2.6 and older to 3.0. These rules are no longer meaningful as we require users to migrate from one major release series to the immediate next one. So by the time the new migration rules in this commit are applied by users they should already have run gnucash 3.x at least once. That run should have taken care of the pre-3.0 migration actions.	5 years ago
Geert Janssens	f21c7b6e90	GSettings - define old prefix and check settings for the presence of both prefixes while normalizing	5 years ago
Geert Janssens	a203c5b2d5	GSettings - drop logic to relocate our settings ... This was ported from GConf, but GSettings doesn't work that way. Settings locations are defined at compile time and can't be relocated at run time (unless you make all of the settings explicitly relocatable. That however is not how GSettings is meant to be used.)	5 years ago
Geert Janssens	d1113a4534	GSettings - build as cpp	5 years ago
Geert Janssens	02fbf217f6	GSettings Upgrade - change schema prefix from org.gnucash to org.gnucash.GnuCash ... The latter is the prefix format prescribed by gsettings itself. The former never was an issue until flatpak decided to not accept the shorter prefix when requesting a settings migration from host system to flatpak sandbox. In order to allow for migration, keep the old schema around in org.gnucash.GnuCash.deprecated.gschema.in While we're at it, make the new prefix an internal implementation detail. There's no need for it to be visible to the rest of the gnucash code.	5 years ago
Geert Janssens	6674b1bb6b	Cleanup - minimal glib=2.56.1 - drop all conditionals on older versions	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions ... GValue in DxaccAccount[Set|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in 4309469730.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset ... already have comprehensive tests in 15852031d	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry ... Have comprehensive tests in a5d101d1b	5 years ago
Christopher Lam	4309469730	[utest-Account] test old dxaccAccount* functions ... dxaccAccountGetPriceSrc and dxaccAccountGetQuoteTZ. DxaccAccountSetCurrency remains untested - unsure how to retrieve an ISO4217 currency to use as parameter.	5 years ago
Christopher Lam	a5d101d1be	[utest-Account] test gnc_account_get_map_entry	5 years ago
Christopher Lam	73ad5b1265	[gnc-glib-utils] use g_stpcpy instead of gnc_strcat ... g_stpcpy will use stpcpy wherever available.	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" ... This reverts commit d290c3c45d. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path ... exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago
John Ralls	1d8983191d	Fix runaway sed error.	5 years ago
John Ralls	824b515430	Fix qoflog's comments to reflect a preference for the macros over GLib functions.	5 years ago