2300 Commits (6cd8e4e4584cc2a3423a64dd8d5d62c32a8c5b89)

Author	SHA1	Message	Date
John Ralls	241aa1d2eb	Merge Richard Cohen's 'remove-unneeded-memcpy' into stable.	3 years ago
John Ralls	aae568eca6	Add comment explaining "option.template get_value<int>()".	3 years ago
John Ralls	4dc8a7ee0d	Bug 798952 - Unable to set day threshold or counters in properties ... Make counters explicitly integer type and adjust the kvp load and save functions to recognize that and behave accordingly so that other range options like day threshold aren't affected.	3 years ago
John Ralls	827bfabd69	Merge Richard Cohen's 'declare-type-gnc-plugin' into stable.	3 years ago
Richard Cohen	3abc9a5558	Refactor: Remove some unnecessary uses of memcpy ... - Also, remove unnecessary "static" in gnucash-style.c The second one in guid.cpp is UB: libgnucash/engine/guid.cpp:137:5: warning: undefined behavior, source object type 'const gnc::GUID' is not TriviallyCopyable [bugprone-undefined-memory-manipulation] memcpy (&target, &source, sizeof (GncGUID)); ^	3 years ago
Christopher Lam	4a60e01fcd	bugfix xaccTransGetTxnType: avoid returning TXN_TYPE_LINK incorrectly ... A TXN_TYPE_PAYMENT will have non-APAR splits; a TXN_TYPE_LINK will not have non-APAR splits. This bug manifests as a regular TXN_TYPE_PAYMENT transaction being later voided being incorrectly changed to TXN_TYPE_LINK.	3 years ago
Richard Cohen	1255d61917	Refactor: hide implementation of GncPlugin* (move from .h -> .c)	3 years ago
Richard Cohen	2e59bda951	Refactor: DECLARE_FINAL GncPluginExample < GncPlugin ... - Fix the name	3 years ago
John Ralls	0d1ba1ebe7	Merge Richard Cohen's 'y2038-fixes' into stable.	3 years ago
Christopher Lam	8ec6a4cb12	[Scrub.c] 8628ca8715 rewritten to avoid QofQuery ... because QofQuery will include the blank transaction which must not be scrubbed.	3 years ago
Richard Cohen	7d26b8c05f	Fail the test if still using 32bit time_t in 2038 ... gtest-gnc-option.cpp and gtest-gnc-optiondb.cpp need to call time() for g_date_set_time_t()	3 years ago
Richard Cohen	d63248dad2	Update Y2038 comments	3 years ago
Christopher Lam	3ccb5c4896	Merge branch 'wordsmithing' into stable #1658	3 years ago
John Ralls	dda661cfd2	Merge Richard Cohen's 'more-define-types' into stable.	3 years ago
Christopher Lam	f580a6cf2d	[gnc-ui-balances.c] better wording for balance limits	3 years ago
John Ralls	a5ff19b62a	Merge Richard Cohen's 'fix-incorrect-logging-after-fallthrough' into stable.	3 years ago
Richard Cohen	6e5c525f77	Use gnc_time() instead of time()	3 years ago
Richard Cohen	fde90c4c99	Restore test-gnc-option ... - removed in merge 3e5fcc8709 To get it to compile - remove unused variables - remove duplicate operator==(GncGUID)	3 years ago
Richard Cohen	a0fd9af394	Fix incorrect logging after switch fallthrough ... oops	3 years ago
Christopher Lam	ccc75cfc88	Merge branch 'scrub-optimize' into stable	3 years ago
Christopher Lam	81902ba8bb	[scrub.c] xaccTransScrubSplits calls Begin/Commit only if required	3 years ago
Christopher Lam	872e20c555	move xaccTransScrubSplits to Scrub.c ... it's defined in Scrub.h anyway	3 years ago
Richard Cohen	680fe47bac	Refactor: Remove unused macros GNC_BASIC_GOBJECT_*	3 years ago
Christopher Lam	9047156017	[Scrub.c] refactor xaccAccountTreeScrubOrphans	3 years ago
Christopher Lam	8628ca8715	[Scrub.c] refactor xaccAccountTreeScrubImbalance ... The scrubbing routines are transaction oriented. Instead of xaccAccountTreeScrubImbalance calling xaccAccountScrubImbalance for each descendant, refactor so that the transaction list is generated only once. The scrubbing is faster and progress bar is more accurate.	3 years ago
Christopher Lam	d214b2f05d	Merge Vincent Dawans' branch 'bug798879' into stable #1617	3 years ago
Vincent Dawans	1c04e744d3	[trep-engine.scm] Rename "Totals" option to "Grand Total"	3 years ago
John Ralls	dd5be317d8	Merge Richard Cohen's 'define-type' into stable.	3 years ago
John Ralls	6111184c73	Ensure incorrectly coded counter KVP is read correctly. ... Bug 798930 caused some counters to be saved as KVP double. If the correct int64_t value isn't found when reading, or if a double is encountered when loading the option dialog, get the double value and cast it to int64_t.	3 years ago
John Ralls	7d5663899c	Bug 798930 - invoices wont sequence to the next number ... Because KVP can't magically cast between int64_t and double.	3 years ago
Richard Cohen	5d955654bc	Refactor: DEFINE_TYPE GncSxInstanceModel < GObject	3 years ago
John Ralls	3d30e5978a	Merge Richard Cohen's 'define-boxed' into stable.	3 years ago
Richard Cohen	ae9304efb0	Remove unused boxed type gnc_value_list	3 years ago
Richard Cohen	f9efbf86c6	Remove unused Qofbook::ab-templates property	3 years ago
John Ralls	8a5b3721df	Merge Richard Cohen's 'remove-duplicate-define-type-code' into stable.	3 years ago
Mike Alexander	6bdaa161eb	Redo 71afa3e0 and 71afa3e0 so powten(max_leg_digits) is 1e18 ... This is what it was before 71afa3e0. This is the largest power of ten that fits in an int64.	3 years ago
Christopher Lam	89f7e8933b	gnc_list_all_paths returns std::vector instead of GList of EnvPaths ... because its consumers are now cpp there's no need to return a GList.	3 years ago
Richard Cohen	2db5004a22	Remove code that duplicates features of G_DEFINE_TYPE ... - declarations of *_init, *_class_init - implementation of *_parent_class - also, removed unnecessary NULL checks for destroy, dispose, finalize	3 years ago
Richard Cohen	eb2d5df778	Refactor: DEFINE_BOXED GncGUID	3 years ago
Richard Cohen	c514f61a7a	Refactor: DEFINE_BOXED Time64	3 years ago
Richard Cohen	14f2efcfb7	Refactor: DEFINE_BOXED gnc_numeric	3 years ago
John Ralls	bba49a6d09	Fix test-gnc-euro failure. ... Fixing the pow[] array required also adjusting the number of denominator digits when converting doubles to gnc_numerics.	3 years ago
Mike Alexander	71afa3e0fc	Make the GncNumeric string constructtor work for long decimal numbers. ... It was failing to produce a correct representation for input with more than 14 digits after the decimal poin. Fixes Bug 798916. The bug was in powten so this fix may corect other problems too. For example conversion of GncNumeric back to a string also failed in certain circumsances.	3 years ago
Mike Alexander	d61b962954	Fix a typo in some debug output.	3 years ago
John Ralls	8ccc6da87e	Merge Richard Cohen's 'fix-test-engine-crash' into stable.	3 years ago
John Ralls	26162da450	Merge Richard Cohen's 'cleanup-build' into stable.	3 years ago
John Ralls	46e9fcf037	Merge Richard Cohen's 'cleanup-ui-files' into stable.	3 years ago
Richard Cohen	81fba56bbb	Initialise guids in test-engine-kvp-properties.c ... Valgrind: Conditional jump or move depends on uninitialised value(s)	3 years ago
Richard Cohen	bed43c7f3b	Fix potential crash in test-engine ... ==515314== Invalid read of size 1 ==515314== at 0x484AD67: __strcmp_sse42 (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x171D36: do_test_list_handler (unittest-support.c:181) ==515314== by 0x171DCE: test_list_handler (unittest-support.c:197) ==515314== by 0x51BD4C1: g_logv (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51BD7A2: g_log (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x4D5D0D9: xaccSplitEqualCheckBal (Split.c:753) ==515314== by 0x4D5D841: xaccSplitEqual (Split.c:869) ==515314== by 0x4D647A5: xaccTransEqual (Transaction.c:981) ==515314== by 0x15C0E8: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:901) ... ==515314== Address 0x8725260 is 0 bytes inside a block of size 59 free'd ==515314== at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x15BDB1: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:883) ... ==515314== Block was alloc'd at ==515314== at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x5618677: __vasprintf_internal (vasprintf.c:116) ==515314== by 0x520E8C1: g_vasprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51DBBE0: g_strdup_vprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51DBC9C: g_strdup_printf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x15BBAC: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:879) ... ok 78 /engine/Transaction/xaccTransEqual	3 years ago
Richard Cohen	dc62959553	Fix crash in test-engine on Arch ... Thanks, Valgrind: ==515314== Invalid read of size 8 ==515314== at 0x4ED46F3: gncInvoiceRemoveEntries (gncInvoice.c:767) ==515314== by 0x142B35: teardown_with_invoice (utest-Invoice.c:274) ... ==515314== Address 0x8557b98 is 8 bytes inside a block of size 24 free'd ==515314== at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x51B565D: g_list_remove (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x4ED42EF: gncInvoiceRemoveEntry (gncInvoice.c:688) ==515314== by 0x4ED46A2: gncInvoiceRemoveEntries (gncInvoice.c:781) ==515314== by 0x142B35: teardown_with_invoice (utest-Invoice.c:274) ... ==515314== Block was alloc'd at ==515314== at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==515314== by 0x51BD948: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x51B1CB9: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==515314== by 0x4ED4271: gncInvoiceAddEntry (gncInvoice.c:676) ==515314== by 0x142401: setup_with_invoice (utest-Invoice.c:142) ... ok 57 /engine/gncInvoice/post trans - vendor bill	3 years ago
Richard Cohen	3c34a61776	Remove #pragma ... "-Wformat-nonliteral" ... Seems to have been accidentally left behind when time64_to_string() was (re)moved	3 years ago
Richard Cohen	1f43bbc798	Remove #pragma ..."-Wstrict-aliasing" ... G_LOCK was fixed in glib 2.19.8 See https://bugzilla.gnome.org/show_bug.cgi?id=316221	3 years ago
Richard Cohen	80e9d9c35d	scanf supports %lld since C++11, C99	3 years ago
Richard Cohen	7f1ce2b5e5	Remove references to cutecash	3 years ago
Richard Cohen	b3e3eb3166	By default, filter out online_wiggle in test-gnc-quotes ... The test relies on a lot of external dependencies - installed finance-quote-wrapper - alpha vantage key - network - working remote server Running ./bin/test-gnc-quotes from the command line will still include online_wiggle	3 years ago
Richard Cohen	1fe097bd5f	Update gnc-plugin-example-ui.xml	3 years ago
Richard Cohen	4df662afae	Fix the typo in function name "new_query_for_addresss"	3 years ago
Richard Cohen	3957272ef0	Fix some typos in comments	3 years ago
John Ralls	9b95419608	Fix glib include.	3 years ago
John Ralls	d696f0cfcb	Bug 798885 - Accented character in folder name on Account Export (bis) ... Pass a boost::filesystem's c_str() rv to the ofstream constructor to keep libstdc++ from transcoding it back to UTF8 and creating a broken name or failing to match the directory name. Implemented in gnc-filepath-utils to avoid spreading the boost::filesystem dependency throughout the code base. See https://github.com/boostorg/filesystem/issues/181 for why other approaches don't work.	3 years ago
John Ralls	bb423e4484	Merge CrfzdPQM6's 'b_betterCurrencyBudgetReporting' into stable.	3 years ago
Daniel Johnson	04b0317119	Demonstrate fx handling in budget report	3 years ago
John Ralls	df878c6a3d	Merge Maarten Bosmans's 'memleak-fixes' into stable.	3 years ago
Maarten Bosmans	71802b5627	[test] Fix memory leak in test-gnc-quotes ... When the commodity table is registered, the current book will get a default table assigned. When later setting the table explicitly using qof_book_set_data() the exisiting table gets overwritten and is thus leaked. There is no way of removing or freeing a currency table from a book, so the best we can do here is to set our own table on the book before calling gnc_commodity_table_register().	3 years ago
Maarten Bosmans	6be682b645	Store allocated temporaries in a variable so they can be freed ... If a function that returns an allocated pointer is passed directly into something that does not take ownership of the pointer, the allocation is leaked. This can be fixed by assigning the pointer to a new variable and freeing it after operation on the memory.	3 years ago
Christopher Lam	1a7fcb69c0	[gnc-features.cpp] remove_if requires <algorithm>	3 years ago
John Ralls	8481f062d4	Create obsolete features list with first member book_currency. ... Obsolete features set in the book will be removed from the book's KVP and ignored. Note the warning in the comment!	3 years ago
John Ralls	0d175dce12	Refactor gnc-features. ... * type aliases to gnc-features.h * string_views to avoid copying (all of the strings are static) * qof_book_get_unknown_features returns a FeatureSet	3 years ago
John Ralls	e8c80f2f5c	Restore existence, but not implementation, of GNC_FEATURE_BOOK_CURRENCY. ... At least one user has managed to get it set on their book so even though it was supposed to be unimplemented it got through somehow. Restoring it allows books with it set to load.	3 years ago
John Ralls	9ff2362bb0	Merge Muhammadyusuf Kurbanov's 'uz-currency-fix' into stable.	3 years ago
Robert Fewell	fb58959f9a	Bug 798885 - Accented character in folder name on Account Export ... Changed export_coa to use g_fopen instead of fopen	3 years ago
Muhammadyusuf	02e24ccf96	edit: use &apos; instead of ` symbol	3 years ago
Muhammadyusuf	dca596ac84	edit: Fix local symbol of uzbek sum	3 years ago
Christopher Lam	e26c3d6cf4	[gnc-ui-balances.c] gnc_ui_account_get_balance_limit_explanation ... returns a char* explanation, or NULL	3 years ago
Vincent Dawans	761d7f29a5	Bug 765920 - Running balance not accurate when sorted different ways ... - Renamed option to "Account Balance" to avoid confusion with running total. - Added helper function to ensure running balance and balance forward are only shown when transaction are grouped by account and sorted as in register. In that case column heading remains "Running Balance" and balance forward is shown. Otherwwise column heading is renamed "Account Balance" and balance forward is not shown. - Also added missing code for Common Currency conversion.	3 years ago
John Ralls	4a5b897d89	Bug 798863 - Crash on clicking Settings button second time ... Ensure that dialog resources stored in options are freed when the dialog is destroyed. The crash happened when a new dialog replaced the old one on the options and the old one's destructors tried to access a dangling reference to a GtkWidget.	3 years ago
John Ralls	f4f481fe38	Bug 798812 - crashes after I open a customer report and select… ... Edit/Report Options As a result of auto instead of auto& in a std::visit call which resulted in a temporary option whose GncOwner* was destroyed before we could use it.	3 years ago
Robert Fewell	0d84506a5e	Bug 798851 - Account Balance 'include subaccounts' not saved ... The defaults for the account were removed by mistake in a previous commit, added them back.	3 years ago
John Ralls	2f471e65a7	Bug 798802 - Online Price quote - Stocks not working GNU 5.0 Windows Bis ... The previous change of the delimiter between namespace and symbol is needed in both overloads of GncQuoteImpl::query_fq. Also log the query json string to ease future troubleshooting.	3 years ago
Maarten Bosmans	0d86be6d2a	[test] Properly destroy resources on end of tests ... This fixes memory leaks that are only present in testing code. Not very useful on itself, but it does make it easier to fix memory leaks and other AddressSanitizer problems in actual gnucash code later.	3 years ago
Maarten Bosmans	ed3fe00880	[test] Use test fixture to initialize and destroy resources	3 years ago
Maarten Bosmans	35aeed45ec	[engine] Remove two replace functions from KvpValue ... These were not used outside a test. And that test was not leak free, as a result of the functions not doing what they are supposed to do when the current value is not of the type that is expected. (NULL is returned, but the value is not replaced)	3 years ago
Maarten Bosmans	bd94965d9b	[backend/xml] Remove unused string copy	3 years ago
Richard Cohen	6ba5bb326a	Fix dereference of expired temporaries. ... Reported by clang 15.0.7, which will be in Ubuntu 23.04, -Wdangling-gsl	3 years ago
Richard Cohen	9fa2a48fe1	Fix build on gcc-8 & 9. ... See https://lists.gnucash.org/pipermail/gnucash-devel/2023-March/046617.html	3 years ago
John Ralls	0d598d51ed	Fix Finance::Quote use on Win32. ... By dealing with Win32 \r\n newlines on return from finance-quote-wrapper.	3 years ago
John Ralls	a587dfff2c	Bug 798802 - Online Price quote - Stocks not working GNU 5.0 Windows ... Change the property-tree path delimiter for constructing paths from '.' that's commonly used in stock symbols, to '|' that isn't.	3 years ago
Christopher Lam	bdf79f7721	Merge branch 'master-fileopen-filter' into stable #1576	3 years ago
John Ralls	89f41a305c	Merge new potfile reflecting string changes.	3 years ago
John Ralls	576fc9b52c	Fix quotes on Windows. ... Boost process wchar_t conversion chokes if it's fed an empty string. This would happen when the user had no alphavantage key. Separate the process invocation to not present the empty value to boost process.	3 years ago
John Ralls	90e1e2d1c3	Merge Bob Fewell's 'bug798558' into master.	3 years ago
John Ralls	0c3e85404d	Avoid crash from trying to free an unallocated char*.	3 years ago
Christopher Lam	97f0653238	[gnc-quotes] g_free a char* from gnc_prefs_get_string ... ultimately gets char* from g_settings_get_string and must be freed	3 years ago
Robert Fewell	a576dd87a4	Bug798558 - Irregular line spacing in Account Tree View ... When securities are in the list, the rows look twice as high as though there is a linefeed at the end. This is partly due to commit for bug 797501 which worked at the time but a change in pango 50.4 to do with wrapping has highlighted this bug. To fix this only wrap currencies with ltr bidi isolate characters in gnc_print_amount_with_bidi_ltr_isolate	3 years ago
John Ralls	00c560d8f5	Move operator==(const GncGUID&, const GncGUID&) to guid.[ch]pp.	3 years ago
John Ralls	352ab8a0e5	Merge Richard Cohen's 'minor-options-fixes' into master.	3 years ago
John Ralls	d192be5307	Merge Richard Cohen's 'cleanup-cflags-deprecated' into master.	3 years ago
Richard Cohen	24f52d9b17	Remove incorrect operator!= for GncItem ... It's better to use the default std::pair implementation - spotted by clang-tidy bugprone-suspicious-string-compare - will always return false, because type is the same Also, - remove redundant "using GncItem ..."	3 years ago
Richard Cohen	b5f3f99035	Fix incorrect use of remove_if() ... - spotted by clang-tidy bugprone - probably no visible effects because of uniqueness, and other checks libgnucash/engine/gnc-optiondb.cpp:149:5: warning: this call will remove at most one item even when multiple items should be removed [bugprone-inaccurate-erase] m_options.erase(std::remove_if(m_options.begin(), m_options.end(), ^ libgnucash/engine/gnc-optiondb.cpp:358:5: warning: the value returned by this function should be used [bugprone-unused-return-value] std::remove_if(m_callbacks.begin(), m_callbacks.end(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libgnucash/engine/gnc-optiondb.cpp:358:5: note: cast the expression to void to silence this warning	3 years ago
John Ralls	b4b8431984	Bug 798778 - GnuCashquits abruptly when attempting to edit options… ... for certain reports. Those reports being ones using complex options, apparently because the callbacks weren't protected from Guile's garbage collector. So replace the anyway ugly hack of a void* with a std::any wrapping a class holding a std::unique_ptr with a custom deleter. The constructor calls scm_gc_protect_object on the SCM containing the callback and the custom deleter calls scm_gc_unprotect_object. The copy constructor, required for std::any, makes a new std::unique_ptr and calls scm_gc_protect_object again ensuring that the protect and unprotect calls are symmetrical. Meanwhile std::any hides the Guile dependency from all the classes that don't need to know about it. The only ugliness is that there's no good place to put a common implementation of SCNCallbackWrapper so it's repeated in gnc-optiondb.i and dialog-options.cpp.	3 years ago
Christopher Lam	dd0d65d861	[1/2] [gnc-filepath-utils.cpp] gnc_filename_is_backup|datafile ... uses std::regex to test filename	3 years ago
Richard Cohen	30586ac3e6	Push -Wno-error=deprecated-declarations from C*_FLAGS down to the target	3 years ago
Geert Janssens	1f0a69a804	Properly parse plus signs while importing numbers ... Silly copy/paste error.	3 years ago
John Ralls	a44b3664e2	[c++options] Implement GncOptionGncOwnerValue class. ... GncOwners aren't QofInstances and have limited lifetimes so an option must hold its own, wrapped in std::unique_ptr for memory management.	3 years ago
John Ralls	8db8105850	[c++options] Warn when an option variant type's set_value isn't found.	3 years ago
John Ralls	83829e6513	Merge branch 'maint'	3 years ago
John Ralls	1020bde89c	Fix crashes in test-engine on Arch Linux. ... Root cause is mutating a list while it's iterating. We're able to protect it in two cases, have to copy it in xaccTransScrubGainsDate.	3 years ago
Geert Janssens	d75ab275f1	Eliminate gnc-csv-account-map.[ch] ... The code is was only used by the csv import assistant and forced gtk as a dependency on gnc-imp-props-tx Part has been moved to Account, other bits have been moved to the importer code where they were used.	3 years ago
Geert Janssens	13ec4bb594	xaccParseAmount... - some code cleanups ... - declare at first use - compact tests - reduce use of {}	3 years ago
Geert Janssens	8010d9646c	Restore proper indentation ... It got mixed up while refactoring the various xaccParseAmountXYZ functions	3 years ago
John Ralls	07d8ebd90c	Add JSON::Parse to gnc-fq-update. ... Required by finance-quote-wrapper to interpret quoter output.	3 years ago
Richard Cohen	329a2f7d42	Guard against some possible null pointer dereferences ... Found by gcc 12 when compiling with "-O2 -Wnull-dereference"	3 years ago
Richard Cohen	3a7464a312	Remove redundant uses of cmake -E env ... - In GncAddTest, set_tests_properties() is already setting the env - In the other uses, there is no change to the environment	3 years ago
John Ralls	cdb674ebf1	[c++options]Really fix the gnc_option_db_lookup_string_value leak ... By deleting the function and using GncOptionDbImpl::lookup_string_option directly. It returns a string that we don't have to worry about memory-managing. Also create a new GncOptionDbImpl::set_string_option to replace gnc_option_db_set_string_value.	3 years ago
John Ralls	92071e8844	[c++options] Fix leak.	3 years ago
John Ralls	f735c64cac	Merge Richard Cohen's 'extern-c-part2' into master.	3 years ago
Richard Cohen	7b47c07f8e	Don't use extern "C" around #includes ... Some I missed the first time. Some are new.	3 years ago
Frank H. Ellenberger	bdb12fd94f	I18N: Change TaxTable to "Tax Table" for consistency	3 years ago
John Ralls	bbfa378783	Don't crash and do pass tests.	3 years ago
John Ralls	af02dae286	Fixups for merging into master instead of maint.	3 years ago
John Ralls	1eecb9f5c0	[c++ options] Fix locale dependency in test-gnc-option-scheme-output. ... Created by using std::to_string() in GncOptionRangeValue::serialize. It wraps sprintf that reads the locale. Use ostringstream instead.	3 years ago
Christopher Lam	76014f18a0	[account.cpp] don't cache char* [fails]	3 years ago
Christopher Lam	3d381eb6fd	[gnc-lot] don't cache char*	3 years ago
Christopher Lam	50f998fad8	[gncInvoice] don't cache char*	3 years ago
Christopher Lam	c9dc71978b	[gnc-commodity] don't cache char*	3 years ago
Christopher Lam	57fcaabd8f	[Split.c] don't cache char*	3 years ago
Richard Cohen	be41bde58a	Add missing MAKE_LINKS, and the local scm directory to %load-path ... Before this change, "make check" would fail after rm -rf ${build}/share/guile/site/*/gnucash/	3 years ago
John Ralls	675d894128	Merge Richard Cohen's 'cleanup-options' into master.	3 years ago
John Ralls	ca73b00039	Merge Richard Cohen's 'cleanup-boost' into master.	3 years ago
John Ralls	3d5e27982f	Merge branch 'maint'	3 years ago
John Ralls	7f0353adc4	Fix a missed g_value_dup_string and some no longer used variables.	3 years ago
John Ralls	8a7c539258	Bug 798748 - Transaction Notes field's value does not appear in... ... reverse transaction. The proximate cause was that xaccTransBeginEdit put the KVP cache variable of the new transaction in a state that prevented the value from being copied. More generally the KVP cache variables didn't handle any invalidating events. With the change to GValue usage in qof_instance_get_kvp it's now a simple memory dereference with no copying except for POD types so caching is no longer useful. This commit removes caching from Transaction, eliminating the notes problem.	3 years ago
John Ralls	ddc3f28899	[kvp] Use static strings and boxed in gvalue_from_kvp_value. ... Saves allocating and copying complex values, avoiding potential memory leaks.	3 years ago
Richard Cohen	9f06859390	Remove references to old boost versions ... we already require 1.67	3 years ago
Richard Cohen	3d995de2ab	Refactor: use default GncOptionValue copy constructor	3 years ago
Richard Cohen	1b0af4246a	Refactor: remove extra template parameter from member functions	3 years ago
Richard Cohen	87c52f53fa	Update some references to hello-world.scm	3 years ago
Richard Cohen	ec169e6e24	Fix some non-translatable typos	3 years ago
Christopher Lam	47b85d3b2f	[gnc-xml-backend.cpp] g_free char* from g_path_get_dirname	3 years ago
Christopher Lam	89e2bef427	Merge branch 'maint'	3 years ago
Christopher Lam	89e63ef672	Bug 798754 - Build fails with gcc 13 and glib > 2.76, ter	3 years ago
John Ralls	6ab7b16d62	[c++options] Restore the ability to set plot sizes in pixels. ... Enable and fix the previously untested GtkOptionGtkUIItem::PLOTSIZE. This has the potentially unfortunate side effect that integer range options are assumed to be plot sizes. That's correct for now, but if some report comes along that needs an integer range option for something else it will have to be differentiated.	3 years ago
Christopher Lam	abcce5000c	Bug 798754 - Build fails with gcc 13 and glib > 2.76, bis	3 years ago
Geert Janssens	26482f397b	Bug 797033 - The CSV Importer should not obey with the "automatic digital point" setting ... Expose variations of xaccParseAmount and xaccParseAmountExtended that will ignore the automatic decimal point user preference. This preference is really only useful for manual number entering in the register. The xaccParseAmountImport variant replaces xaccParseAmountPosSign which was used exclusively by the csv importers. Like xaccParseAmountPosSign, this replacement has the flag to ignore or parse the positive number indicator.	3 years ago
Frank H. Ellenberger	fcbda57a6b	Merge branch 'maint'	3 years ago
John Ralls	184669f517	Bug 798754 - Build fails with gcc 13 and glib > 2.76 ... GLib 2.76 introduced a no-discard warning on g_string_free if the second parameter is FALSE. This revealed a string leak and a correct usage that didn't use the return value.	3 years ago
Geert Janssens	549c93e005	Fix test for import-backend ... Another split function needed mocking	3 years ago
Richard Cohen	bddb4468fa	Import GLIB2 as a target, and use it to simplify the CMakeLists	3 years ago
Robert Fewell	ec7cc27d6d	Add tests for default invoice report book property	3 years ago
Robert Fewell	76f0e3a97e	Add some PWARN messages to the default invoice report ... book functions	3 years ago
Geert Janssens	8a23304283	GncGSettings - use bool as return type for static function	3 years ago
Geert Janssens	64329414e9	GncGSettings - cosmetic: NULL->nullptr	3 years ago
Geert Janssens	32ae47980c	GncGSettings - some minor cleanups ... - remove unused macros - avoid manual counters	3 years ago
Geert Janssens	03aff5642a	GncGSettings - rework signal handler manipulation ... Use ref-counting to manage GSettings object lifecycle Use g_signal_handler_handlers_[un]block_matched to block or unblock handlers rather than tracking them in our own hash table.	3 years ago
Geert Janssens	4761aa414c	GncGSettings - reduce code duplication ... Most getters and setters are identical with the exception of the actual function to call into GSettings. Extract boilerplate in two template functions and make all getters/setters wrappers of these two functions.	3 years ago
Geert Janssens	edab41f23a	GncGSettings - basic c++ cleanups ... - declare at first use - gboolean->bool (TRUE/true, FALSE/false)	3 years ago
Robert Fewell	a1d17518a8	Add a function to dump the schema entries when in debug ... mode.	3 years ago
Robert Fewell	2306ef8ca6	On a new install, the gnc_gsettings_version_upgrade ... would not run When doing a new install, set the GNC_PREF_VERSION to the current version.	3 years ago
Robert Fewell	57f874bd3f	Change the behaviour of the gseettings migration ... function In the pref_transformations.xml file, when the release version is greater than the current GnuCash version, do not process those changes.	3 years ago
Robert Fewell	ac0532bf5c	Change the alignment of a function in gnc_gsettings.cpp	3 years ago
Robert Fewell	308c609904	Fix comment typo in gnc-gsettings.cpp	3 years ago
Geert Janssens	286e1afa41	Bug 798749 - Fails to read gsettings on startup ... Only cache GSettings objects we need to keep track of callback functions. This means a bit more overhead per GSettings interaction, but as typical interactions are only a few objects at once at best, this overhead is unnoticeable.	3 years ago
Richard Cohen	9c6ad222a9	[-Wunused-function] - remove	3 years ago
Richard Cohen	4eb022c7a2	[-Wunused-variable] - remove	3 years ago
Richard Cohen	8a20bcadb0	[-Wunused-variable] - remove unused translatable string	3 years ago
Richard Cohen	0dd406de10	[-Wunused-lambda-capture] (clang) - remove	3 years ago
Richard Cohen	0f3813e0fd	[-Wunused-private-field] (clang) - remove ... In file included from gnucash/gnome-utils/dialog-options.cpp:34: gnucash/gnome-utils/dialog-options.hpp:55:10: warning: private field 'toplevel' is not used [-Wunused-private-field] bool toplevel; ^ In file included from gnucash/import-export/csv-imp/gnc-imp-props-price.cpp:42: gnucash/import-export/csv-imp/gnc-imp-props-price.hpp:113:10: warning: private field 'created' is not used [-Wunused-private-field] bool created = false; ^ libgnucash/backend/dbi/gnc-dbisqlconnection.cpp:53:29: warning: private field 'm_conn' is not used [-Wunused-private-field] const GncSqlConnection* m_conn = nullptr; ^ libgnucash/backend/sql/test/utest-gnc-backend-sql.cpp:81:33: warning: private field 'm_conn' is not used [-Wunused-private-field] const GncMockSqlConnection* m_conn; ^	3 years ago
Richard Cohen	d4dfe4e279	[-Wunused-local-typedef] - remove ... libgnucash/engine/test/utest-Account.cpp:2414:11: warning: typedef ‘using AcctTypeType = struct std::underlying_type<GNCAccountType>’ locally defined but not used [-Wunused-local-typedefs] 2414 | using AcctTypeType = std::underlying_type<GNCAccountType>; | ^~~~~~~~~~~~	3 years ago
Richard Cohen	0798bce2a6	[-Wunused-value] - remove ... borrowed/jenny/jenny.c: In function ‘next_builder’: borrowed/jenny/jenny.c:1164:5: warning: statement with no effect [-Wunused-value] 1164 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c:1172:5: warning: statement with no effect [-Wunused-value] 1172 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c: In function ‘confirm’: borrowed/jenny/jenny.c:1797:7: warning: statement with no effect [-Wunused-value] 1797 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ borrowed/jenny/jenny.c:1805:7: warning: statement with no effect [-Wunused-value] 1805 | for (i; i<n-1; ++i) { /* reset all less significant positions */ | ^~~ libgnucash/backend/xml/io-gncxml-v2.cpp: In function ‘gboolean qof_session_load_from_xml_file_v2_full(GncXmlBackend*, QofBook*, sixtp_push_handler, gpointer, QofBookFileType)’: libgnucash/backend/xml/io-gncxml-v2.cpp:806:40: warning: value computed is not used [-Wunused-value] 806 | g_thread_join (thread) != nullptr; | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp: In function ‘void xaccFreeAccount(Account*)’: libgnucash/engine/Account.cpp:1428:17: warning: statement has no effect [-Wunused-value] 1428 | priv->color == nullptr; | ~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1429:22: warning: statement has no effect [-Wunused-value] 1429 | priv->sort_order == nullptr; | ~~~~~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1430:17: warning: statement has no effect [-Wunused-value] 1430 | priv->notes == nullptr; | ~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/Account.cpp:1431:18: warning: statement has no effect [-Wunused-value] 1431 | priv->filter == nullptr; | ~~~~~~~~~~~~~^~~~~~~~~~ libgnucash/engine/gnc-int128.cpp: In function ‘void decimal_from_binary(uint64_t*, uint64_t, uint64_t)’: libgnucash/engine/gnc-int128.cpp:898:36: warning: right operand of comma operator has no effect [-Wunused-value] 898 | d[3] = (hi >> 32) & bin_mask, 0; | ^	3 years ago
Richard Cohen	bd8e81f35c	Move an unused variable into an #ifdef where it is used	3 years ago
Richard Cohen	1c6679720b	Use some unused variables	3 years ago
Richard Cohen	78ec20515b	Remove some unused variables - and the initialization ... - checked that any side effects were irrelevant	3 years ago
Richard Cohen	c819b03a17	Remove some unused variables - leave the side effect	3 years ago
Richard Cohen	ea2d3be217	Remove some unused variables with obviously no side effects	3 years ago
Richard Cohen	4e25bbfc43	Mark some QofLogModules as potentially unused ... - __attribute__((unused)) for C - [[maybe_unused]] for cpp	3 years ago
Robert Fewell	45a07463fb	Change max timeout to 20 seconds for default invoice report	3 years ago
Christopher Lam	85c2491664	Merge branch 'maint'	3 years ago
Geert Janssens	60209a766f	Merge branch 'csv_import'	3 years ago
Geert Janssens	2d8bb6f62f	Bug 796955 - Import CSV - Single-line two-currency transactions can't be imported ... Behaviour is as follows: If single line provides a price And at some point in the import process we get into a situation where the base account and transfer account have a different commodity Then transfer_acct amount = base_acct amount * price If on the other hand base_acct and transfer_acct turn out to have the same commodity, price is ignored.	3 years ago
Geert Janssens	99506d331a	Reduce GncImportMatchMap to just the account ... There is no added value in storing the book and account together The book is easily retrieved from the account (as was illustrated in the gnc_account_imap_new function). I looked through the commit history to understand why this struct was originally created and a long time ago it also had a reference to a kvp frame.	3 years ago
Geert Janssens	51706f289c	Minor corrections in comments	3 years ago
John Ralls	7bb14b9caa	Merge Richard Cohen's 'use-reference-for-loop' into master	3 years ago
Robert Fewell	07f3f536cc	Allow to select saved report on print invoice button ... This change was inspired by mildred's #PR1247 and uses the new GncReportCombo to allow selection of 'Saved Invoice reports' when the invoice print button is used or when printing multiple invoices. This change presents a dialog with the default for the report combo set to the properties setting. This dialog has a timeout which is adjustable under properties and will stop if a key is pressed or combo popped so that a different report template can be selected and used. There is also an 'OK' button that stops the time out and prints and a 'Cancel' button which cancels the print.	3 years ago
Robert Fewell	019214f1c2	Bug753307 - Custom Report be selectable as default Report for Printing ... This commit changes the preference in Business->'Report for Printing' to be saved as a book property and allow the selection of any Invoice Report to be used as the default.	3 years ago
Richard Cohen	d8f45f2443	Use const references for for-loops to avoid unnecessary copies ... Found by clazy - clazy-range-loop-reference	3 years ago
John Ralls	ce3447e6ea	Bug 798740 - Build fails with gcc 13 ... Protect against passing an lseek failure rv to read().	3 years ago
Christopher Lam	119356752f	Merge branch 'maint'	3 years ago
Geert Janssens	894f8241e1	Revisit invoice payment in multi-currency context ... - Show proper amount in dialog when applying or editing an existing transaction as payment - Be more careful not to waste the existing payment split - If the user changed the payment amount while starting from an existing transaction unreconcile the changed payment split - Avoid needlessly changing transaction currency (only do so if the user chose a new transfer account and the old currency is neither the new transfer account's currency nor the post account's currency)	3 years ago
John Ralls	44f4b55927	Merge Richard Cohen's 'fix-memleaks' into master.	3 years ago
Richard Cohen	846e75146a	Fix some typos so that the correct tests are run ... - test_gnc_txn_to_float_txn_cut_semantics - test_dbi_business_store_and_reload	3 years ago
Richard Cohen	a2ffc7fe75	Fix memory leak in binreloc function _br_find_exe() ... Ironically, it seems to be in a code path that is only followed when using valgrind	3 years ago
luzpaz	67ab9e90d2	Fix some typos	3 years ago
Christopher Lam	17820ec261	Merge branch 'maint'	3 years ago
John Ralls	f4c6d65395	Merge Bob Fewell's 'nofree' into maint.	3 years ago
John Ralls	f6919e60a7	Merge Richard Cohen's 'cleanup' into master.	3 years ago
John Ralls	46f9fb01c9	Simplify gnc_commodity equality and compare functions. ... gnc_commodity_compare is used for sorting and so needs to have a less-than return value. The only place it's used presents nothing to the UI; a GncGUID ordering is fast and stable. GnuCash allows only one commodity per book for any namespace/mnemonic pair, so the exhaustive string comparisons are superflous. While the current engine design allows only one instance of any object, meaning that a pointer comparison is sufficient to determine equality, that may not be true in the future, but the GncGUID is guaranteed to sufficiently identify a single commodity. Note that gnc_commodity_equiv is used to enforce that single-commodity rule and so cannot use GncGUID comparison.	3 years ago
Richard Cohen	6927535a0a	Remove unused test function get_object_is_initialized in qofobject.cpp	3 years ago
Richard Cohen	925fcbc3fd	Remove unused gnc-jalali.{c,h}	3 years ago
Richard Cohen	e83c91050c	Remove unneeded dummy.cpp	3 years ago
Richard Cohen	d6ac56ce5f	Re-enable -Waddress - gncInvoiceLookup etc. are now inline functions, not macros ... - Remove outdated comments	3 years ago
Richard Cohen	3360a6d13b	Remove extra semicolons ... Courtesy of gcc -pedantic	3 years ago
John Ralls	046e4a156e	Silence Clang deprecation warnings about sprintf.	3 years ago
John Ralls	dd2497416c	Merge Richard Cohen's 'internal-extern-c' into master.	3 years ago
John Ralls	60c06debce	[c++options] Don't crash when find_option returns nullopt.	3 years ago
Richard Cohen	1cec0cb3f3	Use internal extern "C" { ... } for C++ ... - removes warnings compiling swig engine ... [ 10%] Generating swig-engine.cpp .../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored), .../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'. .../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++". .../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".	3 years ago
Richard Cohen	19bbde7000	Fix some typos	3 years ago
John Ralls	432f2d4bb8	Merge Richard Cohen's suppress-boost-warning into master.	3 years ago
John Ralls	9a1a90d8d0	Merge branch 'maint'	3 years ago
richardcohen	f3cc223f5f	Fix some bad code formatting	3 years ago
richardcohen	8044f79f75	Silence the boost (<1.76) warning message ... from .../gnucash-4.8/libgnucash/app-utils/gnc-quotes.cpp:33: /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’ The issue was fixed in boost 1.76, but, e.g ubuntu 22.04 has boost 1.74	3 years ago
Christopher Lam	fd007a0af1	Merge branch 'maint'	3 years ago
Robert Fewell	6df866f876	Add tests for the reconcile account functions	3 years ago
Robert Fewell	fd37ee997d	Fix getting xaccAccountGetReconcilePostponeBalance ... Change the G_VALUE from a INT64 to BOXED.	3 years ago
John Ralls	fb9947b7b6	Rename GncDateTime's ymd to gnc_ymd to avoid a name conflict with Carbon.	3 years ago
John Ralls	fed4daf4e7	[c++ quotes] Make sure to include all of the required Boost libraries. ... Also Boost-iostreams needs winsock but doesn't tell Cmake, so explicitly add it to the link list.	3 years ago
Christopher Lam	c65b36490a	Merge branch 'master-progress'	3 years ago
Frank H. Ellenberger	506a1b3c5e	Merge branch 'maint'	3 years ago
Alex Aycinena	1085d8920b	Update Form/Schedule line references for 2022 for the US Income Tax Report	3 years ago
John Ralls	b922cfd78d	Bug 798679 - Unicode normalization should be used for comparison but not stored. ... Change to NFC normalization for all comparisons because the Unicode meaning of compatible might collide with the user's intent.	3 years ago
John Ralls	31d79e3004	Merge Bob Fewell's 'bug798673' into master.	3 years ago
John Ralls	5c17950a59	Merge Bob Fewell's 'mainwin2' into master.	3 years ago
Christopher Lam	259881f940	[gnc-optiondb] add some more renamed options ... following ab13b01f8c Replace ... with … in all translatable strings.	3 years ago
John Ralls	ab13b01f8c	Replace ... with … in all translatable strings. ... Also a few other places like translator comments and report options. Replaces https://github.com/Gnucash/gnucash/pull/1033.	3 years ago
Geert Janssens	734f90bd36	Replace string literal 'gnucash' with PROJECT_NAME parameter where it makes sense ... The idea behind this is to not assume the project is always built as "gnucash" exactly. One example where it can be useful to use a different project name would be when building multiple development versions of the project on the same system and don't want these different versions share the same settings in GSettings or the same stored passwords.	3 years ago
John Ralls	b8c0673526	Merge branch 'maint'	3 years ago
Robert Fewell	7536fcaf2f	Change the balance limit icon if both limits are zero ... When higher and lower limits are zero, when used for a a suspense account, change the icon to 'dialog-warning'. This type of use is to indicate that a non zero balance exists.	3 years ago
John Ralls	091d4aff22	Bug 798657 - Import Summary language is wrong ... Root cause is using boost::locale::translate because it ignores the LANGUAGES environment variable and doesn't support different values for LC_MESSAGES, LC_DATE, LC_MONETARY, and LC_NUMERIC. That makes it impossible to configure a user environment that presents translated strings in a different locale from the one applied to formatting dates and numbers. To correct this replace all use of boost::locale::translate with GNU gettext.	3 years ago
Robert Fewell	3be25ff0a9	Add some tests for the account functions	3 years ago
Robert Fewell	a15c6f81b3	Allow the balances of sub accounts to be used in limits	3 years ago
Robert Fewell	60ab654d2b	Add account balance test functions to gnc-ui-balance	3 years ago
John Ralls	73a134730f	Bug 798680 - Not able to match a reverse transaction of a... ... previously matched transaction. Cloned transactions and copied splits shouldn't keep the online-id slot.	3 years ago
John Ralls	b4bab92da2	Bug 798664 - Result of 'gnucash --nofile' is marked dirty ... Don't create a new book in the new-user dialog unless the user says to. Don't automatically create a new book when retrieving default commodities because the retrieve might be requested in a context like the Preferences dialog when there is no book. Some report tests relied on requesting the default commodity creating the book, so in those tests ensure that the book is created first.	3 years ago
John Ralls	fae5de80d3	Undo unintended change in Bug 798679 commit.	3 years ago
John Ralls	fd2761bd68	Bug 798679 - Fullwidth characters cannot be pasted as-is in register fields ... Control character check doesn't need normalization, the control character codepoints aren't graphic and so can't be composed nor have compatible equivalents.	3 years ago
Robert Fewell	518ecfe041	Add some functions that would allow adding a balance limit to accounts	3 years ago
Geert Janssens	98251d59a6	Bug 798672 - Preferences are not saved nor loaded, ERROR <GLib-GIO> g_settings_new_full: assertion 'schema != NULL' failed ... Apparently it was a failure on our side to properly look up requested gsettings schema.	3 years ago
Christopher Lam	bfc325f63c	Merge branch 'maint'	3 years ago
Marco Scardovi	6fe2028bca	Fix test ... Signed-off-by: Marco Scardovi <mscardovi@icloud.com>	3 years ago
Robert Fewell	59d95a4ce6	Bug 798545 - Crash when updating document link on vendor bill ... There were two issues here, the first one was that the copied doclink was pointing to the original doclink which lead to a double-free. The second is the setting of the doclink on the copied invoice needs to be done with gncInvoiceSetDocLink otherwise on closure the doclink value will disappear.	3 years ago
Christopher Lam	3d8a28898d	[gnc-budget] gnc_budget_get_account_period_note returns a const ... to harmonize with all other char getters	4 years ago
Christopher Lam	2ee0c98200	[gnc-budget] use operator[] instead of find() and insert() ... - avoid hashing Account* twice. one call to operator[] is sufficient. - don't need use std::move with better constructors - sanity check - can't have a budget with num_periods = 0 - remove unused headers	4 years ago
Christopher Lam	3e5fcc8709	Merge branch 'maint'	4 years ago
Robert Fewell	4f8643674b	Remove all references to GncDisplayItem	4 years ago
Robert Fewell	078d7875d3	Change all references to plugin_class->actionsb ... Change all references to plugin_class->actionsb and n_actionsb to plugin_class->actions and n_actions	4 years ago
Christopher Lam	6f80c548e6	[gtest-qofevent.cpp] comprehensive tests for qofevent	4 years ago
Christopher Lam	05ffd3d4eb	[budget-feature] move unset_feature call to gnc_budget_gui_delete_budget ... because gnc_budget_gui_delete_budget is a more general function to delete a budget.	4 years ago
Christopher Lam	b87aa004f9	[test-qofbook] add tests for unknown features ... tests that gnc_features_test_unknown returns a suitable error message	4 years ago
Robert Fewell	0f70143c55	Initial change to plugin source files	4 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	4 years ago
Christopher Lam	fc94b41c81	Merge branch 'maint'	4 years ago
Christopher Lam	4716af24e4	Merge branch 'maint'	4 years ago
Christopher Lam	ba44f720c1	Merge branch 'maint'	4 years ago
Christopher Lam	f2354d6b2a	[test-qofbook.c] add test for gnc_features_set_unused	4 years ago
Christopher Lam	1516bb18b0	[gnc-features.cpp] backport gnc_features_set_unused from master	4 years ago
Christopher Lam	a078921a33	[qofbook.cpp] backport qof_book_unset_feature from master	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
Christopher Lam	093aa81ed1	[qofbook.cpp] deprecate qof_book_get_features	4 years ago
Christopher Lam	8192deff37	[gnc-features.cpp] convert to cpp ... - don't need to create/destroy GHashTable for each feature query - plugs leak: g_hash_table_unref (features_used) not always called properly - to check 1 feature, don't need to traverse whole GHashTable	4 years ago
Christopher Lam	6f6d2fef48	[test-qofbook] basic features test ... sets a feature and tests it's set. it's impossible to design a book with unknown features using the API.	4 years ago
John Ralls	14a0ea4ed3	[price-quotes] Sort and format source list.	4 years ago
John Ralls	1a906b00aa	[price-quotes] Enable gnucash-cli to retrieve preferences on macOS. ... By embedding a minimal Info.plist with a bundle ID into the executable. This necessitated a change to binreloc because the unix-style install depended on there being a bundle ID only when the program was run from an application bundle.	4 years ago
John Ralls	2767587874	[price-quotes] Fix setting alphavantage API key.	4 years ago
John Ralls	939a77407c	Merge branch 'price-quotes-cpp'	4 years ago
John Ralls	7f2a09a69f	[price-quotes] Handle short error strings from finance-quote-wrapper. ... This keeps the translation work in GnuCash and improves the error signalling in gnc-quotes.	4 years ago
John Ralls	fe9b23ff2b	[price quotes] Pass short errors to gnc-quotes. ... And wordier but not translated messages when STDERR is a tty.	4 years ago
John Ralls	88d658fef0	[price-quotes] Date::Manip is no longer required.	4 years ago
John Ralls	50c72b4f88	[price-quotes] Remove m_ready and usable() from GncQuoteSource. ... GncQuoteSource ctor throws if something is wrong so usable is always true.	4 years ago
John Ralls	7d93774dd2	[price-quotes] Throw instead of returning if there aren't any commodities to quote. ... So that the user gets sees an error instead of silent failure.	4 years ago
John Ralls	81d4ea9550	[price-quotes] Remove F::Q version format check. ... We don't care what the version string looks like as long as there is one.	4 years ago
John Ralls	c78fe37ff7	[price-quotes] General typo fixes and code cleanup.	4 years ago
John Ralls	70c9d4c9e3	[price-quotes] Fix version retrieval. ... Plus there's no need for a "not found" version string because GncQuotes construction will throw if Finance::Quote isn't correctly installed. No object, nothing to call version() on.	4 years ago
John Ralls	97e730b8d8	[price-quotes] Reformat test quote response strings to one line per quote.	4 years ago
John Ralls	f24c2c8bdd	Instrument failure to set the account when creating a split.	4 years ago
Mike Alexander	3c306eae65	Merge branch 'maint'	4 years ago
Mike Alexander	2d3e80ea08	Compatibility with XCode's "new build system" ... With XCode 14 or newer CMake tries to use the "new build system" which has a requirement that if two targets depend on the same generated file one of them must depend on the other. This commit adds reduntant dependencies to satisfy this requirement.	4 years ago
John Ralls	c7d1b6ab26	Bug 798633 - 4.12 build failure on 32-bit Linux: "No code for module"	4 years ago
John Ralls	673a925554	[price-quotes] Remove superseded gnc-fq-dump and Quotes-example.pl	4 years ago
John Ralls	e817091de1	[price-quotes] Warn only once if the AlphaVantage Key isn't set. ... And check the environment if it's not in preferences.	4 years ago
John Ralls	d97ea77762	[price quotes] Add report member function to display quote information to stdout. ... Instead of creating price instances in the database.	4 years ago
John Ralls	6ffb0bb633	[price-quotes] Report quote fetch failures to the user.	4 years ago
John Ralls	4c47e91180	[price-quotes] Implement error codes for currency and quote failures.	4 years ago
John Ralls	6db7800ca5	[price-quotes] Doxygen docs.	4 years ago
John Ralls	29ce925646	[price-quotes] Test the other fetch overloads and quote values.	4 years ago
John Ralls	b5bc6463a3	[price-quotes] Rework date-time handling. ... A check of the F::Q modules found that the only ones that return a quote time return a bogus one and do so only to mollify GnuCash. Since there's no good way to determine the TZ of the exchange originating the quote there's no good way to decide if the quote is current or from a previous market session, so we just punt and use a time of 16:00 for all quotes.	4 years ago
John Ralls	19064093d2	[price-quotes] Remove m_comm_vec and m_fq_answer. ... Passing the intermediate values comm_vec and quote_str on the stack instead.	4 years ago
John Ralls	734fb6ce2a	[price-quotes] Switch error handling to exceptions. ... Allows for cleaner code with less state, less coupling of the GncQuotes class, and better transfer of error messages to client code. Also translates some error messages for presentation to users.	4 years ago
John Ralls	d307295076	[price-quotes] Paramaterize GncMockQuoteSource construction. ... So we can have different results passed back for different tests.	4 years ago
John Ralls	2b87066687	[price-quotes] Extract some static functions. ... To get GncQuoteImpl::parse_one_quote to a reasonable size.	4 years ago
John Ralls	a82c72cfb9	[price-quotes] Remove level of indirection when parsing quote data.	4 years ago
John Ralls	37dfab7f31	[price-quotes] Convert long quote parsing lambda to a regular function. ... To begin separating price parsing from inserting in the price db.	4 years ago
John Ralls	dd8316714b	[price-quotes] Extract function GncQuotesImpl::comm_vec_to_json_string.	4 years ago
John Ralls	e3ab384504	[price-quotes] Log messages instead of writing them to std::streams.	4 years ago
John Ralls	b8642e55d9	[price-quotes] Implement mock quote source. ... Note that because the non-default constructor exists only on GncQuotesImpl we must use that directly and violate the pimpl.	4 years ago
John Ralls	4dd3922871	[price-quotes] Make wiggle test conditional on F::Q being installed.	4 years ago
John Ralls	784aca5a4c	[price-quotes] Extract class GncQuoteSource. ... Provide a specialization GncFQQuoteSource and move the F::Q command construction and query functions to GncFQQuoteSource. This allows for dependency injection to provide testing that doesn't need F::Q to be installed.	4 years ago
John Ralls	e9577b7996	[price-quotes] Basic wiggle test.	4 years ago
Geert Janssens	277f299ad6	GncQuotes - cleanups ... - make more use of auto - mark user visible strings as translatable - return early on input errors - fix date conversion fallback to actually fall back to today	4 years ago
Geert Janssens	585de5d134	GncQuotes - break actual interaction with Finance::Quote out into a separate function query_fq ... That allows for later reuse and easier testing.	4 years ago
Geert Janssens	70ab8a8a46	GncQuotes - drop parameterized constructor ... The book parameter is only needed while fetching quotes. In case the user passes one or more commodities to process the book can be readily derived from the commodity/commodities. In the other case (fetch all quotes) the user now is required to pass a book to the call.	4 years ago
Geert Janssens	4c2863966b	GncQuotes - rename fetch_all to be an overload of fetch ... And add a third overload to fetch only a single quote	4 years ago