198 Commits (stable)

Author	SHA1	Message	Date
Christopher Lam	2b7043b4ba	[reports] use gnc_date_interval_format	6 days ago
John Ralls	79b43fb4f6	Guile: Use the right conversion for size_t.	1 month ago
John Ralls	6dc106ff08	SRFI-64 test-equal no longer considers exceptions equal to #f. ... So convert test that raise an exception to test-error with the exception type.	2 months ago
John Ralls	01f1d75198	Fix missing or incorrect expected exception test failures. ... The new SRFI-64 implementation doesn't convert a missing expected exception nor the symbol 'error to mean any exception. Use #t to mean any exception.	2 months ago
John Ralls	e618b98950	Show the full test result alist on failure if expected value isn't defined. ... With the new SRFI-64 implementation tests are failing without setting expected and actual values on the test result. Dump the test-result-alist to get more information.	2 months ago
Richard Cohen	647d3b7221	Make a link in the build directory for options.scm	3 months ago
Christopher Lam	8846ff4605	[test-engine-extras] add invoice IDs to test invoices	6 months ago
Christopher Lam	b0c60fb310	[reports] use ICU for Unicode string comparison	8 months ago
Christopher Lam	c01cccbddc	[gnc-engine-guile.cpp] helper gnc_split_to_scm function	9 months ago
Christopher Lam	b219744dba	[gnc-engine-guile] reduce overhead of gnc_foo_to_scm ... by caching the result of SWIG_TypeQuery(typestr)	9 months ago
John Ralls	b5b2221e72	Test gnc-option-date variable fy start days. ... Leverages the FakePrefsBackend from the previous commit to change the fiscal year for testing. Makes now_t a defaulted parameter of gnc_relative_date_to_time64 so that we can inject different reference dates for testing.	11 months ago
John Ralls	0185a2fec8	Bug 799533 - Saved reports configurations are opening with… ... No Accounts selected error Revert "[gnc-optiondb.i] don't add null accounts"	11 months ago
John Ralls	218aa4ad87	Fix test-gnc-option-scheme-output to match fix for bug 799501.	11 months ago
John Ralls	2f0ed09bf1	Bug 799501 - Gnucash grashes on startup ice-9/read.scm error ... Correctly format ("'~s" instead of "'~a") the scheme string returned from gnc_query2scm.	12 months ago
Christopher Lam	5661c45d2a	gnc_commodity_table_get_namespaces must be g_list_freed	1 year ago
David Seifert	c06bc18dc4	Add missing `#include <cstdint>` ... * GCC 15 has reduced transitive dependencies between headers. Bug: https://bugs.gentoo.org/939856	1 year ago
Christopher Lam	664b1cb77a	[gnc-optiondb.i] instead of scm_list_ref, walk the list	2 years ago
Christopher Lam	3e5d6a510b	[gnc-optiondb.i] don't add null accounts	2 years ago
Geert Janssens	1def3ce8fd	Cleanup - remove deprecated function (re-)defines ... They were deprected 11 years ago	2 years ago
Geert Janssens	39aa5f9c09	Remove texi design document in engine ... It's extremely out of date and we no longer use it to keep track of our design decisions and suggestions. Only a section on KVP policy has been move into kvp_doc.txt as it may make sense there.	2 years ago
Christopher Lam	8fb5a6afd6	Fix tests so that they don't fail unnecessarily ... - test-begin/test-end names must be consistent - remove empty test group in test-scm-engine	2 years ago
John Ralls	e22a57ad26	Merge John Ralls's 'asan' into stable.	2 years ago
John Ralls	d92d97aef6	Add Scheme coverage collection with option GUILE_COVERAGE. ... This can be used with or without COVERAGE, though if without the results will reflect only the Scheme code exercised by the tests.	2 years ago
Christopher Lam	d8ece96503	[gnc-engine-guile.cpp] plug runaway GSList* leak ... The QofQuery param_list is a GSList of const char*. Every SCM Query would typically leak the GSList. This change will store the params into the string cache, and the cached string is passed onto the QofQuery param.	2 years ago
John Ralls	e17ba3cc00	Fix UAF in xaccFreeSplit. ... xaccSplitComputeCapGains creates gains_split pointers in both the Cap Gains Split and its Income split to the original split, but the original's gains_split pointer can point to only one of them, the Cap Gains split. When the original split is freed both the Cap Gains split's and its Income split need their gains_split pointers NULLed or when it's the Income split's turn to be freed it will try to deref the dangling pointer.	2 years ago
Christopher Lam	550c43d13a	Merge branch 'free-guid-string' into stable #1777	2 years ago
John Ralls	a49fd0bc09	[c++options] Correctly implement handling Fancy Date Format. ... It's not a simple string.	2 years ago
Christopher Lam	8e21d3328f	guid_to_string should be freed.	2 years ago
Christopher Lam	75f6ee1817	[test-scm-engine] tests gnc-numeric-from-string	3 years ago
John Ralls	50418527b0	Fix two typos.	3 years ago
John Ralls	2e76d2f43d	Bug 799021 - Saved report renders default of gnc-register-list-option ... save_scm_value was trying too hard to handle the different possible types that Scheme can set options to and in the process converting lists to single symobls (e.g. ('good 'ugly) became #{good ugly}#. That not being one of the possible values it was ignored and the default value was used.	3 years ago
Christopher Lam	2a392633ed	Bug 798991 - Incorrect Account Name Order in Transaction Report ... gnc:string-locale<? uses glib instead of guile string compare	3 years ago
Richard Cohen	3957272ef0	Fix some typos in comments	3 years ago
Christopher Lam	56b75c3691	std::string cannot free() scm_to_utf8_string automatically	3 years ago
John Ralls	30cbf3074e	Fix misplaced static variable decl. ... Why this compiled is a mystery. Since empty wasn't captured it should have raised an unused variable for the outside the lambda declaration and an undeclared variable for the use inside. Only gcc 7 raised the first error and nothing noticed the second.	3 years ago
John Ralls	d8a3e83189	Fix test breakage from account list reversal.	3 years ago
John Ralls	634b9f8744	Bug 798810 - Income Statement (multicolumn) - account sorting is... ... 'reversed' each time you restart. Lists read from the front, vectors to the back, so reverse the vector after loading it. While we're at it reserve enough elements to hold the list.	3 years ago
Richard Cohen	9fa2a48fe1	Fix build on gcc-8 & 9. ... See https://lists.gnucash.org/pipermail/gnucash-devel/2023-March/046617.html	3 years ago
John Ralls	b4b8431984	Bug 798778 - GnuCashquits abruptly when attempting to edit options… ... for certain reports. Those reports being ones using complex options, apparently because the callbacks weren't protected from Guile's garbage collector. So replace the anyway ugly hack of a void* with a std::any wrapping a class holding a std::unique_ptr with a custom deleter. The constructor calls scm_gc_protect_object on the SCM containing the callback and the custom deleter calls scm_gc_unprotect_object. The copy constructor, required for std::any, makes a new std::unique_ptr and calls scm_gc_protect_object again ensuring that the protect and unprotect calls are symmetrical. Meanwhile std::any hides the Guile dependency from all the classes that don't need to know about it. The only ugliness is that there's no good place to put a common implementation of SCNCallbackWrapper so it's repeated in gnc-optiondb.i and dialog-options.cpp.	3 years ago
John Ralls	a44b3664e2	[c++options] Implement GncOptionGncOwnerValue class. ... GncOwners aren't QofInstances and have limited lifetimes so an option must hold its own, wrapped in std::unique_ptr for memory management.	3 years ago
Richard Cohen	329a2f7d42	Guard against some possible null pointer dereferences ... Found by gcc 12 when compiling with "-O2 -Wnull-dereference"	3 years ago
John Ralls	1341511edb	[c++options] Save an empty SCM string for nil or empty option values. ... Avoids crash at reload due to unknown variable.	3 years ago
John Ralls	1eecb9f5c0	[c++ options] Fix locale dependency in test-gnc-option-scheme-output. ... Created by using std::to_string() in GncOptionRangeValue::serialize. It wraps sprintf that reads the locale. Use ostringstream instead.	3 years ago
Richard Cohen	be41bde58a	Add missing MAKE_LINKS, and the local scm directory to %load-path ... Before this change, "make check" would fail after rm -rf ${build}/share/guile/site/*/gnucash/	3 years ago
Richard Cohen	ec169e6e24	Fix some non-translatable typos	3 years ago
John Ralls	408b5ec216	[c++ options] Restore forward & backward compatibility, fix crash. ... Store Number Range option values as a pair '(percentage . value) or '(pixels . value) depending on the size of value as 4.x and earlier expect. When reading a stored number range option handle the possibility that value is fixed point (e.g. 50.0) as 4.x and earlier emit, avoiding a crash.	3 years ago
Richard Cohen	bddb4468fa	Import GLIB2 as a target, and use it to simplify the CMakeLists	3 years ago
Christopher Lam	4d977a947a	[business-core] remove gnc:split->owner	3 years ago
Christopher Lam	d53f3e68d1	Merge branch 'maint'	3 years ago
Christopher Lam	4953cf94fa	[reports] use gnc:make-split->owner with guardian ... Instead of a gnc:split->owner, use gnc:make-split->owner instead which generates a split->owner function with its own hashtable. This function (and its hash table) will be garbage collected in due course, triggering the gncOwnerFreeing of all owners. This is a better approach than gnc:split->owner which maintains a single hash table. It could be buggy: a report calls gnc:split->owner to query a split, fails to reset its hashtable via #f; the split's owner is assigned or modified, and the next call to gnc:split->owner will return the incorrect cached owner.	3 years ago