29074 Commits (c99f5972dee6f62eaaf96ba74ab3cd4e71d19caa)

 

All Branches   

Search

Author	SHA1	Message	Date
Nick Fagerlund	c99f5972de	cloud.StateMgr(): Set terraform version AFTER creating workspace ... Previously, if the remote TFC/TFE instance doesn't happen to have a tool_version record whose name exactly matches the value of `tfversion.String()`, Terraform would be completely blocked from using the `terraform workspace new` command (when configured with the tags strategy) — the API would give a 422 to the whole create request. This commit changes the StateMgr() function to do the work in two passes; first create the workspace (which should work fine regardless), THEN update the Terraform version and print a warning to the terminal if it fails (which 99% of the time is a benign failure with little impact on your future CLI usage).	5 years ago
Chris Arcand	aace0015c2	cloud: Fix E2E variables test	5 years ago
Brandon Croft	64fbb0b613	remove reference to AccessInternalTools	5 years ago
Omar Ismail	1ff7827416	Multi-state migration prompt fix	5 years ago
Barrett Clark	cc6de251d8	Update init reconfigure error message ... If you move from the remote backend to the cloud block you will see this error message.	5 years ago
Chris Arcand	85f0bc6198	Update go-tfe to e52963e	5 years ago
Chris Arcand	12a4af3e72	Temporarily skip API version checking	5 years ago
Barrett Clark	e16c53b561	Simplify/Consolidate the cloud conditionals	5 years ago
Barrett Clark	ab304d831f	Found another path to backend init error ... There are actually a few different ways to get to this message. 1. Blank state — no previous terraform applied. Start with a cloud block. 1. Implicit local — start with no backend specified. This actually goes through the same code execution path as the first scenario. 1. Explicit local — start with a backend local block that has been applied, then change from the local backend to a cloud block. This will recognize the state, and is a different path through the code in the meta backend. This commit handles the last case. The messaging has also been tweaked. End to end test included as well.	5 years ago
Barrett Clark	d29532cfeb	tfc apply before init ... https://app.asana.com/0/1199201948575144/1201019450474843/f	5 years ago
Barrett Clark	e49f271eb5	Update copy for terraform init with cloud block	5 years ago
Omar Ismail	5ff2495ffa	Update HasResource to HasManagedResourceInstanceObjects	5 years ago
Omar Ismail	86f93a2cbc	Cloud UX test fixes	5 years ago
Chris Arcand	09d5b70b7a	command/meta_backend_migrate:Tweak multi-to-single To TFC copy	5 years ago
Omar Ismail	dfb4609be2	Backend State Migration from cloud to cloud. ... * Add test for tfc to tfc mgiration * Fix old tests, and remove unused code.	5 years ago
Barrett Clark	93bfcff61a	More Terraform Cloud UX changes ... * Update e2e tests to specify Terraform Cloud * Update more of the terraform command flow to specify Terraform Cloud	5 years ago
Barrett Clark	261a2b49d3	UX for terraform init that copies state to TFC	5 years ago
Barrett Clark	d04c01573c	Fix iterator in a couple of e2e tests	5 years ago
Barrett Clark	0cd9490838	PR Feedback: cleanup variable setter	5 years ago
Chris Arcand	f8256f6634	Update ux for "terraform init [-reconfigure]"	5 years ago
Omar Ismail	dc76bbee73	Backend State Migration: Add remote backend test	5 years ago
Omar Ismail	3fedd6898c	Backend State Migration to `cloud`: Multiple Workspaces ... * Handle when there are multiple workspaces migrating to cloud, using both the cloud name strategy and cloud tags strategy. * Add e2e tests	5 years ago
Nick Fagerlund	baa72ce235	Simplify logic flow: everything is a constraint ... Explicit version strings are actually also version constraints! And the special comparisons we were doing to allow a range of compatible versions can also be expressed as version constraints. Bonus: also simplify the way we handle version check errors, by composing the messages inline and only extracting the repetitive parts into a function.	5 years ago
Barrett Clark	83538fdd6b	Shift errors to error file, improve error text	5 years ago
Nick Fagerlund	9857097b34	Add tests for version constraints in workspace terraform-versions	5 years ago
Nick Fagerlund	b43daeaa8d	Cloud backend: accept version constraints from workspaces ... The cloud backend (and remote before it) previously expected a TFC workspace's `terraform-version` attribute to be either the magic string `"latest"` or an explicit semver value. But a workspace might have a version constraint instead (like `~> 1.1.0`), in which case the version check would blow up. This commit checks whether `terraform-version` is a valid version constraint before erroring out, and if so, returns success if the local version meets the constraint. Because it's not practical to deeply introspect the slice of version space defined by a constraint, this check is slightly less robust than the version comparisons below it: - It can give a false OK on open-ended constraints like `>= 1.1.0`. Say you're running 1.3.0, it changed the state format, and the TFE instance admin has not yet added any 1.3.x Terraform versions; your workspace will now break. - It will give a false not-OK when using different minor versions within a range that we know to be compatible, e.g. remote constraint of `~> 0.15.0` and local version of 1.1.0. - This would be totally useless with the pre-0.14 versions of Terraform, where patch releases could change state format... but we're not going back in time to add this feature to them anyway. Still, in the most common likely case (`~> x.y.z`), it'll complain at you (with an error you can choose to override) if you're not using the same minor version, and that seems proportionate, useful, and expected.	5 years ago
Brandon Croft	0bae48bc01	update to tfc-integration branch of go-tfe	5 years ago
Barrett Clark	83337de654	Remove prefix from the cloud backend config ... Now that we have tags we no longer need prefix.	5 years ago
Barrett Clark	edbc84420c	Run apply -refresh-state instead of refresh ... When a user runs `terraform refresh` we give them an error message that tells them to run `terraform apply -refresh-state`. We could just run that command for them, though. That is what this PR does.	5 years ago
Brandon Croft	bf02b5cb53	e2e test for cloud run variables	5 years ago
Brandon Croft	9963bf940a	refactor: only fetch variables if unset variables are not allowed	5 years ago
Omar Ismail	dd856f8a1b	Add run variables to cloud plan operations from non-file sources ... Run variables allow the run API to accept input variables not found in the configuration slug (the file-based ones plus workspace vars)	5 years ago
Brandon Croft	dbbfae5a1c	refactor ParseVariableValues into separate operations ... 1. ParseDeclaredValues: parses unparsed variables into terraform.InputValues 2. ProbeUndeclaredVariableValues: compares variable declarations with unparsed values to warn/error about undeclared variables	5 years ago
Omar Ismail	55fc590904	Teraform Cloud Backend State Migration ... * determining source or destination to cloud * handling single to single state migrations to cloud, using a name strategy or a tags strategy * Add end-to-end tests for state migration.	5 years ago
Chris Arcand	7cc53fe163	cloud: Set minimum TFE version ... These changes remove all of the preexisting version checking for individual features, wiping the slate clean with an overall minimum requirement of a future TFP-API-Version 2.5, which at the time of this writing is expected to be TFE v202112-1. It also actually provides that expected TFE version as an actionable error message, rather than generically saying that it isn't supported or using the somewhat opaque API version header.	5 years ago
Chris Arcand	46e47ed379	Use the 'tfe' service for everything. ... The 'tfe' service was appended to with various versions to denote a new 'feature' implemented by a new 'service'. This quickly proved to not be scalable, as adding an entry to the discovery document from every feature is bad. The new mechanism added was checking the TFP-API-Version header on requests for a version, instead. So we'll remove the separation here between different tfe service 'versions' and the separate 'state' service and Just Use TFE, as well as the TFP-API-Version header for all feature versioning., as well as the TFP-API-Version header for all feature versioning.	5 years ago
Chris Arcand	412679522d	Remove all constraint checking ... This is an outdated mechanism that isn't used anymore.	5 years ago
Chris Arcand	a4e196d067	Port backend/local: Check dependency lock consistency before any operations ... This is a port of the changes made in #29683	5 years ago
Omar Ismail	d5567b479c	Fix terraform version in cloud e2e tests to ignore prerelease. (#29)	5 years ago
Omar Ismail	a387af6c61	Add auto-approve logic, e2e tests	5 years ago
Chris Arcand	ee384e8716	Attempt to set current Terraform version on new workspaces, always	5 years ago
Chris Arcand	aba7d96596	cloud: Support interop from 0.14 to 1.1 ... The previous conservative guarantee that we would not make backwards incompatible changes to the state file format until at least Terraform 1.1 can now be extended. Terraform 0.14 through 1.1 will be able to interoperably use state files, so we can update the remote backend version compatibility check accordingly. This is a port of https://github.com/hashicorp/terraform/pull/29645	5 years ago
Chris Arcand	74e087dc29	Rename cloud.testBackendDefault -> cloud.testBackendWithName	5 years ago
Chris Arcand	d2b6b5f2b3	cloud: Align local and remote workspace name with 'name' strategy ... This changes the 'name' strategy to always align the local configured workspace name and the remote Terraform Cloud workspace, rather than the implicit use of the 'default' unnamed workspace being used instead. What this essentially means is that the Cloud integration does not fully support workspaces when configured for a single TFC workspace (as was the case with the 'remote' backend), but *does* use the backend.Workspaces() interface to allow for normal local behaviors like terraform.workspace to resolve to the correct name. It does this by always setting the local workspace name when the 'name' strategy is used, as a part of initialization. Part of the diff here is exporting all the previously unexported types for mapping workspaces. The command package (and init in particular) needs to be able to handle setting the local workspace in this particular scenario.	5 years ago
Omar Ismail	a94b2405b1	static checker	5 years ago
Omar Ismail	594a390f84	Use context parallelism	5 years ago
Chris Arcand	1791b71196	cloud: TestCloud_backendWithTags ... Implementing this test was quite a rabbithole, as in order to satisfy backendTestBackendStates() the workspaces returned from backend.Workspaces() must match exactly, and the shortcut taken to test pagination in 3cc58813f0 created an impossible circumstance that got plastered over with the fact that prefix filtering is done clientside, not by the API as it should be. Tagging does not rely on clientside filtering, and expects that the request made to the TFC API returns exactly those workspaces with the given tags. These changes include a better way to test pagination, wherein we actually create over a page worth of valid workspaces in the mock client and implement a simplified pagination behavior to match how the TFC API actually works.	5 years ago
Chris Arcand	a97a1c8f66	cloud.MockClient: Use Contains() to implement Search ... The TFC API doesn't behave this way; a search term just signals the substring was found within the name.	5 years ago
Chris Arcand	9bdf1d2579	Rename testBackendNoDefault ... "NoDefault" is now ambiguous with tags, and it does not imply using a prefix.	5 years ago
Chris Arcand	6dcd0db265	Map CLI workspaces by TFC tags	5 years ago