terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	765bff1dd5	Update CHANGELOG.md	5 years ago
dependabot[bot]	b0d10c9857	build(deps): bump github.com/xanzy/ssh-agent from 0.2.1 to 0.3.1 Bumps [github.com/xanzy/ssh-agent](https://github.com/xanzy/ssh-agent) from 0.2.1 to 0.3.1. - [Release notes](https://github.com/xanzy/ssh-agent/releases) - [Commits](https://github.com/xanzy/ssh-agent/compare/v0.2.1...v0.3.1) --- updated-dependencies: - dependency-name: github.com/xanzy/ssh-agent dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	5 years ago
James Bardin	87e852c832	Merge pull request #29741 from hashicorp/jbardin/test-fix fix test fixture with multiple provider instances	5 years ago
James Bardin	73b1263a86	wrap multiple provider creations into a factory fn When a test uses multiple instances of the same provider, we may need to have separate objects to prevent overwriting of the MockProvider state. Create a completely new MockProvider in each factory function call rather than re-using the original provider value.	5 years ago
Martin Atkins	965c0f3f91	build: Run staticcheck with "go run" Running the tool this way ensures that we'll always run the version selected by our go.mod file, rather than whatever happened to be available in $GOPATH/bin on the system where we're running this. This change caused some contexts to now be using a newer version of staticcheck with additional checks, and so this commit also includes some changes to quiet the new warnings without any change in overall behavior.	5 years ago
Martin Atkins	d76759a6a9	configs/configload: snapshotDir must be used via pointer A snapshotDir tracks its current position as part of its state, so we need to use it via pointer rather than value so that Readdirnames can actually update that position, or else we'll just get stuck at position zero. In practice this wasn't hurting anything because we only call Readdir once on our snapshots, to read the whole directory at once. Still nice to fix to avoid a gotcha for future maintenence, though.	5 years ago
James Bardin	903ae5edfd	fix test fixtures with multiple providers Allow these to share the same backing MockProvider.	5 years ago
James Bardin	e804fce63a	Merge pull request #29740 from hashicorp/jbardin/test-fix fix test fixture had the instance in the wrong mod	5 years ago
James Bardin	656f03b250	fix test fixture had the instance in the wrong mod Make the state match the fixture config. The old test was not technically invalid, but because it caused multiple instances of the provider to be created, they were backed by the same MockProvider value resulting in the `*Called` fields interfering.	5 years ago
dependabot[bot]	051629d74a	build(deps): bump github.com/agext/levenshtein from 1.2.2 to 1.2.3 Bumps [github.com/agext/levenshtein](https://github.com/agext/levenshtein) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/agext/levenshtein/releases) - [Commits](https://github.com/agext/levenshtein/compare/v1.2.2...v1.2.3) --- updated-dependencies: - dependency-name: github.com/agext/levenshtein dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	5 years ago
Martin Atkins	02ca4e970c	go.mod: replace github.com/dgrijalva/jwt-go with .../golang-jwt/jwt CVE-2020-26160 is a high-severity advisory reported against this module. The dgrijalva package is no longer maintained but our legacy etcv2 backend depends on it indirectly, via go.etcd.io/etcd/client. The golang-jwt package is the blessed successor of the original, and has a v3 line which is compatible with the v3 line of dgrijalva, and so through this replace we can get a fix for the advisory without other significant behavior change. We've preserved the etcdv2 backend as-is on a best-effort basis in order to support anyone who is already using it, but recommend that users switch to etcdv3 or to some other backend for ongoing use. We also have future plans to make state storage be a matter for provider plugins rather than built in to Terraform CLI, at which point this backend will either become obsolete or be factored out into its own plugin, at which point we can remove this "replace" directive and the associated dependency altogether.	5 years ago
dependabot[bot]	2fd5ca3767	build(deps): bump honnef.co/go/tools from 0.0.1-2020.1.4 to 0.3.0-0.dev Bumps [honnef.co/go/tools](https://github.com/dominikh/go-tools) from 0.0.1-2020.1.4 to 0.3.0-0.dev. - [Release notes](https://github.com/dominikh/go-tools/releases) - [Commits](https://github.com/dominikh/go-tools/compare/v0.0.1-2020.1.4...v0.3.0-0.dev) --- updated-dependencies: - dependency-name: honnef.co/go/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	5 years ago
Martin Atkins	55f0d06314	go.mod: go get github.com/lib/pq@v1.10.3 This is just a routine upgrade to the latest v1 release.	5 years ago
dependabot[bot]	eec4a838e0	Bump github.com/mitchellh/copystructure from 1.0.0 to 1.2.0 Bumps [github.com/mitchellh/copystructure](https://github.com/mitchellh/copystructure) from 1.0.0 to 1.2.0. - [Release notes](https://github.com/mitchellh/copystructure/releases) - [Commits](https://github.com/mitchellh/copystructure/compare/v1.0.0...v1.2.0) --- updated-dependencies: - dependency-name: github.com/mitchellh/copystructure dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	5 years ago
dependabot[bot]	2dd15caf87	Bump github.com/hashicorp/go-plugin from 1.4.1 to 1.4.3 Bumps [github.com/hashicorp/go-plugin](https://github.com/hashicorp/go-plugin) from 1.4.1 to 1.4.3. - [Release notes](https://github.com/hashicorp/go-plugin/releases) - [Commits](https://github.com/hashicorp/go-plugin/compare/v1.4.1...v1.4.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	5 years ago
James Bardin	ef8f1b3e38	Merge pull request #29734 from hashicorp/jbardin/missing-change Check for nil change during apply	5 years ago
James Bardin	69787e7f67	Merge pull request #29431 from hashicorp/dependabot/go_modules/google.golang.org/protobuf-1.27.1 Bump google.golang.org/protobuf from 1.25.0 to 1.27.1	5 years ago
Martin Atkins	2e6b6e9a6b	go.mod: go get google.golang.org/protobuf@v1.27.1	5 years ago
James Bardin	3f4b680f1c	Check for nil change during apply Because NodeAbstractResourceInstance.readDiff can return a nil change, we must check for that in all callers.	5 years ago
James Bardin	3c942ee3ac	Merge pull request #29720 from hashicorp/jbardin/destroy-plan-deposed don't refresh deposed instances during the destroy plan	5 years ago
James Bardin	fc980887fe	Merge pull request #29721 from hashicorp/jbardin/go-version Update go1.17.2	5 years ago
James Bardin	94ed6a0c84	update the go.mod format for go1.17.2	5 years ago
James Bardin	4c2dbec5b1	update to go1.17.2	5 years ago
James Bardin	05954a328d	udpate CI go version Since we have to specify the minor release for `.go-version`, make sure the CI version doesn't automatically udpate.	5 years ago
James Bardin	a036109bc1	add comment about when we call ConfigureProvider	5 years ago
megan07	71cbb2a81a	Merge pull request #29719 from hashicorp/megan_invalid_creds add better error if credentials are invalid	5 years ago
megan07	7dda3366a6	Update internal/backend/remote-state/gcs/backend.go Co-authored-by: appilon <apilon@hashicorp.com>	5 years ago
James Bardin	03f71c2f06	fixup tests for MockProvider changes Resetting the *Called fields and enforcing configuration broke a few tests.	5 years ago
Megan Bang	81201d69a3	check valid json	5 years ago
Megan Bang	348c761bea	add better error if credentials are invalid	5 years ago
James Bardin	22b400b8de	skip refreshing deposed during destroy plan The destroy plan should not require a configured provider (the complete configuration is not evaluated, so they cannot be configured). Deposed instances were being refreshed during the destroy plan, because this instance type is only ever destroyed and shares the same implementation between plan and walkPlanDestroy. Skip refreshing during walkPlanDestroy.	5 years ago
James Bardin	ad9944e523	test that providers are configured for calls Have the MockProvider ensure that Configure is always called before any methods that may require a configured provider. Ensure the MockProvider *Called fields are zeroed out when re-using the provider instance.	5 years ago
hc-github-team-tf-core	d05fa3049e	Cleanup after v1.1.0-alpha20211006 release	5 years ago
hc-github-team-tf-core	db1a97f9af	Release v1.1.0-alpha20211006	5 years ago
Alisdair McDiarmid	09edbba81f	Merge pull request #29550 from hashicorp/alisdair/json-format-version-1.0 json-output: Release format version 1.0	5 years ago
Alisdair McDiarmid	b9f3dab035	json-output: Release format version 1.0	5 years ago
Omar Ismail	bea7e3ebce	Backend State Migration: change variable names from one/two to source/destination (#29699 )	5 years ago
Jeff Escalante	44764ffdee	fix broken logo in readme (#29705 )	5 years ago
Martin Atkins	01b22f4b76	command/e2etest: TestProviderTampering We have various mechanisms that aim to ensure that the installed provider plugins are consistent with the lock file and that the lock file is consistent with the provider requirements, and we do have existing unit tests for them, but all of those cases mock our fake out at least part of the process and in the past that's caused us to miss usability regressions, where we still catch the error but do so at the wrong layer and thus generate error message lacking useful additional context. Here we'll add some new end-to-end tests to supplement the existing unit tests, making sure things work as expected when we assemble the system together as we would in a release. These tests cover a number of different ways in which the plugin selections can grow inconsistent. These new tests all run only when we're in a context where we're allowed to access the network, because they exercise the real plugin installer codepath. We could technically build this to use a local filesystem mirror or other such override to avoid that, but the point here is to make sure we see the expected behavior in the main case, and so it's worth the small additional cost of downloading the null provider from the real registry.	5 years ago
Martin Atkins	d09510a8fb	command: Early error message for missing cache entries of locked providers In the original incarnation of Meta.providerFactories we were returning into a Meta.contextOpts whose signature didn't allow it to return an error directly, and so we had compromised by making the provider factory functions themselves return errors once called. Subsequent work made Meta.contextOpts need to return an error anyway, but at the time we neglected to update our handling of the providerFactories result, having it still defer the error handling until we finally instantiate a provider. Although that did ultimately get the expected result anyway, the error ended up being reported from deep in the guts of a Terraform Core graph walk, in whichever concurrently-visited graph node happened to try to instantiate the plugin first. This meant that the exact phrasing of the error message would vary between runs and the reporting codepath didn't have enough context to given an actionable suggestion on how to proceed. In this commit we make Meta.contextOpts pass through directly any error that Meta.providerFactories produces, and then make Meta.providerFactories produce a special error type so that Meta.Backend can ultimately return a user-friendly diagnostic message containing a specific suggestion to run "terraform init", along with a short explanation of what a provider plugin is. The reliance here on an implied contract between two functions that are not directly connected in the callstack is non-ideal, and so hopefully we'll revisit this further in future work on the overall architecture of the CLI layer. To try to make this robust in the meantime though, I wrote it to use the errors.As function to potentially unwrap a wrapped version of our special error type, in case one of the intervening layers is changed at some point to wrap the downstream error before returning it.	5 years ago
James Bardin	aece887a85	Merge pull request #29701 from hashicorp/jbardin/proposed-new-null-objs objchange: fix ProposedNew from null objects	5 years ago
James Bardin	58d85fcc2e	add test for planing unknown data source values	5 years ago
James Bardin	18d354223e	objchange: fix ProposedNew from null objects The codepath for AllAttributesNull was not correct for any nested object types with collections, and should create single null values for the correct NestingMode rather than a single object with null attributes. Since there is no reason to descend into nested object types to create nullv alues, we can drop the AllAttributesNull function altogether and create null values as needed during ProposedNew. The corresponding AllBlockAttributesNull was only called internally in 1 location, and simply delegated to schema.EmptyValue. We can reduce the package surface area by dropping that function too and calling EmptyValue directly.	5 years ago
Alisdair McDiarmid	6b87e63955	Merge pull request #29652 from hashicorp/alisdair/add-exhaustive-switch-statement-lint build: Add exhaustive switch statement lint	5 years ago
James Bardin	c68422d125	Merge pull request #29682 from hashicorp/jbardin/less-data-depends_on Refine data depends_on dependency checks	5 years ago
Ram	45dab1b956	replace an with a	5 years ago
Martin Atkins	9e0de1c464	Update CHANGELOG.md	5 years ago
Martin Atkins	df578afd7e	backend/local: Check dependency lock consistency before any operations In historical versions of Terraform the responsibility to check this was inside the terraform.NewContext function, along with various other assorted concerns that made that function particularly complicated. More recently, we reduced the responsibility of the "terraform" package only to instantiating particular named plugins, assuming that its caller is responsible for selecting appropriate versions of any providers that _are_ external. However, until this commit we were just assuming that "terraform init" had correctly selected appropriate plugins and recorded them in the lock file, and so nothing was dealing with the problem of ensuring that there haven't been any changes to the lock file or config since the most recent "terraform init" which would cause us to need to re-evaluate those decisions. Part of the game here is to slightly extend the role of the dependency locks object to also carry information about a subset of provider addresses whose lock entries we're intentionally disregarding as part of the various little edge-case features we have for overridding providers: dev_overrides, "unmanaged providers", and the testing overrides in our own unit tests. This is an in-memory-only annotation, never included in the serialized plan files on disk. I had originally intended to create a new package to encapsulate all of this plugin-selection logic, including both the version constraint checking here and also the handling of the provider factory functions, but as an interim step I've just made version constraint consistency checks the responsibility of the backend/local package, which means that we'll always catch problems as part of preparing for local operations, while not imposing these additional checks on commands that _don't_ run local operations, such as "terraform apply" when in remote operations mode.	5 years ago
Martin Atkins	702413702c	plans/planfile: Include dependency locks in saved plan files We recently removed the legacy way we used to track the SHA256 hashes of individual provider executables as part of a plans.Plan, because these days we want to track the checksums of entire provider packages rather than just the executable. In order to achieve that new goal, we can save a copy of the dependency lock information inside the plan file. This follows our existing precedent of using exactly the same serialization formats we'd normally use for this information, and thus we can reuse the existing models and serializers and be confident we won't lose any detail in the round-trip. As of this commit there's not yet anything actually making use of this mechanism. In a subsequent commit we'll teach the main callers that write and read plan files to include and expect (respectively) dependency information, verifying that the available providers still match by the time we're applying the plan.	5 years ago
Martin Atkins	3f85591998	depsfile: SaveLocksToBytes function In a future commit we'll use this to include dependency lock information in full fidelity inside a saved plan file.	5 years ago

1 2 3 4 5 ...

29074 Commits (c99f5972dee6f62eaaf96ba74ab3cd4e71d19caa) All Branches Search

29074 Commits (c99f5972dee6f62eaaf96ba74ab3cd4e71d19caa)

All Branches