407 Commits (5e282683bfcd819fc3eacd94de424924d14701b5)

Author	SHA1	Message	Date
Sander van Harmelen	4c23019ab7	core: fixing new test ... Removed the ‘hashcode’ function so we didn’t need to import it here, but also removed the needed type assertion.	12 years ago
Sander van Harmelen	54db46ef1b	Fixing a small logic bug in diffList ... It’s not enough to only check if no new value is set. It can also be that a new value is set, but contains a variable that cannot be interpolated until a depending resource is created during the apply fase. I actually found this one as one of the acceptance tests for the AWS ELB resource was failing. It failed with the following error: ``` --- FAIL: TestAccAWSELB_InstanceAttaching (177.83 seconds) testing.go:121: Step 1 error: Error applying: aws_elb.bar: diffs didn't match during apply. This is a bug with the resource provider, please report a bug. FAIL exit status 1 FAIL github.com/hashicorp/terraform/builtin/providers/aws 177.882s ``` After a quick look I noticed it was actually a bug in core TF so added the test and made sure all unit tests and AWS acceptance tests are now running successfully.	12 years ago
Mitchell Hashimoto	c3ec9f7965	Revert "helper/schema: TypeMap computed should mark diff as cmputed" ... This reverts commit b73078c670.	12 years ago
Mitchell Hashimoto	b73078c670	helper/schema: TypeMap computed should mark diff as cmputed	12 years ago
Emil Hessman	4bfe18b40d	argument and verb formatting fixes reported by go vet ... builtin/providers/aws/tags_test.go:56: unrecognized printf verb 'i' builtin/providers/aws/tags_test.go:59: unrecognized printf verb 'i' config/config_test.go:101: possible formatting directive in Fatal call config/config_test.go:157: possible formatting directive in Fatal call config/module/get_file_test.go:91: missing argument for Fatalf(%s): format reads arg 1, have only 0 args helper/schema/schema.go:341: arg v.Type for printf verb %s of wrong type: schema.ValueType helper/schema/schema.go:656: missing argument for Errorf(%s): format reads arg 2, have only 1 args helper/schema/schema.go:912: arg schema.Type for printf verb %s of wrong type: schema.ValueType terraform/context.go:178: arg v.Type() for printf verb %s of wrong type: github.com/hashicorp/terraform/config.VariableType terraform/context.go:486: arg c.Operation for printf verb %s of wrong type: terraform.walkOperation terraform/diff_test.go💯 arg actual for printf verb %s of wrong type: terraform.DiffChangeType terraform/diff_test.go:235: arg actual for printf verb %s of wrong type: terraform.DiffChangeType	12 years ago
Mitchell Hashimoto	1792334ec4	fmt	12 years ago
Mitchell Hashimoto	81913c58fb	providers/aws: fixing faililng test	12 years ago
Mitchell Hashimoto	61811fce23	helper/schema: remove debug info	12 years ago
Mitchell Hashimoto	f63a5d24e9	helper/schema: diffs for sets should include the full set [GH-457] ... Prior to this, the diff only contained changed set elements. The issue with this is that `getSet`, the internal function that reads a set from the ResourceData, expects that each level (state, config, diff, etc.) has the _full set_ information. This change was done to fix merging issues. Because of this, we need to make sure the full set is visible in the diff.	12 years ago
Mitchell Hashimoto	d0ce67a5b7	helper/schema: on destroy/create, reset state to be empty [GH-464]	12 years ago
Mitchell Hashimoto	d1324678dd	helper/schema: setting empty map works [GH-464]	12 years ago
Mitchell Hashimoto	9ecbbc6fa0	helper/schema: some more unit tests	12 years ago
Mitchell Hashimoto	17d1bb7dde	Revert "Merge pull request #422 from svanharmelen/f-shaving-off-some-cpu-cycles" ... This reverts commit 428cce2478, reversing changes made to 517c5b2ea8.	12 years ago
Mitchell Hashimoto	428cce2478	Merge pull request #422 from svanharmelen/f-shaving-off-some-cpu-cycles ... helper/schema: Shaving off some unneeded calls, saving CPU cycles	12 years ago
Mitchell Hashimoto	8f166458d2	Merge pull request #480 from hashicorp/f-fix-consul ... Consul param should be "key"	12 years ago
Mitchell Hashimoto	5390357e45	helper/schema: sets properly take into account the diff	12 years ago
Mitchell Hashimoto	39edc5dc04	helper/schema: diffing maps that are computed should not result in ... change	12 years ago
Mitchell Hashimoto	37930f51a1	helper/schema: test case for boolean diffs	12 years ago
Mitchell Hashimoto	deec7194a3	helper/schema: validate maps properly [GH-461]	12 years ago
Mitchell Hashimoto	3e1169db61	helper/schema: validate string/bool types [GH-460]	12 years ago
Mitchell Hashimoto	686871310d	terraform: input properly sends on only set input	12 years ago
Mitchell Hashimoto	2b50d44aa4	helper/schema: validate Set is a set type [GH-413]	12 years ago
Mitchell Hashimoto	b4f8b7f43b	helper/resource: RetryError for quitting quickly	12 years ago
Mitchell Hashimoto	2e703afdad	helper/schema: valiate should ignore computed fields	12 years ago
Sander van Harmelen	e003334429	Shaving off some unneeded calls, saving CPU cycles ... I know it’s very unlikely that a user will notice the difference, but why range through the list, generate the set and calculate the hashcode, only to find out that indexMap == nil (e.g. don’t do anything with the generated hashcode). As indexMap is only needed when len(parts) > 0, why not only create and fill it (in one go) when len(parts) > 0?	12 years ago
Armon Dadgar	5a3f80559c	helper/ssh: Cleanups	12 years ago
Mitchell Hashimoto	12c178bc63	helper/schema: don't ask for input if provider default would not be nil	12 years ago
Mitchell Hashimoto	30786ce442	fmt	12 years ago
Mitchell Hashimoto	59349cca11	helper/schema: sets must be treated atomically within ResourceData ... This fixes a seemingly minor issue (GH-255) around plans showing changes when in fact there are none. But in reality this turned out to uncover a really terrible bug. The effect of what was happening was that multiple items in a set were being merged. Now, they were being merged in the right order, so if you didn't have rich types (lists in a set) then you never saw the effect since the later value would overwrite the earlier. But with lists (such as in security groups), you would end up with the lists merging. So, if you had one ingress rule with CIDR blocks and one with SGs, then after the merge both ingress rules would have BOTH CIDR and SGs, resulting in an incorrect plan (GH-255). This fixes the issue by introducing a `getSourceExact` bitflag to the ResourceData source. When this is set, ALL data must come from this level, instead of merging lower levels. In the case of sets and diffs, this is exactly what you want: "Get me the set 'foo' from the config and the config ONLY (not the state or diff or w/e)". Andddddd its fixed. GH-255	12 years ago
Mitchell Hashimoto	3a107d2e50	helper/schema: set the field to empty if it is a list and computed	12 years ago
Mitchell Hashimoto	e5d64318bf	helper/schema: don't say that a set is computed if it exists	12 years ago
Mitchell Hashimoto	36f225dea0	fmt	12 years ago
Mitchell Hashimoto	e0994c717d	helper/schema: fix issues around computed sets	12 years ago
Mitchell Hashimoto	539eca5ee6	Fix failing tests	12 years ago
Mitchell Hashimoto	dcaf653d6f	helper/schema: properly detect that a list is computed	12 years ago
Mitchell Hashimoto	3aa655ad3b	helper/schema: test schema diffs with the interpolation splits	12 years ago
Mitchell Hashimoto	753f6c6f8e	helper/schema: fix failing tests	12 years ago
Mitchell Hashimoto	00bdef3093	providers/aws: test tag removal	12 years ago
Mitchell Hashimoto	6eafac8a34	providers/aws: aws_vpc supports tags	12 years ago
Mitchell Hashimoto	f43528957e	helper/schema: support top-level TypeMap	12 years ago
Mitchell Hashimoto	0db9d98fff	helper/schema: can set Partial(true) multiple times	12 years ago
Mitchell Hashimoto	ef62fa80db	helper/resource: add Retry function	12 years ago
Mitchell Hashimoto	a7c321a028	helper/scheam: support UI defaults	12 years ago
Mitchell Hashimoto	99044a1f14	Add descriptions for AWS inputs	12 years ago
Mitchell Hashimoto	901c1448b4	command: make the UI a look nicer	12 years ago
Mitchell Hashimoto	d9596fa4d0	helper/schema: don't ask for input on fields that have a value	12 years ago
Mitchell Hashimoto	5aed997223	helper/schema: Input support	12 years ago
Mitchell Hashimoto	9ba39d93b7	helper/resource: compile	12 years ago
Mitchell Hashimoto	9b2b3a963f	ResourceDiff => InstanceDiff	12 years ago
Mitchell Hashimoto	81d9d70296	helper/schema: conforms to new API, tests pass	12 years ago
Mitchell Hashimoto	0bcbccf046	helper/resource: compiles, fails because Context doesn't work, probably	12 years ago
Mitchell Hashimoto	90dd00ee3c	helper/diff: InstanceState conversion	12 years ago
Mitchell Hashimoto	f117e33c9d	helper/ssh: convert to InstanceState	12 years ago
Mitchell Hashimoto	0250c17d6e	helper/schema: DefaultFunc for dynamic defaults ... /cc @c4milo - This might be useful to you as well.	12 years ago
Mitchell Hashimoto	5919637456	helper/schema: Defaults [GH-245]	12 years ago
Mitchell Hashimoto	3a6940d715	helper/schema: test cases around unknown variable values	12 years ago
Mitchell Hashimoto	faa4e75960	helper/schema: Get on computed diff should be empty	12 years ago
Mitchell Hashimoto	c9a541d95b	helper/schema: generate a full diff in destroy/create cycle	12 years ago
Mitchell Hashimoto	9d239eea60	helper/schema: detect no change computed for sets/lists properly	12 years ago
Mitchell Hashimoto	0c9b65f3f4	helper/schema: documentation	12 years ago
Mitchell Hashimoto	87a488092c	helper/schema: support partial states	12 years ago
Mitchell Hashimoto	40e5608fa9	helper/schema: return the prior state if Data is an error	12 years ago
Mitchell Hashimoto	56cf1e6faa	Fix go vet complaints	12 years ago
Mitchell Hashimoto	95bd64132b	helper/schema: update docs	12 years ago
Mitchell Hashimoto	31cc3ffca1	helper/schema: one of Optional, Required, Computed must be set	12 years ago
Mitchell Hashimoto	eff8306a6c	helper/schema: don't mark things computed if an ID is set	12 years ago
Mitchell Hashimoto	9ed601d541	helper/schema: store state with processed properly	12 years ago
Mitchell Hashimoto	50026a6d5c	helper/schema: When having a StateFunc, make sure NewExtra contains ... original	12 years ago
Mitchell Hashimoto	d009ea800a	helper/schema: add support for StateFunc	12 years ago
Mitchell Hashimoto	7be2f1b091	helper/schema: add GetOk	12 years ago
Mitchell Hashimoto	37cf52fa27	helper/schema: if no ID is set then return nil	12 years ago
Mitchell Hashimoto	3d3789920d	helper/schema: can set conninfo	12 years ago
Mitchell Hashimoto	efaedbabb0	fmt	12 years ago
Mitchell Hashimoto	4015d942ab	providers/aws: security group ingress rules treated as set [GH-87] ... /cc @pearkes - !!!	12 years ago
Mitchell Hashimoto	3db41fe9f6	helper/hashcode for generating hashcodes	12 years ago
Mitchell Hashimoto	e9cc09a886	helper/schema: improve InternalValidate for sets	12 years ago
Mitchell Hashimoto	9ab5577beb	helper/schema: set diff tests	12 years ago
Mitchell Hashimoto	475528adc3	helper/schema: Set operations	12 years ago
Mitchell Hashimoto	ca18e971d1	helper/schema: can set sets	12 years ago
Mitchell Hashimoto	9fe21f0423	helper/schema: verify that sets remove duplicates	12 years ago
Mitchell Hashimoto	56dde5c0c1	helper/schema: can read and get the state of sets	12 years ago
Mitchell Hashimoto	a7e1154a0f	helper/schema: remove swap tracking	12 years ago
Mitchell Hashimoto	312acf3e40	helper/schema: track map of swaps	12 years ago
Mitchell Hashimoto	5e975e47cf	helper/schema: diffing should use ResourceData for guidance	12 years ago
Mitchell Hashimoto	5fc41cc272	helper/schema: properly put "id" into attributes	12 years ago
Mitchell Hashimoto	021a23fe99	helper/schema: if update sets the ID to blank, it deletes the resource	12 years ago
Mitchell Hashimoto	ee0acc4a5d	helper/schema: support bools	12 years ago
Mitchell Hashimoto	968a567499	helper/schema: ability to force set Meta	12 years ago
Mitchell Hashimoto	e2abcb9c14	Merge pull request #163 from desimone/patch-4 ... helper/ssh: style	12 years ago
Alex Gaynor	2606ef8853	Remove extraneous trailing bit in the import URL	12 years ago
Alex Gaynor	3374f310f8	Replace implementation with Mitchell's go-homedir	12 years ago
Alex Gaynor	f48b888477	Merge branch 'master' into expand-user-path	12 years ago
Mitchell Hashimoto	2444986fe8	helper/schema: nice error if update isn't supported	12 years ago
Mitchell Hashimoto	c4664a81e6	helper/schema: show computed lists in diffs	12 years ago
Mitchell Hashimoto	ba819d1f37	helper/schema: don't include zero count in state	12 years ago
Mitchell Hashimoto	5a5ef67d87	helper/schema: don't forward computing onto elements	12 years ago
Mitchell Hashimoto	801b220dc7	helper/schema: can diff lists more correctly	12 years ago
Mitchell Hashimoto	e70522f4ca	helper/schema: if you can't find the list, just fall through to return ... nil	12 years ago
Mitchell Hashimoto	1b85f3a565	helper/schema: SetDependencies	12 years ago
Mitchell Hashimoto	dfede5791c	helper/schema: use reflection to set maps	12 years ago
Mitchell Hashimoto	3800dffdeb	helper/schema: computed values should not be Get-able	12 years ago
Mitchell Hashimoto	4ae1673580	helper/schema: support for NewRemoved	12 years ago
Mitchell Hashimoto	ce42845acd	helper/schema: use reflection to build []interface{}	12 years ago
Mitchell Hashimoto	17d29f7949	helper/schema: use reflection to verify list	12 years ago
Mitchell Hashimoto	4c9271160e	helper/schema: can handle maps	12 years ago
Mitchell Hashimoto	66d7003e6f	helper/schema: HasChange	12 years ago
Mitchell Hashimoto	f1f4836c99	helper/schema: GetChange	12 years ago
Mitchell Hashimoto	513596cc37	providers/heroku: Heroku app is mostly converted	12 years ago
Mitchell Hashimoto	3943bf5d8c	helper/schema: README	12 years ago
Mitchell Hashimoto	539e4da03f	helper/schema: more tests	12 years ago
Mitchell Hashimoto	d321240042	helper/schema: Provider implements ResourceProvider	12 years ago
Mitchell Hashimoto	c418681cc3	helper/schema: create/update/delete should work for Resource	12 years ago
Mitchell Hashimoto	894187ec18	helper/schema: Resource.Refresh	12 years ago
Mitchell Hashimoto	7db585c257	helper/schema: fix test	12 years ago
Mitchell Hashimoto	afd3a7b811	helper/schema: Provider.Resources	12 years ago
Mitchell Hashimoto	eaac13dd9b	helper/schema: ResourceProvider.Configure	12 years ago
Mitchell Hashimoto	51a44db6c2	helper/schema: move InternalValidate to schemaMap	12 years ago
Mitchell Hashimoto	e5e4437351	helper/schema: start Provider	12 years ago
Mitchell Hashimoto	a33e4bcdf0	helper/schema: properly validate sub-resources	12 years ago
Mitchell Hashimoto	c3f1f49640	helper/schema: final state for lists/objects works	12 years ago
Mitchell Hashimoto	06d30a559a	helper/schema: Set object	12 years ago
Mitchell Hashimoto	2d74a3cadd	helper/schema: basic set	12 years ago
Mitchell Hashimoto	bf6ad07505	helper/schema: ResourceData.Get can get the full object	12 years ago
Mitchell Hashimoto	43e4921bd9	helper/schema: more tests, todo tests for computedwhen	12 years ago
Mitchell Hashimoto	7bc0be4b81	helper/schema: couple more tests around Computed (+ fix)	12 years ago
Mitchell Hashimoto	3a46d21527	helper/schema: computed fields cannot be set	12 years ago
Mitchell Hashimoto	90f462e609	helper/schema: detect invalid/unknown keys	12 years ago
Mitchell Hashimoto	4af387b986	helper/schema: validation	12 years ago
Mitchell Hashimoto	b54acf4a0b	helper/schema: better docs	12 years ago
Mitchell Hashimoto	1d9528e595	helper/schema: ResourceData.Get works in most cases	12 years ago
Mitchell Hashimoto	31067ee8f6	helper/schema: ResourceData, starting tests	12 years ago
Mitchell Hashimoto	660dc68a86	helper/schema: more tests	12 years ago
Mitchell Hashimoto	d05b9d6193	helper/schema: can diff complex resource	12 years ago
Mitchell Hashimoto	878d844f5c	helper/schema: comment	12 years ago
Mitchell Hashimoto	7f14708e71	helper/schema: list ForceNew	12 years ago
Mitchell Hashimoto	22e286ffd5	helper/schema: diff-ing lists at a basic level	12 years ago
Mitchell Hashimoto	46d911325a	helper/schema: Bools and ints can decode	12 years ago
Mitchell Hashimoto	efa2335886	helper/schema: start the Diff function	12 years ago
Mitchell Hashimoto	01b6b5f48e	helper/schema: initial work	12 years ago
Alex Gaynor	d578031831	Added a second test for the other form of tilde paths	12 years ago
Alex Gaynor	e85b89d7fb	Added a test and fixed a typo	12 years ago
Alex Gaynor	9d6e0e4e83	Fixes #179 -- expand ~'s in the path to a key file	12 years ago
Jack Pearkes	1244bff399	Merge pull request #162 from desimone/patch-3 ... Update communicator.go	12 years ago
bdd	462bbece95	Update communicator.go ... If block ends in a return statement. Personal preference. It's less explicit, but more concise to drop the else and outdent the return.	12 years ago
bdd	0cb0c412c3	Update communicator.go ... typo	12 years ago
Mitchell Hashimoto	08c1a19cbf	Merge pull request #161 from desimone/patch-2 ... helper/ssh: equivalent loop	12 years ago
bdd	dbe946a97a	Update communicator.go ... Naming convention consistencies.	12 years ago
bdd	b55ab5d5b4	Update password.go ... Loop is equivalent.	12 years ago
bdd	fd60ddaacd	Update provisioner.go ... Comment should be capitalized to match exported function "VerifySSH"	12 years ago
Alex Gaynor	46154ca1d3	Fixed a ton of typos in docs and comments	12 years ago
Mitchell Hashimoto	a74775d077	helper/ssh: error if private key on SSH [GH-73]	12 years ago
Mitchell Hashimoto	d28e5a1638	dos2unix	12 years ago
Mitchell Hashimoto	b8660c2a65	helper/diff: ComputedAttrsUpdate	12 years ago
Mitchell Hashimoto	c6474b3e5c	terraform: more test cases	12 years ago
Mitchell Hashimoto	d7ecc76148	helper/resource: refactor wait a bit and introduce delay/mintimeout	12 years ago
Mitchell Hashimoto	c89e02c545	helper/diff: fix problems with PreProcess	12 years ago
Mitchell Hashimoto	2cfad3fa71	helper/diff: can specify PreProcess functions	12 years ago
Mitchell Hashimoto	9ec1990608	providers/aws/aws_instance: fix security group and key name issues in count	12 years ago
Mitchell Hashimoto	e8eae17cc9	helper/config: clean up validation to work with nested items ... /cc @pearkes	12 years ago
Armon Dadgar	b84814539f	Refactor shared SSH setup code	12 years ago
Armon Dadgar	2c3e619960	Removing unused constants	12 years ago
Armon Dadgar	8691a3ce91	Refactor helper methods out of provisioner	12 years ago
Armon Dadgar	b56a7d6957	helper/ssh: Adding Connect function	12 years ago
Armon Dadgar	9ad4531d10	helper/ssh: Importing SSH stuff from Packer	12 years ago
Mitchell Hashimoto	35071f0328	helper/config: can validate array configurations	12 years ago
Mitchell Hashimoto	f8b974c9aa	helper/resource: never use an interval more than 10 seconds on wait	12 years ago
Mitchell Hashimoto	4f798fdec6	helper/diff: if attribute is set and also computed, don't mark computed	12 years ago
Mitchell Hashimoto	f93c9c23d5	helper/diff: don't delete keys from diff if computed	12 years ago
Mitchell Hashimoto	91ad873113	helper/resource: improve logging and output for tests	12 years ago
Mitchell Hashimoto	0b2860fafc	helper/config: more correct logic with regards to nested things	12 years ago
Mitchell Hashimoto	dbe5a1254a	helper/resource: better error if config doesn't validate	12 years ago
Mitchell Hashimoto	9ab4a5bf88	helper/resource: exponential backoff	12 years ago
Mitchell Hashimoto	63ef4cf28a	helper/resource: stdlib to check resource attribute	12 years ago
Mitchell Hashimoto	4a3d51f40e	helper/resource: can compose TestCheckFuncs	12 years ago
Mitchell Hashimoto	8229758806	helper/resource: refresh during test	12 years ago
Mitchell Hashimoto	83f73e63aa	helper/resource: add PreCheck	12 years ago
Mitchell Hashimoto	bc146d21a3	helper/resource: persist state, log	12 years ago
Mitchell Hashimoto	be82499f3c	helper/resource: remove debugging stuff	12 years ago
Mitchell Hashimoto	55c1bf7f79	helper/resource: more tests	12 years ago
Mitchell Hashimoto	e0fbd48afd	helper/resource: Acceptance test framework	12 years ago
Mitchell Hashimoto	96e09440d4	helper/diff: mark removed keys as removed	12 years ago
Mitchell Hashimoto	2d97738636	helper/diff: calculate removed keys	12 years ago
Mitchell Hashimoto	fa3e9fab42	helper/resource: wait 2 seconds between each	12 years ago
Mitchell Hashimoto	b700eee3e0	helper/diff: don't output ID anymore since Terraform does it	12 years ago
Mitchell Hashimoto	663be265dc	helper/config: can validate nested structures ... /cc @pearkes - See docs	12 years ago
Mitchell Hashimoto	7c588eca58	add readme to helper dir	12 years ago
Mitchell Hashimoto	0c812ba9e8	helper/resource: automatically validate resources ... /cc @pearkes - So, just set a ConfigValidator struct up on your resources and it'll now automatically validate.	12 years ago
Mitchell Hashimoto	50b8e761f1	helper/config: Validator ... /cc @pearkes - Here is the beginning of that helper. It can't really validate deeper keys (i.e. listeners in ELB), but my goal is for it to support that soon. Working on it.	12 years ago
Mitchell Hashimoto	f1d782031b	helper/resource: don't assign to nil map	12 years ago
Mitchell Hashimoto	1c725896ca	helper/resource: support waiting on absense of thing	12 years ago
Mitchell Hashimoto	8acd3a6373	helper/resource: set to valid ID	12 years ago
Mitchell Hashimoto	21539d08a8	helper/resource: add id to attributes	12 years ago
Mitchell Hashimoto	177f8c094d	helper/diff: add ID to diff	12 years ago
Jack Pearkes	5ae69778a1	helper/resource: wait should return obj	12 years ago
Jack Pearkes	eb7c8c07c8	helpers/resource: add wait helper	12 years ago
Mitchell Hashimoto	947fa4e669	terraform: Context introduction	12 years ago
Mitchell Hashimoto	6b42d3d9a5	helper/resource: basic tests	12 years ago
Mitchell Hashimoto	cc9ef7a0d3	helper/resource: add UpdateFunc	12 years ago
Mitchell Hashimoto	37995e7ff8	helper/diff: work with complex data types	12 years ago
Mitchell Hashimoto	b6a02e473d	helper/resource: destroy on requiresNew	12 years ago
Mitchell Hashimoto	e392c349ef	helper/resource: clearer destroy logic	12 years ago
Mitchell Hashimoto	cb591ab2df	helper/resource: Destroy is called if destroy is set on diff	12 years ago
Mitchell Hashimoto	d54034d0b5	helper/diff: comment	12 years ago
Mitchell Hashimoto	bd0f23ce25	Move diff to helper/diff, helper/resource knows about it	12 years ago
Mitchell Hashimoto	ae142efff7	providers/aws: know how to destroy things	12 years ago
Mitchell Hashimoto	543e70aab1	helper/resource: nice helper for resourceprovider impl	12 years ago
Mitchell Hashimoto	c556e2ad48	providers/aws: start filling out	12 years ago