407 Commits (5e282683bfcd819fc3eacd94de424924d14701b5)

Author	SHA1	Message	Date
Martin Atkins	a67182543c	Nicer error when list/map assigned to string argument. ... Previous this would return the following sort of error: expected type 'string', got unconvertible type '[]interface {}' This is the raw error returned by the underlying mapstructure library. This is not a helpful error message for anyone who doesn't know Go's type system, and it exposes Terraform's internals to the UI. Instead we'll catch these cases before we try to use mapstructure and return a more straightforward message. By checking the type before the IsComputed exception this also avoids a crash caused when the assigned value is a computed list. Otherwise the list of interpolations is allowed through here and then crashes later during Diff when the value is not a primitive as expected.	11 years ago
Mitchell Hashimoto	344e7c26b5	fix a bunch of tests from go-getter import	11 years ago
Paul Hinze	2a179d1065	helper/schema: ValidateFunc support for maps	11 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Martin Atkins	cc8e8a55de	helper/schema: Default hashing function for sets ... A common issue with new resource implementations is not considering parts of a complex structure that's used inside a set, which causes quirky behavior. The schema helper has enough information to provide a default reasonable implementation of a set function that includes all non-computed attributes in a deterministic way. Here we implement such a function and use it when no explicit hashing function is provided. In order to achieve this we encapsulate the construction of the zero value for a schema in a new method schema.ZeroValue, which allows us to put the fallback logic to the new default function in a single spot. It is no longer valid to use &Set{F: schema.Set} and all uses of that construct should be replaced with schema.ZeroValue().(*Set) .	11 years ago
Martin Atkins	3fde993978	Merge #3336: Remove local multierror package. ... Instead, use ``github.com/hashicorp/go-multierror``.	11 years ago
Radek Simko	641b701830	schema: Make validation more strict	11 years ago
Sander van Harmelen	2ba8dc38fa	Switch to go-multierror ... It seems there are 4 locations left that use the `helper/multierror` package, where the rest is TF settled on the `hashicorp/go-multierror` package. Functionally this doesn’t change anything, so I suggest to delete the builtin version as it can only cause confusion (both packages have the same name, but are still different types according to Go’s type system.	11 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Paul Hinze	7eb72e7a12	helper/schema: record schema version when destroy fails ... This was just a missed exit from the resource.Apply function - subsequent refreshes would add the SchemaVersion back into the state, but having the state recorded once without the meta information can cause problems with Atlas's remote state checksumming.	11 years ago
Clint	f979fd7dee	Merge pull request #2571 from TimeIncOSS/f-aws-autogenerated-elb-name ... provider/aws: Allow ELB name to be generated	11 years ago
Radek Simko	9882cc59d8	aws: Add regression test for renaming ecs_cluster	11 years ago
Sander van Harmelen	4a8ef78d33	Fixes #2676 by prefixing all Windows commands ... By prefixing them with `cmd /c` it will work with both `winner` and `ssh` connection types. This PR also reverts some bad stringer changes made in PR #2673	11 years ago
Sander van Harmelen	97fd4f5b7d	Tweaking the tests	11 years ago
Paul Hinze	5c38456b05	core: don't prompt for variables with defaults ... In `helper/schema` we already makes a distinction between `Default` which is always applied and `InputDefault` which is displayed to the user for an empty field. But for variables we just have `Default` which is treated like `InputDefault`. This changes it to _not_ prompt the user for a value when the variable declaration includes a default. Treating this as a UX bugfix and the "don't prompt for variables w/ defaults set" behavior as the originally expected behavior we were failing to honor. Added an already-passing test to verify and cover the `helper/schema` behavior. Perhaps down the road we can add a `input_default` attribute to variables to allow similar behavior to `helper/schema` in variables, but for now just sticking with the fix. Fixes #2592	11 years ago
Radek Simko	70b7243dd6	helper: Add resource.PrefixedUniqueId	11 years ago
Mitchell Hashimoto	2f08a2bb15	Merge pull request #2507 from hashicorp/b-set-remove ... helper/schema: diff should include removed set items [GH-1823]	11 years ago
Mitchell Hashimoto	0100d4139b	helper/schema: clean up style	11 years ago
Mitchell Hashimoto	6e509aedcb	helper/schema: diff should include removed set items [GH-1823]	11 years ago
Paul Hinze	7238b3b4af	core: encapsulate representation of StringList ... Now the only code that cares about how StringLists are represented lives inside string_list.go ...which gives us the ability to change it! :)	11 years ago
Paul Hinze	10b3abf405	config: introduce StringList to abstract over list hack ... This is the initial pure "all tests passing without a diff" stage. The plan is to change the internal representation of StringList to include a suffix delimiter, which will allow us to recognize empty and single-element lists.	11 years ago
Radek Simko	6fdbca8e58	Merge pull request #2466 from TimeIncOSS/f-schema-field-name-validate ... schema: Add field name to ValidateFunc	11 years ago
Mitchell Hashimoto	6b7c2bcb35	Merge pull request #2450 from hashicorp/b-schema-validate-type ... helper/schema: validate objects are objects [GH-2166]	11 years ago
Mitchell Hashimoto	630646335f	Merge pull request #2451 from hashicorp/b-provider-validate ... helper/schema: internal validate as part of provider validation	11 years ago
Radek Simko	92db4802b6	schema: Add field name to ValidateFunc	11 years ago
Mitchell Hashimoto	4e7fcd4f42	helper/schema: test that validatefunc is not called with computed vals	11 years ago
Mitchell Hashimoto	e36597cad7	helper/schema: internal validate as part of provider validation ... [GH-1291]	11 years ago
Mitchell Hashimoto	4f391902a0	helper/schema: validate objects are objects [GH-2166]	11 years ago
Paul Hinze	aa8cf572a8	Merge pull request #2265 from hashicorp/f-schema-validate-field ... Support arbitrary per-field schema validation	11 years ago
Paul Hinze	385b17d679	provider/template: don't error when rendering fails in Exists ... The Exists function can run in a context where the contents of the template have changed, but it uses the old set of variables from the state. This means that when the set of variables changes, rendering will fail in Exists. This was returning an error, but really it just needs to be treated as a scenario where the template needs re-rendering. fixes #2344 and possibly a few other template issues floating around	11 years ago
Paul Hinze	a4912cc51f	helper/schema: limit ValidateFunc to primitives for now ... I couldn't see a simple path get this working for Maps, Sets, and Lists, so lets land it as a primitive-only schema feature. I think validation on primitives comprises 80% of the use cases anyways.	11 years ago
Paul Hinze	49352db26f	helper/schema: skip ValidateFunc on other errors ... Guarantees that the `interface{}` arg to ValidateFunc is the proper type, allowing implementations to be simpler. Finish the docstring on `ValidateFunc` to call this out. /cc @mitchellh	11 years ago
Paul Hinze	61fee6735d	helper/schema: ValidateFunc ... Allows provider authors to implement arbitrary per-field validation warnings or errors.	11 years ago
Svend Sorensen	943bf3c00a	Use name of function in comment string ... Name of function is Difference, not Differences.	11 years ago
Clint Shryock	78e7519efa	Updates from go generate	11 years ago
Sam Boyer	b82bd0c280	Condense switch fallthroughs into expr lists	11 years ago
Mitchell Hashimoto	dd24ed4b76	helper/schema: blank ID refresh doesn't exist [GH-1905]	11 years ago
Justin Campbell	bb14bfa657	helper/schema: call InternalValidate w/ schemaMap{}	11 years ago
Paul Hinze	1e3d1b07e6	helper/schema: validate ConflictsWith against top-level ... The runtime impl of ConfictsWith uses Resource.Get(), which makes it work with any other attribute of the resource - the InternalValidate was only checking against the local schemaMap though, preventing subResource from using ConflictsWith properly. It's a lot of wiring and it's a bit ugly, but it's not runtime code, so I'm a bit less concerned about that aspect. This should take care of the problem mentioned in #1909	11 years ago
Paul Hinze	a96a3372c6	provider/template: don't diff when there's no diff ... This reworks the template lifecycle a bit such that we get nicer diff behavior. First, we tick ForceNew on for both filename and vars, so that the diff indicates that the template will be "replaced" on change. This is mostly cosmetic, but it also tracks conceptually with the fact that the identifier we use is a hash of the contents, so any change essentially makes a "new resource". Second, we change the Exists implementation to only return `false` when there has been a change in the rendered template. This lets descendent resources see the computed value changing so that they'll properly trigger in the plan. Fixes #1898 Refs #1866 (but does not fix, there's another deeper issue there)	11 years ago
Paul Hinze	bc9792f4c5	helper/schema: tweak test anotation	11 years ago
Paul Hinze	051ba78554	Merge pull request #1824 from hashicorp/b-write-count-for-empty-maps ... helper/schema: write "attr.#": "0" for empty maps	11 years ago
Andrew Langhorn	bb4f7415ca	Rename "The The" so that they can play songs again ... Other than the fact that "The the" doesn't really make any sense anywhere that it's used in Terraform, they're a post-punk band from the UK. Fixes "The The" so that they can get back to playing songs.	11 years ago
Paul Hinze	fbce3a3caa	helper/resource: don't fail test on config warnings ... AccTests like TestAccComputeInstance_basic_deprecated_network were failing early on "invalid config" when we are explictly testing behavior that we know generates warnings.	11 years ago
Paul Hinze	f2368428d3	helper/schema: write "attr.#": "0" for empty maps ... This fixes some perpetual diffs I saw in Atlas AccTests where an empty map (`map[string]interface{}{}`) was being `d.Set` for "metadata_full". Because the MapFieldWriter was not distinguishing between empty and nil, this trigger the "map delete" logic and no count was written to the state. This caused subsequent plans to improperly report a diff. Here we redefine the map delete functionality to explicitly trigger only on `nil`, so we catch the `.#` field for empty maps.	11 years ago
Paul Hinze	cebcee5c63	Merge pull request #1778 from josharian/template-provider ... providers: add template provider	11 years ago
Phil Frost	b082117e92	Implement AWS IAM resources ... - Users - Groups - Roles - Inline policies for the above three - Instance profiles - Managed policies - Access keys This is most of the data types provided by IAM. There are a few things missing, but the functionality here is probably sufficient for 95% of the cases. Makes a dent in #28.	11 years ago
Phil Frost	33183c078b	Implement a hash function for string sets ... Sets of strings are pretty common. Let's not duplicate the function necessary to create a set of strings in so many places.	11 years ago
Paul Hinze	a3101568c5	helper/schema: add clarifying GetOk test ... Wrote this test to verify behavior, committing and commenting to help me get the answer faster in the future.	11 years ago
Josh Bleecher Snyder	76bcac3031	providers/template: add tests, address review comments ... Do directory expansion on filenames. Add basic acceptance tests. Code coverage is 72.5%. Uncovered code is uninteresting and/or impossible error cases. Note that this required adding a knob to helper/resource.TestStep to allow transient resources.	11 years ago