proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	c2f82b3d4e	Fix more Valgrind uninitialized value errors 1. MySQL_Logger.cpp: Initialize username_len, schemaname_len, and server_len to 0 in MySQL_Event constructor. These fields were uninitialized and used in copy constructor and JSON serialization. 2. debug.cpp: Add default member initializers to DebugLogEntry struct to ensure POD fields are zero-initialized. Move errno save/restore to after early return checks to avoid potential TLS access issues before thread is fully initialized.	1 week ago
Rene Cannao	ee7ee0b387	Fix multiple Valgrind-reported uninitialized memory issues 1. MySQL_Logger.cpp: Add NULL checks for myconn->parent before accessing address/port. Client connections (frontend) have parent=NULL, causing uninitialized value reads when logging. 2. debug.cpp: Add NULL check for GloVars.global.gdbg_lvl before accessing debug level configuration. Prevents use of uninitialized data when proxy_debug_func is called before init_debug_struct() completes. 3. ProxySQL_Admin.cpp: Add NULL checks for debug filter database fields before constructing filter strings. Prevents undefined behavior when constructing std::string from NULL pointers.	1 week ago
Rene Cannao	af58865b06	Fix uninitialized memory in QueryParserArgs.buf Use memset to zero-initialize the entire QueryParserArgs struct instead of individually setting only digest_text and first_comment to NULL. This fixes Valgrind errors about use of uninitialised values in strcasestr() when reading from the uninitialized buf array. Fixes errors like: Use of uninitialised value of size 8 at tolower (ctype.c:46) by strcasestr by MySQL_Connection::ProcessQueryAndSetStatusFlags(char*)	1 week ago
Rene Cannao	cc53ddca23	Merge branch 'v3.0-openssl-fix' into v3.0-test0213	1 week ago
Rene Cannao	52718df11f	Fix memory leak in stats processlist functions - Add missing delete resultset in stats___mysql_processlist - Add missing delete resultset in stats___pgsql_processlist	1 week ago
René Cannaò	0654efd62b	Merge pull request #5371 from sysown/v3.0-fixes0212 Fix admin shutdown races, RAII sqlite3 statements, and unsafe sprintf usage	1 week ago
Rene Cannao	746eca9f7c	More sprintf to snprintf conversions and indentation fixes - Replace remaining sprintf with snprintf in Admin_FlushVariables.cpp - Fix indentation in flush_GENERIC_variables__process__database_to_runtime - Apply same pattern to ProxySQL_Admin.cpp and ProxySQL_Admin_Stats.cpp	1 week ago
Rene Cannao	3e37337877	Use RAII for sqlite3 statements across codebase - Convert prepare_v2() calls to use unique_ptr RAII pattern - Remove manual sqlite3_finalize calls (now handled by RAII) - Update flush_*_variables functions to use new prepare_v2 return pattern - Apply changes to Admin, Cluster, Monitor, Catalog, and other modules	1 week ago
Rene Cannao	335be9ec72	Fix unsafe sprintf and error message handling - Replace sprintf with snprintf in flush_*_variables functions - Add null value safety with safe_val in variable flushing - Fix error message to use send_error_msg_to_client instead of send_ok_msg_to_client	1 week ago
Rene Cannao	61ce0a96e8	Remove redundant sqlite3_finalize calls in pgSQL stats Statements are managed by RAII and auto-finalized	1 week ago
Rene Cannao	afd6dffb05	Fix admin shutdown races and implement graceful teardown - Add coordinated shutdown for PROXYSQL KILL/SHUTDOWN in debug builds - Track active admin client threads with admin_client_threads_active counter - Add shutdown checks to prevent new connections during shutdown - Wait for all admin client threads to finish before cleanup in admin_shutdown() - Handle accept failures gracefully	1 week ago
Rene Cannao	368a9e3a63	Fix log_buffer debug leak during shutdown	1 week ago
Rene Cannao	ba86be70a6	Fixed some bugs in PR 5358	1 week ago
Rene Cannao	da7c8e5cf5	Fix missing variable	1 week ago
Rene Cannao	4ae5bd852a	Revert "fix: prevent dangling pointer in flush_*_variables___runtime_to_database" This reverts commit `a20b2704f4`.	1 week ago
René Cannaò	02ea4f90be	Merge pull request #5360 from sysown/v3.0-5359 fix: crash on macOS/FreeBSD when running PostgreSQL queries	1 week ago
René Cannaò	e82ff6f8aa	Merge pull request #5361 from sysown/v3.0-5069 Add protocol labels for all PostgreSQL metrics and extend prometheus metrics coverage	1 week ago
Rene Cannao	a69b925932	Minor typo fixes	1 week ago
René Cannaò	3145473438	Merge pull request #5367 from sysown/v3.0_pgsql-meta-cmd-admin-5365 Add PostgreSQL psql meta-command support to admin interface	1 week ago
Rahim Kanji	9460520999	Add more tests	1 week ago
Rahim Kanji	e76d9dc130	Cleanup	1 week ago
Rahim Kanji	ba5afd0bbf	Add TAP test	1 week ago
Rahim Kanji	331b0d6bce	Add support for PostgreSQL psql meta-commands in admin interface Implement handling for psql meta-commands (\dt, \di, \dv, \d, \l) in ProxySQL's PostgreSQL admin interface by intercepting expanded queries and converting them to appropriate SQLite queries. Supported commands: - \l, \l+: List databases (maps to PRAGMA DATABASE_LIST) - \dt [pattern]: List tables with optional pattern matching - \di [pattern]: List indexes with optional pattern matching - \dv [pattern]: List views with optional pattern matching - \d: List all relations (tables, views, indexes, triggers) Pattern matching supports psql regex syntax like '\dt mytest' by converting PostgreSQL regex patterns (^(pattern).$) to SQLite LIKE patterns (pattern%).	1 week ago
Rene Cannao	d90be4080a	Add documentation for Prometheus protocol labels feature Add comprehensive documentation describing the protocol labels feature introduced in this branch to resolve metric collisions between MySQL and PostgreSQL prometheus metrics. Related: #5068, #5069	2 weeks ago
Rene Cannao	3ab964010d	Add protocol labels to Query Cache metrics and enable PostgreSQL QC metrics This commit resolves the prometheus metric collision between MySQL and PostgreSQL Query Cache instances by creating separate metric maps with protocol labels and using compile-time type trait selection. Changes: - Add #include <type_traits> to Query_Cache.cpp - Create qc_metrics_map_mysql with { "protocol", "mysql" } labels (8 metrics) - Create qc_metrics_map_pgsql with { "protocol", "pgsql" } labels (8 metrics) - Modify Query_Cache constructor to use if constexpr with std::is_same_v to select the appropriate metrics map based on derived type - Enable GloPgQC metrics export in update_modules_metrics() This allows MySQL and PostgreSQL query cache metrics to coexist without collision, following the same pattern as Thread Handler metrics. Related: #5068, #5069	2 weeks ago
Rene Cannao	778e01174c	Add protocol labels to Thread Handler metrics and enable PostgreSQL metrics This commit extends PR #5069 by adding protocol labels to distinguish MySQL and PostgreSQL metrics in the Thread Handler modules. Changes: - Add { "protocol", "mysql" } labels to 65 MySQL_Thread.cpp metrics - Add { "protocol", "pgsql" } labels to 60 PgSQL_Thread.cpp metrics - Enable GloPTH (PostgreSQL threads handler) metrics export - Document Query Cache limitation (template base class collision) This resolves Issue #5068 by ensuring PostgreSQL prometheus metrics are properly exported with protocol labels, distinguishing them from MySQL metrics. Related: #5068, #5069	2 weeks ago
René Cannaò	fa35bda62b	Merge pull request #5069 from evkuzin/v3.0-fix-prometheus-metrics-dumplication add protocol labels for shared metrics between mysql and psql	2 weeks ago
Rene Cannao	17054cd14f	fix: memory leak in pull_global_variables_from_peer The statement1 was prepared but never finalized, causing a memory leak. Migrated to RAII pattern for automatic cleanup. Also updates mysql_hostgroup_attributes and mysql_servers_ssl_params to use RAII for consistency (lines 2231 and 2267), even though those had manual finalize calls. Reported-by: CodeRabbit AI	2 weeks ago
Rene Cannao	deb19a021c	fix: remove double-finalization in stats___save_mysql_query_digest_to_sqlite The RAII-managed unique_ptr already handles statement finalization. Manual finalize calls cause double-free which leads to undefined behavior. Reported-by: CodeRabbit AI	2 weeks ago
Rene Cannao	a20b2704f4	fix: prevent dangling pointer in flush_*_variables___runtime_to_database Move statement2_unique to function scope to prevent use-after-free. The unique_ptr was declared inside the if (runtime) block but statement2 (raw pointer) was used in the loop outside that block, causing the statement to be finalized before use. Affected functions: - flush_variables___runtime_to_database (PgSQL variables) - flush_genai_variables___runtime_to_database (GenAI variables) - flush_mysql_variables___runtime_to_database (MySQL variables) Reported-by: CodeRabbit AI	2 weeks ago
René Cannaò	fcaa904135	fix: crash on macOS/FreeBSD when running PostgreSQL queries Fix NULL pointer dereference in CopyCmdMatcher that caused ProxySQL to crash immediately when running any PostgreSQL query on macOS and FreeBSD systems. Root cause: copy_cmd_matcher was guarded by #ifdef IDLE_THREADS, but IDLE_THREADS is explicitly disabled on macOS (__APPLE__) and FreeBSD in proxy_defines.h. This caused the pointer to be NULL when accessed. The fix removes #ifdef IDLE_THREADS guards from copy_cmd_matcher since COPY command detection is a fundamental PostgreSQL feature for fast- forward mode and has no dependency on idle threads. Affected systems: macOS, FreeBSD (where IDLE_THREADS is disabled) Fixes: #5359	2 weeks ago
Rene Cannao	0e605f4170	build: fix anomaly_detection-t linking for PROXYSQLGENAI When PROXYSQLGENAI is enabled, anomaly_detection-t should link with libsqlite_rembed.a instead of -lscram -lusual due to different SQLite embedding requirements.	2 weeks ago
Rene Cannao	ac71e12a95	refactor: migrate RSA key generation to OpenSSL 3.0 EVP_PKEY API Replace deprecated OpenSSL RSA APIs with OpenSSL 3.0 EVP_PKEY keygen API: - Replace RSA_new() + RSA_generate_key_ex() with EVP_PKEY_keygen() - Replace PEM_write_bio_RSAPrivateKey() with PEM_write_bio_PrivateKey() - Remove EVP_PKEY_assign_RSA() - use EVP_PKEY directly - Update write_rsa_key() to accept EVP_PKEY instead of RSA* This eliminates deprecation warnings for: - RSA_new() - RSA_generate_key_ex() - RSA_free() - EVP_PKEY_assign_RSA() - PEM_write_bio_RSAPrivateKey() Note: MD5_* deprecation warnings in PgSQL_Protocol.cpp remain as a separate issue (scram-md5 authentication uses legacy MD5 API).	2 weeks ago
Rene Cannao	6f415dfdb2	fix: correct RAII migration issues - variable naming and redundant declarations - Fixed SAFE_SQLITE3_STEP2 macro errors: renamed 'rc1' to 'rc' in PgSQL_Monitor.cpp functions (update_connect_table, update_ping_table, update_readonly_table, maint_monitor_table) to match the macro's expected variable name - Removed redundant NULL declarations in ProxySQL_Admin_Stats.cpp functions (stats___pgsql_processlist, stats___pgsql_free_connections, stats___pgsql_errors, stats___save_pgsql_query_digest_to_sqlite) - Completed migration of stats___pgsql_errors and stats___save_pgsql_query_digest_to_sqlite to RAII pattern	2 weeks ago
Rene Cannao	7c0ff770f6	refactor: migrate prepare_v2 SIMPLE cases in ProxySQL_Admin_Stats.cpp Migrated all prepare_v2 calls to RAII-based pattern in 5 functions: - stats___mysql_processlist(): 2 statements (statement1, statement32) - stats___pgsql_processlist(): 2 statements - stats___mysql_free_connections(): 2 statements - stats___mysql_query_rules(): 2 statements - stats___mysql_query_digest(): 2 statements And removed manual finalization calls for all functions. The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	2 weeks ago
Rene Cannao	ee85b11ad5	refactor: migrate prepare_v2 SIMPLE case in PgSQL_HostGroups_Manager.cpp Migrated 1 function with 2 prepare_v2 calls to RAII-based pattern in: - generate_pgsql_hostgroup_attributes_table(): 2 statements (statement1, statement2) The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	2 weeks ago
Rene Cannao	e4704c5a51	refactor: migrate prepare_v2 SIMPLE cases in PgSQL_Monitor.cpp Migrated 5 prepare_v2 calls to RAII-based pattern in: - update_monitor_pgsql_servers(): 2 statements (stmt1, stmt32) - update_connect_table(): 1 statement (stmt) - update_ping_table(): 1 statement (stmt) - update_readonly_table(): 1 statement (stmt) - maint_monitor_table(): 1 statement (stmt) Note: Functions shunn_non_resp_srv() and update_srv_latency() were NOT migrated because they use global thread_local cached statements, which is a valid use case for the old API. The RAII pattern ensures automatic cleanup and eliminates manual sqlite_finalize_statement() calls.	2 weeks ago
Rene Cannao	73555410e9	refactor: migrate prepare_v2 SIMPLE case in FlushDigestTableToDisk template Migrated the template function FlushDigestTableToDisk to use RAII-based prepare_v2. This function is instantiated for both MySQL and PostgreSQL, eliminating 8 deprecation warnings (4 instantiations x 2 prepare_v2 calls). The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	2 weeks ago
Rene Cannao	2e907bdd3a	refactor: migrate prepare_v2 SIMPLE cases in ProxySQL_Cluster.cpp Migrated 4 prepare_v2 calls to RAII-based pattern in: - pull_mysql_query_rules_from_peer(): 3 statements (statement1, statement1fr, statement32fr) - update_mysql_users(): 1 statement (also fixes memory leak - missing finalize) - update_ldap_mappings(): 1 statement (also fixes memory leak - missing finalize) The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls, reducing the risk of resource leaks.	2 weeks ago
Rene Cannao	e3ee454369	fix: remove duplicate 'int rc' declarations in prepare_v2 migrated functions The RAII-based prepare_v2 migration introduced duplicate variable declarations that caused compilation errors. Removed duplicate 'int rc;' declarations in: - dump_checksums_values_table() - save_mysql_users_runtime_to_database() - save_pgsql_users_runtime_to_database() The 'int rc' variable was already declared at function scope, so the duplicate declarations after the structured bindings were redundant.	2 weeks ago
Rene Cannao	5b6381b329	refactor: migrate remaining prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - save_pgsql_ldap_mapping_runtime_to_database() - save_mysql_servers_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	2 weeks ago
Rene Cannao	2a83a30972	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - save_pgsql_users_runtime_to_database() - save_mysql_ldap_mapping_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	2 weeks ago
Rene Cannao	ca9b72a9df	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - dump_checksums_values_table() - save_mysql_users_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	2 weeks ago
Rene Cannao	e56da24c81	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - save_mysql_firewall_whitelist_rules_from_runtime() - save_pgsql_firewall_whitelist_rules_from_runtime() All statements are now automatically managed by RAII smart pointers.	2 weeks ago
Rene Cannao	575449cdf6	refactor: migrate all prepare_v2 SIMPLE cases to RAII API in ProxySQL_Admin Migrated the following functions: - save_mysql_query_rules_fast_routing_from_runtime() - save_pgsql_query_rules_fast_routing_from_runtime() - save_mysql_firewall_whitelist_sqli_fingerprints_from_runtime() - save_pgsql_firewall_whitelist_sqli_fingerprints_from_runtime() - save_mysql_firewall_whitelist_users_from_runtime() - save_pgsql_firewall_whitelist_users_from_runtime() All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	2 weeks ago
Rene Cannao	f779a6059a	refactor: migrate remaining prepare_v2 SIMPLE cases in MySQL_Monitor Migrated the following functions: - populate_monitor_mysql_server_aws_aurora_log() - populate_monitor_mysql_server_aws_aurora_check_status() - monitor_ping_process_ready_task_thread() - monitor_read_only_process_ready_tasks() (with if/else branches for replication_lag) All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	2 weeks ago
Rene Cannao	bdba0b44a0	refactor: migrate all prepare_v2 SIMPLE cases to RAII API in MySQL_Monitor Migrated the following functions: - update_monitor_mysql_servers() - update_monitor_proxysql_servers() - monitor_connect_thread() - monitor_ping_thread() - monitor_read_only_thread() - monitor_replication_lag_thread() - monitor_connect() cleanup - monitor_ping() cleanup - monitor_read_only() cleanup - monitor_replication_lag() cleanup - populate_monitor_mysql_server_group_replication_log() - populate_monitor_mysql_server_galera_log() All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	2 weeks ago
Rene Cannao	854ab4fbb6	refactor: migrate generate_pgsql_hostgroup_attributes_table() to RAII prepare_v2 - Changed from raw pointer to smart pointer-based prepare_v2 - Fixes existing memory leak where statement was never finalized - RAII ensures automatic cleanup when function exits	2 weeks ago
Rene Cannao	9939fe17e4	refactor: migrate generate_pgsql_servers_table() to RAII prepare_v2 - Changed from raw pointer to smart pointer-based prepare_v2 - Use raw pointer aliases to avoid .get() verbosity - Remove manual finalize - RAII handles cleanup automatically	2 weeks ago
Rene Cannao	7c2c6121e5	refactor: migrate prepare_v2 to RAII API in ProxySQL_Admin_Tests2 Migrate 2 test functions from deprecated prepare_v2() to the new RAII-based API: - ProxySQL_Test___GenerateRandom_mysql_query_rules_fast_routing() - ProxySQL_Test___MySQL_HostGroups_Manager_generate_many_clusters() Both are test functions with clear structure - simple cases. Uses raw pointer aliases to avoid .get() verbosity. Pattern used: auto [rc, statement_unique] = admindb->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly ... // No manual finalize - RAII handles it This addresses 3 of the ~150 deprecated prepare_v2 warnings.	2 weeks ago

1 2 3 4 5 ...

8460 Commits (c2f82b3d4e74ea632abcd4a12c19c0b20988570d) All Branches Search

8460 Commits (c2f82b3d4e74ea632abcd4a12c19c0b20988570d)

All Branches