fix: remove double-finalization in stats___save_mysql_query_digest_to_sqlite

The RAII-managed unique_ptr already handles statement finalization.
Manual finalize calls cause double-free which leads to undefined behavior.

Reported-by: CodeRabbit AI
v3.0-openssl-fix
Rene Cannao 1 week ago
parent a20b2704f4
commit deb19a021c

@ -1871,8 +1871,7 @@ int ProxySQL_Admin::stats___mysql_query_digests(bool reset, bool copy) {
}
row_idx++;
}
(*proxy_sqlite3_finalize)(statement1);
(*proxy_sqlite3_finalize)(statement32);
// RAII auto-finalizes statement1 and statement32
/*
char *query=(char *)malloc(strlen(a)+arg_len+32);
sprintf(query,a,r->fields[10],r->fields[0],r->fields[1],r->fields[2],r->fields[3],r->fields[4],r->fields[5],r->fields[6],r->fields[7],r->fields[8],r->fields[9]);

Loading…
Cancel
Save