proxysql

Commit Graph

Author	SHA1	Message	Date
Rahim Kanji	000a9794e4	Don't short-circuit in pipeline mode, fall through to backend execution	3 months ago
Rahim Kanji	5810978e4e	Unify ABORT and ROLLBACK command parsing Remove separate early-return handling for ABORT that was bypassing parse_rollback(). Treat ABORT as a synonym of ROLLBACK.	3 months ago
René Cannaò	4d58ce473e	Merge pull request #5435 from sysown/v3.0-ci_fix0301 Fix tests for isolated CI environment and enhance diagnostics	3 months ago
Rahim Kanji	abb66cc19f	Addressed AI review feeback	3 months ago
Rene Cannao	6b9918fdcc	chore: refine guard structures and fix indentation - Fixed indentation for TSDB methods in include/proxysql_admin.h. - Refined PROXYSQLTSDB guard structure in lib/Admin_FlushVariables.cpp. - Cleaned up indentation and redundant code in lib/ProxySQL_RESTAPI_Server.cpp. - Ensured consistent formatting across modified files.	3 months ago
Rene Cannao	17225e8e23	fix: resolve syntax error in ProxySQL_Statistics.cpp and verify build stability across tiers - Fixed a mismatched #endif and closing brace in ProxySQL_Statistics::disk_upgrade_mysql_connections. - Verified build stability for all three tiers (base, v3.1, v4.0) with clean builds.	3 months ago
Rene Cannao	6b46b26931	chore: implement PR review feedback for release tier system - Makefile: normalized GIT_VERSION by stripping 'v' prefix before arithmetic. - Makefile: corrected .PHONY declaration for build_deps_debug_default. - Admin Handler: properly guarded TSDB commands to return error when disabled. - REST API: removed redundant nested guards inside tsdb_resource class. - Statistics: implemented rigorous input validation for set_variable. - Statistics: added return value checks and rollback logic for TSDB migrations. - Statistics: implemented bounded concurrency (batching) for backend probes. - FFTO: implemented cumulative buffer limit enforcement in MySQL and PgSQL. - FFTO: ensured initial packet capture in PgSQL_Session by early initialization. - FFTO: improved reassembly buffer compaction logic. - Headers: default-initialized ffto_bypassed to false. - Code cleanup: merged redundant PROXYSQLFFTO guards.	3 months ago
Rene Cannao	c2f678a9de	feat: implement release tiers and feature guards for v3.0, v3.1, and v4.0 This commit introduces a structured release tier system controlled by environment variables, allowing three distinct ProxySQL versions to be built from the same codebase while maintaining a clear upgrade path. Key Changes: - Tier 1 (v3.0.x Stable): Default build including bug fixes and core enhancements. - Tier 2 (v3.1.x Innovative): Enabled via PROXYSQL31=1. Adds FFTO and TSDB. - Tier 3 (v4.0.x AI/MCP): Enabled via PROXYSQLGENAI=1. Adds the AI stack. Implementation Details: - Makefile: Implemented dynamic versioning logic that increments the minor version for v3.1 and the major version for v4.0. Added tier documentation. - Feature Guards: Introduced PROXYSQLFFTO and PROXYSQLTSDB guards across ProxySQL_Admin, ProxySQL_Statistics, REST API, and HTTP server. - FFTO: Guarded Fast Forward Traffic Observer in MySQL and PgSQL sessions, including thread-local variables and configuration parameters. - TSDB: Guarded the entire Time Series Database subsystem, including SQLite table definitions, background loops, and REST API endpoints. - Build Fixes: * Fixed 'proxy_debug_func' linkage by adding extern "C" and moving the definition outside of DEBUG guards to ensure non-debug builds link correctly. * Corrected misplaced/nested DEBUG and PROXYSQLFFTO guards. * Verified build stability for all tiers (unset, PROXYSQL31=1, PROXYSQLGENAI=1).	3 months ago
Rahim Kanji	e84433159b	Merge remote-tracking branch 'v3.0' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	3 months ago
Rene Cannao	ff1398ead5	fix: plumb real hostgroup_id for pgsql replication lag monitoring - Add hostgroup_id to mon_srv_t and ext_srvs.\n- Update fetch_updated_conf queries to return hostgroup_id.\n- Use real hostgroup_id in replication_lag_action call.	3 months ago
Rene Cannao	1911b02157	feat: temporarily disable pgsql monitor replication lag group_by_host	3 months ago
René Cannaò	16f8837e0d	Merge branch 'v3.0' into v3.0-pgsql_monitor_repl_lag Signed-off-by: René Cannaò <rene@proxysql.com>	3 months ago
Rene Cannao	c4fc60bdb0	fix: address security and logic issues in PostgreSQL replication lag monitoring - Fix SQL injection in pt-heartbeat query concatenation.\n- Fix copy-paste errors between mysql_thread_ and pgsql_thread_ variables.\n- Restore monitor_replication_lag_group_by_host logic.	3 months ago
Rene Cannao	cf1fd5cb35	Admin: Add support for loading sqliteserver variables from config file Previously, sqliteserver variables (e.g., sqliteserver-mysql_ifaces) were not loaded from the configuration file during startup or via the LOAD SQLITESERVER VARIABLES FROM CONFIG command. This fix adds: - LOAD SQLITESERVER VARIABLES FROM CONFIG command handling in Admin_Handler - sqliteserver variables loading during bootstrap in Admin_Bootstrap	3 months ago
Rahim Kanji	96bc668735	Fix pipeline mode transaction state handling and SET/RESET/DISCARD support Addresses issues with PostgreSQL Extended Query Protocol (Pipeline mode) in ProxySQL: Transaction State Handler Migration: - Moved handle_transaction_state() from PgSQL_Session::RequestEnd() to PgSQL_Session::handler() - Now called only for client queries (PROCESSING_QUERY/PROCESSING_STMT_EXECUTE) - Prevents internal SET commands from triggering transaction logic incorrectly - Added transaction state reset at 7 locations for clean connection pool return SET/RESET/DISCARD Pipeline Mode Support (lib/PgSQL_Session.cpp): - SET statements now execute properly in pipeline mode via RunQuery() - RESET ALL and DISCARD ALL blocked with proper error messages in pipeline mode - Added startup parameter mismatch detection for RESET with locked hostgroup	3 months ago
Rahim Kanji	aca91c3bd2	Optimize PgSQL_Protocol::generate_ok_packet to use direct buffer writes Replace format-specifier based PG_pkt helper methods (write_CommandComplete, write_ParameterStatus, write_ReadyForQuery) with direct buffer writes using put_char(), put_uint32(), and put_string().	3 months ago
Rahim Kanji	5dd27500f3	Addressed AI review feedback	3 months ago
Rahim Kanji	742ff05ecc	Fix PostgreSQL transaction state management for pipeline mode Move transaction state tracking from RequestEnd to connection handler to enable proper binary pipeline mode support: - Call handle_transaction_state() at ASYNC_QUERY_END/ASYNC_STMT_EXECUTE_END in PgSQL_Connection instead of RequestEnd - Add reset_state() calls in 7 locations to prevent stale state: * Session reset * Connection detach (finishQuery) * Error handlers (4 paths) * Base session housekeeping - Refactor destructor to use reset_state() Fixes transaction state tracking in pipeline mode where connections can be returned to pool mid-transaction.	3 months ago
Rahim Kanji	4d86e6949c	Add defensive null guard before reading PSarrayIN->len	3 months ago
Rahim Kanji	c309facaa2	Fixed typo	3 months ago
Rahim Kanji	ed8890b6a5	Added bounds checking for Describe and Close messages to prevent reads beyond packet boundaries	3 months ago
Rahim Kanji	8c9af56f38	Address AI review feedback	3 months ago
Rahim Kanji	83d16f3c22	Fix buffer handling in PostgreSQL admin session handler Improve error handling in admin_session_handler when processing PostgreSQL query packets: * Fix potential underflow in query_length calculation when handling very small packets (< 2 bytes) * Fix NULL pointer dereference in strcasecmp when query_no_space is not initialized due to early packet validation failures	3 months ago
Rahim Kanji	05b5821fbc	Fix integer underflow in PostgreSQL query packet handling and null terminator checking * Add validation to reject packets smaller than 6 bytes before processing * Add null terminator check	3 months ago
Rahim Kanji	d71090864f	Improve startup packet parsing Replace strlen() with memchr() to safely search for null terminators within buffer bounds. If no null terminator is found, treat the packet as malformed and break out of the processing loop.	3 months ago
Rahim Kanji	03ad2c3aae	Fix underallocation for undersized PostgreSQL packets The buffer2array() function could allocate less than 5 bytes for a packet when pkgsize was malformed to be smaller than the header size. This violated PostgreSQL protocol assumptions that packets are always >= 5 bytes. Ensure minimum allocation of sizeof(header) bytes regardless of the claimed packet size in the header.	3 months ago
Javier Jaramago Fernández	ff729a657e	chore: disable 'pt-heartbeat' in 'PgSQL_Threads_Handler::get_variable' This isn't for functional purposes, just for consistency in reporting the motivation for disabling the feature in the codebase.	3 months ago
Wazir Ahmed	5421a382ab	fix: Load TSDB variables from disk during startup - TSDB variables stored on disk were not being loaded into runtime during startup. Add the missing `flush_tsdb_variables___database_to_runtime()` and invoke it during init. - Inline the existing load/save wrappers in the header as thin delegations to the underlying flush functions Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	3 months ago
Wazir Ahmed	1684d30725	fix: Refresh Prometheus metrics before TSDB sampling - `tsdb_sampler_loop()` calls `registry->Collect()` without refreshing module metrics, causing stale metric values to be stored in the TSDB. - Added `update_modules_metrics()` call before `Collect()` in the sampler. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	3 months ago
René Cannaò	148dfb2af3	Merge pull request #5423 from sysown/v3.0-genai_keys v3.0-genai_keys: GenAI live validations, LLM bridge tests, and portability fix	3 months ago
Rene Cannao	cffd980bb9	fix: Conditionally include sys/eventfd.h only on Linux Add #ifdef __linux__ guard around sys/eventfd.h include to fix compilation on non-Linux platforms.	4 months ago
Javier Jaramago Fernández	a4ea3b2174	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-pgsql_monitor_repl_lag	4 months ago
Javier Jaramago Fernández	4103d69979	feat: disable 'pt-heartbeat' support for PostgreSQL The feature has been disabled until 'pt-heartbeat' support for PostgreSQL is fixed. See https://perconadev.atlassian.net/browse/PT-2030.	4 months ago
Rahim Kanji	866c3593bb	Set query retries for PostgreSQL extended query protocol operations Add query_retries_on_failure configuration for PARSE, DESCRIBE, and EXECUTE operations in PostgreSQL extended query protocol.	4 months ago
Rahim Kanji	27119169e4	Reset extended query frame if an unsupported message type is received	4 months ago
Rahim Kanji	7a062a3444	Add PgSQL notice handling in reset session paths Register the PostgreSQL notice handler during reset session operations. Previously, the handler was not set in this path, which could result in unhandled backend notices.	4 months ago
Rahim Kanji	1ffb4f13ac	Fix PostgreSQL resync error detection Add flush() call in resync_start() for immediate socket error detection instead of deferring to event loop	4 months ago
Wazir Ahmed	daa0b2037e	fix: Use consistent value representation in MCP query rules `mcp_query_rules` and `runtime_mcp_query_rules` uses different representations for the same fields, causing the web UI to always report config differences even after loading to runtime. - Use `-1` sentinel for nullable int fields (`flagOUT`, `timeout_ms`, `log`) so `NULL` values from main are preserved when written to runtime, following the `MySQL QP_rule_t` pattern. - Serialize `re_modifiers` bitmask back to `VARCHAR` (`1→"CASELESS"`) to match the format used in main table - Update `evaluate_mcp_query_rules()` to handle tri-state log field Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Wazir Ahmed	c05bc66655	fix: MCP variables overwritten due to incorrect flush logic `flush_mcp_variables___runtime_to_database()` ignores the `replace` parameter. The prepared statement is hardcoded to `REPLACE INTO`, so even when callers pass `replace=false` (e.g. `GenericRefreshStatistics`), the function overwrites values in memory config with stale runtime values. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Rene Cannao	f29a326ca0	Fix QueryDigestTopK heap comparator semantics	4 months ago
Rene Cannao	3e73787753	Revert "fix: Handle optimizer hints /+ / correctly in query tokenizers" This reverts commit `178f679fad`.	4 months ago
Rahim Kanji	176362c77d	Addressed feedback from AI review	4 months ago
Rahim Kanji	a82d653c0b	Handle late COPY protocol messages after session exits fast_forward mode When a COPY FROM STDIN operation encounters an error, the session switches back to normal mode. However, the client may have already pipelined CopyData('d'), CopyDone('c'), or CopyFail('f') messages that are still in the input queue. Previously, these messages fell through to the default case, generating a spurious "Feature not supported" error. This change adds explicit handling to discard these messages when session_fast_forward == SESSION_FORWARD_TYPE_NONE, preventing the race condition from causing errors. The client does not expect a response for these messages in this scenario.	4 months ago
Rene Cannao	6be9dd1bfa	fix: Address AI code review feedback from PR #5410 - Fix Top-K heap comparator in Query_Processor.cpp: use 'worse' comparator so heap top is the worst candidate (not best), enabling proper Top-K selection - Add packet/message size guards in MySQLFFTO and PgSQLFFTO on_server_data() to prevent memory exhaustion from large result sets - Add _exit(1) in utils.cpp when /dev/null open fails to prevent FD pollution - Add NULL checks and consume query result in test_ffto_bypass-t.cpp - Fix TAP message formatting in mcp_show_connections_commands_inmemory-t.cpp - Add run_admin_checked() helper in pgsql-issue5384-t.cpp for proper error handling	4 months ago
Rene Cannao	178f679fad	fix: Handle optimizer hints /+ / correctly in query tokenizers The query tokenizers for both MySQL and PostgreSQL did not correctly handle optimizer hint comments in the format /+ ... /. When parsing queries like `/+ hostgroup=1000 / SELECT 1`, the '+' character was incorrectly included in the extracted first comment content, resulting in the parsed key being '+hostgroup' instead of 'hostgroup'. This caused the query_processor_first_comment_parsing variable (modes 1 and 3) to not work correctly when using optimizer hint syntax. Changes: - c_tokenizer.cpp: Detect both /! and /+ comment formats - pgsql_tokenizer.cpp: Detect /*+ comment format - issue5384-t.cpp: Re-enable tests 2 and 3 (previously skipped) - pgsql-issue5384-t.cpp: Re-enable tests 2 and 3, add hostgroup 1000 setup Fixes #5413 (MySQL tokenizer) Fixes #5414 (PostgreSQL tokenizer)	4 months ago
Rene Cannao	70647fb426	fix: Remove unused legacy mcp-mysql_* variables These variables were deprecated in favor of profile-based routing but were never removed from the code. They existed in the struct definition, getters, and setters but were not consumed anywhere - Query_Tool_Handler uses target_auth_map via mcp_auth_profiles and mcp_target_profiles. Removed: - mcp-mysql_hosts, mcp-mysql_ports, mcp-mysql_user, mcp-mysql_password, mcp-mysql_schema from MCP_Thread.h struct - Variable names from mcp_thread_variables_names array - Initialization, cleanup, getters, and setters in MCP_Thread.cpp - Documentation in doc/MCP/VARIABLES.md	4 months ago
Rene Cannao	9b5d52308f	fix: Use legacy prepare_v2 for conditional statement preparation Use the legacy db->prepare_v2(const char, sqlite3_stmt*) overload for the runtime_global_variables statement, which allows conditional preparation only when the runtime flag is set. Properly finalize the statement when done.	4 months ago
Rene Cannao	de60fe2b3f	fix: Use db->execute() for runtime_global_variables inserts Simplified the code to use db->execute() instead of prepared statements for runtime_global_variables inserts. This avoids complex unique_ptr deleter type matching issues and the table not existing during early initialization.	4 months ago
Rene Cannao	7479f2168e	fix: Only prepare runtime_global_variables stmt when runtime=true The runtime_global_variables table may not exist during early initialization, so we should only prepare the statement for it when the runtime flag is true. This fixes a crash on startup when init_mcp_variables() is called before the admin database schema is fully initialized.	4 months ago
Rene Cannao	8b1fb84d5c	fix: Populate runtime_global_variables for MCP variables The MCP variables were not being exposed in runtime_global_variables table after LOAD MCP VARIABLES TO RUNTIME. This fix: 1. Adds runtime_global_variables handling to flush_mcp_variables___runtime_to_database: - Clears existing mcp-* entries from runtime_global_variables when runtime=true - Inserts current runtime values into runtime_global_variables 2. Calls flush_mcp_variables___runtime_to_database with runtime=true from flush_mcp_variables___database_to_runtime to ensure the runtime table is populated after variables are loaded to runtime. This matches the behavior of other variable modules (admin, ldap, mysql, pgsql).	4 months ago
Rene Cannao	e53d2c76f9	Address PR #5410 review findings across FFTO, sessions, TAP, and docs Apply actionable bot review feedback from PR #5410 without behavior drift:\n- fix MySQL/PgSQL FFTO digest normalization and max-length hashing\n- add early FFTO packet/message size guards for bypass safety\n- restore MySQL session GTID reset and harden GenAI async error ownership\n- add null-check for stripped KILL query normalization path\n- call FFTO on_close() before observer reset/bypass in session flows\n- fix processlist query-options default pagination limit semantics\n- fix TAP noise_failures locking race and noise-aware plan count\n- extend wait_get_enpoint_ready with optional basic-auth passthrough\n- update MCP architecture docs from observe->stats naming\n- clean corrupted character in pgsql query-cache test comment\n\nValidation run:\n- git diff --check\n- make -C test/tap/tap tap.o utils_mariadb.o utils_mysql57.o utils_mysql8.o -j4\n- make -C lib obj/MySQLFFTO.oo obj/PgSQLFFTO.oo obj/MySQL_Session.oo obj/PgSQL_Session.oo obj/Query_Processor.oo -j4	4 months ago
Rene Cannao	79c0b383e8	integration: fix pre-CI issues in unified branch	4 months ago
Rene Cannao	acef17a8c1	Merge branch 'v3.0-ff_inspect' into v3.0-unified-large-pr # Conflicts: # test/tap/tests/Makefile	4 months ago
Rene Cannao	e2ebc0c449	Merge branch 'v4.0-mcp-stats2' into v3.0-unified-large-pr	4 months ago
Rene Cannao	54bcb5eeca	Merge branch 'v3.0-5384' into v3.0-unified-large-pr	4 months ago
Rene Cannao	90462f6d5a	ffto: harden MySQL/PgSQL observer state handling and align tests/docs Address outstanding review findings for FFTO on v3.0-ff_inspect and tighten protocol-state correctness for both engines. MySQL FFTO - Restrict on_close() reporting to true in-flight states and always clear query tracking state after close. - Add explicit active-query cleanup helpers and invoke them on state transitions to IDLE. - Preserve accounting on mid-resultset server ERR packets by reporting current query in READING_COLUMNS/READING_ROWS before reset. - Keep prepared-statement lifecycle cleanup robust (pending prepare cleared on prepare completion paths). MySQL session integration - Extract duplicated FAST_FORWARD client FFTO feed logic into observe_ffto_client_packet() and reuse it from all call sites. PostgreSQL FFTO - Replace regex-based CommandComplete parsing with lightweight token parsing, including NUL/whitespace trimming and strict numeric validation. - Add queued tracking for pipelined extended-protocol executes so query text and response attribution stay aligned under Parse/Bind/Execute pipelining. - Distinguish finalize semantics (execute-finalize on CommandComplete vs sync-finalize on ReadyForQuery) and centralize finalize/activation helpers. - Add frontend Close ('C') handling to evict statement/portal mappings. - Harden client/server message parsing with additional length checks. - Extend affected-row command tag coverage to COPY and MERGE. TAP tests - Stabilize test plans for failure paths by replacing early returns with a fail-and-skip-remaining flow and shared cleanup labels. - Ensure both MySQL and PgSQL FFTO tests preserve planned assertion counts under setup/prepare/execute failures. Documentation - Align FFT0 design doc state/response descriptions with current implementation (ReadyForQuery handling, pipelined queueing, supported PG command tags). - Fix wording/typo issues in protocol section. Validation performed - make -C lib -j4 - make -C test/tap/tests test_ffto_mysql-t test_ffto_pgsql-t -j4 Runtime execution of the two TAP binaries remains environment-dependent (admin endpoint connectivity required).	4 months ago
Rene Cannao	5519080ac2	mcp stats: address review findings and remove --genai CLI flag	4 months ago
Rene Cannao	5988468521	Query Processor: re-initialize parser on rewritten queries and enhance test coverage - Fixed Query Processor to re-extract comments and re-compute digest if a query rule rewrites the query. - Enhanced issue5384-t with better regex, robust NULL checks, and teardown logic. - Added pgsql-issue5384-t to provide parity coverage for the PostgreSQL module. - Registered the new test in groups.json.	4 months ago
René Cannaò	2b710e518f	Merge pull request #5401 from sysown/v3.0_fix-pgsql-extended-query-routing_5387 Revert "Reset current_hostgroup to default when no query rule matches"	4 months ago
Rene Cannao	3ccf0982e6	AI: Fix retry logic bug and synchronize TAP tests - Fixed a bug in LLM_Bridge (LLM_Clients.cpp) where negative max_retries would prevent the initial API call from being made. - Improved numeric range validation in TAP tests by replacing atoi() with strtol() to correctly reject non-numeric suffixes (e.g., "50abc"). - Adjusted API key format validation in tests to match actual test data lengths for OpenAI and Anthropic prefixes. - Enhanced URL validation to correctly reject hosts starting with colons. - Updated test plans and added missing test cases to achieve full synchronization between planned and executed tests in: - ai_llm_retry_scenarios-t - ai_error_handling_edge_cases-t - ai_validation-t	4 months ago
Rene Cannao	3240a3a942	Fix SIGSEGV caused by double-finalize of sqlite3_stmt	4 months ago
René Cannaò	3647678193	Merge pull request #5399 from sysown/v3.0_3596_3597 Tokenizer: fix type mismatch for grouping limit variables	4 months ago
René Cannaò	1dbe9fde97	Merge pull request #5385 from sysown/v3.0-2233 Fix #2233: Mirror sessions destination_hostgroup overwritten by fast routing	4 months ago
Javier Jaramago Fernández	ba5af979ff	feat-wip: Add replication lag support for PostgreSQL monitoring	4 months ago
Rene Cannao	1c25787b88	Introduce {mysql,pgsql}-query_processor_first_comment_parsing variable (#5384 ) This universal fix allows controlling when the first comment of a query is processed relative to the query rules. By setting this variable to 1, ProxySQL-specific annotations (like GTID) can be parsed immediately, allowing subsequent query rules to strip them from the query string. This prevents prepared statement cache bloat and improves backend statement reuse when annotations with unique literals are used.	4 months ago
Rene Cannao	ca73b9eced	Tokenizer: fix type mismatch for grouping limit variables Fixes issues #5396 and #5397. The variables mysql_thread___query_digests_grouping_limit and mysql_thread___query_digests_groups_grouping_limit (and their PgSQL counterparts) were incorrectly declared as bool instead of int in the tokenizer files. This caused any value greater than 0 to be treated as 1, effectively forcing a hardcoded grouping limit of 1 regardless of user configuration. By correcting the types to int, the tokenizer now correctly honors the configured values. Also added regression tests to regular_tokenizer_digests.hjson.	4 months ago
Rene Cannao	797d4b580c	mcp stats: move show_users to in-memory auth snapshots Rework stats.show_users so it no longer queries runtime-populated stats tables via admindb. The tool now reads user connection counters directly from authentication runtime structures, matching the direction taken for other MCP stats tools that must avoid stale stats schema reads. Implementation details: - Replaced show_users SQL path over stats_mysql_users/stats_pgsql_users with in-memory collection from GloMyAuth::dump_all_users(..., false) and GloPgAuth::dump_all_users(..., false). - Preserved Admin semantics by excluding internal/admin-style accounts (default_hostgroup < 0). - For MySQL, included LDAP user counters from GloMyLdapAuth->dump_all_users() to keep parity with stats___mysql_users population behavior. - Added deterministic argument handling for db_type validation and pagination bounds (limit capped to 1000, offset clamped to >= 0). - Kept output contract unchanged (username, frontend_connections, frontend_max_connections, utilization_pct, status) and ordering by frontend_connections DESC then username ASC. Documentation and tests: - Added extensive doxygen comments describing in-memory data sources, filtering semantics, and result construction in show_users implementation. - Extended TAP test mcp_show_connections_commands_inmemory-t with show_users coverage for MySQL and PgSQL, including payload shape checks and username filter validation. - Updated TAP plan count accordingly. - Included current tap groups updates present in working tree (test_ffto_* entries in groups.json), as requested.	4 months ago
Rene Cannao	1258a1f2f2	Address PR reviews: improve performance, safety, and robustness of FFTO	4 months ago
Rene Cannao	db04a54c92	Fix memory corruption and stack overflow in FFTO due to large queries	4 months ago
Rahim Kanji	194e20b3e8	Revert "Reset current_hostgroup to default when no query rule matches" This reverts commit `1b3d20388e`.	4 months ago
Rene Cannao	5d786520b0	Merge remote-tracking branch 'origin/v3.0' into merge/v3.0-into-v3.0-5243 # Conflicts: # include/PgSQL_Logger.hpp # lib/Makefile # lib/PgSQL_Logger.cpp # lib/ProxySQL_Admin.cpp # test/tap/groups/groups.json	4 months ago
Rene Cannao	5d45d17456	mcp stats: split connection metrics from debug free-pool snapshots Refactor MCP stats connection tools so operational pool metrics remain lightweight while debug-level free-connection details are exposed through a dedicated gated tool. Changes in this commit: - Updated stats tool catalog and dispatch to add show_free_connections and keep show_connections focused on per-server pool metrics only. - Removed free-connection payload from show_connections and added explicit compatibility error when callers still pass detail=true, with guidance to use show_free_connections. - Implemented show_free_connections using in-memory hostgroup manager snapshots (MySQL and PgSQL) with hostgroup/server filtering and summary counters. - Added MCP runtime variable mcp-stats_enable_debug_tools (default false), including variable registration, getter/setter handling, and config default in proxysql.cfg. - Added extensive doxygen comments across modified code paths to document behavior, rationale, filters, and output contracts. - Added TAP coverage in mcp_show_connections_commands_inmemory-t for: show_commands baseline, show_connections aggregate-only contract, debug tool gating behavior, and enabled-path validation for show_free_connections on both MySQL and PgSQL. - Registered the new TAP test in test groups.	4 months ago
Rene Cannao	e762f91cda	MCP stats: add in-memory processlist filtering and PgSQL concurrency stress TAP Replace direct stats-schema reads in MCP show_processlist with in-memory processlist access via SQL3_Processlist query options. Add processlist query option types in proxysql_admin interfaces and implement filtering, sorting, and pagination post-processing in both MySQL and PgSQL thread implementations. Introduce configurable MCP cap mcp_stats_show_processlist_max_rows (default 200, max 1000), wire it through MCP variable loading, and expose it in default config. Expand Stats_Tool_Handler processlist handling to parse filter/sort arguments, enforce cap metadata, and return consistent MCP payload fields from in-memory snapshots. Add extensive doxygen documentation in the touched headers and source blocks to describe API contracts, filtering behavior, and runtime constraints. Add new TAP test mcp_pgsql_concurrency_stress-t that generates sustained concurrent PgSQL traffic (simple reads, read/write table workload, randomized pg_sleep) while polling MCP show_processlist and show_queries in parallel with filter and ordering assertions. Validation performed locally: mcp_pgsql_concurrency_stress-t (31 assertions) and mcp_show_queries_topk-t (12 assertions).	4 months ago
René Cannaò	9c6945fae8	Merge branch 'v3.0' into v3.0-tsdb-feature Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	9a630a949b	Add extended Doxygen documentation for FFTO classes	4 months ago
Rene Cannao	40aff577a9	Complete FFTO implementation with verified metrics and robust error handling - Finalized MySQL and PostgreSQL protocol state machines. - Implemented accurate affected_rows and rows_sent capture. - Added defensive null checks to prevent early-session crashes. - Enhanced TAP tests with result-set draining and success verification. - Verified 100% pass rate for MySQL CRUD, binary protocol, and memory bypass.	4 months ago
Rene Cannao	70b61a86e3	MCP stats: implement in-memory show_queries Top-K path Replace stats table reads in show_queries with Query Processor in-memory aggregation to avoid stale/empty admin-db snapshots.\n\nIntroduce Top-K digest filtering primitives and wire them into Stats_Tool_Handler so filtering/sorting/limit are executed against live digest memory. Add runtime MCP variable mcp-stats_show_queries_max_rows with validation, defaulting, and configuration plumbing, plus cap metadata in the tool response.\n\nEnforce configurable hard cap semantics while preserving deterministic ordering and pagination behavior for MCP clients. Add internal DEBUG validator path (PROXYSQLTEST 56) in admin tests to stress generated digest data and validate the Top-K/filter pipeline against in-memory state.\n\nKeep the validator callable from startup/testing workflows without depending on MCP linkage. Add TAP coverage in test/tap/tests/mcp_show_queries_topk-t.cpp for:\n- MCP endpoint setup and reachability\n- digest generation + optional DEBUG internal validator\n- payload validation and cap metadata assertions\n- descending count order validation\n- match_digest_text filter verification\n\nMake payload parsing backward-compatible in TAP (direct tool result object and legacy wrapped success/result payloads).	4 months ago
René Cannaò	bad7ce40c5	Merge pull request #5391 from sysown/v3.0_pgsql_advanced_logging feat(pgsql): advanced query logging parity with mysql eventslog	4 months ago
Rene Cannao	c126e63a23	mcp stats: refresh stats tables under admin mutex before direct reads Problem MCP stats tools were querying stats.* tables directly through admindb. Unlike admin-session SQL, that path bypassed GenericRefreshStatistics() and could return stale or empty data for runtime-populated tables. What changed - Updated Stats_Tool_Handler::execute_admin_query() to mirror admin-session semantics for stats reads: - acquire GloAdmin->sql_query_global_mutex - optionally invoke ProxySQL_Admin::GenericRefreshStatistics(sql, ..., false) - execute admindb statement - release sql_query_global_mutex - Added strict input validation and explicit lock/unlock error reporting. - Added refresh_before_query parameter (default true) to avoid duplicate refresh passes for secondary count queries. - Switched secondary COUNT(*) calls in show_processlist/show_queries/ show_errors/show_query_rules to refresh_before_query=false. Documentation - Expanded Doxygen in include/Stats_Tool_Handler.h for execute_admin_query() to document locking, refresh behavior, and performance tradeoff. - Added detailed Doxygen above the execute_admin_query() implementation in lib/Stats_Tool_Handler.cpp. Testing - Added TAP integration test test/tap/tests/mcp_stats_refresh-t.cpp. - The test injects a synthetic stale marker row into stats.stats_mysql_global, calls /mcp/stats show_status, and verifies the marker disappears after refresh-before-read. - Added helper-level Doxygen in the test for setup/parsing behavior. Build verification - Compiled lib object: make -C lib obj/Stats_Tool_Handler.oo - Compiled TAP target: make -C test/tap/tests mcp_stats_refresh-t - Direct runtime execution of the TAP test in this workspace could not fully run because no local admin listener was available (connection to 127.0.0.1:6032 failed).	4 months ago
Rene Cannao	f3d4153e7d	Final FFTO implementation and verification fixes - Resolved signature mismatch in report_query_stats - Fixed missing type declarations for Query_Processor in FFTO classes - Verified Metric Parity for affected_rows and rows_sent - Confirmed full coverage in TAP tests for text/binary protocols and bypass logic - Verified clean build with make debug	4 months ago
Rene Cannao	33fce1ca35	MCP stats: address review findings and add detailed docs	4 months ago
René Cannaò	4a6809b60f	Merge branch 'v3.0' into v3.0-tsdb-feature Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	ef397f9f1d	Fix TSDB variable patterns and backend monitor runtime source	4 months ago
René Cannaò	5256f3d77a	Merge pull request #5388 from sysown/v3.0_fix-pgsql-extended-query-routing_5387 Fix: Extended query Routing and Statistics Tracking	4 months ago
Rene Cannao	82a28a2e62	fix(pgsql-eventslog): close remaining minor review findings in logger internals Address two minor correctness/style follow-ups from final review: 1) `PgSQL_Event::set_error()` overwrite safety - Free previous `sqlstate` / `errmsg` buffers when either ownership mode is active (`free_on_delete` or `free_error_on_delete`) before replacing pointers. - This avoids latent leaks if `set_error()` is called on deep-copied events. 2) Explicit atomic access for circular-buffer capacity - Keep `buffer_size` atomic and use explicit `load/store` operations with `std::memory_order_relaxed` in hot-path and helper methods. - Update log-path check, insert path, getter, and setter to use explicit atomic operations for clearer thread-safety semantics.	4 months ago
Rene Cannao	3dfd6a97d9	Fix FFTO metric parity: capture and report affected_rows and rows_sent - Implemented MySQL OK_Packet parsing to extract affected_rows - Implemented PostgreSQL CommandComplete parsing to extract rows affected/sent - Updated TAP tests to validate sum_rows_affected and sum_rows_sent metrics - Fixed incorrect assertion in test_ffto_mysql-t.cpp	4 months ago
Rene Cannao	17092487cf	Add protocol-labeled logger counters and FLUSH LOGS race TAP - Introduce proxysql_query_logger_logged_queries_total with protocol label (mysql, pgsql) for direct query-log accounting via Prometheus. - Wire MySQL and PgSQL loggers to increment/export the counter and hook PgSQL logger metrics into admin scrape updates. - Add reg_test_5389-flush_logs_no_drop-t.cpp to stress concurrent client traffic + PROXYSQL FLUSH LOGS and assert no dropped logs via metric delta == executed queries. - Document the new TAP with doxygen comments for env knobs and flow.	4 months ago
Rene Cannao	6db089883e	fix(admin): improve PGSQL eventslog dump failure reporting and stats insert path Admin command behavior: - `DUMP PGSQL EVENTSLOG ...` returned `OK 0` when `GloPgSQL_Logger` was null. - This masked unavailable logger state from operators. Change: - Return an explicit admin error (`PgSQL logger not initialized`) when logger is unavailable. - Preserve normal `OK` response path when logger is present. Stats path behavior: - PgSQL logger metrics insertion into `stats_pgsql_global` used per-row string formatting and `execute()` calls. Change: - Replace per-row dynamic SQL construction with a prepared-statement row insert path. - Reuse `sqlite3_global_stats_row_step()` for consistent binding/reset semantics.	4 months ago
Rene Cannao	0aa3c5e153	fix(pgsql-eventslog): harden event ownership and keep newest rows in memory table Problem 1: - `PgSQL_Event::set_error()` stored borrowed pointers from connection-owned strings. - This could create lifetime hazards before/around event serialization and buffering. Fix: - Add explicit ownership tracking for error fields via `free_error_on_delete`. - Make `set_error()` duplicate incoming SQLSTATE/error strings. - Free owned error strings in destructor when the event does not own all fields. - Keep copy-constructor behavior for deep-copied buffered events and disable copy-assignment to avoid accidental shallow assignment. Problem 2: - `processEvents()` could repopulate `stats_pgsql_query_events` using the beginning of the drained batch after retention pruning. - This keeps older rows instead of the most recent rows when truncation is required. Fix: - Insert the tail of the drained batch (`events.end() - numEventsToInsert`) so memory table retention always preserves latest events. - Tighten row retention arithmetic using `size_t` to avoid signed/unsigned mismatch in keep/delete calculations.	4 months ago
Rene Cannao	c5191d21f8	logger: avoid log drops during rotate close/open window	4 months ago
Rene Cannao	eba795d729	fix(pgsql-eventslog): make dump-to-memory sizing protocol-agnostic across admin ports Context: - Admin commands are exposed by one shared Admin module over two protocols: - MySQL admin endpoint (`6032`) - PostgreSQL admin endpoint (`6132`) - `DUMP PGSQL EVENTSLOG ...` must behave identically regardless of which admin protocol executes the command. Issue fixed: - PGSQL events dump path used thread-local PGSQL sizing variables when draining to memory (`stats_pgsql_query_events`). - When command execution happened from a non-PGSQL protocol admin worker, TLS values could be out of sync for PGSQL sizing decisions. Changes: - In `lib/PgSQL_Logger.cpp`, add runtime-size helper functions that read canonical values from `GloPTH->variables` with TLS fallback: - `eventslog_buffer_max_query_length` - `eventslog_table_memory_size` - Use these helpers in: - `PgSQL_Event` copy constructor (buffered query truncation) - `PgSQL_Logger::processEvents()` (in-memory retention for `stats_pgsql_query_events`) - Update internal architecture doc to explicitly state command availability from both admin protocol endpoints. Why: - Ensure `DUMP PGSQL EVENTSLOG ...` semantics remain consistent across `6032` and `6132`, matching the shared-admin-module design.	4 months ago
Rene Cannao	20d6282a60	build(clean): ignore and remove generated MySQL parser artifacts Context: - Bison/Flex-generated parser files in `lib/` can be created locally during parser work. - These files are generated artifacts and should not be tracked. Changes: - Add generated parser artifacts to `.gitignore`: - `lib/MySQL_Lexer.yy.c` - `lib/MySQL_Parser.output` - `lib/MySQL_Parser.tab.c` - `lib/MySQL_Parser.tab.h` - Extend `lib/Makefile` `clean` target to remove the same generated files. Why: - Prevent accidental inclusion of regenerated parser outputs in feature commits. - Keep worktrees clean and make `make clean` deterministic for parser-related changes.	4 months ago
Rene Cannao	b4e85f1799	Expose PostgreSQL eventslog metrics in stats and Prometheus	4 months ago
Rene Cannao	b100235fbd	Add PGSQL eventslog dump commands and periodic disk sync scheduling	4 months ago
Rene Cannao	acbd7d0df3	Implement PostgreSQL eventslog circular buffer and sink pipeline	4 months ago
Rene Cannao	2a46c239be	Add PostgreSQL advanced eventslog schema and variable scaffolding	4 months ago
Rene Cannao	3ca390dacb	Fix binary protocol support for prepared statements in FFTO - Implemented statement ID tracking for MySQL COM_STMT_PREPARE/EXECUTE - Implemented Parse/Bind/Execute portal mapping for PostgreSQL Extended Query - Corrected documentation regarding binary protocol support - Ensured metric parity for prepared statements in Fast Forward mode	4 months ago
Rene Cannao	3a3be5a559	Implement Fast Forward Traffic Observer (FFTO) for MySQL and PostgreSQL - Added TrafficObserver base interface - Implemented MySQLFFTO and PgSQLFFTO classes for protocol-aware observation - Integrated FFTO hooks into MySQL and PostgreSQL session handlers in FAST_FORWARD state - Added configuration variables: mysql-ffto_enabled, mysql-ffto_max_buffer_size, pgsql-ffto_enabled, pgsql-ffto_max_buffer_size - Implemented query digest extraction and reporting parity with internal stats - Added session-level bypass when packet size exceeds buffer threshold - Included architectural documentation in doc/ffto_design.md	4 months ago
Rahim Kanji	1f0756b59f	Correct bytes_sent tracking for extended query protocol Fix missing and incorrect update_bytes_sent() calls in PgSQL_Connection async state machine.	4 months ago
Rene Cannao	eaadabbb8e	logger: fix thread-context map race in buffered logging	4 months ago
Rene Cannao	caf324f911	logger: harden buffered logging flush/rotation semantics This commit addresses three correctness regressions introduced by thread-local log buffering in PR #5364 (query logging performance): 1) stale logfile pointer/UAF race during concurrent rotate/close 2) stale logfile-open state after close 3) non-global flush behavior in admin/format-switch paths What was fixed - Make `flush_and_rotate()` consume the current logfile pointer under lock - Signature changed from `std::fstream` to `std::fstream&` - Prevents dereferencing a stale stream pointer captured before lock acquisition while another thread rotates/closes the file - Updated declaration/definition and all call sites - Add explicit synchronization for cross-thread buffer draining - Added `LogBufferThreadContext::buffer_lock` - Any path that appends or flushes a thread buffer now locks this mutex - Guarantees force-flush from admin/config paths cannot race with worker-thread appends on the same context - Restore global forced flush semantics where required - Extended `MySQL_Logger::flush` and `PgSQL_Logger::flush` to `flush(bool force = false)` - `force=false`: preserves existing low-overhead worker-loop behavior (per-thread timeout-based flush) - `force=true`: snapshots all known thread contexts and drains both events/audit buffers regardless of timeout - `flush_log()` now calls `flush(true)` before file rotation, so admin flush and format-switch operations no longer miss pending thread buffers - Avoid unintended rotation during forced draining - In `force=true` path, flush uses `rotate_fn=nullptr` - Drains buffered payload into the current file first - `flush_log()` then performs one controlled rotate/open step - Fix logfile state tracking after close - `events_close_log_unlocked()` and `audit_close_log_unlocked()` now set `logfile_open=false` when the stream is closed - Prevents write paths from treating a closed stream as open - Remove per-thread-context dependency during metadata header write - `events_open_log_unlocked()` now uses a local `LogBuffer` for metadata emission in format=1 instead of reusing a thread context buffer - Keeps open/rotate path independent from worker context lifecycle - Keep callers consistent and non-duplicative - Since `flush_log()` now force-drains internally, removed redundant explicit `flush()` calls from: - MySQL/PgSQL `eventslog_format` switch handlers - `ProxySQL_Admin::flush_logs` Behavioral outcome - No stale stream pointer use when close/rotate interleaves with flush - No false-positive logfile-open state after close - `FLUSH LOGS` and eventslog format switch now drain all known thread buffers before rotating, preventing dropped/misplaced buffered records Validation - Built modified objects directly - Ran full debug build with GENAI enabled: make clean && export PROXYSQLGENAI=1 && make debug -j24 Build completed successfully.	4 months ago
René Cannaò	568fe1524e	Merge pull request #5364 from mevishalr/feature/query-logging-improvements Optimize query logging performance (#5243)	4 months ago
René Cannaò	762afaa44f	Merge branch 'v3.0' into v4.0-mcp-stats Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	4882559239	Cleanup: Uncomment delete statsdb_disk in ProxySQL_Statistics destructor This ensures statsdb_disk is properly deallocated during ProxySQL_Statistics destruction, preventing a potential memory leak.	4 months ago
Rene Cannao	700459f67b	tsdb: address AI code review feedback, fix memory safety and logic bugs Summary of changes: - Fixed allocator mismatches (sqlite3_free vs free) across multiple files. - Converted manual SQL construction to prepared statements for TSDB variables. - Resolved memory leaks in statistics and monitoring loops. - Fixed critical 'LOAD TSDB VARIABLES FROM CONFIG' command mismatch. - Improved command parsing robustness using string searching. - Standardized SQL LIKE patterns with escaped wildcards (\%). - Switched to data-driven variable management in ProxySQL_Statistics. - Improved web dashboard security with URL encoding and const correctness. - Clarified documentation regarding configuration lifecycle and schema names. - Updated TAP tests for better reliability and correct persistence verification.	4 months ago
René Cannaò	10ff1322ba	Merge pull request #5386 from sysown/v3.0-MCP_multi MCP query+harvest hardening: HGM routing, weighted targets, pgsql harvest fix, TAP updates	4 months ago
Rene Cannao	3bb233e800	tsdb: commit missing REST API safety fixes	4 months ago
Rahim Kanji	db5f1ea498	Track query count for extended query protocol executions The queries_sent counter in stats.stats_pgsql_connection_pool was not being incremented for prepared statement executions (ASYNC_STMT_EXECUTE_START), only for regular queries (ASYNC_QUERY_START) and statement preparation (ASYNC_STMT_PREPARE_START).	4 months ago
Rahim Kanji	1b3d20388e	Reset current_hostgroup to default when no query rule matches In the extended query protocol flow (Parse/Bind/Execute/Sync messages), queries without matching query rules were incorrectly retaining the current_hostgroup value from the previous query instead of being reset to the default_hostgroup. This happened because: - Simple query protocol goes through STATE_SLEEP between queries, which resets current_hostgroup to default_hostgroup - Extended query protocol does NOT go through STATE_SLEEP between Parse/Bind/Execute messages, so current_hostgroup was never reset	4 months ago
Rene Cannao	253d098653	security: fix SQL injection vulnerabilities in SQLite catalog queries Address Gemini Code Assist review feedback on PR #5386: 1. Discovery_Schema::resolve_run_id - Replace string concatenation with replace_str escaping with proper parameterized queries using sqlite3_prepare_v2 and sqlite3_bind_* functions. 2. PgSQL_Static_Harvester - Remove unsafe escape_sql_string() function and replace its usages with: - New lookup_object_id() helper using parameterized queries - Parameterized UPDATE statements in harvest_view_definitions() These changes ensure complete protection against SQL injection for the catalog database, following the pattern already used in create_run().	4 months ago
Rene Cannao	2fa1401b05	MCP query+harvest hardening: HGM-based target routing, weighted backend selection, pgsql schema fix, and TAP robustness This squashed commit consolidates the recent MCP stabilization work across query execution and static-discovery tests. 1) Query endpoint routing/executability now uses Hostgroup Manager runtime snapshots - File: lib/Query_Tool_Handler.cpp - Removed dependency on direct SQL probes against runtime_mysql_servers/runtime_pgsql_servers from inside the MCP query handler path. - Target backend resolution now reuses the same Hostgroup Manager runtime snapshot APIs that feed Admin runtime server visibility: - MyHGM->dump_table_mysql("mysql_servers") - PgHGM->dump_table_pgsql("pgsql_servers") - Non-executable diagnostics now summarize statuses from HGM snapshots instead of ad hoc runtime-table SQL. 2) Backend endpoint selection changed to weighted random - File: lib/Query_Tool_Handler.cpp - Selection remains constrained by: - matching target hostgroup_id - ONLINE backend status - Candidate choice now uses random selection with linear probability by weight, replacing deterministic ordering. 3) Read-only validation and guardrail adjustments - File: lib/Query_Tool_Handler.cpp - Fixed false negatives for valid read-only queries such as SELECT literals (no FROM clause required). - Added additional dangerous-query patterns for file-write variants: - INTO OUTFILE - INTO DUMPFILE 4) PostgreSQL static harvester schema query fix - File: lib/PgSQL_Static_Harvester.cpp - Fixed harvest_schemas() failure on PostgreSQL caused by querying non-existent information_schema.schemata.default_collation_name. - Replaced with PostgreSQL-safe projection while preserving the insert_schema() column contract. 5) TAP reliability improvements for MCP test phases - File: test/tap/tests/mcp_rules_testing/test_phase11_pgsql_target.sh - Isolated phase state by clearing MCP rules before setup. - Added verbose response prints for T11.1-T11.4. - Added LOGENTRY phase start/end markers and EXIT trap for guaranteed end watermark. - Replaced fragile grep/escaping checks with robust string assertions. - Fixed NULL-concat stats assertions with COALESCE(username,'') and COALESCE(target_id,''). - File: test/tap/tests/test_mcp_static_harvest-t.sh - Hardened escaped-JSON parsing in MCP response checks (run_id extraction + key/value assertions). - Reworked target/protocol/object assertions to avoid transport-format false negatives. - Corrected cross-target negative assertion to check MCP isError semantics. Observed result in user verification - Phase 11 pgsql target/rules/stats checks pass. - Static harvest phase-A checks pass for mixed mysql/pgsql target_id flow. This commit intentionally keeps runtime ONLINE-only target executability semantics and improves observability/diagnostic quality for future MCP routing/test failures.	4 months ago
Rene Cannao	b8c6b4f573	tsdb: address code review comments and improve stability - Refactored variable flushing to use prepared statements for safety. - Replaced brittle command parsing with robust string searching. - Extracted TSDB dashboard HTML/JS to separate source file for maintainability. - Added NULL guards for GloProxyStats in Admin and REST API. - Implemented batched metric insertions using transactions for performance. - Refactored backend probing to use non-blocking connect() with timeout. - Fixed potential integer overflows in timer calculations. - Improved error handling and fixed memory leaks in statistics reporting. - Updated TAP tests to verify UI and REST API functionality.	4 months ago
Rene Cannao	9685cdaa4b	mcp discovery: enforce target-scoped run model and add protocol-aware static harvesting (mysql+pgsql) Refactor the MCP query/discovery stack to remove prototype-era MySQL-only assumptions and make discovery/catalog semantics explicitly target-scoped. This commit is intentionally not backward compatible with legacy single-target catalog metadata. Key implementation details: - Discovery_Schema: - runs table now stores target_id, protocol, and server_version - resolve_run_id() now requires target_id and resolves schemas within target scope - create_run() now records target/protocol/server version - added legacy schema detection + destructive catalog table rebuild when old runs layout is found - fixed resultset lifetime/escaping issues in target-aware run resolution - New PostgreSQL static harvester: - added PgSQL_Static_Harvester class and build wiring - harvests schemas/objects/columns/indexes/fks/view definitions into Discovery_Schema - maps pg metadata to object_id-based insert APIs used by Discovery_Schema - Query_Tool_Handler: - constructor simplified to catalog_path only (no mcp-mysql_* runtime ctor deps) - discovery.run_static now requires target_id and dispatches protocol-aware harvester at runtime - catalog., agent.run_start, and llm. tool contracts now require target_id when resolving run_id - all run_id resolution call sites switched to resolve_run_id(target_id, ...) - list_schemas catalog query now scoped by target_id via runs join - digest logging path now resolves run_id in target context - ProxySQL_MCP_Server: - updated Query_Tool_Handler construction to new signature - Docs updated: - added explicit target_id scoping guidance for discovery/catalog/agent/llm workflows - clarified protocol-aware routing and noted legacy examples still present in large script docs Build validation: - Recompiled changed objects with PROXYSQLGENAI=1: - Query_Tool_Handler.oo - Discovery_Schema.oo - PgSQL_Static_Harvester.oo - ProxySQL_MCP_Server.oo	4 months ago
Rene Cannao	7e54883ba5	mcp query debugging: surface rule-id context for blocks and add backend failure SQL details Observed confusion: - MCP failures like 'Error 100' / 'Error 101' were visible at endpoint level but gave no direct clue whether they came from query-rule blocks or backend execution failures. - Connection/firewall-style failures also lacked enough target/query context in lower-level logs. Changes in this commit: 1) Log MCP query-rule block/OK matches with rule id and context - In Discovery_Schema::evaluate_mcp_query_rules(): - when error_msg rule action is applied, log: rule_id, tool, target_id, schema, error_msg, query preview. - when OK_msg rule action is applied, log: rule_id, tool, target_id, schema, ok_msg. - This makes it explicit which runtime_mcp_query_rules row produced the returned error. 2) Add detailed backend execution error logs in Query_Tool_Handler - For MySQL and PostgreSQL execution paths (with and without schema switching), failures now log: - target_id - schema (when applicable) - backend error text - SQL query text - Added context for PG search_path failures too. - This disambiguates rule-block errors from actual backend connectivity/authorization/firewall failures. Behavioral notes: - API responses are unchanged (to avoid breaking tests expecting exact messages). - Logging is now sufficiently descriptive to trace each failure to either: - a specific MCP rule id/action, or - a concrete backend execution error. Validation: - Recompiled successfully: - lib/obj/Discovery_Schema.oo - lib/obj/Query_Tool_Handler.oo	4 months ago
Rene Cannao	8fbd570c79	mcp variables: stop writing runtime_global_variables during LOAD MCP VARIABLES TO RUNTIME Issue: - MCP variable load path was writing rows into runtime_global_variables. - For MCP this is incorrect and misleading; runtime_global_variables should not be used as a write target in this flow. - Logs showed explicit INSERT statements into runtime_global_variables for mcp-* entries. Fix implemented: 1) Removed runtime_global_variables population from MCP database->runtime flow - In flush_mcp_variables___database_to_runtime(), removed the block that called: flush_mcp_variables___runtime_to_database(..., runtime=true, ...) - LOAD MCP VARIABLES TO RUNTIME now applies mcp-* variables to GloMCPH and reloads MCP server state, without runtime_global_variables writes. 2) Removed runtime_global_variables writes from MCP runtime->database helper - In flush_mcp_variables___runtime_to_database(): - removed DELETE FROM runtime_global_variables WHERE variable_name LIKE 'mcp-%' - removed INSERT INTO runtime_global_variables(...) per variable - Function now persists MCP variables only to global_variables (main/disk paths), which is the intended save behavior. 3) Removed temporary MCP info-level debug noise related to runtime_global_variables inserts - Deleted MCP info logs that printed per-variable INSERT SQL into runtime_global_variables. Build validation: - Recompiled successfully: - lib/obj/Admin_FlushVariables.oo Expected result after this commit: - Executing LOAD MCP VARIABLES TO RUNTIME should no longer emit any INSERT/DELETE against runtime_global_variables for mcp-* variables. - MCP runtime behavior remains: variables are applied in-memory and MCP server reload logic is triggered via load_mcp_server().	4 months ago
Rene Cannao	f15460348c	mcp query diagnostics: include runtime hostgroup status breakdown when target lacks ONLINE backend Adds targeted debug context for non-executable MCP targets. When Query_Tool_Handler reports that a target has no ONLINE backend, it now appends a status summary read from the corresponding runtime server table for that hostgroup: - MySQL: runtime_mysql_servers - PostgreSQL: runtime_pgsql_servers Example diagnostics now include status aggregates such as: - ONLINE=0, SHUNNED=1 - OFFLINE_SOFT=1 - no rows in runtime_*_servers for hostgroup X This closes the observability gap where users saw 'target non-executable' but could not immediately tell why the hostgroup failed ONLINE eligibility. Validation: - Recompiled lib/obj/Query_Tool_Handler.oo successfully.	4 months ago
Rene Cannao	f4bc1943fb	mcp query diagnostics: restore strict ONLINE requirement and explain target non-executable failures This change does two things: 1) Reverts executable-target policy to strict ONLINE backend status - Query target resolution in Query_Tool_Handler is restored to require UPPER(status)='ONLINE' in runtime_mysql_servers/runtime_pgsql_servers. - This matches expected semantics: non-ONLINE backends should not be considered executable MCP targets. 2) Replaces generic non-executable errors with actionable diagnostics - Added Query_Tool_Handler::format_target_unavailable_error(target_id). - All query-tool paths that previously returned the generic: 'Target is not executable by this handler' now return a reasoned error with context, including: - target_id - protocol - hostgroup_id - auth_profile_id - concrete reason (for example: empty db_username in auth profile, or no ONLINE backend in runtime_*_servers) - Internal logs in get_connection()/get_pgsql_connection() now emit the same detailed reason. 3) Improves MCP endpoint failure logging with SQL/target context - In MCP_JSONRPC_Resource::handle_tools_call(), failed tool calls now log: - endpoint/tool/error - full arguments payload (existing) - additional parsed details when present: target_id, schema, sql (trimmed for safety) - This makes it explicit what SQL was requested when a tool call fails before execution. 4) Protocol normalization retained for robustness - MCP_Threads_Handler::load_target_auth_map() lowercases protocol values when loading runtime profile joins. - This avoids protocol-casing drift causing inconsistent routing behavior. Build validation: - Successfully recompiled modified objects: - lib/obj/Query_Tool_Handler.oo - lib/obj/MCP_Endpoint.oo - lib/obj/MCP_Thread.oo Resulting behavior expected on next test run: - If a target is non-executable, the response and logs will state exactly why (ONLINE/backend/auth reason), instead of a generic error. - Failure logs will also include the attempted SQL text (for tool calls that carry sql arguments), clarifying whether a backend query was actually executed or blocked before execution.	4 months ago
Rene Cannao	49f811a638	mcp query: stop misclassifying reachable targets as non-executable Observed failure: - MCP tools received valid target_id values, but /mcp/query returned 'Target is not executable by this handler'. - This prevented rule evaluation, digest accounting, and hit counters from advancing, causing multiple TAP phases to fail. Root cause addressed in this commit: - Target endpoint resolution required runtime server status to be exactly ONLINE. - In practice, reachable backends can temporarily appear in other statuses (for example monitor-related transitions), while MCP direct connections with profile credentials are still valid. - Protocol casing inconsistencies could also lead to fragile routing behavior when profile data is consumed. Changes: 1) Relax backend eligibility during endpoint resolution - In Query_Tool_Handler::refresh_target_registry(), endpoint discovery now accepts any server status except OFFLINE_HARD. - ONLINE is still preferred deterministically via ORDER BY, but non-ONLINE candidates remain eligible for MCP execution. 2) Normalize protocol values to lowercase - In MCP_Threads_Handler::load_target_auth_map(), target protocol is normalized to lowercase when loaded from runtime profiles. - In Query_Tool_Handler::refresh_target_registry(), protocol is normalized again defensively before routing decisions. 3) Improve diagnostics for target executability - Added explicit warnings when: - a target resolves to a backend but has empty db_username, - a target has no eligible backend for its hostgroup/protocol. - These logs make it clear why a target is being marked non-executable. Expected behavioral impact: - MCP query tools should execute for valid target_id entries even when monitor status is not strictly ONLINE. - Query-rules blocking/rewriting/OK actions should be exercised again. - stats_mcp_query_rules hits and stats_mcp_query_digest counters should resume incrementing once queries run. Validation performed: - Recompiled modified objects successfully: - lib/obj/Query_Tool_Handler.oo - lib/obj/MCP_Thread.oo	4 months ago
Rene Cannao	6a788e48c4	mcp: make /mcp/query self-healing when targets/backends appear after startup Problem addressed: - MCP query endpoint could stay unusable with 'Tool Handler not initialized' after restart/reload flows. - This was triggered when Query_Tool_Handler could not build an executable pool at init time (for example profiles loaded before ONLINE servers), leaving runtime commands like 'LOAD MCP QUERY RULES FROM MEMORY' blocked behind a NULL query tool handler. - Users had to manually toggle MCP enablement to recover, which is the opposite of expected self-healing behavior. What this commit changes: 1) Query_Tool_Handler pool init is now resilient and idempotent - init_connection_pool() now starts with close() so reinitialization fully resets stale mysql/pgsql pool state before rebuilding from runtime profile + server tables. - If no executable targets are available, init_connection_pool() now returns success with a warning instead of hard failure. This allows the query tool handler (and /mcp/query endpoint) to stay initialized even before backends are ready. 2) Lazy auto-rebuild on first query usage - get_connection() and get_pgsql_connection() now: - refresh target registry before resolution, - attempt to use an existing pooled connection, - if unavailable, trigger a full pool rebuild (init_connection_pool()) and retry once. - This provides automatic recovery when hostgroups/servers/profiles are loaded or changed after MCP startup, without requiring manual MCP disable/enable. 3) Admin runtime rule load path attempts MCP recovery - load_mcp_query_rules_to_runtime() now detects NULL query tool handler and calls load_mcp_server() once before failing. - This turns a hard, immediate admin error into a self-recovery attempt consistent with MCP runtime semantics. Behavioral impact: - /mcp/query endpoint remains online even when there are temporarily zero executable targets. - As soon as compatible runtime targets/backends exist, run_sql_readonly/explain_sql can recover automatically on demand. - LOAD MCP QUERY RULES TO/FROM RUNTIME no longer fails immediately on first NULL handler condition; it retries after MCP server recovery. Validation performed: - Recompiled modified objects successfully: - lib/obj/Query_Tool_Handler.oo - lib/obj/ProxySQL_Admin.oo - Full TAP runtime test execution is not possible in this sandbox due blocked local TCP socket creation; validation should be run in the normal test environment where ProxySQL/MySQL/PGSQL are reachable.	4 months ago
Rene Cannao	998bd82387	MCP TAP startup: fix tool-handler initialization order, improve MCP PROFILES observability, and seed monitor users This change fixes recurring MCP TAP failures where `/mcp/query` returned: Tool Handler not initialized for endpoint: query and where backend monitor auth failures flooded logs. Problem summary - MCP server startup can occur before runtime target/auth profiles and backend server mappings are loaded. - If that happens, Query_Tool_Handler initialization sees no executable targets and remains NULL. - MCP endpoint resources bind the handler pointer at creation time, so a NULL query handler at startup breaks `/mcp/query` until server restart. Code changes 1) Add explicit admin command logging for MCP PROFILES commands - Added `Received <command>` logging in the MCP PROFILES command block, matching behavior of other admin command handlers. - File: `lib/Admin_Handler.cpp` 2) Trigger MCP server refresh after `LOAD MCP PROFILES TO RUNTIME` - After copying profiles into runtime and rebuilding target/auth map, call `ProxySQL_Admin::load_mcp_server()`. - This allows MCP to self-heal when profiles become available after initial startup. - File: `lib/Admin_Handler.cpp` 3) Restart MCP server when query handler is missing - Extended `ProxySQL_Admin::load_mcp_server()` restart checks to include: - running server + `query_tool_handler == NULL` - Restart reason now includes tool handler initialization mismatch. - File: `lib/ProxySQL_Admin.cpp` 4) Fix TAP configurator load order to avoid early MCP startup - Reordered `test/tap/tests/mcp_rules_testing/configure_mcp.sh` runtime sequence: - `LOAD MYSQL SERVERS TO RUNTIME` - `LOAD PGSQL SERVERS TO RUNTIME` (best effort) - `LOAD MCP PROFILES TO RUNTIME` - `LOAD MCP VARIABLES TO RUNTIME` (last) - This ensures MCP starts only after routing/auth context is present. 5) Seed monitor credentials in AI local infra pre-hook - Added backend user/role creation for default monitor credentials `monitor/monitor`: - MySQL: create user + monitor-relevant grants - PostgreSQL: create role + `pg_monitor` + DB connect grants - Reduces monitor auth noise in local AI TAP dockerized setup. - File: `test/tap/groups/ai/pre-proxysql.bash` 6) Mark new TAP phase scripts executable - `test_phase10_eval_explain.sh` - `test_phase11_pgsql_target.sh` Expected outcome - MCP query endpoint no longer stays stuck with an uninitialized tool handler after TAP configuration. - MCP query-rules admin commands stop failing due to missing Query_Tool_Handler. - MCP profile command flow is visible in logs for easier debugging. - Local AI TAP infra no longer emits continuous monitor authentication failures for default monitor credentials.	4 months ago
Rene Cannao	af0411bd46	MCP: add target-aware rules/stats tests, explain_sql rule coverage, and AI local docker TAP infra This commit completes end-to-end MCP query-rules validation for multi-target routing and introduces a self-contained TAP infra for the `ai` group that can run both in Jenkins and manually. Main MCP/runtime changes: - Extended MCP query-rule matching context to include both `target_id` and resolved backend `username`. - Added `target_id` column to `mcp_query_rules` and `runtime_mcp_query_rules` table definitions. - Extended `stats_mcp_query_rules` to include `username` and `target_id` alongside `rule_id` and `hits`. - Updated load/save/runtime refresh paths to persist and rehydrate the expanded MCP rule schema. - Wired the rule engine into `explain_sql` so MCP rules apply consistently across `run_sql_readonly` and `explain_sql`. - Included startup-order fix in `src/main.cpp` to initialize MCP/GenAI thread handlers early, preventing startup crashes in PROXYSQLGENAI builds. Test coverage changes: - Updated existing MCP TAP phases to assert target-aware and username-aware behavior: - `test_phase4_stats.sh` - `test_phase6_eval_block.sh` - Added new MCP TAP phases: - `test_phase10_eval_explain.sh` (rule engine coverage for `explain_sql`) - `test_phase11_pgsql_target.sh` (pgsql target routing/rule/stats coverage; graceful skip if no pgsql target is configured) - Updated `test_mcp_query_rules-t.sh` runner to execute new phases. AI group isolated infra (manual + CI compatible): - Added `test/tap/groups/ai/docker-compose.yml` with MySQL 9.0 and PostgreSQL 16 backends. - Added lifecycle scripts: - `docker-compose-init.bash` - `docker-compose-destroy.bash` - `pre-proxysql.bash` - `post-proxysql.bash` - Extended `test/tap/groups/ai/env.sh` with local default ports/credentials/target IDs used by MCP TAP tests. - Added `test/tap/groups/ai/README.md` documenting manual execution flow outside Jenkins. Outcome: - MCP tests now validate routing-aware rule enforcement and stats attribution for both MySQL and PostgreSQL targets. - The `ai` TAP group can be run with an isolated local backend stack without relying on external Jenkins infra repositories.	4 months ago
René Cannaò	28b1114cd9	Merge pull request #5353 from sysown/v3.0_pgsql-prepared-statement-refcount-race-5352 Fix PostgreSQL prepared statement purge crash: use memory_order_acquire instead of memory_order_relaxed	4 months ago
jesmarcannao	db40505d18	Fix #2233 : Mirror sessions destination_hostgroup overwritten by fast routing Bug fix: - Mirror sessions had their destination_hostgroup incorrectly overwritten by fast routing rules, causing duplicate query execution to the same hostgroup - Added check in Query_Processor.cpp to skip fast routing for mirror sessions Changes: - lib/Query_Processor.cpp: Wrapped fast routing logic with mirror session check - test/tap/tests/reg_test_2233_mirror_fast_routing-t.cpp: New regression test - test/tap/groups/groups.json: Added test to default-g1 test group - test/tap/tests/Makefile: Added build rule for the new test (commented out) The fix ensures mirror sessions maintain their assigned destination_hostgroup and are not affected by fast routing rules.	4 months ago
Rene Cannao	013864b36f	MCP: introduce profile-based target/auth routing and unified LOAD/SAVE MCP PROFILES commands This commit introduces the core MCP routing architecture that decouples client-facing target selection from backend connection details. Architecture introduced: - New MCP auth profile table to store backend credentials/policy (`mcp_auth_profiles`). - New MCP target profile table to map opaque `target_id` -> protocol/hostgroup/auth profile (`mcp_target_profiles`). - Runtime mirrors for both profile tables. Behavioral changes: - MCP query tools resolve execution context by `target_id` and route internally by protocol + hostgroup. - Client no longer needs backend-specific connection details; only logical target identifiers. - Unified admin commands for profile lifecycle management: - `LOAD MCP PROFILES TO/FROM MEMORY/RUNTIME/DISK` - `SAVE MCP PROFILES TO/FROM MEMORY/RUNTIME/DISK` Design goals: - Support multi-backend MCP execution (MySQL + PostgreSQL) behind one endpoint. - Provide server-side credential management and cleaner operational model. - Replace legacy one-backend POC configuration with scalable target/auth abstractions. Result: - MCP routing is now dynamic, protocol-agnostic at the client layer, and fully managed through profile tables and unified load/save commands.	4 months ago
Rene Cannao	5f5b7d604f	tsdb: improve administrative interface and command support - Move 'stats_tsdb' to 'main' schema for better visibility in 'SHOW TSDB STATUS'. - Implement 'PROXYSQL TSDB DOWNSAMPLE' command to trigger manual metrics aggregation. - Ensure 'SHOW TSDB STATUS' triggers a statistics refresh before returning data. - Integrate 'tsdb-' variables into 'runtime_global_variables' refresh logic. - Update TAP tests to verify new commands and improve troubleshooting output.	4 months ago
Rene Cannao	a09db8318c	tsdb: fix SET command validation by adding tsdb- prefix support	4 months ago
Rene Cannao	6587bfdd40	tsdb: trigger stats refresh on SHOW TSDB STATUS	4 months ago
Rene Cannao	2d51aeff64	tsdb: correctly implement SHOW TSDB commands and variable initialization	4 months ago
Rahim Kanji	b3e8955adb	Fixed error handling	4 months ago
Rene Cannao	6404d7b365	tsdb: implement SHOW TSDB VARIABLES and SHOW TSDB STATUS	4 months ago
Rahim Kanji	409070faa7	Add PostgreSQL \d tablename describe table support in Admin Handler Extend \d meta-command to support \d tablename for describing specific tables. Implements handlers for all 8 queries in the describe sequence: - Query 1: pg_class lookup with c.relname OPERATOR (extracts/caches table) - Query 2: pg_class attributes with c.oid= (table metadata) - Query 3: pg_attribute with PRAGMA table_info() (column information) - Queries 4-8: pg_policy, pg_statistic_ext, pg_publication, pg_inherits (return empty results as SQLite lacks these features)	4 months ago
Rene Cannao	c73011b302	tsdb: implement REST API and basic UI dashboard	4 months ago
Rene Cannao	4e0f94a345	tsdb: fix compilation error in ProxySQL_Admin.cpp	4 months ago
Rene Cannao	a236a13787	tsdb: dedicated module for TSDB variables with tsdb- prefix and optimized background tasks	4 months ago
Rene Cannao	da877c378b	tsdb: align admin variable lifecycle, full prometheus ingestion, docs and tap coverage	4 months ago
Rene Cannao	f17e999830	Implement SQLite-based TSDB subsystem Add time-series database extension to ProxySQL_Statistics with: - Three SQLite tables: tsdb_metrics, tsdb_metrics_hour, tsdb_backend_health - Automatic downsampling from raw to hourly aggregates - Retention management (7 days raw, 1 year hourly) - Prometheus metrics sampling - Backend health monitoring via TCP probes - SQL query interface with JSON label filtering - Admin variable integration Documentation: - embedded_tsdb_overview.md - Architecture and benefits - embedded_tsdb_architecture.md - System design and components - embedded_tsdb_reference.md - Configuration and API reference - embedded_tsdb_specs.md - Technical specifications - embedded_tsdb_quickstart.md - Getting started guide All 4 build combinations pass: - make debug / make release - PROXYSQLGENAI=1 make debug / make release	4 months ago
René Cannaò	5de836a4c1	Merge pull request #5373 from sysown/v3.0_improve_mysql_monitoring_5256 Improve MySQL Monitor connection management	4 months ago
René Cannaò	3b578db4bf	Merge pull request #5374 from sysown/v3.0-test0213 Fix Valgrind-reported uninitialized memory issues	4 months ago
René Cannaò	83209da487	Merge pull request #5356 from sysown/v3.0-5355 Fix #5355: Add null pointer check in RequestEnd() to prevent use-after-free crash	4 months ago
Rene Cannao	37e72ea3f9	Fix PROXY protocol detection in MySQL_Data_Stream::read_from_net When pkts_recv==0, the code reads 4 bytes expecting a MySQL packet header, but PROXY protocol starts with 'PROXY ' which gets misinterpreted as a MySQL header with a huge packet length (0x504f5250 = ~1.3GB). Add check for 'PROX' prefix before parsing as MySQL header. This prevents passing an incorrect length parameter to recv() that exceeds the buffer size. Fixes #5376	4 months ago
Rene Cannao	11a43bf768	Fix uninitialized max_allowed_pkt in MySQL_Connection constructor Initialize options.max_allowed_pkt to 0 to prevent Valgrind errors when logging handshake debug information.	4 months ago
Rene Cannao	ca4f858b29	Fix uninitialized memory read in pgsql tokenizer Change malloc() to calloc() in get_result_buffer() to zero-initialize the query digest buffer before use. This prevents stage_2_parsing() from reading uninitialized memory when processing query digests. Fixes #5375	4 months ago
Rene Cannao	85952373d9	Fix uninitialized mondb pointer in MySQL_Monitor_State_Data constructor Add mondb = NULL initialization to prevent Valgrind errors when monitor threads access the pointer before it's properly set.	4 months ago
Rahim Kanji	8ca6323eef	Merge remote-tracking branch 'Master/v3.0' into v3.0_pgsql-prepared-statement-refcount-race-5352	4 months ago
Rene Cannao	200fdecb8d	Apply AI agent review fixes to PR #5374 Critical Fixes: - Fix NULL pointer dereferences in MySQL_Logger.cpp: * Add null checks for myds->myconn->parent in log_audit_entry() * Fix cleanup code in log_request() and log_audit_entry() * Change sprintf to snprintf for buffer safety - Remove redundant pthread_rwlock_init in debug.cpp: * filters_rwlock already initialized with PTHREAD_RWLOCK_INITIALIZER * Re-initialization caused undefined behavior per POSIX Major Improvements: - Add bounded wait helper wait_for_glo_mth() in proxysql_utils.h: * Replaces indefinite while loops with 10s timeout * Applied to 26 locations across 4 files Build System: - Require C++17 in Makefile (remove C++11 fallback): * Code uses C++17 structured bindings extensively * Cleanest solution vs adding fallback guards to 27+ locations Compilation fixes: - Add unistd.h include for usleep - Remove conflicting GloMyMon extern declaration Files changed: - Makefile - include/proxysql_utils.h - lib/MySQL_Logger.cpp - lib/debug.cpp - lib/MySQL_Monitor.cpp - lib/ProxySQL_Admin.cpp - lib/ClickHouse_Server.cpp - src/SQLite3_Server.cpp	4 months ago
Rahim Kanji	1cccfb3220	Fix connection cleanup in failure paths	4 months ago
Rene Cannao	941e6b7320	Fix filters_rwlock initialization race condition Add static initialization PTHREAD_RWLOCK_INITIALIZER to filters_rwlock in debug.cpp to prevent race condition where proxy_debug() is called before init_debug_struct() initializes the rwlock. This fixes Valgrind errors in filter_debug_entry() where threads were accessing an uninitialized rwlock.	4 months ago
Rene Cannao	3c85c593cf	Add GloMTH initialization wait to all monitor and server threads Fix race condition where threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int() and related functions. Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to ensure GloMTH is fully initialized before use: In lib/MySQL_Monitor.cpp: - monitor_connect(), monitor_ping(), monitor_read_only() - monitor_group_replication(), monitor_galera(), monitor_replication_lag() - monitor_AWS_Aurora_thread_HG(), monitor_aws_aurora() - init_mysql_thread_struct() In src/SQLite3_Server.cpp: - SQLite3_Server_session_handler In lib/ProxySQL_Admin.cpp: - admin_session_handler In lib/ClickHouse_Server.cpp: - ClickHouse_Server_session_handler The pattern ensures threads wait for GloMTH initialization during startup, then check for NULL during shutdown to exit cleanly.	4 months ago
Rene Cannao	aa53d990ed	Add GloMTH initialization wait to all monitor threads Fix race condition where monitor threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int(). Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to: - monitor_ping_thread - monitor_read_only_thread - monitor_replication_lag_thread - monitor_group_replication_thread (also moved check before MySQL_Thread creation) - monitor_galera_thread (also moved check before MySQL_Thread creation) This matches the existing pattern in monitor_connect_thread.	4 months ago
Rene Cannao	f4cd34be5c	Fix race condition in monitor_connect_thread Add wait loop for GloMTH initialization before accessing variables. Other monitor threads (MonitorPing, MonitorReadOnly, etc.) already had this pattern, but monitor_connect_thread was missing it. This fixes Valgrind errors about uninitialized values in get_variable_uint16() when strcasecmp reads from memory that hasn't been fully initialized yet.	4 months ago

1 2 3 4 5 ...

5113 Commits (mysqlx-plugin-impl)