mirror of https://github.com/sysown/proxysql
Rene Cannao
3 weeks ago
commit
54bcb5eeca
@ -0,0 +1,168 @@
|
||||
/**
|
||||
* @file issue5384-t.cpp
|
||||
* @brief This test file verifies the functionality of the mysql-query_processor_first_comment_parsing variable.
|
||||
* - Sets mysql-query_processor_first_comment_parsing=1 (before rules)
|
||||
* - Sets a rule to strip the comment.
|
||||
* - Verifies that the comment is still parsed even if stripped by a rule.
|
||||
*/
|
||||
|
||||
#include <cstdio>
|
||||
#include <cstring>
|
||||
|
||||
#include "command_line.h"
|
||||
#include "mysql.h"
|
||||
#include "tap.h"
|
||||
#include "utils.h"
|
||||
|
||||
int main(int, char**) {
|
||||
CommandLine cl;
|
||||
if (cl.getEnv()) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
plan(3);
|
||||
|
||||
MYSQL* admin = init_mysql_conn(cl.host, cl.admin_port, cl.admin_username, cl.admin_password);
|
||||
if (!admin) {
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
MYSQL* proxy = init_mysql_conn(cl.host, cl.port, cl.username, cl.password);
|
||||
if (!proxy) {
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
diag(" ========== Test 1: Default behavior (parsed after rules) ==========");
|
||||
// By default (2), comment is parsed AFTER rules.
|
||||
// If a rule strips the comment, it won't be parsed.
|
||||
const char *q_del_rules = "DELETE FROM mysql_query_rules";
|
||||
diag("Running on Admin: %s", q_del_rules);
|
||||
MYSQL_QUERY_T(admin, q_del_rules);
|
||||
|
||||
// Rule to strip the comment. Improved regex to be non-greedy and optional trailing space.
|
||||
const char *q_ins_rule = "INSERT INTO mysql_query_rules (rule_id, active, match_pattern, replace_pattern, apply) VALUES (1, 1, '/\\\\*.*?\\\\*/ ?', '', 1)";
|
||||
diag("Running on Admin: %s", q_ins_rule);
|
||||
MYSQL_QUERY_T(admin, q_ins_rule);
|
||||
|
||||
const char *q_load_rules = "LOAD MYSQL QUERY RULES TO RUNTIME";
|
||||
diag("Running on Admin: %s", q_load_rules);
|
||||
MYSQL_QUERY_T(admin, q_load_rules);
|
||||
|
||||
const char *q_set_var = "SET mysql-query_processor_first_comment_parsing = 2";
|
||||
diag("Running on Admin: %s", q_set_var);
|
||||
MYSQL_QUERY_T(admin, q_set_var);
|
||||
|
||||
const char *q_load_vars = "LOAD MYSQL VARIABLES TO RUNTIME";
|
||||
diag("Running on Admin: %s", q_load_vars);
|
||||
MYSQL_QUERY_T(admin, q_load_vars);
|
||||
|
||||
const char *q_truncate = "TRUNCATE stats_mysql_query_digest";
|
||||
diag("Running on Admin: %s", q_truncate);
|
||||
MYSQL_QUERY_T(admin, q_truncate);
|
||||
|
||||
// We use hostgroup=1000 which likely doesn't exist or is different from default
|
||||
const char *query = "/*+ hostgroup=1000 */ SELECT 1";
|
||||
diag("Running on Proxy: %s", query);
|
||||
run_q(proxy, query);
|
||||
|
||||
// Check stats to see if hostgroup 1000 was used
|
||||
const char *q_stats = "SELECT destination_hostgroup FROM stats_mysql_query_digest WHERE digest_text='SELECT ?'";
|
||||
diag("Running on Admin: %s", q_stats);
|
||||
if (mysql_query_t(admin, q_stats)) {
|
||||
fprintf(stderr, "File %s, line %d, Error: %s\n", __FILE__, __LINE__, mysql_error(admin));
|
||||
return exit_status();
|
||||
}
|
||||
MYSQL_RES *res = mysql_store_result(admin);
|
||||
if (res) {
|
||||
MYSQL_ROW row = mysql_fetch_row(res);
|
||||
if (row) {
|
||||
int hg = atoi(row[0]);
|
||||
ok(hg != 1000, "Comment should NOT have been parsed because it was stripped by rule. hg=%d", hg);
|
||||
} else {
|
||||
ok(0, "Failed to find query in stats (Test 1)");
|
||||
}
|
||||
mysql_free_result(res);
|
||||
} else {
|
||||
ok(0, "mysql_store_result returned NULL (Test 1)");
|
||||
}
|
||||
|
||||
diag(" ========== Test 2: New behavior (parsed before rules) ==========");
|
||||
const char *q_set_var2 = "SET mysql-query_processor_first_comment_parsing = 1";
|
||||
diag("Running on Admin: %s", q_set_var2);
|
||||
MYSQL_QUERY_T(admin, q_set_var2);
|
||||
|
||||
diag("Running on Admin: %s", q_load_vars);
|
||||
MYSQL_QUERY_T(admin, q_load_vars);
|
||||
|
||||
diag("Running on Admin: %s", q_truncate);
|
||||
MYSQL_QUERY_T(admin, q_truncate);
|
||||
|
||||
diag("Running on Proxy: %s", query);
|
||||
run_q(proxy, query);
|
||||
|
||||
diag("Running on Admin: %s", q_stats);
|
||||
if (mysql_query_t(admin, q_stats)) {
|
||||
fprintf(stderr, "File %s, line %d, Error: %s\n", __FILE__, __LINE__, mysql_error(admin));
|
||||
return exit_status();
|
||||
}
|
||||
res = mysql_store_result(admin);
|
||||
if (res) {
|
||||
MYSQL_ROW row = mysql_fetch_row(res);
|
||||
if (row) {
|
||||
int hg = atoi(row[0]);
|
||||
ok(hg == 1000, "Comment SHOULD have been parsed BEFORE it was stripped by rule. hg=%d", hg);
|
||||
} else {
|
||||
ok(0, "Failed to find query in stats (Test 2)");
|
||||
}
|
||||
mysql_free_result(res);
|
||||
} else {
|
||||
ok(0, "mysql_store_result returned NULL (Test 2)");
|
||||
}
|
||||
|
||||
diag(" ========== Test 3: Both passes (mode 3) ==========");
|
||||
// In mode 3, it parses before and after. If stripped, it should still work due to the before pass.
|
||||
const char *q_set_var3 = "SET mysql-query_processor_first_comment_parsing = 3";
|
||||
diag("Running on Admin: %s", q_set_var3);
|
||||
MYSQL_QUERY_T(admin, q_set_var3);
|
||||
|
||||
diag("Running on Admin: %s", q_load_vars);
|
||||
MYSQL_QUERY_T(admin, q_load_vars);
|
||||
|
||||
diag("Running on Admin: %s", q_truncate);
|
||||
MYSQL_QUERY_T(admin, q_truncate);
|
||||
|
||||
diag("Running on Proxy: %s", query);
|
||||
run_q(proxy, query);
|
||||
|
||||
diag("Running on Admin: %s", q_stats);
|
||||
if (mysql_query_t(admin, q_stats)) {
|
||||
fprintf(stderr, "File %s, line %d, Error: %s\n", __FILE__, __LINE__, mysql_error(admin));
|
||||
return exit_status();
|
||||
}
|
||||
res = mysql_store_result(admin);
|
||||
if (res) {
|
||||
MYSQL_ROW row = mysql_fetch_row(res);
|
||||
if (row) {
|
||||
int hg = atoi(row[0]);
|
||||
ok(hg == 1000, "Comment SHOULD have been parsed in the BEFORE pass (mode 3). hg=%d", hg);
|
||||
} else {
|
||||
ok(0, "Failed to find query in stats (Test 3)");
|
||||
}
|
||||
mysql_free_result(res);
|
||||
} else {
|
||||
ok(0, "mysql_store_result returned NULL (Test 3)");
|
||||
}
|
||||
|
||||
// Teardown: restore defaults
|
||||
diag("Teardown: restoring defaults");
|
||||
MYSQL_QUERY_T(admin, "DELETE FROM mysql_query_rules WHERE rule_id=1");
|
||||
MYSQL_QUERY_T(admin, "LOAD MYSQL QUERY RULES TO RUNTIME");
|
||||
MYSQL_QUERY_T(admin, "SET mysql-query_processor_first_comment_parsing = 2");
|
||||
MYSQL_QUERY_T(admin, "LOAD MYSQL VARIABLES TO RUNTIME");
|
||||
|
||||
mysql_close(admin);
|
||||
mysql_close(proxy);
|
||||
|
||||
return exit_status();
|
||||
}
|
||||
@ -0,0 +1,159 @@
|
||||
/**
|
||||
* @file pgsql-issue5384-t.cpp
|
||||
* @brief This test file verifies the functionality of the pgsql-query_processor_first_comment_parsing variable.
|
||||
* - Sets pgsql-query_processor_first_comment_parsing=1 (before rules)
|
||||
* - Sets a rule to strip the comment.
|
||||
* - Verifies that the comment is still parsed even if stripped by a rule.
|
||||
*/
|
||||
|
||||
#include <unistd.h>
|
||||
#include <string>
|
||||
#include <sstream>
|
||||
#include <chrono>
|
||||
#include <thread>
|
||||
#include <vector>
|
||||
#include <utility>
|
||||
#include <memory>
|
||||
#include "libpq-fe.h"
|
||||
#include "command_line.h"
|
||||
#include "tap.h"
|
||||
#include "utils.h"
|
||||
|
||||
CommandLine cl;
|
||||
|
||||
using PGConnPtr = std::unique_ptr<PGconn, decltype(&PQfinish)>;
|
||||
|
||||
enum ConnType {
|
||||
ADMIN,
|
||||
BACKEND
|
||||
};
|
||||
|
||||
PGConnPtr createNewConnection(ConnType conn_type, const std::string& options = "", bool with_ssl = false) {
|
||||
const char* host = (conn_type == BACKEND) ? cl.pgsql_host : cl.pgsql_admin_host;
|
||||
int port = (conn_type == BACKEND) ? cl.pgsql_port : cl.pgsql_admin_port;
|
||||
const char* username = (conn_type == BACKEND) ? cl.pgsql_username : cl.admin_username;
|
||||
const char* password = (conn_type == BACKEND) ? cl.pgsql_password : cl.admin_password;
|
||||
|
||||
std::stringstream ss;
|
||||
ss << "host=" << host << " port=" << port;
|
||||
ss << " user=" << username << " password=" << password;
|
||||
ss << (with_ssl ? " sslmode=require" : " sslmode=disable");
|
||||
|
||||
if (options.empty() == false) {
|
||||
ss << " options='" << options << "'";
|
||||
}
|
||||
|
||||
PGconn* conn = PQconnectdb(ss.str().c_str());
|
||||
if (PQstatus(conn) != CONNECTION_OK) {
|
||||
diag("Connection failed to '%s': %s",
|
||||
(conn_type == BACKEND ? "Backend" : "Admin"),
|
||||
PQerrorMessage(conn));
|
||||
PQfinish(conn);
|
||||
return PGConnPtr(nullptr, &PQfinish);
|
||||
}
|
||||
return PGConnPtr(conn, &PQfinish);
|
||||
}
|
||||
|
||||
int get_query_hg_from_stats(PGconn* admin, const char* query_digest_text) {
|
||||
std::stringstream ss;
|
||||
ss << "SELECT destination_hostgroup FROM stats_pgsql_query_digest WHERE digest_text='" << query_digest_text << "'";
|
||||
PGresult* res = PQexec(admin, ss.str().c_str());
|
||||
if (PQresultStatus(res) != PGRES_TUPLES_OK) {
|
||||
diag("Failed to get query stats: %s", PQerrorMessage(admin));
|
||||
PQclear(res);
|
||||
return -1;
|
||||
}
|
||||
int hg = -1;
|
||||
if (PQntuples(res) > 0) {
|
||||
char *val = PQgetvalue(res, 0, 0);
|
||||
if (val) {
|
||||
hg = atoi(val);
|
||||
}
|
||||
}
|
||||
PQclear(res);
|
||||
return hg;
|
||||
}
|
||||
|
||||
int main(int argc, char** argv) {
|
||||
if (cl.getEnv()) {
|
||||
diag("Failed to get the required environmental variables.");
|
||||
return -1;
|
||||
}
|
||||
|
||||
plan(3);
|
||||
|
||||
PGConnPtr admin = createNewConnection(ADMIN);
|
||||
if (!admin) {
|
||||
BAIL_OUT("Failed to connect to admin interface");
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
PGConnPtr proxy = createNewConnection(BACKEND);
|
||||
if (!proxy) {
|
||||
BAIL_OUT("Failed to connect to proxy");
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
diag(" ========== Test 1: Default behavior (parsed after rules) ==========");
|
||||
PQclear(PQexec(admin.get(), "DELETE FROM pgsql_query_rules"));
|
||||
|
||||
// Rule to strip the comment. PostgreSQL comments can be /* */ or --
|
||||
// Note: the regex needs to match the comment format used in the test query.
|
||||
PQclear(PQexec(admin.get(), "INSERT INTO pgsql_query_rules (rule_id, active, match_pattern, replace_pattern, apply) VALUES (1, 1, '/\\\\*.*?\\\\*/ ?', '', 1)"));
|
||||
PQclear(PQexec(admin.get(), "LOAD PGSQL QUERY RULES TO RUNTIME"));
|
||||
|
||||
PQclear(PQexec(admin.get(), "SET pgsql-query_processor_first_comment_parsing = 2"));
|
||||
PQclear(PQexec(admin.get(), "LOAD PGSQL VARIABLES TO RUNTIME"));
|
||||
|
||||
PQclear(PQexec(admin.get(), "TRUNCATE stats_pgsql_query_digest"));
|
||||
|
||||
const char *query = "/*+ hostgroup=1000 */ SELECT 1";
|
||||
diag("Running on Proxy: %s", query);
|
||||
PQclear(PQexec(proxy.get(), query));
|
||||
|
||||
int hg = get_query_hg_from_stats(admin.get(), "SELECT ?");
|
||||
if (hg != -1) {
|
||||
ok(hg != 1000, "Comment should NOT have been parsed because it was stripped by rule. hg=%d", hg);
|
||||
} else {
|
||||
ok(0, "Failed to find query in stats (Test 1)");
|
||||
}
|
||||
|
||||
diag(" ========== Test 2: New behavior (parsed before rules) ==========");
|
||||
PQclear(PQexec(admin.get(), "SET pgsql-query_processor_first_comment_parsing = 1"));
|
||||
PQclear(PQexec(admin.get(), "LOAD PGSQL VARIABLES TO RUNTIME"));
|
||||
PQclear(PQexec(admin.get(), "TRUNCATE stats_pgsql_query_digest"));
|
||||
|
||||
diag("Running on Proxy: %s", query);
|
||||
PQclear(PQexec(proxy.get(), query));
|
||||
|
||||
hg = get_query_hg_from_stats(admin.get(), "SELECT ?");
|
||||
if (hg != -1) {
|
||||
ok(hg == 1000, "Comment SHOULD have been parsed BEFORE it was stripped by rule. hg=%d", hg);
|
||||
} else {
|
||||
ok(0, "Failed to find query in stats (Test 2)");
|
||||
}
|
||||
|
||||
diag(" ========== Test 3: Both passes (mode 3) ==========");
|
||||
PQclear(PQexec(admin.get(), "SET pgsql-query_processor_first_comment_parsing = 3"));
|
||||
PQclear(PQexec(admin.get(), "LOAD PGSQL VARIABLES TO RUNTIME"));
|
||||
PQclear(PQexec(admin.get(), "TRUNCATE stats_pgsql_query_digest"));
|
||||
|
||||
diag("Running on Proxy: %s", query);
|
||||
PQclear(PQexec(proxy.get(), query));
|
||||
|
||||
hg = get_query_hg_from_stats(admin.get(), "SELECT ?");
|
||||
if (hg != -1) {
|
||||
ok(hg == 1000, "Comment SHOULD have been parsed in the BEFORE pass (mode 3). hg=%d", hg);
|
||||
} else {
|
||||
ok(0, "Failed to find query in stats (Test 3)");
|
||||
}
|
||||
|
||||
// Teardown
|
||||
diag("Teardown: restoring defaults");
|
||||
PQclear(PQexec(admin.get(), "DELETE FROM pgsql_query_rules WHERE rule_id=1"));
|
||||
PQclear(PQexec(admin.get(), "LOAD PGSQL QUERY RULES TO RUNTIME"));
|
||||
PQclear(PQexec(admin.get(), "SET pgsql-query_processor_first_comment_parsing = 2"));
|
||||
PQclear(PQexec(admin.get(), "LOAD PGSQL VARIABLES TO RUNTIME"));
|
||||
|
||||
return exit_status();
|
||||
}
|
||||
Loading…
Reference in new issue