5113 Commits (mysqlx-plugin-impl)

Author	SHA1	Message	Date
Rene Cannao	e53d2c76f9	Address PR #5410 review findings across FFTO, sessions, TAP, and docs ... Apply actionable bot review feedback from PR #5410 without behavior drift:\n- fix MySQL/PgSQL FFTO digest normalization and max-length hashing\n- add early FFTO packet/message size guards for bypass safety\n- restore MySQL session GTID reset and harden GenAI async error ownership\n- add null-check for stripped KILL query normalization path\n- call FFTO on_close() before observer reset/bypass in session flows\n- fix processlist query-options default pagination limit semantics\n- fix TAP noise_failures locking race and noise-aware plan count\n- extend wait_get_enpoint_ready with optional basic-auth passthrough\n- update MCP architecture docs from observe->stats naming\n- clean corrupted character in pgsql query-cache test comment\n\nValidation run:\n- git diff --check\n- make -C test/tap/tap tap.o utils_mariadb.o utils_mysql57.o utils_mysql8.o -j4\n- make -C lib obj/MySQLFFTO.oo obj/PgSQLFFTO.oo obj/MySQL_Session.oo obj/PgSQL_Session.oo obj/Query_Processor.oo -j4	4 months ago
Rene Cannao	79c0b383e8	integration: fix pre-CI issues in unified branch	4 months ago
Rene Cannao	acef17a8c1	Merge branch 'v3.0-ff_inspect' into v3.0-unified-large-pr ... # Conflicts: # test/tap/tests/Makefile	4 months ago
Rene Cannao	e2ebc0c449	Merge branch 'v4.0-mcp-stats2' into v3.0-unified-large-pr	4 months ago
Rene Cannao	54bcb5eeca	Merge branch 'v3.0-5384' into v3.0-unified-large-pr	4 months ago
Rene Cannao	90462f6d5a	ffto: harden MySQL/PgSQL observer state handling and align tests/docs ... Address outstanding review findings for FFTO on v3.0-ff_inspect and tighten protocol-state correctness for both engines. MySQL FFTO - Restrict on_close() reporting to true in-flight states and always clear query tracking state after close. - Add explicit active-query cleanup helpers and invoke them on state transitions to IDLE. - Preserve accounting on mid-resultset server ERR packets by reporting current query in READING_COLUMNS/READING_ROWS before reset. - Keep prepared-statement lifecycle cleanup robust (pending prepare cleared on prepare completion paths). MySQL session integration - Extract duplicated FAST_FORWARD client FFTO feed logic into observe_ffto_client_packet() and reuse it from all call sites. PostgreSQL FFTO - Replace regex-based CommandComplete parsing with lightweight token parsing, including NUL/whitespace trimming and strict numeric validation. - Add queued tracking for pipelined extended-protocol executes so query text and response attribution stay aligned under Parse/Bind/Execute pipelining. - Distinguish finalize semantics (execute-finalize on CommandComplete vs sync-finalize on ReadyForQuery) and centralize finalize/activation helpers. - Add frontend Close ('C') handling to evict statement/portal mappings. - Harden client/server message parsing with additional length checks. - Extend affected-row command tag coverage to COPY and MERGE. TAP tests - Stabilize test plans for failure paths by replacing early returns with a fail-and-skip-remaining flow and shared cleanup labels. - Ensure both MySQL and PgSQL FFTO tests preserve planned assertion counts under setup/prepare/execute failures. Documentation - Align FFT0 design doc state/response descriptions with current implementation (ReadyForQuery handling, pipelined queueing, supported PG command tags). - Fix wording/typo issues in protocol section. Validation performed - make -C lib -j4 - make -C test/tap/tests test_ffto_mysql-t test_ffto_pgsql-t -j4 Runtime execution of the two TAP binaries remains environment-dependent (admin endpoint connectivity required).	4 months ago
Rene Cannao	5519080ac2	mcp stats: address review findings and remove --genai CLI flag	4 months ago
Rene Cannao	5988468521	Query Processor: re-initialize parser on rewritten queries and enhance test coverage ... - Fixed Query Processor to re-extract comments and re-compute digest if a query rule rewrites the query. - Enhanced issue5384-t with better regex, robust NULL checks, and teardown logic. - Added pgsql-issue5384-t to provide parity coverage for the PostgreSQL module. - Registered the new test in groups.json.	4 months ago
René Cannaò	2b710e518f	Merge pull request #5401 from sysown/v3.0_fix-pgsql-extended-query-routing_5387 ... Revert "Reset current_hostgroup to default when no query rule matches"	4 months ago
Rene Cannao	3ccf0982e6	AI: Fix retry logic bug and synchronize TAP tests ... - Fixed a bug in LLM_Bridge (LLM_Clients.cpp) where negative max_retries would prevent the initial API call from being made. - Improved numeric range validation in TAP tests by replacing atoi() with strtol() to correctly reject non-numeric suffixes (e.g., "50abc"). - Adjusted API key format validation in tests to match actual test data lengths for OpenAI and Anthropic prefixes. - Enhanced URL validation to correctly reject hosts starting with colons. - Updated test plans and added missing test cases to achieve full synchronization between planned and executed tests in: - ai_llm_retry_scenarios-t - ai_error_handling_edge_cases-t - ai_validation-t	4 months ago
Rene Cannao	3240a3a942	Fix SIGSEGV caused by double-finalize of sqlite3_stmt	4 months ago
René Cannaò	3647678193	Merge pull request #5399 from sysown/v3.0_3596_3597 ... Tokenizer: fix type mismatch for grouping limit variables	4 months ago
René Cannaò	1dbe9fde97	Merge pull request #5385 from sysown/v3.0-2233 ... Fix #2233: Mirror sessions destination_hostgroup overwritten by fast routing	4 months ago
Javier Jaramago Fernández	ba5af979ff	feat-wip: Add replication lag support for PostgreSQL monitoring	4 months ago
Rene Cannao	1c25787b88	Introduce {mysql,pgsql}-query_processor_first_comment_parsing variable (#5384) ... This universal fix allows controlling when the first comment of a query is processed relative to the query rules. By setting this variable to 1, ProxySQL-specific annotations (like GTID) can be parsed immediately, allowing subsequent query rules to strip them from the query string. This prevents prepared statement cache bloat and improves backend statement reuse when annotations with unique literals are used.	4 months ago
Rene Cannao	ca73b9eced	Tokenizer: fix type mismatch for grouping limit variables ... Fixes issues #5396 and #5397. The variables mysql_thread___query_digests_grouping_limit and mysql_thread___query_digests_groups_grouping_limit (and their PgSQL counterparts) were incorrectly declared as bool instead of int in the tokenizer files. This caused any value greater than 0 to be treated as 1, effectively forcing a hardcoded grouping limit of 1 regardless of user configuration. By correcting the types to int, the tokenizer now correctly honors the configured values. Also added regression tests to regular_tokenizer_digests.hjson.	4 months ago
Rene Cannao	797d4b580c	mcp stats: move show_users to in-memory auth snapshots ... Rework stats.show_users so it no longer queries runtime-populated stats tables via admindb. The tool now reads user connection counters directly from authentication runtime structures, matching the direction taken for other MCP stats tools that must avoid stale stats schema reads. Implementation details: - Replaced show_users SQL path over stats_mysql_users/stats_pgsql_users with in-memory collection from GloMyAuth::dump_all_users(..., false) and GloPgAuth::dump_all_users(..., false). - Preserved Admin semantics by excluding internal/admin-style accounts (default_hostgroup < 0). - For MySQL, included LDAP user counters from GloMyLdapAuth->dump_all_users() to keep parity with stats___mysql_users population behavior. - Added deterministic argument handling for db_type validation and pagination bounds (limit capped to 1000, offset clamped to >= 0). - Kept output contract unchanged (username, frontend_connections, frontend_max_connections, utilization_pct, status) and ordering by frontend_connections DESC then username ASC. Documentation and tests: - Added extensive doxygen comments describing in-memory data sources, filtering semantics, and result construction in show_users implementation. - Extended TAP test mcp_show_connections_commands_inmemory-t with show_users coverage for MySQL and PgSQL, including payload shape checks and username filter validation. - Updated TAP plan count accordingly. - Included current tap groups updates present in working tree (test_ffto_* entries in groups.json), as requested.	4 months ago
Rene Cannao	1258a1f2f2	Address PR reviews: improve performance, safety, and robustness of FFTO	4 months ago
Rene Cannao	db04a54c92	Fix memory corruption and stack overflow in FFTO due to large queries	4 months ago
Rahim Kanji	194e20b3e8	Revert "Reset current_hostgroup to default when no query rule matches" ... This reverts commit 1b3d20388e.	4 months ago
Rene Cannao	5d786520b0	Merge remote-tracking branch 'origin/v3.0' into merge/v3.0-into-v3.0-5243 ... # Conflicts: # include/PgSQL_Logger.hpp # lib/Makefile # lib/PgSQL_Logger.cpp # lib/ProxySQL_Admin.cpp # test/tap/groups/groups.json	4 months ago
Rene Cannao	5d45d17456	mcp stats: split connection metrics from debug free-pool snapshots ... Refactor MCP stats connection tools so operational pool metrics remain lightweight while debug-level free-connection details are exposed through a dedicated gated tool. Changes in this commit: - Updated stats tool catalog and dispatch to add show_free_connections and keep show_connections focused on per-server pool metrics only. - Removed free-connection payload from show_connections and added explicit compatibility error when callers still pass detail=true, with guidance to use show_free_connections. - Implemented show_free_connections using in-memory hostgroup manager snapshots (MySQL and PgSQL) with hostgroup/server filtering and summary counters. - Added MCP runtime variable mcp-stats_enable_debug_tools (default false), including variable registration, getter/setter handling, and config default in proxysql.cfg. - Added extensive doxygen comments across modified code paths to document behavior, rationale, filters, and output contracts. - Added TAP coverage in mcp_show_connections_commands_inmemory-t for: show_commands baseline, show_connections aggregate-only contract, debug tool gating behavior, and enabled-path validation for show_free_connections on both MySQL and PgSQL. - Registered the new TAP test in test groups.	4 months ago
Rene Cannao	e762f91cda	MCP stats: add in-memory processlist filtering and PgSQL concurrency stress TAP ... Replace direct stats-schema reads in MCP show_processlist with in-memory processlist access via SQL3_Processlist query options. Add processlist query option types in proxysql_admin interfaces and implement filtering, sorting, and pagination post-processing in both MySQL and PgSQL thread implementations. Introduce configurable MCP cap mcp_stats_show_processlist_max_rows (default 200, max 1000), wire it through MCP variable loading, and expose it in default config. Expand Stats_Tool_Handler processlist handling to parse filter/sort arguments, enforce cap metadata, and return consistent MCP payload fields from in-memory snapshots. Add extensive doxygen documentation in the touched headers and source blocks to describe API contracts, filtering behavior, and runtime constraints. Add new TAP test mcp_pgsql_concurrency_stress-t that generates sustained concurrent PgSQL traffic (simple reads, read/write table workload, randomized pg_sleep) while polling MCP show_processlist and show_queries in parallel with filter and ordering assertions. Validation performed locally: mcp_pgsql_concurrency_stress-t (31 assertions) and mcp_show_queries_topk-t (12 assertions).	4 months ago
René Cannaò	9c6945fae8	Merge branch 'v3.0' into v3.0-tsdb-feature ... Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	9a630a949b	Add extended Doxygen documentation for FFTO classes	4 months ago
Rene Cannao	40aff577a9	Complete FFTO implementation with verified metrics and robust error handling ... - Finalized MySQL and PostgreSQL protocol state machines. - Implemented accurate affected_rows and rows_sent capture. - Added defensive null checks to prevent early-session crashes. - Enhanced TAP tests with result-set draining and success verification. - Verified 100% pass rate for MySQL CRUD, binary protocol, and memory bypass.	4 months ago
Rene Cannao	70b61a86e3	MCP stats: implement in-memory show_queries Top-K path ... Replace stats table reads in show_queries with Query Processor in-memory aggregation to avoid stale/empty admin-db snapshots.\n\nIntroduce Top-K digest filtering primitives and wire them into Stats_Tool_Handler so filtering/sorting/limit are executed against live digest memory. Add runtime MCP variable mcp-stats_show_queries_max_rows with validation, defaulting, and configuration plumbing, plus cap metadata in the tool response.\n\nEnforce configurable hard cap semantics while preserving deterministic ordering and pagination behavior for MCP clients. Add internal DEBUG validator path (PROXYSQLTEST 56) in admin tests to stress generated digest data and validate the Top-K/filter pipeline against in-memory state.\n\nKeep the validator callable from startup/testing workflows without depending on MCP linkage. Add TAP coverage in test/tap/tests/mcp_show_queries_topk-t.cpp for:\n- MCP endpoint setup and reachability\n- digest generation + optional DEBUG internal validator\n- payload validation and cap metadata assertions\n- descending count order validation\n- match_digest_text filter verification\n\nMake payload parsing backward-compatible in TAP (direct tool result object and legacy wrapped success/result payloads).	4 months ago
René Cannaò	bad7ce40c5	Merge pull request #5391 from sysown/v3.0_pgsql_advanced_logging ... feat(pgsql): advanced query logging parity with mysql eventslog	4 months ago
Rene Cannao	c126e63a23	mcp stats: refresh stats tables under admin mutex before direct reads ... Problem MCP stats tools were querying stats.* tables directly through admindb. Unlike admin-session SQL, that path bypassed GenericRefreshStatistics() and could return stale or empty data for runtime-populated tables. What changed - Updated Stats_Tool_Handler::execute_admin_query() to mirror admin-session semantics for stats reads: - acquire GloAdmin->sql_query_global_mutex - optionally invoke ProxySQL_Admin::GenericRefreshStatistics(sql, ..., false) - execute admindb statement - release sql_query_global_mutex - Added strict input validation and explicit lock/unlock error reporting. - Added refresh_before_query parameter (default true) to avoid duplicate refresh passes for secondary count queries. - Switched secondary COUNT(*) calls in show_processlist/show_queries/ show_errors/show_query_rules to refresh_before_query=false. Documentation - Expanded Doxygen in include/Stats_Tool_Handler.h for execute_admin_query() to document locking, refresh behavior, and performance tradeoff. - Added detailed Doxygen above the execute_admin_query() implementation in lib/Stats_Tool_Handler.cpp. Testing - Added TAP integration test test/tap/tests/mcp_stats_refresh-t.cpp. - The test injects a synthetic stale marker row into stats.stats_mysql_global, calls /mcp/stats show_status, and verifies the marker disappears after refresh-before-read. - Added helper-level Doxygen in the test for setup/parsing behavior. Build verification - Compiled lib object: make -C lib obj/Stats_Tool_Handler.oo - Compiled TAP target: make -C test/tap/tests mcp_stats_refresh-t - Direct runtime execution of the TAP test in this workspace could not fully run because no local admin listener was available (connection to 127.0.0.1:6032 failed).	4 months ago
Rene Cannao	f3d4153e7d	Final FFTO implementation and verification fixes ... - Resolved signature mismatch in report_query_stats - Fixed missing type declarations for Query_Processor in FFTO classes - Verified Metric Parity for affected_rows and rows_sent - Confirmed full coverage in TAP tests for text/binary protocols and bypass logic - Verified clean build with make debug	4 months ago
Rene Cannao	33fce1ca35	MCP stats: address review findings and add detailed docs	4 months ago
René Cannaò	4a6809b60f	Merge branch 'v3.0' into v3.0-tsdb-feature ... Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	ef397f9f1d	Fix TSDB variable patterns and backend monitor runtime source	4 months ago
René Cannaò	5256f3d77a	Merge pull request #5388 from sysown/v3.0_fix-pgsql-extended-query-routing_5387 ... Fix: Extended query Routing and Statistics Tracking	4 months ago
Rene Cannao	82a28a2e62	fix(pgsql-eventslog): close remaining minor review findings in logger internals ... Address two minor correctness/style follow-ups from final review: 1) `PgSQL_Event::set_error()` overwrite safety - Free previous `sqlstate` / `errmsg` buffers when either ownership mode is active (`free_on_delete` or `free_error_on_delete`) before replacing pointers. - This avoids latent leaks if `set_error()` is called on deep-copied events. 2) Explicit atomic access for circular-buffer capacity - Keep `buffer_size` atomic and use explicit `load/store` operations with `std::memory_order_relaxed` in hot-path and helper methods. - Update log-path check, insert path, getter, and setter to use explicit atomic operations for clearer thread-safety semantics.	4 months ago
Rene Cannao	3dfd6a97d9	Fix FFTO metric parity: capture and report affected_rows and rows_sent ... - Implemented MySQL OK_Packet parsing to extract affected_rows - Implemented PostgreSQL CommandComplete parsing to extract rows affected/sent - Updated TAP tests to validate sum_rows_affected and sum_rows_sent metrics - Fixed incorrect assertion in test_ffto_mysql-t.cpp	4 months ago
Rene Cannao	17092487cf	Add protocol-labeled logger counters and FLUSH LOGS race TAP ... - Introduce proxysql_query_logger_logged_queries_total with protocol label (mysql, pgsql) for direct query-log accounting via Prometheus. - Wire MySQL and PgSQL loggers to increment/export the counter and hook PgSQL logger metrics into admin scrape updates. - Add reg_test_5389-flush_logs_no_drop-t.cpp to stress concurrent client traffic + PROXYSQL FLUSH LOGS and assert no dropped logs via metric delta == executed queries. - Document the new TAP with doxygen comments for env knobs and flow.	4 months ago
Rene Cannao	6db089883e	fix(admin): improve PGSQL eventslog dump failure reporting and stats insert path ... Admin command behavior: - `DUMP PGSQL EVENTSLOG ...` returned `OK 0` when `GloPgSQL_Logger` was null. - This masked unavailable logger state from operators. Change: - Return an explicit admin error (`PgSQL logger not initialized`) when logger is unavailable. - Preserve normal `OK` response path when logger is present. Stats path behavior: - PgSQL logger metrics insertion into `stats_pgsql_global` used per-row string formatting and `execute()` calls. Change: - Replace per-row dynamic SQL construction with a prepared-statement row insert path. - Reuse `sqlite3_global_stats_row_step()` for consistent binding/reset semantics.	4 months ago
Rene Cannao	0aa3c5e153	fix(pgsql-eventslog): harden event ownership and keep newest rows in memory table ... Problem 1: - `PgSQL_Event::set_error()` stored borrowed pointers from connection-owned strings. - This could create lifetime hazards before/around event serialization and buffering. Fix: - Add explicit ownership tracking for error fields via `free_error_on_delete`. - Make `set_error()` duplicate incoming SQLSTATE/error strings. - Free owned error strings in destructor when the event does not own all fields. - Keep copy-constructor behavior for deep-copied buffered events and disable copy-assignment to avoid accidental shallow assignment. Problem 2: - `processEvents()` could repopulate `stats_pgsql_query_events` using the beginning of the drained batch after retention pruning. - This keeps older rows instead of the most recent rows when truncation is required. Fix: - Insert the tail of the drained batch (`events.end() - numEventsToInsert`) so memory table retention always preserves latest events. - Tighten row retention arithmetic using `size_t` to avoid signed/unsigned mismatch in keep/delete calculations.	4 months ago
Rene Cannao	c5191d21f8	logger: avoid log drops during rotate close/open window	4 months ago
Rene Cannao	eba795d729	fix(pgsql-eventslog): make dump-to-memory sizing protocol-agnostic across admin ports ... Context: - Admin commands are exposed by one shared Admin module over two protocols: - MySQL admin endpoint (`6032`) - PostgreSQL admin endpoint (`6132`) - `DUMP PGSQL EVENTSLOG ...` must behave identically regardless of which admin protocol executes the command. Issue fixed: - PGSQL events dump path used thread-local PGSQL sizing variables when draining to memory (`stats_pgsql_query_events`). - When command execution happened from a non-PGSQL protocol admin worker, TLS values could be out of sync for PGSQL sizing decisions. Changes: - In `lib/PgSQL_Logger.cpp`, add runtime-size helper functions that read canonical values from `GloPTH->variables` with TLS fallback: - `eventslog_buffer_max_query_length` - `eventslog_table_memory_size` - Use these helpers in: - `PgSQL_Event` copy constructor (buffered query truncation) - `PgSQL_Logger::processEvents()` (in-memory retention for `stats_pgsql_query_events`) - Update internal architecture doc to explicitly state command availability from both admin protocol endpoints. Why: - Ensure `DUMP PGSQL EVENTSLOG ...` semantics remain consistent across `6032` and `6132`, matching the shared-admin-module design.	4 months ago
Rene Cannao	20d6282a60	build(clean): ignore and remove generated MySQL parser artifacts ... Context: - Bison/Flex-generated parser files in `lib/` can be created locally during parser work. - These files are generated artifacts and should not be tracked. Changes: - Add generated parser artifacts to `.gitignore`: - `lib/MySQL_Lexer.yy.c` - `lib/MySQL_Parser.output` - `lib/MySQL_Parser.tab.c` - `lib/MySQL_Parser.tab.h` - Extend `lib/Makefile` `clean` target to remove the same generated files. Why: - Prevent accidental inclusion of regenerated parser outputs in feature commits. - Keep worktrees clean and make `make clean` deterministic for parser-related changes.	4 months ago
Rene Cannao	b4e85f1799	Expose PostgreSQL eventslog metrics in stats and Prometheus	4 months ago
Rene Cannao	b100235fbd	Add PGSQL eventslog dump commands and periodic disk sync scheduling	4 months ago
Rene Cannao	acbd7d0df3	Implement PostgreSQL eventslog circular buffer and sink pipeline	4 months ago
Rene Cannao	2a46c239be	Add PostgreSQL advanced eventslog schema and variable scaffolding	4 months ago
Rene Cannao	3ca390dacb	Fix binary protocol support for prepared statements in FFTO ... - Implemented statement ID tracking for MySQL COM_STMT_PREPARE/EXECUTE - Implemented Parse/Bind/Execute portal mapping for PostgreSQL Extended Query - Corrected documentation regarding binary protocol support - Ensured metric parity for prepared statements in Fast Forward mode	4 months ago
Rene Cannao	3a3be5a559	Implement Fast Forward Traffic Observer (FFTO) for MySQL and PostgreSQL ... - Added TrafficObserver base interface - Implemented MySQLFFTO and PgSQLFFTO classes for protocol-aware observation - Integrated FFTO hooks into MySQL and PostgreSQL session handlers in FAST_FORWARD state - Added configuration variables: mysql-ffto_enabled, mysql-ffto_max_buffer_size, pgsql-ffto_enabled, pgsql-ffto_max_buffer_size - Implemented query digest extraction and reporting parity with internal stats - Added session-level bypass when packet size exceeds buffer threshold - Included architectural documentation in doc/ffto_design.md	4 months ago
Rahim Kanji	1f0756b59f	Correct bytes_sent tracking for extended query protocol ... Fix missing and incorrect update_bytes_sent() calls in PgSQL_Connection async state machine.	4 months ago
Rene Cannao	eaadabbb8e	logger: fix thread-context map race in buffered logging	4 months ago
Rene Cannao	caf324f911	logger: harden buffered logging flush/rotation semantics ... This commit addresses three correctness regressions introduced by thread-local log buffering in PR #5364 (query logging performance): 1) stale logfile pointer/UAF race during concurrent rotate/close 2) stale logfile-open state after close 3) non-global flush behavior in admin/format-switch paths What was fixed - Make `flush_and_rotate()` consume the current logfile pointer under lock - Signature changed from `std::fstream*` to `std::fstream*&` - Prevents dereferencing a stale stream pointer captured before lock acquisition while another thread rotates/closes the file - Updated declaration/definition and all call sites - Add explicit synchronization for cross-thread buffer draining - Added `LogBufferThreadContext::buffer_lock` - Any path that appends or flushes a thread buffer now locks this mutex - Guarantees force-flush from admin/config paths cannot race with worker-thread appends on the same context - Restore global forced flush semantics where required - Extended `MySQL_Logger::flush` and `PgSQL_Logger::flush` to `flush(bool force = false)` - `force=false`: preserves existing low-overhead worker-loop behavior (per-thread timeout-based flush) - `force=true`: snapshots all known thread contexts and drains both events/audit buffers regardless of timeout - `flush_log()` now calls `flush(true)` before file rotation, so admin flush and format-switch operations no longer miss pending thread buffers - Avoid unintended rotation during forced draining - In `force=true` path, flush uses `rotate_fn=nullptr` - Drains buffered payload into the current file first - `flush_log()` then performs one controlled rotate/open step - Fix logfile state tracking after close - `events_close_log_unlocked()` and `audit_close_log_unlocked()` now set `logfile_open=false` when the stream is closed - Prevents write paths from treating a closed stream as open - Remove per-thread-context dependency during metadata header write - `events_open_log_unlocked()` now uses a local `LogBuffer` for metadata emission in format=1 instead of reusing a thread context buffer - Keeps open/rotate path independent from worker context lifecycle - Keep callers consistent and non-duplicative - Since `flush_log()` now force-drains internally, removed redundant explicit `flush()` calls from: - MySQL/PgSQL `eventslog_format` switch handlers - `ProxySQL_Admin::flush_logs` Behavioral outcome - No stale stream pointer use when close/rotate interleaves with flush - No false-positive logfile-open state after close - `FLUSH LOGS` and eventslog format switch now drain all known thread buffers before rotating, preventing dropped/misplaced buffered records Validation - Built modified objects directly - Ran full debug build with GENAI enabled: make clean && export PROXYSQLGENAI=1 && make debug -j24 Build completed successfully.	4 months ago
René Cannaò	568fe1524e	Merge pull request #5364 from mevishalr/feature/query-logging-improvements ... Optimize query logging performance (#5243)	4 months ago
René Cannaò	762afaa44f	Merge branch 'v3.0' into v4.0-mcp-stats ... Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	4882559239	Cleanup: Uncomment delete statsdb_disk in ProxySQL_Statistics destructor ... This ensures statsdb_disk is properly deallocated during ProxySQL_Statistics destruction, preventing a potential memory leak.	4 months ago
Rene Cannao	700459f67b	tsdb: address AI code review feedback, fix memory safety and logic bugs ... Summary of changes: - Fixed allocator mismatches (sqlite3_free vs free) across multiple files. - Converted manual SQL construction to prepared statements for TSDB variables. - Resolved memory leaks in statistics and monitoring loops. - Fixed critical 'LOAD TSDB VARIABLES FROM CONFIG' command mismatch. - Improved command parsing robustness using string searching. - Standardized SQL LIKE patterns with escaped wildcards (\%). - Switched to data-driven variable management in ProxySQL_Statistics. - Improved web dashboard security with URL encoding and const correctness. - Clarified documentation regarding configuration lifecycle and schema names. - Updated TAP tests for better reliability and correct persistence verification.	4 months ago
René Cannaò	10ff1322ba	Merge pull request #5386 from sysown/v3.0-MCP_multi ... MCP query+harvest hardening: HGM routing, weighted targets, pgsql harvest fix, TAP updates	4 months ago
Rene Cannao	3bb233e800	tsdb: commit missing REST API safety fixes	4 months ago
Rahim Kanji	db5f1ea498	Track query count for extended query protocol executions ... The queries_sent counter in stats.stats_pgsql_connection_pool was not being incremented for prepared statement executions (ASYNC_STMT_EXECUTE_START), only for regular queries (ASYNC_QUERY_START) and statement preparation (ASYNC_STMT_PREPARE_START).	4 months ago
Rahim Kanji	1b3d20388e	Reset current_hostgroup to default when no query rule matches ... In the extended query protocol flow (Parse/Bind/Execute/Sync messages), queries without matching query rules were incorrectly retaining the current_hostgroup value from the previous query instead of being reset to the default_hostgroup. This happened because: - Simple query protocol goes through STATE_SLEEP between queries, which resets current_hostgroup to default_hostgroup - Extended query protocol does NOT go through STATE_SLEEP between Parse/Bind/Execute messages, so current_hostgroup was never reset	4 months ago
Rene Cannao	253d098653	security: fix SQL injection vulnerabilities in SQLite catalog queries ... Address Gemini Code Assist review feedback on PR #5386: 1. Discovery_Schema::resolve_run_id - Replace string concatenation with replace_str escaping with proper parameterized queries using sqlite3_prepare_v2 and sqlite3_bind_* functions. 2. PgSQL_Static_Harvester - Remove unsafe escape_sql_string() function and replace its usages with: - New lookup_object_id() helper using parameterized queries - Parameterized UPDATE statements in harvest_view_definitions() These changes ensure complete protection against SQL injection for the catalog database, following the pattern already used in create_run().	4 months ago
Rene Cannao	2fa1401b05	MCP query+harvest hardening: HGM-based target routing, weighted backend selection, pgsql schema fix, and TAP robustness ... This squashed commit consolidates the recent MCP stabilization work across query execution and static-discovery tests. 1) Query endpoint routing/executability now uses Hostgroup Manager runtime snapshots - File: lib/Query_Tool_Handler.cpp - Removed dependency on direct SQL probes against runtime_mysql_servers/runtime_pgsql_servers from inside the MCP query handler path. - Target backend resolution now reuses the same Hostgroup Manager runtime snapshot APIs that feed Admin runtime server visibility: - MyHGM->dump_table_mysql("mysql_servers") - PgHGM->dump_table_pgsql("pgsql_servers") - Non-executable diagnostics now summarize statuses from HGM snapshots instead of ad hoc runtime-table SQL. 2) Backend endpoint selection changed to weighted random - File: lib/Query_Tool_Handler.cpp - Selection remains constrained by: - matching target hostgroup_id - ONLINE backend status - Candidate choice now uses random selection with linear probability by weight, replacing deterministic ordering. 3) Read-only validation and guardrail adjustments - File: lib/Query_Tool_Handler.cpp - Fixed false negatives for valid read-only queries such as SELECT literals (no FROM clause required). - Added additional dangerous-query patterns for file-write variants: - INTO OUTFILE - INTO DUMPFILE 4) PostgreSQL static harvester schema query fix - File: lib/PgSQL_Static_Harvester.cpp - Fixed harvest_schemas() failure on PostgreSQL caused by querying non-existent information_schema.schemata.default_collation_name. - Replaced with PostgreSQL-safe projection while preserving the insert_schema() column contract. 5) TAP reliability improvements for MCP test phases - File: test/tap/tests/mcp_rules_testing/test_phase11_pgsql_target.sh - Isolated phase state by clearing MCP rules before setup. - Added verbose response prints for T11.1-T11.4. - Added LOGENTRY phase start/end markers and EXIT trap for guaranteed end watermark. - Replaced fragile grep/escaping checks with robust string assertions. - Fixed NULL-concat stats assertions with COALESCE(username,'') and COALESCE(target_id,''). - File: test/tap/tests/test_mcp_static_harvest-t.sh - Hardened escaped-JSON parsing in MCP response checks (run_id extraction + key/value assertions). - Reworked target/protocol/object assertions to avoid transport-format false negatives. - Corrected cross-target negative assertion to check MCP isError semantics. Observed result in user verification - Phase 11 pgsql target/rules/stats checks pass. - Static harvest phase-A checks pass for mixed mysql/pgsql target_id flow. This commit intentionally keeps runtime ONLINE-only target executability semantics and improves observability/diagnostic quality for future MCP routing/test failures.	4 months ago
Rene Cannao	b8c6b4f573	tsdb: address code review comments and improve stability ... - Refactored variable flushing to use prepared statements for safety. - Replaced brittle command parsing with robust string searching. - Extracted TSDB dashboard HTML/JS to separate source file for maintainability. - Added NULL guards for GloProxyStats in Admin and REST API. - Implemented batched metric insertions using transactions for performance. - Refactored backend probing to use non-blocking connect() with timeout. - Fixed potential integer overflows in timer calculations. - Improved error handling and fixed memory leaks in statistics reporting. - Updated TAP tests to verify UI and REST API functionality.	4 months ago
Rene Cannao	9685cdaa4b	mcp discovery: enforce target-scoped run model and add protocol-aware static harvesting (mysql+pgsql) ... Refactor the MCP query/discovery stack to remove prototype-era MySQL-only assumptions and make discovery/catalog semantics explicitly target-scoped. This commit is intentionally not backward compatible with legacy single-target catalog metadata. Key implementation details: - Discovery_Schema: - runs table now stores target_id, protocol, and server_version - resolve_run_id() now requires target_id and resolves schemas within target scope - create_run() now records target/protocol/server version - added legacy schema detection + destructive catalog table rebuild when old runs layout is found - fixed resultset lifetime/escaping issues in target-aware run resolution - New PostgreSQL static harvester: - added PgSQL_Static_Harvester class and build wiring - harvests schemas/objects/columns/indexes/fks/view definitions into Discovery_Schema - maps pg metadata to object_id-based insert APIs used by Discovery_Schema - Query_Tool_Handler: - constructor simplified to catalog_path only (no mcp-mysql_* runtime ctor deps) - discovery.run_static now requires target_id and dispatches protocol-aware harvester at runtime - catalog.*, agent.run_start, and llm.* tool contracts now require target_id when resolving run_id - all run_id resolution call sites switched to resolve_run_id(target_id, ...) - list_schemas catalog query now scoped by target_id via runs join - digest logging path now resolves run_id in target context - ProxySQL_MCP_Server: - updated Query_Tool_Handler construction to new signature - Docs updated: - added explicit target_id scoping guidance for discovery/catalog/agent/llm workflows - clarified protocol-aware routing and noted legacy examples still present in large script docs Build validation: - Recompiled changed objects with PROXYSQLGENAI=1: - Query_Tool_Handler.oo - Discovery_Schema.oo - PgSQL_Static_Harvester.oo - ProxySQL_MCP_Server.oo	4 months ago
Rene Cannao	7e54883ba5	mcp query debugging: surface rule-id context for blocks and add backend failure SQL details ... Observed confusion: - MCP failures like 'Error 100' / 'Error 101' were visible at endpoint level but gave no direct clue whether they came from query-rule blocks or backend execution failures. - Connection/firewall-style failures also lacked enough target/query context in lower-level logs. Changes in this commit: 1) Log MCP query-rule block/OK matches with rule id and context - In Discovery_Schema::evaluate_mcp_query_rules(): - when error_msg rule action is applied, log: rule_id, tool, target_id, schema, error_msg, query preview. - when OK_msg rule action is applied, log: rule_id, tool, target_id, schema, ok_msg. - This makes it explicit which runtime_mcp_query_rules row produced the returned error. 2) Add detailed backend execution error logs in Query_Tool_Handler - For MySQL and PostgreSQL execution paths (with and without schema switching), failures now log: - target_id - schema (when applicable) - backend error text - SQL query text - Added context for PG search_path failures too. - This disambiguates rule-block errors from actual backend connectivity/authorization/firewall failures. Behavioral notes: - API responses are unchanged (to avoid breaking tests expecting exact messages). - Logging is now sufficiently descriptive to trace each failure to either: - a specific MCP rule id/action, or - a concrete backend execution error. Validation: - Recompiled successfully: - lib/obj/Discovery_Schema.oo - lib/obj/Query_Tool_Handler.oo	4 months ago
Rene Cannao	8fbd570c79	mcp variables: stop writing runtime_global_variables during LOAD MCP VARIABLES TO RUNTIME ... Issue: - MCP variable load path was writing rows into runtime_global_variables. - For MCP this is incorrect and misleading; runtime_global_variables should not be used as a write target in this flow. - Logs showed explicit INSERT statements into runtime_global_variables for mcp-* entries. Fix implemented: 1) Removed runtime_global_variables population from MCP database->runtime flow - In flush_mcp_variables___database_to_runtime(), removed the block that called: flush_mcp_variables___runtime_to_database(..., runtime=true, ...) - LOAD MCP VARIABLES TO RUNTIME now applies mcp-* variables to GloMCPH and reloads MCP server state, without runtime_global_variables writes. 2) Removed runtime_global_variables writes from MCP runtime->database helper - In flush_mcp_variables___runtime_to_database(): - removed DELETE FROM runtime_global_variables WHERE variable_name LIKE 'mcp-%' - removed INSERT INTO runtime_global_variables(...) per variable - Function now persists MCP variables only to global_variables (main/disk paths), which is the intended save behavior. 3) Removed temporary MCP info-level debug noise related to runtime_global_variables inserts - Deleted MCP info logs that printed per-variable INSERT SQL into runtime_global_variables. Build validation: - Recompiled successfully: - lib/obj/Admin_FlushVariables.oo Expected result after this commit: - Executing LOAD MCP VARIABLES TO RUNTIME should no longer emit any INSERT/DELETE against runtime_global_variables for mcp-* variables. - MCP runtime behavior remains: variables are applied in-memory and MCP server reload logic is triggered via load_mcp_server().	4 months ago
Rene Cannao	f15460348c	mcp query diagnostics: include runtime hostgroup status breakdown when target lacks ONLINE backend ... Adds targeted debug context for non-executable MCP targets. When Query_Tool_Handler reports that a target has no ONLINE backend, it now appends a status summary read from the corresponding runtime server table for that hostgroup: - MySQL: runtime_mysql_servers - PostgreSQL: runtime_pgsql_servers Example diagnostics now include status aggregates such as: - ONLINE=0, SHUNNED=1 - OFFLINE_SOFT=1 - no rows in runtime_*_servers for hostgroup X This closes the observability gap where users saw 'target non-executable' but could not immediately tell why the hostgroup failed ONLINE eligibility. Validation: - Recompiled lib/obj/Query_Tool_Handler.oo successfully.	4 months ago
Rene Cannao	f4bc1943fb	mcp query diagnostics: restore strict ONLINE requirement and explain target non-executable failures ... This change does two things: 1) Reverts executable-target policy to strict ONLINE backend status - Query target resolution in Query_Tool_Handler is restored to require UPPER(status)='ONLINE' in runtime_mysql_servers/runtime_pgsql_servers. - This matches expected semantics: non-ONLINE backends should not be considered executable MCP targets. 2) Replaces generic non-executable errors with actionable diagnostics - Added Query_Tool_Handler::format_target_unavailable_error(target_id). - All query-tool paths that previously returned the generic: 'Target is not executable by this handler' now return a reasoned error with context, including: - target_id - protocol - hostgroup_id - auth_profile_id - concrete reason (for example: empty db_username in auth profile, or no ONLINE backend in runtime_*_servers) - Internal logs in get_connection()/get_pgsql_connection() now emit the same detailed reason. 3) Improves MCP endpoint failure logging with SQL/target context - In MCP_JSONRPC_Resource::handle_tools_call(), failed tool calls now log: - endpoint/tool/error - full arguments payload (existing) - additional parsed details when present: target_id, schema, sql (trimmed for safety) - This makes it explicit what SQL was requested when a tool call fails before execution. 4) Protocol normalization retained for robustness - MCP_Threads_Handler::load_target_auth_map() lowercases protocol values when loading runtime profile joins. - This avoids protocol-casing drift causing inconsistent routing behavior. Build validation: - Successfully recompiled modified objects: - lib/obj/Query_Tool_Handler.oo - lib/obj/MCP_Endpoint.oo - lib/obj/MCP_Thread.oo Resulting behavior expected on next test run: - If a target is non-executable, the response and logs will state exactly why (ONLINE/backend/auth reason), instead of a generic error. - Failure logs will also include the attempted SQL text (for tool calls that carry sql arguments), clarifying whether a backend query was actually executed or blocked before execution.	4 months ago
Rene Cannao	49f811a638	mcp query: stop misclassifying reachable targets as non-executable ... Observed failure: - MCP tools received valid target_id values, but /mcp/query returned 'Target is not executable by this handler'. - This prevented rule evaluation, digest accounting, and hit counters from advancing, causing multiple TAP phases to fail. Root cause addressed in this commit: - Target endpoint resolution required runtime server status to be exactly ONLINE. - In practice, reachable backends can temporarily appear in other statuses (for example monitor-related transitions), while MCP direct connections with profile credentials are still valid. - Protocol casing inconsistencies could also lead to fragile routing behavior when profile data is consumed. Changes: 1) Relax backend eligibility during endpoint resolution - In Query_Tool_Handler::refresh_target_registry(), endpoint discovery now accepts any server status except OFFLINE_HARD. - ONLINE is still preferred deterministically via ORDER BY, but non-ONLINE candidates remain eligible for MCP execution. 2) Normalize protocol values to lowercase - In MCP_Threads_Handler::load_target_auth_map(), target protocol is normalized to lowercase when loaded from runtime profiles. - In Query_Tool_Handler::refresh_target_registry(), protocol is normalized again defensively before routing decisions. 3) Improve diagnostics for target executability - Added explicit warnings when: - a target resolves to a backend but has empty db_username, - a target has no eligible backend for its hostgroup/protocol. - These logs make it clear why a target is being marked non-executable. Expected behavioral impact: - MCP query tools should execute for valid target_id entries even when monitor status is not strictly ONLINE. - Query-rules blocking/rewriting/OK actions should be exercised again. - stats_mcp_query_rules hits and stats_mcp_query_digest counters should resume incrementing once queries run. Validation performed: - Recompiled modified objects successfully: - lib/obj/Query_Tool_Handler.oo - lib/obj/MCP_Thread.oo	4 months ago
Rene Cannao	6a788e48c4	mcp: make /mcp/query self-healing when targets/backends appear after startup ... Problem addressed: - MCP query endpoint could stay unusable with 'Tool Handler not initialized' after restart/reload flows. - This was triggered when Query_Tool_Handler could not build an executable pool at init time (for example profiles loaded before ONLINE servers), leaving runtime commands like 'LOAD MCP QUERY RULES FROM MEMORY' blocked behind a NULL query tool handler. - Users had to manually toggle MCP enablement to recover, which is the opposite of expected self-healing behavior. What this commit changes: 1) Query_Tool_Handler pool init is now resilient and idempotent - init_connection_pool() now starts with close() so reinitialization fully resets stale mysql/pgsql pool state before rebuilding from runtime profile + server tables. - If no executable targets are available, init_connection_pool() now returns success with a warning instead of hard failure. This allows the query tool handler (and /mcp/query endpoint) to stay initialized even before backends are ready. 2) Lazy auto-rebuild on first query usage - get_connection() and get_pgsql_connection() now: - refresh target registry before resolution, - attempt to use an existing pooled connection, - if unavailable, trigger a full pool rebuild (init_connection_pool()) and retry once. - This provides automatic recovery when hostgroups/servers/profiles are loaded or changed after MCP startup, without requiring manual MCP disable/enable. 3) Admin runtime rule load path attempts MCP recovery - load_mcp_query_rules_to_runtime() now detects NULL query tool handler and calls load_mcp_server() once before failing. - This turns a hard, immediate admin error into a self-recovery attempt consistent with MCP runtime semantics. Behavioral impact: - /mcp/query endpoint remains online even when there are temporarily zero executable targets. - As soon as compatible runtime targets/backends exist, run_sql_readonly/explain_sql can recover automatically on demand. - LOAD MCP QUERY RULES TO/FROM RUNTIME no longer fails immediately on first NULL handler condition; it retries after MCP server recovery. Validation performed: - Recompiled modified objects successfully: - lib/obj/Query_Tool_Handler.oo - lib/obj/ProxySQL_Admin.oo - Full TAP runtime test execution is not possible in this sandbox due blocked local TCP socket creation; validation should be run in the normal test environment where ProxySQL/MySQL/PGSQL are reachable.	4 months ago
Rene Cannao	998bd82387	MCP TAP startup: fix tool-handler initialization order, improve MCP PROFILES observability, and seed monitor users ... This change fixes recurring MCP TAP failures where `/mcp/query` returned: Tool Handler not initialized for endpoint: query and where backend monitor auth failures flooded logs. Problem summary - MCP server startup can occur before runtime target/auth profiles and backend server mappings are loaded. - If that happens, Query_Tool_Handler initialization sees no executable targets and remains NULL. - MCP endpoint resources bind the handler pointer at creation time, so a NULL query handler at startup breaks `/mcp/query` until server restart. Code changes 1) Add explicit admin command logging for MCP PROFILES commands - Added `Received <command>` logging in the MCP PROFILES command block, matching behavior of other admin command handlers. - File: `lib/Admin_Handler.cpp` 2) Trigger MCP server refresh after `LOAD MCP PROFILES TO RUNTIME` - After copying profiles into runtime and rebuilding target/auth map, call `ProxySQL_Admin::load_mcp_server()`. - This allows MCP to self-heal when profiles become available after initial startup. - File: `lib/Admin_Handler.cpp` 3) Restart MCP server when query handler is missing - Extended `ProxySQL_Admin::load_mcp_server()` restart checks to include: - running server + `query_tool_handler == NULL` - Restart reason now includes tool handler initialization mismatch. - File: `lib/ProxySQL_Admin.cpp` 4) Fix TAP configurator load order to avoid early MCP startup - Reordered `test/tap/tests/mcp_rules_testing/configure_mcp.sh` runtime sequence: - `LOAD MYSQL SERVERS TO RUNTIME` - `LOAD PGSQL SERVERS TO RUNTIME` (best effort) - `LOAD MCP PROFILES TO RUNTIME` - `LOAD MCP VARIABLES TO RUNTIME` (last) - This ensures MCP starts only after routing/auth context is present. 5) Seed monitor credentials in AI local infra pre-hook - Added backend user/role creation for default monitor credentials `monitor/monitor`: - MySQL: create user + monitor-relevant grants - PostgreSQL: create role + `pg_monitor` + DB connect grants - Reduces monitor auth noise in local AI TAP dockerized setup. - File: `test/tap/groups/ai/pre-proxysql.bash` 6) Mark new TAP phase scripts executable - `test_phase10_eval_explain.sh` - `test_phase11_pgsql_target.sh` Expected outcome - MCP query endpoint no longer stays stuck with an uninitialized tool handler after TAP configuration. - MCP query-rules admin commands stop failing due to missing Query_Tool_Handler. - MCP profile command flow is visible in logs for easier debugging. - Local AI TAP infra no longer emits continuous monitor authentication failures for default monitor credentials.	4 months ago
Rene Cannao	af0411bd46	MCP: add target-aware rules/stats tests, explain_sql rule coverage, and AI local docker TAP infra ... This commit completes end-to-end MCP query-rules validation for multi-target routing and introduces a self-contained TAP infra for the `ai` group that can run both in Jenkins and manually. Main MCP/runtime changes: - Extended MCP query-rule matching context to include both `target_id` and resolved backend `username`. - Added `target_id` column to `mcp_query_rules` and `runtime_mcp_query_rules` table definitions. - Extended `stats_mcp_query_rules` to include `username` and `target_id` alongside `rule_id` and `hits`. - Updated load/save/runtime refresh paths to persist and rehydrate the expanded MCP rule schema. - Wired the rule engine into `explain_sql` so MCP rules apply consistently across `run_sql_readonly` and `explain_sql`. - Included startup-order fix in `src/main.cpp` to initialize MCP/GenAI thread handlers early, preventing startup crashes in PROXYSQLGENAI builds. Test coverage changes: - Updated existing MCP TAP phases to assert target-aware and username-aware behavior: - `test_phase4_stats.sh` - `test_phase6_eval_block.sh` - Added new MCP TAP phases: - `test_phase10_eval_explain.sh` (rule engine coverage for `explain_sql`) - `test_phase11_pgsql_target.sh` (pgsql target routing/rule/stats coverage; graceful skip if no pgsql target is configured) - Updated `test_mcp_query_rules-t.sh` runner to execute new phases. AI group isolated infra (manual + CI compatible): - Added `test/tap/groups/ai/docker-compose.yml` with MySQL 9.0 and PostgreSQL 16 backends. - Added lifecycle scripts: - `docker-compose-init.bash` - `docker-compose-destroy.bash` - `pre-proxysql.bash` - `post-proxysql.bash` - Extended `test/tap/groups/ai/env.sh` with local default ports/credentials/target IDs used by MCP TAP tests. - Added `test/tap/groups/ai/README.md` documenting manual execution flow outside Jenkins. Outcome: - MCP tests now validate routing-aware rule enforcement and stats attribution for both MySQL and PostgreSQL targets. - The `ai` TAP group can be run with an isolated local backend stack without relying on external Jenkins infra repositories.	4 months ago
René Cannaò	28b1114cd9	Merge pull request #5353 from sysown/v3.0_pgsql-prepared-statement-refcount-race-5352 ... Fix PostgreSQL prepared statement purge crash: use memory_order_acquire instead of memory_order_relaxed	4 months ago
jesmarcannao	db40505d18	Fix #2233: Mirror sessions destination_hostgroup overwritten by fast routing ... Bug fix: - Mirror sessions had their destination_hostgroup incorrectly overwritten by fast routing rules, causing duplicate query execution to the same hostgroup - Added check in Query_Processor.cpp to skip fast routing for mirror sessions Changes: - lib/Query_Processor.cpp: Wrapped fast routing logic with mirror session check - test/tap/tests/reg_test_2233_mirror_fast_routing-t.cpp: New regression test - test/tap/groups/groups.json: Added test to default-g1 test group - test/tap/tests/Makefile: Added build rule for the new test (commented out) The fix ensures mirror sessions maintain their assigned destination_hostgroup and are not affected by fast routing rules.	4 months ago
Rene Cannao	013864b36f	MCP: introduce profile-based target/auth routing and unified LOAD/SAVE MCP PROFILES commands ... This commit introduces the core MCP routing architecture that decouples client-facing target selection from backend connection details. Architecture introduced: - New MCP auth profile table to store backend credentials/policy (`mcp_auth_profiles`). - New MCP target profile table to map opaque `target_id` -> protocol/hostgroup/auth profile (`mcp_target_profiles`). - Runtime mirrors for both profile tables. Behavioral changes: - MCP query tools resolve execution context by `target_id` and route internally by protocol + hostgroup. - Client no longer needs backend-specific connection details; only logical target identifiers. - Unified admin commands for profile lifecycle management: - `LOAD MCP PROFILES TO/FROM MEMORY/RUNTIME/DISK` - `SAVE MCP PROFILES TO/FROM MEMORY/RUNTIME/DISK` Design goals: - Support multi-backend MCP execution (MySQL + PostgreSQL) behind one endpoint. - Provide server-side credential management and cleaner operational model. - Replace legacy one-backend POC configuration with scalable target/auth abstractions. Result: - MCP routing is now dynamic, protocol-agnostic at the client layer, and fully managed through profile tables and unified load/save commands.	4 months ago
Rene Cannao	5f5b7d604f	tsdb: improve administrative interface and command support ... - Move 'stats_tsdb' to 'main' schema for better visibility in 'SHOW TSDB STATUS'. - Implement 'PROXYSQL TSDB DOWNSAMPLE' command to trigger manual metrics aggregation. - Ensure 'SHOW TSDB STATUS' triggers a statistics refresh before returning data. - Integrate 'tsdb-' variables into 'runtime_global_variables' refresh logic. - Update TAP tests to verify new commands and improve troubleshooting output.	4 months ago
Rene Cannao	a09db8318c	tsdb: fix SET command validation by adding tsdb- prefix support	4 months ago
Rene Cannao	6587bfdd40	tsdb: trigger stats refresh on SHOW TSDB STATUS	4 months ago
Rene Cannao	2d51aeff64	tsdb: correctly implement SHOW TSDB commands and variable initialization	4 months ago
Rahim Kanji	b3e8955adb	Fixed error handling	4 months ago
Rene Cannao	6404d7b365	tsdb: implement SHOW TSDB VARIABLES and SHOW TSDB STATUS	4 months ago
Rahim Kanji	409070faa7	Add PostgreSQL \d tablename describe table support in Admin Handler ... Extend \d meta-command to support \d tablename for describing specific tables. Implements handlers for all 8 queries in the describe sequence: - Query 1: pg_class lookup with c.relname OPERATOR (extracts/caches table) - Query 2: pg_class attributes with c.oid= (table metadata) - Query 3: pg_attribute with PRAGMA table_info() (column information) - Queries 4-8: pg_policy, pg_statistic_ext, pg_publication, pg_inherits (return empty results as SQLite lacks these features)	4 months ago
Rene Cannao	c73011b302	tsdb: implement REST API and basic UI dashboard	4 months ago
Rene Cannao	4e0f94a345	tsdb: fix compilation error in ProxySQL_Admin.cpp	4 months ago
Rene Cannao	a236a13787	tsdb: dedicated module for TSDB variables with tsdb- prefix and optimized background tasks	4 months ago
Rene Cannao	da877c378b	tsdb: align admin variable lifecycle, full prometheus ingestion, docs and tap coverage	4 months ago
Rene Cannao	f17e999830	Implement SQLite-based TSDB subsystem ... Add time-series database extension to ProxySQL_Statistics with: - Three SQLite tables: tsdb_metrics, tsdb_metrics_hour, tsdb_backend_health - Automatic downsampling from raw to hourly aggregates - Retention management (7 days raw, 1 year hourly) - Prometheus metrics sampling - Backend health monitoring via TCP probes - SQL query interface with JSON label filtering - Admin variable integration Documentation: - embedded_tsdb_overview.md - Architecture and benefits - embedded_tsdb_architecture.md - System design and components - embedded_tsdb_reference.md - Configuration and API reference - embedded_tsdb_specs.md - Technical specifications - embedded_tsdb_quickstart.md - Getting started guide All 4 build combinations pass: - make debug / make release - PROXYSQLGENAI=1 make debug / make release	4 months ago
René Cannaò	5de836a4c1	Merge pull request #5373 from sysown/v3.0_improve_mysql_monitoring_5256 ... Improve MySQL Monitor connection management	4 months ago
René Cannaò	3b578db4bf	Merge pull request #5374 from sysown/v3.0-test0213 ... Fix Valgrind-reported uninitialized memory issues	4 months ago
René Cannaò	83209da487	Merge pull request #5356 from sysown/v3.0-5355 ... Fix #5355: Add null pointer check in RequestEnd() to prevent use-after-free crash	4 months ago
Rene Cannao	37e72ea3f9	Fix PROXY protocol detection in MySQL_Data_Stream::read_from_net ... When pkts_recv==0, the code reads 4 bytes expecting a MySQL packet header, but PROXY protocol starts with 'PROXY ' which gets misinterpreted as a MySQL header with a huge packet length (0x504f5250 = ~1.3GB). Add check for 'PROX' prefix before parsing as MySQL header. This prevents passing an incorrect length parameter to recv() that exceeds the buffer size. Fixes #5376	4 months ago
Rene Cannao	11a43bf768	Fix uninitialized max_allowed_pkt in MySQL_Connection constructor ... Initialize options.max_allowed_pkt to 0 to prevent Valgrind errors when logging handshake debug information.	4 months ago
Rene Cannao	ca4f858b29	Fix uninitialized memory read in pgsql tokenizer ... Change malloc() to calloc() in get_result_buffer() to zero-initialize the query digest buffer before use. This prevents stage_2_parsing() from reading uninitialized memory when processing query digests. Fixes #5375	4 months ago
Rene Cannao	85952373d9	Fix uninitialized mondb pointer in MySQL_Monitor_State_Data constructor ... Add mondb = NULL initialization to prevent Valgrind errors when monitor threads access the pointer before it's properly set.	4 months ago
Rahim Kanji	8ca6323eef	Merge remote-tracking branch 'Master/v3.0' into v3.0_pgsql-prepared-statement-refcount-race-5352	4 months ago
Rene Cannao	200fdecb8d	Apply AI agent review fixes to PR #5374 ... Critical Fixes: - Fix NULL pointer dereferences in MySQL_Logger.cpp: * Add null checks for myds->myconn->parent in log_audit_entry() * Fix cleanup code in log_request() and log_audit_entry() * Change sprintf to snprintf for buffer safety - Remove redundant pthread_rwlock_init in debug.cpp: * filters_rwlock already initialized with PTHREAD_RWLOCK_INITIALIZER * Re-initialization caused undefined behavior per POSIX Major Improvements: - Add bounded wait helper wait_for_glo_mth() in proxysql_utils.h: * Replaces indefinite while loops with 10s timeout * Applied to 26 locations across 4 files Build System: - Require C++17 in Makefile (remove C++11 fallback): * Code uses C++17 structured bindings extensively * Cleanest solution vs adding fallback guards to 27+ locations Compilation fixes: - Add unistd.h include for usleep - Remove conflicting GloMyMon extern declaration Files changed: - Makefile - include/proxysql_utils.h - lib/MySQL_Logger.cpp - lib/debug.cpp - lib/MySQL_Monitor.cpp - lib/ProxySQL_Admin.cpp - lib/ClickHouse_Server.cpp - src/SQLite3_Server.cpp	4 months ago
Rahim Kanji	1cccfb3220	Fix connection cleanup in failure paths	4 months ago
Rene Cannao	941e6b7320	Fix filters_rwlock initialization race condition ... Add static initialization PTHREAD_RWLOCK_INITIALIZER to filters_rwlock in debug.cpp to prevent race condition where proxy_debug() is called before init_debug_struct() initializes the rwlock. This fixes Valgrind errors in filter_debug_entry() where threads were accessing an uninitialized rwlock.	4 months ago
Rene Cannao	3c85c593cf	Add GloMTH initialization wait to all monitor and server threads ... Fix race condition where threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int() and related functions. Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to ensure GloMTH is fully initialized before use: In lib/MySQL_Monitor.cpp: - monitor_connect(), monitor_ping(), monitor_read_only() - monitor_group_replication(), monitor_galera(), monitor_replication_lag() - monitor_AWS_Aurora_thread_HG(), monitor_aws_aurora() - init_mysql_thread_struct() In src/SQLite3_Server.cpp: - SQLite3_Server_session_handler In lib/ProxySQL_Admin.cpp: - admin_session_handler In lib/ClickHouse_Server.cpp: - ClickHouse_Server_session_handler The pattern ensures threads wait for GloMTH initialization during startup, then check for NULL during shutdown to exit cleanly.	4 months ago
Rene Cannao	aa53d990ed	Add GloMTH initialization wait to all monitor threads ... Fix race condition where monitor threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int(). Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to: - monitor_ping_thread - monitor_read_only_thread - monitor_replication_lag_thread - monitor_group_replication_thread (also moved check before MySQL_Thread creation) - monitor_galera_thread (also moved check before MySQL_Thread creation) This matches the existing pattern in monitor_connect_thread.	4 months ago
Rene Cannao	f4cd34be5c	Fix race condition in monitor_connect_thread ... Add wait loop for GloMTH initialization before accessing variables. Other monitor threads (MonitorPing, MonitorReadOnly, etc.) already had this pattern, but monitor_connect_thread was missing it. This fixes Valgrind errors about uninitialized values in get_variable_uint16() when strcasecmp reads from memory that hasn't been fully initialized yet.	4 months ago
Rahim Kanji	33ce4217f0	Merge remote-tracking branch 'v3.0' into v3.0_improve_mysql_monitoring_5256	4 months ago
Rahim Kanji	9eac5f6420	Improve async ping mmsd ownership tracking and pool validation	4 months ago
Rene Cannao	09d0dcb808	Fix uninitialized tmp_charset in Data_Stream constructors ... Initialize tmp_charset=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. This field was used uninitialized in process_pkt_handshake_response() when calling proxy_debug(), causing Valgrind errors about uninitialized values in vsnprintf.	4 months ago
Rene Cannao	7c67eb25f1	Fix uninitialized fd and status in Data_Stream constructors ... Initialize fd=-1 and status=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. These fields were not initialized, causing Valgrind errors when GPFC_Statuses2() checked mybe->server_myds->status and fd.	4 months ago
Rene Cannao	4e39297ef9	Fix more Valgrind uninitialized value errors ... 1. Base_Thread.cpp: Initialize member variables in constructor - curtime, last_move_to_idle_thread_time, epoll_thread, shutdown, mysql_sessions were not initialized, causing uninitialized value use in ProcessAllMyDS_BeforePoll and ProcessAllMyDS_AfterPoll. 2. MySQL_Logger.cpp: Initialize query_ptr, query_len, and buf in MySQL_Event constructor. These fields were used without initialization, causing Valgrind errors in JSON serialization and other operations.	4 months ago
Rene Cannao	fdbea2a32e	Fix uninitialized memory in Command_Counter::_counters ... Replace _counters{} initialization syntax with explicit memset() to ensure the _counters array is properly zero-initialized. The _counters{} syntax may not reliably zero-initialize arrays in all compiler implementations, causing Valgrind to report use of uninitialized values when add_and_reset() reads from the array. Also remove the safety checks added previously since the root cause is now properly fixed.	4 months ago
Rene Cannao	c2f82b3d4e	Fix more Valgrind uninitialized value errors ... 1. MySQL_Logger.cpp: Initialize username_len, schemaname_len, and server_len to 0 in MySQL_Event constructor. These fields were uninitialized and used in copy constructor and JSON serialization. 2. debug.cpp: Add default member initializers to DebugLogEntry struct to ensure POD fields are zero-initialized. Move errno save/restore to after early return checks to avoid potential TLS access issues before thread is fully initialized.	4 months ago
Rene Cannao	ee7ee0b387	Fix multiple Valgrind-reported uninitialized memory issues ... 1. MySQL_Logger.cpp: Add NULL checks for myconn->parent before accessing address/port. Client connections (frontend) have parent=NULL, causing uninitialized value reads when logging. 2. debug.cpp: Add NULL check for GloVars.global.gdbg_lvl before accessing debug level configuration. Prevents use of uninitialized data when proxy_debug_func is called before init_debug_struct() completes. 3. ProxySQL_Admin.cpp: Add NULL checks for debug filter database fields before constructing filter strings. Prevents undefined behavior when constructing std::string from NULL pointers.	4 months ago
Rene Cannao	af58865b06	Fix uninitialized memory in QueryParserArgs.buf ... Use memset to zero-initialize the entire QueryParserArgs struct instead of individually setting only digest_text and first_comment to NULL. This fixes Valgrind errors about use of uninitialised values in strcasestr() when reading from the uninitialized buf array. Fixes errors like: Use of uninitialised value of size 8 at tolower (ctype.c:46) by strcasestr by MySQL_Connection::ProcessQueryAndSetStatusFlags(char*)	4 months ago
Rene Cannao	cc53ddca23	Merge branch 'v3.0-openssl-fix' into v3.0-test0213	4 months ago
Rene Cannao	52718df11f	Fix memory leak in stats processlist functions ... - Add missing delete resultset in stats___mysql_processlist - Add missing delete resultset in stats___pgsql_processlist	4 months ago
vramesha	71143c2e84	Address AI review comments ... - Added <pthread.h> to log_utils.h and removed the header from log_utils.cpp - Pass 0 to reset_time argument in flush_and_rotate inside logger's destructor	4 months ago
Rene Cannao	746eca9f7c	More sprintf to snprintf conversions and indentation fixes ... - Replace remaining sprintf with snprintf in Admin_FlushVariables.cpp - Fix indentation in flush_GENERIC_variables__process__database_to_runtime - Apply same pattern to ProxySQL_Admin.cpp and ProxySQL_Admin_Stats.cpp	4 months ago
Rene Cannao	3e37337877	Use RAII for sqlite3 statements across codebase ... - Convert prepare_v2() calls to use unique_ptr RAII pattern - Remove manual sqlite3_finalize calls (now handled by RAII) - Update flush_*_variables functions to use new prepare_v2 return pattern - Apply changes to Admin, Cluster, Monitor, Catalog, and other modules	4 months ago
Rene Cannao	335be9ec72	Fix unsafe sprintf and error message handling ... - Replace sprintf with snprintf in flush_*_variables functions - Add null value safety with safe_val in variable flushing - Fix error message to use send_error_msg_to_client instead of send_ok_msg_to_client	4 months ago
Rene Cannao	61ce0a96e8	Remove redundant sqlite3_finalize calls in pgSQL stats ... Statements are managed by RAII and auto-finalized	4 months ago
Rene Cannao	afd6dffb05	Fix admin shutdown races and implement graceful teardown ... - Add coordinated shutdown for PROXYSQL KILL/SHUTDOWN in debug builds - Track active admin client threads with admin_client_threads_active counter - Add shutdown checks to prevent new connections during shutdown - Wait for all admin client threads to finish before cleanup in admin_shutdown() - Handle accept failures gracefully	4 months ago
Rene Cannao	368a9e3a63	Fix log_buffer debug leak during shutdown	4 months ago
Rene Cannao	ba86be70a6	Fixed some bugs in PR 5358	4 months ago
Rahim Kanji	bed851471a	Fix MySQL Monitor assertion failure in DEBUG builds ... Introduce destroy_mysql_connection() helper to centralize the pattern of unregistering, closing, and nullifying MySQL connections in monitor threads.	4 months ago
Rene Cannao	da7c8e5cf5	Fix missing variable	4 months ago
Rene Cannao	4ae5bd852a	Revert "fix: prevent dangling pointer in flush_*_variables___runtime_to_database" ... This reverts commit a20b2704f4.	4 months ago
René Cannaò	02ea4f90be	Merge pull request #5360 from sysown/v3.0-5359 ... fix: crash on macOS/FreeBSD when running PostgreSQL queries	4 months ago
René Cannaò	e82ff6f8aa	Merge pull request #5361 from sysown/v3.0-5069 ... Add protocol labels for all PostgreSQL metrics and extend prometheus metrics coverage	4 months ago
Rene Cannao	a69b925932	Minor typo fixes	4 months ago
Rahim Kanji	9460520999	Add more tests	4 months ago
Rahim Kanji	e76d9dc130	Cleanup	4 months ago
vramesha	091942e9d6	Address AI review suggestions	4 months ago
Rahim Kanji	331b0d6bce	Add support for PostgreSQL psql meta-commands in admin interface ... Implement handling for psql meta-commands (\dt, \di, \dv, \d, \l) in ProxySQL's PostgreSQL admin interface by intercepting expanded queries and converting them to appropriate SQLite queries. Supported commands: - \l, \l+: List databases (maps to PRAGMA DATABASE_LIST) - \dt [pattern]: List tables with optional pattern matching - \di [pattern]: List indexes with optional pattern matching - \dv [pattern]: List views with optional pattern matching - \d: List all relations (tables, views, indexes, triggers) Pattern matching supports psql regex syntax like '\dt mytest*' by converting PostgreSQL regex patterns (^(pattern).*$) to SQLite LIKE patterns (pattern%).	4 months ago
vramesha	15a4ed66e9	Optimize query logging performance (#5243) ... Detailed Changes: - Introduced LogBuffer and LogBufferThreadContext to implement per-thread buffering, reducing lock contention. - Replaced localtime() with localtime_r() for improved performance and thread safety during timestamp generation. - Implemented configurable sampling for event logs to reduce I/O overhead. - Added global configuration variables to control flush size, flush interval, and sampling rate for event and audit logs.	4 months ago
Wazir Ahmed	2d3d12b9a0	Address review comments from gemini and coderabbit	4 months ago
Wazir Ahmed	471ebca74c	fix: GENAI modules fails to initialise ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Wazir Ahmed	ae92ae265f	Merge branch 'v3.0' into v4.0-mcp-stats	4 months ago
Wazir Ahmed	7f19b642c2	MCP: Rewrite stats tool handlers based on updated spec ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Rene Cannao	3ab964010d	Add protocol labels to Query Cache metrics and enable PostgreSQL QC metrics ... This commit resolves the prometheus metric collision between MySQL and PostgreSQL Query Cache instances by creating separate metric maps with protocol labels and using compile-time type trait selection. Changes: - Add #include <type_traits> to Query_Cache.cpp - Create qc_metrics_map_mysql with { "protocol", "mysql" } labels (8 metrics) - Create qc_metrics_map_pgsql with { "protocol", "pgsql" } labels (8 metrics) - Modify Query_Cache constructor to use if constexpr with std::is_same_v to select the appropriate metrics map based on derived type - Enable GloPgQC metrics export in update_modules_metrics() This allows MySQL and PostgreSQL query cache metrics to coexist without collision, following the same pattern as Thread Handler metrics. Related: #5068, #5069	4 months ago
Rene Cannao	778e01174c	Add protocol labels to Thread Handler metrics and enable PostgreSQL metrics ... This commit extends PR #5069 by adding protocol labels to distinguish MySQL and PostgreSQL metrics in the Thread Handler modules. Changes: - Add { "protocol", "mysql" } labels to 65 MySQL_Thread.cpp metrics - Add { "protocol", "pgsql" } labels to 60 PgSQL_Thread.cpp metrics - Enable GloPTH (PostgreSQL threads handler) metrics export - Document Query Cache limitation (template base class collision) This resolves Issue #5068 by ensuring PostgreSQL prometheus metrics are properly exported with protocol labels, distinguishing them from MySQL metrics. Related: #5068, #5069	4 months ago
René Cannaò	fa35bda62b	Merge pull request #5069 from evkuzin/v3.0-fix-prometheus-metrics-dumplication ... add protocol labels for shared metrics between mysql and psql	4 months ago
Rene Cannao	17054cd14f	fix: memory leak in pull_global_variables_from_peer ... The statement1 was prepared but never finalized, causing a memory leak. Migrated to RAII pattern for automatic cleanup. Also updates mysql_hostgroup_attributes and mysql_servers_ssl_params to use RAII for consistency (lines 2231 and 2267), even though those had manual finalize calls. Reported-by: CodeRabbit AI	4 months ago
Rene Cannao	deb19a021c	fix: remove double-finalization in stats___save_mysql_query_digest_to_sqlite ... The RAII-managed unique_ptr already handles statement finalization. Manual finalize calls cause double-free which leads to undefined behavior. Reported-by: CodeRabbit AI	4 months ago
Rene Cannao	a20b2704f4	fix: prevent dangling pointer in flush_*_variables___runtime_to_database ... Move statement2_unique to function scope to prevent use-after-free. The unique_ptr was declared inside the if (runtime) block but statement2 (raw pointer) was used in the loop outside that block, causing the statement to be finalized before use. Affected functions: - flush_variables___runtime_to_database (PgSQL variables) - flush_genai_variables___runtime_to_database (GenAI variables) - flush_mysql_variables___runtime_to_database (MySQL variables) Reported-by: CodeRabbit AI	4 months ago
René Cannaò	fcaa904135	fix: crash on macOS/FreeBSD when running PostgreSQL queries ... Fix NULL pointer dereference in CopyCmdMatcher that caused ProxySQL to crash immediately when running any PostgreSQL query on macOS and FreeBSD systems. Root cause: copy_cmd_matcher was guarded by #ifdef IDLE_THREADS, but IDLE_THREADS is explicitly disabled on macOS (__APPLE__) and FreeBSD in proxy_defines.h. This caused the pointer to be NULL when accessed. The fix removes #ifdef IDLE_THREADS guards from copy_cmd_matcher since COPY command detection is a fundamental PostgreSQL feature for fast- forward mode and has no dependency on idle threads. Affected systems: macOS, FreeBSD (where IDLE_THREADS is disabled) Fixes: #5359	4 months ago
Rene Cannao	6f415dfdb2	fix: correct RAII migration issues - variable naming and redundant declarations ... - Fixed SAFE_SQLITE3_STEP2 macro errors: renamed 'rc1' to 'rc' in PgSQL_Monitor.cpp functions (update_connect_table, update_ping_table, update_readonly_table, maint_monitor_table) to match the macro's expected variable name - Removed redundant NULL declarations in ProxySQL_Admin_Stats.cpp functions (stats___pgsql_processlist, stats___pgsql_free_connections, stats___pgsql_errors, stats___save_pgsql_query_digest_to_sqlite) - Completed migration of stats___pgsql_errors and stats___save_pgsql_query_digest_to_sqlite to RAII pattern	4 months ago
Rene Cannao	7c0ff770f6	refactor: migrate prepare_v2 SIMPLE cases in ProxySQL_Admin_Stats.cpp ... Migrated all prepare_v2 calls to RAII-based pattern in 5 functions: - stats___mysql_processlist(): 2 statements (statement1, statement32) - stats___pgsql_processlist(): 2 statements - stats___mysql_free_connections(): 2 statements - stats___mysql_query_rules(): 2 statements - stats___mysql_query_digest(): 2 statements And removed manual finalization calls for all functions. The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	4 months ago
Rene Cannao	ee85b11ad5	refactor: migrate prepare_v2 SIMPLE case in PgSQL_HostGroups_Manager.cpp ... Migrated 1 function with 2 prepare_v2 calls to RAII-based pattern in: - generate_pgsql_hostgroup_attributes_table(): 2 statements (statement1, statement2) The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	4 months ago
Rene Cannao	e4704c5a51	refactor: migrate prepare_v2 SIMPLE cases in PgSQL_Monitor.cpp ... Migrated 5 prepare_v2 calls to RAII-based pattern in: - update_monitor_pgsql_servers(): 2 statements (stmt1, stmt32) - update_connect_table(): 1 statement (stmt) - update_ping_table(): 1 statement (stmt) - update_readonly_table(): 1 statement (stmt) - maint_monitor_table(): 1 statement (stmt) Note: Functions shunn_non_resp_srv() and update_srv_latency() were NOT migrated because they use global thread_local cached statements, which is a valid use case for the old API. The RAII pattern ensures automatic cleanup and eliminates manual sqlite_finalize_statement() calls.	4 months ago
Rene Cannao	73555410e9	refactor: migrate prepare_v2 SIMPLE case in FlushDigestTableToDisk template ... Migrated the template function FlushDigestTableToDisk to use RAII-based prepare_v2. This function is instantiated for both MySQL and PostgreSQL, eliminating 8 deprecation warnings (4 instantiations x 2 prepare_v2 calls). The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	4 months ago
Rene Cannao	2e907bdd3a	refactor: migrate prepare_v2 SIMPLE cases in ProxySQL_Cluster.cpp ... Migrated 4 prepare_v2 calls to RAII-based pattern in: - pull_mysql_query_rules_from_peer(): 3 statements (statement1, statement1fr, statement32fr) - update_mysql_users(): 1 statement (also fixes memory leak - missing finalize) - update_ldap_mappings(): 1 statement (also fixes memory leak - missing finalize) The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls, reducing the risk of resource leaks.	4 months ago
Rene Cannao	e3ee454369	fix: remove duplicate 'int rc' declarations in prepare_v2 migrated functions ... The RAII-based prepare_v2 migration introduced duplicate variable declarations that caused compilation errors. Removed duplicate 'int rc;' declarations in: - dump_checksums_values_table() - save_mysql_users_runtime_to_database() - save_pgsql_users_runtime_to_database() The 'int rc' variable was already declared at function scope, so the duplicate declarations after the structured bindings were redundant.	4 months ago
Rene Cannao	5b6381b329	refactor: migrate remaining prepare_v2 SIMPLE cases in ProxySQL_Admin ... Migrated: - save_pgsql_ldap_mapping_runtime_to_database() - save_mysql_servers_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	4 months ago
Rene Cannao	2a83a30972	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin ... Migrated: - save_pgsql_users_runtime_to_database() - save_mysql_ldap_mapping_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	4 months ago
Rene Cannao	ca9b72a9df	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin ... Migrated: - dump_checksums_values_table() - save_mysql_users_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	4 months ago
Rene Cannao	e56da24c81	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin ... Migrated: - save_mysql_firewall_whitelist_rules_from_runtime() - save_pgsql_firewall_whitelist_rules_from_runtime() All statements are now automatically managed by RAII smart pointers.	4 months ago
Rene Cannao	575449cdf6	refactor: migrate all prepare_v2 SIMPLE cases to RAII API in ProxySQL_Admin ... Migrated the following functions: - save_mysql_query_rules_fast_routing_from_runtime() - save_pgsql_query_rules_fast_routing_from_runtime() - save_mysql_firewall_whitelist_sqli_fingerprints_from_runtime() - save_pgsql_firewall_whitelist_sqli_fingerprints_from_runtime() - save_mysql_firewall_whitelist_users_from_runtime() - save_pgsql_firewall_whitelist_users_from_runtime() All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	4 months ago
Rene Cannao	f779a6059a	refactor: migrate remaining prepare_v2 SIMPLE cases in MySQL_Monitor ... Migrated the following functions: - populate_monitor_mysql_server_aws_aurora_log() - populate_monitor_mysql_server_aws_aurora_check_status() - monitor_ping_process_ready_task_thread() - monitor_read_only_process_ready_tasks() (with if/else branches for replication_lag) All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	4 months ago
Rene Cannao	bdba0b44a0	refactor: migrate all prepare_v2 SIMPLE cases to RAII API in MySQL_Monitor ... Migrated the following functions: - update_monitor_mysql_servers() - update_monitor_proxysql_servers() - monitor_connect_thread() - monitor_ping_thread() - monitor_read_only_thread() - monitor_replication_lag_thread() - monitor_connect() cleanup - monitor_ping() cleanup - monitor_read_only() cleanup - monitor_replication_lag() cleanup - populate_monitor_mysql_server_group_replication_log() - populate_monitor_mysql_server_galera_log() All statements are now automatically managed by RAII smart pointers, eliminating manual finalize calls and potential memory leaks.	4 months ago
Rene Cannao	854ab4fbb6	refactor: migrate generate_pgsql_hostgroup_attributes_table() to RAII prepare_v2 ... - Changed from raw pointer to smart pointer-based prepare_v2 - Fixes existing memory leak where statement was never finalized - RAII ensures automatic cleanup when function exits	4 months ago
Rene Cannao	9939fe17e4	refactor: migrate generate_pgsql_servers_table() to RAII prepare_v2 ... - Changed from raw pointer to smart pointer-based prepare_v2 - Use raw pointer aliases to avoid .get() verbosity - Remove manual finalize - RAII handles cleanup automatically	4 months ago
Rene Cannao	41564acaac	Fix #5355: Add null pointer check in RequestEnd() to prevent use-after-free crash ... This commit addresses a use-after-free race condition that could cause ProxySQL to crash with SIGSEGV during COM_CHANGE_USER timeout scenarios. Root Cause: ----------- When a session is in RESETTING_CONNECTION status and the backend times out during COM_CHANGE_USER, the code calls RequestEnd() to handle the error. However, RequestEnd() accesses client_myds without null checks. If the session is marked as unhealthy and deleted by ProcessAllSessions_Healthy0() while RequestEnd() is still executing, this results in a use-after-free crash. The crash is particularly likely during AWS Aurora failures when: 1. Monitor detects Aurora master timeouts 2. Multiple sessions experience connection issues 3. Many client connections are marked unhealthy 4. The high volume of session deletions increases race condition probability Fix: ---- Added a null pointer check before accessing client_myds in the unexp_com_pings handling code within RequestEnd(). This is a defensive programming fix that prevents the crash when client_myds has been freed. A more robust fix would involve proper session lifecycle management with reference counting. Fixes: #5355	4 months ago
Rene Cannao	7c2c6121e5	refactor: migrate prepare_v2 to RAII API in ProxySQL_Admin_Tests2 ... Migrate 2 test functions from deprecated prepare_v2() to the new RAII-based API: - ProxySQL_Test___GenerateRandom_mysql_query_rules_fast_routing() - ProxySQL_Test___MySQL_HostGroups_Manager_generate_many_clusters() Both are test functions with clear structure - simple cases. Uses raw pointer aliases to avoid .get() verbosity. Pattern used: auto [rc, statement_unique] = admindb->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly ... // No manual finalize - RAII handles it This addresses 3 of the ~150 deprecated prepare_v2 warnings.	4 months ago
Rene Cannao	2c8c27bf64	refactor: migrate prepare_v2 to RAII API in Admin_FlushVariables ... Migrate 4 functions from deprecated prepare_v2() to the new RAII-based API: - flush_pgsql_variables___runtime_to_database() - flush_genai_variables___runtime_to_database() - flush_mysql_variables___runtime_to_database() - flush_mcp_variables___runtime_to_database() All early returns happen before prepare_v2(), making these simple cases. Uses raw pointer aliases to avoid .get() verbosity. Pattern used: auto [rc, statement_unique] = db->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly ... // No manual finalize - RAII handles it This addresses 4 of the ~150 deprecated prepare_v2 warnings.	4 months ago
Rene Cannao	9262089060	refactor: migrate prepare_v2 to RAII API in MySQL_Logger ... Migrate insertMysqlEventsIntoDb() function from deprecated prepare_v2() to the new RAII-based API using raw pointer aliases. Pattern used: auto [rc, statement_unique] = db->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly ... // No manual finalize - RAII handles it This addresses 2 of the ~150 deprecated prepare_v2 warnings.	4 months ago
Rene Cannao	4161372da7	refactor: migrate simple prepare_v2 cases to RAII-based API ... Migrate 11 functions in MySQL_HostGroups_Manager.cpp from the deprecated prepare_v2() API to the new RAII-based API. Uses raw pointer aliases to avoid .get() verbosity throughout the code. Changes per function: - servers_add() - All mysql_* table generation functions - Group replication, Galera, AWS Aurora hostgroups functions Pattern used: auto [rc, statement_unique] = mydb->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly, no .get() needed ... // No manual finalize - RAII handles it Benefits: - Automatic cleanup via RAII (no manual finalize needed) - Exception-safe cleanup on early returns - Reduced memory leak risk This addresses ~11 of the ~150 deprecated prepare_v2 warnings. Found during compiler warning analysis with 'make debug'.	4 months ago
Rene Cannao	df1c4e7928	fix: medium priority warnings - write-strings and unused variables ... 1. Fix write-strings warnings (12 occurrences): - MySQL_HostGroups_Manager.cpp: Change char* to const char* for src_status and dst_status variables - MySQL_Monitor.cpp: Change ConsumerThread constructor parameter from char thread_name[16] to const char *thread_name 2. Fix unused-but-set-variable warnings (6 occurrences) by wrapping PROXYSQLGENAI-specific variables in #ifdef blocks: - stats_mcp_query_tools_counters - stats_mcp_query_tools_counters_reset - stats_mcp_query_digest - stats_mcp_query_digest_reset - stats_mcp_query_rules - runtime_mcp_query_rules These variables were assigned values but appeared unused when PROXYSQLGENAI was not defined. Now they are only defined and assigned when PROXYSQLGENAI is enabled. This eliminates 18 compiler warnings: 12 write-strings and 6 unused-but-set-variable warnings. Found during compiler warning analysis with 'make debug'.	4 months ago
Rene Cannao	4c788dcbb3	fix: signed/unsigned comparison warnings (-Wsign-compare) ... Fix two HIGH priority signed/unsigned comparison warnings: 1. MySQL_HostGroups_Manager.cpp:1792 - Change loop variable from 'int j' to 'unsigned int j' to match the unsigned comparison with servers->len. 2. MySQL_Thread.cpp:4357 - Cast int to size_t when comparing with getBufferSize() which returns size_t. These changes prevent potential logic errors from negative values being interpreted as large unsigned values. Found during compiler warning analysis with 'make debug'.	4 months ago
Rene Cannao	9e83a81b4c	fix: critical use-after-free in child_telnet function ... Fix use-after-free vulnerability where the function frees the 'arg' pointer at line 2306 but then returns it at line 2323. Change the return value to NULL instead of the freed pointer. This fixes a -Wuse-after-free compiler warning and prevents potential memory corruption. Found during compiler warning analysis with 'make debug'.	4 months ago
Rahim Kanji	557bdb6213	Added missing iterator advancement	4 months ago
Rahim Kanji	230985e93e	Fix: PostgreSQL prepared statement purge race condition ... The fix ensures that when the purge checks ref_count_client under write lock, it sees the latest value from concurrent threads holding raw pointers, preventing reading stale data.	4 months ago
René Cannaò	a360dc22ae	Merge pull request #5308 from sysown/v3.0_mac ... Support for ProxySQL compilation on macOS (Darwin/Apple Silicon)	4 months ago
René Cannaò	48f1b3cfef	Merge pull request #5095 from Gonlo2/fix-overflow-if-first-server-is-invalid ... Fix int overflow if the first server is invalid	4 months ago
René Cannaò	de0a9b9c27	Merge pull request #5093 from Gonlo2/fix-usage-deleted-con ... Avoid usage of deleted connection	4 months ago
René Cannaò	77fe582801	Merge pull request #5317 from sysown/v3.0.6-implement_FLUSH_STATS ... implement admin command 'PROXYSQL FLUSH STATS'	4 months ago
René Cannaò	ce9fdc9d7a	Merge branch 'v3.0' into v3.0.6-implement_FLUSH_STATS ... Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
Rene Cannao	e3026cbc6f	Fix wrong index in connection cleanup loops (MySQL and PgSQL) ... This commit fixes a bug where connection cleanup loops were removing the wrong connection from the pool. The loops checked each connection by index (i), but when an expired connection was found, they removed index 0 instead of index i. This caused: - Fresh connections at index 0 to be incorrectly deleted - Expired connections to remain in the pool Fixed files: - lib/Base_HostGroups_Manager.cpp:2603 (MySQL) - lib/MySQL_HostGroups_Manager.cpp:2939 (MySQL) - lib/PgSQL_HostGroups_Manager.cpp:2782 (PgSQL) The fix changes `remove(0)` to `remove(i)` to remove the correct connection. Related: #5094 (fixes similar issue in drop_all_idle_connections)	4 months ago
René Cannaò	0524363322	Merge pull request #5339 from sysown/v3.0-merge-v4.0-genai ... Merge v4.0 GenAI features into v3.0 with conditional compilation	4 months ago
Wazir Ahmed	adb059c4b5	mcp/stats: Add doxygen documentation for tool handlers ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Wazir Ahmed	643b322f29	MCP: Add stats endpoint and tools ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
René Cannaò	27f13ca18d	Merge pull request #5096 from Gonlo2/fix-close-ssl-con ... Avoid send close in ssl connections	4 months ago
Rene Cannao	79756e78d7	Fix missing #endif for PROXYSQLGENAI guard in Admin_Handler.cpp	4 months ago
Rene Cannao	1af768f932	Fix critical issues in GenAI code (PR #5339) ... This commit addresses critical issues identified in the PR review: 1. Build system redundancy (src/Makefile): - Remove redundant PROXYSQLGENAI conditionals in linking commands - The flag doesn't affect linking, so simplify to PROXYSQLCLICKHOUSE only 2. Missing PROXYSQLGENAI guard (lib/Admin_Handler.cpp): - Add #ifdef PROXYSQLGENAI around MCP VARIABLES DISK commands - Ensures MCP commands are only available when GenAI is enabled 3. Broken retry logic (lib/LLM_Clients.cpp): - Remove misleading is_retryable_error() checks that used stale values - last_curl_code and last_http_code were never updated - Simplify to retry on empty responses only (documented limitation) - Fix thread-safety: use thread_local std::mt19937 instead of rand() 4. Resource leak (lib/MySQL_Tool_Handler.cpp): - Clean up previously created connections on init failure - Both mysql_init and mysql_real_connect error paths now clean up 5. Race condition (lib/Query_Tool_Handler.cpp): - Add missing pool_lock in find_connection() - Prevents race condition when accessing connection_pool Fixes identified by automated PR review agents.	4 months ago
Rene Cannao	b965fc6df4	Fix PROXYSQLGENAI build - resolve circular includes and missing headers ... This commit fixes compilation errors when building with PROXYSQLGENAI=1: Header file fixes: - Add missing #endif /* PROXYSQLGENAI */ before header guards in multiple headers - Remove #include cpp.h from GenAI headers to avoid circular dependencies Source file fixes: - Add #include proxysql.h to GenAI .cpp files that were missing it - Add #include Static_Harvester.h to Query_Tool_Handler.cpp for forward decl Build system fixes: - Remove vec.o from libproxysql.a (it's linked separately in src/Makefile) - Prevents duplicate symbol errors during linking Test files: - Rename MCP test files with .sh suffix to prevent make clean deletion Both build modes now work: - make build_lib_debug (without GenAI) - PROXYSQLGENAI=1 make build_lib_debug (with GenAI)	4 months ago
Rene Cannao	48bc7dd7bf	Merge v4.0 GenAI features into v3.0 with conditional compilation ... This commit merges the experimental v4.0 GenAI/MCP features into the stable v3.0 branch using conditional compilation. All v4.0 features are disabled by default and only enabled when PROXYSQLGENAI=1 is set at compile time. Changes: Build System: - Modified main Makefile to pass PROXYSQLGENAI flag to sub-makefiles - Modified deps/Makefile to conditionally build sqlite-vec and sqlite-rembed - Modified lib/Makefile to add PSQLGA flag and include GenAI object files - Modified src/Makefile to add PSQLGA flag and conditional linking Headers (wrapped with #ifdef PROXYSQLGENAI): - All 20 new GenAI header files in include/ - Modified cpp.h, proxysql_glovars.hpp, proxysql_admin.h - Modified ProxySQL_Admin_Tables_Definitions.h for GenAI/MCP tables Source Files: - All 22 new GenAI source files in lib/ wrapped with #ifdef PROXYSQLGENAI - Modified src/main.cpp for conditional global variables and init/shutdown - Modified Admin_Handler.cpp for conditional command handlers - Modified Admin_Bootstrap.cpp for conditional table registration - Modified Admin_FlushVariables.cpp for conditional variable flushing - Modified ProxySQL_Admin.cpp for conditional admin methods - Modified ProxySQL_Admin_Stats.cpp for conditional MCP stats functions - Modified proxy_sqlite3_symbols.cpp to always compile (needed by core) - Modified MySQL_Session.cpp for conditional GenAI function calls Test Files: - Renamed test_mcp_query_rules-t to test_mcp_query_rules-t.sh - Renamed test_mcp_rag_metrics-t to test_mcp_rag_metrics-t.sh - Modified anomaly_detection-t.cpp for conditional test execution Usage: # Build without GenAI (v3.0 mode - default) make clean && make build_deps -j$(nproc) && make build_lib -j$(nproc) && make build_src -j$(nproc) # Build with GenAI (v4.0 mode) make clean && PROXYSQLGENAI=1 make build_deps -j$(nproc) && PROXYSQLGENAI=1 make build_lib -j$(nproc) && PROXYSQLGENAI=1 make build_src -j$(nproc)	4 months ago
René Cannaò	e00617be11	Merge pull request #5333 from wazir-ahmed/v4.0-config-embedding-model ... RAG: Fix query embedding and vector search	4 months ago
Wazir Ahmed	10026891ce	RAG: Convert vector similarity search into a subquery ... - `sqlite-vec` requires that `knn` queries (using the `MATCH` operator for vector similarity search) must have a `LIMIT` clause at the same query level as the `MATCH` clause. - Execute `knn` queries as a subquery and then do `JOIN`s with `rag_chunks` and `rag_documents`. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Javier Jaramago Fernández	e351a0df74	feat: Add leading comments (--) detection for 'run_sql_readonly' ... Read only queries are no longer flagged as non-readonly when starting with double dash comments.	4 months ago
Miro Stauder	cc1d93d08b	implement admin command 'PROXYSQL FLUSH STATS' for DEBUG builds	4 months ago
Wazir Ahmed	8d022a0fcc	RAG: Add 'model' request parameter for embedding service ... - `model` is a required parameter for embedding request in OpenAI API specification. - https://platform.openai.com/docs/api-reference/embeddings Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Javier Jaramago Fernández	fec97bbabe	fix: Fix GENAI variable loading during 'ProxySQL_Admin::init'	4 months ago
Javier Jaramago Fernández	a5ef787c7e	feat: Improve logging for MCP and RAG tools ... - Add new column 'endpoint' for 'stats_mcp_query_tools_counters'. - Add new table 'rag_search_log' to log 'log_rag_search_fts' operations.	4 months ago
Wazir Ahmed	e4f4dc95ce	RAG: bm25 and MATCH do not work with table alias ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	c52c621b27	MCP: Add mcp-rag_endpoint_auth config ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	eb495f42ee	AI: Fix vector_db table creation ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	22c4e94d53	AI: Fix sqlite-vec extension loading ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	7167f95247	AI: Enable extensions for vector_db ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	4031f85394	AI: Fix vector_db initialization ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	cecb975f66	fix: LOAD GENAI TO RUNTIME does not initialize the module ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Wazir Ahmed	50de536534	MCP: Fix crash during server restarts ... Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	5 months ago
Rene Cannao	42a67ebaf2	Merge rahim/v4.0_rag_ingest into v4.0_rag_ingest_2 ... Merge changes from PR #5318 (RAG ingestion feature) into the new development branch v4.0_rag_ingest_2. Changes include: - RAG ingestion tool (rag_ingest) with chunking and embeddings - MySQL_Catalog fixes for NULL pointer handling - MCP server updates for RAG tools - Comprehensive documentation and test scripts	5 months ago
Rene Cannao	38e5e8e56b	Fix critical issues from coderabbitai review ... - Fix NULL pointer dereference in rag_ingest.cpp: use str_or_empty() helper for all sqlite3_column_text results assigned to std::string - Fix NULL tags/links crash in MySQL_Catalog.cpp: add null guards before assigning sqlite3_column_text results to std::string - Fix missing curl_global_cleanup on error path in rag_ingest.cpp - Fix std::out_of_range exception in rag_ingest.cpp: wrap std::stoll calls in try-catch blocks, fall back to string comparison on overflow	5 months ago
Rene Cannao	9ba3df0ce7	Address AI code review feedback from PR #5318 ... - Fix Makefile: Use $(CXXFLAGS) directly for consistency with build philosophy - Fix MySQL_Catalog: Return proper error JSON instead of empty array on missing query	5 months ago
Rahim Kanji	d28444a02e	Merge remote-tracking branch 'v4.0' into v4.0_rag_ingest	5 months ago