packer

Commit Graph

Author	SHA1	Message	Date
Lucas Bajolet	8f1da2fa79	hcl2template: split local evaluation functions Since we are in the process of integrating a new way to orchestrate dependency management and evaluation for datsources and local variables, we need to split the current function that manages the evaluation of said local variables, so that recursion and the actual evaluation of a local variable are two separate functions. This will allow for evaluating a single variable once the dag is ready to be introduced.	1 year ago
Lucas Bajolet	e1b8edf8d8	hcl2template: rename Datasource.Name to DSName The `Name` function is used by the DAG library to determine which vertex is associated to a component, so the `Name` attribute/function needs to replicate the combination of type and name, so the vertex can be accurately fetched from the graph.	1 year ago
Lucas Bajolet	8e21597e30	hcl2template: add refstring type for generic refs The hcl2template package contains references already, but these are linked to a particular type. This becomes problematic if we want to support cross-type references, so this commit adds a new abstraction: refString. A refString contains the component type, its type (if applicable), and its name, so that the combination of those points to a cty object that can be linked to a block in the configuration. Right now, only `var`, `local` and `data` are supported, but the type is extensible enough that anything else that fits this model such as sources can be supported in the future potentially.	1 year ago
Laurent Goudet	069a6ed62f	Add missing dash on `recursive` `fmt` command As per title, very minor fix but I might as well fix it.	1 year ago
hashicorp-tsccr[bot]	0e825e0a79	Result of tsccr-helper -log-level=info gha update .	1 year ago
Gregory Bonk	cef978f17c	Update datasources.mdx change Locals to local	1 year ago
yannic rieger	3c48f2661b	docs: add S3 community provisioner	1 year ago
Lucas Bajolet	69ec781ee2	hcp: don't continue if HEAD doesn't exist In HCP's metadata package, especially the VCS/git parts, we keep the current HEAD for a repository, along with the state it is in, in order to report it to HCP Packer when the build completes. However, when a build is run on a template from an empty Git repository, and HCP Packer is enabled, the code would crash when trying to get the information on the current HEAD, as it doesn't exist. The git library we use returns an error in such a case, but this was ignored, leading to a crash when attempting to get the hash to this reference later on. This commit fixes the problem by NOT ignoring the error to get the head, and immediately stop processing the git data as it doesn't yet exist.	1 year ago
dependabot[bot]	68730cfcf5	build(deps): bump github.com/hashicorp/hcp-sdk-go (#13162 ) Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.105.0 to 0.112.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.105.0...v0.112.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	1 year ago
Lucas Bajolet	3c449430e1	packer_test: make PluginTestDir a structure In order for the creation of a temporary directory to install plugins into to be simpler to understand and use, we change how the directory is created, cleaned-up, and installs plugins into. Now, instead of a tuple of a string (path) and a cleanup function, we return a structure that comprises the test suite, and the temporary directory, along with methods to handle those steps independently.	1 year ago
Lucas Bajolet	31b6109430	packer_test: hide run and introduce Output When using a PackerCommand, the Run function was made public as a way to access the contents of an execution. This was clumsy as it had too many responsabilities, and was not needed strictly as Assert was performing the executions, as many times as required. This could introduce cases in which one run as spent by the caller, then the remainder were executed through Assert. Therefore, we change this convention. Now, run is private to the type, and only through Assert can a command be executed. If a test needs access to a command's output, stderr, or error, it can do so through the Output function, which requires Assert to be called first.	1 year ago
Lucas Bajolet	71169416db	packer_test: add func to change assert behaviour When a command asserts its output with checkers, by default it will register errors through a t.Errorf. While this works, in some cases we would want to stop execution immediately if a function's Assert fails, as the rest of the test may depend on the assertion being valid. In the current state, this means either getting the result of the run to check if an error was returned (not fully reliable as if the command was run multiple times, and the last run succeeded, we won't get an error), or relying on t.IsFailed() (completely reliable). Instead, we introduce a new function on packerCommand, that lets users change how Assert behaves, so that if an error was reported, instead of logging the error and flagging the test as failed, we can use t.Fatalf, so that the test immedately fails and stops execution.	1 year ago
Lucas Bajolet	35b2317ef3	packer_test: rename/split lib into common/check The lib name for the common components for writing packer_test suites was not clear, and did not follow the convention established in Packer core and plugins. Therefore this commit does two things: first the lib is renamed into common as to follow this convention, and clearly document which components are common to all tests. Also checkers are placed in a subpackage of common, common/check, so that it is clearer what is meant to be used as checks for a command's execution status after it's been run, as part of Assert.	1 year ago
Lucas Bajolet	7f7ae8454a	packer_test: rename core test run function The function's name was the same as the plugins test suite runner/init function, making it impossible to differentiate between the two when looking at the logs, or when attempting to filter which tests to run using the suite function's name.	1 year ago
Lucas Bajolet	6fc2932b09	packer_test: reorganise plugins test suite init	1 year ago
Lucas Bajolet	2952a6621d	packer_test: remove empty defer func in suite init	1 year ago
Lucas Bajolet	3c8a51bdbf	packer_test: split BuildPackerPlugin in build/get The interface for building a plugin through the test suite was confusing, as it would build the plugin and return its path, cache the path for the version built, and return the path regardless if something was built or not. While in the current state this is harmless as builds are idempotent, since the state of the plugin package/module does not change, this will in the future as we introduce customisation techniques on the plugin's directory and files, making this double-use potentially dangerous. Furthermore, the current behaviour is unclear, as the function hides that caching mechanism, which could come as a surprise for users attempting to build a plugin for the duration of a test, while the built plugin is linked to the test suite being run, and not the unit test being evaluated. Therefore this commit changes the sequence in which plugins are built and used. Now the `CompilePlugin` function builds a plugin, and does not return its path anymore, instead terminating the tests immediately if they fail. In normal test usage, a new `GetPluginPath` function is introduced, which looks-up the path in the suite's cache, failing immediately if invoked before the plugin is built. With this change, it is heavily advised to build plugins when initialising the suite, then in the tests, the GetPluginPath function should be used to get a plugin's path for interacting with packer commands.	1 year ago
Lucas Bajolet	393f2e925b	packer_test: replace compiledPlugins by a sync.Map The compiledPlugins map with a mutex was essentially a glorified sync.Map, and therefore did not need to be defined as such. Instead, this commit replaces its uses by a normal sync.Map, and keeps it in the base test suite.	1 year ago
Lucas Bajolet	aba64b457c	packer_test: rename init function for base suite	1 year ago
Lucas Bajolet	dbd441f6f3	packer_test: add convenience func for invert grep As inverted grep is something we do rather often, we add a convenience function to create an inverted grep gadget.	1 year ago
Wilken Rivera	064a00e9db	Bump Go 1.22.7	1 year ago
hashicorp-tsccr[bot]	703e0de15c	Result of tsccr-helper -log-level=info gha update . (#13156 ) Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>	1 year ago
Wenfeng Pan	1b160e5df0	Add base64gzip function support to Packer template	2 years ago
Lucas Bajolet	ded0500109	packer_test: add plugins used gadget When testing a packer build or validate, one common use case is to check which plugins are loaded and used by Packer to run a command. This is generally done through Grep, but repeating the same pattern can be redundant, and if the output changes, all those need to be updated. Therefore, this commit introduces a PluginsUsed gadget, which can be orchestrated to ensure a plugin is used, or not used, allowing to check for multiple plugins at once.	2 years ago
Lucas Bajolet	6b158c5c24	packer_test: move some plugin functions to fs.go As a small reorganisation attempt, this commit moves some file-system oriented functions from plugin.go into its own file so they are more logically grouped.	2 years ago
Lucas Bajolet	96b4ae4767	packer_test: move BuildSimplePlugin to plugin.go In terms of organisation, we keep functions that interact with plugins into its own file, therefore the function that build plugin versions should really be in plugin.go, not in suite.go.	2 years ago
Lucas Bajolet	2fe11fb967	packer_test: move compiledPlugins to attribute The compiledPlugins map used to be a global variable, which can be problematic as we move to independent test suites, since those test suites run in the same process space, the global variable could point to now deleted plugin versions/paths in separate suites, which would make tests fail with random errors. To avoid this, the map is now scoped to the test suite, and a new copy is created lazily if used by the test suite.	2 years ago
Lucas Bajolet	9e4452329f	packer_test: make packer test suite modular Having only one test suite for the whole of Packer makes it harder to segregate between test types, and makes for a longer runtime as no tests run in parallel by default. This commit splits the packer_test suite into several components in order to make extension easier. First we have `lib`: this package embeds the core for running Packer test suites. This ships facilities to build your own test suite for Packer core, and exposes convenience methods and structures for building plugins, packer core, and use it to run a test suite in a temporary directory. Then we have two separate test suites: one for plugins, and one for core itself, the latter of which does not depend on plugins being compiled at all. This sets the stage for more specialised test suites in the future, each of which can run in parallel on different parts of the code.	2 years ago
Wilken Rivera	2a206ccd68	Enable github workflows on feature branches	2 years ago
Lucas Bajolet	199a751353	docs: remove trailing whitespaces from the docs	2 years ago
Lucas Bajolet	6514a66131	docs: update manually installing plugins docs The installing plugins docs had information on manually installing plugins that was misleading a bit, so we update that section with this commit.	2 years ago
dependabot[bot]	a1caaad47d	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.99.0 to 0.105.0 (#13129 ) Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.99.0 to 0.105.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.99.0...v0.105.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
hashicorp-tsccr[bot]	eb77d54973	Result of tsccr-helper -log-level=info gha update . (#13131 ) Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>	2 years ago
Jeanne Angeles Franco	6f3aab147d	Add artifacts manifest (automatically generated) (#13132 ) * Add artifacts manifest (automatically generated) * add copyright header	2 years ago
Lucas Bajolet	85b0325309	CHANGELOG: update for 1.11.2 release	2 years ago
Devashish	265dfe105a	Remove suffix from CICD platform type (#13121 )	2 years ago
Wilken Rivera	c7dd5af450	Enable ci builds for feature branches	2 years ago
Devashish	aa6c5f8405	feat: Phase 2 Extension of Build Metadata (#13092 )	2 years ago
Lucas Bajolet	3e3b136f3c	packer: address unused lint errors	2 years ago
Lucas Bajolet	962ccdfc80	packer: address gosimple lint errors	2 years ago
Lucas Bajolet	e8d3a55b5f	packer: address errcheck lint errors In a couple places in the codebase we didn't check the errors from functions we execute. In some cases this is harmless (or at least ignorable), but others may need to log what went wrong, so for all the reported occurrences we either ignore explicitly or handle the error with a log.	2 years ago
Lucas Bajolet	805015c360	log: simplify the logOutput function The logOutput function had a bunch of nested checks in the code for the function, as well as one ineffasign pointed out by golangci-lint. This commit changes how special cases are processed, and changes a bit how log redirection to a file is handled. Prior to this commit, only when PACKER_LOG and PACKER_LOG_FILE are set does Packer redirect logs to the specified path, which is a bit superfluous as setting PACKER_LOG_FILE should be enough on its own to redirect logs and enable verbose logs. Now, when neither is set, no logOutput is set, if PACKER_LOG_FILE is set (regardless of PACKER_LOG), we redirect to the specified file, and finally if PACKER_LOG is set, we redirect to stderr.	2 years ago
Lucas Bajolet	2009079246	packer: remove ineffasign pointed assigns/decls Some of the variables we create are flagged by our linters as ineffective assignments, which makes sense as those are generally fed by code below, so we don't need to use the declaration/assignation syntax (:=) but instead can fall back to using var with a type to get the zero value of the declared entity.	2 years ago
Lucas Bajolet	02ac9628cc	golangci.yml: add rule to not run errcheck on test Test files have some calls that don't necessarily get checked since they have a very low probability to fail, and in a testing environment it's acceptable to not have bulletproof code. Therefore, we add a rule to not run that check on any file that ends with `_test.go` (Go test convention), so the linter isn't as noisy as it used to be.	2 years ago
Lucas Bajolet	4a7f5f38a6	Makefile: replace enumer upstream with dmarkham's (#13107 ) Since the enumer implementation we used hadn't been updated for 5+ years, this didn't work with recent linux/go versions, and enumer crashed while attempting to parse/analyse the source files. There's another alternative on Github, forked from the one we used, which seems more maintained now, and does produce the expected files in Packer.	2 years ago
Jamie Finnigan	ae367bc114	.go-version: bump version of Go to 1.21.12	2 years ago
Wilken Rivera	1e446de977	Update CHANGELOG post 1.11.1 release	2 years ago
dependabot[bot]	7425ef3a45	build(deps): bump github.com/hashicorp/go-retryablehttp Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.0 to 0.7.7. - [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/go-retryablehttp/compare/v0.7.0...v0.7.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
hashicorp-tsccr[bot]	863f3b0422	Result of tsccr-helper -log-level=info gha update .	2 years ago
Wilken Rivera	986b5c01ce	Add entry for go-retryablehttp bump	2 years ago

1 2 3 4 5 ...

18669 Commits (8f1da2fa79e0765e7d921253c8c86fb2abe454ae) All Branches Search

18669 Commits (8f1da2fa79e0765e7d921253c8c86fb2abe454ae)

All Branches