packer

Commit Graph

Author	SHA1	Message	Date
Lucas Bajolet	d40df8e899	packer: check if errs is nil before getting length When installing a remote plugin, and after we've either successfully installed a binary, or exhausted all the possible sources, we print a final error message if nothing was reported. However, given that errs is a pointer to a structure, and if no errors were produced, the the error list could be nil, leading to the call to `Len()' to crash Packer. This is exceedingly rare as in general the code attempts to read multiple sources from Github, and therefore we almost always get some error reported, but while changing the function's code, I managed to make it crash while removing/changing some error statements. Therefore to avoid future surprises, we first check that `errs' is not nil before invoking `Len()' on it, as no errors and no plugins installed mean that something went wrong all the same.	2 years ago
Lucas Bajolet	56fab30fa1	plugin: factorise calling describe on binaries Given that calling the describe command on plugins and deserialising the output as a plugin description is something done in multiple places in the code, we factorise this operation so we don't need to copy/paste the code around.	2 years ago
Lucas Bajolet	747cb00cdc	packer: remove temp zipfile after installation The zipfile containing the binaries we attempt to install from a remote source is placed in the temporary directory of the host. In general it is wiped automatically by the OS, but in some cases (windows typically), it isn't. To avoid cluttering the temporary directory, we clean-up after ourselves, and remove the temporary zip file that we create when attempting to install a plugin, regardless of it succeeding or not.	2 years ago
Wilken Rivera	61199aed0d	Update internal HashiCorp actions to address Node 20 deprecation	2 years ago
Wilken Rivera	5e043ab3a0	Bump required actions to address Node.js 16 deprecation issue (#12958 ) * Bump required actions to address Node.js 16 deprecation issue * Update all tsccr approved actions ```shell tsccr-helper gha update -latest . ```	2 years ago
Wilken Rivera	1a79aab50e	Bump actions/setup-go to address Node.js 16 deprecation issues (#12957 )	2 years ago
Wilken Rivera	5f47c99ec4	Bump actions/checkout to address Node.js 16 deprecation issues	2 years ago
Devashish	403e35d2ff	Add thread-safe add and get methods for plugin storage * Add general code improvements	2 years ago
dependabot[bot]	26b2bb8dbf	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.92.0 to 0.93.0 (#12942 ) Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.92.0 to 0.93.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.92.0...v0.93.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Lucas Bajolet	6fc1d154bd	packer: relax constraints on sources The source parsing logic was heavily directed towards Github compatible source URIs, however if we want to support more cases, we need to make sure we are able to specify those URIs, and to load plugins installed from those sources. Right now, since the getters available are only github.com, we will not support remotely instlling plugins from sources other than github.com, with the same set of constraints as before. However, we do support now installing from a local plugin binary to any kind of source, and we support loading them, including if a template wants this plugin installed locally with version constraints.	2 years ago
Lucas Bajolet	1bf3e86ee1	hcl2template: fix invalid_inexplicit_source_2 test The invalid_inexplicit_source_2 subtest for parse used to fail in previous versions of Packer, but with the latest changes to plugin source management, it won't, at least at parsing time, instead it fails later when the Github getter (the only available for now) cannot get the plugin binary from the source, as the source is not a valid Github URI.	2 years ago
Jiaqi Liu	00f39e72d3	Add missing option doc for 'packer fmt' (#12944 )	2 years ago
Lucas Bajolet	410e59f141	version: compute SemVer from rawVersion A bug in the SDK prevents us from calling SemVer on the PluginVersion derived from the rawVersion, as when doing so, we reset the semVer attribute to only use the core part of the version, thereby dropping any information on pre-release/metadata. This is not ideal, and arguably not wanted. So in order to not lose this information, we re-compute the SemVer from rawVersion, this way we don't overwrite it for both structures.	2 years ago
Wilken Rivera	f767d06f93	Dockerfile: Add Product directory to /usr/share/doc directory Closes: #12939	2 years ago
Wilken Rivera	094e00ebd2	Update CHANGELOG	2 years ago
Wilken Rivera	baa67010de	Add CHANGELOG entries for 1.10.3	2 years ago
dependabot[bot]	7526cd6e76	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.90.0 to 0.92.0 (#12935 ) Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.90.0 to 0.92.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.90.0...v0.92.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Lucas Bajolet	cdaad0cde2	version: up version handling code for SDK update Since the SDK was updated and now accepts raw version strings in addition to also supporting metadata officially, we can start using those functions in our version package as well.	2 years ago
Lucas Bajolet	33d9550903	packer: make Ui implementations match new SDK's The SDK's Ui interface has had some additions recently for supporting format-strings and their arguments as paramereters to Say, Ask and Error. These changes to the interface means that all the implementations of that interface need to match the definition, so in this case the implementations we had in packer/ui.go need to be updated to support those functions.	2 years ago
Wilken Rivera	0b00f52653	Copy license into zip with txt extension	2 years ago
Wilken Rivera	98fd73ad74	Add LICENSE to Linux packages	2 years ago
Wilken Rivera	c37a892665	Add LICENSE details to Docker release binaries	2 years ago
Wilken Rivera	72a2604b34	Add LICENSE to zipped Go binaries	2 years ago
Lucas Bajolet	f05124e2a4	version: set version to 1.11.0-dev Since we set the raw version string from version/VERSION now, we change its information to point to 1.11.0-dev until we're ready to release.	2 years ago
Lucas Bajolet	93bec31ec9	version: embed version/VERSION as version string Since we have both version/version.go and version/VERSION to specify version strings, both are a bit redundant. As version/VERSION is supposed to be the source of truth now, we are using it to derive the version informaiton we used to rely on in Packer and its subcommands. Note: doing this prevents us from changing the version/prerelease through ldflags though as we derive Version/VersionPrerelease from the rawVersion variable.	2 years ago
Lucas Bajolet	27538f377b	release/ci: remove trailing whitespace	2 years ago
Lucas Bajolet	55a11fe7f4	release/ci: disable automatic version bump	2 years ago
Lucas Bajolet	3f083fe8ea	github: only publish latest release images When building the container images for Packer (light and full), we should only publish them in the version being built is a release, and not a pre-release. Changing this means that both light and full latest will always be only a final release at any time.	2 years ago
Wilken Rivera	fed91012ab	Bump golang.org/x/net to v0.24.0 to address GO-2024-2687	2 years ago
Devashish	f19b9b7369	Remove GetMetadata from StartBuild and add to CompleteBuild for HCL (#12926 )	2 years ago
Devashish	70d2efec4d	Report metadata only when the build completes (#12923 )	2 years ago
Devashish	edc8a4dc0d	Use latest version of hcp-sdk-go Remove loggers and move AddMetadataToBuild method to Version	2 years ago
Devashish	8e92027546	HPR-1537: Packer Core sends metadata to HCP Packer in UpdateBuild API (#12891 )	2 years ago
Devashish	595b45e67c	Packer tracks Version and Plugins Metadata (#12860 )	2 years ago
dependabot[bot]	1c7930bec1	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.85.0 to 0.90.0 Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.85.0 to 0.90.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.85.0...v0.90.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
Lucas Bajolet	407693404b	CHANGELOG: add 1.11.0-alpha2 changes	2 years ago
Lucas Bajolet	132e3d29b8	packer: fix version string variable name typo When introduced back in January, the version variable extracted from the binary name had a typo in its name, and was named `protocolVerionStr' instead of `protocolVersionStr'. This commit was already merged into main, so it's too late to fix at introduction site, but we can fix it today as a separate commit ontop the stack.	2 years ago
Lucas Bajolet	0e6ee70f6f	plugins: reject non-canonical version numbers If a plugin is installed manually, its version number could be valid but non-canonical (ex: 1.2.3 vs 01.002.0003). Since these two versions refer to the same version, but the looks are different, this may become ambiguous which version should be loaded. To avoid such a situation, we reject explicitely non-canonical version numbers in plugins, but only in path, we're aware that because of metadata, the version from `describe' may already differ from the file name.	2 years ago
Lucas Bajolet	208afbebfa	packer: change mock set instantiation methods The former way mock plugin sets were created meant that no API version was set, and since it's private in the SDK, it cannot be set outside of the package itself. Fortunately, there is a NewSet function we can call, which initialises a set properly so we can fill-in the information later. However, because all the set maps were created in a `var` section, we cannot create the set with `NewSet`, and then fill the information in (outside of if there was a fluent interface, but this isn't the case here). We therefore opted to keep the variables defined and accessible globally, but gone through a `init` function to initialise their values for tests.	2 years ago
Lucas Bajolet	66912bf254	packer: use API version for ordering installations As with versions, API versions are useful possibly for ordering plugin installations in order for Packer to choose which plugin to load. This could be unnecessary as API versions are stable, and only in dev plugins this could be a problem normally (there shouldn't be two same releases of a plugin), but this cements API version in ordering plugins so we avoid surprises later down the line.	2 years ago
Lucas Bajolet	0502e09399	packer: check API version matches between name/bin As with the version of the plugin, the API version should also match between the path and the self-reported API version from the describe command. This was not checked before, so users could masquerade a plugin's use of an API version that may be incompatible with Packer. To avoid this problem, we make sure both versions are the same, so that they work as expected.	2 years ago
Lucas Bajolet	d7f299886d	command: scrub metadata from version at install When installing plugins with the `packer plugins install --path' command, the metadata is now scrubbed from the file installed locally. This is as a protection against collisions in the versions, as metadata is meaningless for version comparison, so if two versions of the same plugin are installed, the precedence order between them is undefined. Therefore to avoid such collisions, we remove the metadata from the file name, that way if two successive versions of a plugin include metadata in the version, they won't coexist, and the last installed will be the only installed version locally.	2 years ago
Lucas Bajolet	3f721ff03e	cmd/plugin_install: use semver to render version When installing a plugin from a local binary, Packer builds the name of the plugin from the results of the `describe' command. Depending on how the plugin is built, the version reported may or may not contain a leading `v', which was not taken into account beforehand and the leading `v' was always injected in the path. This caused plugins that report a leading `v' in their version to be installed with two v's in their path, making them impossible to load. Therefore to fix this issue, we count on the version library to print out a version without the leading v, and we inject that in the resulting path.	2 years ago
Lucas Bajolet	385ba4cfac	plugins: ensure valid checksum before exec When Packer discovers binary a bunch of checks are performed, which ultimately end with a checksum match check. This however should be the very first thing we do, even before attempting to run `describe' on the plugin binary we're discovering. So this commit moves this checksum match to the top of the discovery process for binaries.	2 years ago
Lucas Bajolet	0d66848578	plugins: rely more on version lib for checks When discovering the installed plugins locally, we perform a couple of checks on the version, namely that it is valid, if it is a prerelease, it needs to be a dev, and that the self-reported version matches the one hinted at through the name of the binary. This was done through regexes, but those were a wee bit simple when dealing with versions that have metadata. Those binaries would be completely ignored by Packer, and never loaded, although they are a valid use case. The version library we already used supports those however, and comparisons are more reliable with them. So, in order to simplify our code, and make it more reliable, we're exclusively using this library to perform parsing and comparisons of versions during the discovery phase.	2 years ago
Lucas Bajolet	28adb06984	CHANGELOG: call out lexicographic version ordering Since v1.11.0 should fix the version ordering to work with semver comparison instead of reliying on glob (lexicographic), we should call out the problem in the CHANGELOG.	2 years ago
Lucas Bajolet	a8f8902cd3	test: remove directory The test directory contains artifacts from the project's past which are never used nowadays. All those remains are therefore removed with this commit, and we can replace that directory's contents with more up-to-date contents.	2 years ago
Lucas Bajolet	930b6c3e2b	command: support local paths for plugins remove The packer plugins remove command allows users to delete plugins installed locally. Previous versions of the command only allowed for the plugins to be removed using the source for a plugin, and the versions to remove, optionally. This commit adds the capability for the plugins to be removed using their local path, in addition to the regular source+version method, that way we are able to pipe the results of `packer plugins installed' into the plugins remove command for quick plugin removal.	2 years ago
Wilken Rivera	e6c6520714	Update CHANGELOG.md	2 years ago
Wilken Rivera	7baca4d615	Update CHANGELOG	2 years ago

... 3 4 5 6 7 ...

18669 Commits (8f1da2fa79e0765e7d921253c8c86fb2abe454ae) All Branches Search

18669 Commits (8f1da2fa79e0765e7d921253c8c86fb2abe454ae)

All Branches