1861 Commits (dbdb5cb9d15e9e491073ce67e4e389d7e369c1d7)

Author	SHA1	Message	Date
John Ralls	37dfab7f31	[price-quotes] Convert long quote parsing lambda to a regular function. ... To begin separating price parsing from inserting in the price db.	4 years ago
John Ralls	dd8316714b	[price-quotes] Extract function GncQuotesImpl::comm_vec_to_json_string.	4 years ago
John Ralls	e3ab384504	[price-quotes] Log messages instead of writing them to std::streams.	4 years ago
John Ralls	b8642e55d9	[price-quotes] Implement mock quote source. ... Note that because the non-default constructor exists only on GncQuotesImpl we must use that directly and violate the pimpl.	4 years ago
John Ralls	4dd3922871	[price-quotes] Make wiggle test conditional on F::Q being installed.	4 years ago
John Ralls	784aca5a4c	[price-quotes] Extract class GncQuoteSource. ... Provide a specialization GncFQQuoteSource and move the F::Q command construction and query functions to GncFQQuoteSource. This allows for dependency injection to provide testing that doesn't need F::Q to be installed.	4 years ago
John Ralls	e9577b7996	[price-quotes] Basic wiggle test.	4 years ago
Geert Janssens	277f299ad6	GncQuotes - cleanups ... - make more use of auto - mark user visible strings as translatable - return early on input errors - fix date conversion fallback to actually fall back to today	4 years ago
Geert Janssens	585de5d134	GncQuotes - break actual interaction with Finance::Quote out into a separate function query_fq ... That allows for later reuse and easier testing.	4 years ago
Geert Janssens	70ab8a8a46	GncQuotes - drop parameterized constructor ... The book parameter is only needed while fetching quotes. In case the user passes one or more commodities to process the book can be readily derived from the commodity/commodities. In the other case (fetch all quotes) the user now is required to pass a book to the call.	4 years ago
Geert Janssens	4c2863966b	GncQuotes - rename fetch_all to be an overload of fetch ... And add a third overload to fetch only a single quote	4 years ago
Geert Janssens	7765e13704	Bindings - move log wrappers into the swig interface files ... They are only used for guile (and possibly python, so there's no need to carry them around in core-utils.	4 years ago
Geert Janssens	e5c6f6026b	Remove support code that was only used by price-quotes.scm	4 years ago
Geert Janssens	e97fc3e408	Drop price-quotes.scm, gnc-fq-helper.in and gnc-fq-check.in - no longer used	4 years ago
Geert Janssens	bf357315fd	finance-quote-wrapper - implement check and fetch in one file via command line switches ... This obsoletes gnc-fq-check as the same function can now be performed with 'finance-quote-wrapper -v'	4 years ago
Geert Janssens	fbf9aecd25	Use GncQuotes in transfer dialog	4 years ago
Geert Janssens	a00bce168c	GncQuotes - cache default currency	4 years ago
Geert Janssens	fcbe6cf10c	Add code to parse json data returned by our F::Q wrapper ... This code will convert the json data into GncPrice objects and add them to the pricedb, effectively doing what price-quotes.scm does. A few notable remarks: - still requires plenty of cleaning up. This is the first proof of concept - like the original scm based code, this parser completely ignores timezone information. As it wasn't used before and nobody complained, it may not be that important. Or it can be implemented later. - price-quotes.scm would first check if a price already existed in the pricedb and try to update that one instead of adding one (only if the old price's type is inferior). However that is redundant as gnc_pricedb_add_price does the same check. So I have omitted this extra check from GncQuotes. - currency quotes can be inverted. I have slightly changed the way to handle this. The perl wrapper code will simply set an "inverted" flag in that case, but will otherwise not swap currency and commodity as it used to be the case. On parsing, the inversion flag will cause the GncNumeric that's parsed from the price to be inverted. As it's still a GncNumeric that shouldn't result in any loss of precision, while keeping prices in the db always in the default currency.	4 years ago
Geert Janssens	6ecc1ef73f	GncQuotes - switch to Pimpl idiom ... That allows the private implementation to pass a number of variables based on various boost libraries. It's better to not have them in the public interface to keep compilation times down.	4 years ago
Geert Janssens	65ae46426b	GncQuotes - add parameterized construction ... For all but the basic check a book is required. Might as well be able to pass it directly and store a reference to it. That will simplify member function declarations.	4 years ago
Geert Janssens	3685e5de73	Factor out the async call to perl ... This will allow us to reuse it for several F::Q commands, like check, fetch,...	4 years ago
Geert Janssens	6ce91d7f49	Drop the single quotes instance code for now ... I have been reading on singleton implementations and there appears to be a lot of pushback against those. We can revisit this if it turns out performance degrades significantly by running the F::Q check multiple times.	4 years ago
Geert Janssens	616a672d52	Rewrite boost::process call to properly capture both stdout and stderr ... The previous version of the code could only capture one but not both at the same time.	4 years ago
Geert Janssens	a6771754d5	GncQuotes - start implementation of fetch/fetch_all	4 years ago
Geert Janssens	f3fdc5de12	Rewrite gnc-fq-helper as finance-quote-wrapper ... This rewritten version takes JSON input and spits out JSON. Additionally inverted currency quotes will only be flagged. The old code also swapped currencies in the result. GncQuotes will be written towards these new implementation choices.	4 years ago
Geert Janssens	1d94887a0b	Rewrite gnc_commodity_table_get_quotable_commodities as gnc_quotes_get_quotable_commodities ... It only makes sense in that context.	4 years ago
Geert Janssens	466db526b2	Move source files for GncQuotes to app-utils ... It will depend on functions in that library. This can probably be fixed by cleaning up app-utils, but that's not the topic of this feature.	4 years ago
Geert Janssens	9d62755b4a	Make GncQuotes::check() a private function, returning nothing ... At the same time do an explicit reinstantiation of quotes_cached at first use to work around what seems to be a race condition between static instantiation and binreloc.	4 years ago
Geert Janssens	32df095d4f	Catch potential boost::process exceptions ... Could happen if the perl executable isn't found and perhaps also if there's a stream exception.	4 years ago
Geert Janssens	d79306f7db	Protect boost process output read loop from deadlock ... As per the boost::process tutorials	4 years ago
Geert Janssens	8b772384cd	Various performance fixes based on feedback ... - const correctnes - avoid unnecessary copying - avoid need to reverse GList	4 years ago
Geert Janssens	2f7ed7f25d	Initial version of libgnc-quotes ... This library intends to wrap Finance::Quote the way price-quotes.scm currently does. In this first commit the library replaces price-quotes.scm's library to install quote sources. In addition it exposes a new command line parameter in gnucash-cli to show which version of Finance::Quote is installed on the system (if any) and which quotes sources that verions exposes.	4 years ago
John Ralls	eb24099a91	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	23ca899a77	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	b0ae402c23	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	3c75d212ab	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	283a5b7ce9	Fix dist, files moved	4 years ago
John Ralls	8cb8f5067d	Remove non-ISO4217 currency codes from gnc-euro table. ... They're not reachable because they don't have commodities associated with them.	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	3949821da6	Merge branch 'maint'	4 years ago
John Ralls	2505955ab9	Fix test failure from Bug 798616 fix.	4 years ago
John Ralls	7c350c3ae5	Bug 798616 - Can't register amount greater than 9,000,000,000 ... Because when loading the value the split in the xml backend doesn't yet have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION and if the numerator was larger than 10^10 that would overflow. To fix it this changes the "don't know" response to get_currency_denom and get_commodity_denom to GNC_DENOM_AUTO which will normally leave the denominator alone.	4 years ago
Christopher Lam	161b07b241	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	47fa8b281e	Merge PR #1425 into maint	4 years ago
John Ralls	a807d3e6b7	Create function gnc_tm_get_today_neutral. ... To complement gnc_tm_get_today_begin and gnc_tm_get_today_end.	4 years ago
luz paz	ba94730a23	Fix various typos ... Found via `codespell`	4 years ago
Christopher Lam	ecd2cdf425	[gnc-glib-utils] gnc_g_list_stringjoin skips NULL data	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. ... Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago
John Ralls	f24f29830b	[options] Change std::cerr stream output to PWARN. ... Remove temporary diagnostic.	4 years ago
Christopher Lam	3e02859277	Merge branch 'maint'	4 years ago
Christopher Lam	b7a3652de7	[date-utilities] avoid report crash if start>end date	4 years ago
John Ralls	087501d316	Bug 798262 - Scheduled transactions with blank amounts do not get created. ... Handle template transactions that don't have any splits with empty credit and debit strings and those having no set transaction account. Set the concrete transaction commodity to the first found of: The template transaction's commodity The commodity of the first split with a credit or debit string The commodity of the first split.	4 years ago
John Ralls	410db42df0	Test case where the template txn doesn't have a set currency.	4 years ago
John Ralls	229f6f5e85	Fix gdate adjustments.	4 years ago
Simon Arlott	4c1fc1d555	Bug 798262 - Add test case for basic scheduled transactions ... Test these scheduled transactions: * 2 splits with fixed amounts "123" * 2 splits with fixed amounts "0" * 2 splits with empty amounts "" Verify that automatically created scheduled transactions exist.	4 years ago
Christopher Lam	6ba912ee0d	Merge branch 'maint'	4 years ago
Christopher Lam	de7a63082b	[gnc-sx-instance-model] leaks: free temporal_state ... it's a simple struct containing GDate and int	4 years ago
Christopher Lam	ad27be333e	[gnc-sx-instance-model] prepend GList loops instead of append	4 years ago
John Ralls	8b07ac88cd	[options] Add "key" to the register-option documentation blocks.	4 years ago
John Ralls	e29ab5336f	[options] Remove key and doc_string from gnc_register_query_option. ... It's always used as an internal option with no UI component so it doesn't use them.	4 years ago
John Ralls	6faaf3b427	[options] Provide a const char* value flavor for register_commodity ... And register_currency_option	4 years ago
John Ralls	1ff844c195	[options] Fix implementation of gnc_register_owner_option ... To take an owner-type parameter and to set the UIType accordingly.	4 years ago
John Ralls	aa0b0921f4	[options] Add a function to check if an option is internal. ... Instead of relying on the legacy underscore-section-name hack.	4 years ago
John Ralls	da0eff2cac	[options] Implement widget-changed callbacks. ... Enables full functionality for complex-boolean and multichoice-callback options. Note that setter-function callback isn't used in any GnuCash code so it is not implemented and is not present in the register-callback functions.	4 years ago
John Ralls	552aa438ff	[options] Implement gnc_register_internal_option.	4 years ago
John Ralls	0e9ed8cf0a	[options] Provide float variants to gnc_register_plot_size_option.	4 years ago
John Ralls	0213787a2f	[options] Enable registering an absolute date option.	4 years ago
John Ralls	cf2870b71a	[options] Change RelativeDate and Multichoice index type to uint16_t. ... From size_t because clang thinks that std::is_same_v<size_t, time64> is true and we need to differentiate the handling of the two.	4 years ago
John Ralls	0b2d14ee72	Fix distribution for expressions target.	4 years ago
Christopher Lam	b94440b16a	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	ea56d67797	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	bfa0fd1819	Bug 798588 - sx scrubbing was using incorrect free function ... the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	f0ac8d69b2	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	0b5a4cd298	Merge branch 'maint'	4 years ago
Christopher Lam	d1aefc851d	[sx-book] free sx_list before g_object_unreffing sxes	4 years ago
John Ralls	688832b5f8	Bug 798585 - segfault running sample script ... The root cause of which is that on recent releases of GLib (recent meaning 2.66 in the current Debian stable!) g_type_instance_get_private looks in the wrong place for the private data. When running the script in question it returned NULL and since the code didn't check for a valid pointer, it crashed. So this change replaces all calls to g_type_instance_get_private with the function [type_prefix]_get_instance_private() added in glib-2.36 except for two register2 files that have been removed from master; those are ignored to avoid unnecessary merge conflicts.	4 years ago
Christopher Lam	67a1b7a873	[gnc-sx-instance-model] free GHashTable keys when destroying	4 years ago
Christopher Lam	ebf3439558	[gnc-sx-instance-model] free some GHashTable keys & Values	4 years ago
Christopher Lam	7c2a249511	[gnc-sx-instance-model.c] refactor Scrub function ... This scrubbing function calls xaccTransRollbackEdit which is leaky. Instead of trying to fix xaccTransRollbackEdit which requires superhuman skills, it's easiest to track the changes separately in a GList, and use xaccTransBeginEdit/xaccTransCommitEdit only if necessary.	4 years ago
Christopher Lam	7880f9b16f	[SchedXaction.c] free list of recurrences	4 years ago
Christopher Lam	c16840b840	more leaks because qof_instance_get returns a new char*	4 years ago
Christopher Lam	f1adb5da34	Merge branch 'TXN_TYPE-is-dynamic' xaccTransGetTxnType into maint #1201	4 years ago
Christopher Lam	ec3e996f92	tests xaccTransGetTxnType heuristics ... tests TXN_TYPE_NONE in utest-Transaction.c testing TXN_TYPE_INVOICE, TXN_TYPE_PAYMENT, and TXN_TYPE_LINK will require valid posted invoices, so, are best tested in utest-Invoice.c	4 years ago
Christopher Lam	fd12d3900c	[Transaction.c] use heuristics to determine txn->txn_type	4 years ago
John Ralls	f4c27d4494	Move gnc_ui_account_get_tax_info_string to gnc-locale-tax.c ... To prevent a circular dependency between libgnc-app-utils and libgnucash-guile.	4 years ago
Robert Fewell	ce4768c357	Bug 798565 - Import map editor entry deletion ... When a top level bayesian entry is deleted, the book is not marked dirty and so the save button is not highlighted. Deleting individual entries did mark book dirty. Fixed in gnc_account_delete_all_bayes_maps by wrapping the deletion with xaccAccountBeginEdit/CommitEdit block.	4 years ago
Robert Fewell	d688a17ef6	Merge 'luzpaz' branch 'source-typos' into maint PR #1364	4 years ago
John Ralls	3e2f7bc66a	Create separate shared library for expression parser and SX instance model. ... These functions depend on both libgnc-app-utils and libgnucash-guile, creating a circular dependency when the app-utils bindings are added to libgnucash-guile.	4 years ago
John Ralls	47904a858e	Fix distcheck in master. ... Several gnc-optiondb dependencies left out of tarball.	4 years ago
John Ralls	3fd8bd9ddf	Merge branch 'maint'	4 years ago
Christopher Lam	263f007d5c	[gnc-filepath-utils] new: gnc_list_all_paths	4 years ago
Christopher Lam	aa43c198c6	[Transaction.c] don't set TxnType kvp if it is the same as before ... will avoid dirtying the transaction.	4 years ago
John Ralls	9f6d495ca1	Fix use-after-free crash in utest-Invoice.	4 years ago
luz paz	cfc6e9d7e0	Fix source typo begining->beginning	4 years ago
John Ralls	1e6c679e71	Merge branch 'maint'	4 years ago
John Ralls	903cbdcad3	Bug 798547 - Calculated Due Date is short 1 day when posting on... ... day of fall change from Daylight Time to Standard Time. Really any day where the period crosses the dst->std change, and since the date dialog returns local midnight for the time that includes the day of the change. Convert both the parameter time and the return time to neutral time to ensure that the interval is handled correctly.	4 years ago
John Ralls	564d73a553	Bug 798531 - Selecting "Print" from the file menu on a report... ... crashes gnucash Ensure that every call to gnc_prefs_get_string correctly handles both a NULL or empty string return value without crashing or leaking.	4 years ago
Christopher Lam	670902d5a8	Bug 798535 - Crash when increasing the number of periods in a budget ... because in the SQL backend, gnc_budget_commit_edit will update the sql by reading from vectors with an increased priv->num_periods.	4 years ago
Robert Fewell	27cab58bf2	Correct some text describing some date functions.	4 years ago
Robert Fewell	c000a890ad	Bug 798501 - Balance wrong date end of account period ... With the accounting period preference settings set to 'Start/End of previous quarter' and balance sheet report using 'End of accounting period' the date is wrong, currently is 30/03/2022 when it should be 31/03/2022. Simplify gnc_gdate_set_quarter_end to get correct last day and subtract the 3 months befor calling said function.	4 years ago
Christopher Lam	a5cae6c5eb	Don't export undefined functions	4 years ago
Christopher Lam	fcc3b27f92	Merge branch 'maint'	4 years ago
Robert Fewell	ee7ed89b68	This partly fixes the currency and commodity combos ... With these changes the currency works but the commodity allows you to set the commodity but will crash if you save config or leave report open, this was tested on the 'Price scatter plot' report. Fixed with John's commit a8e6a59	4 years ago
Robert Fewell	db6a8f809b	Tax Tables combo does not set the active one ... Fixed by correcting spelling of tax table qof type, should 'gncTaxTable'. Also fixed setting tax table combo to 'none' when page reset button used.	4 years ago
Robert Fewell	0b67a91217	Fix the option GncOptionRangeValue ... The GncOptionRangeValue can be used with integers or doubles, the default being doubles. When used for setting the plot width/height, integers are used so all ValueTypes need to be integers other wise the when create_range_spinner is used you end up with the upper_bound value being G_MAXDOUBLE, a 309 character wide spin button. To differentiate the two, use 'set_alternate(true)' for integers.	4 years ago
Robert Fewell	506eb38493	Update Chart Width/Height Plot setting ... The new plot setting does both settings, values above 100 are treated as pixels and ones below are treated as a percentage. This means the maximum valid setting must be higher and also the tooltip needs to be changed.	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. ... Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. ... In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
Alex Aycinena	e381e70638	reverse commit d48937c. See discussion in Bug #79769.	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Alex Aycinena	d48937cf9c	Bug #79769 - Allow US Income Tax txf code 296 (Returns and allowances) to be shown and assignable for both income and expense type accounts.	4 years ago
Christopher Lam	394e0a4b71	[gnc-sx-instance-model.c] leak: don't strdup char* for xaccTransSetNotes ... For a while now, xaccTransSetNotes would strdup the notes. Don't need to strdup it beforehand.	4 years ago
Christopher Lam	e1d52963ed	[account.cpp] restore breadth-first search for 2 functions ... gnc_account_lookup_by_name and gnc_account_lookup_by_code were searching breadth-first and accidentally changed to depth-first in 4.7. as reported in https://github.com/Gnucash/gnucash/pull/1101#issuecomment-1098146573	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' ... # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
Christopher Lam	fae7ea02cd	[account.cpp] gnc_accounts_and_all_descendants converted from scm ... much more efficient than guile algorithm, avoids numerous repeated GList<->SCM conversions, and traversals of account descendants.	4 years ago
Frank H. Ellenberger	2298590316	Merge PR #1309 into maint	4 years ago
Christopher Lam	736d223198	Merge branch 'maint-progress3' into maint #1312	4 years ago
Christopher Lam	0c4d438a0e	[kvp-frame.cpp] expose iterator, skip inexistent frame	4 years ago
Christopher Lam	aab33954e7	[gnc-numeric.cpp] Reduce logging level of gnc_numeric exception message ... Exceptions are expected in some use cases.	4 years ago
luz paz	8adedc2248	Fix various typos ... Found via `codespell -q 3 -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./borrowed,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,ba,cas,dragable,gae,iff,iif,mut,nd,numer,parm,parms,startd,stoll`	4 years ago
Christopher Lam	6a668df168	[qofutil.h] don't recurse includes	4 years ago
Robert Fewell	ae220b86a4	[C++options] Fix Ubuntu test failure.	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	26b009c0f4	Bug 798500 - FTBFS (tests failure) on armhf ... Ensure the transition_times are correctly aligned for their sizes before attempting to copy them into the transitions vector.	4 years ago
Christopher Lam	ee8729dfb6	[account.cpp] char* must be freed	4 years ago
John Ralls	29bdd9b526	[C++options] Fix Ubuntu test failure.	4 years ago
John Ralls	1fddf70e21	[C++options] Fix previous month and previous quarter at the end of March ... . Because March has more days than February the previous month offset was getting normalized back to the current month--th 29 February this year is really 1 March, so normalizing before setting the day caused begin/end previous month to return the begin/end of the current month. That probably happened on the 31st of May, July, October, and December as well, I just hadn't managed to test on those days. Switching the normalization to after calculating the day of the month broke the previous quarter calculation because now the month was out of range, so normalize month & year first.	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	03cbbd1cd1	Merge branch 'maint'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
John Ralls	4fe83c3b32	[C++options] Remove GncOptionValue<SCM>. ... No longer needed.	4 years ago
John Ralls	278aa484d7	[C++options] Implement new GncOptionValue type GncOptionReportPlacement. ... For multicolumn reports so that we don't have to pass Scheme values.	4 years ago
Christopher Lam	4a75baa4c6	[gnc-xml-backend.cpp] gchar* must be freed after use. ... It is used as a constructor for std::string which makes a copy but doesn't take ownership.	4 years ago
Christopher Lam	cf1282501e	Use original guile variable names changed in #1073 ... The changes 09296dfb96, 1373233cd0 and 189db58e6 had caused inconsistencies. Best restore original guile variable names using underscore, bound to strings instead of functions returning strings.	4 years ago
Christopher Lam	5993ebf4d4	Merge branch 'maint'	4 years ago
Christopher Lam	5388cc8e2c	[kvp-frame.cpp] minor speedups ... reserve vector, cache iterator from m_valuemap.find for reuse immediately afterwards.	4 years ago
John Ralls	30e6c8ab11	[gnc-optiondb.i]Explicitly include array. ... Xcode-13.3 errors without it.	4 years ago
John Ralls	572cb6b1d1	Banish gnc_get_optiondb_from_dispatcher to gnc-report.cpp. ... Puts it closer to its points of use and removes it with its Scheme dependency from libgnucash.	4 years ago
John Ralls	e63baa6270	Merge Bob Fewell's 'rtl' into maint.	4 years ago
Robert Fewell	f8fc796c95	Bug797501 - Currency symbols in Hebrew (RTL) language ... When Gnucash is run in Hebrew which is a RTL language, on the accounts page the tree view is displaying the required number as the following... TreeView entry is '1,500.00 ₪' or '-1,500.00 ₪' TreeModel string is '₪ 1,500.00‬' or '₪ 1,500.00-‬' This seems to be down to the GTK 'Unicode Bidirectional Text Algorithm' which is changing the representation of the model string based on the first strongly typed character, in this case the Israeli shekel sign. To fix this, when creating the displayed monetary amount insert a BiDi ltr isolate uni-character at the start of the string.	4 years ago
John Ralls	d4c3c30b1a	Use GUIDs to represent QofInstances instead of pointers. ... Converting them to pointers for Scheme to use. Prevents dangling pointers when the user deletes a QofInstance as long as the Scheme report code re-fetches its pointers from the options when it's regenerated.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Christopher Lam	0052e3e483	[gnc-pricedb] add user:stock-transaction price source	4 years ago
John Ralls	c1001e6641	Better wording for tax table changed info message.	4 years ago
John Ralls	d841b322d0	Merge Frank Ellenberger's 'Bug684507' into maint.	4 years ago
John Ralls	ce2b89fd8c	[business]Add diagnostic messages to GncEntry and GncInvoice.	4 years ago
John Ralls	916caa25f2	Integrate Windows gzopen differences so that only one ifdef is needed. ... Clarifies code.	4 years ago
John Ralls	250b4ed733	Remove stray line left from earlier refactoring.	4 years ago