1861 Commits (dbdb5cb9d15e9e491073ce67e4e389d7e369c1d7)

Author	SHA1	Message	Date
Christopher Lam	3d8a28898d	[gnc-budget] gnc_budget_get_account_period_note returns a const ... to harmonize with all other char getters	3 years ago
Christopher Lam	2ee0c98200	[gnc-budget] use operator[] instead of find() and insert() ... - avoid hashing Account* twice. one call to operator[] is sufficient. - don't need use std::move with better constructors - sanity check - can't have a budget with num_periods = 0 - remove unused headers	3 years ago
Christopher Lam	3e5fcc8709	Merge branch 'maint'	3 years ago
Robert Fewell	4f8643674b	Remove all references to GncDisplayItem	4 years ago
Robert Fewell	078d7875d3	Change all references to plugin_class->actionsb ... Change all references to plugin_class->actionsb and n_actionsb to plugin_class->actions and n_actions	4 years ago
Christopher Lam	6f80c548e6	[gtest-qofevent.cpp] comprehensive tests for qofevent	4 years ago
Christopher Lam	05ffd3d4eb	[budget-feature] move unset_feature call to gnc_budget_gui_delete_budget ... because gnc_budget_gui_delete_budget is a more general function to delete a budget.	4 years ago
Christopher Lam	b87aa004f9	[test-qofbook] add tests for unknown features ... tests that gnc_features_test_unknown returns a suitable error message	4 years ago
Robert Fewell	0f70143c55	Initial change to plugin source files	4 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	4 years ago
Christopher Lam	fc94b41c81	Merge branch 'maint'	4 years ago
Christopher Lam	4716af24e4	Merge branch 'maint'	4 years ago
Christopher Lam	ba44f720c1	Merge branch 'maint'	4 years ago
Christopher Lam	f2354d6b2a	[test-qofbook.c] add test for gnc_features_set_unused	4 years ago
Christopher Lam	1516bb18b0	[gnc-features.cpp] backport gnc_features_set_unused from master	4 years ago
Christopher Lam	a078921a33	[qofbook.cpp] backport qof_book_unset_feature from master	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
Christopher Lam	093aa81ed1	[qofbook.cpp] deprecate qof_book_get_features	4 years ago
Christopher Lam	8192deff37	[gnc-features.cpp] convert to cpp ... - don't need to create/destroy GHashTable for each feature query - plugs leak: g_hash_table_unref (features_used) not always called properly - to check 1 feature, don't need to traverse whole GHashTable	4 years ago
Christopher Lam	6f6d2fef48	[test-qofbook] basic features test ... sets a feature and tests it's set. it's impossible to design a book with unknown features using the API.	4 years ago
John Ralls	14a0ea4ed3	[price-quotes] Sort and format source list.	4 years ago
John Ralls	1a906b00aa	[price-quotes] Enable gnucash-cli to retrieve preferences on macOS. ... By embedding a minimal Info.plist with a bundle ID into the executable. This necessitated a change to binreloc because the unix-style install depended on there being a bundle ID only when the program was run from an application bundle.	4 years ago
John Ralls	2767587874	[price-quotes] Fix setting alphavantage API key.	4 years ago
John Ralls	939a77407c	Merge branch 'price-quotes-cpp'	4 years ago
John Ralls	7f2a09a69f	[price-quotes] Handle short error strings from finance-quote-wrapper. ... This keeps the translation work in GnuCash and improves the error signalling in gnc-quotes.	4 years ago
John Ralls	fe9b23ff2b	[price quotes] Pass short errors to gnc-quotes. ... And wordier but not translated messages when STDERR is a tty.	4 years ago
John Ralls	88d658fef0	[price-quotes] Date::Manip is no longer required.	4 years ago
John Ralls	50c72b4f88	[price-quotes] Remove m_ready and usable() from GncQuoteSource. ... GncQuoteSource ctor throws if something is wrong so usable is always true.	4 years ago
John Ralls	7d93774dd2	[price-quotes] Throw instead of returning if there aren't any commodities to quote. ... So that the user gets sees an error instead of silent failure.	4 years ago
John Ralls	81d4ea9550	[price-quotes] Remove F::Q version format check. ... We don't care what the version string looks like as long as there is one.	4 years ago
John Ralls	c78fe37ff7	[price-quotes] General typo fixes and code cleanup.	4 years ago
John Ralls	70c9d4c9e3	[price-quotes] Fix version retrieval. ... Plus there's no need for a "not found" version string because GncQuotes construction will throw if Finance::Quote isn't correctly installed. No object, nothing to call version() on.	4 years ago
John Ralls	97e730b8d8	[price-quotes] Reformat test quote response strings to one line per quote.	4 years ago
John Ralls	f24c2c8bdd	Instrument failure to set the account when creating a split.	4 years ago
Mike Alexander	3c306eae65	Merge branch 'maint'	4 years ago
Mike Alexander	2d3e80ea08	Compatibility with XCode's "new build system" ... With XCode 14 or newer CMake tries to use the "new build system" which has a requirement that if two targets depend on the same generated file one of them must depend on the other. This commit adds reduntant dependencies to satisfy this requirement.	4 years ago
John Ralls	c7d1b6ab26	Bug 798633 - 4.12 build failure on 32-bit Linux: "No code for module"	4 years ago
John Ralls	673a925554	[price-quotes] Remove superseded gnc-fq-dump and Quotes-example.pl	4 years ago
John Ralls	e817091de1	[price-quotes] Warn only once if the AlphaVantage Key isn't set. ... And check the environment if it's not in preferences.	4 years ago
John Ralls	d97ea77762	[price quotes] Add report member function to display quote information to stdout. ... Instead of creating price instances in the database.	4 years ago
John Ralls	6ffb0bb633	[price-quotes] Report quote fetch failures to the user.	4 years ago
John Ralls	4c47e91180	[price-quotes] Implement error codes for currency and quote failures.	4 years ago
John Ralls	6db7800ca5	[price-quotes] Doxygen docs.	4 years ago
John Ralls	29ce925646	[price-quotes] Test the other fetch overloads and quote values.	4 years ago
John Ralls	b5bc6463a3	[price-quotes] Rework date-time handling. ... A check of the F::Q modules found that the only ones that return a quote time return a bogus one and do so only to mollify GnuCash. Since there's no good way to determine the TZ of the exchange originating the quote there's no good way to decide if the quote is current or from a previous market session, so we just punt and use a time of 16:00 for all quotes.	4 years ago
John Ralls	19064093d2	[price-quotes] Remove m_comm_vec and m_fq_answer. ... Passing the intermediate values comm_vec and quote_str on the stack instead.	4 years ago
John Ralls	734fb6ce2a	[price-quotes] Switch error handling to exceptions. ... Allows for cleaner code with less state, less coupling of the GncQuotes class, and better transfer of error messages to client code. Also translates some error messages for presentation to users.	4 years ago
John Ralls	d307295076	[price-quotes] Paramaterize GncMockQuoteSource construction. ... So we can have different results passed back for different tests.	4 years ago
John Ralls	2b87066687	[price-quotes] Extract some static functions. ... To get GncQuoteImpl::parse_one_quote to a reasonable size.	4 years ago
John Ralls	a82c72cfb9	[price-quotes] Remove level of indirection when parsing quote data.	4 years ago
John Ralls	37dfab7f31	[price-quotes] Convert long quote parsing lambda to a regular function. ... To begin separating price parsing from inserting in the price db.	4 years ago
John Ralls	dd8316714b	[price-quotes] Extract function GncQuotesImpl::comm_vec_to_json_string.	4 years ago
John Ralls	e3ab384504	[price-quotes] Log messages instead of writing them to std::streams.	4 years ago
John Ralls	b8642e55d9	[price-quotes] Implement mock quote source. ... Note that because the non-default constructor exists only on GncQuotesImpl we must use that directly and violate the pimpl.	4 years ago
John Ralls	4dd3922871	[price-quotes] Make wiggle test conditional on F::Q being installed.	4 years ago
John Ralls	784aca5a4c	[price-quotes] Extract class GncQuoteSource. ... Provide a specialization GncFQQuoteSource and move the F::Q command construction and query functions to GncFQQuoteSource. This allows for dependency injection to provide testing that doesn't need F::Q to be installed.	4 years ago
John Ralls	e9577b7996	[price-quotes] Basic wiggle test.	4 years ago
Geert Janssens	277f299ad6	GncQuotes - cleanups ... - make more use of auto - mark user visible strings as translatable - return early on input errors - fix date conversion fallback to actually fall back to today	4 years ago
Geert Janssens	585de5d134	GncQuotes - break actual interaction with Finance::Quote out into a separate function query_fq ... That allows for later reuse and easier testing.	4 years ago
Geert Janssens	70ab8a8a46	GncQuotes - drop parameterized constructor ... The book parameter is only needed while fetching quotes. In case the user passes one or more commodities to process the book can be readily derived from the commodity/commodities. In the other case (fetch all quotes) the user now is required to pass a book to the call.	4 years ago
Geert Janssens	4c2863966b	GncQuotes - rename fetch_all to be an overload of fetch ... And add a third overload to fetch only a single quote	4 years ago
Geert Janssens	7765e13704	Bindings - move log wrappers into the swig interface files ... They are only used for guile (and possibly python, so there's no need to carry them around in core-utils.	4 years ago
Geert Janssens	e5c6f6026b	Remove support code that was only used by price-quotes.scm	4 years ago
Geert Janssens	e97fc3e408	Drop price-quotes.scm, gnc-fq-helper.in and gnc-fq-check.in - no longer used	4 years ago
Geert Janssens	bf357315fd	finance-quote-wrapper - implement check and fetch in one file via command line switches ... This obsoletes gnc-fq-check as the same function can now be performed with 'finance-quote-wrapper -v'	4 years ago
Geert Janssens	fbf9aecd25	Use GncQuotes in transfer dialog	4 years ago
Geert Janssens	a00bce168c	GncQuotes - cache default currency	4 years ago
Geert Janssens	fcbe6cf10c	Add code to parse json data returned by our F::Q wrapper ... This code will convert the json data into GncPrice objects and add them to the pricedb, effectively doing what price-quotes.scm does. A few notable remarks: - still requires plenty of cleaning up. This is the first proof of concept - like the original scm based code, this parser completely ignores timezone information. As it wasn't used before and nobody complained, it may not be that important. Or it can be implemented later. - price-quotes.scm would first check if a price already existed in the pricedb and try to update that one instead of adding one (only if the old price's type is inferior). However that is redundant as gnc_pricedb_add_price does the same check. So I have omitted this extra check from GncQuotes. - currency quotes can be inverted. I have slightly changed the way to handle this. The perl wrapper code will simply set an "inverted" flag in that case, but will otherwise not swap currency and commodity as it used to be the case. On parsing, the inversion flag will cause the GncNumeric that's parsed from the price to be inverted. As it's still a GncNumeric that shouldn't result in any loss of precision, while keeping prices in the db always in the default currency.	4 years ago
Geert Janssens	6ecc1ef73f	GncQuotes - switch to Pimpl idiom ... That allows the private implementation to pass a number of variables based on various boost libraries. It's better to not have them in the public interface to keep compilation times down.	4 years ago
Geert Janssens	65ae46426b	GncQuotes - add parameterized construction ... For all but the basic check a book is required. Might as well be able to pass it directly and store a reference to it. That will simplify member function declarations.	4 years ago
Geert Janssens	3685e5de73	Factor out the async call to perl ... This will allow us to reuse it for several F::Q commands, like check, fetch,...	4 years ago
Geert Janssens	6ce91d7f49	Drop the single quotes instance code for now ... I have been reading on singleton implementations and there appears to be a lot of pushback against those. We can revisit this if it turns out performance degrades significantly by running the F::Q check multiple times.	4 years ago
Geert Janssens	616a672d52	Rewrite boost::process call to properly capture both stdout and stderr ... The previous version of the code could only capture one but not both at the same time.	4 years ago
Geert Janssens	a6771754d5	GncQuotes - start implementation of fetch/fetch_all	4 years ago
Geert Janssens	f3fdc5de12	Rewrite gnc-fq-helper as finance-quote-wrapper ... This rewritten version takes JSON input and spits out JSON. Additionally inverted currency quotes will only be flagged. The old code also swapped currencies in the result. GncQuotes will be written towards these new implementation choices.	4 years ago
Geert Janssens	1d94887a0b	Rewrite gnc_commodity_table_get_quotable_commodities as gnc_quotes_get_quotable_commodities ... It only makes sense in that context.	4 years ago
Geert Janssens	466db526b2	Move source files for GncQuotes to app-utils ... It will depend on functions in that library. This can probably be fixed by cleaning up app-utils, but that's not the topic of this feature.	4 years ago
Geert Janssens	9d62755b4a	Make GncQuotes::check() a private function, returning nothing ... At the same time do an explicit reinstantiation of quotes_cached at first use to work around what seems to be a race condition between static instantiation and binreloc.	4 years ago
Geert Janssens	32df095d4f	Catch potential boost::process exceptions ... Could happen if the perl executable isn't found and perhaps also if there's a stream exception.	4 years ago
Geert Janssens	d79306f7db	Protect boost process output read loop from deadlock ... As per the boost::process tutorials	4 years ago
Geert Janssens	8b772384cd	Various performance fixes based on feedback ... - const correctnes - avoid unnecessary copying - avoid need to reverse GList	4 years ago
Geert Janssens	2f7ed7f25d	Initial version of libgnc-quotes ... This library intends to wrap Finance::Quote the way price-quotes.scm currently does. In this first commit the library replaces price-quotes.scm's library to install quote sources. In addition it exposes a new command line parameter in gnucash-cli to show which version of Finance::Quote is installed on the system (if any) and which quotes sources that verions exposes.	4 years ago
John Ralls	eb24099a91	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	23ca899a77	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	b0ae402c23	Limit instantiation of GncInt128 constructors to integral values. ... Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	3c75d212ab	Fix build on Apple Silicon or maybe Apple-clang-14.0 ... The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB*, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB* and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	283a5b7ce9	Fix dist, files moved	4 years ago
John Ralls	8cb8f5067d	Remove non-ISO4217 currency codes from gnc-euro table. ... They're not reachable because they don't have commodities associated with them.	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	3949821da6	Merge branch 'maint'	4 years ago
John Ralls	2505955ab9	Fix test failure from Bug 798616 fix.	4 years ago
John Ralls	7c350c3ae5	Bug 798616 - Can't register amount greater than 9,000,000,000 ... Because when loading the value the split in the xml backend doesn't yet have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION and if the numerator was larger than 10^10 that would overflow. To fix it this changes the "don't know" response to get_currency_denom and get_commodity_denom to GNC_DENOM_AUTO which will normally leave the denominator alone.	4 years ago
Christopher Lam	161b07b241	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	47fa8b281e	Merge PR #1425 into maint	4 years ago
John Ralls	a807d3e6b7	Create function gnc_tm_get_today_neutral. ... To complement gnc_tm_get_today_begin and gnc_tm_get_today_end.	4 years ago
luz paz	ba94730a23	Fix various typos ... Found via `codespell`	4 years ago
Christopher Lam	ecd2cdf425	[gnc-glib-utils] gnc_g_list_stringjoin skips NULL data	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. ... Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago