832 Commits (1890c6ccfb1fbfa6063bf34c8a2e406b6e41c9d5)

Author	SHA1	Message	Date
Christopher Lam	e4d808e674	[qofbook] qof_book_use_split_action_for_num_field: free a char* ... qof_instance_get allocates a new char* which must be freed.	5 years ago
Christopher Lam	eafc290034	Merge branch 'maint'	5 years ago
Christopher Lam	40d886fa9d	gnc_account_list_name_violations elements must be freed	5 years ago
Christopher Lam	4c37f6d4ef	[account.cpp] gnc_g_list_stringjoin instead of repeated allocations	5 years ago
Christopher Lam	bedc85afa3	Merge branch 'maint-leaks' into maint #1101	5 years ago
Christopher Lam	0420ae6a66	[account.cpp] refactor gnc_account_list_name_violations	5 years ago
Christopher Lam	67bd513514	[account.cpp] rewrite gnc_account_foreach_descendant_until in C++	5 years ago
Christopher Lam	17953441cb	[account.cpp] refactor gnc_account_foreach_descendant	5 years ago
Christopher Lam	5698b67bf5	[account.cpp] refactor gnc_account_lookup_by_code	5 years ago
Christopher Lam	09e2e7613c	[account.cpp] refactor gnc_account_lookup_by_name	5 years ago
Christopher Lam	bebc366e88	[account.cpp] refactor gnc_account_n_descendants	5 years ago
John Ralls	f0926d66c1	Merge Simon Arlott's 'qof-instance-dispose' into maint.	5 years ago
Christopher Lam	e6c33a39bc	[account.cpp] refactor gnc_account_get_descendants{_sorted}	5 years ago
Christopher Lam	d2db43019c	[account.cpp] internal function account_foreach_descendant ... fast and efficient	5 years ago
Christopher Lam	de1ad9367a	g_free gnc_ctime which returns a new gchar*	5 years ago
Simon Arlott	7a0ea190ca	qof_instance_dispose should always complete dispose processes ... If QofInstancePrivate has no collection then qof_instance_dispose() returns without completing the rest of its dispose processes, skipping removal of its type string from the string cache resulting in a reference count leak. Change the check for a collection so that it only affects the call to qof_collection_remove_entity().	5 years ago
John Ralls	9062be3d47	Merge Simon Arlott's 'string-cache-fixes' into maint.	5 years ago
John Ralls	76b0001cbe	Remove option-util.	5 years ago
John Ralls	e2c87f23c3	Convert optiondb users in gnome and gnome-utils to C++. ... To enable using std::unique_ptr<GncObjectDB> and avoid memory management problems.	5 years ago
John Ralls	7dab089d49	Fix miscalculation of prev_quarter_end for the first quarter. ... If the current quarter ends June 30 backing up 3 months from there gets March 30, one day off. Back up first and calculate the end of the actual quarter of interest. Changed pre_quarter_start for consistency, it doesn't matter.	5 years ago
John Ralls	28438e3126	Rewire gnome and gnome-utils to use GncOptionDB.	5 years ago
John Ralls	67508ea039	Reimplement dialog-options for C++.	5 years ago
John Ralls	08bf3ec5b0	Merge branch 'maint'	5 years ago
Simon Arlott	4a5b5f3bf2	Don't cache the empty string ... Avoid unnecessary reference counting for uses of the empty string.	5 years ago
Simon Arlott	320df7e409	Use const return values for string cache ... This is a prerequisite for being able to return "" (which is const) and none of the returned values should ever be modified.	5 years ago
Simon Arlott	4132939612	Avoid leaking string cache entries for "" in Transaction and Split ... When g_object_new() is used, the strings that default to "" are added to the string cache. These are then not correctly removed when updating them with new values when cloning a Transaction/Split. Use CACHE_REPLACE instead of CACHE_INSERT.	5 years ago
John Ralls	81c5ac6689	Remove the incomplete book-currency code. ... Not everything from the 6 Book-Currency commits is removed: Switching the Num and split-action fields and restricting edits of transactions older than n days were included and those changes are left in place. Some other partly-implemented features were also part of these commits and were removed: Options for setting a default capital gains account and currency, completion of the LIFO cap-gains policy, and creation of a list of cap-gains policies. If any of these are to be revived they should each be done in a separate feature branch and submitted via Github pull request for a code review before merging; a design discussion on gnucash-devel before restarting work is also advisable.	5 years ago
John Ralls	d2535fe21b	KvpValue: Use boost::typeindex::type_id instead of buildtin typeid. ... Under some build conditions boost::typeindex will use an internal type identifier that's different from the C++ builtin. In that case type equality tests to C++ typeid in boost::variant will fail, breaking it. Using boost::typeindex::type_id ensures that the comparisons always work.	5 years ago
Robert Fewell	0f026f6a10	Bug 798221 - Transfer funds between accounts with different currencies crashes Gnucash on macOS ... In the scrub function find_account_matching_name_in_list there was a test for account names being the same for currency but condition was backwards so was matching on account names being different. There was also a g_list_free resulting in a double free which was removed.	5 years ago
Simon Arlott	08b56e9669	[gnc-pricedb] Don't lookup old prices when doing bulk updates	5 years ago
Christopher Lam	1b4d30b3b1	Merge branch 'maint'	5 years ago
Hong Xu	0fd0aca531	Explain out what AsOfDate means in the doc ... As discussed at https://lists.gnucash.org/pipermail/gnucash-user/2021-June/096893.html	5 years ago
John Ralls	601eb51361	Improve transaction sorting on effective num field. ... Inspired by PR #983. Transaction sorting on num broke down if the user had a non-numeric string or a number larger than an int in the effective num field (might be split-action if the option is set). The comparison first tries to use strtoull on the two strings and compares the results. If they're both nonzero and different then the numeric order is returned. If they're both nonzero but the same the unconverted parts of each are passed to g_utf8_collate; if either is 0 then the whole strings are passed to g_utf8_collate. strtoull will return 0 for a negative number.	5 years ago
John Ralls	985a6420fc	Bug 798196 - not building with Boost 1.76	5 years ago
John Ralls	6aa35ea7fb	Better fix for bug 798204, doesn't break trading account selection.	5 years ago
John Ralls	9eeff5dd7e	Bug 798204 - Creation of Imbalance Accounts ... Search recursively when getting account by name.	5 years ago
John Ralls	68ec80e68d	Bug 798203 - g_assert fault while reversing transaction ... * Re-commit the original transaction to ensure that there aren't any stray trading splits. * If the original and cloned transactions have a different number of splits don't leak the cloned transaction. * Check that the cloned transaction isn't NULL before trying to invert it.	5 years ago
John Ralls	80d6749989	Bug 787813 - Price change from editing a transaction not reflected... ... in pricedb. Allow PRICE_SOURCE_SPLIT_REG to overwrite PRICE_SOURCE_XFER_DLG_VAL.	5 years ago
Christopher Lam	321b5efabc	Merge branch 'maint-leaks' into maint #1019	5 years ago
John Ralls	42213c597c	Bug 798199 - Pasting invalid value in date column crashes GnuCash ... Catch boost::gregorian::bad_year in LDT_from_struct_tm and rethrow std::invalid_argument for C wrappers to catch and handle.	5 years ago
Christopher Lam	b095d1e7da	Revert "[qofquery] q->terms g_list members must be freed" ... This reverts commit a3e3823ee7. Already freed earlier in the same function.	5 years ago
Christopher Lam	c8a7b9edb3	[Account] g_value_unset	5 years ago
Christopher Lam	bfdec74a48	[qof-backend] gchar * gnc_path_get_pkglibdir must be g_freed	5 years ago
Christopher Lam	f6a9be45ba	[Split] g_value_unset	5 years ago
Christopher Lam	36901c5751	[gncJob] g_value_unset	5 years ago
Christopher Lam	1824a30bd0	[gncinvoice] g_value_unset	5 years ago
Christopher Lam	badd976e11	[gnc-lot] g_value_unset	5 years ago
Christopher Lam	c9565abe8b	[gnc-commodity] g_value_unset	5 years ago
Christopher Lam	302020fcb7	[gnc-budget] g_value_unset	5 years ago
Christopher Lam	ceeb1dff7a	[scrub.c] g_value_unset	5 years ago
Christopher Lam	92cd437562	[Transaction.c] g_value_unset to release GValue string	5 years ago
Christopher Lam	3353d3950b	[gnc-budget] g_value_unset GValue	5 years ago
Christopher Lam	a3e3823ee7	[qofquery] q->terms g_list members must be freed	5 years ago
Christopher Lam	8a6413342d	[SchedXaction] free GList*	5 years ago
Christopher Lam	c5585ebe2c	[gncInvoice] free GList*	5 years ago
Christopher Lam	d611538ae7	[gncTaxtable] free GSList*	5 years ago
Christopher Lam	b3101c9385	[gnc-pricedb.c] plug GList leak	5 years ago
Christopher Lam	8a56a00313	Modify documentation for gncEntryComputeValue ... Modify documentation for be19b489e	5 years ago
Christopher Lam	b25a444140	Merge branch 'maint'	5 years ago
John Ralls	da3c511b6c	Remove trading splits instead of trying to adjust them.	5 years ago
John Ralls	4f030aac6e	Bug 798093 - Changing the symbol/abbreviation of a security... ... after the trading account was created breaks GnuCash. Revisited. The original changeset looked for a top level trading account and a namespace account in the transaction currency; if either of those accounts had been created in a different currency it would duplicate them. This commit will accept any such account regardless of commodity. If more than one exists it will prefer the one in the root currency if there is one, otherwise it will select the first one found.	5 years ago
John Ralls	18c72baddf	Don't bother scrubbing for orphans if there's no transaction currency. ... If it found one it would try to create an orphan account with no currency which will crash later.	5 years ago
John Ralls	2b48fd375d	Revert "Fix duplicate trading accounts." ... This reverts commit ed486a58a4.	5 years ago
Hong Xu	888676eb31	from_price and to_price may be uninitialized in extract_comon_prices ... Fix the compilation error on gcc 10: gnucash/libgnucash/engine/gnc-pricedb.c: In function ‘extract_common_prices’: gnucash/libgnucash/engine/gnc-pricedb.c:2469:40: error: to_price may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 | if (from_price == NULL || to_price == NULL) | ^ gnucash/libgnucash/engine/gnc-pricedb.c:2469:20: error: ‘from_price’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 | if (from_price == NULL || to_price == NULL) | ^	5 years ago
Christopher Lam	ae7eb9b3ad	[gnc-pricedb] extract common code into get_nearest_price ... Extracts common code in: * gnc_pricedb_get_nearest_before_price * gnc_pricedb_get_nearest_price * gnc_pricedb_get_latest_price	5 years ago
Christopher Lam	a2f5223148	[gnc-pricedb] use g_list_find and plug memory leak ... found_coms was not being freed.	5 years ago
John Ralls	ed486a58a4	Fix duplicate trading accounts. ... In many cases GnuCash would create a new trading account hierarchy when one already existed because gnc_account_lookup_by_type_and_commodity didn't check the account presented and didn't recurse down the account hierarchy correctly.	5 years ago
John Ralls	2258e7a44e	xaccAccountTypes was backwards ... vs. the documentation. The unit tests and dialog-account were similarly backwards, but the use in gnucash/import-export/ofx followed the docs.	5 years ago
Christopher Lam	5ce8f78f77	Merge branch 'maint'	5 years ago
Robert Fewell	e535ba5411	Change some functions to use const gnc_commodity for gnc_pricedb	5 years ago
Robert Fewell	e75308e684	Rename a couple of gnc-pricedb functions that have not been used. ... To be more consistent change gnc_pricedb_lookup_latest_before_t64 and gnc_pricedb_lookup_latest_before_any_currency_t64 to be of the form '_nearest_before_' and add a missing utest.	5 years ago
Robert Fewell	d3bd7fda61	Add unit tests for new gnc-pricedb functions	5 years ago
Robert Fewell	4a491f7cde	Change a couple of docbook definitions in gnc-pricdb.h	5 years ago
Robert Fewell	05507008c5	Add retrieval functions for price before the date given ... Add a new function, gnc_pricedb_convert_balance_nearest_before_price_t64 that retrieves the balance using the last price dated before a specified date like today for the preset value. This uses another new function gnc_pricedb_get_nearest_before_price to do the retrieval.	5 years ago
Robert Fewell	b54c30e03d	Bug 798148 - Chart of Accounts page Present(xxx) value wrong ... If for some reason you have price information in the future for a security, the present value is based on the price retrieved for the greatest date and not a price which is before the current date. To fix this use the 'xaccAccountGetBalanceAsOfDateInCurrencyRecursive' function.	5 years ago
John Ralls	bbb4113a5a	Bug 798156 - glib 2.68.0 breaks gnucash ... Move all of the #include <glib> to before the extern "C" blocks so that the include guards will protect against headers inside the extern "C" block also including glib.h.	5 years ago
John Ralls	4eaa10c6be	Another extern-C glib.h, for Windows this time.	5 years ago
Christopher Lam	d28ff20ff7	Merge branch 'maint'	5 years ago
John Ralls	27435b1038	Don't filter use of TTInfo file section based on sizeof time_t. ... The whole point of GncDateTime is to work around 32-bit time_t.	5 years ago
John Ralls	b40589244c	Fix test-gnc-datetime failure on Ubunutu.	5 years ago
John Ralls	c49b45d8f1	Finish the glib 2.67 fixes for CI tests.	5 years ago
John Ralls	1221d7ebc1	Bug 798150 - Error on report over time ... Extract functions LDT_from_date_time and LDT_from_date_daypart to avoid duplicate code. Handle date-times in start-of-DST transitions and better handle those in end-of-DST transitions. Test the results.	5 years ago
John Ralls	ebb5eb1f17	Fix GncDateTime::format_zulu to emit the UTC timezone. ... Instead of the GncDateTime's timezone with the UTC timestamp.	5 years ago
John Ralls	3a35514d84	Fix the implementations of gnc_foo_get_day_neutral. ... As implemented these returned 10:59 AM local on the day but neutral time is 10:59 UTC.	5 years ago
Christopher Lam	2a2f080813	Merge branch 'maint'	5 years ago
Frank H. Ellenberger	4a983761d7	Fix a typo in a comment of the last commit	5 years ago
John Ralls	a11065b823	Fix fencepost error in calculating the week_num for POSIX timezone rules. ... Fixes CI failure caused by US starting DST in 2021, a year in which March began on a Monday.	5 years ago
John Ralls	8e41857014	Catch more exceptions in gnc_numeric_convert ... To enable fixing https://bugs.gnucash.org/show_bug.cgi?id=798132.	5 years ago
Christopher Lam	87473ed5f9	Merge branch 'maint'	5 years ago
Dong Lin	75209c024f	Update price database for imported transactions ... When a transaction is added from the ledger, price database is updated properly. But if the transaction is imported, there is no price db update. This change adds the proper pricedb update in the import path (qfx/ofx/qif). Tested with make check	5 years ago
Sumit Bhardwaj	df579c257b	Replace g_memdup by memcpy ... GLib is deprecating g_memdup. Since older versions of GLib wouldn't have g_memdup2, this PR replaces occurrences of g_memdup by memcpy.	5 years ago
Frank H. Ellenberger	93e2829ee5	Merge PR #899 into maint	5 years ago
luz paz	16b4976381	Fix typos in libgnucash/ ... Found via `codespell -q 3 -L ans,ba,parm,parms,numer`	5 years ago
Christopher Lam	e79db92d8d	[Split.c] xaccSplitListGetUniqueTransactionsReversed ... Same as xaccSplitListGetUniqueTransactions but doesn't reverse the list prior to returning. To be used by gnc-tree-model-split-reg.c Several optimizations * doesn't call g_list_find and g_list_append for every iteration * uses g_hash_table to cache list of txns already added instead of g_list_find * does not reverse the result, thereby returning a reversed list.	5 years ago
Christopher Lam	b2b8792110	prepend-and-reverse instead of O(N^2) append	5 years ago
Frank H. Ellenberger	6bc8679932	I18N: replace several spourious spaces	5 years ago
John Ralls	7a7c26f87e	Move glib and gtk includes out of extern C for tests. ... Needed to compile with glib 2.67 and later.	5 years ago
Bill Nottingham	c0f2c3ae25	Fix build with glib2 2.67.x. ... glib headers should not be included with 'extern "C"'.	5 years ago
Christopher Lam	092040c7fe	Merge branch 'maint'	5 years ago
John Ralls	4359243c08	Move glib and gtk includes out of extern C for tests. ... Needed to compile with glib 2.67 and later.	5 years ago
Bill Nottingham	f60b6354f8	Fix build with glib2 2.67.x. ... glib headers should not be included with 'extern "C"'.	5 years ago
Christopher Lam	c20a588e0f	Don't use g_list_append unnecessarily	5 years ago
Christopher Lam	d16f39046d	Merge branch 'maint'	5 years ago
John Ralls	0f8d9f6d7c	Bug 798093 - Changing the symbol/abbreviation of a security after... ... the trading account was created breaks GnuCash. Introduces a new function, gnc_account_lookup_by_type_and_commodity that does that, though it also looks at name for the one special case of finding/creating the Namespace placeholder account. Adds a parameter checkname to xaccScrubUtilityGetOrMakeAccount to flag whether to look for the name. Namespaces aside this makes it possible for the user to rename trading accounts or securities independent of each other.	5 years ago
John Ralls	bcbebe62b1	Make xaccScrubUtilityGetOrMakeAccount static and remove ScrubP.h ... It being the only declaration in ScrubP.h	5 years ago
Christopher Lam	ddc86579c0	Merge branch 'master-remove-deprecated' #855	5 years ago
Frank H. Ellenberger	84cc64daed	I18N: Remove annoying stars from translator comments	5 years ago
John Ralls	ffa2f606e3	Fix use-after-free in test_xaccTransEqual.	5 years ago
Christopher Lam	c5e7406c9f	[account.cpp] remove deprecated function	5 years ago
Allan Nordhøy	383b0b2f19	Replace 'Non Bayesian' with grammatically more correct 'non-Bayesian'.	5 years ago
Allan Nordhøy	8d4d1f1523	Replace 'Non Bayesian' with grammatically more correct 'non-Bayesian'.	5 years ago
Christopher Lam	f1c1fca023	[account.cpp][API] deprecate xaccAccountCountSplits	5 years ago
John Ralls	ae66da9632	Fix test-gnc-timezone failure caused by latest zoneinfo release. ... See the comment for details.	5 years ago
John Ralls	2ff3bf5877	Echo into CMakeLists.txt rename of gmock-qofqury to fake-qofquery.	5 years ago
Christopher Lam	d11bdb3e3a	Bug 798015 - cash flow numerical-overflow ... error is caused by pricedb containing an invalid gnc_numeric price. multiplication of (invalid) price with amount causes a report crash. Fix: if invalid price, return zero for amount converted to report currency.	6 years ago
Ralf Habacker	63580d91ba	Add feature GNC_FEATURE_EQUITY_TYPE_OPENING_BALANCE ... When the above function is activated, the slot 'equity type' is used and set in relation to opening balances and the checkbox for marking the opening balance in the accounts dialog can be changed.	6 years ago
Ralf Habacker	f8dcd23023	Add support for the opening balance accounts flag ... Up to now, opening balance accounts have been identified by means of fixed names and their translations, which in some cases is not appropriate. With this commit, therefore, opening balance accounts can now be identified by a special slot, which should solve the above problem. in gnc_find_or_create_equity_account(), when querying the EQUITY_OPENING_BALANCE type, the system now first searches for an account with an existing 'equity-type' slot having the value 'opening-balance' and returns it as an opening balance account if one exists. If no corresponding account is found, the search is continued as before. An account found in the process is automatically given the status of an opening balance account (it is given an 'equity-type' slot with value 'opening-balance') to simplify the future search. The opening balance status of an account is visualized in the account settings dialog with a check box. If a Gnucash file does not yet contain an opening balance account, one can be selected in the account settings dialog. https://bugs.gnucash.org/show_bug.cgi?id=797836	6 years ago
John Ralls	e09a26ba3a	Merge Christian Gruber's 'test_import_backend' into maint.	6 years ago
John Ralls	2290fa7c22	Fix exception when converting to decimal values that reduce to N/1. ... Before this the loop wouldn't terminate until the denominator had been reduced to 0 and trying to create a GncRational with a 0 denominator throws.	6 years ago
John Ralls	d03dc07b8d	Remove redundant and incorrectly named constant.	6 years ago
John Ralls	3bcf57e7f2	Fix timezone transition times. ... This is responsible for test failures on DST transition days. See the comments in gnc-timezone.cpp for an explanation of why this is correct. The rubric was tested on macOS, Arch Linux, Debian Unstable, Fedora 33, and Ubuntu 18.04 to confirm universal applicability.	6 years ago
McLayn	cebe6022c8	fix CZK partname to nominative singular	6 years ago
Christopher Lam	e833c8e1aa	[utest-gnc-pricedb.c] test: gnc_pricedb_get_[latest|nearest]_price	6 years ago
Christopher Lam	2ecdd70e24	[gnc-pricedb.c][api] pull out composite pricedb price retriever ... * tries direct price retrieval from pricedb. * if fails, tries intermediate currency.	6 years ago
Christopher Lam	4d63eb922f	[gnc-pricedb.c] copy convert_amount to convert_price	6 years ago
Christopher Lam	26e7eada37	[gnc-pricedb.c] refactor amount converters, use common code	6 years ago
Robert Fewell	8e5e3480ad	Bug 797984 - Infinite loop while Check&Repair AR and AP accounts ... If using the Check&Repair option from the Chart of Accounts on 'Account Receivable or Payable' add has a voided transaction will cause an infinite loop. This occurs from checking the transaction split amount is zero in gncScrubBusinessSplit and trying to delete it. As the transaction is read only as a result of being voided this fails so add a further condition for the 'else if' statement to include !is_void.	6 years ago
Robert Fewell	122cd682f6	Add some additional places where Check&Repair can be aborted	6 years ago
Robert Fewell	6ee537e1a7	Allow the Check&Repair routine to be cancellable from CoA ... Add a callback for a keypress event when on the Accounts page that checks for the Escape key and presents a dialog to confirm whether to abort the Check&Repair. A similar dialog is used if you decide to quit Gnucash while the Check&Repair is still running.	6 years ago
John Ralls	94a68dca7c	Bug 797983 - v4.2 report numbers change over gnucash restarts;... ... Price Database dropping user:price-editor entries. A wider problem: QofInstance was unmarking itself dirty as long as the backend raised an error and unconditionally marking itself non-infant. This matters because the SQL backend depends on infant status to decide whether to do an insert or update query; either will fail if the infant status is wrong. The price editor dialog clones a price having only its commodity set and GncSqlPriceBackend declines to save if the currency isn't set. Since the instance marked itself non-infant even though it wasn't saved subsequent commits tried to use an update query and since the price wasn't in the table that inevitably failed. Requiring that QofBackend::commit should doing the marking-clean required implementing it in the backends where it wasn't already.	6 years ago
Christian Gruber	6394b6491b	fixup! Simplify type checking for GObject mockups	6 years ago
Christian Gruber	feba64624c	Fix xaccTransSetNotes() ... This is a bugfix for commit 954ce9577f	6 years ago
Christopher Lam	6eb2e36c2d	minor optimisations, g_list_prepend then g_list_sort separately ... if building a g_list incrementally, don't sort on each insertion.	6 years ago
Christopher Lam	e6486e9d95	deprecate xaccAccountCountSplits with include_children = FALSE ... whereby xaccAccountCountSplits is called with with_children = FALSE, test xaccAccountGetSplitList against NULL.	6 years ago
Christopher Lam	1b31c06b29	[Account.cpp] add gnc_account_and_descendants_empty (acc) ... and deprecate xaccAccountCountSplits	6 years ago
John Ralls	5e6f9b3460	Fix some return of ptr-to-temporary errors ... Flagged by new clang Apple version 12.	6 years ago
John Ralls	1c5561714d	Fix ptr-comparison-to-string-literal error ... A new error raised in the latest versions of gcc and clang. The address of string literals is undefined in the C standard so the compiler raises an error if one tries to test for string equality by comparing them. A better fix would be to replace QOF_ID strings with an int-based identifier; an even better one would get rid of QOF_ID entirely and use the C++ type system.	6 years ago
Christian Gruber	e44cf9c61f	Add missing C linkage statements	6 years ago
Christian Gruber	63969e8628	Remove unecessary include	6 years ago
Christian Gruber	d673c32e35	Mock methods should not neccessarily return mock objects	6 years ago
Christian Gruber	0e634c5446	Relax runtime type checks ... Runtime type checks should only check for the mock up type, if neccessary. If objects of another class than the mocked object itself are processed, runtime type check should only check for the base-class type. It should be possible to use mockup objects and non-mockup objects within the same application. The included headers are adapted accordingly.	6 years ago
Christian Gruber	99256c385b	Add missing _get_type() functions of all mocked GObject classes ... If a GObject is replaced by a mock up, its _get_type() function has to be replaced as well. The replaced _get_type() functions have to return the type of the mock up now.	6 years ago
Christian Gruber	833edd0b29	Add missing comment	6 years ago
Christian Gruber	bc80bbb325	Simplify type checking for GObject mockups ... A type conversion function is introduced for each GObject mockup. This function does a runtime type check and generates a GoogleTest failure in case of any type error. This avoids checking GObject type twice.	6 years ago
Christian Gruber	b0906b5e2a	Use MOCK_CONST_METHODn() macro instead of MOCK_METHODn() macro if necessary	6 years ago
Christian Gruber	5408854c28	Rename GObject type names of mock classes ... According to a remark in PR #738 the lower case type name is changed. Underscores should only be used between namespace and type name and between type name and suffixes.	6 years ago
Robert Fewell	edaa0d7eea	Fix some spaces on blank lines is source files	6 years ago
Robert Fewell	416e234232	Bug 797945 - Imap bayes conversion runs many times ... When the Imap Editor is loaded, the bayes KVP entries are tested to see if they are required to be converted to flat entries. This involves a function that scans every account and if it finds entries that need changing, the change is made and book property GNC_FEATURE_GUID_FLAT_BAYESIAN is added so further scans are not made. As the Imap Editor loops over the account list also, if there are no bayes KVP changes then the conversion function gets called for every account in the list. This can also happen to a lesser degree when doing imports. To stop this a flag is set once the convert to flat function has been run so it only runs once and only lasts for the session.	6 years ago
John Ralls	9c8fa5cd2e	Bug 797895 - Hang for a long time (9 minutes per account) importing... ... a QFX file. Bug 797945 - Tools -> Import Map Editor causes GnuCash to lock up. Don't edit and commit the account if it has no BAYES_IMAP slots. Account committing is extremely expensive.	6 years ago
Robert Fewell	7c1026783b	Change the document link KVP symbol to original name ... To maintain compatibility with any existing document link entries the old 'assoc-head' and 'asooc_uri' entries will be used for the gsetting and KVP entries.	6 years ago
John Ralls	843282f583	Merge John Ralls's 'assoc_title' into maint.	6 years ago
John Ralls	db626de68a	Rename all Transaction and Invoice Association identifiers to DocLink. ... To better reflect the purpose and for consistency with other software (e.g. Libre Office).	6 years ago
Robert Fewell	d0309b39d9	Bug 797935 - Strange formal register headers ... The headers were made up from two parts, 'Tot' which was translated and 'Debit/Credit' which was not. Traced to some missing brackets around the returned dflt_acct_debit_str and dflt_acct_credit_str.	6 years ago
John Ralls	de0422da25	Merge G4js's missing-sentinels into maint.	6 years ago
Christopher Lam	f6d34f226f	[Scrub.c] improve responsiveness of progressbar during scrub ... Formerly would update progress bar every 100 splits. With scrub being slow, it's nicer to update every 10 splits. Also remove the (percentagefunc)(NULL, 0.0) which seems an error -- it would reset the progressbar back to zero immediately.	6 years ago
Gaming4JC	cca4524055	Fix warnings: missing sentinel in function calls ... When compiling with -Werror, GNUCash fails to build due to various error: missing sentinel in function call. This patch resolves the issue by passing nullptr instead of C-style casting NULL.	6 years ago
jean	bbdd4f34b6	Bug 797900 - Crash caused by Quitting while Check and Repair All is running ... The account tree page didn't have a "finish" function normally used to verify a page can close. I added one, along with two flags that indicate whether a scrubbing operation is currently ongoing and whether we should quit when the scrubbing is done. The result is: If a user attempts to quit while scrubbing isn't done, an alert pops up asking whether the user wants to abort the scrub. If so, the scrub is aborted (safely) and GC quits. If not the app does not quit. I have to say, I'm not sure this is the right way to do this. In my view, the right way would be: - Disable the "quit" menu when scrubbing is happening (for some reason gnc_suspend_gui_refresh() does not cause the quit menu to be grayed) so there's no chance of quitting while scrubbing is ongoing - If needed, add an abort scrubbing button to the main window. Not sure whether that's desirable or not. Let me know what you think: is what I have what we need, or would the above be better.	6 years ago
Christian Gruber	41c147a918	Use /* ... */ for multi-line comments	6 years ago
Christian Gruber	df6621f2b5	Add doxygen documentation to QofFakeQuery and QofFakeQueryPool	6 years ago
John Ralls	6d44d0675e	Reduce random transactions and iterations on test-lots.cpp. ... No point in generating 320 transactions or running the test 10 times for a simple does-it-crash test. Do it once with 32 transactions so it takes less than one second instead of 16.	6 years ago
Christopher Lam	00efc1696a	[Transaction.c] sanity check xaccTransGetAPARAcctSplitList ... prevent segfault if trans is NULL	6 years ago
jean	a9f79cf79c	Add a flag to the account structure to defer balance computation	6 years ago
Ralf Habacker	4df6493bc2	Fix API doc of gnc_account_lookup_by_code() ... Taken from PR #762, but it is separate issue and rest of the PR needs some discussion.	6 years ago
John Ralls	a93f3c198d	Warn against using xaccTransGetSplit for iteration. ... Instead of encouraging it.	6 years ago
jean	705f0dbf9e	Bug 797854 - Global Register Preference to prompt for interest payment is not being honored. ... A new per-account preference is added to let the user decide whether the interest transaction dialog should be opened automatically before the reconcile. This preference is only enabled for certain types of accounts and the code that decides that was moved to Account.h as is it now used in two separate place.	6 years ago
John Ralls	edd7efd951	Bug 797853 - Crash on 'Save As' in MacOS Mojave and Gnucash 4 ... Check and handle null books throughout GnuCash. Tests are left alone because they should fail if there's no book.	6 years ago
Christian Gruber	861a2482fe	Add a comment on using empty ctor for mock classes derived from GObjects	6 years ago
Christian Gruber	3d92d53917	Rename all class methods using snake_case instead of camelCase	6 years ago
Christian Gruber	1fa90a5429	Cleanup some comments	6 years ago
Christian Gruber	1e2236afdc	Use typed queries	6 years ago
Christian Gruber	fa82a8bcce	Replace query factory by a query pool ... Query factory was implemented using a public global variable qof_query_factory. Furthermore a query pool is easier to handle than a factory, since the whole management can be hidden from the user.	6 years ago
Christian Gruber	2639cdefdf	Remove unnecessary inclusion of qofquery-p.h	6 years ago
Christian Gruber	841111e37e	Rename class QofMockQuery to QofFakeQuery	6 years ago
Christian Gruber	bbfc30d70b	Rename gmock-qofquery to fake-qofquery	6 years ago
Christopher Lam	ebb462d06d	[account.cpp] prevent crash in gnc_account_get_currency_or_parent ... if the *account argument is NULL, it is not reasonable to have a g_assert crash. Passing NULL account returns NULL commodity instead.	6 years ago
John Ralls	0e0c27f80f	Bug 797850 - Account register credit/debit column headings untranslated ... Plus make the former globals static.	6 years ago
c-holtermann	22f91c407e	use same order in comment as in definition of SessionOpenMode enum	6 years ago
c-holtermann	e23bf0bc1c	fix SessionOpenMode explanation for SESSION_NEW_OVERWRITE	6 years ago
c-holtermann	7c8e0a28fc	better display for doxygen, typo and consistent naming	6 years ago
Christian Gruber	8ac640d5fa	Fix typo	6 years ago
Christian Gruber	610bbda23f	Add glib-object.h to includes	6 years ago
Christian Gruber	53c294f9e8	Remove unnecessary type check	6 years ago
Christian Gruber	bb0088c43c	Replace g_return_if_fail() and g_return_val_if_fail() by ASSERT_TRUE and EXPECT_TRUE	6 years ago
Christian Gruber	967cf0b430	Pass std::vector arguments by reference instead of by value	6 years ago
Christian Gruber	d084279891	State comment on unused GObject instance init function more precisely	6 years ago
Christian Gruber	67f63053fb	Remove todo comments on replacement of std::vector by std::list ... Replacing std::vector by std::list wouldn't have any advantage	6 years ago
Christian Gruber	a9d85e8f8e	Use std::vector of const char* instead of std::string where meaningful ... This avoids additional string allocation	6 years ago
John Ralls	6a1cb5eecd	Replace the three bool parameters to qof_session_begin to an enum. ... For clarity. In so doing found the backend behavior a bit inconsistent so it's modified to do what the enum values indicate. In the course of changing the various calls I found some implementation errors in the back end and corrected them.	6 years ago
John Ralls	a320035f42	QofSession, QofBackend: Change book_id to uri. ... It's more descriptive and less likely to be confused with the book:id value in XML files that is the book's GUID. Also changed the QofSessionImpl::begin new_uri parameter from std::string to const char*. There's no point in allocating a string just to call new_uri.c_str() all over the place.	6 years ago
John Ralls	65e2639de4	Delete QOF_STDOUT. ... Apparently a hack for the long-gone QSF backend.	6 years ago
Geert Janssens	a124e647db	Add files omitted in previous commit	6 years ago
Geert Janssens	5fc2b9519c	Add mock sources and import-export test to dist	6 years ago
Robert Fewell	2f9be87549	Replace tabs with spaces in gncInvoice.c/h ... Replace tabs with spaces, trim ending spaces and add spaces to function calls where appropriate.	6 years ago
Robert Fewell	69aeacb621	Add KVP Association property to GncInvoice	6 years ago
John Ralls	f2a13ecac7	Merge Christian Gruber's 'test_import_backend' into master.	6 years ago
John Ralls	a81f155408	Fix abort in qof_log_check. ... Apparently g_logv doesn't like recursive calls from its log handler.	6 years ago
Christopher Lam	09a8bee5c0	Merge branch 'speedup-aging' #638	6 years ago
John Ralls	1510f34926	Use std::unique_ptr instead of std::shared_ptr. ... No need to share ownership.	6 years ago
John Ralls	bd6840e035	Fix incorrecly logging all possible messages regardless of log level.	6 years ago
John Ralls	94fdc42f16	Fix wrong Boost library variable names.	6 years ago