832 Commits (1890c6ccfb1fbfa6063bf34c8a2e406b6e41c9d5)

Author	SHA1	Message	Date
Christopher Lam	6a668df168	[qofutil.h] don't recurse includes	4 years ago
Robert Fewell	83373563c3	Counter formats stored in wrong place. ... The Book Options, counter formats were being stored under the 'options' tree but need to be stored in the 'counter_format' tree similar to the 'counters' tree.	4 years ago
John Ralls	26b009c0f4	Bug 798500 - FTBFS (tests failure) on armhf ... Ensure the transition_times are correctly aligned for their sizes before attempting to copy them into the transitions vector.	4 years ago
Christopher Lam	ee8729dfb6	[account.cpp] char* must be freed	4 years ago
John Ralls	abd1a0b3f1	Merge branch 'c++options'	4 years ago
John Ralls	03cbbd1cd1	Merge branch 'maint'	4 years ago
John Ralls	109efe62b8	Rework default non-currency commodity namespace. ... Separate the "All noncurrency" convenience category in the commodity selector and the default non-commodity namespace proposed by the QIF importer because they have different functions. Also remove the namespace guessing code from qif-dialog because with only one default non-currency namespace there's nothing to guess.	4 years ago
Christopher Lam	5388cc8e2c	[kvp-frame.cpp] minor speedups ... reserve vector, cache iterator from m_valuemap.find for reuse immediately afterwards.	4 years ago
Christopher Lam	193a7aae5d	Merge branch 'maint'	4 years ago
Christopher Lam	0052e3e483	[gnc-pricedb] add user:stock-transaction price source	4 years ago
John Ralls	c1001e6641	Better wording for tax table changed info message.	4 years ago
John Ralls	d841b322d0	Merge Frank Ellenberger's 'Bug684507' into maint.	4 years ago
John Ralls	ce2b89fd8c	[business]Add diagnostic messages to GncEntry and GncInvoice.	4 years ago
John Ralls	9ad24321b4	Remove investment-type namespaces. ... Leave it to users to categorize their non-currency commodities. In the QIF importer default non-classifiable commodities to GNC_COMMODITY_NS_NONCURRENCY.	4 years ago
Frank H. Ellenberger	c7f842c081	Bug 684507 - commodity namespace should be localized	4 years ago
Christopher Lam	bd4a457040	Merge branch 'maint-lightning-budget' into maint #1248	4 years ago
Christopher Lam	a47413860a	Factor out GValue access for setters and getters	4 years ago
Christopher Lam	8f845df934	Factor out make_period_[data|note]_path	4 years ago
Christopher Lam	919f392c7a	Use kvp C++ interface rather than GValue	4 years ago
Christopher Lam	6c4c2512db	Use C++ STL instead of GLib	4 years ago
Christopher Lam	9088acabd8	[gnc-budget.cpp] convert to c++	4 years ago
Christopher Lam	c1c198c9ff	Merge branch 'maint'	4 years ago
Christopher Lam	f0de54ac7a	Merge branch 'maint-798406' into maint #1240	4 years ago
Christopher Lam	8bc080b96d	[gnc-budget] store budget kvp data onto memory upon first call. ... then each getter will retrieve from memory rather than backend's kvp.	4 years ago
Christopher Lam	ef8d812d3f	[utest-Budget] test data retention when modifying budget num_periods	4 years ago
Christopher Lam	87b0a41e9b	[Split.c] return price==0 instead of 1, if !split, or amt==0	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" ... The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
Christopher Lam	f7ee644695	Amendment to 73822f97a [1/2] use heuristics to scrub budget signs ... Testing income<0 to conclude "none reversal" is likely a more sound strategy than testing liability>0.	4 years ago
Christopher Lam	c3eaff9bb2	[account.cpp] gnc_account_and_descendants_empty: don't copy children	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	5c7967c4a5	Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint." ... This reverts commit 17a3f7fef2, reversing changes made to b8458d0732.	4 years ago
John Ralls	ae7eaad018	Merge Chris Good's 'maintBug797678OfxAppend' into maint.	4 years ago
John Ralls	17a3f7fef2	Merge Stefan Bayer's 'SepaInternalTransfer' into maint.	4 years ago
Christopher Lam	73822f97a9	[1/2][Scrubbudget.c] use heuristics to scrub budget signs ... If book has budgets, and GNC_FEATURE_BUDGET_UNREVERSED isn't set, check and fix budget amount signs. Previously budgets were created with assumption that sign reversal was set to credit amounts. A heuristic approach is used: - if budgeted expense is negative, conclude sign reversal is "Income and Expense" - if budgeted liability is positive, conclude sign reversal is "None" - otherwise conclude sign reversal is "Credit Accounts" The above is calibrated to (hopefully) prefer sign reversal of Credit Accounts.	4 years ago
Christopher Lam	6070aecd69	[2/3][gnc-features.c] add & expose gnc_features_set_unused ... same as gnc_features_set_used but removes feature	4 years ago
Christopher Lam	5dab33694f	[1/3][qofbook.cpp] add & expose qof_book_unset_feature ... same as qof_book_set_feature but removes feature item	4 years ago
Christopher Lam	88ecf8dd17	Merge branch 'maint'	4 years ago
John Ralls	d1fe359e47	gnc_numeric_to_decimal: Change can't round warning to a debug. ... Routinely used as a check so a warning isn't appropriate.	4 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	ff04ad3785	Bug 798346 - crashes when running check & repair ... Don't scrub trading accounts for imbalances, see the comment in the commit for why.	5 years ago
Christopher Lam	984d816a58	Merge branch 'maint'	5 years ago
Christopher Lam	79d8ef0299	Revert b5f5129f7 using gnc_list_length_cmp	5 years ago
Christopher Lam	b5f5129f7d	Shortcut g_list_length comparison against small numbers ... It's more efficient to test node && node->next etc when testing GList length against small numbers	5 years ago
goodvibes2	8ad29feaba	Bug797678 OFX import should append not replace, existing Notes & Desc ... Add an "Append" checkbox to the bottom of the "Generic import transaction matcher" window to the left of the "Reconcile after match" checkbox. When ticked, this causes the imported Description/Notes to be appended to the matched transaction Description/Notes respectively. The selected ticked/unticked state of the "Append" checkbox is saved in a key value pair for the import account, so the next import for that account will automatically default it to the saved state. As these mods are limited to the code for the matcher window, this should work for all the imports that use it - ie ofx & csv file imports (both tested) & aqbanking (cannot test).	5 years ago
John Ralls	5a8cbf4193	Bug 798325 - New Currency for Venezuela (VED) ... Add latest Venezuelan revaluation of the Bolivar Soberano, following the ISO notation replacing VES (which the Venezualan central bank is keeping) with VED and the exchange code (ditto) with 926.	5 years ago
Christopher Lam	f40dbb8c28	Avoid unnecessary g_list_length in equality functions	5 years ago
Christopher Lam	f0970c8eb4	[gnc-features] don't repeatedly g_strconcat gchars*	5 years ago
Christopher Lam	31a0300abe	[Recurrence.c] avoid repeated calls to g_list_length	5 years ago
Christopher Lam	b480600dc8	[gnc-pricedb] gnc_price_list_equal: avoid 4 g_list_length calls	5 years ago
Christopher Lam	23e528f51a	[utest-gnc-pricedb] add tests for gnc_price_list_equal ... Also need to change PWARN which causes test failure, to PINFO	5 years ago
John Ralls	2f4438ab28	Bug 798335 - No longer possible to change trading account ... Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so.	5 years ago
Christopher Lam	9eaa3eb23a	Merge branch 'maint'	5 years ago
John Ralls	7c9c2eba3c	Bug 798320 - Error message indicating a crash of GNUcash when closing... ... application - MacOS 10.15.7 (19H1419) Destruction order problem: The SX template accounts can't be destroyed until after the template splts and transactions are. Register them before the transactions and splits, as destruction occurs in reverse order of registration.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason ... tests in 128c8d6f88	5 years ago
Christopher Lam	128c8d6f88	[utest-Transaction] add tests for xaccTransGetReadOnly	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions ... GValue in DxaccAccount[Set|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in 4309469730.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset ... already have comprehensive tests in 15852031d	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry ... Have comprehensive tests in a5d101d1b	5 years ago
Christopher Lam	4309469730	[utest-Account] test old dxaccAccount* functions ... dxaccAccountGetPriceSrc and dxaccAccountGetQuoteTZ. DxaccAccountSetCurrency remains untested - unsure how to retrieve an ISO4217 currency to use as parameter.	5 years ago
Christopher Lam	a5d101d1be	[utest-Account] test gnc_account_get_map_entry	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" ... This reverts commit d290c3c45d. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path ... exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago
John Ralls	824b515430	Fix qoflog's comments to reflect a preference for the macros over GLib functions.	5 years ago
John Ralls	74d0630867	Bug 798237 - Logging during XML file loading degrades performance... ... significantly Modify the DEBUG and PINFO macros to return unless qof_log_check is true. Replace almost all direct calls to g_debug and g_message with DEBUG and PINFO respectively. Track the highest logging level sent to qof_log_set_level to provide a short-circuit return in qof_log_check. Remove setting GNC_MOD_TESTS to QOF_LOG_DEBUG so that the short-circuit threshold isn't defeated by always being DEBUG. Net result: 33% improvement in xml load times.	5 years ago
Christopher Lam	15852031d4	[utest-account.cpp] increase test coverage ... adds getter/setter tests for xaccAccountSetLastNum xaccAccountSetTaxUSCode xaccAccountSetTaxUSPayerNameSource	5 years ago
Christopher Lam	017ab06939	Merge branch 'maint'	5 years ago
John Ralls	8ab8642e76	Fix leak of trading_splits list in xaccTransClearTradingSplits	5 years ago
John Ralls	1387d5f960	Fix unchecked ptr dereference. ... First crash in Bug 798225.	5 years ago
John Ralls	ab24c34660	Merge Simon Arlott's 'free-template-root' into maint.	5 years ago
Simon Arlott	4a8acf3fb2	Free template root accounts on book end ... The template root should be unset so that it's destroyed when the book is ending. This is required to free all the template accounts and referenced strings. The scheduled transactions themselves need to be freed first so reverse the order that SXRegister and gnc_sxtt_register are called in cashobjects_register: The list resulting from that function is traversed from the bottom up.	5 years ago
John Ralls	079a900300	Bug 798298 - Re-imported transactions no longer ignored ... Merges Jean Laroche's '798298_reimport_ofx' into maint.	5 years ago
Mike Alexander	068a5d2fa8	Fix xaccSplitGetOtherSplit which was broken by 028bf9826, don't ... count splits that aren't really in the transaction. The rewrite left out one test. This was most obvious in the dummy transaction used to enter a new transaction into an account. xaccSplitGetOtherSplit never returned an "other split" for this transaction. It turns out the old code was broken too, but it worked for this case by coincidence.	5 years ago
jean	4e9fe0a4d1	Add missing function to mock account	5 years ago
Christopher Lam	8d502fcdd8	Merge branch 'maint'	5 years ago
Christopher Lam	1eb6709331	[test-lots.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	323182c9f7	[utest-Account.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	8a37c4c019	[utest-Invoice.c] add kvp getter/setter tests	5 years ago
Christopher Lam	9ec670f828	[test-commodities.cpp] add kvp setter/getter test	5 years ago
Christopher Lam	d4c8b36f9f	[utest-Transaction.cpp] add kvp setter/getter tests ... wasn't tested before	5 years ago
Christopher Lam	c3b50f0b58	[gnc-lot.c] fix - cache value properly	5 years ago
Christopher Lam	595e126a34	[account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr ... - will remove a second call to g_strstrip (g_strdup (str))	5 years ago
Christopher Lam	c5a6383b43	[account.cpp] fix - incomplete #1117 ... - init struct members properly to: is_unset and TriState::Unset - test acct kvp "equity-type" for "opening-balance" instead of "true" - cached account->color/sort_order/notes/filter gets strstripped similarly to previous behavior	5 years ago
Christopher Lam	001b34616f	[Transaction.c] GValue string must be unset	5 years ago
Christopher Lam	a47bee97d6	[Split.c] GValue string must be unset	5 years ago
Christopher Lam	0ecbcb4ef1	[gnc-lot.c] GValue string must be unset	5 years ago
Christopher Lam	ac2afc7e13	[gncInvoice.c] GValue string must be unset	5 years ago
Christopher Lam	3bf49ed8d7	[Account.cpp] GValue string must be unset	5 years ago
Christopher Lam	e3af2f22f9	[gnc-commodity.c] cache user_symbol into commodity struct ... Continuation of ff2ceb111 which introduced issue whereby user_symbol returned could become stale, leading to invalid read fixed with c398bef59. There are likely other user_symbol pointers becoming stale without this commit. This change will save the user_symbol into the commodity struct, avoids gchar* becoming stale.	5 years ago
John Ralls	57f73d70c7	Merge Yordan Miladinov's denom_lcd into maint.	5 years ago
Christopher Lam	c6d8333811	Merge branch 'maint'	5 years ago
Christopher Lam	c55ab50349	[gnc-budget.c] gnc_budget_get_account_period_note to be freed by the caller	5 years ago
Yordan Miladinov	6cb509ea7d	fix an uncaught exception: denom_lcd may throw an overflow exception if casting lcm to int64_t fails	5 years ago
Christopher Lam	7e41efc232	Merge branch 'maint-speedup-and-leaks' into maint #1109 ... Speedup xaccSplitGetOtherSplit	5 years ago
Christopher Lam	ff2ceb111d	[gnc-commodity] GValue must be unset	5 years ago
Christopher Lam	028bf9826b	[Split] xaccSplitGetOtherSplit don't test book trading-accts ... don't test trading-acct property when finding other split.	5 years ago
Christopher Lam	6bf5a618de	qof_instance_get gchar* must be freed ... A call to qof_instance_get expecting a gchar* receives a newly allocated string which must be freed.	5 years ago