832 Commits (1890c6ccfb1fbfa6063bf34c8a2e406b6e41c9d5)

Author	SHA1	Message	Date
Christopher Lam	23e528f51a	[utest-gnc-pricedb] add tests for gnc_price_list_equal ... Also need to change PWARN which causes test failure, to PINFO	5 years ago
John Ralls	2f4438ab28	Bug 798335 - No longer possible to change trading account ... Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so.	5 years ago
Christopher Lam	9eaa3eb23a	Merge branch 'maint'	5 years ago
John Ralls	7c9c2eba3c	Bug 798320 - Error message indicating a crash of GNUcash when closing... ... application - MacOS 10.15.7 (19H1419) Destruction order problem: The SX template accounts can't be destroyed until after the template splts and transactions are. Register them before the transactions and splits, as destruction occurs in reverse order of registration.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason ... tests in 128c8d6f88	5 years ago
Christopher Lam	128c8d6f88	[utest-Transaction] add tests for xaccTransGetReadOnly	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions ... GValue in DxaccAccount[Set|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in 4309469730.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset ... already have comprehensive tests in 15852031d	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry ... Have comprehensive tests in a5d101d1b	5 years ago
Christopher Lam	4309469730	[utest-Account] test old dxaccAccount* functions ... dxaccAccountGetPriceSrc and dxaccAccountGetQuoteTZ. DxaccAccountSetCurrency remains untested - unsure how to retrieve an ISO4217 currency to use as parameter.	5 years ago
Christopher Lam	a5d101d1be	[utest-Account] test gnc_account_get_map_entry	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" ... This reverts commit d290c3c45d. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path ... exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago
John Ralls	824b515430	Fix qoflog's comments to reflect a preference for the macros over GLib functions.	5 years ago
John Ralls	74d0630867	Bug 798237 - Logging during XML file loading degrades performance... ... significantly Modify the DEBUG and PINFO macros to return unless qof_log_check is true. Replace almost all direct calls to g_debug and g_message with DEBUG and PINFO respectively. Track the highest logging level sent to qof_log_set_level to provide a short-circuit return in qof_log_check. Remove setting GNC_MOD_TESTS to QOF_LOG_DEBUG so that the short-circuit threshold isn't defeated by always being DEBUG. Net result: 33% improvement in xml load times.	5 years ago
Christopher Lam	15852031d4	[utest-account.cpp] increase test coverage ... adds getter/setter tests for xaccAccountSetLastNum xaccAccountSetTaxUSCode xaccAccountSetTaxUSPayerNameSource	5 years ago
Christopher Lam	017ab06939	Merge branch 'maint'	5 years ago
John Ralls	8ab8642e76	Fix leak of trading_splits list in xaccTransClearTradingSplits	5 years ago
John Ralls	1387d5f960	Fix unchecked ptr dereference. ... First crash in Bug 798225.	5 years ago
John Ralls	ab24c34660	Merge Simon Arlott's 'free-template-root' into maint.	5 years ago
Simon Arlott	4a8acf3fb2	Free template root accounts on book end ... The template root should be unset so that it's destroyed when the book is ending. This is required to free all the template accounts and referenced strings. The scheduled transactions themselves need to be freed first so reverse the order that SXRegister and gnc_sxtt_register are called in cashobjects_register: The list resulting from that function is traversed from the bottom up.	5 years ago
John Ralls	079a900300	Bug 798298 - Re-imported transactions no longer ignored ... Merges Jean Laroche's '798298_reimport_ofx' into maint.	5 years ago
Mike Alexander	068a5d2fa8	Fix xaccSplitGetOtherSplit which was broken by 028bf9826, don't ... count splits that aren't really in the transaction. The rewrite left out one test. This was most obvious in the dummy transaction used to enter a new transaction into an account. xaccSplitGetOtherSplit never returned an "other split" for this transaction. It turns out the old code was broken too, but it worked for this case by coincidence.	5 years ago
jean	4e9fe0a4d1	Add missing function to mock account	5 years ago
Christopher Lam	8d502fcdd8	Merge branch 'maint'	5 years ago
Christopher Lam	1eb6709331	[test-lots.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	323182c9f7	[utest-Account.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	8a37c4c019	[utest-Invoice.c] add kvp getter/setter tests	5 years ago
Christopher Lam	9ec670f828	[test-commodities.cpp] add kvp setter/getter test	5 years ago
Christopher Lam	d4c8b36f9f	[utest-Transaction.cpp] add kvp setter/getter tests ... wasn't tested before	5 years ago
Christopher Lam	c3b50f0b58	[gnc-lot.c] fix - cache value properly	5 years ago
Christopher Lam	595e126a34	[account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr ... - will remove a second call to g_strstrip (g_strdup (str))	5 years ago
Christopher Lam	c5a6383b43	[account.cpp] fix - incomplete #1117 ... - init struct members properly to: is_unset and TriState::Unset - test acct kvp "equity-type" for "opening-balance" instead of "true" - cached account->color/sort_order/notes/filter gets strstripped similarly to previous behavior	5 years ago
Christopher Lam	001b34616f	[Transaction.c] GValue string must be unset	5 years ago
Christopher Lam	a47bee97d6	[Split.c] GValue string must be unset	5 years ago
Christopher Lam	0ecbcb4ef1	[gnc-lot.c] GValue string must be unset	5 years ago
Christopher Lam	ac2afc7e13	[gncInvoice.c] GValue string must be unset	5 years ago
Christopher Lam	3bf49ed8d7	[Account.cpp] GValue string must be unset	5 years ago
Christopher Lam	e3af2f22f9	[gnc-commodity.c] cache user_symbol into commodity struct ... Continuation of ff2ceb111 which introduced issue whereby user_symbol returned could become stale, leading to invalid read fixed with c398bef59. There are likely other user_symbol pointers becoming stale without this commit. This change will save the user_symbol into the commodity struct, avoids gchar* becoming stale.	5 years ago
John Ralls	57f73d70c7	Merge Yordan Miladinov's denom_lcd into maint.	5 years ago
Christopher Lam	c6d8333811	Merge branch 'maint'	5 years ago
Christopher Lam	c55ab50349	[gnc-budget.c] gnc_budget_get_account_period_note to be freed by the caller	5 years ago
Yordan Miladinov	6cb509ea7d	fix an uncaught exception: denom_lcd may throw an overflow exception if casting lcm to int64_t fails	5 years ago
Christopher Lam	7e41efc232	Merge branch 'maint-speedup-and-leaks' into maint #1109 ... Speedup xaccSplitGetOtherSplit	5 years ago
Christopher Lam	ff2ceb111d	[gnc-commodity] GValue must be unset	5 years ago
Christopher Lam	028bf9826b	[Split] xaccSplitGetOtherSplit don't test book trading-accts ... don't test trading-acct property when finding other split.	5 years ago
Christopher Lam	6bf5a618de	qof_instance_get gchar* must be freed ... A call to qof_instance_get expecting a gchar* receives a newly allocated string which must be freed.	5 years ago
Christopher Lam	e4d808e674	[qofbook] qof_book_use_split_action_for_num_field: free a char* ... qof_instance_get allocates a new char* which must be freed.	5 years ago
Christopher Lam	eafc290034	Merge branch 'maint'	5 years ago
Christopher Lam	40d886fa9d	gnc_account_list_name_violations elements must be freed	5 years ago
Christopher Lam	4c37f6d4ef	[account.cpp] gnc_g_list_stringjoin instead of repeated allocations	5 years ago
Christopher Lam	bedc85afa3	Merge branch 'maint-leaks' into maint #1101	5 years ago
Christopher Lam	0420ae6a66	[account.cpp] refactor gnc_account_list_name_violations	5 years ago
Christopher Lam	67bd513514	[account.cpp] rewrite gnc_account_foreach_descendant_until in C++	5 years ago
Christopher Lam	17953441cb	[account.cpp] refactor gnc_account_foreach_descendant	5 years ago
Christopher Lam	5698b67bf5	[account.cpp] refactor gnc_account_lookup_by_code	5 years ago
Christopher Lam	09e2e7613c	[account.cpp] refactor gnc_account_lookup_by_name	5 years ago
Christopher Lam	bebc366e88	[account.cpp] refactor gnc_account_n_descendants	5 years ago
John Ralls	f0926d66c1	Merge Simon Arlott's 'qof-instance-dispose' into maint.	5 years ago
Christopher Lam	e6c33a39bc	[account.cpp] refactor gnc_account_get_descendants{_sorted}	5 years ago
Christopher Lam	d2db43019c	[account.cpp] internal function account_foreach_descendant ... fast and efficient	5 years ago
Christopher Lam	de1ad9367a	g_free gnc_ctime which returns a new gchar*	5 years ago
Simon Arlott	7a0ea190ca	qof_instance_dispose should always complete dispose processes ... If QofInstancePrivate has no collection then qof_instance_dispose() returns without completing the rest of its dispose processes, skipping removal of its type string from the string cache resulting in a reference count leak. Change the check for a collection so that it only affects the call to qof_collection_remove_entity().	5 years ago
John Ralls	9062be3d47	Merge Simon Arlott's 'string-cache-fixes' into maint.	5 years ago
John Ralls	76b0001cbe	Remove option-util.	5 years ago
John Ralls	e2c87f23c3	Convert optiondb users in gnome and gnome-utils to C++. ... To enable using std::unique_ptr<GncObjectDB> and avoid memory management problems.	5 years ago
John Ralls	7dab089d49	Fix miscalculation of prev_quarter_end for the first quarter. ... If the current quarter ends June 30 backing up 3 months from there gets March 30, one day off. Back up first and calculate the end of the actual quarter of interest. Changed pre_quarter_start for consistency, it doesn't matter.	5 years ago
John Ralls	28438e3126	Rewire gnome and gnome-utils to use GncOptionDB.	5 years ago
John Ralls	67508ea039	Reimplement dialog-options for C++.	5 years ago
John Ralls	08bf3ec5b0	Merge branch 'maint'	5 years ago
Simon Arlott	4a5b5f3bf2	Don't cache the empty string ... Avoid unnecessary reference counting for uses of the empty string.	5 years ago
Simon Arlott	320df7e409	Use const return values for string cache ... This is a prerequisite for being able to return "" (which is const) and none of the returned values should ever be modified.	5 years ago
Simon Arlott	4132939612	Avoid leaking string cache entries for "" in Transaction and Split ... When g_object_new() is used, the strings that default to "" are added to the string cache. These are then not correctly removed when updating them with new values when cloning a Transaction/Split. Use CACHE_REPLACE instead of CACHE_INSERT.	5 years ago
John Ralls	81c5ac6689	Remove the incomplete book-currency code. ... Not everything from the 6 Book-Currency commits is removed: Switching the Num and split-action fields and restricting edits of transactions older than n days were included and those changes are left in place. Some other partly-implemented features were also part of these commits and were removed: Options for setting a default capital gains account and currency, completion of the LIFO cap-gains policy, and creation of a list of cap-gains policies. If any of these are to be revived they should each be done in a separate feature branch and submitted via Github pull request for a code review before merging; a design discussion on gnucash-devel before restarting work is also advisable.	5 years ago
John Ralls	d2535fe21b	KvpValue: Use boost::typeindex::type_id instead of buildtin typeid. ... Under some build conditions boost::typeindex will use an internal type identifier that's different from the C++ builtin. In that case type equality tests to C++ typeid in boost::variant will fail, breaking it. Using boost::typeindex::type_id ensures that the comparisons always work.	5 years ago
Robert Fewell	0f026f6a10	Bug 798221 - Transfer funds between accounts with different currencies crashes Gnucash on macOS ... In the scrub function find_account_matching_name_in_list there was a test for account names being the same for currency but condition was backwards so was matching on account names being different. There was also a g_list_free resulting in a double free which was removed.	5 years ago
Simon Arlott	08b56e9669	[gnc-pricedb] Don't lookup old prices when doing bulk updates	5 years ago
Christopher Lam	1b4d30b3b1	Merge branch 'maint'	5 years ago
Hong Xu	0fd0aca531	Explain out what AsOfDate means in the doc ... As discussed at https://lists.gnucash.org/pipermail/gnucash-user/2021-June/096893.html	5 years ago
John Ralls	601eb51361	Improve transaction sorting on effective num field. ... Inspired by PR #983. Transaction sorting on num broke down if the user had a non-numeric string or a number larger than an int in the effective num field (might be split-action if the option is set). The comparison first tries to use strtoull on the two strings and compares the results. If they're both nonzero and different then the numeric order is returned. If they're both nonzero but the same the unconverted parts of each are passed to g_utf8_collate; if either is 0 then the whole strings are passed to g_utf8_collate. strtoull will return 0 for a negative number.	5 years ago
John Ralls	985a6420fc	Bug 798196 - not building with Boost 1.76	5 years ago
John Ralls	6aa35ea7fb	Better fix for bug 798204, doesn't break trading account selection.	5 years ago
John Ralls	9eeff5dd7e	Bug 798204 - Creation of Imbalance Accounts ... Search recursively when getting account by name.	5 years ago
John Ralls	68ec80e68d	Bug 798203 - g_assert fault while reversing transaction ... * Re-commit the original transaction to ensure that there aren't any stray trading splits. * If the original and cloned transactions have a different number of splits don't leak the cloned transaction. * Check that the cloned transaction isn't NULL before trying to invert it.	5 years ago
John Ralls	80d6749989	Bug 787813 - Price change from editing a transaction not reflected... ... in pricedb. Allow PRICE_SOURCE_SPLIT_REG to overwrite PRICE_SOURCE_XFER_DLG_VAL.	5 years ago
Christopher Lam	321b5efabc	Merge branch 'maint-leaks' into maint #1019	5 years ago
John Ralls	42213c597c	Bug 798199 - Pasting invalid value in date column crashes GnuCash ... Catch boost::gregorian::bad_year in LDT_from_struct_tm and rethrow std::invalid_argument for C wrappers to catch and handle.	5 years ago
Christopher Lam	b095d1e7da	Revert "[qofquery] q->terms g_list members must be freed" ... This reverts commit a3e3823ee7. Already freed earlier in the same function.	5 years ago
Christopher Lam	c8a7b9edb3	[Account] g_value_unset	5 years ago
Christopher Lam	bfdec74a48	[qof-backend] gchar * gnc_path_get_pkglibdir must be g_freed	5 years ago
Christopher Lam	f6a9be45ba	[Split] g_value_unset	5 years ago
Christopher Lam	36901c5751	[gncJob] g_value_unset	5 years ago
Christopher Lam	1824a30bd0	[gncinvoice] g_value_unset	5 years ago
Christopher Lam	badd976e11	[gnc-lot] g_value_unset	5 years ago
Christopher Lam	c9565abe8b	[gnc-commodity] g_value_unset	5 years ago
Christopher Lam	302020fcb7	[gnc-budget] g_value_unset	5 years ago
Christopher Lam	ceeb1dff7a	[scrub.c] g_value_unset	5 years ago
Christopher Lam	92cd437562	[Transaction.c] g_value_unset to release GValue string	5 years ago
Christopher Lam	3353d3950b	[gnc-budget] g_value_unset GValue	5 years ago
Christopher Lam	a3e3823ee7	[qofquery] q->terms g_list members must be freed	5 years ago
Christopher Lam	8a6413342d	[SchedXaction] free GList*	5 years ago
Christopher Lam	c5585ebe2c	[gncInvoice] free GList*	5 years ago
Christopher Lam	d611538ae7	[gncTaxtable] free GSList*	5 years ago
Christopher Lam	b3101c9385	[gnc-pricedb.c] plug GList leak	5 years ago
Christopher Lam	8a56a00313	Modify documentation for gncEntryComputeValue ... Modify documentation for be19b489e	5 years ago
Christopher Lam	b25a444140	Merge branch 'maint'	5 years ago
John Ralls	da3c511b6c	Remove trading splits instead of trying to adjust them.	5 years ago
John Ralls	4f030aac6e	Bug 798093 - Changing the symbol/abbreviation of a security... ... after the trading account was created breaks GnuCash. Revisited. The original changeset looked for a top level trading account and a namespace account in the transaction currency; if either of those accounts had been created in a different currency it would duplicate them. This commit will accept any such account regardless of commodity. If more than one exists it will prefer the one in the root currency if there is one, otherwise it will select the first one found.	5 years ago
John Ralls	18c72baddf	Don't bother scrubbing for orphans if there's no transaction currency. ... If it found one it would try to create an orphan account with no currency which will crash later.	5 years ago
John Ralls	2b48fd375d	Revert "Fix duplicate trading accounts." ... This reverts commit ed486a58a4.	5 years ago
Hong Xu	888676eb31	from_price and to_price may be uninitialized in extract_comon_prices ... Fix the compilation error on gcc 10: gnucash/libgnucash/engine/gnc-pricedb.c: In function ‘extract_common_prices’: gnucash/libgnucash/engine/gnc-pricedb.c:2469:40: error: to_price may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 | if (from_price == NULL || to_price == NULL) | ^ gnucash/libgnucash/engine/gnc-pricedb.c:2469:20: error: ‘from_price’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 | if (from_price == NULL || to_price == NULL) | ^	5 years ago
Christopher Lam	ae7eb9b3ad	[gnc-pricedb] extract common code into get_nearest_price ... Extracts common code in: * gnc_pricedb_get_nearest_before_price * gnc_pricedb_get_nearest_price * gnc_pricedb_get_latest_price	5 years ago
Christopher Lam	a2f5223148	[gnc-pricedb] use g_list_find and plug memory leak ... found_coms was not being freed.	5 years ago
John Ralls	ed486a58a4	Fix duplicate trading accounts. ... In many cases GnuCash would create a new trading account hierarchy when one already existed because gnc_account_lookup_by_type_and_commodity didn't check the account presented and didn't recurse down the account hierarchy correctly.	5 years ago
John Ralls	2258e7a44e	xaccAccountTypes was backwards ... vs. the documentation. The unit tests and dialog-account were similarly backwards, but the use in gnucash/import-export/ofx followed the docs.	5 years ago
Christopher Lam	5ce8f78f77	Merge branch 'maint'	5 years ago
Robert Fewell	e535ba5411	Change some functions to use const gnc_commodity for gnc_pricedb	5 years ago
Robert Fewell	e75308e684	Rename a couple of gnc-pricedb functions that have not been used. ... To be more consistent change gnc_pricedb_lookup_latest_before_t64 and gnc_pricedb_lookup_latest_before_any_currency_t64 to be of the form '_nearest_before_' and add a missing utest.	5 years ago
Robert Fewell	d3bd7fda61	Add unit tests for new gnc-pricedb functions	5 years ago
Robert Fewell	4a491f7cde	Change a couple of docbook definitions in gnc-pricdb.h	5 years ago
Robert Fewell	05507008c5	Add retrieval functions for price before the date given ... Add a new function, gnc_pricedb_convert_balance_nearest_before_price_t64 that retrieves the balance using the last price dated before a specified date like today for the preset value. This uses another new function gnc_pricedb_get_nearest_before_price to do the retrieval.	5 years ago
Robert Fewell	b54c30e03d	Bug 798148 - Chart of Accounts page Present(xxx) value wrong ... If for some reason you have price information in the future for a security, the present value is based on the price retrieved for the greatest date and not a price which is before the current date. To fix this use the 'xaccAccountGetBalanceAsOfDateInCurrencyRecursive' function.	5 years ago
John Ralls	bbb4113a5a	Bug 798156 - glib 2.68.0 breaks gnucash ... Move all of the #include <glib> to before the extern "C" blocks so that the include guards will protect against headers inside the extern "C" block also including glib.h.	5 years ago
John Ralls	4eaa10c6be	Another extern-C glib.h, for Windows this time.	5 years ago
Christopher Lam	d28ff20ff7	Merge branch 'maint'	5 years ago
John Ralls	27435b1038	Don't filter use of TTInfo file section based on sizeof time_t. ... The whole point of GncDateTime is to work around 32-bit time_t.	5 years ago
John Ralls	b40589244c	Fix test-gnc-datetime failure on Ubunutu.	5 years ago
John Ralls	c49b45d8f1	Finish the glib 2.67 fixes for CI tests.	5 years ago
John Ralls	1221d7ebc1	Bug 798150 - Error on report over time ... Extract functions LDT_from_date_time and LDT_from_date_daypart to avoid duplicate code. Handle date-times in start-of-DST transitions and better handle those in end-of-DST transitions. Test the results.	5 years ago
John Ralls	ebb5eb1f17	Fix GncDateTime::format_zulu to emit the UTC timezone. ... Instead of the GncDateTime's timezone with the UTC timestamp.	5 years ago
John Ralls	3a35514d84	Fix the implementations of gnc_foo_get_day_neutral. ... As implemented these returned 10:59 AM local on the day but neutral time is 10:59 UTC.	5 years ago
Christopher Lam	2a2f080813	Merge branch 'maint'	5 years ago
Frank H. Ellenberger	4a983761d7	Fix a typo in a comment of the last commit	5 years ago
John Ralls	a11065b823	Fix fencepost error in calculating the week_num for POSIX timezone rules. ... Fixes CI failure caused by US starting DST in 2021, a year in which March began on a Monday.	5 years ago
John Ralls	8e41857014	Catch more exceptions in gnc_numeric_convert ... To enable fixing https://bugs.gnucash.org/show_bug.cgi?id=798132.	5 years ago
Christopher Lam	87473ed5f9	Merge branch 'maint'	5 years ago
Dong Lin	75209c024f	Update price database for imported transactions ... When a transaction is added from the ledger, price database is updated properly. But if the transaction is imported, there is no price db update. This change adds the proper pricedb update in the import path (qfx/ofx/qif). Tested with make check	5 years ago
Sumit Bhardwaj	df579c257b	Replace g_memdup by memcpy ... GLib is deprecating g_memdup. Since older versions of GLib wouldn't have g_memdup2, this PR replaces occurrences of g_memdup by memcpy.	5 years ago
Frank H. Ellenberger	93e2829ee5	Merge PR #899 into maint	5 years ago
luz paz	16b4976381	Fix typos in libgnucash/ ... Found via `codespell -q 3 -L ans,ba,parm,parms,numer`	5 years ago
Christopher Lam	e79db92d8d	[Split.c] xaccSplitListGetUniqueTransactionsReversed ... Same as xaccSplitListGetUniqueTransactions but doesn't reverse the list prior to returning. To be used by gnc-tree-model-split-reg.c Several optimizations * doesn't call g_list_find and g_list_append for every iteration * uses g_hash_table to cache list of txns already added instead of g_list_find * does not reverse the result, thereby returning a reversed list.	5 years ago
Christopher Lam	b2b8792110	prepend-and-reverse instead of O(N^2) append	5 years ago
Frank H. Ellenberger	6bc8679932	I18N: replace several spourious spaces	5 years ago
John Ralls	7a7c26f87e	Move glib and gtk includes out of extern C for tests. ... Needed to compile with glib 2.67 and later.	5 years ago
Bill Nottingham	c0f2c3ae25	Fix build with glib2 2.67.x. ... glib headers should not be included with 'extern "C"'.	5 years ago
Christopher Lam	092040c7fe	Merge branch 'maint'	5 years ago
John Ralls	4359243c08	Move glib and gtk includes out of extern C for tests. ... Needed to compile with glib 2.67 and later.	5 years ago