The current logic has each 'prepare' function jump us around in the assistant
flow in order to skip pages that aren't needed. But that logic only allows
forward movement, effectively breaking the back button.
This patch introduces a custom 'next page' function, which GtkAssistant
supports, along with a shift in the paradigm. Instead of the prepare
function jumping around, there is now a deliberate 'should I skip?' function
that is used to avoid displaying a page.
This does not make the flow perfect; unexpected exceptions still end the
process (see bug 698804) and going back with loaded files feels a bit clunky.
==158291== 6 bytes in 1 blocks are definitely lost in loss record 18 of 824
==158291== at 0x4848C63: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==158291== by 0x4A91473: scm_realloc (in /usr/lib/x86_64-linux-gnu/libguile-3.0.so.1.5.0)
==158291== by 0x4AFF26B: scm_to_stringn (in /usr/lib/x86_64-linux-gnu/libguile-3.0.so.1.5.0)
==158291== by 0x4CB473D: _wrap_gnc_mktime(scm_unused_struct*) (swig-engine.cpp:38703)
...
The expected results changed with commit 80f7e60f49.
At the same time, improve readability of test results by
assigning a tag and ordering expected vs actual correctly.
The price import will now throw warnings if there are
invalid prices. The previous logic would 'auto-next' in this
case, only holding if the parse-file phase threw warnings.
This change insures that these warnings are seen.
With private data members, replacing direct member access with
accessor functions and refactoring functionality away from the
Model, View, and Controller container classes to the classes
that own the members.
This removes the need for RTTI inspection as regular virtual
function dispatch accounts for differences in Entry classes.
Replace multiple-responsibility function in the wrong class with a
single-responsibility function in the right class.
Changes the signature of a couple of PageStockValue functions.
Setting happens via callbacks and they were handed direct access
to the member variables so the validation wasn't happening.
Validation also requires a logger and passing that to the callbacks
would be hard.
It's StockEntry's responsibility not Model's. This lets us remove
the model parameter from PageStockAmount::prepare. It also requires
that we use StockEntry's set_amount method instead of just setting
m_amount it StockAssistantTest::instantiate_model.
Cash in lieu must be reported as a separate transaction. There was
already a note about that in reverse splits, apply it to regular
splits.
Add suggestion to enter a placeholder number when one can't
immediately calculate the capital gain on a sale or cover buy.
* Get the sign right when calculating new shares
* Fix displaying values and units on the summary page
* Don't display "missing" for values when the user skips
entering a 0 value.
* Create the Stock-account's fees split (when capitalizing)
and cap-gains split.
John Ralls
Arve Eriksson
Giuseppe Foti
Zdenko Podobný
Jeremy White
Richard Cohen
Luna Jernberg
Christopher Lam