Build the pruned list with cons, not append.

It is 10x faster against a large dataset. Insight from Christopher Lam.
3 years ago · 9cacaa72e8
parent af11a549e3
commit 9cacaa72e8
1 changed files with 2 additions and 1 deletions
--- a/gnucash/import-export/qif-imp/qif-to-gnc.scm
+++ b/gnucash/import-export/qif-imp/qif-to-gnc.scm
@ -499,10 +499,11 @@
                          (G_ (format #f "Warning: cannot find commodity for symbol ~a." current-symbol))))))
            (if (not (equal? commodity #f))
                (if (not (duplicate-price? pricedb commodity default-currency price))
-                    (set! pruned-prices (append pruned-prices (list price)))
+                    (set! pruned-prices (cons price pruned-prices))
                    (set! pruned-price-count (+ 1 pruned-price-count))))
            (update-progress))
         sorted-prices)
+        (set! pruned-prices (reverse pruned-prices))

        (if progress-dialog
            (begin