5219 Commits (ef4d8dd4e233d3456d03be7e9b73c24f00a1c8be)

Author	SHA1	Message	Date
Sam Dunne	628743b24c	Add ability to skip chef registration ... This change allows a user to skip the bootstrap stage for a machine.	10 years ago
Sander van Harmelen	c307dc9557	Accept both slices and strings in vault_json (#9114) ... Fixes #9105 by allowing the `vault_json` to contain either slices or strings. And fixes #8932 by changing to way we cleanup the user key.	10 years ago
clint shryock	de3a7b5d20	give security groups their own sgProtocolIntegers methodw	10 years ago
clint shryock	2cc28f6137	revert netacl protocolIntegers change from 45da08c67f	10 years ago
clint shryock	6282c0fabf	provider/aws: Regression test for NetAcl + ESP protocol	10 years ago
James Nugent	506268aabe	Merge pull request #9035 from apparentlymart/tls-cert-request-resource ... Restore tls_cert_request to being a managed resource	10 years ago
Clint	7337a346ec	provider/aws: Fix issue with updating ELB subnets for subnets in the same AZ (#9131) ... * provider/aws: Regression test for #9120 * provider/aws: Fix issue with updating ELB subnets for subnets in the same AZ	10 years ago
Paul Stack	5f8cd8e69f	Merge pull request #9101 from hashicorp/b-aws-elasticache-panic-parameter-group ... provider/aws: Modifying the parameter_group_name of aws_elasticache_replication_group caused a panic	10 years ago
Paul Stack	10eb572437	Merge pull request #9050 from hashicorp/b-aws-ecr-delete-timeout ... provider/aws: Add retry logic to the aws_ecr_repository delete func	10 years ago
Paul Stack	9202bb4751	Merge pull request #9011 from hashicorp/f-aws-cloudfront-tags ... provider/aws: Add support for tags to aws_cloudfront_distribution	10 years ago
Paul Stack	b6718de299	Merge pull request #9010 from hashicorp/aws-elasticache-cluster-import ... Aws elasticache cluster import	10 years ago
Mickaël Canévet	1521517068	network_id is computed (#9102)	10 years ago
stack72	13cf370d07	provider/aws: Add support for tags to aws_cloudfront_distribution ... Fixes #8959 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_S3OriginWithTags' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/23 16:30:31 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCloudFrontDistribution_S3OriginWithTags -timeout 120m === RUN TestAccAWSCloudFrontDistribution_S3OriginWithTags --- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1234.66s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 1234.680s ```	10 years ago
stack72	b02a5c47ec	provider/aws: Support Import of aws_elasticache_cluster ... Initial tests were failing as follows: ``` === RUN TestAccAWSElasticacheCluster_importBasic --- FAIL: TestAccAWSElasticacheCluster_importBasic (362.66s) testing.go:265: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected. (map[string]string) { } (map[string]string) (len=2) { (string) (len=20) "parameter_group_name": (string) (len=20) "default.memcached1.4", (string) (len=22) "security_group_names.#": (string) (len=1) "0" } FAIL exit status 1 ``` The import of ElastiCache clusters helped to point out 3 things: 1. Currently, we were trying to set the parameter_group_name as follows: ``` d.Set("parameter_group_name", c.CacheParameterGroup) ``` Unfortunately, c.CacheParameterGroup is a struct not a string. This was causing the test import failure. So this had to be replaced as follows: ``` if c.CacheParameterGroup != nil { d.Set("parameter_group_name", c.CacheParameterGroup.CacheParameterGroupName) } ``` 2. We were trying to set the security_group_names as follows: ``` d.Set("security_group_names", c.CacheSecurityGroups) ``` The CacheSecurityGroups was actually a []* so had to be changed to work as follows: ``` if len(c.CacheSecurityGroups) > 0 { d.Set("security_group_names", flattenElastiCacheSecurityGroupNames(c.CacheSecurityGroups)) } ``` 3. We were trying to set the security_group_ids as follows: ``` d.Set("security_group_ids", c.SecurityGroups) ``` This is another []* and needs to be changed as follows: ``` if len(c.SecurityGroups) > 0 { d.Set("security_group_ids", flattenElastiCacheSecurityGroupIds(c.SecurityGroups)) } ``` This then allows the import test to pass as expected: ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSElasticacheCluster_importBasic' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/23 10:59:01 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSElasticacheCluster_importBasic -timeout 120m === RUN TestAccAWSElasticacheCluster_importBasic --- PASS: TestAccAWSElasticacheCluster_importBasic (351.96s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 351.981s ``` As a final test, I ran the basic ElastiCache cluster creation to make sure all passed as expected: ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSElasticacheCluster_basic' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/23 11:05:51 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSElasticacheCluster_basic -timeout 120m === RUN TestAccAWSElasticacheCluster_basic --- PASS: TestAccAWSElasticacheCluster_basic (809.25s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 809.267s ```	10 years ago
stack72	15c8534538	provider/aws: Add retry logic to the aws_ecr_repository delete func ... Fixes #8597 There was sometimes an issue where Terraform was deleting the ECR repository from the statefile before the reposity was actually deleted. Added retry logic for Terraform to wait for the repository to be deleted before proceeding with the statefile update ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcrRepository_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/26 12:46:57 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcrRepository_ -timeout 120m === RUN TestAccAWSEcrRepository_importBasic --- PASS: TestAccAWSEcrRepository_importBasic (17.86s) === RUN TestAccAWSEcrRepository_basic --- PASS: TestAccAWSEcrRepository_basic (16.40s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 34.288s ```	10 years ago
stack72	2efd93a67e	provider/aws: Modifying the parameter_group_name of ... aws_elasticache_replication_group caused a panic Fixes #9097 The update for `parameter_group_name` was trying to find the incorrect value to set `cache_parameter_group_name` - this is what was causing the panic ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_updateParameterGroup' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/28 11:17:30 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSElasticacheReplicationGroup_updateParameterGroup -timeout 120m === RUN TestAccAWSElasticacheReplicationGroup_updateParameterGroup --- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (903.90s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws903.931s ```	10 years ago
Paul Stack	d4dd615b52	Merge pull request #9052 from hashicorp/b-aws-rds-option-group ... provider/aws: aws_db_option_group flattenOptions failing due to missing values	10 years ago
stack72	df8ca94093	provider/aws: aws_db_option_group flattenOptions failing due to missing ... values Fixes #8332 Not all option_group parameters have values. For example, when you enable the MariaDB option_group, some of the settings have empty values (see screenshot) This PR adds a safety net on reading those values back to the statefile ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBOptionGroup_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/26 13:55:21 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBOptionGroup_ -timeout 120m === RUN TestAccAWSDBOptionGroup_importBasic --- PASS: TestAccAWSDBOptionGroup_importBasic (20.12s) === RUN TestAccAWSDBOptionGroup_basic --- PASS: TestAccAWSDBOptionGroup_basic (18.45s) === RUN TestAccAWSDBOptionGroup_basicDestroyWithInstance --- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (597.90s) === RUN TestAccAWSDBOptionGroup_OptionSettings --- PASS: TestAccAWSDBOptionGroup_OptionSettings (33.27s) === RUN TestAccAWSDBOptionGroup_sqlServerOptionsUpdate --- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (33.39s) === RUN TestAccAWSDBOptionGroup_multipleOptions --- PASS: TestAccAWSDBOptionGroup_multipleOptions (19.87s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 723.037s ```	10 years ago
Paul Stack	bf5039311b	Merge pull request #9049 from hashicorp/b-aws-r53-record-delete ... provider/aws: guard against aws_route53_record delete panic	10 years ago
clint shryock	2c7d4faf53	provider/google: remove debug spew statement	10 years ago
Paul Stack	f6ff349d6d	Merge pull request #8971 from BedeGaming/azurerm-sdk-4 ... provider/azurerm: update Azure SDK	10 years ago
Paul Stack	1cf9f41510	Merge pull request #9038 from kwilczynski/feature/error-reporting-aws_vpc_peering_connection ... provider/aws: Make sure that VPC Peering Connection in a failed state returns an error.	10 years ago
Joe Topjian	1e85d21dc4	Merge pull request #8948 from jfpucheu/PATCH_8735 ... Correct Proxy setting for openstack provider: issue 8735	10 years ago
Paul Stack	3840ff0f40	Merge pull request #8947 from dagnello/vsphere-vm-disks-detach ... vSphere: Adding 'detach_unknown_disks_on_delete' flag for VM resource	10 years ago
Davide Agnello	dfe1cacc9e	Adding 'detach_unknown_disks_on_delete' flag for VM resource ... Optional, defaults to false. If true, will detach disks not managed by Terraform VM resource prior to VM deletion. Issue: #8945	10 years ago
Paul Stack	bdb915693b	Merge pull request #9060 from TimeIncOSS/b-aws-aurora-encryption ... provider/aws: Make encryption in Aurora instances computed-only	10 years ago
Radek Simko	de03308b73	provider/aws: Make encryption in Aurora instances computed-only	10 years ago
stack72	054f46b1f9	provider/aws: Refresh AWS EIP association from state when not found ... Fixes #6758 We used to throw an error when this was the case - we should refresh from state so the association can be recreated ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEIPAssociation_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/26 16:42:37 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEIPAssociation_ -timeout 120m === RUN TestAccAWSEIPAssociation_basic --- PASS: TestAccAWSEIPAssociation_basic (272.92s) === RUN TestAccAWSEIPAssociation_disappears --- PASS: TestAccAWSEIPAssociation_disappears (119.62s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws392.559s ```	10 years ago
Paul Stack	a77d55c919	Merge pull request #8806 from optimisticanshul/8793-snapshot-identifier ... Changing snapshot_identifier on aws_db_instance resource should force…	10 years ago
stack72	a367f3550f	provider/aws: guard against aws_route53_record delete panic ... Fixes #9025 We were assuming there would always be a changeInfo record and then dereferencing the ID. This wasn't always the case (As noted in #9025) where it was a delete rather than a delete / create action ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRoute53Record_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/26 11:26:43 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute53Record_ -timeout 120m === RUN TestAccAWSRoute53Record_basic --- PASS: TestAccAWSRoute53Record_basic (114.99s) === RUN TestAccAWSRoute53Record_basic_fqdn --- PASS: TestAccAWSRoute53Record_basic_fqdn (126.64s) === RUN TestAccAWSRoute53Record_txtSupport --- PASS: TestAccAWSRoute53Record_txtSupport (113.25s) === RUN TestAccAWSRoute53Record_spfSupport --- PASS: TestAccAWSRoute53Record_spfSupport (112.89s) === RUN TestAccAWSRoute53Record_generatesSuffix --- PASS: TestAccAWSRoute53Record_generatesSuffix (113.29s) === RUN TestAccAWSRoute53Record_wildcard --- PASS: TestAccAWSRoute53Record_wildcard (163.05s) === RUN TestAccAWSRoute53Record_failover --- PASS: TestAccAWSRoute53Record_failover (121.15s) === RUN TestAccAWSRoute53Record_weighted_basic --- PASS: TestAccAWSRoute53Record_weighted_basic (117.06s) === RUN TestAccAWSRoute53Record_alias --- PASS: TestAccAWSRoute53Record_alias (116.97s) === RUN TestAccAWSRoute53Record_s3_alias --- PASS: TestAccAWSRoute53Record_s3_alias (138.79s) === RUN TestAccAWSRoute53Record_weighted_alias --- PASS: TestAccAWSRoute53Record_weighted_alias (241.48s) === RUN TestAccAWSRoute53Record_geolocation_basic --- PASS: TestAccAWSRoute53Record_geolocation_basic (132.51s) === RUN TestAccAWSRoute53Record_latency_basic --- PASS: TestAccAWSRoute53Record_latency_basic (121.29s) === RUN TestAccAWSRoute53Record_TypeChange --- PASS: TestAccAWSRoute53Record_TypeChange (189.31s) === RUN TestAccAWSRoute53Record_empty --- PASS: TestAccAWSRoute53Record_empty (127.31s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 2050.012s ```	10 years ago
Paul Stack	01cef1a63c	Merge pull request #9029 from hashicorp/b-cloudwatch-dimensions-read ... provider/aws: Fix reading dimensions on cloudwatch alarms	10 years ago
Krzysztof Wilczynski	a2a2de5db2	Add test to check for failed state of the VPC Peering Connection. ... Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>	10 years ago
Krzysztof Wilczynski	a58650c980	Make sure that VPC Peering Connection in a failed state returns an error. ... This commit adds simple logic which allows for a VPC Peering Connection that is in a failed state (e.g. due to an overlapping IP address ranges, etc.), to report such failed state as an error, rather then waiting for the time out to occur. Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>	10 years ago
Evan Brown	0edb68ef5a	Merge pull request #8977 from sl1pm4t/b-gcs-storage-class ... provider/google: Add support for GCS StorageClass	10 years ago
Martin Atkins	804d714ff6	Restore tls_cert_request to being a managed resource ... In c244e5a6 this resource was converted to a data source, but that was a mistake since data sources are expected to produce stable results on each run, and yet certificate requests contain a random nonce as part of the signature. Additionally, using the data source as a managed resource through the provided compatibility shim was not actually working, since "Read" was trying to parse the private key out of a SHA1 hash of the key, which is what we place in state due to the StateFunc on that attribute. By restoring this we restore Terraform's ability to produce all of the parts of a basic PKI/CA, which is useful for creating dev environments and bootstrapping PKI for production environments.	10 years ago
Krzysztof Wilczynski	5af8c8080a	Fix. Handle missing AMI name when matching against image name. ... This commit fixes the issues where in a very rare cases the Amazon Machine Image (AMI) would not have an image name set causing regular expression match to fail with a nil pointer dereference. Also, the logic of if-else statements was simplified (reduced branching since return is used a lot). Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>	10 years ago
Paul Stack	979af97b52	Merge pull request #9031 from kjmkznr/b-aws-s3-lifecycle ... provider/aws: Fix failed remove S3 lifecycle_rule	10 years ago
Alexander Ekdahl	d2861be48e	Corrected Seoul S3 Website Endpoint	10 years ago
Alexander Ekdahl	ec1ee7f2be	Corrected Seoul S3 Website Endpoint Test	10 years ago
Kazunori Kojima	71f721cd3e	provider/aws: Fix failed remove S3 lifecycle_rule	10 years ago
Paul Hinze	2449b45087	provider/aws: Fix reading dimensions on cloudwatch alarms ... They're structs that need to be unrolled and d.Set was silently failing on them before. This enhances the basic test to cover the change.	10 years ago
Chris Marchesi	5af63c233e	provider/aws: Add query_string_cache_keys to aws_cloudfront_distribution ... Looks like AWS updated their API and now our tests are failing because QueryStringCacheKeys was not included in the distribution configuration. This adds support for specifying query string cache keys in the CloudFront distribution configuration, which ensures that only a subset of query string keys are actually cached when forwarding query strings, possibly improving performance.	10 years ago
Chris Marchesi	c2b44217dd	provider/aws: Require CloudFront S3 origin origin_access_identity ... This fixes an issue where an empty s3_origin_config could be supplied to aws_cloudfront_distribution, "correctly" setting an empty default value. Unfortunately the rest of the CloudFront structure helper functions are not equipped to deal with this kind of scenario, and TF produces spurious diffs upon future runs. This removes the default and makes origin_access_identity required when specifying s3_origin_config. Note that it has always been intended behaviour that if someone does not want to use an origin access identity, that s3_origin_config should not be specified at all. This behaviour still works, as should be evident by the (still) passing tests. Fixes hashicorp/terraform#7930.	10 years ago
Chris Marchesi	ec2b345ed0	provider/aws: Enable aws_cloudfront_distribution HTTP/2 ... Added http_version to aws_cloudfront_distribution, which allows selection of the maximum HTTP version to use in the distribution. Defaults to http2. Fixes hashicorp/terraform#8730.	10 years ago
stack72	cea685099e	Merge branch 'elasticache-cluster-import' of https://github.com/AMeng/terraform into AMeng-elasticache-cluster-import	10 years ago
Clint	b7ad602993	provider/aws: Fix importing of EIP by IP address (#8970) ... * provider/aws: Fix importing of EIP by IP address EIPs are meant to be imported by their allocation id, however, importing by their EIP *appears* to work because this API actually accepts IP lookup, despite the documentation asking for the allocation id. This PR does: - update docs on how to import EIPs - fix case if user imported by IP, to switch to using the alloc id for the resource id I chose not to document that looking up by IP is a method of import, because the AWS API docs do not explicitly say that looking up by IP is OK, so I'd rather people not do it if it's not documented to stay that way. Alternatively, we could parse the resource ID and reject it (remove from state with error/warning) if it doesn't match the `eipalloc-*` format, but I thought this was a bit better UX. * fix issue with swapping IDs on EC2 Classic * update docs * update comment	10 years ago
Clint	becdfef87b	provider/aws: Wait for Spot Fleet to drain before removing from state (#8938) ... * provider/aws: Wait for Spot Fleet to drain before removing from state Ensures the spot fleet is drained before reporting successful destroy and moving on * remove unreachable code * hack to sleep and test regression/leak * fix broken english in warning	10 years ago
Paul Stack	ecabebf5e6	Merge pull request #8989 from hashicorp/b-aws-alb-protocol-change-forcenew ... provider/aws: VPC ID, Port, Protocol and Name change on aws_alb_target_group will ForceNew resource	10 years ago
Paul Stack	5cc4f17189	Merge pull request #8992 from kwilczynski/feature/check-error-aws_cloudformation_stack ... provider/aws: Handle JSON parsing error in the ReadFunc for various JSON documents.	10 years ago
Krzysztof Wilczynski	828a8f4729	provider/aws: Handle JSON parsing error in the ReadFunc for various JSON documents. ... Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>	10 years ago