629 Commits (ea93b91a80201c19c00d12dfd6fddc46f443bd2a)

Author	SHA1	Message	Date
Mitchell Hashimoto	03931bfda9	helper/schema: ImportState must set ID on the resource data	10 years ago
Mitchell Hashimoto	445194ebdf	helper/schema: test ImportState	10 years ago
Mitchell Hashimoto	1685054a9a	helper/schema: cleaner way to store Ephemeral	10 years ago
Mitchell Hashimoto	84531a3fd5	helper/schema: sets Importable to true for resources that have importer	10 years ago
Mitchell Hashimoto	19609bde0e	helper/schema: can specify Importer on Resource, InternalValidate	10 years ago
Mitchell Hashimoto	b8121ea63e	helper/schema: Resource.Data to return a ResourceData for a Resource	10 years ago
Mitchell Hashimoto	4e9877179c	helper/schema: start the resource importer	10 years ago
James Nugent	7b6df27e4a	helper/schema: Read native maps from configuration ... This adds a test and the support necessary to read from native maps passed as variables via interpolation - for example: ``` resource ...... { mapValue = "${var.map}" } ``` We also add support for interpolating maps from the flat-mapped resource config, which is necessary to support assignment of computed maps, which is now valid. Unfortunately there is no good way to distinguish between a list and a map in the flatmap. In lieu of changing that representation (which is risky), we assume that if all the keys are numeric, this is intended to be a list, and if not it is intended to be a map. This does preclude maps which have purely numeric keys, which should be noted as a backwards compatibility concern.	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
Mitchell Hashimoto	35c87836b4	core: Add terraform_version to state ... This adds a field terraform_version to the state that represents the Terraform version that wrote that state. If Terraform encounters a state written by a future version, it will error. You must use at least the version that wrote that state. Internally we have fields to override this behavior (StateFutureAllowed), but I chose not to expose them as CLI flags, since the user can just modify the state directly. This is tricky, but should be tricky to represent the horrible disaster that can happen by enabling it. We didn't have to bump the state format version since the absense of the field means it was written by version "0.0.0" which will always be older. In effect though this change will always apply to version 2 of the state since it appears in 0.7 which bumped the version for other purposes.	10 years ago
Paul Hinze	b4df304b47	helper/schema: Normalize bools to "true"/"false" in diffs ... For a long time now, the diff logic has relied on the behavior of `mapstructure.WeakDecode` to determine how various primitives are converted into strings. The `schema.DiffString` function is used for all primitive field types: TypeBool, TypeInt, TypeFloat, and TypeString. The `mapstructure` library's string representation of booleans is "0" and "1", which differs from `strconv.FormatBool`'s "false" and "true" (which is used in writing out boolean fields to the state). Because of this difference, diffs have long had the potential for cosmetically odd but semantically neutral output like: "true" => "1" "false" => "0" So long as `mapstructure.Decode` or `strconv.ParseBool` are used to interpret these strings, there's no functional problem. We had our first clear functional problem with #6005 and friends, where users noticed diffs like the above showing up unexpectedly and causing troubles when `ignore_changes` was in play. This particular bug occurs down in Terraform core's EvalIgnoreChanges. There, the diff is modified to account for ignored attributes, and special logic attempts to handle properly the situation where the ignored attribute was going to trigger a resource replacement. That logic relies on the string representations of the Old and New fields in the diff to be the same so that it filters properly. So therefore, we now get a bug when a diff includes `Old: "0", New: "false"` since the strings do not match, and `ignore_changes` is not properly handled. Here, we introduce `TypeBool`-specific normalizing into `finalizeDiff`. I spiked out a full `diffBool` function, but figuring out which pieces of `diffString` to duplicate there got hairy. This seemed like a simpler and more direct solution. Fixes #6005 (and potentially others!)	10 years ago
Mitchell Hashimoto	d85df63526	providers/aws: aws_instance id-only	10 years ago
Mitchell Hashimoto	e0da21d381	helper/resource: make id-only check opt-in ... As I've been working through the resources, I'm finding that a lot are going to need some serious work. Given we have hundreds, I think it might be prudent to make this opt-in for now and we can revisit automatic/opt-out at some future point. Importability will likely be opt-in it appears so this will match up with that.	10 years ago
Mitchell Hashimoto	ff7b58f032	providers/aws: peering connection id-only test settings	10 years ago
Mitchell Hashimoto	0ef1b3b84a	providers/aws: response value for DescribeVpcAttribute needs to be ... .Value	10 years ago
Mitchell Hashimoto	1db1bf6639	helper/resource: use the full config for id-only checks ... Originally I used an empty config module. This caused problems since important provider configurations weren't available. Instead, I now set it to use the full config. This isn't an issue since the attributes themselves aren't available to Refresh anyways.	10 years ago
Mitchell Hashimoto	0c8b0bff2c	helper/resource: can specify specific name to id refresh test	10 years ago
Mitchell Hashimoto	1a9fae6b2e	helper/resource: can disable ID refresh check	10 years ago
Mitchell Hashimoto	35f4201b9e	providers/aws: instance_tenancy is computed, set	10 years ago
Mitchell Hashimoto	f2c4f8e9ba	helper/resource: fix tests	10 years ago
Mitchell Hashimoto	5c4f78796b	helper/resource: don't need to id-only check if no test steps	10 years ago
Mitchell Hashimoto	a285c04dc9	helper/resource: only verify id-only run if no error	10 years ago
Mitchell Hashimoto	baac14aaeb	helper/resource: guard id-only by acc var	10 years ago
Mitchell Hashimoto	cb32cb8947	helper/resource: error if id-only check didn't run	10 years ago
Mitchell Hashimoto	86e0c853db	helper/resource: test for failing id-only refresh check	10 years ago
Mitchell Hashimoto	060b43fbd9	helper/resource: remove debug	10 years ago
Mitchell Hashimoto	4f6edf4fe4	helper/resource: id-only refresh testing	10 years ago
James Nugent	cb8a0549e1	Merge pull request #5757 from hashicorp/f-output-testing ... Add TestCheckOutput helper to resource testing	10 years ago
James Nugent	35f9d2e081	Add TestCheckOutput helper to resource testing ... This allows outputs in test configuration to have test functions written conveniently. Useful for azurerm_template_deployment.	10 years ago
Radek Simko	bf9f5879ca	helper/resource: Remove NotFoundError function	10 years ago
James Nugent	f946695187	Merge pull request #5444 from TimeIncOSS/f-aws-logs-metric-filter ... provider/aws: Add support for CloudWatch Log Metric Filter	10 years ago
Paul Hinze	c3e27b3e0a	provider/test: a test provider ... Here we also introduce a `test` provider meant as an aid to exposing via automated tests issues involving interactions between `helper/schema` and Terraform core. This has been helpful so far in diagnosing `ignore_changes` problems, and I imagine it will be helpful in other contexts as well. We'll have to be careful to prevent the `test` provider from becoming a dumping ground for poorly specified tests that have a clear home elsewhere. But for bug exposure I think it's useful to have.	10 years ago
Radek Simko	fd2fcaf1d5	helper/resource: Implement resource-wide NotFoundError	10 years ago
Paul Hinze	25fce81bfc	provider/aws: log HTTP req/resp at DEBUG level ... This should be quite helpful in debugging aws-sdk-go operations. Required some tweaking around the `helper/logging` functions to expose an `IsDebugOrHigher()` helper for us to use.	10 years ago
Radek Simko	034287fdc2	helper/resource: Error shouldn't be returned in case of success	10 years ago
Radek Simko	8582f4df9f	helper/resource: Fix TestRetry	10 years ago
Paul Hinze	108ccf0007	builtin: Refactor resource.Retry to clarify return ... Change the `RetryFunc` from a plain `error` return type to a specialized `RetryError` which must decide whether it is retryable or not. Add `RetryableError` / `NonRetryableError` factory functions that callers are meant to use to build up these errors. This makes it eminently clear whether or not a given error is retryable from inside the client code. Goal here is to _not_ change any behavior, simply reflect the existing behavior with the new, clearer, API.	10 years ago
Paul Hinze	5160578e18	helper/resource: restore retval of resource.Retry on timeout ... In #4700 while fixing a data race I made an incorrect assumption about the return value of StateChangeConf, and ended up changing the behavior in the timeout case to always return: > timeout while waiting for state to become '[success]' When it used to capture the "most recent error" from the function itself. It's much more useful to see that error bubbling up, so here we revert to pulling it out of the function as we did before, and we protect against the data race with a good old fashioned mutex.	10 years ago
Martin Atkins	c1ce8ff31a	Merge pull request #5218 from paybyphone/paybyphone_set_maxitems ... Add MaxItems attribute to Schema	10 years ago
Radek Simko	8bdd92187c	Merge pull request #4446 from TimeIncOSS/f-schema-new-resource ... helper/schema: Allow identification of a new resource in update func	10 years ago
Paul Hinze	bba8a79a52	acctests: log a line w/ the non-empty plan ... Helpful when iterating on a drift test. Eventually I think this assertion could be fanned out to something much more targeted like: ExpectAttributeDiff(resource, attr, oldval, newval) But this is a step in the right direction.	10 years ago
Chris Marchesi	8c5354b7dc	Add MaxItems attribute to Schema ... * MaxItems defines a maximum amount of items that can exist within a TypeSet or TypeList. Specific use cases would be if a TypeSet is being used to wrap a complex structure, however more than one instance would cause instability.	10 years ago
Radek Simko	ab73f2b762	helper: Add StateChangeConf.ContinuousTargetOccurence (int)	10 years ago
Trevor Pounds	0cd0ff0f8e	Use built-in schema.HashString.	10 years ago
Mitchell Hashimoto	4576eaa966	helper/schema: replace config/lang	10 years ago
Mitchell Hashimoto	55a9b1ba4c	helper/diff: replace ocnfig/lang	10 years ago
Paul Hinze	24048b4dca	providers: Mention check number when acctest fails	10 years ago
Paul Hinze	da872eee66	Merge pull request #4864 from hashicorp/phinze/aws-min-elb-cap-regression ... aws: undeprecate min_elb_capacity; restore min capacity waiting	10 years ago
Paul Hinze	c70eab6500	aws: undeprecate min_elb_capacity; restore min capacity waiting ... It was a mistake to switched fully to `==` when activating waiting for capacity on updates in #3947. Users that didn't set `min_elb_capacity == desired_capacity` and instead treated it as an actual "minimum" would see timeouts for every create, since their target numbers would never be reached exactly. Here, we fix that regression by restoring the minimum waiting behavior during creates. In order to preserve all the stated behavior, I had to split out different criteria for create and update, criteria which are now exhaustively unit tested. The set of fields that affect capacity waiting behavior has become a bit of a mess. Next major release I'd like to rework all of these into a more consistently named block of config. For now, just getting the behavior correct and documented. (Also removes all the fixed names from the ASG tests as I was hitting collision issues running them over here.) Fixes #4792	10 years ago
Paul Hinze	069425a700	consul: Fix several problems w/ consul_keys update ... Implementation notes: * The hash implementation was not considering key value, causing "diffs did not match" errors when a value was updated. Switching to default HashResource implementation fixes this * Using HashResource as a default exposed a bug in helper/schema that needed to be fixed so the Set function is picked up properly during Read * Stop writing back values into the `key` attribute; it triggers extra diffs when `default` is used. Computed values all just go into `var`. * Includes a state migration to prevent unnecessary diffs based on "key" attribute hashcodes changing. In the tests: * Switch from leaning on the public demo Consul instance to requiring a CONSUL_HTTP_ADDR variable be set pointing to a `consul agent -dev` instance to be used only for testing. * Add a test that exposes the updating issues and covers the fixes Fixes #774 Fixes #1866 Fixes #3023	10 years ago
Paul Hinze	0b11ace9ac	Merge pull request #4788 from hashicorp/phinze/skip-remote-test-option ... tests: allow opt-out of remote tests via env var	10 years ago
Paul Hinze	6bafa74011	tests: allow opt-out of remote tests via env var ... Adds the `TF_SKIP_REMOTE_TESTS` env var to be used in cases where the `http.Get()` smoke test passes but the network is not able to service the needs of the tests. Fixes #4421	10 years ago
Ian Duffy	47ac10d66b	Change resource.StateChangeConf to use an array for target states ... Signed-off-by: Ian Duffy <ian@ianduffy.ie>	10 years ago
Paul Hinze	d59db52f06	helper/resource: Fix data race in resource.Retry ... The implementation was attempting to capture the error using a scoped variable reference, but the error value is already exposed via the return value of `WaitForState()`. Using that instead fixes the data race. Fixes the following data race: ``` ================== WARNING: DATA RACE Read by goroutine 74: github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:35 +0x284 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc Previous write by goroutine 90: github.com/hashicorp/terraform/helper/resource.Retry.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:20 +0x87 github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:83 +0x284 Goroutine 74 (running) created at: testing.RunTests() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:561 +0xaa3 testing.(*M).Run() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:494 +0xe4 main.main() github.com/hashicorp/terraform/helper/resource/_test/_testmain.go:84 +0x20f Goroutine 90 (running) created at: github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:127 +0x283 github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:34 +0x276 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc ================== ```	10 years ago
Paul Hinze	a8d2ad3ebe	refactor s3 bucket test to expect non-empty plan ... pushing to master but paging @catsby for post-hoc review	10 years ago
Paul Hinze	e916bd1527	provider/google: enchance storage acctests to avoid collisions ... Generate bucket names and object names per test instead of once at the top level. Should help avoid failures like this one: https://travis-ci.org/hashicorp/terraform/jobs/100254008 All storage tests checked on this commit: ``` TF_ACC=1 go test -v ./builtin/providers/google -run TestAccGoogleStorage === RUN TestAccGoogleStorageBucketAcl_basic --- PASS: TestAccGoogleStorageBucketAcl_basic (8.90s) === RUN TestAccGoogleStorageBucketAcl_upgrade --- PASS: TestAccGoogleStorageBucketAcl_upgrade (14.18s) === RUN TestAccGoogleStorageBucketAcl_downgrade --- PASS: TestAccGoogleStorageBucketAcl_downgrade (12.83s) === RUN TestAccGoogleStorageBucketAcl_predefined --- PASS: TestAccGoogleStorageBucketAcl_predefined (4.51s) === RUN TestAccGoogleStorageObject_basic --- PASS: TestAccGoogleStorageObject_basic (3.77s) === RUN TestAccGoogleStorageObjectAcl_basic --- PASS: TestAccGoogleStorageObjectAcl_basic (4.85s) === RUN TestAccGoogleStorageObjectAcl_upgrade --- PASS: TestAccGoogleStorageObjectAcl_upgrade (7.68s) === RUN TestAccGoogleStorageObjectAcl_downgrade --- PASS: TestAccGoogleStorageObjectAcl_downgrade (7.37s) === RUN TestAccGoogleStorageObjectAcl_predefined --- PASS: TestAccGoogleStorageObjectAcl_predefined (4.16s) PASS ok github.com/hashicorp/terraform/builtin/providers/google 68.275s ```	10 years ago
Paul Hinze	028664a015	provider/digitalocean: acctest improvements ... * Add SSH Keys to all droplets in tests, this prevents acctests from spamming account owner email with root password details * Add a new helper/acctest package to be a home for random string / int implementations used in tests. * Insert some random details into record tests to prevent collisions * Normalize config style in tests to hclfmt conventions	10 years ago
Radek Simko	4c6ceef9b8	helper/schema: Allow identification of a new resource in update func	10 years ago
James Nugent	e976d6e787	testing: Use a copy of pre-destroy state in destroy check ... In the acceptance testing framework, it is neccessary to provide a copy of the state _before_ the destroy is applied to the check in order that it can loop over resources to verify their destruction. This patch makes a deep copy of the state prior to applying test steps which have the Destroy option set and then passes that to the destroy check.	11 years ago
Paul Hinze	edaf5795a5	Merge pull request #3257 from fatih/fix-nil-setting-schema ... schema: delete non existing values	11 years ago
Paul Hinze	4bd4e18def	core: use same logging setup for acctests ... We weren't doing any log setup for acceptance tests, which made it difficult to wrangle log output in CI. This moves the log setup functions we use in `main` over into a helper package so we can use them for acceptance tests as well. This means that acceptance tests will by default be a _lot_ quieter, only printing out actual test output. Setting `TF_LOG=trace` will restore the full prior noise level. Only minor behavior change is to make `ioutil.Discard` the default return value rather than a `nil` that needs to be checked for.	11 years ago
Paul Hinze	99244c5597	helper/schema: skip provider input for deprecated fields ... There's no reason that a field that's been deprecated should ever prompt. fixes #4033	11 years ago
Paul Hinze	f1e7cec566	Merge pull request #3992 from svanharmelen/f-change-sets ... core: change set internals and make (extreme) performance improvements	11 years ago
Sander van Harmelen	ef4726bd50	Change Set internals and make (extreme) performance improvements ... Changing the Set internals makes a lot of sense as it saves doing conversions in multiple places and gives a central place to alter the key when a item is computed. This will have no side effects other then that the ordering is now based on strings instead on integers, so the order will be different. This will however have no effect on existing configs as these will use the individual codes/keys and not the ordering to determine if there is a diff or not. Lastly (but I think also most importantly) there is a fix in this PR that makes diffing sets extremely more performand. Before a full diff required reading the complete Set for every single parameter/attribute you wanted to diff, while now it only gets that specific parameter. We have a use case where we have a Set that has 18 parameters and the set consist of about 600 items (don't ask 😉). So when doing a diff it would take 100% CPU of all cores and stay that way for almost an hour before being able to complete the diff. Debugging this we learned that for retrieving every single parameter it made over 52.000 calls to `func (c *ResourceConfig) get(..)`. In this function a slice is created and used only for the duration of the call, so the time needed to create all needed slices and on the other hand the time the garbage collector needed to clean them up again caused the system to cripple itself. Next to that there are also some expensive reflect calls in this function which also claimed a fair amount of CPU time. After this fix the number of calls needed to get a single parameter dropped from 52.000+ to only 2! 😃	11 years ago
Paul Hinze	c7dc1c10a3	helper/schema: skip StateFunc when value is nil ... This takes the nil checking burden off of StateFunc. fixes #3586, see that issue for further discussion	11 years ago
Paul Hinze	938281024f	helper/schema: name test cases w/ strings ... I promised myself that next time I jumped in this file I'd fix this up. Now we don't have to manually index the file with comments, we can just add descriptive names to the test cases!	11 years ago
Paul Hinze	6b6b5a43c3	provider/aws: serialize SG rule access to fix race condition ... Because `aws_security_group_rule` resources are an abstraction on top of Security Groups, they must interact with the AWS Security Group APIs in a pattern that often results in lots of parallel requests interacting with the same security group. We've found that this pattern can trigger race conditions resulting in inconsistent behavior, including: * Rules that report as created but don't actually exist on AWS's side * Rules that show up in AWS but don't register as being created locally, resulting in follow up attempts to authorize the rule failing w/ Duplicate errors Here, we introduce a per-SG mutex that must be held by any security group before it is allowed to interact with AWS APIs. This protects the space between `DescribeSecurityGroup` and `Authorize*` / `Revoke*` calls, ensuring that no other rules interact with the SG during that span. The included test exposes the race by applying a security group with lots of rules, which based on the dependency graph can all be handled in parallel. This fails most of the time without the new locking behavior. I've omitted the mutex from `Read`, since it is only called during the Refresh walk when no changes are being made, meaning a bunch of parallel `DescribeSecurityGroup` API calls should be consistent in that case.	11 years ago
Radek Simko	1e3cc7b33f	helper: Remove url helper (moved to go-getter)	11 years ago
Paul Hinze	7ffa66d1a5	ssh: accept private key contents instead of path ... We've been moving away from config fields expecting file paths that Terraform will load, instead prefering fields that expect file contents, leaning on `file()` to do loading from a path. This helps with consistency and also flexibility - since this makes it easier to shift sensitive files into environment variables. Here we add a little helper package to manage the transitional period for these fields where we support both behaviors. Also included is the first of several fields being shifted over - SSH private keys in provisioner connection config. We're moving to new field names so the behavior is more intuitive, so instead of `key_file` it's `private_key` now. Additional field shifts will be included in follow up PRs so they can be reviewed and discussed individually.	11 years ago
James Nugent	f4c03ec2a6	Reflect new comment format in stringer.go ... As of November 8th 2015, (4b07c5ce8a), the word "Code" is prepended to the comments in Go source files generated by the stringer utility.	11 years ago
Martin Atkins	a67182543c	Nicer error when list/map assigned to string argument. ... Previous this would return the following sort of error: expected type 'string', got unconvertible type '[]interface {}' This is the raw error returned by the underlying mapstructure library. This is not a helpful error message for anyone who doesn't know Go's type system, and it exposes Terraform's internals to the UI. Instead we'll catch these cases before we try to use mapstructure and return a more straightforward message. By checking the type before the IsComputed exception this also avoids a crash caused when the assigned value is a computed list. Otherwise the list of interpolations is allowed through here and then crashes later during Diff when the value is not a primitive as expected.	11 years ago
Mitchell Hashimoto	344e7c26b5	fix a bunch of tests from go-getter import	11 years ago
Paul Hinze	2a179d1065	helper/schema: ValidateFunc support for maps	11 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Martin Atkins	cc8e8a55de	helper/schema: Default hashing function for sets ... A common issue with new resource implementations is not considering parts of a complex structure that's used inside a set, which causes quirky behavior. The schema helper has enough information to provide a default reasonable implementation of a set function that includes all non-computed attributes in a deterministic way. Here we implement such a function and use it when no explicit hashing function is provided. In order to achieve this we encapsulate the construction of the zero value for a schema in a new method schema.ZeroValue, which allows us to put the fallback logic to the new default function in a single spot. It is no longer valid to use &Set{F: schema.Set} and all uses of that construct should be replaced with schema.ZeroValue().(*Set) .	11 years ago
Martin Atkins	3fde993978	Merge #3336: Remove local multierror package. ... Instead, use ``github.com/hashicorp/go-multierror``.	11 years ago
Radek Simko	641b701830	schema: Make validation more strict	11 years ago
Sander van Harmelen	2ba8dc38fa	Switch to go-multierror ... It seems there are 4 locations left that use the `helper/multierror` package, where the rest is TF settled on the `hashicorp/go-multierror` package. Functionally this doesn’t change anything, so I suggest to delete the builtin version as it can only cause confusion (both packages have the same name, but are still different types according to Go’s type system.	11 years ago
Fatih Arslan	f269d4fc8c	schema: add test for nil string case	11 years ago
Fatih Arslan	8e7fc240f9	schema: delete non existing values ... We need to set the value to an empty value so the state file does indeed change the value. Otherwise the obsolote value is still intact and doesn't get changed at all. This means `terraform show` still shows the obsolote value when the particular value is not existing anymore. This is due the AWS API which is returning a null instead of an empty string.	11 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Paul Hinze	7eb72e7a12	helper/schema: record schema version when destroy fails ... This was just a missed exit from the resource.Apply function - subsequent refreshes would add the SchemaVersion back into the state, but having the state recorded once without the meta information can cause problems with Atlas's remote state checksumming.	11 years ago
Clint	f979fd7dee	Merge pull request #2571 from TimeIncOSS/f-aws-autogenerated-elb-name ... provider/aws: Allow ELB name to be generated	11 years ago
Radek Simko	9882cc59d8	aws: Add regression test for renaming ecs_cluster	11 years ago
Sander van Harmelen	4a8ef78d33	Fixes #2676 by prefixing all Windows commands ... By prefixing them with `cmd /c` it will work with both `winner` and `ssh` connection types. This PR also reverts some bad stringer changes made in PR #2673	11 years ago
Sander van Harmelen	97fd4f5b7d	Tweaking the tests	11 years ago
Paul Hinze	5c38456b05	core: don't prompt for variables with defaults ... In `helper/schema` we already makes a distinction between `Default` which is always applied and `InputDefault` which is displayed to the user for an empty field. But for variables we just have `Default` which is treated like `InputDefault`. This changes it to _not_ prompt the user for a value when the variable declaration includes a default. Treating this as a UX bugfix and the "don't prompt for variables w/ defaults set" behavior as the originally expected behavior we were failing to honor. Added an already-passing test to verify and cover the `helper/schema` behavior. Perhaps down the road we can add a `input_default` attribute to variables to allow similar behavior to `helper/schema` in variables, but for now just sticking with the fix. Fixes #2592	11 years ago
Radek Simko	70b7243dd6	helper: Add resource.PrefixedUniqueId	11 years ago
Mitchell Hashimoto	2f08a2bb15	Merge pull request #2507 from hashicorp/b-set-remove ... helper/schema: diff should include removed set items [GH-1823]	11 years ago
Mitchell Hashimoto	0100d4139b	helper/schema: clean up style	11 years ago
Mitchell Hashimoto	6e509aedcb	helper/schema: diff should include removed set items [GH-1823]	11 years ago
Paul Hinze	7238b3b4af	core: encapsulate representation of StringList ... Now the only code that cares about how StringLists are represented lives inside string_list.go ...which gives us the ability to change it! :)	11 years ago
Paul Hinze	10b3abf405	config: introduce StringList to abstract over list hack ... This is the initial pure "all tests passing without a diff" stage. The plan is to change the internal representation of StringList to include a suffix delimiter, which will allow us to recognize empty and single-element lists.	11 years ago
Radek Simko	6fdbca8e58	Merge pull request #2466 from TimeIncOSS/f-schema-field-name-validate ... schema: Add field name to ValidateFunc	11 years ago
Mitchell Hashimoto	6b7c2bcb35	Merge pull request #2450 from hashicorp/b-schema-validate-type ... helper/schema: validate objects are objects [GH-2166]	11 years ago
Mitchell Hashimoto	630646335f	Merge pull request #2451 from hashicorp/b-provider-validate ... helper/schema: internal validate as part of provider validation	11 years ago
Radek Simko	92db4802b6	schema: Add field name to ValidateFunc	11 years ago
Mitchell Hashimoto	4e7fcd4f42	helper/schema: test that validatefunc is not called with computed vals	11 years ago
Mitchell Hashimoto	e36597cad7	helper/schema: internal validate as part of provider validation ... [GH-1291]	11 years ago
Mitchell Hashimoto	4f391902a0	helper/schema: validate objects are objects [GH-2166]	11 years ago
Paul Hinze	aa8cf572a8	Merge pull request #2265 from hashicorp/f-schema-validate-field ... Support arbitrary per-field schema validation	11 years ago
Paul Hinze	385b17d679	provider/template: don't error when rendering fails in Exists ... The Exists function can run in a context where the contents of the template have changed, but it uses the old set of variables from the state. This means that when the set of variables changes, rendering will fail in Exists. This was returning an error, but really it just needs to be treated as a scenario where the template needs re-rendering. fixes #2344 and possibly a few other template issues floating around	11 years ago
Paul Hinze	a4912cc51f	helper/schema: limit ValidateFunc to primitives for now ... I couldn't see a simple path get this working for Maps, Sets, and Lists, so lets land it as a primitive-only schema feature. I think validation on primitives comprises 80% of the use cases anyways.	11 years ago
Paul Hinze	49352db26f	helper/schema: skip ValidateFunc on other errors ... Guarantees that the `interface{}` arg to ValidateFunc is the proper type, allowing implementations to be simpler. Finish the docstring on `ValidateFunc` to call this out. /cc @mitchellh	11 years ago
Paul Hinze	61fee6735d	helper/schema: ValidateFunc ... Allows provider authors to implement arbitrary per-field validation warnings or errors.	11 years ago
Svend Sorensen	943bf3c00a	Use name of function in comment string ... Name of function is Difference, not Differences.	11 years ago
Clint Shryock	78e7519efa	Updates from go generate	11 years ago
Sam Boyer	b82bd0c280	Condense switch fallthroughs into expr lists	11 years ago
Mitchell Hashimoto	dd24ed4b76	helper/schema: blank ID refresh doesn't exist [GH-1905]	11 years ago
Justin Campbell	bb14bfa657	helper/schema: call InternalValidate w/ schemaMap{}	11 years ago
Paul Hinze	1e3d1b07e6	helper/schema: validate ConflictsWith against top-level ... The runtime impl of ConfictsWith uses Resource.Get(), which makes it work with any other attribute of the resource - the InternalValidate was only checking against the local schemaMap though, preventing subResource from using ConflictsWith properly. It's a lot of wiring and it's a bit ugly, but it's not runtime code, so I'm a bit less concerned about that aspect. This should take care of the problem mentioned in #1909	11 years ago
Paul Hinze	a96a3372c6	provider/template: don't diff when there's no diff ... This reworks the template lifecycle a bit such that we get nicer diff behavior. First, we tick ForceNew on for both filename and vars, so that the diff indicates that the template will be "replaced" on change. This is mostly cosmetic, but it also tracks conceptually with the fact that the identifier we use is a hash of the contents, so any change essentially makes a "new resource". Second, we change the Exists implementation to only return `false` when there has been a change in the rendered template. This lets descendent resources see the computed value changing so that they'll properly trigger in the plan. Fixes #1898 Refs #1866 (but does not fix, there's another deeper issue there)	11 years ago
Paul Hinze	bc9792f4c5	helper/schema: tweak test anotation	11 years ago
Paul Hinze	051ba78554	Merge pull request #1824 from hashicorp/b-write-count-for-empty-maps ... helper/schema: write "attr.#": "0" for empty maps	11 years ago
Andrew Langhorn	bb4f7415ca	Rename "The The" so that they can play songs again ... Other than the fact that "The the" doesn't really make any sense anywhere that it's used in Terraform, they're a post-punk band from the UK. Fixes "The The" so that they can get back to playing songs.	11 years ago
Paul Hinze	fbce3a3caa	helper/resource: don't fail test on config warnings ... AccTests like TestAccComputeInstance_basic_deprecated_network were failing early on "invalid config" when we are explictly testing behavior that we know generates warnings.	11 years ago
Paul Hinze	f2368428d3	helper/schema: write "attr.#": "0" for empty maps ... This fixes some perpetual diffs I saw in Atlas AccTests where an empty map (`map[string]interface{}{}`) was being `d.Set` for "metadata_full". Because the MapFieldWriter was not distinguishing between empty and nil, this trigger the "map delete" logic and no count was written to the state. This caused subsequent plans to improperly report a diff. Here we redefine the map delete functionality to explicitly trigger only on `nil`, so we catch the `.#` field for empty maps.	11 years ago
Paul Hinze	cebcee5c63	Merge pull request #1778 from josharian/template-provider ... providers: add template provider	11 years ago
Phil Frost	b082117e92	Implement AWS IAM resources ... - Users - Groups - Roles - Inline policies for the above three - Instance profiles - Managed policies - Access keys This is most of the data types provided by IAM. There are a few things missing, but the functionality here is probably sufficient for 95% of the cases. Makes a dent in #28.	11 years ago
Phil Frost	33183c078b	Implement a hash function for string sets ... Sets of strings are pretty common. Let's not duplicate the function necessary to create a set of strings in so many places.	11 years ago
Paul Hinze	a3101568c5	helper/schema: add clarifying GetOk test ... Wrote this test to verify behavior, committing and commenting to help me get the answer faster in the future.	11 years ago
Josh Bleecher Snyder	76bcac3031	providers/template: add tests, address review comments ... Do directory expansion on filenames. Add basic acceptance tests. Code coverage is 72.5%. Uncovered code is uninteresting and/or impossible error cases. Note that this required adding a knob to helper/resource.TestStep to allow transient resources.	11 years ago
Paul Hinze	1671f1e50c	Merge pull request #1762 from hashicorp/f-add-test-for-nested-set-statefunc ... helper/schema: add test for statefunc with nested sets	11 years ago
Paul Hinze	15c75c501f	Merge pull request #1483 from svanharmelen/f-winrm-support ... core: add WinRM support	11 years ago
Sander van Harmelen	c9e9e374bb	Adding some abstractions for the communicators ... This is needed as preperation for adding WinRM support. There is still one error in the tests which needs another look, but other than that it seems like were now ready to start working on the WinRM part…	11 years ago
Paul Hinze	88744d569f	helper/resource/testing: unit tests to cover #1770 ... Also clarified that final return value of testStep is now only for the happy path.	11 years ago
Paul Hinze	dbf6d1bd00	helper/resource: fix accidentaly swallowing of acctest step errors ... With #1757 I unwittingly reused an err variable, causing all test check errors to be swallowed. -_-	11 years ago
Paul Hinze	cb3cbffb19	helper/schema: add test for statefunc with nested sets ... refs #1759	11 years ago
Paul Hinze	149e52ad1f	helper/resource: verify refresh+plan after each step ... I forgot to add `Computed: true` when I made the "key_name" field optional in #1751. This made the behavior: * Name generated in Create and set as ID * Follow up plan (without refresh) was nice and empty * During refresh, name gets cleared out on Read, causing a bad diff on subsequent plans We can automatically catch bugs like this if we add yet another verification step to our resource acceptance tests -> a post Refresh+Plan that we verify is empty. I left the non-refresh Plan verification in, because it's important that _both_ of these are empty after an Apply.	11 years ago
Mitchell Hashimoto	b96027ac87	Merge pull request #1656 from tpounds/bug-fix-prevent-neg-hash-all-operations ... helper/schema: Prevent negative hashcodes for all set operations.	11 years ago
Phil Frost	bd8ac4fe5e	Better document StateChangeConf.WaitForState	11 years ago
Trevor Pounds	17b31925fe	Prevent negative hashcodes for all set operations.	11 years ago
Mitchell Hashimoto	10fa50ce35	Merge pull request #1654 from hashicorp/b-neg-code ... helper/schema: allow set items with hyphens	11 years ago
Mitchell Hashimoto	707aa36aec	helper/schema: only use ~ on first char of code	11 years ago
Mitchell Hashimoto	77314a01d2	helper/schema: disallow negative hash codes	11 years ago
Paul Hinze	92ebb60293	helper/resource: ok let's actually use RFC4122	11 years ago
Paul Hinze	d1106e9e22	helper/resource: add UniqueId() helper ... A generic function for provider resources to use to get a unique identifier.	11 years ago
Mitchell Hashimoto	1f46bc1926	helper/schema: validate unknown fields with computed values [GH-1507]	11 years ago
Mitchell Hashimoto	3176e5b44a	Merge pull request #1595 from TimeIncOSS/aws-account-protection ... aws: Allow defining blacklist/whitelist of account IDs	11 years ago
Mitchell Hashimoto	54e3e6104e	Merge pull request #1594 from TimeIncOSS/schema-conflicts-with ... helper/schema: add schema.ConflictsWith[]	11 years ago
Mitchell Hashimoto	51951d68f4	helper/schema: change diff logic around maps to fix case #57 and #44	11 years ago
Mitchell Hashimoto	9c10a89cf8	helper/schema: FieldReaderMap should mark map as exists if anything set	11 years ago
Mitchell Hashimoto	fa934d96d0	helper/schema: FieldReaderConfig detects computed maps	11 years ago
Mitchell Hashimoto	dc69603cd4	helper/resource: docs	11 years ago
Matt Good	21b0a03d70	Support for multiple providers of the same type ... Adds an "alias" field to the provider which allows creating multiple instances of a provider under different names. This provides support for configurations such as multiple AWS providers for different regions. In each resource, the provider can be set with the "provider" field. (thanks to Cisco Cloud for their support)	11 years ago
Radek Simko	150fd00932	AWS account ID protection added	11 years ago
Radek Simko	34f48b3e06	Add schema.ConflictsWith[] ... - this will allow defining logically conflicting attributes	11 years ago
Radek Simko	e0df74c863	Add schema.ConflictsWith[] ... - this will allow defining logically conflicting attributes	11 years ago
Mitchell Hashimoto	de8666a5fa	helper/ssh: add random number to script [GH-1545]	11 years ago
Mitchell Hashimoto	968a152df4	Merge pull request #1443 from hashicorp/f-acc-tests-check-empty-plan ... providers: check for empty plan after each test step	11 years ago
Sander van Harmelen	d90b3aa332	Merge pull request #1469 from svanharmelen/b-communicator-tests ... Fixing up the communicator tests	11 years ago
Sander van Harmelen	02a41a8802	Fixing up the communicator tests ... It turned out the tests didn’t work as expected due to some missing config in the `newMockLineServer` and a defer located in the wrong location. All is good again now…	11 years ago
Mitchell Hashimoto	db58c7dd33	providers/docker: default cert_path to non-nil so input isn't asked	11 years ago
Paul Hinze	7fe34d4547	providers: check for empty plan after each test step ... Each acceptance test step plays a Refresh, Plan, Apply for a given config. This adds a follow up Plan and fails the test if it does not come back empty. This will catch issues with perpetual, unresolvable diffs that crop up here and there. This is going to cause a lot of our existing acceptance tests to fail - too many to roll into a single PR. I think the best plan is to land this in master and then fix the failures (each of which should be catching a legitimate provider bug) one by one until we get the provider suites back to green.	11 years ago
Paul Hinze	66dbf91ffd	helper/schema: ensure ForceNew set when Update is not ... If a given resource does not define an `Update` function, then all of its attributes must be specified as `ForceNew`, lest Applys fail with "doesn't support update" like #1367. This is something we can detect automatically, so this adds a check for it when we validate provider implementations.	11 years ago
Tarrant	f68c9eee63	Merge branch 'master' of https://github.com/hashicorp/terraform	11 years ago
Tarrant	6ad812e3d8	Merge branch 'ssh_agent'	11 years ago
Paul Hinze	97acccd3ed	core: targeted operations ... Add `-target=resource` flag to core operations, allowing users to target specific resources in their infrastructure. When `-target` is used, the operation will only apply to that resource and its dependencies. The calculated dependencies are different depending on whether we're running a normal operation or a `terraform destroy`. Generally, "dependencies" refers to ancestors: resources falling _before_ the target in the graph, because their changes are required to accurately act on the target. For destroys, "dependencies" are descendents: those resources which fall _after_ the target. These resources depend on our target, which is going to be destroyed, so they should also be destroyed.	11 years ago
Tarrant	05407296c6	Add cleanup function to close SSHAgent	11 years ago
Paul Hinze	3ba8ed536b	helper/schema: record schema version on apply ... We were previously only recording the schema version on refresh. This caused the state to be incorrectly written after a `terraform apply` causing subsequent commands to run the state through an unnecessary migration.	11 years ago
Tarrant	164f303da4	Add SSH Agent support	11 years ago
Paul Hinze	558775d115	Merge pull request #1184 from hashicorp/f-update-ssh-import ... helper/ssh: update import location	11 years ago
Paul Hinze	a24c21bd2c	Merge pull request #1152 from hashicorp/f-helper-schema-versioning ... helper/schema: schema versioning & migration	11 years ago
Paul Hinze	85caf9d8d7	helper/ssh: update import location ... go's ssh package now lives canonically at `golang.org/x/crypto/ssh` see https://godoc.org/golang.org/x/crypto/ssh closes #1179	11 years ago
Paul Hinze	3d4b55e557	helper/schema: schema versioning & migration ... Providers get a per-resource SchemaVersion integer that they can bump when a resource's schema changes format. Each InstanceState with an older recorded SchemaVersion than the cureent one is yielded to a `MigrateSchema` function to be transformed such that it can be addressed by the current version of the resource's Schema.	11 years ago
Paul Hinze	ef70c8cae5	helper/schema: allow Schema attrs to be Removed ... Removed fields show a customizable error message to the user when they are used in a Terraform config. This is a tool that provider authors can use for user feedback as they evolve their Schemas. refs #957	11 years ago
Paul Hinze	888f16d2d3	helper/schema: allow Schema attrs to be Deprecated ... Deprecated fields show a customizable warning message to the user when they are used in a Terraform config. This is a tool that provider authors can use for user feedback as they evolve their Schemas. fixes #957	11 years ago
Paul Hinze	000238835c	helper/schema: [tests] add names to Validate tests ... a process also known as 'paulification' :)	11 years ago
Mitchell Hashimoto	58a8776c41	helper/schema: test real nil pointer to ResourceData.Set	11 years ago
Mitchell Hashimoto	c030148259	helper/schema: allow pointer values to ResourceData.Set	11 years ago
Mitchell Hashimoto	2feaebdca5	config: substring containing computed value replaces element	11 years ago
Jack Pearkes	c180487af6	helper/resource: allow configuration of not found checks in state change	11 years ago
Mitchell Hashimoto	0bc0c03fec	helper/schema: zero value set should set function [GH-1009]	11 years ago
Mitchell Hashimoto	9b8b38cbb1	helper/schema: test that set can be nil	11 years ago
Mitchell Hashimoto	e4f0f6b15d	helper/schema: more tests	11 years ago
Mitchell Hashimoto	dd00001c9a	helper/schema: tests that all pass as I was trying to track down a bug	11 years ago
Mitchell Hashimoto	17680bb7ff	helper/schema: some more test cases, revert some weird behavior from ... dbfb95fcd5 I don't know why that behavior was in there, but it was breaking a lot of existing Terraform states. Let's circle back on it.	11 years ago
Mitchell Hashimoto	659a77c6ae	helper/schema: validate subresources more effectively	11 years ago
Mitchell Hashimoto	fa7f496bef	helper/schema: zero value of a set should be empty	11 years ago
Mitchell Hashimoto	7d32c8946a	helper/schema: GetOk now only returns true if set to non-zero value	11 years ago
Mitchell Hashimoto	e04def93e6	Merge pull request #991 from hashicorp/b-autoscale-lc-update ... providers/aws: allow in-place update of launch configuration	11 years ago
Mitchell Hashimoto	faec39b8c1	Merge pull request #990 from hashicorp/b-set-change ... helper/schema: GetChange shouldn't return true when no change	11 years ago
Mitchell Hashimoto	5a64d0900b	providers/aws: test for allowing in-place lC update	11 years ago
Mitchell Hashimoto	66f7731995	helper/schema: GetChange shouldn't return true when no change	11 years ago
Mitchell Hashimoto	5c06cc386a	helper/schema: empty map values should show up in diff [GH-968]	11 years ago
Mitchell Hashimoto	e9778c85a5	helper/schema: clarify test	11 years ago
Mitchell Hashimoto	dbfb95fcd5	helper/schema: show in diff when no config is going to empty set	11 years ago
Mitchell Hashimoto	fd274d7328	helper/schema: update test desc	11 years ago
Mitchell Hashimoto	bcdec738d4	helper/schema: default the new value to zero only for the decode	11 years ago
Mitchell Hashimoto	ad6be99f5b	helper/schema: failing test	11 years ago
Mitchell Hashimoto	2ee2b9e26f	Merge pull request #986 from hashicorp/b-remove-set ... helper/schema: Diff with set going to 0 elements removes it from state	11 years ago
Mitchell Hashimoto	2212d6895d	helper/schema: diff with set going to 0 elements removes it from state	11 years ago
Mitchell Hashimoto	c22ba7d3a8	helper/schema: fix test index	11 years ago
Mitchell Hashimoto	cbcfb26ec6	helper/schema: add test for sets	11 years ago
Mitchell Hashimoto	b778a65a83	helper/schema: diff of zero value in state with lack of value should not ... diff	11 years ago
Mitchell Hashimoto	61215d8826	Merge pull request #919 from ceh/url-helper ... helper/url: add "Windows-safe" URL Parse wrapper	11 years ago
Clint Shryock	4c7b732dad	typo	11 years ago
Clint Shryock	5602348695	formatting, cleanups	11 years ago
Clint Shryock	a5040ecc03	Update hashcode to always generate a positive	11 years ago
Emil Hessman	e7bbbfb098	helper/url: add Windows 'safe' URL Parse wrapper ... Pull out the urlParse function, which was introduced in config/module, into a helper package.	11 years ago