629 Commits (ea93b91a80201c19c00d12dfd6fddc46f443bd2a)

Author	SHA1	Message	Date
Mitchell Hashimoto	6d594b3bc6	helper/variables: trim whitespace on key before empty string comp	9 years ago
Mitchell Hashimoto	b7f6f8eb2a	helper/variables: trim whitespace around the key in -var ... Fixes #10716 This trims whitespace around the key in the `-var` flag. This is a regression from 0.7.x. The value is whitespace sensitive unless double-quoted. This is the same behavior as 0.7.x. I considered rejecting whitespace around the '=' completely but I don't want to introduce BC and the behavior actually seems quite obvious to me.	9 years ago
Mitchell Hashimoto	42edd22566	helper/variables: address go vet	9 years ago
Mitchell Hashimoto	83e72b0361	helper/variables: ParseInput for consistent parsing	9 years ago
Mitchell Hashimoto	39e3d8ea9b	helper/variables: helpers for working with vars	9 years ago
James Nugent	3177fc0765	provider/aws: Extract helper/encryption library ... This commit extracts the GPG code used for aws_iam_user_login_profile into a library that can be reused for other resources, and updates the call sites appropriately.	9 years ago
James Bardin	7677bd94ed	Merge pull request #10325 from hashicorp/jbardin/GH-10187 ... Fix some cases for nested maps and lists	9 years ago
James Bardin	01be1a5ecd	Check for interpolated values when reading a map ... Accessing an interpolated value in a map through ConfigFieldReader can fail, because GetRaw can't access interpolated values, so check if the value exists at all by looking in the config. If the config has a value, assume our map's value is interpolated and proceed as such. We also need to lookup the correct schema to properly read a field from a nested structure. - Maps previously always defaulted to TypeString. Now check if Elem is a ValueType and use that if applicable - Lists now return the schema for nested element types, defaulting to a TypeString like maps. This only allows maps and lists to be nested one level deep, and the inner map or list must only contain string values.	9 years ago
Paul Tyng	fead481002	Fix typo in test method name (#10370)	9 years ago
Mitchell Hashimoto	0634aada69	Revert "core: Ensure hasComputedSubKeys iterates over Sets and Lists properly" ... This reverts commit 4d8208d840.	9 years ago
Mitchell Hashimoto	f2fcf1494a	Merge branch 'fix-field-reader-setsubkeys-computed' of https://github.com/vancluever/terraform into vancluever-fix-field-reader-setsubkeys-computed	9 years ago
Mitchell Hashimoto	fd36b548c5	helper/wrappedstreams: get original console input/output on Windows ... Fixes #10266 panicwrap was using Extrafiles to get the original standard streams for `terraform console`. This doesn't work on Windows. Instead, we must use the Win32 APIs to get the exact handles.	9 years ago
James Bardin	24ebb72920	Merge pull request #10152 from hashicorp/jbardin/unique-id ... Fix resource.UniqueId to be properly ordered	9 years ago
Chris Marchesi	8d06d68d0f	core: Backport NewComputed change to nested list/set tests ... Needed due to work done in 95d37ea, we may need to adjust hasComputedSubKeys to propagate NewComputed in the same way that we have added "~", however will wait for comment from @mitchellh.	9 years ago
Chris Marchesi	f258056731	core: Tests for hasComputedSubKeys fix ... This covers: * Complex sets with computed fields in a set * Complex lists with computed fields in a set Adding a test to test basic lists with computed fields seemed to fail, but possibly for an unrelated reason (the list returned as nil). The fix to this inparticular case may be out of the scope of this specific issue. Reference gist and details in hashicorp/terraform#9171.	9 years ago
Chris Marchesi	4d8208d840	core: Ensure hasComputedSubKeys iterates over Sets and Lists properly ... This fixes some edge-ish cases where a set in a config has a set or list in it that contains computed values, but non-set or list values in the parent do not. This can cause "diffs didn't match during apply" errors in a scenario such as when a set's hash is calculated off of child items (including any sub-lists or sets, as it should be), and the hash changes between the plan and apply diffs due to the computed values present in the sub-list or set items. These will be marked as computed, but due to the fact that the function was not iterating over the list or set items properly (ie: not adding the item number to the address, so set.0.set.foo was being yielded instead of set.0.set.0.foo), these computed values were not being properly propagated to the parent set to be marked as computed. Fixes hashicorp/terraform#6527. Fixes hashicorp/terraform#8271. This possibly fixes other non-CloudFront related issues too.	9 years ago
James Bardin	c4eefd4b5e	Allow primitive type in maps via all FieldReaders ... Now that we can read primitive type out of a map, each field reader needs to be able to set the proper type as expected.	9 years ago
James Bardin	730014b33e	Convert the map fields values when reading diff ... Convert the value to the correct type when reading a diff and the map schema has an primitive Elem type.	9 years ago
Radek Simko	ad34f1ec74	Add (failing) test for map w/ non-string values	9 years ago
James Bardin	e28e11d44c	Fix resource.UniqueId to be properly ordered ... UniqueId attempted to provide an ordered unique id by using a nanosecond timestamp, but doesn't take into account that time is not monotonic increasing. This provides an implementation that will always be increasing.	9 years ago
Mitchell Hashimoto	39542898b0	helper/schema: mark diff as forcenew if element is computed ... Fixes #10125 If the elements are computed and the field is ForceNew, then we should mark the computed count as potentially forcing a new operation. Example, assuming `groups` forces new... **Step 1:** groups = ["1", "2", "3"] At this point, the resource isn't create, so this should result in a diff like: CREATE resource: groups: "" => ["1", "2", "3"] **Step 2:** groups = ["${computedvar}"] The OLD behavior was: UPDATE resource groups.#: "3" => "computed" This would cause a diff mismatch because if `${computedvar}` was different then it should force new. The NEW behavior is: DESTROY/CREATE resource: groups.#: "3" => "computed" (forces new)	9 years ago
Mitchell Hashimoto	6557a3de18	helper/shadow: Close for auto-closing all values ... Fixes #10122 The simple fix was that we forgot to close `ReadDataApply` for the provider. But I've always felt that this section of the code was brittle and I wanted to put in a more robust solution. The `shadow.Close` method uses reflection to automatically close all values.	9 years ago
Mitchell Hashimoto	1a6056b287	command: split out and tag code so compilation works on Solaris ... The readline library doesn't support Solaris. For now, we'll just not support console there.	9 years ago
Mitchell Hashimoto	a867457d75	command/console	9 years ago
Mitchell Hashimoto	73a1564dac	helper/wrappedreadline: helper for dealing with wrapped standard streams	9 years ago
Mitchell Hashimoto	785cc7b78a	terraform: default new graphs on, old graphs behind -Xlegacy-graph ... This turns the new graphs on by default and puts the old graphs behind a flag `-Xlegacy-graph`. This effectively inverts the current 0.7.x behavior with the new graphs. We've incubated most of these for a few weeks now. We've found issues and we've fixed them and we've been using these graphs internally for awhile without any major issue. Its time to default them on and get them part of a beta.	9 years ago
Mitchell Hashimoto	15f50b86bf	helper/schema: passing tests for computed complex sets	9 years ago
Mitchell Hashimoto	59bd1a22f4	helper/diff: handle unknownvariablevalue	9 years ago
Mitchell Hashimoto	29485f6167	terraform: ResourceConfig.IsComputed cases	9 years ago
Mitchell Hashimoto	5792b2cba2	helper/schema: convert _Diff to subtests	9 years ago
Mitchell Hashimoto	2b7177cfe7	Merge pull request #9607 from hashicorp/f-provider-stop-redo ... terraform: ResourceProvider.Stop (redo)	9 years ago
Mitchell Hashimoto	e45debe0e5	helper/schema: only mark "ForceNew" on resources that cause the ForceNew ... Fixes #2748 This changes the diff to only mark "forces new resource" on the fields that actually caused the new resource, not every field that changed. This makes diffs much more accurate. I'd like to request a review but I'm going to defer merging until Terraform 0.8. Changes like this are very possible to cause "diffs didn't match" errors and I want some real world testing in a beta before we hit prod with this.	9 years ago
Mitchell Hashimoto	b7bee66df5	helper/schema: sort errors in helper/schema test for deterministic tests	10 years ago
Mitchell Hashimoto	f0abe6d1a0	Merge pull request #9812 from hashicorp/b-bool-computed-crash ... helper/schema: computed bool fields should not crash	10 years ago
Mitchell Hashimoto	65b17ccd06	helper/schema: allow ConflictsWith and Computed Optional fields	10 years ago
Mitchell Hashimoto	7834cf7190	helper/schema: computed bool fields should not crash ... Fixes #7715 If a bool field was computed and the raw value was not convertable to a boolean, helper/schema would crash. The correct behavior is to try not to read the raw value when the value is computed and to simply mark that it is computed. This does that (and matches the behavior of the other primitives).	10 years ago
Mitchell Hashimoto	2d84582881	Merge pull request #9699 from hashicorp/b-removed-forcenew ... helper/schema: removed optional items force new	10 years ago
Mitchell Hashimoto	f7a234bc71	helper/schema: validate Read, Delete are set	10 years ago
Mitchell Hashimoto	5489d8c549	helper/schema: removed optional items force new ... Fixes #5138 If an item is optional and is removed completely from the configuration, it should still trigger a destroy/create if the field itself was marked as "ForceNew". See the example in #5138.	10 years ago
Mitchell Hashimoto	3f36787207	Merge pull request #9618 from hashicorp/b-computed-prim ... helper/schema,terraform: handle computed primitives in diffs	10 years ago
Mitchell Hashimoto	af82be19ea	helper/experiment: a helper for setting, making experiments ... This creates a standard package and interface for defining, querying, setting experiments (`-X` flags). I expect we'll want to continue to introduce various features behind experimental flags. I want to make doing this as easy as possible and I want to make _removing_ experiments as easy as possible as well. The goal with this packge has been to rely on the compiler enforcing our experiment references as much as possible. This means that every experiment is a global variable that must be referenced directly, so when it is removed you'll get compiler errors where the experiment is referenced. This also unifies and makes it easy to grab CLI flags to enable/disable experiments as well as env vars! This way defining an experiment is just a couple lines of code (documented on the package).	10 years ago
Mitchell Hashimoto	95d37ea79c	helper/schema,terraform: handle computed primtives in diffs ... Fixes #3309 There are two primary changes, one to how helper/schema creates diffs and one to how Terraform compares diffs. Both require careful understanding. == 1. helper/schema Changes helper/schema, given any primitive field (string, int, bool, etc.) _used to_ create a basic diff when given a computed new value (i.e. from an unkown interpolation). This would put in the plan that the old value is whatever the old value was, and the new value was the actual interpolation. For example, from #3309, the diff showed the following: ``` ~ module.test.aws_eip.test-instance.0 instance: "<INSTANCE ID>" => "${element(aws_instance.test-instance.*.id, count.index)}" ``` Then, when running `apply`, the diff would be realized and you would get a diff mismatch error because it would realize the final value is the same and remove it from the diff. **The change:** `helper/schema` now marks unknown primitive values with `NewComputed` set to true. Semantically this is correct for the diff to have this information. == 2. Terraform Diff.Same Changes Next, the way Terraform compares diffs needed to be updated Specifically, the case where the diff from the plan had a NewComputed primitive and the diff from the apply _no longer has that value_. This is possible if the computed value ended up being the same as the old value. This is allowed to pass through. Together, these fix #3309.	10 years ago
Mitchell Hashimoto	ad5a82de75	helper/resource: remove StopCh, use contexts instead	10 years ago
Mitchell Hashimoto	5ee8042dff	helper/schema: expose stop information as a Context	10 years ago
Mitchell Hashimoto	be34dfe7c1	helper/resource: StopCh as a helper for provider stopCh + timeout	10 years ago
Mitchell Hashimoto	d1bb2f3487	helper/schema: support Stop()	10 years ago
Mitchell Hashimoto	60140b28f4	Revert "Merge pull request #9536 from hashicorp/f-provider-stop" ... This reverts commit c3a4cff133, reversing changes made to 791a02e6e4. This change requires plugin recompilation and we should hold off until a minor release for that.	10 years ago
Mitchell Hashimoto	61bbaf6f85	helper/resource: remove StopCh, use contexts instead	10 years ago
Mitchell Hashimoto	86eb30b8a2	helper/schema: expose stop information as a Context	10 years ago
Mitchell Hashimoto	89647745b0	helper/resource: StopCh as a helper for provider stopCh + timeout	10 years ago