1228 Commits (e024960c745f0a464cb081d04765d93f94deaba0)

Author	SHA1	Message	Date
James Bardin	16e8e405c7	create failing test cases for remote lineage issue ... Some remote backend would fail on `-state push -force`, or `workspace new -state` because of a new strict lineage check in remote.State.	9 years ago
Martin Atkins	8a7a0a7459	command: terraform init -from-module=... ... This restores the earlier behavior of the first positional argument to terraform init in 0.9, but as a command line option. The positional argument was removed to improve consistency with other commands that take a working directory as their first positional argument. It was originally intended that this functionality would return in a later release along with some other general improvements to Terraform's module handling, but we're introducing here an interim solution that uses the existing module source concept, to allow for easier porting of workflows that previously depended on the automatic copy behavior. In a future release this feature may change again as the module improvements design firms up, but we expect it to be broadly compatible with this temporary state.	9 years ago
James Bardin	51547ad2ba	add tests for state commands through a backend	9 years ago
James Bardin	5b4ae36cb0	don't print help for state loading errors ... These already include detailed messages, and it's not a usage issue, it's a config or file location issue.	9 years ago
James Bardin	33ba6774e0	Make the state commands use the real command.Meta ... In order to use a backend for the state commands, we need an initialized meta. Use a single Meta instance rather than temporary ones to make sure the backends are initialized properly.	9 years ago
James Bardin	45a9edb763	make state mv and rm work with remote states ... The default value for the -state flag was overriding the location of any remote state.	9 years ago
Kyle McCullough	ad896b65c9	command: add -check flag to fmt (#15304)	9 years ago
James Bardin	0bca383b6b	Merge pull request #15528 from alrs/command-swallowed-errors ... Fix swallowed errors in command package.	9 years ago
Lars Lehtonen	119996b815	Return immediately after newly-added error condition	9 years ago
James Bardin	eb02467298	Merge pull request #15588 from hashicorp/jbardin/no-graph-config ... graph should not panic with no config	9 years ago
James Bardin	f10163ecc7	graph should not panic with no config ... The backends replace a nil module tree with an empty one before building the graph, so the graph command needs to do the same.	9 years ago
Martin Atkins	23f9c8785e	command/e2etest: an initial test for the primary workflow ... This e2etest runs an init, plan, apply, destroy sequence against a test configuration using the real template and null providers downloaded from the official repository. This test _does_ trample a bit on the scope of some already-existing tests, but this is mainly just to check our assumptions about how Terraform behaves to ensure that we can reach our main conclusion here: that the main Terraform workflow commands interact correctly with each other in real use and we can complete the full workflow.	9 years ago
Martin Atkins	52df81ee49	command/e2etest: test that we can install provider plugins ... We already have good tests for the business logic around provider installation, but the existing tests all stub out the main repository server. This test completes that coverage by verifying that the installer is able to run against the real repository and install an official release of the template provider.	9 years ago
Martin Atkins	0e0b0d125a	command/e2etest: "terraform version" test ... This basic test is here primarily because it's one of the few that can run without reaching out to external services, and so it means our usual test runs will catch situations where the main executable build is somehow broken. The version command itself is not very interesting to test, but it's convenient in that its behavior is very predictable and self-contained.	9 years ago
Martin Atkins	fee61a44b4	command/e2etest: end-to-end testing harness ... Previously we had no automated testing of whether we can produce a Terraform executable that actually works. Our various functional tests have good coverage of specific Terraform features and whole operations, but we lacked end-to-end testing of actual usage of the generated binary, without any stubbing. This package is intended as a vehicle for such end-to-end testing. When run normally under "go test" it will produce a build of the main Terraform binary and make it available for tests to execute. The harness exposes a flag for whether tests are allowed to reach out to external network services, controlled with our standard TF_ACC environment variable, so that basic local tests can be safely run as part of "make test" while more elaborate tests can be run easily when desired. It also provides a separate mode of operation where the included script make-archive.sh can be used to produce a self-contained test archive that can be copied to another system to run the tests there. This is intended to allow testing of cross-compiled binaries, by shipping them over to the target OS and architecture to run without requiring a full Go compiler installation on the target system. The goal here is not to test again functionality that's already well-covered by our existing tests, but rather to test chains of normal operations against the build binary that are not otherwise tested together.	9 years ago
Lars Lehtonen	8501d83e6c	Fix swallowed errors in command package.	9 years ago
James Bardin	583cc350a9	fix minor races in workspace tests ... The improved err scanner loop in meta causes these to race. There's no need to write back to the same commands struct, so just use a new instance in each iteration.	9 years ago
James Bardin	f7f1e8e406	Sort arguments in Meta.process ... Meta.process was relying on the system readdir to order the arguments, but readdir doesn't guarantee any ordering. Read the directory contents as a whole and sort them in place before adding the tfvars files.	9 years ago
James Bardin	0fdcf2c01e	properly cleanup and print correct error messages ... Some Meta tests were not cleaning up their temp directories. The process test wasn't printing the correct arguments in the error messages.	9 years ago
Robert Liebowitz	4bf2269784	Add test case for autoloading tfvars	9 years ago
Robert Liebowitz	e67ecb5ce2	Restructure Meta.process to logically group code	9 years ago
Robert Liebowitz	8d98fdecac	Autoload only .auto.tfvars files	9 years ago
Robert Liebowitz	006744bfe0	Use all tfvars files in working directory ... As a side effect, several commands that previously did not have a failure state can now fail during meta-parameter processing.	9 years ago
Martin Atkins	39c4d6ab1f	Merge #15424: Improve robustness of state persistence handling ... Previously the APIs for state persistence and management had some problematic cases where we depended on hidden mutations of the state structure as side-effects of otherwise-innocent-looking operations, which was a frequent cause of accidental regressions due to faulty assumptions. This new model attempts to isolate certain state mutations to just within the state managers, and makes the state managers work on separated snapshots of the state rather than on the "live" object to reduce the risk of race conditions.	9 years ago
Martin Atkins	fee1197cf9	command: terraform state rm to require at least one argument ... Due to how the state filter machinery works, passing no arguments is valid and matches _all_ resources. It is very unlikely that someone wants to remove everything from state, so this ends up being a very dangerous default for the "terraform state rm" command, and surprising for someone who perhaps runs it looking for the usage information. So we'll be pragmatic here and reject the no-arguments case for this command, accepting that it makes the unlikely case of intentionally deleting all resources harder in order to make it less likely that it will happen _unintentionally_. If someone does really want to remove all resources from the state, they can provide an explicit empty string argument, but this isn't documented because it's a weird case that doesn't seem worth mentioning. This fixes #15283.	9 years ago
James Bardin	fb397060eb	add some Serial checks to apply and refresh tests	9 years ago
James Bardin	054716c397	use testStateRead helper in apply tests ... We have a helper function that we hardly ever use. TODO: convert the rest of the manual ReadState calls eventually.	9 years ago
James Bardin	501cbeaffe	testState shouldn't rely on mods from WriteState ... The state returned from the testState helper shouldn't rely on any mutations caused by WriteState. The Init function (which is analogous to NewState) shoudl set any required fields.	9 years ago
Mike Helmick	9d7fce2f69	command: "terraform workspace show" to print current workspace name ... This command serves as an alternative to the human-oriented list of workspaces for scripting use-cases where it's useful to know the _current_ workspace name.	9 years ago
Martin Atkins	4d53eaa6df	state: more robust handling of state Serial ... Previously we relied on a constellation of coincidences for everything to work out correctly with state serials. In particular, callers needed to be very careful about mutating states (or not) because many different bits of code shared pointers to the same objects. Here we move to a model where all of the state managers always use distinct instances of state, copied when WriteState is called. This means that they are truly a snapshot of the state as it was at that call, even if the caller goes on mutating the state that was passed. We also adjust the handling of serials so that the state managers ignore any serials in incoming states and instead just treat each Persist as the next version after what was most recently Refreshed. (An exception exists for when nothing has been refreshed, e.g. because we are writing a state to a location for the first time. In that case we _do_ trust the caller, since the given state is either a new state or it's a copy of something we're migrating from elsewhere with its state and lineage intact.) The intent here is to allow the rest of Terraform to not worry about serials and state identity, and instead just treat the state as a mutable structure. We'll just snapshot it occasionally, when WriteState is called, and deal with serials _only_ at persist time. This is intended as a more robust version of #15423, which was a quick hotfix to an issue that resulted from our previous slopping handling of state serials but arguably makes the problem worse by depending on an additional coincidental behavior of the local backend's apply implementation.	9 years ago
Radek Simko	14614a5423	command/validate: Add flag to check that all variables are specified (#13872) ... * command/validate: Add flag to check that all variables are specified * Rename config-only to check-variables	9 years ago
Jake Champlin	9944ea6886	core: Skip provider checksum validation based on env var ... Skips checksum validation if the `TF_SKIP_PROVIDER_VERIFY` environment variable is set. Undocumented variable, as the primary goal is to significantly improve the local provider development workflow.	9 years ago
James Bardin	da1c45b566	Merge pull request #15412 from hashicorp/jbardin/windows-delete-workspace ... Unlock state before workspace deletion	9 years ago
James Bardin	1c78dfb286	Unlock state before workspace deletion ... We need to release the lock just before deleting the state, in case the backend can't remove the resource while holding the lock. This is currently true for Windows local files. TODO: While there is little safety in locking while deleting the state, it might be nice to be able to coordinate processes around state deletion, i.e. in a CI environment. Adding Delete() as a required method of States would allow the removal of the resource to be delegated from the Backend to the State itself.	9 years ago
David Glasser	14af879fe0	command: also print plan for destroy	9 years ago
David Glasser	039d36bf91	command: add "apply -auto-approve=false" flag ... A common reason to want to use `terraform plan` is to have a chance to review and confirm a plan before running it. If in fact that is the only reason you are running plan, this new `terraform apply -auto-approve=false` flag provides an easier alternative to P=$(mktemp -t plan) terraform refresh terraform plan -refresh=false -out=$P terraform apply $P rm $P The flag defaults to true for now, but in a future version of Terraform it will default to false.	9 years ago
James Bardin	22074f1029	Merge pull request #15408 from hashicorp/jbardin/import-plugin-dir ... Make sure import uses complete plugin path	9 years ago
Patrick Aikens	7775ef809b	Display correct to and from backends in copy message when migrating to new remote state (#15318)	9 years ago
James Bardin	85b9069eb7	test import with -plugin-dir ... The import command wasn't loading the full plugin path for discovery. Run a basic plugin init sequence, and verify we can find a plugin (even though the plugin is invalid and will fail).	9 years ago
James Bardin	0cbd51c365	find -plugin-dir during import ... The import command wasn't loading the plugin path at all, relying on the local directory for binaries. Load the plugin dir into Meta, and pass in ForceLocal for consistency. The Backend returned was going to be a Local anyway, so the added check wasn't ensuring anything.	9 years ago
Martin Atkins	3df164502a	command: don't prompt for state migration if TF_INPUT is set ... The "confirm" method was directly checking the meta struct's input field, but that only represents the -input command line flag, and doesn't respect the TF_INPUT environment variable. By calling the Input method instead, we check both. This fixes #15338.	9 years ago
James Bardin	833cc9a6c5	Fix state mv/rm -backup documentation ... There is only one backup made, contrary to the help text. We may want to implement that, but the documentation should match the current behavior.	9 years ago
James Bardin	6e7baaaeff	don't load the backend when -state is provided ... When using a `state` command, if the `-state` flag is provided we do not want to modify the Backend state. In this case we should always create a local state instance. The backup flag was also being ignored, and some tests were relying on that, which have been fixed.	9 years ago
James Bardin	5f939b42fe	test that `state mv -state` doesn't use Backend ... If we provide a -state flag to a state command, we do not want terraform to modify the backend state. This test fails since the state specified in the backend doesn't exist	9 years ago
James Bardin	4893fcc24f	improve plugin error formatting ... Remove "checksum" from the error, and only indicate that the plugin has changed. Always show requested versions even if it's "any", and found versions of plugins.	9 years ago
James Bardin	103ab20b00	add required and found versions to error output ... Provide the user with feedback showing the version requirements and the versions found when there's is a plugin error	9 years ago
James Bardin	7a955f990c	make display plugin checksum error to user ... The error follows a generic message, so can be ignored by users who may not understand the implications.	9 years ago
Martin Atkins	0dc6d97a37	command/format: minor adjustments to plan rendering ... This change makes various minor adjustments to the rendering of plans in the output of "terraform plan": - Resources are identified using the standard resource address syntax, rather than exposing the legacy internal representation used in the module diff resource keys. This fixes #8713. - Subjectively, having square brackets in the addresses made it look more visually "off" when the same name but with different indices were shown together with differing-length "symbols", so the symbols are now all padded and right-aligned to three characters for consistent layout across all operations. - The -/+ action is now more visually distinct, using several different colors to help communicate what it will do and including a more obvious "(new resource required)" marker to help draw attention to this not being just an update diff. This fixes #15350. - The resources are now sorted in a manner that sorts index [10] after index [9], rather than after index [1] as we did before. This makes it easier to scan the list and avoids the common confusion where it seems that there are only 10 items when in fact there are 11-20 items with all the tens hiding further up in the list.	9 years ago
Martin Atkins	40e2fbb8e9	command: init to allow plugin init without backend init ... Previously init would crash if given these options: -backend=false -get-plugins=true This is because the state is used as a source of provider dependency information, and we need to instantiate the backend to get the state. To avoid the crash, we now use the following adjusted behavior: - if -backend=true, we behave as before - if -backend=false, we instead try to instantiate the backend the same way any other command would, without modifying its configuration - if we're able to instantiate the backend, we use it to fetch state for dependency resolution purposes - if the backend is not instantiable then we assume it's not yet configured and proceed with a nil state, which may cause us to see an incomplete picture of the dependencies but still allows the install to succeed. Subsequently running "terraform plan" will not work until the backend is (re-)initialized, so the incomplete picture of required plugins is safe.	9 years ago
Martin Atkins	3dc7d618f7	command: avoid empty string constraints in plugin install errors ... This takes care of a few dangling cases where we were still stringifying empty version constraints, which creates confusing error messages due to it stringing as the empty string. For the "no suitable versions available" message, we fall back on the "provider not found" message if no versions were found even though it's unconstrained. This should only happen in an edge case where the provider's index page exists on the releases server but no versions are yet present. For the message about plugin protocol versions, this again is an edge case since with no constraints this should happen only if we release an incompatible Terraform version but don't release a new version of the plugin that's compatible. In this case we just show the constraint as "(any version)" to make sure we always show _something_.	9 years ago
James Bardin	c10f5caf05	Merge pull request #15345 from hashicorp/jbardin/plugin-sig ... verify automatically downloaded plugins	9 years ago
Martin Atkins	9c2fe3456b	command: purge unused plugins as a side effect of plugin installation ... Previously we only did this when _upgrading_, but that's unnecessarily specific and confusing since e.g. plugins can get upgraded implicitly by constraint changes, which would not then trigger the purge process. Instead, we'll assume that the user is able to easily re-download plugins that were purged here, or if they need more specific guarantees they will manage manually a plugin directory and disable the auto-install behavior using `-plugin-dir`.	9 years ago
Martin Atkins	d48dcbb4a5	command: more-helpful error messages from plugin installation ... Now we are able to recognize and handle a few special error situations from plugin installation with more verbose error messages that give the user better feedback on how to proceed.	9 years ago
James Bardin	0a47228065	add -verify-plugins flag to init ... This provides the user with the option to disable plugin signature verification.	9 years ago
James Bardin	6728c48d8c	fix whitespace around backend init success message ... make it better match the surrounding messages.	9 years ago
James Bardin	da385c4268	Don't show plugin init message if there are none ... Skip the message and plugin initialization if there are none in the config.	9 years ago
James Bardin	2e57d284cb	Merge pull request #15323 from hashicorp/jbardin/constraint-suggestion ... remove "~> 0.0" constraint suggestions	9 years ago
James Bardin	ec99b6910b	remove "~> 0.0" constraint suggestions ... Don't suggest constraints when the available plugin isn't versioned. Add zero version const for comparisons.	9 years ago
James Bardin	270eedd4b8	always pass in the full plugin path to dicovery ... Discovery no longer tries to walk into OS_ARCH dirs, so always pass in the full search path.	9 years ago
James Bardin	be2069ac81	add -plugin-dir option ... The -plugin-dir option lets the user specify custom search paths for plugins. This overrides all other plugin search paths, and prevents the auto-installation of plugins. We also make sure that the availability of plugins is always checked during init, even if -get-plugins=false or -plugin-dir is set.	9 years ago
James Bardin	000e860706	Add plugin dir scaffolding ... add pluginDir to command.Meta, the flag to initialize it, and the methods to save and restore it.	9 years ago
James Bardin	f723270e3e	search the vendor directory for plugins ... The default location for users to manually add plugins will be ./terraform.d/plugins/	9 years ago
James Bardin	4f5e92e4c0	reverse init test to check for dataDir in PWD ... init should always write intternal data to the current directory, even when a path is provided. The inherited behavior no longer applies to the new use of init.	9 years ago
James Bardin	55bf19e548	always write to dataDir in the current directory ... Now that init can take a directory for configuration, the old behavior of writing the .terraform data directory into the target path no longer makes sense. Don't change the dataDir field during init, and write to the default location. Clean up all references to Meta.dataDir, and only use the getter method in case we chose to dynamically override this at some point.	9 years ago
Martin Atkins	6979a07754	command: init -upgrade for provider plugins ... Now when -upgrade is provided to "terraform init" (and plugin installation isn't disabled) it will: - ignore the contents of the auto-install plugin directory when deciding what is "available", thus causing anything there to be reinstalled, possibly at a newer version. - if installation completes successfully, purge from the auto-install plugin directory any plugin-looking files that aren't in the set of chosen plugins. As before, plugins outside of the auto-install directory are able to take precedence over the auto-install ones, and these will never be upgraded nor purged. The thinking here is that the auto-install directory is an implementation detail directly managed by Terraform, and so it's Terraform's responsibility to automatically keep it clean as plugins are upgraded. We don't yet have the -plugin-dir option implemented, but once it is it should circumvent all of this behavior and just expect providers to be already available in the given directory, meaning that nothing will be auto-installed, -upgraded or -purged.	9 years ago
Martin Atkins	f753974bb3	plugin/discovery: Installer interface, and provider implementation ... Previously we had a "getProvider" function type used to implement plugin fetching. Here we replace that with an interface type, initially with just a "Get" function. For now this just simplifies the interface by allowing the target directory and protocol version to be members of the struct rather than passed as arguments. A later change will extend this interface to also include a method to purge unused plugins, so that upgrading frequently doesn't leave behind a trail of unused executable files.	9 years ago
Gavin Williams	5834333ea3	command: terraform get -upgrade ... As of this commit this just upgrades modules, but this option will also later upgrade plugins and indeed anything else that's being downloaded and installed as part of the init.	9 years ago
James Bardin	be900e8085	Merge pull request #15258 from hashicorp/jbardin/remove-providers ... Remove providers from core	9 years ago
James Bardin	cbbbcea4b9	stop err scanner goroutines between tests	9 years ago
James Bardin	77a32f3df0	remove "core" distinction ... Since there is little left that isn't core, remove the distinction for now to reduce confusion, since a "core" binary will mostly work except for provisioners.	9 years ago
James Bardin	7e7f53954d	remove internal provider test from command pkg	9 years ago
James Bardin	81ac0ed204	re-generate plugin list	9 years ago
Radek Simko	4e85f552e7	Merge pull request #15246 from hashicorp/b-fix-cmd-provider-crash ... command/providers: Avoid crash when no configs found	9 years ago
James Bardin	a30007b41d	Merge pull request #15032 from hashicorp/jbardin/init ... change init args to remove source copy	9 years ago
Radek Simko	f5ff67c530	command/providers: Add regression test	9 years ago
Radek Simko	ee30df3efd	command/providers: Enable processing of meta-parameters ... This will enable proper colouring of the output, like for other commands.	9 years ago
Radek Simko	86fbcfac83	command/providers: Avoid crash when no configs found	9 years ago
Martin Atkins	f7ce6a15f8	backend: Operation.Environment renamed to "Workspace" ... This is part of an effort to switch this terminology across all of Terraform.	9 years ago
Martin Atkins	418a8a8bc9	command + backend: rename various API objects to "Workspace" terminology ... We're shifting terminology from "environment" to "workspace". This takes care of some of the main internal API surface that was using the old terminology, though is not intended to be entirely comprehensive and is mainly just to minimize the amount of confusion for maintainers as we continue moving towards eliminating the old terminology.	9 years ago
Martin Atkins	5f9f13ab8f	command: show warnings from backend config validation ... Previously we just silently ignored warnings from validating the backend config, but now that we have a deprecated argument it's important to print these out so users can respond to the deprecation warning.	9 years ago
Martin Atkins	31d556894f	command: shallow UI-focused rename of "environment" to "workspace" ... Feedback after 0.9 was that the term "environment" was confusing due to it colliding with several other concepts, such as OS environment variables, a non-aligned Terraform Enterprise concept, and differing ideas of "environment" within various organizations. This new term "workspace" is intended to ease some of that confusion. This term is not used anywhere else in Terraform today, and we expect it to not be used in a manner that would be confusing within user organizations. This begins a deprecation cycle for the "terraform env" family of commands, instead moving to an equivalent set of "terraform workspace" commands. There are some remaining references to the old "environment" concept in the code, which will be cleaned up in a separate change. This change is instead focused on text visible in the UI and wording within code comments for the benefit of human maintainers of the code.	9 years ago
David Glasser	c25d848ffb	core: allow overriding environment name via env var ... This allows you to run multiple concurrent terraform operations against different environments from the same source directory. Fixes #14447. Also removes some dead code which appears to do the same thing as the function I modified.	9 years ago
James Bardin	2bfcdbbd08	change init args to remove source copy ... When init was modified in 0.9 to initialize a terraform working directory, the legacy behavior was kept to copy or fetch module sources. This left the init command without the ability that the plan and apply commands have to target a specific directory for the operation. This commit removes the legacy behavior altogether, and allows init to target a directory for initialization, bringing it into parity with plan and apply. If one want to copy a module to the target or current directory, that will have to be done manually before calling init. We can later reintroduce fetching modules with init without breaking this new behavior, by adding the source as an optional second argument. The unit tests testing the copying of sources with init have been removed, as well as some out of date (and commented out) init tests regarding remote states.	9 years ago
James Bardin	d1c50efb01	change providers.json to lock.json ... It might not just be for providers, and it's in the plugins dir, so lock.json seems descriptive enough.	9 years ago
James Bardin	08592c2602	update plugin name in command test	9 years ago
James Bardin	a529b64cc8	better init error output ... Provide log-form message when a provider isn't found, along with the desired constraints.	9 years ago
James Bardin	fdbfc17fae	missing constraints passed erroniously ... ConstrainVersions was documented as returning nil, but it was instead returning an empty set. Use the Count() method to check for nil or empty. Add test to verify failed constraints will show up as missing.	9 years ago
Martin Atkins	766f8e5d64	command init: remove confusing uses of "environment" in the usage ... "environment" is a very overloaded term, so here we prefer to use the term "working directory" to talk about a local directory where operations are executed on a given Terraform configuration.	9 years ago
Martin Atkins	3c429b3628	command init: show log output for each provider plugin downloaded ... Each provider plugin will take at least a few seconds to download, so providing feedback about each one should make users feel less like Terraform has hung. Ideally we'd show ongoing progress during the download, but that's not possible without re-working go-getter, so we'll accept this as an interim solution for now.	9 years ago
Martin Atkins	4571a16b15	command: remove Meta.forceProviderSHA256s ... This was added with the idea of using it to override the SHA256 hashes to match those hypothetically stored in a plan, but we already have a mechanism elsewhere for populating context fields from plan fields, so this is not actually necessary.	9 years ago
Martin Atkins	9aae06db97	command: update mockGetProvider.GetProvider for new interface ... The expected type was changed in the mainline code but the tests were not updated to match.	9 years ago
Martin Atkins	4ba20f9c1c	command init: show suggested constraints for unconstrained providers ... When running "terraform init" with providers that are unconstrained, we will now produce information to help the user update configuration to constrain for the particular providers that were chosen, to prevent inadvertently drifting onto a newer major release that might contain breaking changes. A ~> constraint is used here because pinning to a single specific version is expected to create dependency hell when using child modules. By using this constraint mode, which allows minor version upgrades, we avoid the need for users to constantly adjust version constraints across many modules, but make major version upgrades still be opt-in. Any constraint at all in the configuration will prevent the display of these suggestions, so users are free to use stronger or weaker constraints if desired, ignoring the recommendation.	9 years ago
James Bardin	e0f2235f66	update init command with new GetProvider signature ... GetProvider needs the plugin protocol version to be passed in	9 years ago
Martin Atkins	032f71f1ff	command: produce provider lock file during "terraform init" ... Once we've installed the necessary plugins, we'll do one more walk of the available plugins and record the SHA256 hashes of all of the plugins we select in the provider lock file. The file we write here gets read when we're building ContextOpts to initialize the main terraform context, so any command that works with the context will then fail if any of the provider binaries change.	9 years ago
Martin Atkins	6ba6508ec9	command: pass the locked plugin hashes into ContextOpts ... By reading our lock file and passing this into the context, we ensure that only the plugins referenced in the lock file can be used. As of this commit there is no way to create that lock file, but that will follow soon as part of "terraform init". We also provide a way to force a particular set of SHA256s. The main use for this is to allow us to persist a set of plugins in the plan and check the same plugins are used during apply, but it may also be useful for automated tests.	9 years ago
Martin Atkins	720670fae7	command: helper to manage the provider plugins lock file ... This is just a JSON file with the SHA256 digests of the plugin executables.	9 years ago
Martin Atkins	7d0a98af46	command: provider resolver to also check SHA256 constraints when set ... In addition to looking for matching versions, the caller can also optionally require a specific executable by its SHA256 digest.	9 years ago
Martin Atkins	e3401947a6	plugin/discovery: PluginRequirements can specify SHA256 digests ... As well as constraining plugins by version number, we also want to be able to pin plugins to use specific executables so that we can detect drift in available plugins between commands. This commit allows such requirements to be specified, but doesn't yet specify any such requirements, nor validate them.	9 years ago
Martin Atkins	9a398a7793	command: require resource to be in config before import ... Previously we encouraged users to import a resource and _then_ write the configuration block for it. This ordering creates lots of risk, since for various reasons users can end up subsequently running Terraform without any configuration in place, which then causes Terraform to want to destroy the resource that was imported. Now we invert this and require a minimal configuration block be written first. This helps ensure that the user ends up with a correlated resource config and state, protecting against any inconsistency caused by typos. This addresses #11835.	9 years ago
Martin Atkins	7d8719150c	command: validate import resource address early ... Previously we deferred validation of the resource address on the import command until we were in the core guts, which caused the error responses to be rather unhelpful. By validating these things early we can give better feedback to the user.	9 years ago
Martin Atkins	f6305fcc27	command: remove commented-out, misplaced tests ... For some reason there was a block of commented-out tests for the refresh command in the test file for the import command. Here we remove them to reduce the noise in this file.	9 years ago
James Bardin	044ad5ef59	rename some Constraints methods per code review	9 years ago
James Bardin	2994c6ac5d	add init getPlugin test ... add a mock plugin getter, and test that we can fetch requested version of the plugins.	9 years ago
James Bardin	4c32cd432a	make getProvider pluggable	9 years ago
James Bardin	66ebff90cd	move some more plugin search path logic to command ... Make less to change when we remove the old search path	9 years ago
James Bardin	2749946f5c	basic plugin getter ... Add discovery.GetProviders to fetch plugins from the relases site. This is an early version, with no tests, that only (probably) fetches plugins from the default location. The URLs are still subject to change, and since there are no plugin releases, it doesn't work at all yet.	9 years ago
James Bardin	7d2d951f27	Rename VersionSet to Constraints ... VersionSet is a wrapper around version.Contraints, so rename it it as such.	9 years ago
James Bardin	718ede0636	have Meta.Backend use a Config rather than loading ... Instead of providing the a path in BackendOpts, provide a loaded *config.Config instead. This reduces the number of places where configuration is loaded.	9 years ago
Martin Atkins	3af0ecdf01	command: "terraform providers" command ... This new command prints out the tree of modules annotated with their associated required providers. The purpose of this command is to help users answer questions such as "why is this provider required?", "why is Terraform using an older version of this provider?", and "what combination of modules is creating an impossible provider version situation?" For configurations using many modules this sort of question is likely to come up a lot once we support versioned providers. As a bonus use-case, this command also shows explicitly when a provider configuration is being inherited from a parent module, to help users to understand where the configuration is coming from for each module when some child modules provide their own provider configurations.	9 years ago
Martin Atkins	4ab8973520	core: provide config to all import context tests ... We're going to use config to determine provider dependencies, so we need to always provide a config when instantiating a context or we'll end up loading no providers at all. We previously had a test for running "terraform import -config=''" to disable the config entirely, but this test is now removed because it makes no sense. The actual functionality its testing still remains for now, but it will be removed in a subsequent commit when we start requiring that a resource to be imported must already exist in configuration.	9 years ago
Martin Atkins	c835ef8ff3	Update tests for the new ProviderResolver interface ... Rather than providing an already-resolved map of plugins to core, we now provide a "provider resolver" which knows how to resolve a set of provider dependencies, to be determined later, and produce that map. This requires the context to be instantiated in a different way, so this very noisy diff is a mostly-mechanical update of all of the existing places where contexts get created for testing, using some adapted versions of the pre-existing utilities for passing in mock providers.	9 years ago
Martin Atkins	7ca592ac06	core: use ResourceProviderResolver to resolve providers ... Previously the set of providers was fixed early on in the command package processing. In order to be version-aware we need to defer this work until later, so this interface exists so we can hold on to the possibly-many versions of plugins we have available and then later, once we've finished determining the provider dependencies, select the appropriate version of each provider to produce the final set of providers to use. This commit establishes the use of this new mechanism, and thus populates the provider factory map with only the providers that result from the dependency resolution process. This disables support for internal provider plugins, though the mechanisms for building and launching these are still here vestigially, to be cleaned up in a subsequent commit. This also adds a new awkward quirk to the "terraform import" workflow where one can't import a resource from a provider that isn't already mentioned (implicitly or explicitly) in config. We will do some UX work in subsequent commits to make this behavior better. This breaks many tests due to the change in interface, but to keep this particular diff reasonably easy to read the test fixes are split into a separate commit.	9 years ago
Martin Atkins	d6b6dbb5c6	command: correct provider name in the test fixture for push ... Currently this doesn't matter much, but we're about to start checking the availability of providers early on and so we need to use the correct name for the mock set of providers we use in command tests, which includes only a provider named "test". Without this change, the "push" tests will begin failing once we start verifying this, since there's no "aws" provider available in the test context.	9 years ago
Martin Atkins	9b4f15c261	plugin: move Client function into plugin, from plugin/discovery ... Having this as a method of PluginMeta felt most natural, but unfortunately that means that discovery must depend on plugin and plugin in turn depends on core Terraform, thus making the discovery package hard to use without creating dependency cycles. To resolve this, we invert the dependency and make the plugin package be responsible for instantiating clients given a meta, using a top-level function.	9 years ago
Martin Atkins	8364383c35	Push plugin discovery down into command package ... Previously we did plugin discovery in the main package, but as we move towards versioned plugins we need more information available in order to resolve plugins, so we move this responsibility into the command package itself. For the moment this is just preserving the existing behavior as long as there are only internal and unversioned plugins present. This is the final state for provisioners in 0.10, since we don't want to support versioned provisioners yet. For providers this is just a checkpoint along the way, since further work is required to apply version constraints from configuration and support additional plugin search directories. The automatic plugin discovery behavior is not desirable for tests because we want to mock the plugins there, so we add a new backdoor for the tests to use to skip the plugin discovery and just provide their own mock implementations. Most of this diff is thus noisy rework of the tests to use this new mechanism.	9 years ago
Jake Champlin	7894478c8c	Merge pull request #14681 from svanharmelen/f-review ... Use `helpers.shema.Provisoner` in Chef provisioner V2	9 years ago
James Bardin	dbe9599820	remove dead code	9 years ago
James Bardin	b3795e2d29	remove old state hook code	9 years ago
Mat Schaffer	76d4abd12a	Fix typo on state migration input error	9 years ago
Vladislav Rassokhin	df4342bc3d	Regenerate plugin list since provisioners were changed in previous commits	9 years ago
David Glasser	783908ee25	core: fix bad Sprintf in backend migration message (#14601) ... Before this, invoking this codepath would print Terraform has successfully migrated from legacy remote state to your configured remote state.%!(EXTRA string=s3)	9 years ago
Paul Stack	055c18e302	core/provider-split: Split out the Oracle OPC provider to new structure (#14362) ... * core/providersplit: Split OPC Provider to separate repo As we march towards Terraform 0.10.0, we are going to start building the terraform providers as separate binaries - this will allow us to continually release them. Before we go to 0.10.0, we need to be able to continue building providers in the same manner, therefore, we have hardcoded the path of the provider in the generate-plugins.go file The interim solution will require us to vendor the opc provider and any child dependencies, but when we get to 0.10.0, we will no longer have to do this - the core will auto download the plugin binary. The plugin package will have it's own dependencies vendored as well. * core/providersplit: Removing the builtin version of OPC provider * core/providersplit: Vendoring the OPC plugin * core/providersplit: update internal plugin list * core/providersplit: remove unused govendor item	9 years ago
yanndegat	21d8125d5c	provider/ovh: new provider (#12669) ... * vendor: add go-ovh * provider/ovh: new provider * provider/ovh: Adding PublicCloud User Resource * provider/ovh: Adding VRack Attachment Resource * provider/ovh: Adding PublicCloud Network Resource * provider/ovh: Adding PublicCloud Subnet Resource * provider/ovh: Adding PublicCloud Regions Datasource * provider/ovh: Adding PublicCloud Region Datasource * provider/ovh: Fix Acctests using project's regions	9 years ago
Dmitrii Korotovskii	ace0456d58	http provider and http request data source	9 years ago
James Bardin	947db2304a	it's possible to get a nil diff in PreApply ... Looking through the operations in node_resource_apply and node_resource_destroy, there are multiple nil checks for diffApply, so one we need to continue to assume that the diff can be nil through there until we ensure that it is non-nill in all cases. So regardless of how we came to get a nil diff in the UiHook PreApply method, we need to check it.	9 years ago
Justin LaRose	c6ad44de10	update error response when env does not exist (#14009)	9 years ago
stack72	898ac02854	Merge branch 'feature/gitlab_provider' of https://github.com/richardc/terraform into richardc-feature/gitlab_provider	9 years ago
Edward Betts	be265479a9	correct spelling mistakes (#13979)	9 years ago
James Bardin	6ef7c83ec5	add data-loss warning to SIGINT handler in apply ... Warning user about data loss after receiving an interrupt.	9 years ago
Richard Clamp	631b0b865c	provider/gitlab: add gitlab provider and `gitlab_project` resource ... Here we add a basic provider with a single resource type. It's copied heavily from the `github` provider and `github_repository` resource, as there is some overlap in those types/apis. ~~~ resource "gitlab_project" "test1" { name = "test1" visibility_level = "public" } ~~~ We implement in terms of the [go-gitlab](https://github.com/xanzy/go-gitlab) library, which provides a wrapping of the [gitlab api](https://docs.gitlab.com/ee/api/) We have been a little selective in the properties we surface for the project resource, as not all properties are very instructive. Notable is the removal of the `public` bool as the `visibility_level` will take precedent if both are supplied which leads to confusing interactions if they disagree.	9 years ago
Martin Atkins	b1763e262a	Restore stringer-generated files back to new version ... stringer has changed the boilerplate it generates in a recent version. We'd previously updated to the new format but accientally rolled back to the old while merging a long-running feature branch. This restores us back to the new format again.	9 years ago
Jasmin Gacic	61499cfcf0	Provider Oneandone (#13633) ... * Terraform Provider 1&1 * Addressing pull request remarks * Fixed imports * Fixing remarks * Test optimiziation	9 years ago
James Bardin	dca89519ec	Merge pull request #13825 from hashicorp/jbardin/reconfigure ... add init -reconfigure flag	9 years ago
James Bardin	0e0f0b64b9	add init -reconfigure test ... Check that we can reconfigure a backend ignoring the saved config, and without effecting the saved backend.	9 years ago
James Bardin	7aa2ce8341	add -reconfigure option for init ... The reconfigure flag will force init to ignore any saved backend state. This is useful when a user does not want any backend migration to happen, or if the saved configuration can't be loaded at all for some reason.	9 years ago
Jake Champlin	35388cbc31	Merge pull request #13468 from hashicorp/f-oracle-compute ... provider/opc: Add Oracle Compute Provider	9 years ago
Quentin Machu	bf8d932d23	provider/local: Implement a new local_file resource ... This commit adds the ability to provision files locally. This is useful for cases where TerraForm generates assets such as TLS certificates or templated documents that need to be saved locally. - While output variables can be used to return values to the user, it is not extremly suitable for large content or when many of these are generated, nor is it practical for operators to manually save them on disk. - While `local-exec` could be used with an `echo`, this provider works across platforms and do not require any convoluted escaping.	9 years ago
James Bardin	d1b4df42ed	missing PersistState in env new	9 years ago
David Joos	bbd2e6de35	Fix for minor typo ... "destionation" -> "destination"	9 years ago
tombuildsstuff	3a084b061a	Merge branch 'master' into f-oracle-merge	9 years ago
Jake Champlin	456d43e200	Merge remote-tracking branch 'origin/master' into f-oracle-compute	9 years ago
James Bardin	fb4a365d12	noop migrate copy, add -lock and -input ... A couple commits got rebased together here, and it's easier to enumerate them in a single commit. Skip copying of states during migration if they are the same state. This can happen when trying to reconfigure a backend's options, or if the state was manually transferred. This can fail unexpectedly with locking enabled. Honor the `-input` flag for all confirmations (the new test hit some more). Also unify where we reference the Meta.forceInitCopy and transfer the value to the existing backendMigrateOpts.force field.	9 years ago
James Bardin	aad143b6d1	set stateLock to true when building meta flagSet ... Any commands that use `stateLock` should have a flag to set that value, but set a failsafe to true just in case.	9 years ago
James Bardin	d059939f88	Merge pull request #13262 from hashicorp/jbardin/lock-timeouts ... lock timeouts	9 years ago
Radek Simko	fc72a20c66	command/hook_ui: Increase max length of state IDs (#13317)	9 years ago
Jake Champlin	edc524df55	provider/opc: Update OPC Provider ... Updates the OPC provider to a fully working version.	9 years ago
James Bardin	3d604851c2	test -lock-timeout from cli	9 years ago
James Bardin	5eca913b14	add cli flags for -lock-timeout ... Add the -lock-timeout flag to the appropriate commands. Add the -lock flag to `init` and `import` which were missing it. Set both stateLock and stateLockTimeout in Meta.flagsSet, and remove the extra references for clarity.	9 years ago
James Bardin	305ef43aa6	provide contexts to clistate.Lock calls ... Add fields required to create an appropriate context for all calls to clistate.Lock. Add missing checks for Meta.stateLock, where we would attempt to lock, even if locking should be skipped.	9 years ago
James Bardin	3f0dcd1308	Have the clistate Lock use LockWithContext ... - Have the ui Lock helper use state.LockWithContext. - Rename the message package to clistate, since that's how it's imported everywhere. - Use a more idiomatic placement of the Context in the LockWithContext args.	9 years ago
James Bardin	75458a182d	remove extra state.Locker assertions ... All states are lockers, so get rid of extra asertions.	9 years ago
James Bardin	8050eda52d	don't delete local state on a local backend ... Don't erase local state during backend migration if the new and old paths are the same. Skipping the confirmation and copy are handled in another patch, but the local state was always erased by default, even when it was our new state.	9 years ago
James Bardin	50023e9a60	honor `input=false` in state migration ... return an error when confirming a copy if -input=false	9 years ago
James Bardin	7d23e1ef20	add equivalent tests to meta_backend_test	9 years ago
James Bardin	c891ab50b7	detect when backend.Hash needs update ... It's possible to not change the backend config, but require updating the stored backend state by moving init options from the config file to the `-backend-config` flag. If the config is the same, but the hash doesn't match, update the stored state.	9 years ago
James Bardin	ff2d753062	add Rehash to terraform.BackendState ... This method mirrors that of config.Backend, so we can compare the configration of a backend read from a config vs that of a backend read from a state. This will prevent init from reinitializing when using `-backend-config` options that match the existing state.	9 years ago
Martin Atkins	76dca009e0	Allow escaped interpolation-like sequences in variable defaults ... The variable validator assumes that any AST node it gets from an interpolation walk is an indicator of an interpolation. Unfortunately, back in f223be15 we changed the interpolation walker to emit a LiteralNode as a way to signal that the result is a literal but not identical to the input due to escapes. The existence of this issue suggests a bit of a design smell in that the interpolation walker interface at first glance appears to skip over all literals, but it actually emits them in this one situation. In the long run we should perhaps think about whether the abstraction is right here, but this is a shallow, tactical change that fixes #13001.	9 years ago
Martin Atkins	21cd5595e2	Update stringer-generated files to new boilerplate ... golang/tools commit 23ca8a263 changed the format of the leading comment to comply with some new standards discussed here: https://golang.org/issue/13560 This is the result of running generate with the latest version of stringer. Everyone working on Terraform will need to update stringer after this is merged, to avoid reverting this: go get -u golang.org/x/tools/cmd/stringer	9 years ago
James Bardin	f172b4a023	Merge pull request #13105 from hashicorp/jbardin/command-env ... disallow env names that aren't url-safe	9 years ago
James Bardin	2cffa25235	Add test to verify that Validation isn't called ... The apply won't succeed because we don't have a valid plan, but this verifies that providing a plan file prevents Validation.	9 years ago
James Bardin	9d118325b3	Reject names that aren't url-safe ... Environment names can be used in a number of contexts, and should be properly escaped for safety. Since most state names are store in path structures, and often in a URL, use `url.PathEscape` to check for disallowed characters	9 years ago
James Bardin	8027fe9e08	Don't Validate if we have an execution plan ... The plan file should contain all data required to execute the apply operation. Validation requires interpolation, and the `file()` interpolation function may fail if the module files are not present. This is the case currently with how TFE executes plans.	9 years ago
James Bardin	54e536cfe0	add `-force-copy` option to init command ... The `-force-copy` option will suppress confirmation for copying state data. Modify some tests to use the option, making sure to leave coverage of the Input code path.	9 years ago
Mitchell Hashimoto	d01886a644	command: remove legacy remote state on migration ... Fixes #12871 We were forgetting to remove the legacy remote state from the actual state value when migrating. This only causes an issue when saving a plan since the plan contains the state itself and causes an error where both a backend + legacy state exist. If saved plans aren't used this causes no noticable issue. Due to buggy upgrades already existing in the wild, I also added code to clear the remote section if it exists in a standard unchanged backend	9 years ago
Mitchell Hashimoto	23505cc2a8	Merge pull request #12818 from hashicorp/b-legacy ... command: use backendinit instead of initializing legacy directly	9 years ago
James Bardin	434e78158a	Merge pull request #12812 from hashicorp/jbardin/hook-ui-race ... fix race in hook ui PreApply test	9 years ago
Mitchell Hashimoto	4f59576231	command: fix awkward wording in message	9 years ago
James Bardin	b9931c437d	fix race in hook ui PreApply test ... Fix a race in the PreApply test, and make the PreApply background task actually concealable.	9 years ago
Mitchell Hashimoto	96e38041ab	command: use backendinit instead of initializing legacy directly ... Fixes #12806 This should've been part of 2c19aa69d9 This is the same issue, just missed a spot. Tests are hard to cover for this since we're removing the legacy backends one by one, eventually it'll be gone. A good sign is that we don't import backendlegacy at all anymore in command/	9 years ago
Mitchell Hashimoto	c87f3dfdd5	command/init: add test for -backend-config k/v	9 years ago
Mitchell Hashimoto	df8529719c	command/init: backend-config accepts key=value pairs ... This augments backend-config to also accept key=value pairs. This should make Terraform easier to script rather than having to generate a JSON file. You must still specify the backend type as a minimal amount in configurations, example: ``` terraform { backend "consul" {} } ``` This is required because Terraform needs to be able to detect the _absense_ of that value for unsetting, if that is necessary at some point.	9 years ago
Mitchell Hashimoto	e1f4eca93c	command: apply needs to look at the right field for backend state ... Plans were properly encoding backend configuration but the apply was reading it from the wrong field. :( This meant that every apply from a plan was applying it locally with backends. This needs to get released ASAP.	9 years ago
Mitchell Hashimoto	25312c8985	command/push: update copy for remote state error	9 years ago
James Bardin	9bfa361e21	Merge pull request #12778 from hashicorp/jbardin/GH-12741 ... change to default state after backend migration	9 years ago
Mitchell Hashimoto	6921457601	Merge pull request #12777 from hashicorp/b-refresh-empty ... backend/local: allow refresh on empty/non-existent state	9 years ago
James Bardin	ea095eda87	change to default state after backend migration ... When migrating from a multi-state backend to a single-state backend, we have to ensure that our locally configured environment is changed back to "default", or we won't be able to access the new backend.	9 years ago
Mitchell Hashimoto	2be1f55cbb	backend/local: allow refresh on empty/non-existent state ... This allows a refresh on a non-existent or empty state file. We changed this in 0.9.0 to error which seemed reasonable but it turns out this complicates automation that runs refresh since it now needed to determine if the state file was empty before running. Its easier to just revert this into a warning with exit code zero. The reason this changed is because in 0.8.x and earlier, the output would be simply empty with exit code zero which seemed odd.	9 years ago
Mitchell Hashimoto	81639480fb	command: recompute config hash with ConfigFile set ... Fixes #12749 If we merge in an extra partial config we need to recompute the hash to compare with the old value to detect that change. This hash needs to NOT be stored and just used as a temporary. We want to keep the original hash in the state so that we don't detect a change from the config (since the config will always be partial).	9 years ago
Mitchell Hashimoto	87201ec854	command/push: test for push with new backends	9 years ago
Mitchell Hashimoto	8b208a597d	command/push: don't allow pushing with local backend	9 years ago
Radek Simko	4448e45678	Merge pull request #12372 from hashicorp/f-kubernetes ... kubernetes: Add provider + namespace resource	9 years ago
Mitchell Hashimoto	f7964194eb	command: fix odd formatting that snuck in	9 years ago
Mitchell Hashimoto	d475fc29a8	command: test that terraform meta information is passed through	9 years ago
Radek Simko	f1db0fcf9b	kubernetes: Add provider + namespace resource	9 years ago
Radek Simko	4d6242dfe0	command: Add tests for UiHook (#12447)	9 years ago
Sean Chittenden	17fb98afa2	Circonus Provider (#12338) ... * Begin stubbing out the Circonus provider. * Remove all references to `reverse:secret_key`. This value is dynamically set by the service and unused by Terraform. * Update the `circonus_check` resource. Still a WIP. * Add docs for the `circonus_check` resource. Commit miss, this should have been included in the last commit. * "Fix" serializing check tags I still need to figure out how I can make them order agnostic w/o using a TypeSet. I'm worried that's what I'm going to have to do. * Spike a quick circonus_broker data source. * Convert tags to a Set so the order does not matter. * Add a `circonus_account` data source. * Correctly spell account. Pointed out by: @postwait * Add the `circonus_contact_group` resource. * Push descriptions into their own file in order to reduce the busyness of the schema when reviewing code. * Rename `circonus_broker` and `broker` to `circonus_collector` and `collector`, respectively. Change made with concent by Circonus to reduce confusion (@postwait, @maier, and several others). * Use upstream contsants where available. * Import the latest circonus-gometrics. * Move to using a Set of collectors vs a list attached to a single attribute. * Rename "cid" to "id" in the circonus_account data source and elsewhere where possible. * Inject a tag automatically. Update gometrics. * Checkpoint `circonus_metric` resource. * Enable provider-level auto-tagging. This is disabled by default. * Rearrange metric. This is an experimental "style" of a provider. We'll see. That moment. When you think you've gone off the rails on a mad scientist experiment but like the outcome and think you may be onto something but haven't proven it to yourself or anyone else yet? That. That exact feeling of semi-confidence while being alone in the wilderness. Please let this not be the Terraform provider equivalent of DJB's C style of coding. We'll know in another resource or two if this was a horrible mistake or not. * Begin moving `resource_circonus_check` over to the new world order/structure: Much of this is WIP and incomplete, but here is the new supported structure: ``` variable "used_metric_name" { default = "_usage`0`_used" } resource "circonus_check" "usage" { # collectors = ["${var.collectors}"] collector { id = "${var.collectors[0]}" } name = "${var.check_name}" notes = "${var.notes}" json { url = "https://${var.target}/account/current" http_headers = { "Accept" = "application/json" "X-Circonus-App-Name" = "TerraformCheck" "X-Circonus-Auth-Token" = "${var.api_token}" } } stream { name = "${circonus_metric.used.name}" tags = "${circonus_metric.used.tags}" type = "${circonus_metric.used.type}" } tags = { source = "circonus" } } resource "circonus_metric" "used" { name = "${var.used_metric_name}" tags = { source = "circonus" } type = "numeric" } ``` * Document the `circonus_metric` resource. * Updated `circonus_check` docs. * If a port was present, automatically set it in the Config. * Alpha sort the check parameters now that they've been renamed. * Fix a handful of panics as a result of the schema changing. * Move back to a `TypeSet` for tags. After a stint with `TypeMap`, move back to `TypeSet`. A set of strings seems to match the API the best. The `map` type was convenient because it reduced the amount of boilerplate, but you loose out on other things. For instance, tags come in the form of `category:value`, so naturally it seems like you could use a map, but you can't without severe loss of functionality because assigning two values to the same category is common. And you can't normalize map input or suppress the output correctly (this was eventually what broke the camel's back). I tried an experiment of normalizing the input to be `category:value` as the key in the map and a value of `""`, but... seee diff suppress. In this case, simple is good. While here bring some cleanups to _Metric since that was my initial testing target. * Rename `providerConfig` to `_ProviderConfig` * Checkpoint the `json` check type. * Fix a few residual issues re: missing descriptions. * Rename `validateRegexp` to `_ValidateRegexp` * Use tags as real sets, not just a slice of strings. * Move the DiffSuppressFunc for tags down to the Elem. * Fix up unit tests to chase the updated, default hasher function being used. * Remove `Computed` attribute from `TypeSet` objects. This fixes a pile of issues re: update that I was having. * Rename functions. `GetStringOk` -> `GetStringOK` `GetSetAsListOk` -> `GetSetAsListOK` `GetIntOk` -> `GetIntOK` * Various small cleanups and comments rolled into a single commit. * Add a `postgresql` check type for the `circonus_check` resource. * Rename various validator functions to be _CapitalCase vs capitalCase. * Err... finish the validator renames. * Add `GetFloat64()` support. * Add `icmp_ping` check type support. * Catch up to the _API*Attr renames. Deliberately left out of the previous commit in order to create a clean example of what is required to add a new check type to the `circonus_check` resource. * Clarify when the `target` attribute is required for the `postgresql` check type. * Correctly pull the metric ID attribute from the right location. * Add a circonus_stream_group resource (a.k.a. a Circonus "metric cluster") * Add support for the [`caql`](https://login.circonus.com/user/docs/caql_reference) check type. * Add support for the `http` check type. * `s/SSL/TLS/g` * Add support for `tcp` check types. * Enumerate the available metrics that are supported for each check type. * Add [`cloudwatch`](https://login.circonus.com/user/docs/Data/CheckTypes/CloudWatch) check type support. * Add a `circonus_trigger` resource (a.k.a Circonus Ruleset). * Rename a handful of functions to make it clear in the function name the direction of flow for information moving through the provider. TL;DR: Replace `parse` and `read` with "foo to bar"-like names. * Fix the attribute name used in a validator. Absent != After. * Set the minimum `absent` predicate to 70s per testing. * Fix the regression tests for circonus_trigger now that absent has a 70s min * Fix up the `tcp` check to require a `host` attribute. Fix tests. It's clear I didn't run these before committing/pushing the `tcp` check last time. * Fix `circonus_check` for `cloudwatch` checks. * Rename `parsePerCheckTypeConfig()` to `_CheckConfigToAPI` to be consistent with other function names. grep(1)ability of code++ * Slack buttons as an integer are string encoded. * Fix updates for `circonus_contact`. * Fix the out parameters for contact groups. * Move to using `_CastSchemaToTF()` where appropriate. * Fix circonus_contact_group. Updates work as expected now. * Use `_StateSet()` in place of `d.Set()` everywhere. * Make a quick pass over the collector datasource to modernize its style * Quick pass for items identified by `golint`. * Fix up collectors * Fix the `json` check type. Reconcile possible sources of drift. Update now works as expected. * Normalize trigger durations to seconds. * Improve the robustness of the state handling for the `circonus_contact_group` resource. * I'm torn on this, but sort the contact groups in the notify list. This does mean that if the first contact group in the list has a higher lexical sort order the plan won't converge until the offending resource is tainted and recreated. But there's also some sorting happening elsewhere, so.... sort and taint for now and this will need to be revisited in the future. * Add support for the `httptrap` check type. * Remove empty units from the state file. * Metric clusters can return a 404. Detect this accordingly in its respective Exists handler. * Add a `circonus_graph` resource. * Fix a handful of bugs in the graph provider. * Re-enable the necessary `ConflictsWith` definitions and normalize attribute names. * Objects that have been deleted via the UI return a 404. Handle in Exists(). * Teach `circonus_graph`'s Stack set to accept nil values. * Set `ForceNew: true` for a graph's name. * Chase various API fixes required to make `circonus_graph` work as expected. * Fix up the handling of sub-1 zoom resolutions for graphs. * Add the `check_by_collector` out parameter to the `circonus_check` resource. * Improve validation of line vs area graphs. Fix graph_style. * Fix up the `logarithmic` graph axis option. * Resolve various trivial `go vet` issues. * Add a stream_group out parameter. * Remove incorrectly applied `Optional` attributes to the `circonus_account` resource. * Remove various `Optional` attributes from the `circonus_collector` data source. * Centralize the common need to suppress leading and trailing whitespace into `suppressWhitespace`. * Sync up with upstream vendor fixes for circonus_graph. * Update the checksum value for the http check. * Chase `circonus_graph`'s underlying `line_style` API object change from `string` to `*string`. * Clean up tests to use a generic terraform regression testing account. * Add support for the MySQL to the `circonus_check` resource. * Begin stubbing out the Circonus provider. * Remove all references to `reverse:secret_key`. This value is dynamically set by the service and unused by Terraform. * Update the `circonus_check` resource. Still a WIP. * Add docs for the `circonus_check` resource. Commit miss, this should have been included in the last commit. * "Fix" serializing check tags I still need to figure out how I can make them order agnostic w/o using a TypeSet. I'm worried that's what I'm going to have to do. * Spike a quick circonus_broker data source. * Convert tags to a Set so the order does not matter. * Add a `circonus_account` data source. * Correctly spell account. Pointed out by: @postwait * Add the `circonus_contact_group` resource. * Push descriptions into their own file in order to reduce the busyness of the schema when reviewing code. * Rename `circonus_broker` and `broker` to `circonus_collector` and `collector`, respectively. Change made with concent by Circonus to reduce confusion (@postwait, @maier, and several others). * Use upstream contsants where available. * Import the latest circonus-gometrics. * Move to using a Set of collectors vs a list attached to a single attribute. * Rename "cid" to "id" in the circonus_account data source and elsewhere where possible. * Inject a tag automatically. Update gometrics. * Checkpoint `circonus_metric` resource. * Enable provider-level auto-tagging. This is disabled by default. * Rearrange metric. This is an experimental "style" of a provider. We'll see. That moment. When you think you've gone off the rails on a mad scientist experiment but like the outcome and think you may be onto something but haven't proven it to yourself or anyone else yet? That. That exact feeling of semi-confidence while being alone in the wilderness. Please let this not be the Terraform provider equivalent of DJB's C style of coding. We'll know in another resource or two if this was a horrible mistake or not. * Begin moving `resource_circonus_check` over to the new world order/structure: Much of this is WIP and incomplete, but here is the new supported structure: ``` variable "used_metric_name" { default = "_usage`0`_used" } resource "circonus_check" "usage" { # collectors = ["${var.collectors}"] collector { id = "${var.collectors[0]}" } name = "${var.check_name}" notes = "${var.notes}" json { url = "https://${var.target}/account/current" http_headers = { "Accept" = "application/json" "X-Circonus-App-Name" = "TerraformCheck" "X-Circonus-Auth-Token" = "${var.api_token}" } } stream { name = "${circonus_metric.used.name}" tags = "${circonus_metric.used.tags}" type = "${circonus_metric.used.type}" } tags = { source = "circonus" } } resource "circonus_metric" "used" { name = "${var.used_metric_name}" tags = { source = "circonus" } type = "numeric" } ``` * Document the `circonus_metric` resource. * Updated `circonus_check` docs. * If a port was present, automatically set it in the Config. * Alpha sort the check parameters now that they've been renamed. * Fix a handful of panics as a result of the schema changing. * Move back to a `TypeSet` for tags. After a stint with `TypeMap`, move back to `TypeSet`. A set of strings seems to match the API the best. The `map` type was convenient because it reduced the amount of boilerplate, but you loose out on other things. For instance, tags come in the form of `category:value`, so naturally it seems like you could use a map, but you can't without severe loss of functionality because assigning two values to the same category is common. And you can't normalize map input or suppress the output correctly (this was eventually what broke the camel's back). I tried an experiment of normalizing the input to be `category:value` as the key in the map and a value of `""`, but... seee diff suppress. In this case, simple is good. While here bring some cleanups to _Metric since that was my initial testing target. * Rename `providerConfig` to `_ProviderConfig` * Checkpoint the `json` check type. * Fix a few residual issues re: missing descriptions. * Rename `validateRegexp` to `_ValidateRegexp` * Use tags as real sets, not just a slice of strings. * Move the DiffSuppressFunc for tags down to the Elem. * Fix up unit tests to chase the updated, default hasher function being used. * Remove `Computed` attribute from `TypeSet` objects. This fixes a pile of issues re: update that I was having. * Rename functions. `GetStringOk` -> `GetStringOK` `GetSetAsListOk` -> `GetSetAsListOK` `GetIntOk` -> `GetIntOK` * Various small cleanups and comments rolled into a single commit. * Add a `postgresql` check type for the `circonus_check` resource. * Rename various validator functions to be _CapitalCase vs capitalCase. * Err... finish the validator renames. * Add `GetFloat64()` support. * Add `icmp_ping` check type support. * Catch up to the _API*Attr renames. Deliberately left out of the previous commit in order to create a clean example of what is required to add a new check type to the `circonus_check` resource. * Clarify when the `target` attribute is required for the `postgresql` check type. * Correctly pull the metric ID attribute from the right location. * Add a circonus_stream_group resource (a.k.a. a Circonus "metric cluster") * Add support for the [`caql`](https://login.circonus.com/user/docs/caql_reference) check type. * Add support for the `http` check type. * `s/SSL/TLS/g` * Add support for `tcp` check types. * Enumerate the available metrics that are supported for each check type. * Add [`cloudwatch`](https://login.circonus.com/user/docs/Data/CheckTypes/CloudWatch) check type support. * Add a `circonus_trigger` resource (a.k.a Circonus Ruleset). * Rename a handful of functions to make it clear in the function name the direction of flow for information moving through the provider. TL;DR: Replace `parse` and `read` with "foo to bar"-like names. * Fix the attribute name used in a validator. Absent != After. * Set the minimum `absent` predicate to 70s per testing. * Fix the regression tests for circonus_trigger now that absent has a 70s min * Fix up the `tcp` check to require a `host` attribute. Fix tests. It's clear I didn't run these before committing/pushing the `tcp` check last time. * Fix `circonus_check` for `cloudwatch` checks. * Rename `parsePerCheckTypeConfig()` to `_CheckConfigToAPI` to be consistent with other function names. grep(1)ability of code++ * Slack buttons as an integer are string encoded. * Fix updates for `circonus_contact`. * Fix the out parameters for contact groups. * Move to using `_CastSchemaToTF()` where appropriate. * Fix circonus_contact_group. Updates work as expected now. * Use `_StateSet()` in place of `d.Set()` everywhere. * Make a quick pass over the collector datasource to modernize its style * Quick pass for items identified by `golint`. * Fix up collectors * Fix the `json` check type. Reconcile possible sources of drift. Update now works as expected. * Normalize trigger durations to seconds. * Improve the robustness of the state handling for the `circonus_contact_group` resource. * I'm torn on this, but sort the contact groups in the notify list. This does mean that if the first contact group in the list has a higher lexical sort order the plan won't converge until the offending resource is tainted and recreated. But there's also some sorting happening elsewhere, so.... sort and taint for now and this will need to be revisited in the future. * Add support for the `httptrap` check type. * Remove empty units from the state file. * Metric clusters can return a 404. Detect this accordingly in its respective Exists handler. * Add a `circonus_graph` resource. * Fix a handful of bugs in the graph provider. * Re-enable the necessary `ConflictsWith` definitions and normalize attribute names. * Objects that have been deleted via the UI return a 404. Handle in Exists(). * Teach `circonus_graph`'s Stack set to accept nil values. * Set `ForceNew: true` for a graph's name. * Chase various API fixes required to make `circonus_graph` work as expected. * Fix up the handling of sub-1 zoom resolutions for graphs. * Add the `check_by_collector` out parameter to the `circonus_check` resource. * Improve validation of line vs area graphs. Fix graph_style. * Fix up the `logarithmic` graph axis option. * Resolve various trivial `go vet` issues. * Add a stream_group out parameter. * Remove incorrectly applied `Optional` attributes to the `circonus_account` resource. * Remove various `Optional` attributes from the `circonus_collector` data source. * Centralize the common need to suppress leading and trailing whitespace into `suppressWhitespace`. * Sync up with upstream vendor fixes for circonus_graph. * Update the checksum value for the http check. * Chase `circonus_graph`'s underlying `line_style` API object change from `string` to `*string`. * Clean up tests to use a generic terraform regression testing account. * Rename all identifiers that began with a `_` and replace with a corresponding lowercase glyph. * Remove stale comment in types. * Move the calls to `ResourceData`'s `SetId()` calls to be first in the list so that no resources are lost in the event of a `panic()`. * Remove `stateSet` from the `circonus_trigger` resource. * Remove `stateSet` from the `circonus_stream_group` resource. * Remove `schemaSet` from the `circonus_graph` resource. * Remove `stateSet` from the `circonus_contact` resource. * Remove `stateSet` from the `circonus_metric` resource. * Remove `stateSet` from the `circonus_account` data source. * Remove `stateSet` from the `circonus_collector` data source. * Remove stray `stateSet` call from the `circonus_contact` resource. This is an odd artifact to find... I'm completely unsure as to why it was there to begin with but am mostly certain it's a bug and needs to be removed. * Remove `stateSet` from the `circonus_check` resource. * Remove the `stateSet` helper function. All call sites have been converted to return errors vs `panic()`'ing at runtime. * Remove a pile of unused functions and type definitions. * Remove the last of the `attrReader` interface. * Remove an unused `Sprintf` call. * Update `circonus-gometrics` and remove unused files. * Document what `convertToHelperSchema()` does. Rename `castSchemaToTF` to `convertToHelperSchema`. Change the function parameter ordering so the `map` of attribute descriptions: this is much easier to maintain when the description map is first when creating schema inline. * Move descriptions into their respective source files. * Remove all instances of `panic()`. In the case of software bugs, log an error. Never `panic()` and always return a value. * Rename `stream_group` to `metric_cluster`. * Rename triggers to rule sets * Rename `stream` to `metric`. * Chase the `stream` -> `metric` change into the docs. * Remove some unused test functions. * Add the now required `color` attribute for graphing a `metric_cluster`. * Add a missing description to silence a warning. * Add `id` as a selector for the account data source. * Futureproof testing: Randomize all asset names to prevent any possible resource conflicts. This isn't a necessary change for our current build and regression testing, but *just in case* we have a radical change to our testing framework in the future, make all resource names fully random. * Rename various values to match the Circonus docs. * s/alarm/alert/g * Ensure ruleset criteria can not be empty.	9 years ago
James Bardin	200d5787ca	Merge pull request #12433 from hashicorp/jbardin/extra-args ... missing args assignment after parsing flags	9 years ago
Clint	5d894e4ffd	Fix up command and some go fmt issues (#12509)	9 years ago
Paul Stack	b57e0bee2a	provider/datadog: Update to datadog_monitor still used d.GetOk (#12497) ... Fixes: #12494 The Create was changed to use the default and not d.GetOk - the update wasn't - this was causing issues when trying to update to a false value ``` % make testacc TEST=./builtin/providers/datadog ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/07 16:20:54 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/datadog -v -timeout 120m === RUN TestDatadogMonitor_import --- PASS: TestDatadogMonitor_import (4.77s) === RUN TestDatadogUser_import --- PASS: TestDatadogUser_import (6.23s) === RUN TestProvider --- PASS: TestProvider (0.00s) === RUN TestProvider_impl --- PASS: TestProvider_impl (0.00s) === RUN TestAccDatadogMonitor_Basic --- PASS: TestAccDatadogMonitor_Basic (3.83s) === RUN TestAccDatadogMonitor_BasicNoTreshold --- PASS: TestAccDatadogMonitor_BasicNoTreshold (4.92s) === RUN TestAccDatadogMonitor_Updated --- PASS: TestAccDatadogMonitor_Updated (5.88s) === RUN TestAccDatadogMonitor_TrimWhitespace --- PASS: TestAccDatadogMonitor_TrimWhitespace (3.23s) === RUN TestAccDatadogMonitor_Basic_float_int --- PASS: TestAccDatadogMonitor_Basic_float_int (5.73s) === RUN TestAccDatadogTimeboard_update --- PASS: TestAccDatadogTimeboard_update (8.86s) === RUN TestValidateAggregatorMethod --- PASS: TestValidateAggregatorMethod (0.00s) === RUN TestAccDatadogUser_Updated --- PASS: TestAccDatadogUser_Updated (6.05s) PASS ok github.com/hashicorp/terraform/builtin/providers/datadog 49.506s ```	9 years ago
James Bardin	e58a02405e	missing args assignment after parsing flags ... `env list` was missing the args re-assignment after parsing the flags. This is only a problem if the variables are automatically be populated as arguments from a tfvars file.	9 years ago
Mitchell Hashimoto	03493f7d46	command: validate backend config ... The validation itself was added a couple weeks ago but I forgot to actually call it. :sad:	9 years ago
Mitchell Hashimoto	d1b930d5b5	command: remove unused test	9 years ago
Mitchell Hashimoto	0224a12a00	command: fix go vet	9 years ago
Mitchell Hashimoto	5086f9f568	command: remove log	9 years ago
Mitchell Hashimoto	866de2776e	command: trigger still applying cancellations from a channel	9 years ago
Radek Simko	17c9a403f2	WIP	9 years ago
Radek Simko	08283f077b	command: Fix crash caused by empty state	9 years ago
Radek Simko	2e2b8686dd	command: Display state ID in PreApply+PostApply (#12261)	9 years ago
Mitchell Hashimoto	868230ee60	command/state-push: fix go vet	9 years ago
Mitchell Hashimoto	ee985a606c	Merge pull request #12350 from hashicorp/b-state-push-stdin ... command/state-push: support pushing from stdin	9 years ago
Mitchell Hashimoto	f735205677	Merge pull request #12349 from hashicorp/b-ux ... command: color changes, trimming newlines	9 years ago
Mitchell Hashimoto	a6b2eca613	command/state-push: support pushing from stdin	9 years ago
Mitchell Hashimoto	1f614bd4d6	command: color changes, trimming newlines	9 years ago
Mitchell Hashimoto	e1a63e6b7f	Merge pull request #12348 from hashicorp/b-state-pull-crash ... command: fix crash on state pull with empty state	9 years ago
Mitchell Hashimoto	bdde7d845a	Merge pull request #12347 from hashicorp/b-env-migrate ... command: migrating envs when changing backends	9 years ago
Mitchell Hashimoto	7f6a99404d	command: fix crash on state pull with empty state ... When you have no state (no local state or you just switched to a new env) and run `terraform state pull`, it would crash.	9 years ago
Mitchell Hashimoto	549d525487	Merge pull request #12320 from hashicorp/b-legacy-state ... command: fix loading legacy remote state + migration guide	9 years ago
Mitchell Hashimoto	1e3d452613	command: multistate to multistate conversions	9 years ago
Mitchell Hashimoto	c82d7dd56c	command: multi-state (non-default env) to single state	9 years ago
Mitchell Hashimoto	e75b666591	command: test multi-state to single state	9 years ago
Mitchell Hashimoto	3ef82e6b5f	command: test multi-state with default only to single state	9 years ago
Mitchell Hashimoto	1d8b76c89d	command: initial work on migrating envs, basic cases first	9 years ago
James Bardin	39a5ddd381	Split Meta back out of StateMeta ... Removing the call to StateMeta.Env, so that it doesn't need an embedded Meta field. Embed Meta and StateMeta separately in all State commands.	9 years ago
Mitchell Hashimoto	2c19aa69d9	command: legacy remote state should load from backendinit	9 years ago
James Bardin	4dac986a91	Local.StatePaths doesn't need to reutrn an error ... add a test to ensure we have consistent output	9 years ago
James Bardin	dc675540de	fix rebased tests	9 years ago
James Bardin	b53704ed87	Thread the environment through all commands ... Add Env and SetEnv methods to command.Meta to retrieve the current environment name inside any command. Make sure all calls to Backend.State contain an environment name, and make the package compile against the update backend package.	9 years ago
James Bardin	2a73331c62	use State.HasResources rather than State.Empty ... Destroying a terraform state can't always create an empty state, as outputs and the root module may remain. Use HasResources to warn about deleting an environment with resources.	9 years ago
James Bardin	06663991d1	Add config path argument to env commands ... In order to operate in parity with other commands, the env command should take a path argument to locate the configuration. This however introduces the issue of a possible name conflict between a path and subcommand, or printing an incorrect current environment for the bare `env` command. In favor of simplicity this removes the current env output and only prints usage when no subcommand is provided.	9 years ago
James Bardin	c8526484b3	split the env command into subcommands	9 years ago
James Bardin	31f033827f	Add basic env commands ... Used a single command with flags for now. We may refactor this out to subcommands.	9 years ago
James Bardin	1ea9413c07	Remove state path handling from commands ... The Local backend is now responsible for handling the paths to the local state files, since they are dependent on the current environment.	9 years ago
Mitchell Hashimoto	3cedfa00f4	command: use backend.CLIIinit ... I made this interface way back with the original backend work and I guess I forgot to hook it up! This is becoming an issue as I'm working on our 2nd enhanced backend that requires this information and I realized it was hardcoded before. This propertly uses the CLIInit interface allowing any backend to gain access to this data.	9 years ago
James Bardin	80389375b5	Fix the Push test outputs ... Change the expected outputs in the Push tests to match the quotes map keys.	9 years ago
James Bardin	71c541c65c	always quote hcl map keys ... HCL identifiers may need to be quoted, so always quote them to be safe.	9 years ago
James Bardin	d596d6e761	Revert "always quote hcl map keys" ... This reverts commit 43f62d2630.	9 years ago
James Bardin	43f62d2630	always quote hcl map keys ... HCL identifiers may need to be quoted, so always quote them to be safe.	9 years ago
James Bardin	43c7bd648c	fix sorting of module resources during state mv ... Module resource were being sorted lexically by name by the state filter. If there are 10 or more resources, the order won't match the index order, and resources will have different indexes in their new location. Sort the FilterResults by index numerically when the names match. Clean up the module String output for visual inspection by sorting Resource name parts numerically when they are an integer value.	9 years ago
Mitchell Hashimoto	4c7c46bf40	command: fix test for new Meta type	9 years ago
Mitchell Hashimoto	8f11068ab2	Merge pull request #12173 from hashicorp/b-remote-state-ds ... providers/terraform: remote state data source supports backends	9 years ago
Mitchell Hashimoto	d2d87bccf0	Merge pull request #12155 from hashicorp/b-state-backend ... command: refresh state in old commands for backend	9 years ago
Mitchell Hashimoto	ebb22d3ecd	backend/local: don't RefreshState on State API	9 years ago
Liran Polak	f37800ae62	New Provider: Spotinst (#5001) ... * providers/spotinst: Add support for Spotinst resources * providers/spotinst: Fix merge conflict - layouts/docs.erb * docs/providers/spotinst: Fix the resource description field * providers/spotinst: Fix the acceptance tests * providers/spotinst: Mark the device_index as a required field * providers/spotinst: Change the associate_public_ip_address field to TypeBool * docs/providers/spotinst: Update the description of the adjustment field * providers/spotinst: Rename IamRole to IamInstanceProfile to make it more compatible with the AWS provider * docs/providers/spotinst: Rename iam_role to iam_instance_profile * providers/spotinst: Deprecate the iam_role attribute * providers/spotinst: Fix a misspelled var (IamRole) * providers/spotinst: Fix possible null pointer exception related to "iam_instance_profile" * docs/providers/spotinst: Add "load_balancer_names" missing description * providers/spotinst: New resource "spotinst_subscription" added * providers/spotinst: Eliminate a possible null pointer exception in "spotinst_aws_group" * providers/spotinst: Eliminate a possible null pointer exception in "spotinst_subscription" * providers/spotinst: Mark spotinst_subscription as deleted in destroy * providers/spotinst: Add support for custom event format in spotinst_subscription * providers/spotinst: Disable the destroy step of spotinst_subscription * providers/spotinst: Add support for update subscriptions * providers/spotinst: Merge fixed conflict - layouts/docs.erb * providers/spotinst: Vendor dependencies * providers/spotinst: Return a detailed error message * provider/spotinst: Update the plugin list * providers/spotinst: Vendor dependencies using govendor * providers/spotinst: New resource "spotinst_healthcheck" added * providers/spotinst: Update the Spotinst SDK * providers/spotinst: Comment out unnecessary log.Printf * providers/spotinst: Fix the acceptance tests * providers/spotinst: Gofmt fixes * providers/spotinst: Use multiple functions to expand each block * providers/spotinst: Allow ondemand_count to be zero * providers/spotinst: Change security_group_ids from TypeSet to TypeList * providers/spotinst: Remove unnecessary `ForceNew` fields * providers/spotinst: Update the Spotinst SDK * providers/spotinst: Add support for capacity unit * providers/spotinst: Add support for EBS volume pool * providers/spotinst: Delete health check * providers/spotinst: Allow to set multiple availability zones * providers/spotinst: Gofmt * providers/spotinst: Omit empty strings from the load_balancer_names field * providers/spotinst: Update the Spotinst SDK to v1.1.9 * providers/spotinst: Add support for new strategy parameters * providers/spotinst: Update the Spotinst SDK to v1.2.0 * providers/spotinst: Add support for Kubernetes integration * providers/spotinst: Fix merge conflict - vendor/vendor.json * providers/spotinst: Update the Spotinst SDK to v1.2.1 * providers/spotinst: Add support for Application Load Balancers * providers/spotinst: Do not allow to set ondemand_count to 0 * providers/spotinst: Update the Spotinst SDK to v1.2.2 * providers/spotinst: Add support for scaling policy operators * providers/spotinst: Add dimensions to spotinst_aws_group tests * providers/spotinst: Allow both ARN and name for IAM instance profiles * providers/spotinst: Allow ondemand_count=0 * providers/spotinst: Split out the set funcs into flatten style funcs * providers/spotinst: Update the Spotinst SDK to v1.2.3 * providers/spotinst: Add support for EBS optimized flag * providers/spotinst: Update the Spotinst SDK to v2.0.0 * providers/spotinst: Use stringutil.Stringify for debugging * providers/spotinst: Update the Spotinst SDK to v2.0.1 * providers/spotinst: Key pair is now optional * providers/spotinst: Make sure we do not nullify signals on strategy update * providers/spotinst: Hash both Strategy and EBS Block Device * providers/spotinst: Hash AWS load balancer * providers/spotinst: Update the Spotinst SDK to v2.0.2 * providers/spotinst: Verify namespace exists before appending policy * providers/spotinst: Image ID will be in a separate block from now on, so as to allow ignoring changes only on the image ID. This change is backwards compatible. * providers/spotinst: user data decoded when returned from spotinst api, so that TF compares the two states properly, and does not update without cause.	9 years ago
Mitchell Hashimoto	478a7dbfe7	command: convert to using backend/init	9 years ago
Mitchell Hashimoto	e4d2193ed6	command/state: mv and rm -backup works ... Fixes #12154 The "-backup" flag before for "state *" CLI had some REALLY bizarre behavior: it would change the _destination_ state and actually not create any additional backup at all (the original state was unchanged and the normal timestamped backup still are written). Really weird. This PR makes the -backup flag work as you'd expect with one caveat: we'll _still_ create the timestamped backup file. The timestamped backup file helps make sure that you always get a backup history when using these commands. We don't want to make it easy for you to overwrite a state with the `-backup` flag.	9 years ago
Mitchell Hashimoto	6e1dc9c77d	command: extra RefreshState calls	9 years ago
Mitchell Hashimoto	ad1ba7c2b1	command/state list: test against backend	9 years ago
James Bardin	c080334c3f	Merge pull request #12069 from hashicorp/jbardin/state-locking ... Add inmem remote backend	9 years ago
James Bardin	d710ecbd4d	Fix regression from not having an real unlock test ... args were sliced incorrectly.	9 years ago
James Bardin	5095d7c6a7	Add complete unlock test ... Test actual unlock failure and success through the the unlock command.	9 years ago
clint shryock	be6ae20ac1	Merge branch 'pr-8299' ... * pr-8299: Patch up website docs provider/dns: DNS dynamic updates (RFC 2136) vendor: Capture new dependency miekg-dns	9 years ago
Chris Paris	5812bae27f	RefreshState in output command	9 years ago
Mitchell Hashimoto	716132431a	command/init: initialize backend even if not set in the config ... We need to initialize the backend even if the config has no backend set. This allows `init` to work when unsetting a previously set backend. Without this, there was no way to unset a backend.	9 years ago
James Bardin	a372e9c54b	fix state migration lock info	9 years ago
James Bardin	ec00564be6	Clean up LockInfo and LockError and use them ... Gove LockInfo a Marshal method for easy serialization, and a String method for more readable output. Have the state.Locker implementations use LockError when possible to return LockInfo and an error.	9 years ago
James Bardin	f2e496a14c	Have backend operations properly unlock state ... Make sure unlock is called with the correct LockID during operations	9 years ago
James Bardin	f5ed8cd288	Use NewLockInfo to get a pre-populated value ... Using NewLockInfo ensure we start with all required fields filled.	9 years ago
James Bardin	4f0c465187	make command tests pass with new state.Locker	9 years ago
James Bardin	67dc16c9ca	Make backend/local test pass	9 years ago
Mitchell Hashimoto	b7a143fffb	command/state: improved error message on state lock fail	9 years ago
Mitchell Hashimoto	18bc77c359	command/state: up the threshold for showing lock info	9 years ago
Mitchell Hashimoto	90f3d40c1f	command: use new state lock/unlock helpers for better UX	9 years ago
Mitchell Hashimoto	34f438b635	command/state: helpers for UX with lock/unlock state	9 years ago
Kazumichi Yamamoto	cd7f69ab11	New provider arukas (#11171) ... * Add a Arukas provider * Add dependencies for the Arukas provider * Add documents for the Arukas	9 years ago
George Hartzell	e39f4e1993	Typo: determien -> determine (#11888)	10 years ago
Roberto Jung Drebes	e3934c23c8	provider/dns: DNS dynamic updates (RFC 2136)	10 years ago
James Bardin	0c1b138719	Add state locking during backend init ... During backend initialization, especially during a migration, there is a chance that an existing state could be overwritten. Attempt to get a locks when writing the new state. It would be nice to always have a lock when reading the states, but the recursive structure of the Meta.Backend config functions makes that quite complex.	10 years ago
James Bardin	5c2e945b3c	Fix format string and typos	10 years ago
Mitchell Hashimoto	a5ab6e447b	command/apply: update help text to be "parallel" instead of concurrent	10 years ago
James Bardin	5ca5a3c78a	Merge pull request #11724 from hashicorp/jbardin/state-locking ... add force-unlock command	10 years ago
James Bardin	65abe98047	Remove lock command and rename lock/force-unlock ... Remove the lock command for now to avoid confusion about the behavior of locks. Rename lock to force-unlock to make it more aparent what it does. Add a success message, and chose red because it can be a dangerous operation. Add confirmation akin to `destroy`, and a `-force` option for automation and testing.	10 years ago
Mitchell Hashimoto	0c97c5a3d9	command: tests should move to temporary cwd ... This fixes any issues where rogue tfstate files may appear in the cwd otherwise.	10 years ago
James Bardin	015198ca11	Add lock/unlock commands	10 years ago
James Bardin	b80ae5e13e	Add source path argument to testLockState ... The new test pattern is to chdir into a temp location for the test, but the prevents us from locating the testdata directory in the source. Add a source path to testLockState so we can find the statelocker.go source.	10 years ago
James Bardin	eb8e5ac739	Change CLI flag to '-lock'	10 years ago
James Bardin	07903189f1	s/Meta.lockState/Meta.stateLock/g	10 years ago
James Bardin	cd96bb5aca	Add test/untaint tests with locked state ... add missing lock-state flag to untaint	10 years ago
James Bardin	82e59cd826	Add test for destroy with locked state	10 years ago
James Bardin	9fa436e0bd	Add test for locked state in plan	10 years ago
James Bardin	f3e4c05250	build the statelocker binary before running ... this way we can signal it directly to amke sure it exits cleanly.	10 years ago
James Bardin	bd65ddbcaa	Add test for apply/refresh on locked state files ... Verify that these operations fail when a state file is locked.	10 years ago
James Bardin	fb60b6f6f2	Add separate program for locking state files ... Depending on the implementation, local state locks may be reentrant within the same process. Use a separate process to test locked state files.	10 years ago
James Bardin	6a20c35d61	apply-test	10 years ago
James Bardin	91608843a4	Add state locking in taint/untaint	10 years ago
James Bardin	a157ebbccd	add -lock-state usage to plan/refresh/apply/destr	10 years ago
James Bardin	94f2f4d6ae	Create state files first for backup tests ... Previously when runnign a plan with no exitsing state, the plan would be written out and then backed up on the next WriteState by another BackupState instance. Since we now maintain a single State instance thoughout an operation, the backup happens before any state exists so no backup file is created. This is OK, as the backup state the tests were checking for is from the plan file, which already exists separate from the state.	10 years ago
James Bardin	dd19cb202d	add locking to plan and refresh commands	10 years ago
James Bardin	9cdba1f199	enable local state locking for apply ... Have the LocalBackend lock the state during operations, and enble this for the apply comand.	10 years ago
James Bardin	9acb86a182	Merge pull request #11187 from hashicorp/jbardin/state-locking ... State Locking initial implementations	10 years ago
Seth Vargo	0d39123cb0	Update error message when no outputs are defined ... Terraform can't tell the difference between an empty output and an undefined output. This is often confusing for folks using interpolation. As much as it would be great to fix upstream, changing this error message to be a bit more helpful is a good stop-gap to avoid frustration.	10 years ago
Seth Vargo	037d4b6c87	Suggest refresh instead of apply ... Suggesting an apply could actually change remote resources whereas a refresh will at-worst modify local state.	10 years ago
James Bardin	11d601ad6d	TestRefresh_badState can be re-enabled ... Refactored the code to maintain the behavior.	10 years ago
James Bardin	1380bbedb2	don't print err in Fatalf when it's nil	10 years ago
James Bardin	b8bd4846db	fix test despite original comments ... Original comments were incorrect, and the test was checking for the absence of state	10 years ago
James Bardin	39ca4fa2f8	Ensure that backend tests check for data in state ... Test should not simply check for the existence of a file for state, but make sure that file also contains data.	10 years ago
James Bardin	8f7f1917f2	Remove state file data when writing a nil state ... The old behavior in this situation was to simply delete the file. Since we now have a lock on this file we don't want to close or delete it, so instead truncate the file at offset 0. Fix a number of related tests	10 years ago
James Bardin	eb59b5925e	Fix some tests, and make rest fail with good errs ... Having the state files always created for locking breaks a lot of tests. Most can be fixed by simple checking for state within a file, but a few still might be writing state when they shouldn't.	10 years ago
Mitchell Hashimoto	61881d2795	Merge pull request #10934 from hashicorp/f-provisioner-stop ... core: stoppable provisioners, helper/schema for provisioners	10 years ago
Mitchell Hashimoto	b8c310c61e	command: update test failure to correct message	10 years ago
Mitchell Hashimoto	09242fab09	terraform: remove legacy graph builder	10 years ago
Mitchell Hashimoto	83cc54bfbe	updated generate output	10 years ago
Mitchell Hashimoto	09e0727d5e	command/plan: revert test change on this output	10 years ago
Mitchell Hashimoto	d9bc1572eb	command: remove old State funcs	10 years ago
Mitchell Hashimoto	ad7b063262	command: convert to use backends	10 years ago
Mitchell Hashimoto	9654387771	command: meta.Backend is used for initializing the backend ... This is a complex function that handles all the potential cases that can happen with legacy remote state, new configurations, etc.	10 years ago
Mitchell Hashimoto	0a0842a7d9	command/format: a package for formatting plans/state for output	10 years ago
Mitchell Hashimoto	f84fd39ef9	command/import: document -var-file and -var is available #11211	10 years ago
Paul Stack	987b910828	Ns1 provider (#10782) ... * vendor: update gopkg.in/ns1/ns1-go.v2 * provider/ns1: Port the ns1 provider to Terraform core * docs/ns1: Document the ns1 provider * ns1: rename remaining nsone -> ns1 (#10805) * Ns1 provider (#11300) * provider/ns1: Flesh out support for meta structs. Following the structure outlined by @pashap. Using reflection to reduce copy/paste. Putting metas inside single-item lists. This is clunky, but I couldn't figure out how else to have a nested struct. Maybe the Terraform people know a better way? Inside the meta struct, all fields are always written to the state; I can't figure out how to omit fields that aren't used. This is not just verbose, it actually causes issues because you can't have both "up" and "up_feed" set). Also some minor other changes: - Add "terraform" import support to records and zones. - Create helper class StringEnum. * provider/ns1: Make fmt * provider/ns1: Remove stubbed out RecordRead (used for testing metadata change). * provider/ns1: Need to get interface that m contains from Ptr Value with Elem() * provider/ns1: Use empty string to indicate no feed given. * provider/ns1: Remove old record.regions fields. * provider/ns1: Removes redundant testAccCheckRecordState * provider/ns1: Moves account permissions logic to permissions.go * provider/ns1: Adds tests for team resource. * provider/ns1: Move remaining permissions logic to permissions.go * ns1/provider: Adds datasource.config * provider/ns1: Small clean up of datafeed resource tests * provider/ns1: removes testAccCheckZoneState in favor of explicit name check * provider/ns1: More renaming of nsone -> ns1 * provider/ns1: Comment out metadata for the moment. * Ns1 provider (#11347) * Fix the removal of empty containers from a flatmap Removal of empty nested containers from a flatmap would sometimes fail a sanity check when removed in the wrong order. This would only fail sometimes due to map iteration. There was also an off-by-one error in the prefix check which could match the incorrect keys. * provider/ns1: Adds ns1 go client through govendor. * provider/ns1: Removes unused debug line * docs/ns1: Adds docs around apikey/datasource/datafeed/team/user/record. * provider/ns1: Gets go vet green	10 years ago
Paul Stack	798bf60ef9	command/plugin_list: Adding Alicloud to the plugin list file (#11292)	10 years ago
Jasmin Gacic	7e9c850936	Terraform ProfitBricks Builder (#7943) ... * Terraform ProfitBricks Builder * make fmt * Merge remote-tracking branch 'upstream/master' into terraform-provider-profitbricks # Conflicts: # command/internal_plugin_list.go * Addressing PR remarks * Removed importers	10 years ago
clint shryock	87bb691800	Revert "New provider arukas (#10862)" ... This reverts commit 9176bd4861. This provider includes a dependency that at time of writing requires a *nix system, and will not build on Windows.	10 years ago
Kazumichi Yamamoto	9176bd4861	New provider arukas (#10862) ... * Add a Arukas provider * Add dependencies for the Arukas provider * Add documents for the Arukas	10 years ago
Tom Harvey	05d00a93ce	New Provider: OpsGenie (#11012) ... * Importing the OpsGenie SDK * Adding the goreq dependency * Initial commit of the OpsGenie / User provider * Refactoring to return a single client * Adding an import test / fixing a copy/paste error * Adding support for OpsGenie docs * Scaffolding the user documentation for OpsGenie * Adding a TODO * Adding the User data source * Documentation for OpsGenie * Adding OpsGenie to the internal plugin list * Adding support for Teams * Documentation for OpsGenie Team's * Validation for Teams * Removing Description for now * Optional fields for a User: Locale/Timezone * Removing an implemented TODO * Running makefmt * Downloading about half the internet Someone witty might simply sign this commit with "npm install" * Adding validation to the user object * Fixing the docs * Adding a test creating multple users * Prompting for the API Key if it's not specified * Added a test for multiple users / requested changes * Fixing the linting	10 years ago
Máximo Cuadros	85f0fba9f9	Ignition provider (#6189) ... * providers: ignition, basic config, version and config * providers: ignition, user and passwd example, general cache implementation * vendor: Capture new dependency upstream-pkg * providers: ignition ignition_user * providers: ignition ignition_disk, ignition_group and ignition_raid * providers: ignition_file and ignition_filesystem * providers: ignition_systemd_unit and ignition_networkd_unit * providers: ignition_config improvements * vendor: Capture new dependency upstream-pkg * providers: ignition main * documentation: ignition provider * providers: ignition minor changes * providers: ignition, fix test * fixing tests and latest versions	10 years ago
Paul Tyng	3dfe5a47f1	provider/newrelic: Add new provider for New Relic	10 years ago
Mitchell Hashimoto	751e45c1d2	Merge pull request #10654 from hashicorp/b-vars ... Maps with -var-file or -var always merge	10 years ago
Mitchell Hashimoto	1c537f6295	Merge pull request #10639 from hashicorp/b-plan-plan ... command/plan: user friendly error if plan file given to plan command	10 years ago
Mitchell Hashimoto	36ff8b3c02	command/plan: show a warning when a plan file is given	10 years ago
Len Smith	015e96d0dd	Initial check in for Icinga2 Provider/Resource (#8306) ... * Initial checkin for PR request * Added an argument to provider to allow control over whether or not TLS Certs will skip verification. Controllable via provider or env variable being set * Initial check-in to use refactored module * Checkin of very MVP for creating/deleting host test which works and validates basic host creation and deletion * Check in with support for creating hosts with variables working * Checking in work to date * Remove code that causes travis CI to fail while I debug * Adjust create to accept multivale * Back on track. Working basic tests. go-icinga2-api needs more test too * Squashing * Back on track. Working basic tests. go-icinga2-api needs more test too * Check in refactored hostgroup support * Check in refactored check_command, hosts, and hsotgroup with a few test * Checking in service code * Add in dependency for icinga2 provider * Add documentation. Refactor, fix and extend based on feedback from Hashicorp * Added checking and validation around invalid URL and unavailable server	10 years ago
Mitchell Hashimoto	77efacf30e	command: use helper/variables for flags and parsing	10 years ago
James Bardin	fc13a1b814	Disaply interpolation strings for computed fields ... Displaying interpolations strings when possible for computed fields in the plan output makes for a nicer UX	10 years ago
Mitchell Hashimoto	7f87a0109b	command/plan: user friendly error if plan file given to plan command	10 years ago
Mitchell Hashimoto	a4ceb4a772	Merge pull request #10518 from hashicorp/b-graph ... command/graph: work with new graphs	10 years ago
Martin Atkins	e772b45970	"external" data source, for integrating with external programs (#8768) ... * "external" provider for gluing in external logic This provider will become a bit of glue to help people interface external programs with Terraform without writing a full Terraform provider. It will be nowhere near as capable as a first-class provider, but is intended as a light-touch way to integrate some pre-existing or custom system into Terraform. * Unit test for the "resourceProvider" utility function This small function determines the dependable name of a provider for a given resource name and optional provider alias. It's simple but it's a key part of how resource nodes get connected to provider nodes so worth specifying the intended behavior in the form of a test. * Allow a provider to export a resource with the provider's name If a provider only implements one resource of each type (managed vs. data) then it can be reasonable for the resource names to exactly match the provider name, if the provider name is descriptive enough for the purpose of the each resource to be obvious. * provider/external: data source A data source that executes a child process, expecting it to support a particular gateway protocol, and exports its result. This can be used as a straightforward way to retrieve data from sources that Terraform doesn't natively support.. * website: documentation for the "external" provider	10 years ago
John Engelman	243ecf3b4f	[Provider] Rancher (#9173) ... * Vendor Rancher Go library. * Implement Rancher Provider. Starting implementation taken from https://github.com/platanus/terraform-provider-rancher Commits from jidonoso@gmail.com and raphael.pinson@camptocamp.com	10 years ago
Mitchell Hashimoto	22e868b966	command/graph: update for new graphs	10 years ago
Mitchell Hashimoto	a2f3259e51	Merge pull request #10404 from hashicorp/b-plan-deposed ... terraform: diff shows pure deposed destroy	10 years ago
Mitchell Hashimoto	2f8bf5b7ec	terraform: add variables to Interpolator value ... Fixes #10412 The context wasn't properly adding variable values to the Interpolator instance which made it so that the `console` command couldn't access variables set via tfvars and the CLI. This also adds better test coverage in command itself for this.	10 years ago
Mitchell Hashimoto	ab1e512ae2	command: use reset instead of reset_bold ... Fixes #10337 The `reset_bold` escape code (21) causes the text on Windows command prompts to just become invisible. `reset` does the same job for us in this scenario so do that.	10 years ago
Mitchell Hashimoto	80457b689c	terraform: do the deposed check within EvalDiff ... There is never any reason to separate the two.	10 years ago
Mitchell Hashimoto	8701434b4d	command: plan formatting for deposed destroy	10 years ago
Mitchell Hashimoto	28d933f6dd	nitpicks for #10310	10 years ago
Mitchell Hashimoto	c15754c365	Merge pull request #10310 from spangenberg/custom-import-provider ... Implements import with specified provider	10 years ago
Daniel Spangenberg	804a5bd3c5	Implements import with specified provider ... This allows the import with a specified provider. So far it was not possible to get resources imported from a different provider than the default.	10 years ago
James Bardin	bf20db688c	Remove extra dot from state backup file ... The state subcommand was adding an extra dot to the backup file	10 years ago
Mitchell Hashimoto	251231e3ee	command: more manageable shadow error output	10 years ago
James Bardin	b8adf10236	Add debug command with json2dot ... Add `terraform debug json2dot` to convert debug log graphs to dot format. This is not meant to be in place of more advanced debug visualization, but may continue to be a useful way to work with the debug output.	10 years ago
Mitchell Hashimoto	aaf1ad0532	Merge pull request #10093 from hashicorp/f-console ... Add `terraform console` for REPL	10 years ago
James Bardin	28d406c040	Provider a marshaler for dag.Graph ... The dot format generation was done with a mix of code from the terraform package and the dot package. Unify the dot generation code, and it into the dag package. Use an intermediate structure to allow a dag.Graph to marshal itself directly. This structure will be ablt to marshal directly to JSON, or be translated to dot format. This was we can record more information about the graph in the debug logs, and provide a way to translate those logged structures to dot, which is convenient for viewing the graphs.	10 years ago
Mitchell Hashimoto	1a6056b287	command: split out and tag code so compilation works on Solaris ... The readline library doesn't support Solaris. For now, we'll just not support console there.	10 years ago
Mitchell Hashimoto	a867457d75	command/console	10 years ago
Mitchell Hashimoto	785cc7b78a	terraform: default new graphs on, old graphs behind -Xlegacy-graph ... This turns the new graphs on by default and puts the old graphs behind a flag `-Xlegacy-graph`. This effectively inverts the current 0.7.x behavior with the new graphs. We've incubated most of these for a few weeks now. We've found issues and we've fixed them and we've been using these graphs internally for awhile without any major issue. Its time to default them on and get them part of a beta.	10 years ago
Mitchell Hashimoto	fd498fbfff	Merge pull request #9538 from hashicorp/f-nomad-provider ... provider/nomad: Nomad provider for managing jobs	10 years ago
Mitchell Hashimoto	f8ec7dad19	command/import: allow the -config flag to specify a config location	10 years ago
Mitchell Hashimoto	ec0ef95c6f	terraform: verify import providers only depend on vars	10 years ago
Mitchell Hashimoto	5107c33119	command/import: load configurations and allow empty config dirs ... Fixes #7774 This modifies the `import` command to load configuration files from the pwd. This also augments the configuration loading section for the CLI to have a new option (default false, same as old behavior) to allow directories with no Terraform configurations. For import, we allow directories with no Terraform configurations so this option is set to true.	10 years ago
Mitchell Hashimoto	646b3c1b68	Merge pull request #9158 from hashicorp/f-vault-provider ... Vault Provider	10 years ago
Mitchell Hashimoto	57c0cadc79	Merge pull request #9666 from hashicorp/jbardin/debug ... preliminary debug output	10 years ago
Mitchell Hashimoto	f6dacab0ba	Merge pull request #9794 from hashicorp/b-partial-input ... command/meta: always ask for unset variable input	10 years ago
James Bardin	797a1b339d	DebugInfo and DebugGraph ... Implement debugInfo and the DebugGraph DebugInfo will be a global variable through which graph debug information can we written to a compressed archive. The DebugInfo methods are all safe for concurrent use, and noop with a nil receiver. The API outside of the terraform package will be to call SetDebugInfo to create the archive, and CloseDebugInfo() to properly close the file. Each write to the archive will be flushed and sync'ed individually, so in the event of a crash or a missing call to Close, the archive can still be recovered. The DebugGraph is a representation of a terraform Graph to be written to the debug archive, currently in dot format. The DebugGraph also contains an internal buffer with Printf and Write methods to add to this buffer. The buffer will be written to an accompanying file in the debug archive along with the graph. This also adds a GraphNodeDebugger interface. Any node implementing `NodeDebug() string` can output information to annotate the debug graph node, and add the data to the log. This interface may change or be removed to provide richer options for debugging graph nodes. The new graph builders all delegate the build to the BasicGraphBuilder. Having a Name field lets us differentiate the actual builder implementation in the debug graphs.	10 years ago
Mitchell Hashimoto	d429e82661	command: show shadow errors to the user	10 years ago
Mitchell Hashimoto	6c801d0386	command/apply: add additional nil check to loading state for outputs	10 years ago
Mitchell Hashimoto	1248b147ac	command/meta: always ask for unset variable input ... Fixes #7975 This changes the InputMode for the CLI to always be: InputModeProvider | InputModeVar | InputModeVarUnset Which means: * Ask for provider variables * Ask for user variables _that are not already set_ The change is the latter point. Before, we'd only ask for variables if zero were given. This forces the user to either have no variables set via the CLI, env vars, tfvars or ALL variables, but no in between. As reported in #7975, this isn't expected behavior. The new change makes is so that unset variables are always asked for. Users can retain the previous behavior by setting `-input=false`. This would ensure that variables set by external sources cover all cases.	10 years ago
Mitchell Hashimoto	ab0b7e2d89	Merge pull request #9660 from hashicorp/b-validate-help ... command/validate: respond to --help	10 years ago
Mitchell Hashimoto	314a8ed134	Merge pull request #9706 from hashicorp/b-apply-plan ... command/apply: apply from plan respects -backup and -state-out	10 years ago
Calle Pettersson	51ff5cba38	Align the help string of output with documentation (#9735)	10 years ago
Martin Atkins	b2b5831205	"vault" provider registration ... To reduce the risk of secret exposure via Terraform state and log output, we default to creating a relatively-short-lived token (20 minutes) such that Vault can, where possible, automatically revoke any retrieved secrets shortly after Terraform has finished running. This has some implications for usage of this provider that will be spelled out in more detail in the docs that will be added in a later commit, but the most significant implication is that a plan created by "terraform plan" that includes secrets leased from Vault must be *applied* before the lease period expires to ensure that the issued secrets remain valid. No resources yet. They will follow in subsequent commits.	10 years ago
Mitchell Hashimoto	2019a44f04	command/apply: apply from plan respects -backup and -state-out ... Fixes #5409 I didn't expect this to be such a rabbit hole! Based on git history, it appears that for "historical reasons"(tm), setting up the various `state.State` structures for a plan were _completely different logic_ than a normal `terraform apply`. This meant that it was skipping things like disabling backups with `-backup="-"`. This PR unifies loading from a plan to the normal state setup mechanism. A few tests that were failing prior to this PR were added, no existing tests were changed.	10 years ago
Mitchell Hashimoto	b2950bc205	command/validate: respond to --help ... Fixes #5072 This is very simple: we need to process CLI flags on validate in order to catch and respond to `--help`.	10 years ago
Mitchell Hashimoto	69b32223b8	Merge pull request #9633 from hashicorp/f-experiment ... helper/experiment: a helper for setting, making experiments	10 years ago
Mitchell Hashimoto	9c2014d5b6	Merge pull request #9642 from hashicorp/b-var-bool ... command: FlagTypedKV parses bool as string	10 years ago
Mitchell Hashimoto	f9b0207304	command: FlagTypedKV parses bool as string ... When passing a bool type to a variable such as `-var foo=true`, the CLI would parse this as a `bool` type which Terraform core cannot handle. It would then error with an invalid type error. This changes the handling to convert the bool to its literally string value given on the command-line.	10 years ago
James Bardin	43f860ddfd	Fix panic during "terraform show" with empty state ... It's possible to have > 1 result from the StateFilter, and not have any instances to show.	10 years ago
Mitchell Hashimoto	af82be19ea	helper/experiment: a helper for setting, making experiments ... This creates a standard package and interface for defining, querying, setting experiments (`-X` flags). I expect we'll want to continue to introduce various features behind experimental flags. I want to make doing this as easy as possible and I want to make _removing_ experiments as easy as possible as well. The goal with this packge has been to rely on the compiler enforcing our experiment references as much as possible. This means that every experiment is a global variable that must be referenced directly, so when it is removed you'll get compiler errors where the experiment is referenced. This also unifies and makes it easy to grab CLI flags to enable/disable experiments as well as env vars! This way defining an experiment is just a couple lines of code (documented on the package).	10 years ago
Mitchell Hashimoto	aed23a0a31	Merge pull request #9527 from hashicorp/f-destroy-builder2 ... terraform: destroy graph builder based on state	10 years ago
Mitchell Hashimoto	bb5f6498e2	provider/nomad	10 years ago
Alexander Hellbom	d02067a75e	Add PagerDuty provider	10 years ago
Mitchell Hashimoto	1a418c1452	command/apply: -Xnew-destroy	10 years ago
Mitchell Hashimoto	ae4f79e3b6	command/meta: add -shadow flag to disable shadow graph ... Since it is still very much possible for this to cause problems, this can be used to disable the shadow graph. We'll purposely not document this since the goal is to remove this flag as we become more confident with it.	10 years ago
Mitchell Hashimoto	e8516f259d	command/apply: Xnew-apply	10 years ago
Mitchell Hashimoto	ec15783f24	-Xnew-apply to enable the new apply graph	10 years ago
James Bardin	f175497dd7	Fix vet issues ... None were critical, but these will fail with the next version of vet.	10 years ago
James Bardin	54d50c90b1	Make TestApply_parallelism more reliable ... Wait for our expected number of goroutines to be staged and ready, then allow Run() to complete. Use a high-water-mark counter to ensure we never exceeded the max expected concurrent goroutines at any point during the run.	10 years ago
James Bardin	4f91507d05	Merge pull request #9268 from hashicorp/jbardin/hcl-maps ... Get rid of the list when parsing HCL maps for vars	10 years ago
James Bardin	9fc50a76c3	Get rid of the list when parsing HCL maps for vars ... When we parse a map from HCL, it's decoded into a list of maps because HCL allows declaring a key multiple times to implicitly add it to a list. Since there's no terraform variable configuration that supports this structure, we can always flatten a []map[string]interface{} value to a map[string]interface{} and remove any type rrors trying to apply that value.	10 years ago
James Bardin	286fea571f	Fix push test to use something that is HCL ... Fix the tfvars push test which was mistakingly using a single number to trigger the HCL behavior.	10 years ago
James Bardin	cf1cfccf06	Don't parse a TestFlagTypedKV value as a number ... Don't try to parse a varibale as HCL if the value can be parse as a single number. HCL will always attempt to convert the value to a number, even if we later find the configured variable's type to be a string.	10 years ago
stack72	a2970e631c	Merge branch 'cwood/bitbucket-provider' of https://github.com/cwood/terraform into cwood-cwood/bitbucket-provider	10 years ago
Mitchell Hashimoto	609219fc65	command/meta: validate config immediately ... * config: test for validating multi-vars (passes) * command/plan: test invalid run * command/meta: validate module on load	10 years ago
Mitchell Hashimoto	fad1ce9915	Merge pull request #8620 from hashicorp/b-var-input ... command: more resilient HCL check for inputs	10 years ago
Mitchell Hashimoto	c84f699158	update HCL vendor	10 years ago
Paul Stack	05994cef31	Merge pull request #7694 from jtopjian/provider-rabbitmq ... RabbitMQ Provider	10 years ago
Mitchell Hashimoto	0a2b5de67f	command: more resilient HCL check for inputs	10 years ago
Joe Topjian	c2469c95f4	provider/rabbitmq: Initial Commit of RabbitMQ Provider ... Contains provider configuration, a rabbitmq_vhost resource, and acceptance test.	10 years ago
Mitchell Hashimoto	475d8750bb	command/push: make test more resilient	10 years ago
Radek Simko	8494cad8c4	Output 'destroy complete' when it's destroy (was: apply) (#8453)	10 years ago
Mitchell Hashimoto	2f8baa4580	command/push: fix tests to be vcs=false GH-8478	10 years ago
Mitchell Hashimoto	9a8209cfbd	command/push: create the proper parent directory entries in tar	10 years ago
Mitchell Hashimoto	928fdff33e	command/push: only add module directory to tar if it exists	10 years ago
Mitchell Hashimoto	92b15de080	command/push: remove the old test fixture for the new one	10 years ago
Mitchell Hashimoto	a650455ed6	command/push: only explicitly include the state ... modify the module include flag to flag whether we explicitly include or exclude modules	10 years ago
Mitchell Hashimoto	3aecc52bf3	command/push: "Extra" value must be absolute	10 years ago
Mitchell Hashimoto	f0de3c3e91	command/push: removed all the git stuff, turns out it doesn't matter	10 years ago
Mitchell Hashimoto	e8267f4907	command/push: failing test for pushing with no modules	10 years ago
Mitchell Hashimoto	70cc108614	Revert "command/push: test that -upload-modules=false works" ... This reverts commit edda576452.	10 years ago
Mitchell Hashimoto	edda576452	command/push: test that -upload-modules=false works	10 years ago
Mitchell Hashimoto	2ac142abc3	command: use bufio.ReadString instead of scanning to get spaces ... [GH-2628]	10 years ago
Mitchell Hashimoto	d3792e4aef	command: correct outdated comment	10 years ago
Mitchell Hashimoto	43cfd3d1c9	command: fix regressions for state mv with count resource	10 years ago
Mitchell Hashimoto	0d1ea84d39	command: test for moving resource with count [GH-7797]	10 years ago
Mitchell Hashimoto	3b3f92cd9b	terraform: fix some test failures on state add with multiple modules	10 years ago
Mitchell Hashimoto	a44c8b8760	terraform: state mv tests	10 years ago
James Nugent	f933b2cf16	Merge pull request #8200 from hashicorp/fix-state-rm ... core: Add `terraform state rm` command	10 years ago
Paul Stack	4d46812bab	Update state_rm_test.go ... Removing sort as it was imported and not used	10 years ago
Mitchell Hashimoto	3fdc08a9eb	core: Add `terraform state rm` command and docs ... This commit adds the `state rm` command for removing an address from state. It is the result of a rebase from pull-request #5953 which was lost at some point during the Terraform 0.7 feature branch merges.	10 years ago
Paul Hinze	84bbbfbe18	command: Fixup comment typo ... Hat tip to @Ninir :)	10 years ago
Paul Hinze	50df583ffd	Merge pull request #8120 from hashicorp/jbardin/null-state-module ... Fix panic from a null resources module in a state file	10 years ago
James Bardin	1be5a650fc	Add test for showing an empty state ... Make sure we don't panic if there's no state to print	10 years ago
James Bardin	191d7c1007	Fix panic when showing empty state ... Fixes a nil dereference when there's no state to print. Fix some slice declaration to use the recommended style when allocations don't matter.	10 years ago
James Bardin	cdb80f68a8	Ensure better state normalization ... Fix checksum issue with remote state If we read a state file with "null" objects in a module and they become initialized to an empty map the state file may be written out with empty objects rather than "null", changing the checksum. If we can detect this, increment the serial number to prevent a conflict in atlas. Our fakeAtlas test server now needs to decode the state directly rather than using the ReadState function, so as to be able to read the state unaltered. The terraform.State data structures have initialization spread out throughout the package. More thoroughly initialize State during ReadState, and add a call to init() during WriteState as another normalization safeguard. Expose State.init through an exported Init() method, so that a new State can be completely realized outside of the terraform package. Additionally, the internal init now completely walks all internal state structures ensuring that all maps and slices are initialized. While it was mentioned before that the `init()` methods are problematic with too many call sites, expanding this out better exposes the entry points that will need to be refactored later for improved concurrency handling. The State structures had a mix of `omitempty` fields. Remove omitempty for all maps and slices as part of this normalization process. Make Lineage mandatory, which is now explicitly set in some tests.	10 years ago
James Nugent	e181d753fe	build: Fix ordering of plugin list	10 years ago
Colin Wood	bd9ddff0cc	Bitbucket provider for terraform	10 years ago
Brad Sickles	70cadcf31d	Implement archive provider and "archive_file" resource. (#7322)	10 years ago
James Bardin	1322aaf473	Merge pull request #7989 from hashicorp/jbardin/tf_push ... Override atlas variables even if they aren't local	10 years ago
James Bardin	67bd4f29e0	Override atlas variables even if they aren't local ... Some Atlas usage patterns expect to be able to override a variable set in Atlas, even if it's not seen in the local context. This allows overwriting a variable that is returned from atlas, and sends it back. Also use a unique sential value in the context where we have variables from atlas. This way atals variables aren't combined with the local variables, and we don't do something like inadvertantly change the type, double encode/escape, etc.	10 years ago
James Bardin	d5fbb5f5c0	Modify the tfvars test to also use a cli var ... Modify the test to demonstrate where cli vars were being lost because they weren't interpreted as strings.	10 years ago
James Bardin	9d0faa2cae	Strip off extra \n in hcl encoded variables ... They don't change the value, but they do currently end up in the UI	10 years ago
James Bardin	bf83b435e1	numeric variables aren't always interpreted as str ... If we have a number value in our config variables, format it as a string, and send it with the HCL=true flag just in case. Also use %g for for float encoding, as the output is a generally a little friendlier.	10 years ago
James Bardin	1af7ee87a2	Silence log output when not verbose ... Set the default log package output to iotuil.Discard during tests if the `-v` flag isn't set. If we are verbose, then apply the filter according to the TF_LOG env variable.	10 years ago
James Bardin	2747d964cb	Merge pull request #7877 from hashicorp/jbardin/races ... core: Fix race conditions, mostly around diffs	10 years ago
James Nugent	9034196baf	Merge pull request #7875 from hashicorp/b-outputs-by-module ... core: Fix -module for terraform output command	10 years ago
James Nugent	0e4e94a86f	core: Fix -module for terraform output command ... The behaviour whereby outputs for a particular nested module can be output was broken by the changes for lists and maps. This commit restores the previous behaviour by passing the module path into the outputsAsString function. We also add a new test of this since the code path for indivdual output vs all outputs for a module has diverged.	10 years ago
James Bardin	5802f76eaa	Make all terraform package tests pass under -race ... This isn't a pretty refactor, but fixes the race issues in this package for now. Fix race on RawConfig.Config() fix command package races	10 years ago
James Bardin	0c714592f0	Fix variable handling on subsequent pushes ... The handling of remote variables was completely disabled for push. We still need to fetch variables from atlas for push, because if the variable is only set remotely the Input walk will still prompt the user for a value. We add the missing remote variables to the context to disable input. We now only handle remote variables as atlas.TFVar and explicitly pass around that type rather than an `interface{}`. Shorten the text fixture slightly to make the output a little more readable on failures.	10 years ago
James Bardin	b4b70193d2	whitespace fixes	10 years ago
James Bardin	8038e60a20	Add a function to quote HCL strings ... The strings we have in the variables may contain escaped double-quotes, which have already been parsed and had the `\`s removed. We need to re-escape these, but only if we are in the outer string and not inside an interpolation.	10 years ago
James Bardin	de87267697	Add tf_vars to the variables sent in push ... Add tf_vars to the data structures sent in terraform push. This takes any value of type []interface{} or map[string]interface{} and marshals it as a string representation of the equivalent HCL. This prevents ambiguity in atlas between a string that looks like a json structure, and an actual json structure. For the time being we will need a way to serialize data as HCL, so the command package has an internal encodeHCL function to do so. We can remove this if we get complete package for marshaling HCL.	10 years ago
James Nugent	681d94ae20	core: Allow lists and maps as variable overrides ... Terraform 0.7 introduces lists and maps as first-class values for variables, in addition to string values which were previously available. However, there was previously no way to override the default value of a list or map, and the functionality for overriding specific map keys was broken. Using the environment variable method for setting variable values, there was previously no way to give a variable a value of a list or map. These now support HCL for individual values - specifying: TF_VAR_test='["Hello", "World"]' will set the variable `test` to a two-element list containing "Hello" and "World". Specifying TF_VAR_test_map='{"Hello = "World", "Foo" = "bar"}' will set the variable `test_map` to a two-element map with keys "Hello" and "Foo", and values "World" and "bar" respectively. The same logic is applied to `-var` flags, and the file parsed by `-var-files` ("autoVariables"). Note that care must be taken to not run into shell expansion for `-var-` flags and environment variables. We also merge map keys where appropriate. The override syntax has changed (to be noted in CHANGELOG as a breaking change), so several tests needed their syntax updating from the old `amis.us-east-1 = "newValue"` style to `amis = "{ "us-east-1" = "newValue"}"` style as defined in TF-002. In order to continue supporting the `-var "foo=bar"` type of variable flag (which is not valid HCL), a special case error is checked after HCL parsing fails, and the old code path runs instead.	10 years ago
James Bardin	2712328d5a	Merge pull request #7756 from hashicorp/jbardin/tf-atlas-version ... core: send version info to atlas	10 years ago
James Bardin	885935962c	Add a terraform version header to all atlas calls ... Using the DefaultHeader added to the atlas.Client	10 years ago
David Glasser	50959a654c	command: Remove second DefaultDataDirectory const (#7666)	10 years ago
James Nugent	3735140286	core: Don't set variables for Atlas until lib is updated	10 years ago
James Nugent	5d18f41f04	core: Convert context vars to map[string]interface{} ... This is the first step in allowing overrides of map and list variables. We convert Context.variables to map[string]interface{} from map[string]string and fix up all the call sites.	10 years ago
Raphael Randschau	9081cabd6e	Add scaleway provider (#7331) ... * Add scaleway provider this PR allows the entire scaleway stack to be managed with terraform example usage looks like this: ``` provider "scaleway" { api_key = "snap" organization = "snip" } resource "scaleway_ip" "base" { server = "${scaleway_server.base.id}" } resource "scaleway_server" "base" { name = "test" # ubuntu 14.04 image = "aecaed73-51a5-4439-a127-6d8229847145" type = "C2S" } resource "scaleway_volume" "test" { name = "test" size_in_gb = 20 type = "l_ssd" } resource "scaleway_volume_attachment" "test" { server = "${scaleway_server.base.id}" volume = "${scaleway_volume.test.id}" } resource "scaleway_security_group" "base" { name = "public" description = "public gateway" } resource "scaleway_security_group_rule" "http-ingress" { security_group = "${scaleway_security_group.base.id}" action = "accept" direction = "inbound" ip_range = "0.0.0.0/0" protocol = "TCP" port = 80 } resource "scaleway_security_group_rule" "http-egress" { security_group = "${scaleway_security_group.base.id}" action = "accept" direction = "outbound" ip_range = "0.0.0.0/0" protocol = "TCP" port = 80 } ``` Note that volume attachments require the server to be stopped, which can lead to downtimes of you attach new volumes to already used servers * Update IP read to handle 404 gracefully * Read back resource on update * Ensure IP detachment works as expected Sadly this is not part of the official scaleway api just yet * Adjust detachIP helper based on feedback from @QuentinPerez in https://github.com/scaleway/scaleway-cli/pull/378 * Cleanup documentation * Rename api_key to access_key following @stack72 suggestion and rename the provider api_key for more clarity * Make tests less chatty by using custom logger	10 years ago
James Nugent	b4048dfc1d	core: Add -json flag to `terraform output` ... This commit removes the ability to index into complex output types using `terraform output a_list 1` (for example), and adds a `-json` flag to the `terraform output` command, such that the output can be piped through a post-processor such as jq or json. This removes the need to allow arbitrary traversal of nested structures. It also adds tests of human readable ("normal") output with nested lists and maps, and of the new JSON output.	10 years ago
James Nugent	ef3aad1231	core: Correctly format nested outputs ... This commit pretty prints outputs which consist of nested complex structures (e.g. lists of lists, lists of maps). Fixes #7143.	10 years ago
James Nugent	1ca51ab454	Merge pull request #7589 from hashicorp/b-data-source-plan-counts ... command: Do not count data sources in plan totals	10 years ago
Derek Abdine	7bdc060d24	provider/logentries: Implementing logentries provider (#7067) ... * logentries provider * logentries vendoring * logentries docs	10 years ago
Paul Hinze	d5a941a0a4	command: Do not count data sources in plan totals ... Fixes #7483	10 years ago
James Bardin	b0b2923027	Merge pull request #7443 from hashicorp/jbardin/GH-7264 ... core: Use -state-out option when applying from a plan	10 years ago
James Bardin	6b5ee73e86	Use -state-out option when applying from a plan ... When working from an existing plan, we weren't setting the PathOut field for a LocalState. This required adding an outPath argument to the StateFromPlan function to avoid having to introspect the returned state.State interface to find the appropriate field. To test we run a plan first and provide the new plan to apply with `-state-out` set.	10 years ago
James Bardin	db83a779ab	Fix plan output for data sources ... Data sources are given a special plan output when the diff would show it creating a new resource, to indicate that there is only a logical data resource being read. Data sources nested in modules weren't formatted in the plan output in the same way. This checks for the "data." part of the path in nested modules, and adds acceptance tests for the plan output.	10 years ago
James Nugent	b190aa05a5	core: Add missing OutputStates in synthetic state ... In cases where we construct state directly rather than reading it via the usual methods, we need to ensure that the necessary maps are initialized correctly.	10 years ago
James Nugent	aa5dc453ee	cli: Fix registration of `state mv`. ... Fixes #7259.	10 years ago
James Nugent	75ab4a9970	core: Fix crash with tainted resource ... This commit fixes a crash in `terraform show` where there is no primary resource, but there is a tainted resource, because of the changes made to tainted resource handling in 0.7.	10 years ago
James Nugent	7aec98237c	core: Format empty lists and maps in output ... `terraform output` and it's brethren now consolidate empty maps and lists on a single line of output instead of the pathological behaviour of taking three lines previously. The same code paths are used across all output mechanisms: ``` $ cat main.tf variable "emptystring" { type = "string" default = "" } variable "emptylist" { type = "list" default = [] } variable "emptymap" { type = "map" default = {} } output "emptystring" { value = "${var.emptystring}" } output "emptylist" { value = "${var.emptylist}" } output "emptymap" { value = "${var.emptymap}" } $ terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: emptylist = [] emptymap = {} emptystring = $ terraform output emptylist = [] emptymap = {} emptystring = $ terraform show Outputs: emptylist = [] emptymap = {} emptystring = ```	10 years ago
Paul Hinze	1a0893ddc7	command/plan: remove -backup from help text ... The `-backup` flag no longer applies since `terrafom plan` does not write state. Fixes #7087	10 years ago
Maxime Bury	c98f391bee	Add basic implementation for remote state on azure (#7064) ... * Add basic implementation for remote state on azure * Don't auto-provision the container * Fix compilation errors * Add factory to the remote map * Add documentation * Add acceptance tests	10 years ago
James Nugent	c96a8d5302	core: Update `terraform show` to deal with lists ... Fixes #6931.	10 years ago
Matt Morrison	cbfb4d8b86	remote state: Add GCS provider for remote state	10 years ago
Chris Marchesi	9d7fb89114	core: Adding Sensitive attribute to resource schema ... This an effort to address hashicorp/terraform#516. Adding the Sensitive attribute to the resource schema, opening up the ability for resource maintainers to mark some fields as sensitive. Sensitive fields are hidden in the output, and, possibly in the future, could be encrypted.	10 years ago
James Nugent	5a0f6565d3	Merge pull request #6672 from apparentlymart/random-provider ... Logical Resources for Random Values	10 years ago
Sander van Harmelen	d97b24e3c1	Add tests and fix last issues	10 years ago
Sander van Harmelen	8560f50cbc	Change taint behaviour to act as a normal resource ... This means it’s shown correctly in a plan and takes into account any actions that are dependant on the tainted resource and, vice verse, any actions that the tainted resource depends on. So this changes the behaviour from saying this resource is tainted so just forget about it and make sure it gets deleted in the background, to saying I want that resource to be recreated (taking into account the existing resource and it’s place in the graph).	10 years ago
Paul Hinze	aee1520ac5	core: Make refresh message explicitly point out lack of state persist ... Helps make clear to users that refresh only occurs in-memory during plan per @jen20's recommendation	10 years ago
Paul Hinze	ae73aa2fb4	core: Do not persist state after plans ... This makes the behavior of plans much more predictable, as they no longer potentially have side effects on shared remote state.	10 years ago
James Nugent	28ad394264	build: Update generated internal plugin list	10 years ago
James Nugent	8e732c104b	core: Error over panic if output type unknown	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
Martin Atkins	3e34ddbf38	New "random" provider, representing randomness ... This provider will have logical resources that allow Terraform to "manage" randomness as a resource, producing random numbers on create and then retaining the outcome in the state so that it will remain consistent until something explicitly triggers generating new values. Managing randomness in this way allows configurations to do things like random distributions and ids without causing "perma-diffs".	10 years ago