1267 Commits (db2fe3dbd9de6fe22cb396643d6ce85bcdf6ed5c)

Author	SHA1	Message	Date
Radek Simko	b492c3662c	Merge pull request #20089 from hashicorp/t-cmd-fmt-sensitive-update ... command/format: Add test to cover update of sensitive field	7 years ago
Radek Simko	f04d0b48bc	command/format: Add test to cover update of sensitive field	7 years ago
Radek Simko	953eae7e4b	command/format: Fix rendering of different types	7 years ago
Radek Simko	f3d1565d6f	command/format: Fix tuple diff formatting	7 years ago
Radek Simko	0dff8fe5e0	Add failing test case for tuple	7 years ago
Radek Simko	3d0a25c65d	command/format: Fix nested (JSON) object formatting	7 years ago
Radek Simko	c5ba7469be	command/format: Fix rendering of unknown elements in set/map/list	7 years ago
Radek Simko	98cc99e632	command/format: Add crashing test with unknown element in map	7 years ago
Radek Simko	73225c7aeb	command/format: Add crashing test with unknown element in list	7 years ago
Radek Simko	e7e8b7358f	command/format: Add crashing test with unknown element in set	7 years ago
Martin Atkins	8b094f48f7	command: Update "terraform get" to use the new module installer ... We missed this on the initial update pass because this was calling directly into the module package API rather than going through the Meta methods that we updated for the new config loader. m.installModules here is the same method that "terraform init" is using for this purpose, ensuring the two will behave the same way. This changes the output a little compared to the old installer, but it still includes the important information about where each module is coming from.	7 years ago
Martin Atkins	176a5abfd3	command: Restore single-file support in "terraform fmt" ... This possibility was lost in the rewrite to use HCL2, but it's used by a number of external utilities and text editor integrations, so we'll restore it here. Using the stdin/stdout mode is generally preferable for text editor use since it allows formatting of the in-memory buffer rather than directly the file on disk, but for editors that don't have support for that sort of tooling it can be convenient to just launch a single command and directly modify the on-disk file.	7 years ago
Martin Atkins	b0a43cab84	command: "terraform fmt" must fail if file has invalid syntax ... Since the HCL formatter only works with tokens, it can in principle be called with any input and produce some output. However, when given invalid syntax it will tend to produce nonsensical results that may drastically change the input file and be hard for the user to undo. Since there's no strong reason to try to format an invalid or incomplete file, we'll instead try parsing first and fail if parsing does not complete successfully. Since we talk directly to the HCL API here this is only a _syntax_ check, and so it can be applied to files that are invalid in other ways as far as Terraform is concerned, such as using unsupported top-level block types, resource types that don't exist, etc.	7 years ago
findkim	7816e61614	Bump installer protocol version to 5 and separate client and server protocol references	7 years ago
Radek Simko	13896d72c5	command/format: Render empty object as {}	7 years ago
Radek Simko	5f14b7a7f2	command/format: Render empty primitive list/set as []	7 years ago
Radek Simko	09d19ca9d9	command/format: Render empty JSON object as {}	7 years ago
Radek Simko	0dd2d56f18	command/format: Render empty maps as {}	7 years ago
Kim Ngo	41a2376915	Merge pull request #19981 from findkim/colorize-protocol-mismatch-msg ... Condense protocol mismatch UI error message	7 years ago
findkim	6e0de3e3f5	Nest incompatible provider protocol error to include dynamic custom msg	7 years ago
Radek Simko	aae87c7921	Merge pull request #19990 from hashicorp/f-cmd-fmt-ignore-empty-str ... command/format: Ignore removal of empty strings	7 years ago
Martin Atkins	86c02d5c35	command: "terraform init" can partially initialize for 0.12upgrade ... There are a few constructs from 0.11 and prior that cause 0.12 parsing to fail altogether, which previously created a chicken/egg problem because we need to install the providers in order to run "terraform 0.12upgrade" and thus fix the problem. This changes "terraform init" to use the new "early configuration" loader for module and provider installation. This is built on the more permissive parser in the terraform-config-inspect package, and so it allows us to read out the top-level blocks from the configuration while accepting legacy HCL syntax. In the long run this will let us do version compatibility detection before attempting a "real" config load, giving us better error messages for any future syntax additions, but in the short term the key thing is that it allows us to install the dependencies even if the configuration isn't fully valid. Because backend init still requires full configuration, this introduces a new mode of terraform init where it detects heuristically if it seems like we need to do a configuration upgrade and does a partial init if so, before finally directing the user to run "terraform 0.12upgrade" before running any other commands. The heuristic here is based on two assumptions: - If the "early" loader finds no errors but the normal loader does, the configuration is likely to be valid for Terraform 0.11 but not 0.12. - If there's already a version constraint in the configuration that excludes Terraform versions prior to v0.12 then the configuration is probably _already_ upgraded and so it's just a normal syntax error, even if the early loader didn't detect it. Once the upgrade process is removed in 0.13.0 (users will be required to go stepwise 0.11 -> 0.12 -> 0.13 to upgrade after that), some of this can be simplified to remove that special mode, but the idea of doing the dependency version checks against the liberal parser will remain valuable to increase our chances of reporting version-based incompatibilities rather than syntax errors as we add new features in future.	7 years ago
Martin Atkins	0c0a437bcb	Move module install functionality over to internal/initwd	7 years ago
Radek Simko	d96f4fa77b	command/format: Ignore removal of empty strings	7 years ago
Kristin Laemmert	5df9cd0f52	command/show: tests for -json output (#19980) ... * command/show: added test scaffold for json output More test cases will be added once the basic shape of the tests is validated. - command/json* packages now sort resources by address, matching behavior elsewhere - using cmp in tests instead of reflect.DeepEqual for the diffs - updating expected output in tests to match sorting	7 years ago
Radek Simko	bc4b7cad68	command/format: Render null in dark gray (#19616)	7 years ago
Kristin Laemmert	cdf7cc2449	command/json*: updating documentation and adding tests (#19944) ... A few minor fixes and cleanups as a result of said tests. Hooray for eventual consistency!	7 years ago
Sander van Harmelen	fb57e9b26f	command/state: add proper locking	7 years ago
Kristin Laemmert	3e9c51c726	command/jsonstate: marshal state into a machine readable blob o'json (#19911) ... * command/jsonstate: marshal state into a machine readable blob o'json * consistent json tags are nice	7 years ago
Kristin Laemmert	2b6dc13f29	jsonplan: remove "proposed_unknown" structure in favor of "after_unknown" field in "change" (#19709) ... * jsonplan: remove "proposed_unknown" structure in favor of "after_unknown" field in "change"	7 years ago
Martin Atkins	2cf63d068f	command: Always normalize config path before operations ... Previously we were doing this rather inconsistently: some commands would do it and others would not. By doing it here we ensure we always apply the same normalization, regardless of which operation we're running. This normalization is mostly for cosmetic purposes in error messages, but it also ends up being used to populate path.module and path.root and so it's important that we always produce consistent results here so that we don't produce flappy changes as users work with different commands. The fact that thus mutates a data structure as a side-effect is not ideal but this is the best place to ensure it always gets applied without doing any significant refactoring, since everything after this point happens in the backend package where the normalizePath method is not available.	7 years ago
Kristin Laemmert	126e5f337f	json output of terraform plan (#19687) ... * command/show: adding functions to aid refactoring The planfile -> statefile -> state logic path was getting hard to follow with blurry human eyes. The getPlan... and getState... functions were added to help streamline the logic flow. Continued refactoring may follow. * command/show: use ctx.Config() instead of a config snapshot As originally written, the jsonconfig marshaller was getting an error when loading configs that included one or more modules. It's not clear if that was an error in the function call or in the configloader itself, but as a simpler solution existed I did not dig too far. * command/jsonplan: implement jsonplan.Marshal Split the `config` portion into a discrete package to aid in naming sanity (so we could have for example jsonconfig.Resource instead of jsonplan.ConfigResource) and to enable marshaling the config on it's own.	7 years ago
James Bardin	149ccd929e	missing commits from 19688	7 years ago
James Bardin	9667e06a03	decode backend hash as uint64 ... Older versions of terraform could save the backend hash number in a value larger than an int. While we could conditionally decode the state into an intermediary data structure for upgrade, or detect the specific decode error and modify the json, it seems simpler to just decode into the most flexible value for now, which is a uint64.	7 years ago
Charles Kenney	2dfc3a399d	command: allow -no-color option on "providers" command	7 years ago
Radek Simko	f64978b64c	backend/local: Render CBD replacement (+/-) correctly (#19642) ... * backend/local: Render CBD replacement (+/-) correctly * command/format: Use IsReplace helper function	7 years ago
Radek Simko	b28efa0bf3	command/format: Fix tests	7 years ago
Radek Simko	0b981fa641	command/format: Fix rendering of force-new updates	7 years ago
Radek Simko	fe117e9f02	command/format: Fix rendering of nested blocks during update	7 years ago
Radek Simko	2df886397b	command/format: Add more tests to cover non-primitive fields	7 years ago
Radek Simko	e3e459a8d4	command/format: Restructure tests	7 years ago
Radek Simko	49e7026bdd	command/format: Add tests for ResourceChange renderer	7 years ago
Kristin Laemmert	e3cecb7d56	format/state: added missing newline in the `outputs` output (#19542)	7 years ago
Radek Simko	9e5677adeb	Merge pull request #19453 from hashicorp/b-whole-body-diag-rendering ... command/format: Fix rendering of attribute-agnostic diagnostics	8 years ago
Radek Simko	501fcd1e21	Fix tests after upgrading hcl	8 years ago
Radek Simko	4f2868a019	command/format: Fix rendering of attribute-agnostic diagnostics	8 years ago
Sander van Harmelen	ef9054562e	commands: make sure the correct flagset is used ... A lot of commands used `c.Meta.flagSet()` to create the initial flagset for the command, while quite a few of them didn’t actually use or support the flags that are then added. So I updated a few commands to use `flag.NewFlagSet()` instead to only add the flags that are actually needed/supported. Additionally this prevents a few commands from using locking while they actually don’t need locking (as locking is enabled as a default in `c.Meta.flagSet()`.	8 years ago
Sander van Harmelen	79a9a15879	command/state: lock when pushing state ... Next to adding the locking for the `state push` command, this commit also fixes a small bug where the lock would not be propertly released when running the `state show` command. And finally it renames some variables in the `[un]taint` code in order to try to standardize the var names of a few frequently used variables (e.g. statemgr.Full, states.State, states.SyncState).	8 years ago
Martin Atkins	884aa387b8	command: Use vendoring when building helper programs in tests ... In a couple places in tests we execute a child "go build" to make a helper program. Now that we're running in module mode, "go build" will normally default to downloading and caching dependencies, which we don't want because we're still using vendoring for the moment. Therefore we need to instruct these child builds to use vendoring too, avoiding the need to download all of the dependencies and ensuring that we'll be building with the same dependencies that we'd use for a normal build.	8 years ago
Martin Atkins	5255e85238	"go fmt" fixups ... Apparently my editor is still not reliably formatting on save, so I missed a few formatting quirks in these files.	8 years ago
Martin Atkins	73c9521a04	command/e2etest: Temporarily disable tests that access network ... Several of these tests rely on external services (e.g. Terraform Registry) that have not yet been updated to support the needs of Terraform v0.12.0, so for now we'll skip all of these tests and wait until those systems have been updated. This should be removed before Terraform v0.12.0 final to enable these tests to be used as part of pre-release smoke testing.	8 years ago
Martin Atkins	37bc187f95	command: "terraform output" mustn't panic when no state is present ... This is verified by TestOutput_noArgs.	8 years ago
Martin Atkins	53b5b95ef5	command: Fix TestRefresh_backup ... The local filesystem state manager no longer creates backup files eagerly, instead creating them only if on first write there is already a snapshot present in the target file. Therefore for this test to exercise the codepaths it intends to we must create an initial state snapshot for it to overwrite, creating the backup in the process. There are several other tests for this behavior elsewhere, so this test is primarily to verify that the refresh command is configuring the backend appropriately to get the backups written in the desired location.	8 years ago
Martin Atkins	762a173c7f	command: Fix TestRefresh_outPath ... We now only create a backup state file if the given output file already exists, which it does not in this test. (The behavior of creating the backup files is already covered by other tests, so no need for this one go out of its way to do it.)	8 years ago
Martin Atkins	e2ba90fdfa	command: Fix TestMetaBackend_planLocalMatch ... We now don't create a local state backup until the first snapshot write, so we don't expect there to be a backup file until the end of the test. (There is already a check at the end there, unmodified by this change.)	8 years ago
Martin Atkins	48601d261d	states/statemgr: In Filesystem, back up output file, not input file ... The filesystem backend has the option of using a different file for its initial read. Previously we were incorrectly writing the contents of that file out into the backup file, rather than the prior contents of the output file. Now we will always read the output file in RefreshState in order to decide what we will back up but then we will optionally additionally read the input file and prefer its content as the "current" state snapshot. This is verified by command.TestMetaBackend_planLocalStatePath and TestMetaBackend_configureNew, which are both now passing.	8 years ago
Martin Atkins	27abd9c6b8	command: Fix TestMetaBackend_localDoesNotDeleteLocal ... The changes to how we handle setting the state path on the local backend broke the heuristic we were using here for detecting migration from one local backend to another with the same state path, which would by default end up deleting the state altogether after migration. We now use the StatePaths method to do this, which takes into account both the default values and any settings that have been set. Additionally this addresses a flaw in the old method which could potentially have deleted all non-default workspace state files if the "path" setting were changed without also changing the "workspace_dir" setting. This new approach is conservative because it will preserve all of the files if any one overlaps.	8 years ago
Martin Atkins	be79bf0412	command: Fix TestPlan_outBackend ... In an earlier change we fixed the "backendFromConfig" codepath to be able to properly detect changes to the -backend-config arguments during "terraform init", but this detection is too strict for the normal case of running an operation in a previously-initialized directory. Before any of the recent changes, the logic here was to selectively update the hash to include -backend-config settings in the init case. Since that late hash recalculation was confusing, here we take the alternative path of using the hash only in the normal case and full value comparison in the init case. Treating both of these cases separately makes things marginally easier to follow here.	8 years ago
Martin Atkins	b316e4ab56	command: Fix TestImport_remoteState ... The import command was imposing the default state path at the CLI level, rather than leaving that to be handled by the backend. As a result, the output state was always forced to be terraform.tfstate, regardless of the backend settings.	8 years ago
Martin Atkins	2b9f92be31	command: Partially fix TestMetaBackend_planLocalStatePath ... This test is testing some strange implementation details of the old local backend which do not hold with the new filesystem state manager. Specifically, it was expecting state to be read from the stateOutPath rather than the statePath, which makes no sense here because the backend is configured to read from the default terraform.tfstate file (which does not exist.) There is another problem with this test which will be addressed in a subsequent commit.	8 years ago
Martin Atkins	aecb66d3db	command: Fix TestMetaBackend_configuredChangeCopy_multiToNoDefaultWithoutDefault ... As part of integrating the new "remote" backend we relaxed the requirement that a "default" workspace must exist in all backends and now skip migrating empty workspace states to avoid creating unnecessary "default" workspaces when switching between backends that require it and backends that don't, such as when switching from the local backend (which always has a "default" workspace) to Terraform Enterprise.	8 years ago
Martin Atkins	ec27526cc3	command: Fix TestMetaBackend_configuredChangeCopy_multiToMulti ... This was failing because we now handle the settings for the local backend a little differently as a result of decoding it with the HCL2 machinery. Specifically, the backend.State* fields are now assumed to be what is given in configuration, and any CLI overrides are maintained separately in OverrideState* fields so that they can be imposed "just in time" in StatePaths. This is particularly important because OverrideStatePath (when set) is used regardless of workspace name, while StatePath is a suitable value only for the "default" workspace, with others needing to be constructed from StateWorkspaceDir instead.	8 years ago
Martin Atkins	6c7cecfbd8	command: More logging during migration ... This just finishes off the logging added in earlier commits to get all the way through to the actual migration call.	8 years ago
Martin Atkins	f39a5d0962	command: Fix various TestMetaBackend-prefix tests ... Our new state model has a different implementation of "empty" that doesn't consider lineage/serial, so we need to have some actual content in these state fixtures to avoid them being skipped during state migrations.	8 years ago
Martin Atkins	22c84c71a4	command: Use statemgr.Import and statemgr.Export for state push and pull ... We previously hacked around the import/export functionality being missing in the statemgr layer after refactoring, but now it's been reintroduced to fix functionality elsewhere we should use the centralized Import and Export functions to ensure consistent behavior. In particular, this pushes the logic for checking lineage and serial during push down into the state manager itself, which is better because all other details about lineage and serial are managed within the state managers.	8 years ago
Martin Atkins	aacbe1d14b	command: Fix TestMetaBackend_configureNewWithState ... This test was initially failing because its fixture had a state which our new state models consider to be "empty", and thus it was not migrated. After fixing that (by adding an output to the fixture), this revealed a bug that the lineage was not being persisted through the migration. This is fixed by using the statemgr.Migrate method instead of writing via the normal Writer interface, which allows two cooperating state managers to properly transfer the lineage and serial along with the state snapshot.	8 years ago
Martin Atkins	24046ab833	command: More TRACE logging for the Backend instantiation codepaths	8 years ago
Martin Atkins	2293391241	command: Fix TestMetaBackend_emptyWithExplicitState ... This test was incorrectly updated in a previous iteration, with it creating a modified state to write but then not actually writing it, writing an empty test state instead. This made the test fail because a backup state file is created only if the new state snapshot is different to the old when written.	8 years ago
Martin Atkins	8c54da0ad2	command: TestInit_fromModule_explicitDest guard against other tests ... Some other test is leaving behind a terraform.tfstate after it concludes, which can cause this test to fail in a strange way due to picking up extra provider requirements from that state. This check doesn't fix that problem, but it at least makes the test fail in a more helpful way to avoid time wasted trying to debug this test when it's some other test that actually has the bug.	8 years ago
Martin Atkins	ced06a4ca3	command: fix panic in TestStatePush_lineageMismatch ... This test is currently failing due to the command completing successfully, which would previously cause a panic because we didn't properly initialize the MockUi and so its error buffer is nil unless written to. (The failure this was masking will be fixed in a subsequent commit.)	8 years ago
Martin Atkins	544c2932ce	command: Fix TestInit_checkRequiredVersion ... In prior refactoring we lost the required core version check from "terraform init", which we restore here. Additionally, this test used to have an incorrect name that suggested it was testing something in the "getProvider" codepath, but version checking happens regardless of what other options are selected.	8 years ago
Martin Atkins	9ba399bca8	command: Fix TestInit_getProvider ... After all of the refactoring we were no longer checking the Terraform version field in a state file, causing this test to fail. This restores that check, though with a slightly different error message.	8 years ago
Martin Atkins	f6d468ffd5	command: Fix TestInit_inputFalse ... This test was using old-style state files as its input, differing only by lineage. Since lineages are now managed within the state manager itself, the test can't use that to distinguish the two files and so we put a different output in each one instead. This also introduces some TRACE logging to the migration codepaths. There's some hard-to-follow control flow here and so this extra logging helps to understand the reason for a particular outcome, and since this codepath is visited only in "terraform init" anyway it doesn't hurt to be a bit more verbose here.	8 years ago
Martin Atkins	c0b7f58143	command: Fix detection of necessary backend migration ... In the refactoring for new HCL this codepath stopped taking into account changes to the CLI -backend-config options when deciding if a backend migration is required. This restores that behavior in a different way than it used to be: rather than re-hashing the merged config and comparing the hashes, we instead just compare directly the configuration values, which must be exactly equal in order to skip migration. This change is covered by the test TestInit_inputFalse, although as of this commit it is still not passing due a downstream problem within the migration code itself.	8 years ago
Sander van Harmelen	5e9414bf03	backend/migrations: only select workspaces if supported ... If the backend does not support workspaces, we don't have to try to select a workspace and we should not return an error.	8 years ago
Martin Atkins	297b3b8830	command: Fix TestInit_backendReinitConfigToExtra ... This test was re-using the same InitCommand value to run multiple times, which is not realistic. Since we now cache configuration source code inside command.Meta on load, it's important that we use a fresh InitCommand instance here so it'll see the modified configuration file we've left on disk.	8 years ago
Martin Atkins	b5547f00f6	command: backendConfig must mutate its copy, not the original ... Here we were going to the trouble of copying the body so we could mutate it, but then ended up mutating the original anyway and then returning the unmodified copy. Whoops! This fix is verified by a number of "init" command tests that exercise the -backend-config option, including TestInit_backendConfigFile and several others whose names have the prefix TestInit_backendConfig .	8 years ago
Martin Atkins	8b603e4877	command: Name the Terraform Registry specifically in error message ... When we originally wrote this message we struggled a bit for how to refer to the releases server without writing an awkwardly-ungrammatical sentence, and so "the official repository" became a placeholder name for it. Now that we'll be looking in Terraform Registry this gives us a nice proper noun to use. This message will need to evolve more as our integration with the registry gets more sophisticated, but for now this works.	8 years ago
Martin Atkins	592850e22c	command: Fix TestApply_plan_remoteState ... Some over-zealous bulk updating of this test file caused this test to be producing a remote state config cache file on disk when it doesn't actually need one: the backend config comes from the plan file when applying a saved plan.	8 years ago
Martin Atkins	c05a556c0e	command: Fix TestRefresh_backup ... This test intentionally overrides the backup file location using the -backup option, so the backup file is not in the default location for this one.	8 years ago
Martin Atkins	ad276142b4	command: Fix the command package test build ... Some merging conflict shenanigans here led to this usage not lining up with the imported symbol name, meaning that the tests couldn't compile any more.	8 years ago
Martin Atkins	1e45d30036	command: Fix TestPlan_outBackend ... We missed fixing this up during the big updates for the new plan/state models since the failures were being masked by testBackendState being broken. This is the same sort of update made to many other tests: add schema to the mock provider, adjust for the new plan/state types, and make allowances for the new built-in diffing behavior in core.	8 years ago
Martin Atkins	c3d11b762b	command: Fix testBackendState ... The hashing function for cached backend configuration is different now, so our hard-coded hash of the HTTP backend address wasn't working anymore. Here we update the hash so that tests using this test backend will work again. Rather than leaving it hard-coded, we'll instead compute it the same way as "terraform init" would. In practice only one test is actually using this function right now, so we also update the test fixture for that test (TestPlan_outBackend) to match the new expectations, though as of this commit it's still failing with an unrelated error.	8 years ago
Martin Atkins	e20346bf4f	command: fix TestMeta_process ... The mission of this process method used to include dealing with auto-loaded tfvars files, but it doesn't do that anymore. It does still deal with the -no-color option, but the test wasn't exercising that part before. Now the test here focuses on the -no-color behavior. The process method still has a "vars" flag argument which is no longer used. Since this is an unexported method we could potentially address this but this commit is intentionally limited only to fixing the test.	8 years ago
Martin Atkins	fcf3f643ce	command: Fix TestPlan_shutdown ... Comments here indicate that this was erroneously returning an error but we accepted it anyway to get the tests passing again after other work. The tests over in the "terraform" package agree that cancelling should be a successful outcome rather than an error. I think that cancelling _should_ actually be an error, since Terraform did not complete the operation it set out to complete, but that's a change we'd need to make cautiously since automation wrapper scripts may be depending on the success-on-cancel behavior. Therefore this just fixes the command package test to agree with the Terraform package tests and adds some FIXME notes to capture the potential that we might want to update this later.	8 years ago
Martin Atkins	0ea8aa6fe5	command: Fix TestWorkspace_createWithState ... The State.Equal function is now more precise than this test needs. It's only trying to distinguish between an empty state and a non-empty state, so the string representation of state is good enough to get that done while disregarding other subtle differences.	8 years ago
Sander van Harmelen	52a1b22f7a	Implement the remote enhanced backend ... This is a refactored version of the `remote` backend that was initially added to Terraform v0.11.8 which should now be compatible with v0.12.0.	8 years ago
Sander van Harmelen	b62a22ab62	Add a VariableSourceType for names .tfvars files ... This new source type should be used for variables loaded from .tfvars files that were explicitly passed as command line arguments (e.g. -var-file=foo.tfvars)	8 years ago
Sander van Harmelen	178ec8f7b4	Remove support for the -module-depth flag ... # Conflicts: # backend/backend.go	8 years ago
Sander van Harmelen	643fccc923	Merge pull request #19250 from hashicorp/f-inputs ... Fix the ability to ask for and save user input	8 years ago
Sander van Harmelen	5944e8e34f	Fix the ability to ask for and save user input	8 years ago
Sander van Harmelen	5458a91985	command/state: update and fix the state show command	8 years ago
Sander van Harmelen	7ec3f96e3a	command/state: update and fix the state mv command	8 years ago
Sander van Harmelen	19c1241a50	command/state: update and fix the state rm command	8 years ago
James Bardin	e93d69f18b	more nil/known checks before val.LengthInt	8 years ago
Sander van Harmelen	536c2fe6f1	Make `state mv` use the new `states.Filter`	8 years ago
Sander van Harmelen	5e11de460a	Merge pull request #19130 from hashicorp/f-state-push-pull ... command/state: update and fix the state push and pull	8 years ago
Sander van Harmelen	7fbd93b5cd	command/state: update and fix the state push and pull	8 years ago
Sander van Harmelen	a88ba31b63	Merge pull request #19129 from hashicorp/f-show-list ... command/state: update and fix the state list command	8 years ago
Sander van Harmelen	83168ea25f	Merge pull request #19127 from hashicorp/b-prepare-provider ... Make the test compile again	8 years ago
Sander van Harmelen	af1a471a05	command/state: update and fix the state list command	8 years ago
Sander van Harmelen	4d6626b3a8	Terraform show didn’t show absolute paths ... Without using absolute paths any module info is lost in the output. And the attributes were randomly ordered and so changed between different executions of the command.	8 years ago
Sander van Harmelen	b846c5f653	Make the test compile again ... Not sure if these checks still make sense, but without this change the test don’t compile for the related packages.	8 years ago
Martin Atkins	17b883f592	command/format: Include variable values in diagnostic messages ... When HCL encounters an error during expression evaluation, it annotates its diagnostics with information about the expression that was being evaluated and the EvalContext it was evaluated in. This gives us enough information to show helpful hints to the user about the final values of any reference expressions that are present in the expression, which is very useful extra context for expressions that get evaluated multiple times, such as: - Any expression in a block with "count" or "for_each" set - The sub-expressions within a "for" expression	8 years ago
James Bardin	e08a388d3c	check IsKnown on values that may panic	8 years ago
Sander van Harmelen	48ef7ecfa6	Updates after running `make fmt` with Go v1.11.1	8 years ago
James Bardin	fe9ed37dfc	minor fixes for command Apply tests	8 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	8 years ago
Martin Atkins	8e51363f04	command: Don't allow -var and -var-file when applying saved plan ... This reinstates an old behavior that was lost in the reorganization of how we deal with the -var and -var-file options. This fix is verified by TestApply_planVars now passing.	8 years ago
Martin Atkins	7abf81d8da	command: Restore support for terraform.tfvars.json ... In the new implementation of collecting variables I initially forgot the JSON variant of terraform.tfvars. This fix is verified by TestApply_varFileDefaultJSON now passing.	8 years ago
Martin Atkins	66f96cf842	command: Un-stub and reimplement "terraform state rm" ... This was previously targeting the old state manager and state types, so it needed some considerable rework to get it working again with the new state types. Since our new resource address syntax lacks the weird extra .deposed special case we had before, we instead interpret addresses as whole-instance addresses here and remove the deposed objects along with the current one (if present), since this is more likely to match with user expectations because we don't consider deposed objects to be independently addressable in any other situation. With that said, to be more explicit about what is going on we do now have a -dry-run mode and maintain separate counts of current and deposed instances so that we can expose that in the UI where relevant.	8 years ago
Martin Atkins	40eda180d6	command: go fmt in import_test.go and refresh_test.go	8 years ago
Martin Atkins	8b466811d2	command: Fix a few tests from meta_backend_test.go	8 years ago
Martin Atkins	86b7963bba	command: Fix tests for "terraform providers"	8 years ago
Martin Atkins	5b61cc919b	command: Fix "terraform import" tests	8 years ago
Martin Atkins	7b77e20bdc	command: Fix several "terraform init" tests	8 years ago
Martin Atkins	89d0944e5b	command: Fix even more of the "terraform refresh" tests	8 years ago
Martin Atkins	5d1d6a95f9	command: "go fmt" of plan_test.go	8 years ago
Martin Atkins	e54848b86f	command: Fix many (but not all) "terraform refresh" tests	8 years ago
Martin Atkins	73abb6e8f4	command: Re-enable showing outputs after successful "apply" ... We temporarily disabled this because it needed some further work to update it for the new state models, which has now been done. We no longer need the configuration objects for the outputs because the state itself contains all of the information needed for displaying these.	8 years ago
Martin Atkins	98bbd560b5	command: Fix most (but not all) "terraform plan" tests	8 years ago
Martin Atkins	ca314afc0d	command: Make suitable provider schemas available for all "plan" tests	8 years ago
Martin Atkins	73318a436b	command: go fmt	8 years ago
Martin Atkins	53bb3f57e6	command: Remove tests related to legacy remote state migrations, etc ... We no longer support legacy remote state, so the behaviors these tests were covering are no longer present.	8 years ago
Martin Atkins	275a44f552	command: Reinstate object ids in the UIHook progress logs ... We used to treat the "id" attribute of a resource as special and elevate it into its own struct field "ID" in the state, but the new state format and provider protocol treats it just as any other attribute. However, it's still useful to show the value of a single identifying attribute when there isn't room in the UI for showing all of the attributes, and so here we take a new strategy of considering "id" along with some other conventional names as special only in the UI layer. This new heuristic approach can be adjusted over time as new provider patterns emerge, but for now it covers some common conventions we've seen in real providers. With that said, since all existing providers made for Terraform versions prior to v0.12 were forced to set "id", we won't see any use of other attributes here until providers are updated to remove the placeholder ids they were generating in cases where an id was not actually relevant but was forced by the old protocol. At that point the UX should be improved by showing a more relevant attribute instead. We now also allow for the possibility of no id at all, since that is valid for resources that exist only within the Terraform state, like the ones from the "random" and "tls" providers.	8 years ago
Martin Atkins	43d5206d82	command: Stub the "terraform state mv" tests to remind to fix ... This command isn't yet updated for the new state types, but since we were not returning a non-successful error status here the tests were just failing in a weird way instead. Now we'll fail with a message that makes it clear there is still work to do in the real implementation here.	8 years ago
Martin Atkins	1d64ce8ec0	command: Fix "terraform validate" tests ... We now need to give a provider schema that the test fixtures conform to, so we can validate against it.	8 years ago
Martin Atkins	025540789c	command: Restore the "terraform output" functionality ... We previously stubbed most of this out because it hadn't yet been updated to support the new state types, etc. This restores all of the previous behavior as covered by the tests. We intentionally remove one behavior that was not covered by the tests: we used to allow retrieval of outputs from non-root modules using the -module option, but since we no longer persist non-root outputs in the state we can no longer support this without a full expression evaluation walk, and that'd be overkill for this otherwise-simple command. Descendant module outputs are not part of the public interface of a configuration anyway, so accessing them from outside in this way is an anti-pattern. (For debugging scenarios it is still possible to access these from "terraform console", which _does_ do a full evaluation graph walk to prepare its evaluation scope.)	8 years ago
Martin Atkins	feff10dcb5	command: Fix TestGraph_plan ... The plan file writer requires a backend config to be present, but we don't really need one for the sake of _this_ test, since we don't activate the backend to render a plan graph, and so we just write in a placeholder.	8 years ago
Martin Atkins	c0baedac84	command: Fix tests for "terraform fmt" command ... Some underlying assumptions have shifted here, so although the behavior is still broadly the same we need to accommodate some different details.	8 years ago
Martin Atkins	74582447bb	command: Make input variable values available to "terraform console" ... This fixes TestConsole_tfvars.	8 years ago
Martin Atkins	741d334ee4	command: Even more fixes for "apply" command tests	8 years ago
Martin Atkins	34a29315f7	command: More fixes (but still not all) for "apply" command tests	8 years ago
Martin Atkins	de3944b9bf	command: collect root module variable values for apply/plan/refresh ... This connects a missing link left by earlier refactoring: the command package is responsible for gathering up variable values provided by the user and passing them through to the backend to use in operations.	8 years ago
Martin Atkins	fc2614c939	command: Fix some tests for the "apply" command	8 years ago
Martin Atkins	34c4fd316d	command: Update backend-unchanged fixture for new expectations ... Our serialization of the backend configuration has changed slightly for Terraform 0.12 due to reimplementing it in terms of the HCL2 types, so the base case that should be unchanged during the test needs to be changed.	8 years ago
Martin Atkins	34ebde0b95	command/format: be resilient to incomplete schema when formatting state ... In all real cases the schemas should be populated here, but we don't want to panic in UI rendering code if there's a bug here. This can also be tripped up by tests with incomplete mocks. It's unfortunate that this can therefore mask some problems in tests, but tests can protect against it by asserting on specific output text rather than just assuming that a zero exit status is a pass.	8 years ago
Kristin Laemmert	3cf1b001c2	command/format: revert indentation change for consistency's sake	8 years ago
Kristin Laemmert	db26324b3c	command/format: fix indentation ... also run go mod tidy	8 years ago
Martin Atkins	d63c2fdd8d	command: Show snippet of invalid resource addresses in import ... If we fail to parse the resource address given to "terraform import" then it's helpful to produce a "source code" snippet of what the user provided so they might see more precisely which part of the address was invalid.	8 years ago
Martin Atkins	27d086d8bd	command: Fix TestUntaint	8 years ago
Martin Atkins	1bc10180cb	command: Fix all of the "taint" command tests ... Most of this is just updates to allow for the fact that we now always save the provider address as part of resource state, whereas before it was only saved conditionally. This also updates TestTaint_module for the intentional change that it now expects a child module to be specified using normal resource address syntax, rather than as a separate -module option.	8 years ago
Martin Atkins	8321c3614f	command: Fix TestUntaint_module ... The untaint command now uses normal resource address syntax to specify the module path, rather than passing it in as a separate argument.	8 years ago
Martin Atkins	3cee60ee3a	command: Fix various "untaint" command tests ... Resource instance state now always includes the provider address fo each resource, so our expected state output strings needed to be adjusted.	8 years ago
Martin Atkins	55b9c7eacd	command: Actually include the error when backend config decoding fails	8 years ago
Kristin Laemmert	a4c3022cf8	command/show: config files are assumed to be in cwd	8 years ago
Kristin Laemmert	d08fe7a91f	cli: format/state_test.go ... Added a very simple test with state and schema. TODO: if tests are added we should test using golden files (and example state files, instead of strings). This seemed unnecessary with the simple test cases.	8 years ago
Kristin Laemmert	14c28b8de4	cli: format/state refactor to use blockBodyDiffPrinter ... Use functions from format/diff to print values	8 years ago
Kristin Laemmert	8063f69e5c	cli: format/state refactor for new state format ... format/state now requires provider schemas to properly format output state. command/show has been modified to pass a context to format.State.	8 years ago
Martin Atkins	e8240087fe	command: Populate backend configuration in plan files ... In previous work we didn't quite connect these dots. The connection here is sub-awesome since the existing interfaces here had some unfortunate assumptions that we'd like to move away from (like the idea of a "nil backend" implying the local backend) but we're accepting this for now to avoid another big round of refactoring. The main implication of this is that we will now always include a backend configuration in the plan, though it might just be a placeholder config for the local backend in the remaining cases where that's still implicitly set. Later we will change this so that there is no implicit local backend at all (terraform init is always required, _it_ will deal with setting implicitly setting the local backend when appropriate), which will allow us to rework this to be more straightforward and less "spooky".	8 years ago