30476 Commits (d40b5c7755d04ac3d02e6dfb587b9e70dc608ee8)

 

All Branches   

Search

Author	SHA1	Message	Date
Craig Wright	d40b5c7755	Update .github/ISSUE_TEMPLATE/documentation_issue.yml ... Co-authored-by: Judith Malnick <judith.patudith@gmail.com>	4 years ago
Craig Wright	a8d6d5c913	Correcting a line break visual issue.	4 years ago
Craig Wright	b1c720a633	Update .github/ISSUE_TEMPLATE/documentation_issue.yml ... Thanks! Co-authored-by: Judith Malnick <judith.patudith@gmail.com>	4 years ago
Craig Wright	f058392421	Apply suggestions from code review ... Thanks! Co-authored-by: Judith Malnick <judith.patudith@gmail.com>	4 years ago
Craig Wright	3afa9bd08e	Create documentation_issue.yml ... Closes https://github.com/hashicorp/terraform/issues/31552. Adds a new issue form type for documentation issues. Format discussed with docs team.	4 years ago
Laura Pacilio	1faa05b344	Merge pull request #31945 from hashicorp/fix-backends-link ... Update backends.mdx	4 years ago
Laura Pacilio	8258070fd5	Update website/docs/language/state/backends.mdx	4 years ago
Laura Pacilio	97c628044a	Update website/docs/language/state/backends.mdx	4 years ago
Laura Pacilio	bed5650e2f	Update backends.mdx	4 years ago
James Bardin	3047b8c13e	Merge pull request #31878 from hashicorp/jbardin/import-plan-new ... evaluation of missing instances during import	4 years ago
James Bardin	041d9d3eec	unknown evaluation of missing instances in import ... Because import does not yet plan new instances as part of the import process, we can end up evaluating references to resources which have no state at all. The fallback for this situation could result in slightly better values during import. The count and for_each values were technically incorrect, since the length is not known to be zero, and the single instance does have a concrete type which we can return.	4 years ago
James Bardin	c1e0b046b8	Merge pull request #31917 from hashicorp/jbardin/destroy-edge-cycles ... Extract more exact provider name when checking for destroy cycles	4 years ago
James Bardin	c296172be7	test for cycle around aliased provider	4 years ago
James Bardin	036fb9c1bf	check detailed provider for destroy edge cycles ... When we checked for cycles with destroy edges around providers, it was only for providers of a different type, but one can do the same thing with the same provider under different local aliases. Check to see if the provider also contains an alias, or is defined absolutely in some other way. The absolute accuracy here isn't critical, since in most cases these edges are not required for correct results, but finding a correct and consistent method for determining when these edges are needed is going to take more research. There was also an oversight fixed here where the basic creator->destroyer edges were added _after_ the cycle checks, limiting their utility. The ordering of the additions was swapped to make sure all cycles are noticed.	4 years ago
James Bardin	162b7274fa	Merge pull request #31914 from hashicorp/jbardin/ignore-all-legacy ... special handling for legacy `ignore_changes = all`	4 years ago
Sarah French	65b531c416	Update CHANGELOG.md	4 years ago
Sarah French	d43ec0f30f	Add customer-managed encryption key (KMS) support to GCS backend (#31786) ... * Add ability to use customer-managed KMS key to encrypt state, add acceptance tests * Change test names for different encrpytion methods * Commit files updated by `go mod tidy` * Add guard against missing ENVs to `setupKmsKey` func * Update KMS setup function to get credentials from ENVs * Update tests to not include zero-values in config This means that default values are supplied later by TF instead of supplied as config from the user This also avoids issues related to making field conflicts explicit with `ConflictsWith` * Make `encryption_key` & `kms_encryption_key` conflicting fields Removing the Default from `encryption_key` does not appear to be a breaking change when tested manually * Add ability to set `kms_encryption_key` via ENV * Refactor `encryption_key` to use `DefaultFunc` to access ENV, if set * Remove comments * Update `gcs` backend docs & descriptions in schema * Update `gcs` backend docs to include information on encryption methods * Apply technical writing suggestions from code review Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> * Update documentation to remove passive voice * Change use of context in tests, add inline comment, update logs * Remove use of `ReadPathOrContents` for new field Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com>	4 years ago
Craig Wright	e7fb895c46	Merge pull request #31876 from zisom-hc/patch-1 ... Update custom-conditions.mdx	4 years ago
James Bardin	fcec9e2c4f	Merge pull request #31902 from hashicorp/jbardin/noop-deposed ... Prevent errors from NoOp deposed changes	4 years ago
James Bardin	f78ecef5e7	prevent errors from NoOp deposed changes ... If a previously deposed object is deleted outside of Terraform, the next plan will result in a NoOp change for the deposed object. Fix the check to verify that the deposed object has an acceptable action rather than use the `update` flag.	4 years ago
Martin Atkins	0803ea3f4a	Update CHANGELOG.md	4 years ago
Martin Atkins	f260ed1177	website: Remove warning that yamlencode is experimental ... We originally included this warning because the go-cty-yaml module wasn't yet stable and it was also not extensively tested so it wasn't yet clear if its behavior would need to change in some less common cases we hadn't tested so far. However, go-cty-yaml had its v1.0.0 release some time ago and is now committed to preserving its current Marshal output unless it is found to be non-compliant with the YAML 1.2 specification. This doc change means that Terraform's yamlencode is now adopting a similar posture: - The exact style details produced by the function for a particular input are now frozen. It'll change only if we find that the function is producing output that isn't valid per the YAML spec. - If someone finds a YAML parser that cannot parse what yamlencode produces but what it produces is valid per the YAML 1.2 spec, we'll expect the parser to be corrected to better support the spec rather than changing the yamlencode output. There may be pragmatic exceptions if we encounter a situation we cannot anticipate yet, but the above will be our general rule. This is really just a specialization of the spirit of the v1.x Compatibility Promises, tailored specifically to this function.	4 years ago
James Bardin	92f3a83530	special handling for legacy ignore_changes = all ... Legacy providers expect Terraform to be able to clean up invalid plans and computed attributes. Add a special case for the LegacyTypeSystem to revert `ignore_changes = all` to the complete prior state.	4 years ago
Martin Atkins	6b290cf163	core: Don't re-register checkable outputs during the apply step ... Once again we're caught out by sharing the same output value node type between the plan phase and the apply phase. To allow for some slight variation between plan and apply without drastic refactoring here we just add a new flag to nodeExpandOutput which is true only during the planning phase. This then allows us to register the checkable objects only during the planning phase and not incorrectly re-register them during the apply phase. It's incorrect to re-register during apply because we carry over the planned checkable objects from the plan phase into the apply phase so we can guarantee that the final state will have all of the same checkable objects that the plan did. This avoids a panic during the apply phase from the incorrect duplicate registration.	4 years ago
kmoe	62d22a9406	Update CHANGELOG.md	4 years ago
Radek Simko	196ff4c5c5	providercache: Improve installation error message (#31898)	4 years ago
James Bardin	8c98e1f4a4	Merge pull request #31747 from hashicorp/jbardin/ignore-changes-all-computed ... filter computed attrs from `ignore_changes=all`	4 years ago
Sarah French	a29fefbec7	Update codeowner of `gcs` backend to include Strategic Integrations team (#31848) ... * Update codeowner of gcs backend to SI team * Update CODEOWNERS of gcs backend	4 years ago
zisom-hc	d08fcd63db	Update custom-conditions.mdx ... Made a change to code example within the *Preconditions and Postconditions* section so that it technically makes sense; prior it was missing the data resource that was being called within the precondition lifecycle event on line 135, and the aws_instance resource was not utilizing the ami being provided by the data source in line 129, so i changed that as well.	4 years ago
Martin Atkins	cc964e6b0b	core: Document that TransformRoot must produce coalescable node ... We use a non-pointer value for this particular node, which means that there can never be two root nodes in the same graph: the graph implementation will just coalesce them together when a second one is added. Our resource expansion code is relying on that coalescing so that it can subsume together multiple graphs for different modules instances into a single mega-graph with all instances across all module instances, with any root nodes coalescing together to produce a single root. This also updates one of the context tests that exercises resource expansion so that it will generate multiple resource instance nodes per module and thus potentially have multiple roots to coalesce together. However, we aren't currently explicitly validating the return values from DynamicExpand and so this test doesn't actually fail if the coalescing doesn't happen. We may choose to validate the DynamicExpand result in a later commit in order to make it more obvious if future modifications fail to uphold this invariant.	4 years ago
Martin Atkins	2e177cd632	core: Eliminate NodePlannableResource indirection ... We previously did two levels of DynamicExpand to go from ConfigResource to AbsResource and then from AbsResource to AbsResourceInstance. We'll now do the full expansion from ConfigResource to AbsResourceInstance in a single DynamicExpand step inside nodeExpandPlannableResource. The new approach is essentially functionally equivalent to the old except that it fixes a bug in the previous implementation: we will now call checkState.ReportCheckableObjects only once for the entire set of instances for a particular resource, which is what the checkable objects infrastructure expects so that it can always mention all of the checkable objects in the check report even if we bail out partway through due to a downstream error. This is essentially the same code but now turned into additional methods on nodeExpandPlannableResource instead of having the extra graph node type. This has the further advantage of this now being straight-through code with standard control flow, instead of the unusual inversion of control we were doing before bouncing in and out of different Execute and DynamicExpand implementations to get this done.	4 years ago
Martin Atkins	a9bd4099d3	core: DynamicExpand can return diagnostics ... We were previously _trying_ to handle diagnostics here but were not quite doing it right because we were testing whether the resulting error was nil rather than appending it to the diagnostics and then seeing if the result has errors. The difference here is important because it allows DynamicExpand to return warnings without associated errors when needed. Previously the graph walker would treat a warnings-only result as if it were an error. Ideally we'd change DynamicExpand to return diagnostics directly, but we previously decided against that because there were so many implementors to update, and my intent for this change is to be surgical in the update so we minimize risk of backporting the change into patch releases.	4 years ago
James Bardin	dbaf6d63f3	Merge pull request #31871 from hashicorp/jbardin/remove-planned-during-import ... RemovePlannedResourceInstanceObjects during import	4 years ago
James Bardin	008810f593	Merge pull request #31858 from hashicorp/jbardin/prune-plan-destroy ... prune unused nodes from a destroy plan graph	4 years ago
James Bardin	1c8352d926	Merge pull request #31857 from hashicorp/jbardin/destroy-edge-cycles ... prevent cycles when connecting destroy nodes	4 years ago
James Bardin	ce02344589	prevent cycles when connecting destroy nodes ... When adding destroy edges between resources from different providers, and a provider itself depends on the other provider's resources, we can get cycles in the final dependency graph. The problem is a little deeper than simply not connecting these nodes, since the edges are still needed when doing a full destroy operation. For now we can get by assuming the edges are required, and reverting them only if they result in a cycle. This works because destroy edges are the last edges added to managed resources during graph building. This was rarely a problem before v1.3, because noop nodes were not added to the apply graph, and unused values were aggressively pruned. In v1.3 however all nodes are kept in the graph so that postcondition blocks are always evaluated during apply, increasing the chances of the cycles appearing.	4 years ago
James Bardin	5bca0c609b	RemovePlannedResourceInstanceObjects during import ... Because import uses the complete planning process, it must also call RemovePlannedResourceInstanceObjects. This is required to serialized the resulting state if there are data sources with an ObjectPlanned status because they could not be read during the import process.	4 years ago
Laura Pacilio	a8ea377e7f	Merge pull request #31849 from hashicorp/workspaces-confusion-fixes ... Update workspace documentation	4 years ago
Laura Pacilio	0471c80ebe	Update website/docs/language/state/workspaces.mdx	4 years ago
Laura Pacilio	2ea3765fa6	Update website/docs/language/state/workspaces.mdx	4 years ago
Laura Pacilio	6753fb5476	Update website/docs/language/state/workspaces.mdx	4 years ago
Laura Pacilio	776c25777d	Update website/docs/language/state/workspaces.mdx	4 years ago
Laura Pacilio	94eed2c45b	Incorporate PR feedback	4 years ago
James Bardin	aedd95a1ee	prune unused nodes from a destroy plan graph ... We may need to prune nodes from a full destroy plan graph which cannot be evaluated if there is no current state. Add missing method to nodeExpandPlannableResource to ensure planned resource are handled correctly when pruning nodes.	4 years ago
UKEME BASSEY	a5926f1e9a	Merge pull request #31813 from hashicorp/uk1288-redact-output-sensitive-values ... omit sensitive output values in logs from terraform apply json command	4 years ago
Alisdair McDiarmid	6448d7bfd6	Merge pull request #31847 from hashicorp/alisdair/pre-convert-optional-defaults ... Upgrade hcl to fix crash with optional attributes	4 years ago
Alisdair McDiarmid	10ae444ee2	Upgrade HCL to fix optional attr default crash ... Also add regression test coverage of the crash. This would occur when objects with optional attributes had default values of different type from the attribute type, and the objects were members of a collection. For example: list(object({ a = optional(set(string), []) })) If this type constraint is applied to a variable value where one object has a set(string) value for a, and the other object applies the empty tuple default, Terraform would crash.	4 years ago
Matthew Garrell	1e6f091976	Merge pull request #31598 from bobsut/patch-1 ... insert missing infinitive particle	4 years ago
Laura Pacilio	f7bf19525e	Move TFC workspaces section further down	4 years ago
Laura Pacilio	35a5e92687	language fix	4 years ago