30763 Commits (d1d55653e49137d697b835e32d035d4d30bcfe60)

 

All Branches   

Search

Author	SHA1	Message	Date
James Bardin	d1d55653e4	update comment for fixed test	3 years ago
James Bardin	8e917e5513	check for non-computed within optional+computed ... We can check if an object in state must have at least partially come from configuration, by seeing if the prior value has any non-null attributes which are not computed in the schema. This is used when the configuration contains a null optional+computed value, and we want to know if we should plan to send the null value or the prior state.	3 years ago
James Bardin	e16b848d00	expand test case	3 years ago
James Bardin	7ca9abe463	optional+computed ... Simplify the proposedNewAttributes cases, and add another test for coverage.	3 years ago
James Bardin	470ed22730	failing tests for nested sets in objchange ... Add a number of test cases which fail without the prior changes.	3 years ago
James Bardin	048ee3432c	better handling of nested sets in objchange ... Combine and simplify the set comparison functions for NestingSet blocks and attribute types. The set handling for structural attributes was not recursing into nested values. Once a simplified method for comparing set elements was devised for nested types, it turns out the same method could be applied to nested set blocks as well.	3 years ago
James Bardin	ac4f5fe2f9	reformat	3 years ago
James Bardin	986127e619	remove unused isConfig arg	3 years ago
James Bardin	e661e91bff	failing test for nested set types	3 years ago
James Bardin	93f739e927	optional+computed can contain nested objects ... When structural attributes were added, optional+computed were not correctly handled when containing nested values which could themselves be computed. This would cause terraform to ignore previously computed values from state when generating the proposed plan. The special case for optional+computed was incorrect, but isn't needed in the context of planning new values anyway. Attributes are either computed, or not computed. When optional+computed is set and there is no configuration, the attribute is treated as computed. It is up to the provider to determine how and when to deal with any changes to that computed value.	3 years ago
Liam Cervante	95782f2491	Structured plan renderer: Implement the main functionality for the renderer (#32496) ... * raw unmodified broken tests * tests execute, no panics * fix whitespace differences * fix all the tests * fix tests * actually fix tests * add missing plan metadata into the renderer * address comments * complete merge * remove TODO raising questions about outputs, they are fixed * missing bold on plan	3 years ago
Liam Cervante	af0ff90d6e	Remove outputs from the jsonplan that are not from the root module (#32503)	3 years ago
Liam Cervante	c125397da1	push the colorize actions as locally as possible (#32502)	3 years ago
James Bardin	df601a7fd0	Merge pull request #32500 from hashicorp/jbardin/old-condition-results ... remove deprecated `condition_results` from the json plan	3 years ago
James Bardin	96b1318167	remove deprecated condition_results from plan	3 years ago
James Bardin	0a73e216e5	Merge pull request #32463 from hashicorp/jbardin/nesting-single-null ... NestingSingle blocks can be null	3 years ago
Liam Cervante	f6d625103c	Structured plan renderer: refactor replace paths logic (#32489) ... * change -> diff, value -> change * also update readme# * structured plan renderer: refactor replace paths logic * goimports * goimports * address comments * fix compile error	3 years ago
Liam Cervante	38afb41787	Structured plan renderer: Introduce support for multiline and JSON strings (#32488) ... * pause implementation * change -> diff, value -> change * add support for json and multiline strings to the primitive renderer * goimports * remove unused function * go fmt * address comments	3 years ago
Liam Cervante	8330b7295b	Structured plan renderer: Add support for map blocks and sensitive blocks. (#32491) ... * change -> diff, value -> change * also update readme# * pause * Update internal/command/jsonformat/computed/diff.go Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> * add interface assertions for diff renderers * Add support for different kinds of blocks, and for sensitive blocks Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	3 years ago
Liam Cervante	21bb677db7	Structured Plan Renderer: Naming and package structure refactor (#32486) ... * change -> diff, value -> change * also update readme# * Update internal/command/jsonformat/computed/diff.go Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> * add interface assertions for diff renderers Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	3 years ago
Liam Cervante	a086453783	Structured Plan Renderer: Refactor Primitive and Sensitive value processing (#32476) ... * refactor sensitive and primitive values to match patterns used elsewhere * goimports * address comments * fix tests * also use %q for map keys	3 years ago
Liam Cervante	46ab53d651	Structured Plan Renderer: Escape object and block keys that don't match HCL syntax (#32483) ... * Escape object and block keys that don't match HCL syntax * address comments	3 years ago
Liam Cervante	7a3fc48b70	Structured Plan Renderer: Add tests validating behaviour of dynamic types (#32482) ... * add support for dynamic types into attribute processing * fix names * add tests	3 years ago
Liam Cervante	d31631675b	Add support for Tuples into the structured plan renderer (#32479) ... * add support for tuples to the structured plan renderer * update after latest main changes	3 years ago
Liam Cervante	2d66eee872	Structured Plan Renderer: Address comments raised in previous PRs (#32478) ... * Address comments raised in previous PRs * add doc comments for public types	3 years ago
Liam Cervante	1332d315b6	Structured Plan Renderer: Remove generic `interface{}` entry point (#32477) ... * Remove the single generic point of entry into the differ package * goimports * add comment explaining generic function	3 years ago
Liam Cervante	9bc5ded27a	Add support for outputs in the structured renderer (#32426) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * Add support for sets in the structured renderer * goimports * Add support for blocks in the structured renderer * goimports * Add support for outputs in the structured renderer * fix ordering of blocks * remove unused test stub * fix typo	3 years ago
Liam Cervante	05f1764a0d	Add support for blocks in the structured renderer (#32422) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * Add support for sets in the structured renderer * goimports * Add support for blocks in the structured renderer * goimports * fix ordering of blocks * remove unused test stub	3 years ago
Liam Cervante	69cce3597f	Add support for sets in the structured renderer (#32409) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * Add support for sets in the structured renderer * goimports	3 years ago
Liam Cervante	aff94591c1	Add support for lists in the structured renderer (#32401) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer * Add support for lists in the structured renderer * goimports * add additional comments explaining	3 years ago
Liam Cervante	8975eebf84	Add support for maps in the structured renderer (#32397) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer * Add support for maps in the structured renderer	3 years ago
Liam Cervante	b097d8873d	Add support for the replace paths data in the structured renderer (#32392) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports * Add support for the replace paths data in the structured renderer	3 years ago
Liam Cervante	1eebcf875f	Add support for object attributes in the structured renderer (#32391) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests * Add support for object attributes in the structured renderer * goimports	3 years ago
Liam Cervante	b8b1a8d430	Add support for unknown/computed values in the structured renderer (#32378) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer * Add support for unknown/computed values in the structured renderer * delete missing unit tests	3 years ago
Liam Cervante	6ab277f6ba	Add support for sensitive values in the structured renderer (#32375) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * Add support for parsing and rendering sensitive values in the renderer	3 years ago
Liam Cervante	71daef058f	Add rendering functionality for primitives to the structured renderer (#32373) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add rendering functionality for primitives to the structured renderer * add test case for override * goimports	3 years ago
Liam Cervante	aff7d360e1	Add skeleton functions and API for refactored renderer (#32368) ... * prep for processing the structured run output * undo unwanted change to a json key * Add skeleton functions and API for refactored renderer * goimports * Fix documentation of the RenderOpts struct * Add README explaining implementation details for renderer and plans for future expansion * Update internal/command/jsonformat/README.md Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> * address comments Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	3 years ago
Liam Cervante	b917154a97	Make required JSON structured output structures public for processing (#32367) ... * prep for processing the structured run output * undo unwanted change to a json key	3 years ago
kmoe	4fc02469e7	docs: delete outdated Resource Lifecycle page (#32387) ... * Delete lifecycle.mdx * remove resource lifecycle link * Update internals-nav-data.json	3 years ago
James Bardin	e200f53ec0	Merge pull request #32464 from hashicorp/jbardin/output-check-refs ... Ensure we have all references for output preconditions	3 years ago
James Bardin	45cb0489d0	test references only from output preconditions ... These references were getting dropped, which could cause the referenced nodes to be pruned from the graph.	3 years ago
James Bardin	1790f844b3	output refs missing error_message ... Output references must also include the error_message expression. Fix the early return in referencesForOutput, which could skip preconditions. The small slice allocation optimization is not really needed here, since this is not a hot path at all.	3 years ago
James Bardin	d5d6d61c4c	NestingSingle blocks can be null ... NestingSingle blocks removed from from the config were causing a plan to error out with "... planned for existence but config wants absence". Terraform core was proposing an incorrect value in this case, taking the prior instead as a fallback because a null value was not expected. Unlike other collection nesting modes, a NestingSingle block not present in the configuration is a null value, and should be allowed when planning a new value rather than building an empty object or falling back to the prior value.	3 years ago
James Bardin	6e2a7496c4	update CHANGELOG.md	3 years ago
James Bardin	721df0e68d	Merge pull request #32395 from hashicorp/jbardin/plan-output-on-error ... Always show and store planned actions and checks even when planning fails	3 years ago
Liam Cervante	8e1b660b79	Update equivalence tests to counter non-deterministic output (#32366)	3 years ago
James Bardin	5bcfd36c26	Merge pull request #32428 from hashicorp/jbardin/ignore-changes-panic ... don't panic with a null list block value in config	3 years ago
Craig Wright	deea9b24a9	Merge pull request #32442 from Twixes/patch-1 ... Add missing HCL syntax highlighting in `composition.mdx`	3 years ago
Michael Matloka	28d7a685a9	Add missing HCL syntax highlighting in `composition.mdx`	3 years ago
James Bardin	ea193d5ce6	don't panic with a null list block value in config ... Using ignore_changes with a list block, where the provider returned an invalid null value for that block, can result in a panic when validating the plan. Future releases may prevent providers from storing a null block in state, however we can avoid the panic for now. Only the NestingList case needs to be handled, because legacy providers only have list and set blocks, and the set case does not use the config value.	3 years ago