759 Commits (cc1bf23fee706113fbdf2129be37dd772a2e1ef2)

Author	SHA1	Message	Date
James Bardin	bc31dc3d36	add a nested map test to hcl2shim	8 years ago
James Bardin	499cb5c56f	unknown collections in a flatmap ... Unknown collections in a flatmap also need to be converted to unknown values.	8 years ago
Martin Atkins	35ae732cb2	config/hcl2shim: Treat DynamicVal like any other unknown value in flatmap	8 years ago
Kristin Laemmert	f2c460cb2f	registry: renaming module-specific registry functions	8 years ago
James Bardin	75f7e19c68	update the new RequiresReplace function ... Make the function work specifically how we need for RequiresReplace. Skip index changes, any set changes are only recorded as the set itself, and filter out duplicate paths. Add a few more tests to check for various nested structures.	8 years ago
James Bardin	63808f9350	change PathFromFlatmapKey to RequiresReplace ... Rather than try and make a generalized path function here, what we really need in a function to generate the paths needed for RequiresReplace. This needs to take into account that sets elements don't need to be indexed themselves, and changes to collection index values aren't needed.	8 years ago
James Bardin	1b536a2792	add hcl2shim.PathFromFlatmapKey ... PathFromFlatmapKey is used to convert a flatmap key to a cty.Path, and ensures it conforms to the type schema. This is used when handling Diffs, where the ResourceAttrDiffs are indexed by the flatmapped key values, and we need to convert those to addresses to apply to a cty.Value.	8 years ago
James Bardin	1d3d7d07c8	handle Null collections in flatmaps ... When creating a flatmap from a cty.Value, there may be Null collections which don't need to be added to the flatmap at all. Skip over these to avoid panicking in ElementIterator with a Null value.	8 years ago
James Bardin	7243b5aa57	return a nil flatmap when presented with a NullVal ... A nil flatmap will be encoded as a NullVal of the correct type. When Converting a NullVal back to a flatmap, return nil immediately rather than attempting to build the values.	8 years ago
James Bardin	9a1e1226cd	return a NullVal when presented with a nil flatmap ... This allows us to decode the cty.Value back to a nil map, rather than trying to create a map with nil values.	8 years ago
Martin Atkins	a98d25f41d	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	1283ddbb6b	hcl2shim: Handle unknown values when shimming to/from flatmap ... Previously unknown values were round-tripping through flatmap and coming out as known strings containing the UnknownVariableValue. (The classic bug that, ironically, was one of the big reasons to write cty!) Now we properly handle unknown values in both directions: going in to flatmap we write UnknownVariableValue at the appropriate key (as the count for sequences or maps) and then coming out of flatmap we turn UnknownVariableValue back into a cty unknown value of the requested type.	8 years ago
Martin Atkins	2758712122	config/hcl2shim: shims from flatmap to cty and vice-versa ... These particular shims will have a pretty limited lifetime in mainline Terraform code (primarily to stub out the new expression evaluator against the old state structs until the new format is implemented) but will live on for some time in state migration and provider plugin compatibility shims.	8 years ago
Martin Atkins	8edfe2a84f	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	8 years ago
Martin Atkins	883b50c6f2	configschema: Block.CoerceValue method ... The usual way to use a configschema.Block is to obtain a hcldec spec from it and then decode an hcl.Body. There are inevitably situations though where a body has already been decoded into a cty.Value before we know which schema we need to use. This new method CoerceValue is intended to deal with this case, applying the schema to an already-decoded value in what should be an intuitive way for most situations.	8 years ago
Martin Atkins	47f4580eb3	configschema: include description in schema ... We will need access to this information in order to render interactive input prompts, and it will also be useful in returning schema information to external tools such as text editors that have autocomplete-like functionality.	8 years ago
Martin Atkins	43598f7553	config/hcl2shim: don't put nils in ConfigValue maps ... Absent values are omitted by the old code we are emulating in HCL, so we must do the same here in order to avoid breaking assumptions in the helper/schema layer.	8 years ago
James Bardin	7b5efad725	update missing alias message ... Update the old error message for a missing provider alias, as we no longer automatically inherit providers.	8 years ago
James Bardin	15dc75720e	don't re-use a TempDir path ... Rather than creating and immediately removing a temp directory to get a random path name, fetch files into a subdirectory.	8 years ago
Martin Atkins	5b08fd4f9f	config: Don't expose go implementation details in Resource.Count ... Previously we would return the raw error from strconv.ParseInt, which includes details in its text that expose implementation details and are thus not helpful to the user. Instead, we use a locally-defined error message that talks only about what the caller is expected to know: that count should be parsable as an integer.	8 years ago
Masayuki Morita	e873af9337	Fix panic with substr interpolation function by invalid offset ... Fixes #17041	9 years ago
Pierre-Alain TORET	128f4d19e1	config: Allow build on DragonFlyBSD ... DragonFlyBSD is not officially supported, but allowing it to work is straightforward at the moment so we'll allow it for now.	9 years ago
James Bardin	cf4995d8a7	use the full module name with host for errors ... The module related logs and errors should reference the full module name including the source host.	9 years ago
Rob Campbell	5daeee5f6d	Update various files for new version of "stringer" ... The latest version of stringer now uses strconv instead of fmt.	9 years ago
Martin Atkins	87e1fb4d66	config: a nicer error message for invalid provider constraints ... Previously our error message here was confusing and redundant: Error starting operation: provider.null: invalid version constraint "not valid": Malformed constraint: not valid Instead, we'll generate a full HCL2 diagnostic here, which results in something (subjectively) nicer: Error: Invalid provider version constraint The value "@ 1.0.0" given for provider.null is not a valid version constraint. At the moment this message is an outlier in that the other validation errors are all still just plain Go errors, but over time we'll want to adjust all of these to be full diagnostics so that we can embed source range information in them to help the user find the offending configuration.	9 years ago
James Bardin	e0b2c64645	accessing count directly in an output should is OK ... There should be no warning when accessing a resource's count value directly in an output.	9 years ago
James Bardin	0e7dab09e6	Use the new registry.Client ... The registry code has been moved into the new registry package. Remove the duplicated code and use the new registry and registry/test packages.	9 years ago
Paul Banks	06f067b4e6	Update registry API docs with browse and search (#16846) ... * Verify discovery works without trailing slash on discovery URL * Update registry API docs with browse and search endpoints * Add sample request/responses * Add comment to test to indicate expecations * Fix typo * Remove trailing slash weirdness	9 years ago
David Meyer	fe0cc3b0db	config: new "rsadecrypt" interpolation function ... The primary use-case is to decrypt windows passwords obtained from AWS, but this function is generic and may find other purposes too.	9 years ago
mizuno	01c1142589	config: new "timeadd" interpolation function	9 years ago
James Bardin	048af6e237	Add test fixture to check for warnings	9 years ago
Martin Atkins	cc5e480378	config: detect and warn about access to "counted" attributes ... A common pattern is to conditionally assign to "count" in a resource in order to decide dynamically whether it should be created. In that situation it's necessary to refer to attributes of the resource using the splat syntax, but historically we didn't show errors in output expressions and so people "got away with" incorrect usage in that context. The intent of this warning is to catch potentially-problematic usage of attributes on such resources even if the count happens to be currently set dynamically to 1, which would not generate the error. Then the user can quickly locate and fix the incorrect usage regardless of the current value.	9 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	8091bd627d	move Svchost method to regsrc.Module ... The level of abstraction that needs the "svchost" is the Module, not the FriendlyHost. Us the new method in the module package for registry interaction.	9 years ago
James Bardin	bd576d780a	failing test for module not found error ... The "not found" error should use the raw string directly from the config source, but the existing method was adding the default registry if there was no host indicated.	9 years ago
James Bardin	8619f566bb	validate providers passed to a module exist ... This validation was lost in the migration of inheritance back to core. Make sure a module configuraton doesn't specifiy a provider that doesn't exist.	9 years ago
James Bardin	b79adeae02	save resolved providers for resources to state ... Use the ResourceState.Provider field to store the full name of the provider used during apply. This field is only used when a resource is removed from the config, and will allow that resource to be removed by the exact same provider with which it was created. Modify the locations which might accept the alue of the ResourceState.Provider field to detect that the name is resolved.	9 years ago
James Bardin	b15258dfec	remove provider inheritance from Tree.Load ... Now that resources can be connected to providers with different paths in the core graph, handling the inheritance in config makes less sense. Removing this to make room for core to walk the Tree and connect resources directly to the proper provider instance.	9 years ago
James Bardin	57470f6bf5	remove ProviderConfig Path and Inherited fields ... maving all inheritance into core	9 years ago
James Bardin	3297f60d03	remove raw print statements	9 years ago
James Bardin	2ed529f81a	update from review ... Reference modules by terraform address Unquote versions	9 years ago
James Bardin	c510473fd2	remove code added by stale vim buffer	9 years ago
James Bardin	1bf64ec788	add "Updating" output and fix output tests	9 years ago
James Bardin	9c334fe012	update init output ... Change "Downloading" to 'Initializing" to match the provider loading dialog. List each module being loaded. If a regisry module is being downloaded, list the registry host, and the version discovered. Show the source string from the config that is being fetched, rather than the go-getter url. The full source can be found in the logs for debugging. Add much more extensive logging	9 years ago
James Bardin	b4e9240679	remove implicit provier tests from config/module ... No longer needed	9 years ago
James Bardin	838ffafc18	stop adding implicit provider configs ... Now that providers in the graph can adopt resources without an explicit provider, there's no need to add the implicit configs to the module.Tree when loading.	9 years ago
Martin Atkins	505683dcd3	config/module: produce explicit error for non-registry hosts ... If registry API discovery fails for a particular host then it's better to generate an explicit error message for that early -- so we can tell the user exactly what happened -- rather than assuming a default path and then failing downstream when we get a 404 from that request.	9 years ago
Martin Atkins	288f7c00e4	config/module: allow registry download sources to be relative paths ... It's not always easy or convenient for a web application to determine its own absolute URL to return, so here we pragmatically allow the download source string from a registry to be a path relative to the download endpoint. Since X-Terraform-Get is a go-getter string, not all valid values are valid URLs and so we sniff for certain relative-path-looking prefixes in order to decide whether to apply the relative lookup transform.	9 years ago
James Bardin	eef2129f1a	Storage.GetModule ... Add GetModule for the cli to initialize from a regisry module source. Storage.GetModule fetches a module using the same detection and discovery as used by the normal module loading. The final copy is still done by module.GetCopy to remove vcs files.	9 years ago
James Bardin	ac68f9a16b	make testCredentials token obviously fake	9 years ago