22285 Commits (cc1bf23fee706113fbdf2129be37dd772a2e1ef2)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Atkins	cc1bf23fee	plans/objchange: Fix handling of unknown in AssertValueCompatible ... We need to check for the known-ness of the prior value before we check for the null-ness of actual, because it's valid for an unknown value to become a null.	8 years ago
Martin Atkins	ab2b705ca3	core: Fix test build for ./plans/planfile ... This was missed in the splitting of "Replace" into "DeleteThenCreate" and "CreateThenDelete".	8 years ago
Martin Atkins	7900ddf54e	core: go fmt context_plan_test.go	8 years ago
Martin Atkins	5ea87e7ecf	core: Fix TestContext2Apply_moduleDestroyOrder ... This test was occasionally failing due to a missing graph edge causing it to be non-deterministic. The graph edge was missing because our standard schema doesn't quite match the config fixture and so the reference checker was not finding the "blah" argument on aws_instance.a. This change also includes an 100ms pause for the b node just to make this potential race more likely to hit the "wrong" ordering when the graph is not complete.	8 years ago
Martin Atkins	7454f48727	tools/loggraphdiff: a simple tool for graph change debugging	8 years ago
Martin Atkins	ff77c1ea01	core: Fix TestContext2Plan_moduleVariableFromSplat ... The weird special-case behaviors of testDiffFn were interfering with the outcome of this test, but we don't actually need any of those special behaviors here so we'll use a very simple PlanResourceChangeFn implementation instead, just letting the built-in merge behavior in core take care of it.	8 years ago
Martin Atkins	eefc948b52	core: A "go fmt" catchup ... Since we started using experimental Go Modules our editor tooling hasn't been fully functional, apparently including format-on-save support. This is a catchup to get everything back straight again.	8 years ago
Martin Atkins	0fd3506481	core: Fix TestRefreshGraphBuilder_configOrphans ... We now include explicit separate nodes in the graph for deposed instances, whereas before we just dealt with them inside the main nodes.	8 years ago
Martin Atkins	fa1f065882	core: Re-instate the ignore_changes processing tests	8 years ago
Martin Atkins	2418d772da	core: Fix TestContext2Apply_moduleOrphanGrandchildProvider ... One of the assumptions this test was checking no longer holds: we don't retain outputs for non-root modules in persistent state, because we can always re-populate these on a future run by evaluating the configuration.	8 years ago
Martin Atkins	c76bec4f52	core: Fix TestContext2Apply_moduleOrphanProvider ... We now always expect to find a provider configuration in state. If not, we assume a module-local one, which is not what this test was trying to test.	8 years ago
Martin Atkins	51acec9334	core: Fix TestContext2Apply_moduleOrphanInheritAlias ... The old-fashioned formatting of "Provider" on the shimmed state here was causing the state upgrade code to treat it like a module-relative address, rather than an absolute address as we now expect.	8 years ago
Martin Atkins	f88995682b	core: Better error message for prematurely-removed provider config ... This error message appears in a situation that is often confusing for users, since the connection between resources and their providers in the state is not something we draw attention to in the user experience of Terraform. This new error message tries to be a bit clearer about what the user must do to resolve it. It's still not perfect since it doesn't cover the variant of this problem where an entire module containing a provider block and resources has been removed at the same time, but since there isn't an easily-summarizable way to continue in that state this will need to do for the moment, until we find a way to file off that rough edge in the workflow.	8 years ago
Martin Atkins	3b1e629f1d	core: Don't show full provider configuration block in the logs ... Configuration blocks can contain sensitive information, so better to just talk about them by reference (in this case, source location) rather than embedding them directly, to reduce the risk of accidental information leakage through sharing logs for debug purposes.	8 years ago
Martin Atkins	991e8c6f80	core: Fix TestEvalWriteStateDeposed ... This was already updated for the new state types earlier, but since then we adjusted how deposed instances are written out in the old string representation of state, and so this regressed.	8 years ago
Martin Atkins	61f3abdeae	core: Fix two TestContext2Input_... tests ... These both just were missing some computed attributes from their schema, which was causing them to not appear in the rendered state output.	8 years ago
Martin Atkins	7ab86c26a1	core: Fix various state-pruning-related test failures ... These tests show that we're still not fully pruning modules from the state in all cases, due to us not being able to fully prune out modules that contain resources with count set after a destroy, but this is no worse than before so we'll accept it for now and address this separately later. A module heading without "<no state>" but also without any instances listed is the rendering for a module containing a resource that has no instances, since our old string rendering of state doesn't represent resources themselves.	8 years ago
Martin Atkins	a4df296073	core: Fix TestContext2Apply_destroyModuleWithAttrsReferencingResource ... Now that we're properly pruning orphaned resources and empty modules from the state, our expected output is a little different.	8 years ago
Martin Atkins	c46f5bcc21	core: Clean up resource states when they are orphaned ... We previously had mechanisms to clean up only individual instance states, leaving behind empty resource husks in the state after they were all destroyed. This takes care of it in the "orphan" case. It does not yet do it in the "terraform destroy" or "terraform plan -destroy" cases because we don't have anywhere to record in the plan that we're actually destroying and so the resource configurations should be ignored and _everything_ should be cleaned. We'll let the state be not-quite-empty in that case for now, since it doesn't really hurt; cleaning up orphans is the main case because the state will live on afterwards and so leftover cruft will accumulate over the course of many changes.	8 years ago
Martin Atkins	b37c45d511	core: OrphanResourceTransformer -> OrphanResourceInstanceTransformer ... This transformer creates resource _instance_ nodes rather than resource nodes, so this name is a clearer descriptor for what it does.	8 years ago
Martin Atkins	aa47ac2485	core: Remove unused EvalDiffDestroyModule ... This is no longer needed because the state structure self-prunes when a module becomes empty.	8 years ago
Martin Atkins	6ff44f7123	configload: Don't fail if one module is a child directory of another ... Given a module foo and a module foo/bar, the previous code might incorrectly treat "bar" as a file within "foo" rather than as a module directory in its own right.	8 years ago
Martin Atkins	0b5910f5ff	core: Fix TestContext2Apply_dataDependsOn ... The value returned from ReadDataSourceFn must conform to the schema for the data source.	8 years ago
Kristin Laemmert	927eec5a82	Merge pull request #18954 from hashicorp/mildwonkey/backend-tests ... backend/local: fix panic in tests	8 years ago
Kristin Laemmert	760d342cb5	backend/local: fix panic in tests ... update the function names in testDelegateBackend to match what was being called in TestLocal_multiStateBackend (matching the test behavior in master)	8 years ago
Martin Atkins	119bc97eab	core: Fix TestContext2Apply_multiDepose_createBeforeDestroy ... Since this one has a situation where there are two deposed objects for the same instance at once, we can't rely on comparing state strings: they are not deterministic when multiple deposed objects are present. Instead, we do more surgical comparisons directly on the state model objects, which is not quite as robust but still gets us the main stuff we care about here, to be followed up by another checkStateString further down for the final state.	8 years ago
Martin Atkins	c67b11ecc3	core: Fix TestContext2Apply_targetedWithTaintedInState ... Tainted objects now also remember which provider they belong to (via the resource state they are attached to) and so the stringified state output here is slightly different.	8 years ago
Martin Atkins	1043688410	core: Fix TestContext2Apply_provisionerInterpCount ... This was relying on a no-longer-valid mechanism for accessing the "count" value from a resource block. The original issue this test was written to cover is not really such a sharp edge anymore, since the length is taken from the state during apply rather than from configuration, but it's still a good case to cover.	8 years ago
Martin Atkins	0785c2ef5a	core: Fix TestContext2Apply_issue7824 ... This test was incorrectly amended on the first pass to create a configuration snapshot from the step zero configuration, rather than the step one configuration that the save plan is built from. Along with that, it needed various other minor updates to match with details that have shifted: - "id" and "type" attributes must be explicitly declared in schema - template_file.parent has count = 1, which now causes it to get an index and be a list where before it did not.	8 years ago
Martin Atkins	52b53e368b	core: Always set ProviderAddr on EvalDiffDestroy ... If we don't set it, we end up creating an invalid plan where the destroy changes don't have a provider address set, which then later fails decoding when round-tripped through a planfile. This also includes some extra safety checks in EvalDiff and EvalDiffDestroy so that we can catch this bug sooner in future. This change is verified by TestContext2Apply_plannedDestroyInterpolatedCount, which is now passing.	8 years ago
Martin Atkins	e1b8912735	core: test helper contextOptsForPlanViaFile to set default backend ... A plan file without a backend set is not valid, but at the level we're testing in this package we don't really care about backends so we'll just set a default one if the caller doesn't set something more specific, and then we'll just ignore it completely when reading back.	8 years ago
Martin Atkins	a3b7748437	plans/planfile: allow resource instances with no instance key ... This happens for resources that don't have either "count" or "for_each" set.	8 years ago
Martin Atkins	64d0aa08ba	core: Skip ignore_changes handling for create actions ... It doesn't make sense to ignore_changes when the prior value is null, since we have to create something before we can ignore changes to it. This change is verified by TestContext2Apply_ignoreChangesWildcard.	8 years ago
Martin Atkins	f8ebb243f9	core: Fix TestContext2Apply_destroyProvisionerWithMultipleLocals ... This test was relying on the feature of the old provisioner API that gave provisioners full access to the instance state of what they were provisioning. We no longer do this, and so instead the ApplyFn must distingish the instances using a value from the provisioner's own configuration.	8 years ago
Martin Atkins	106830005f	core: Allow planned Update change to become NoOp during apply ... This can happen if unknown values in the plan actually end up being identical to the prior values once resolved. In that case, we'll just make no change at all. This is verified by TestContext2Apply_ignoreChangesWithDep.	8 years ago
Martin Atkins	d062536427	core: Fix TestContext2Apply_destroyDeeplyNestedModule ... The new state.String() has slightly different output for an empty state, so we'll test that it's empty in a more direct way.	8 years ago
Martin Atkins	2ce38092a6	core: Fix TestContext2Apply_Provisioner_compute ... Due to a quirk in how testDiffFn constructs its diff, compute doesn't actually get included in the final result anymore under the new shims. This result is still correct, nonetheless.	8 years ago
Martin Atkins	60403c07ad	core: Fix TestContext2Apply_outputOrphanModule ... The new state.String is not quite identical to the old, so we'll assert an empty state in a more direct way.	8 years ago
Martin Atkins	ce19c7f5e6	core: Fix TestContext2Apply_outputOrphanModule ... This is caused just be a slight difference in the new implementation of stringifying state.	8 years ago
Martin Atkins	7bc4078807	core: Fix TestContext2Apply_countTainted ... The prior behavior being asserted by this test was incorrect, since the configuration calls for there to be two instances of the resource at the end. We also now assert on the generated plan since it's important to verify that we are indeed planning to replace the zeroth instance but not the first instance (which doesn't yet exist).	8 years ago
Martin Atkins	799b49d7c8	plans: Regenerate Action.String for new action values ... This was missed on the initial update of these because at the time the package wasn't generate-able due to other problems.	8 years ago
Martin Atkins	ad5301454f	core: Fix TestContext2Apply_countDecreaseToOneCorrupted ... We now include attribute changes in destroy diffs, so the expected output of this test includes these changes. Also includes a fix to legacyDiffComparisonString to actually sort the attribute changes by name in the rendered diff.	8 years ago
Martin Atkins	44048f6e86	core: Fix TestContext2Apply_compute ... The testDiffFn doesn't include "compute" in the diff it produces and so it no longer appears in the shimmed output. This is just a quirk of this weird mock implementation; real providers always copy all of the values from thec config into the diff before adding in any other changes.	8 years ago
Martin Atkins	c5fb427b16	core: Fix TestContext2Apply_cancelProvisioner ... This test now requires a provisioner schema for correct operation.	8 years ago
Martin Atkins	3cfedcad20	core: MockProvider and MockProvisioner can't lock in Stop ... The only reasonable usage of these methods is for them to run concurrently with other methods, so we mustn't hold a lock to do this work. For tests that deal with stopping, it's the test's own responsibility to deal with any concurrency issues that arise from their StopFns running concurrently with other mock functions.	8 years ago
Martin Atkins	ee0320917f	core: Additional logging for Context.Stop ... Since stopping is a rather complex mechanism that relies on correct handling of concurrency, it's handy to have these logs here to debug when things don't happen in quite the right order.	8 years ago
James Bardin	c687963ac7	CBD transformer test update ... Comment out an out of date CBD test. The test no longer works due to the CBD status being checked during plan, but the test case may still have some value which we can review later. update the text in the CBD transformer to reflect the s/ancestor/descendent/ change.	8 years ago
Martin Atkins	2134ec40e8	vendor: Update HCL2 and cty, and other related packages ... This brings in a bugfix for analyzing variables inside relative traversal expressions in HCL, and a cosmetic bugfix in cty for GoString of cty.NullVal(cty.DynamicPseudoType). This also updates some other packages, as a result of running "go get -u".	8 years ago
Kristin Laemmert	cb7954e598	Merge pull request #18938 from hashicorp/mildwonkey/export-schemas-fields ... terraform.Schemas: export struct fields	8 years ago
Kristin Laemmert	625c82be55	terraform.Schemas: export struct fields ... There does not appear to be any real reason that these Schemas fields are not exported, and exporting them makes it possible to directly construct Schemas for tests without pulling in an entire context.	8 years ago