terraform

Commit Graph

Author	SHA1	Message	Date
James Nugent	cb8a0549e1	Merge pull request #5757 from hashicorp/f-output-testing Add TestCheckOutput helper to resource testing	10 years ago
James Nugent	35f9d2e081	Add TestCheckOutput helper to resource testing This allows outputs in test configuration to have test functions written conveniently. Useful for azurerm_template_deployment.	10 years ago
Radek Simko	bf9f5879ca	helper/resource: Remove NotFoundError function	10 years ago
James Nugent	f946695187	Merge pull request #5444 from TimeIncOSS/f-aws-logs-metric-filter provider/aws: Add support for CloudWatch Log Metric Filter	10 years ago
Paul Hinze	c3e27b3e0a	provider/test: a test provider Here we also introduce a `test` provider meant as an aid to exposing via automated tests issues involving interactions between `helper/schema` and Terraform core. This has been helpful so far in diagnosing `ignore_changes` problems, and I imagine it will be helpful in other contexts as well. We'll have to be careful to prevent the `test` provider from becoming a dumping ground for poorly specified tests that have a clear home elsewhere. But for bug exposure I think it's useful to have.	10 years ago
Radek Simko	fd2fcaf1d5	helper/resource: Implement resource-wide NotFoundError	10 years ago
Radek Simko	034287fdc2	helper/resource: Error shouldn't be returned in case of success	10 years ago
Radek Simko	8582f4df9f	helper/resource: Fix TestRetry	10 years ago
Paul Hinze	108ccf0007	builtin: Refactor resource.Retry to clarify return Change the `RetryFunc` from a plain `error` return type to a specialized `RetryError` which must decide whether it is retryable or not. Add `RetryableError` / `NonRetryableError` factory functions that callers are meant to use to build up these errors. This makes it eminently clear whether or not a given error is retryable from inside the client code. Goal here is to _not_ change any behavior, simply reflect the existing behavior with the new, clearer, API.	10 years ago
Paul Hinze	5160578e18	helper/resource: restore retval of resource.Retry on timeout In #4700 while fixing a data race I made an incorrect assumption about the return value of StateChangeConf, and ended up changing the behavior in the timeout case to always return: > timeout while waiting for state to become '[success]' When it used to capture the "most recent error" from the function itself. It's much more useful to see that error bubbling up, so here we revert to pulling it out of the function as we did before, and we protect against the data race with a good old fashioned mutex.	10 years ago
Paul Hinze	bba8a79a52	acctests: log a line w/ the non-empty plan Helpful when iterating on a drift test. Eventually I think this assertion could be fanned out to something much more targeted like: ExpectAttributeDiff(resource, attr, oldval, newval) But this is a step in the right direction.	10 years ago
Radek Simko	ab73f2b762	helper: Add StateChangeConf.ContinuousTargetOccurence (int)	10 years ago
Paul Hinze	24048b4dca	providers: Mention check number when acctest fails	10 years ago
Ian Duffy	47ac10d66b	Change resource.StateChangeConf to use an array for target states Signed-off-by: Ian Duffy <ian@ianduffy.ie>	10 years ago
Paul Hinze	d59db52f06	helper/resource: Fix data race in resource.Retry The implementation was attempting to capture the error using a scoped variable reference, but the error value is already exposed via the return value of `WaitForState()`. Using that instead fixes the data race. Fixes the following data race: ``` ================== WARNING: DATA RACE Read by goroutine 74: github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:35 +0x284 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc Previous write by goroutine 90: github.com/hashicorp/terraform/helper/resource.Retry.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:20 +0x87 github.com/hashicorp/terraform/helper/resource.(StateChangeConf).WaitForState.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:83 +0x284 Goroutine 74 (running) created at: testing.RunTests() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:561 +0xaa3 testing.(M).Run() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:494 +0xe4 main.main() github.com/hashicorp/terraform/helper/resource/_test/_testmain.go:84 +0x20f Goroutine 90 (running) created at: github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:127 +0x283 github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:34 +0x276 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc ================== ```	10 years ago
Paul Hinze	a8d2ad3ebe	refactor s3 bucket test to expect non-empty plan pushing to master but paging @catsby for post-hoc review	10 years ago
James Nugent	e976d6e787	testing: Use a copy of pre-destroy state in destroy check In the acceptance testing framework, it is neccessary to provide a copy of the state _before_ the destroy is applied to the check in order that it can loop over resources to verify their destruction. This patch makes a deep copy of the state prior to applying test steps which have the Destroy option set and then passes that to the destroy check.	11 years ago
Paul Hinze	4bd4e18def	core: use same logging setup for acctests We weren't doing any log setup for acceptance tests, which made it difficult to wrangle log output in CI. This moves the log setup functions we use in `main` over into a helper package so we can use them for acceptance tests as well. This means that acceptance tests will by default be a _lot_ quieter, only printing out actual test output. Setting `TF_LOG=trace` will restore the full prior noise level. Only minor behavior change is to make `ioutil.Discard` the default return value rather than a `nil` that needs to be checked for.	11 years ago
Mitchell Hashimoto	344e7c26b5	fix a bunch of tests from go-getter import	11 years ago
Clint	f979fd7dee	Merge pull request #2571 from TimeIncOSS/f-aws-autogenerated-elb-name provider/aws: Allow ELB name to be generated	11 years ago
Radek Simko	9882cc59d8	aws: Add regression test for renaming ecs_cluster	11 years ago
Radek Simko	70b7243dd6	helper: Add resource.PrefixedUniqueId	11 years ago
Paul Hinze	385b17d679	provider/template: don't error when rendering fails in Exists The Exists function can run in a context where the contents of the template have changed, but it uses the old set of variables from the state. This means that when the set of variables changes, rendering will fail in Exists. This was returning an error, but really it just needs to be treated as a scenario where the template needs re-rendering. fixes #2344 and possibly a few other template issues floating around	11 years ago
Paul Hinze	a96a3372c6	provider/template: don't diff when there's no diff This reworks the template lifecycle a bit such that we get nicer diff behavior. First, we tick ForceNew on for both filename and vars, so that the diff indicates that the template will be "replaced" on change. This is mostly cosmetic, but it also tracks conceptually with the fact that the identifier we use is a hash of the contents, so any change essentially makes a "new resource". Second, we change the Exists implementation to only return `false` when there has been a change in the rendered template. This lets descendent resources see the computed value changing so that they'll properly trigger in the plan. Fixes #1898 Refs #1866 (but does not fix, there's another deeper issue there)	11 years ago
Paul Hinze	fbce3a3caa	helper/resource: don't fail test on config warnings AccTests like TestAccComputeInstance_basic_deprecated_network were failing early on "invalid config" when we are explictly testing behavior that we know generates warnings.	11 years ago
Josh Bleecher Snyder	76bcac3031	providers/template: add tests, address review comments Do directory expansion on filenames. Add basic acceptance tests. Code coverage is 72.5%. Uncovered code is uninteresting and/or impossible error cases. Note that this required adding a knob to helper/resource.TestStep to allow transient resources.	11 years ago
Paul Hinze	88744d569f	helper/resource/testing: unit tests to cover #1770 Also clarified that final return value of testStep is now only for the happy path.	11 years ago
Paul Hinze	dbf6d1bd00	helper/resource: fix accidentaly swallowing of acctest step errors With #1757 I unwittingly reused an err variable, causing all test check errors to be swallowed. -_-	11 years ago
Paul Hinze	149e52ad1f	helper/resource: verify refresh+plan after each step I forgot to add `Computed: true` when I made the "key_name" field optional in #1751. This made the behavior: * Name generated in Create and set as ID * Follow up plan (without refresh) was nice and empty * During refresh, name gets cleared out on Read, causing a bad diff on subsequent plans We can automatically catch bugs like this if we add yet another verification step to our resource acceptance tests -> a post Refresh+Plan that we verify is empty. I left the non-refresh Plan verification in, because it's important that _both_ of these are empty after an Apply.	11 years ago
Phil Frost	bd8ac4fe5e	Better document StateChangeConf.WaitForState	11 years ago
Paul Hinze	92ebb60293	helper/resource: ok let's actually use RFC4122	11 years ago
Paul Hinze	d1106e9e22	helper/resource: add UniqueId() helper A generic function for provider resources to use to get a unique identifier.	11 years ago
Mitchell Hashimoto	dc69603cd4	helper/resource: docs	11 years ago
Matt Good	21b0a03d70	Support for multiple providers of the same type Adds an "alias" field to the provider which allows creating multiple instances of a provider under different names. This provides support for configurations such as multiple AWS providers for different regions. In each resource, the provider can be set with the "provider" field. (thanks to Cisco Cloud for their support)	11 years ago
Paul Hinze	7fe34d4547	providers: check for empty plan after each test step Each acceptance test step plays a Refresh, Plan, Apply for a given config. This adds a follow up Plan and fails the test if it does not come back empty. This will catch issues with perpetual, unresolvable diffs that crop up here and there. This is going to cause a lot of our existing acceptance tests to fail - too many to roll into a single PR. I think the best plan is to land this in master and then fix the failures (each of which should be catching a legitimate provider bug) one by one until we get the provider suites back to green.	11 years ago
Paul Hinze	97acccd3ed	core: targeted operations Add `-target=resource` flag to core operations, allowing users to target specific resources in their infrastructure. When `-target` is used, the operation will only apply to that resource and its dependencies. The calculated dependencies are different depending on whether we're running a normal operation or a `terraform destroy`. Generally, "dependencies" refers to ancestors: resources falling _before_ the target in the graph, because their changes are required to accurately act on the target. For destroys, "dependencies" are descendents: those resources which fall _after_ the target. These resources depend on our target, which is going to be destroyed, so they should also be destroyed.	11 years ago
Jack Pearkes	c180487af6	helper/resource: allow configuration of not found checks in state change	11 years ago
Mitchell Hashimoto	5a64d0900b	providers/aws: test for allowing in-place lC update	11 years ago
Mitchell Hashimoto	b4f8b7f43b	helper/resource: RetryError for quitting quickly	12 years ago
Mitchell Hashimoto	36f225dea0	fmt	12 years ago
Mitchell Hashimoto	ef62fa80db	helper/resource: add Retry function	12 years ago
Mitchell Hashimoto	9ba39d93b7	helper/resource: compile	12 years ago
Mitchell Hashimoto	9b2b3a963f	ResourceDiff => InstanceDiff	12 years ago
Mitchell Hashimoto	0bcbccf046	helper/resource: compiles, fails because Context doesn't work, probably	12 years ago
Alex Gaynor	46154ca1d3	Fixed a ton of typos in docs and comments	12 years ago
Mitchell Hashimoto	d7ecc76148	helper/resource: refactor wait a bit and introduce delay/mintimeout	12 years ago
Mitchell Hashimoto	f8b974c9aa	helper/resource: never use an interval more than 10 seconds on wait	12 years ago
Mitchell Hashimoto	91ad873113	helper/resource: improve logging and output for tests	12 years ago
Mitchell Hashimoto	dbe5a1254a	helper/resource: better error if config doesn't validate	12 years ago
Mitchell Hashimoto	9ab4a5bf88	helper/resource: exponential backoff	12 years ago

1 2

74 Commits (ba4ec0097a47820db3bd686fdb708eca3b717d74)