5 Commits (94de72c63834acea811c27a585c19eae29374a4b)

Author	SHA1	Message	Date
James Bardin	622c4df14c	remove the use of panicwrap ... Stop using panicwrap, and execute terraform in the main process.	5 years ago
Martin Atkins	383bbdeebc	Upgrade to Go 1.17 ... This includes the addition of the new "//go:build" comment form in addition to the legacy "// +build" notation, as produced by gofmt to ensure consistent behavior between Go versions. The new directives are all equivalent to what was present before, so there's no change in behavior. Go 1.17 continues to use the Unicode 13 tables as in Go 1.16, so this upgrade does not require also upgrading our Unicode-related dependencies. This upgrade includes the following breaking changes which will also appear as breaking changes for Terraform users, but that are consistent with the Terraform v1.0 compatibility promises. - On MacOS, Terraform now requires macOS 10.13 High Sierra or later. This upgrade also includes the following breaking changes which will appear as breaking changes for Terraform users that are inconsistent with our compatibility promises, but have justified exceptions as follows: - cidrsubnet, cidrhost, and cidrnetmask will now reject IPv4 CIDR addresses whose decimal components have leading zeros, where previously they would just silently ignore those leading zeros. This is a security-motivated exception to our compatibility promises, because some external systems interpret zero-prefixed octets as octal numbers rather than decimal, and thus the previous lenient parsing could lead to a different interpretation of the address between systems, and thus potentially allow bypassing policy when configuring firewall rules etc. This upgrade also includes the following breaking changes which could _potentially_ appear as breaking changes for Terraform users, but that do not in practice for the reasons given: - The Go net/url package no longer allows query strings with pairs separated by semicolons instead of ampersands. This primarily affects HTTP servers written in Go, and Terraform includes a special temporary HTTP server as part of its implementation of OAuth for "terraform login", but that server only needs to accept URLs created by Terraform itself and Terraform does not generate any URLs that would be rejected.	5 years ago
Martin Atkins	f91a3b87c1	terminal: Helpers for doing fmt-ish operations on the streams ... It's pretty common to want to apply the various fmt.Fprint... functions to our two output streams, and so to make that much less noisy at the callsite here we have a small number of very thin wrappers around the underlying fmt package functionality. Although we're aiming to not have too much abstraction in this "terminal" package, this seems justified in that it is only a very thin wrapper around functionality that most Go programmers are already familiar with, and so the risk of this causing any surprises is low and the improvement to readability of callers seems worth it.	5 years ago
Martin Atkins	ffba8064ed	terminal: StreamsForTesting helper ... This is to allow convenient testing of functions that are designed to work directly with *terminal.Streams or the individual stream objects inside. Because the InputStream and OutputStream APIs expose directly an *os.File, this does some extra work to set up OS-level pipes so we can capture the output into local buffers to make test assertions against. The idea here is to keep the tricky stuff we need for testing confined to the test codepaths, so that the "real" codepaths don't end up needing to work around abstractions that are otherwise unnecessary.	5 years ago
Martin Atkins	17728c8fe8	internal/terminal: Interrogate and initialize the terminal, if any ... This is a helper package that creates a very thin abstraction over terminal setup, with the main goal being to deal with all of the extra setup we need to do in order to get a UTF-8-supporting virtual terminal on a Windows system.	5 years ago