Upgrade to Go 1.17

This includes the addition of the new "//go:build" comment form in addition
to the legacy "// +build" notation, as produced by gofmt to ensure
consistent behavior between Go versions. The new directives are all
equivalent to what was present before, so there's no change in behavior.

Go 1.17 continues to use the Unicode 13 tables as in Go 1.16, so this
upgrade does not require also upgrading our Unicode-related dependencies.

This upgrade includes the following breaking changes which will also
appear as breaking changes for Terraform users, but that are consistent
with the Terraform v1.0 compatibility promises.

- On MacOS, Terraform now requires macOS 10.13 High Sierra or later.

This upgrade also includes the following breaking changes which will
appear as breaking changes for Terraform users that are inconsistent with
our compatibility promises, but have justified exceptions as follows:

- cidrsubnet, cidrhost, and cidrnetmask will now reject IPv4 CIDR
  addresses whose decimal components have leading zeros, where previously
  they would just silently ignore those leading zeros.

  This is a security-motivated exception to our compatibility promises,
  because some external systems interpret zero-prefixed octets as octal
  numbers rather than decimal, and thus the previous lenient parsing could
  lead to a different interpretation of the address between systems, and
  thus potentially allow bypassing policy when configuring firewall rules
  etc.

This upgrade also includes the following breaking changes which could
_potentially_ appear as breaking changes for Terraform users, but that do
not in practice for the reasons given:

- The Go net/url package no longer allows query strings with pairs
  separated by semicolons instead of ampersands. This primarily affects
  HTTP servers written in Go, and Terraform includes a special temporary
  HTTP server as part of its implementation of OAuth for "terraform login",
  but that server only needs to accept URLs created by Terraform itself
  and Terraform does not generate any URLs that would be rejected.

.circleci/config.yml

@@ -10,7 +10,7 @@ references:
 executors:
   go:
     docker:
-      - image: docker.mirror.hashicorp.services/cimg/go:1.16
+      - image: docker.mirror.hashicorp.services/cimg/go:1.17
     environment:
       CONSUL_VERSION: 1.7.2
       GOMAXPROCS: 4

.go-version

@@ -1 +1 @@
-1.16.4
+1.17.0

internal/command/cliconfig/config_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package cliconfig

internal/command/cliconfig/config_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package cliconfig

internal/command/clistate/local_state_lock_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package clistate

internal/command/clistate/local_state_lock_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package clistate

internal/command/console_interactive.go

@@ -1,3 +1,4 @@
+//go:build !solaris
 // +build !solaris
 
 // The readline library we use doesn't currently support solaris so

internal/command/console_interactive_solaris.go

@@ -1,3 +1,4 @@
+//go:build solaris
 // +build solaris
 
 package command

internal/command/testdata/login-oauth-server/main.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // This file is a helper for those doing _manual_ testing of "terraform login"

internal/communicator/ssh/communicator_test.go

@@ -1,3 +1,4 @@
+//go:build !race
 // +build !race
 
 package ssh

internal/configs/configload/inode.go

@@ -1,3 +1,4 @@
+//go:build linux || darwin || openbsd || netbsd || solaris || dragonfly
 // +build linux darwin openbsd netbsd solaris dragonfly
 
 package configload

internal/configs/configload/inode_freebsd.go

@@ -1,3 +1,4 @@
+//go:build freebsd
 // +build freebsd
 
 package configload

internal/configs/configload/inode_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package configload

internal/helper/wrappedreadline/wrappedreadline_unix.go

@@ -1,3 +1,4 @@
+//go:build darwin || dragonfly || freebsd || (linux && !appengine) || netbsd || openbsd
 // +build darwin dragonfly freebsd linux,!appengine netbsd openbsd
 
 package wrappedreadline

internal/helper/wrappedreadline/wrappedreadline_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package wrappedreadline

internal/helper/wrappedstreams/streams_other.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package wrappedstreams

internal/helper/wrappedstreams/streams_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package wrappedstreams

internal/replacefile/replacefile_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package replacefile

internal/replacefile/replacefile_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package replacefile

internal/states/statemgr/filesystem_lock_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package statemgr

internal/states/statemgr/filesystem_lock_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package statemgr

internal/terminal/impl_others.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package terminal

internal/terminal/impl_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package terminal

signal_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 package main

signal_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package main

tools/tools.go

@@ -1,3 +1,4 @@
+//go:build tools
 // +build tools
 
 package tools