17 Commits (6440c839474f052d8997bb5cec19c2743e5108e6)

Author	SHA1	Message	Date
Chase	02ff60d083	Fixing small typo in resource/wait.go	8 years ago
James Bardin	074be9ae56	Another race in resource.Retry	10 years ago
David Tolnay	7e1cd34819	Timing out is not success	10 years ago
Radek Simko	034287fdc2	helper/resource: Error shouldn't be returned in case of success	10 years ago
Paul Hinze	108ccf0007	builtin: Refactor resource.Retry to clarify return ... Change the `RetryFunc` from a plain `error` return type to a specialized `RetryError` which must decide whether it is retryable or not. Add `RetryableError` / `NonRetryableError` factory functions that callers are meant to use to build up these errors. This makes it eminently clear whether or not a given error is retryable from inside the client code. Goal here is to _not_ change any behavior, simply reflect the existing behavior with the new, clearer, API.	10 years ago
Paul Hinze	5160578e18	helper/resource: restore retval of resource.Retry on timeout ... In #4700 while fixing a data race I made an incorrect assumption about the return value of StateChangeConf, and ended up changing the behavior in the timeout case to always return: > timeout while waiting for state to become '[success]' When it used to capture the "most recent error" from the function itself. It's much more useful to see that error bubbling up, so here we revert to pulling it out of the function as we did before, and we protect against the data race with a good old fashioned mutex.	10 years ago
Ian Duffy	47ac10d66b	Change resource.StateChangeConf to use an array for target states ... Signed-off-by: Ian Duffy <ian@ianduffy.ie>	10 years ago
Paul Hinze	d59db52f06	helper/resource: Fix data race in resource.Retry ... The implementation was attempting to capture the error using a scoped variable reference, but the error value is already exposed via the return value of `WaitForState()`. Using that instead fixes the data race. Fixes the following data race: ``` ================== WARNING: DATA RACE Read by goroutine 74: github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:35 +0x284 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc Previous write by goroutine 90: github.com/hashicorp/terraform/helper/resource.Retry.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:20 +0x87 github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState.func1() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:83 +0x284 Goroutine 74 (running) created at: testing.RunTests() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:561 +0xaa3 testing.(*M).Run() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:494 +0xe4 main.main() github.com/hashicorp/terraform/helper/resource/_test/_testmain.go:84 +0x20f Goroutine 90 (running) created at: github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/state.go:127 +0x283 github.com/hashicorp/terraform/helper/resource.Retry() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait.go:34 +0x276 github.com/hashicorp/terraform/helper/resource.TestRetry_timeout() /Users/phinze/go/src/github.com/hashicorp/terraform/helper/resource/wait_test.go:35 +0x60 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc ================== ```	10 years ago
Mitchell Hashimoto	b4f8b7f43b	helper/resource: RetryError for quitting quickly	12 years ago
Mitchell Hashimoto	ef62fa80db	helper/resource: add Retry function	12 years ago
Alex Gaynor	46154ca1d3	Fixed a ton of typos in docs and comments	12 years ago
Mitchell Hashimoto	d7ecc76148	helper/resource: refactor wait a bit and introduce delay/mintimeout	12 years ago
Mitchell Hashimoto	f8b974c9aa	helper/resource: never use an interval more than 10 seconds on wait	12 years ago
Mitchell Hashimoto	9ab4a5bf88	helper/resource: exponential backoff	12 years ago
Mitchell Hashimoto	fa3e9fab42	helper/resource: wait 2 seconds between each	12 years ago
Mitchell Hashimoto	1c725896ca	helper/resource: support waiting on absense of thing	12 years ago
Jack Pearkes	eb7c8c07c8	helpers/resource: add wait helper	12 years ago