terraform

Commit Graph

Author	SHA1	Message	Date
James Bardin	268959f4be	make UpEdges and DownEdges return a copy The public functions for the graph UpEdges and DownEdges is returning the internal Set from the graph, meaning that callers could inadvertently corrupt the graph structure by editing the returned Sets. Make UpEdges and DownEdges return a copy of the set, while retaining the efficient no-copy behavior for internal callers.	6 years ago
James Bardin	0c1ab6142b	remove debug code Remove the abandoned graph debugger	6 years ago
James Bardin	6096371068	remove all unneeded list-based iteration Make the default walks always use the sets directly, which avoids repeated copying of every set into a new slice.	6 years ago
James Bardin	26a4de803f	remove uses of Set.List Since the set can be iterated over directly, we no longer need to copy the values into a new slice.	6 years ago
James Bardin	32ae3b5452	make dag.Set a simple map This allows iteration directly over the set, removing the need to allocate and copy a new slice for every iteration.	6 years ago
Martin Atkins	2c70d884d6	dag: node visits return diagnostics rather than errors This allows node visits to also return warnings.	8 years ago
James Bardin	8cf0a8ca9c	faster DAG transitive reduction In the case of highly-connected graphs, the TransitiveReduction process was far too computationally intensive. Since no operations are applied to the nodes, and the walk order is not even user visible, we don't need to sort them n^2 times.	9 years ago
Mitchell Hashimoto	6702a22074	dag: require acyclic graph	9 years ago
Mitchell Hashimoto	65752cd51a	dag: improve docs and read access during a lock	9 years ago
Mitchell Hashimoto	72a717f2de	dag: change the type sig of Update to Graph so its external friendly	9 years ago
Mitchell Hashimoto	28fff99ea8	dag: replace dag.Walk with our walker	9 years ago
James Bardin	6d30b60144	Add DebugVisitInfo This encodes vertex debug information into the graph log when a vertex is visited during a walk operation. These can ordered to show how the Graph was walked. Add a mutex to the encoder so it can be used during a parallel walk. Moved string literal constants used for marshaling to pre-defined constants. Did some renaming to make the marshal* structures more consistent.	10 years ago
James Bardin	de0cb17a39	Add Graph.DebugOperation The method marks the start of a set of operations on the Graph, with extra information optionally provided in the second paramter. This returns a function with a single End method to mark the end of the set in the logs. Refactor the existing graph Begin/End Operation calls to use this single method. Remove the *string types in the marshal structs, these are strictly informational and don't need to differentiate empty vs unset strings. Add calls to DebugOperation for each step while building the graph.	10 years ago
James Bardin	82b1a2abc2	Add graph transformation recording The external api provided here is simply dag.Graph.SetDebugWriter(io.Writer). When a writer is provided to a Graph, it will immediately encode itself to the stream, and subsequently encode any additional transformations to the graph. This will allow easier logging of graph transformations without writing complete graphs to the logs at every step. Since the marshalGraph can also be dot encoded, this will allow translation from the JSON logs to dot graphs.	10 years ago
James Bardin	7b774f771b	implement dag.Subgrapher interface This allows the dag package to detect subgraphs, even when impelemnted by types from other packages	10 years ago
Mitchell Hashimoto	83b1c82e93	terraform: put quotes before vertex name to avoid false panicwrap Fixes #9395	10 years ago
Paul Hinze	b45f53eef4	dag: fix ReverseDepthFirstWalk when nodes remove themselves The report in #7378 led us into a deep rabbit hole that turned out to expose a bug in the graph walk implementation being used by the `NoopTransformer`. The problem ended up being when two nodes in a single dependency chain both reported `Noop() -> true` and needed to be removed. This was breaking the walk and preventing the second node from ever being visited. Fixes #7378	10 years ago
Paul Hinze	9cd88810f4	core: log every 5s while waiting for dependencies Helps to flush out deadlocks in the dependency graph	11 years ago
Paul Hinze	baa33d7326	core: dag errors should cascade to all descendents We weren't marking skipped nodes as failing, so any grandchild-and-deeper dependencies would still evaluate. For example: A -> B -> C -> D If B failed, C would be skipped, but D would still be evaluated. This fixes the behavior so C, D, and any further descendents will all be skipped when B fails. Addresses crashing aspect of #2955 and likely a lot of other confusing failure modes.	11 years ago
Paul Hinze	ce49dd6080	core: graph command gets -verbose and -draw-cycles When you specify `-verbose` you'll get the whole graph of operations, which gives a better idea of the operations terraform performs and in what order. The DOT graph is now generated with a small internal library instead of simple string building. This allows us to ensure the graph generation is as consistent as possible, among other benefits. We set `newrank = true` in the graph, which I've found does just as good a job organizing things visually as manually attempting to rank the nodes based on depth. This also fixes `-module-depth`, which was broken post-AST refector. Modules are now expanded into subgraphs with labels and borders. We have yet to regain the plan graphing functionality, so I removed that from the docs for now. Finally, if `-draw-cycles` is added, extra colored edges will be drawn to indicate the path of any cycles detected in the graph. A notable implementation change included here is that {Reverse,}DepthFirstWalk has been made deterministic. (Before it was dependent on `map` ordering.) This turned out to be unnecessary to gain determinism in the final DOT-level implementation, but it seemed a desirable enough of a property that I left it in.	11 years ago
Paul Hinze	97acccd3ed	core: targeted operations Add `-target=resource` flag to core operations, allowing users to target specific resources in their infrastructure. When `-target` is used, the operation will only apply to that resource and its dependencies. The calculated dependencies are different depending on whether we're running a normal operation or a `terraform destroy`. Generally, "dependencies" refers to ancestors: resources falling _before_ the target in the graph, because their changes are required to accurately act on the target. For destroys, "dependencies" are descendents: those resources which fall _after_ the target. These resources depend on our target, which is going to be destroyed, so they should also be destroyed.	11 years ago
Mitchell Hashimoto	865de51816	dag: do a DFS for each vertex	11 years ago
Mitchell Hashimoto	ed2075e384	dag: TransitiveReduction	11 years ago
Mitchell Hashimoto	54fd742ef6	dag: walk should be able to be halted	11 years ago
Mitchell Hashimoto	5b0004ffc7	dag: detect self references, use multierror	11 years ago
Mitchell Hashimoto	e86698c50d	dag: fix walk order issue, scc issues	11 years ago
Mitchell Hashimoto	d59ced3c57	dag: Validate for DAGs	11 years ago
Mitchell Hashimoto	e94c43e0dc	dag: Walk	11 years ago
Mitchell Hashimoto	cfa3d89265	dag: find root of AcyclicGraph	11 years ago
Mitchell Hashimoto	21e4501edb	terraform: start implementing interfaces for semantic checks	11 years ago

30 Commits (6440c839474f052d8997bb5cec19c2743e5108e6)