1755 Commits (4ec80fa18d1a4e6df2fce9f708b8fed6653e1d0b)

Author	SHA1	Message	Date
Alex Chan	4ec80fa18d	Correct the spelling of heirarchy/hierarchy throughout	5 years ago
Alisdair McDiarmid	b2ba650c21	cli: Remove deprecated destroy -force flag ... This dramatically simplifies the logic around auto-approve, which is nice. Also add test coverage for the manual approve step, for both apply and destroy, answering both yes and no.	5 years ago
James Bardin	1e5a8e4dae	fix concurrent test relying on sleep ... Make an old concurrent test deterministic, and not rely on sleep for any synchronization.	5 years ago
Alisdair McDiarmid	888f36aebb	cli: Remove positional plan argument from graph ... To make the command arguments easier to understand and extend, we are moving away from positional arguments. This commit changes the graph command to take a `-plan` flag instead of an optional trailing path.	5 years ago
Alisdair McDiarmid	ca23a096d8	cli: Remove legacy positional path arguments ... Several commands continued to support the legacy positional path argument to specify a working directory. This functionality has been replaced with the global -chdir flag, which is specified before any other arguments, including the sub-command name. This commit removes support for the trailing path parameter from most commands. The only command which still supports a path argument is fmt, which also supports "-" to indicate receiving configuration from standard input. Any invocation of a command with an invalid trailing path parameter will result in a short error message, pointing at the -chdir alternative. There are many test updates in this commit, almost all of which are migrations from using positional arguments to specify a working directory. Because of the layer at which these tests run, we are unable to use the -chdir argument, so the churn in test files is larger than ideal. Sorry!	5 years ago
Brian Flad	70aac9c551	command: Use different warning messaging in init command and move above potentially confusing output (#27514) ... Reference: https://github.com/hashicorp/terraform/issues/27459 Reference: https://github.com/hashicorp/terraform/pull/27507 This follows the change in the plan command to move the development overrides warning above other output from the command that may exhibit unexpected behavior.	5 years ago
Alisdair McDiarmid	5ca118b4e6	cli: Move resource count code to command package ... CountHook is an implementation of terraform.Hook which is used to calculate how many resources were added, changed, or destroyed during an apply. This hook was previously injected in the local backend code, which means that the apply command code has no access to these counts. This commit moves the CountHook code into the command package, and removes an unused instance of the hook in the plan code path. The goal here is moving UI code into the command package.	5 years ago
Pam Selle	29dd334fe8	Merge pull request #27611 from hashicorp/pselle/ignore-remote-version-docstring ... Update docstring for ignore-remote-version	5 years ago
Pam Selle	c1ede28a15	Update docstring for ignore-remote-version ... Update docstring for ignore-remote-version to be more accurate, as it's not whether the versions differ, but if they are incompatible	5 years ago
Alisdair McDiarmid	2e62e03b64	cli: Remove dead code for output -module flag ... The -module flag to terraform output has been unimplemented since 0.12. This commit removes some dead code and the specific error message for this flag. The website documentation for output does not mention this flag, so it is unchanged.	5 years ago
Katy Moe	de31787966	add missing import	5 years ago
Katy Moe	51c687c2db	command: no visual warning hierarchy in -no-color ... Commit e865faf adds visual indentation for diagnostic messages using various vertical line characters. The present commit disables this behaviour when running with colourised output disabled. While the contents of stderr are not intended to be part of the Terraform API, this is currently how the hashicorp/terraform-exec library detects certain error types in order to present them as well-known Go errors to the user. Such detection is complicated when vertical lines are added to the CLI output at unpredictable points. I expect this change will also be helpful for screen reader users.	5 years ago
Katy Moe	bc51932e08	refactor: extract appendSourceSnippets	5 years ago
Jonathan Hall	49ee3d3ef8	Grammar nit: "setup" as a verb should be spelled "set up"	5 years ago
Pam Selle	35d5ea5455	Update state mv help docs to use spaces instead of tabs ... Adds a test to make sure that this text doesn't accidentally get tabs added, without having a test that simply direct matches the whole strings (which would be brittle to adding a tab to the test validation)	5 years ago
Pam Selle	e1b0e3ce92	Remove -module option for taint and untaint ... This has been an error with help text, and can be removed.	5 years ago
Alisdair McDiarmid	75d38b50b1	docs: Note: state pull upgrades to current version	5 years ago
Nick Fagerlund	a60120477c	Update links to CLI docs in code comments, messages, and readme	5 years ago
Nick Fagerlund	ed7f97c34f	Update language docs URLs in code and tests	5 years ago
James Bardin	9f2a6d33be	move remaining helper packages to internal	5 years ago
Alisdair McDiarmid	a7d50d3264	Merge pull request #27545 from hashicorp/alisdair/remote-backend-version-check-state-migration ... cli: Fix state migration remote version check	5 years ago
James Bardin	21896f74af	builtin provisioner e2e test	5 years ago
Alisdair McDiarmid	212a97c3bd	cli: Fix state migration remote version check ... Previously the state migration process was using the fallback strict error check when migrating to or from a Terraform Cloud workspace. This resulted in an error when running init if the local and remote Terraform versions did not exactly match. This was excessively strict. When migrating from a remote Terraform Cloud workspace to local state, there is no need for a version check at all, as we cannot break the Terraform Cloud workspace. When migrating to Terraform Cloud, we should use the more forgiving check, rather than the strict equality. This commit fixes both of these cases accordingly, and allows migrating state to and from Terraform Cloud remote workspaces without errors.	5 years ago
Martin Atkins	e865faf318	command: Better visual hierarchy for diagnostics ... I frequently see people attempting to ask questions about Terraform's error and warning messages but either only copying part of the message or accidentally copying a surrounding paragraph that isn't part of the message. While I'm sure some of these are just "careless" mistakes, I've also noticed that this has sometimes overlapped with someone asking a question whose answer is written directly in the part of the message they didn't include when copying, and so I have a theory that our current output doesn't create a good enough visual hierarchy for sighted users to understand where the diagnostic messages start and end when we show them in close proximity to other content, or to other diagnostic messages. As a result, some folks fail to notice the relevant message that might've answered their question. I tried a few different experiments for different approaches here, such as adding more horizontal rules to the output and coloring the detail text differently, but the approach that felt like the nicest compromise to me was what's implemented here, which is to add a vertical line along the left edge of each diagnostic message, colored to match with the typical color we use for each diagnostic severity. This means that the diagnostics end up slightly indented from what's around them, and the vertical line seems to help subtly signal how we intended the content to be grouped together.	5 years ago
Alisdair McDiarmid	a15c5c84a3	Merge pull request #27498 from hashicorp/alisdair/fix-remote-terraform-version-check-again ... cli: Fix double check of remote workspace version	5 years ago
Pam Selle	4ffacc8d4a	Merge pull request #27502 from hashicorp/pselle/untaint-missing ... Add name to untaint missing warning	5 years ago
Pam Selle	1e10051cad	Merge pull request #27501 from hashicorp/pselle/taint-err ... Show resource name in taint -allow-missing warning	5 years ago
Martin Atkins	1f1af87dea	command/format: Don't try to fill the last terminal column ... In some terminal emulators, writing a character into the last column on a row causes the terminal to immediately wrap to the beginning of the next line, even if the very next character in the stream is a hard newline. That can then lead to errant blank lines in the final output which make it harder to navigate the visual hierarchy. As a compromise to avoid this, we'll format our horizontal rules and paragraphs to one column less than the terminal width. That does mean that our horizontal rules won't _quite_ cover the whole terminal width, but it seems like a good compromise in order to get consistent behavior across a wider variety of terminal implementations.	5 years ago
Martin Atkins	0c84a56700	command/format: Use box drawing chars for rules in diagnostics ... We were previously using some ASCII art to create some visual divisions between parts of the diagnostic output. Now that we are requiring a UTF-8 terminal we can print out box drawing characters instead.	5 years ago
Martin Atkins	e6a516d87e	backend/local: Use terminal properties to tweak the plan output ... We now require the output to accept UTF-8 and we can determine how wide the terminal (if any) is, so here we begin to make use of that for the "terraform plan" command. The horizontal rule is now made of box drawing characters instead of hyphens and fills the whole terminal width. The paragraphs of text in the output are now also wrapped to fill the terminal width, instead of the hard-wrapping we did before. This is just a start down the road of making better use of the terminal capabilities. Lots of other commands could benefit from updates like these too.	5 years ago
Martin Atkins	d2c3403ab6	command: Use the new terminal.Streams object ... Here we propagate in the initialized terminal.Streams from package main, and then onwards to backends running in CLI mode. This also replaces our use of helper/wrappedstreams to determine whether stdin is a terminal or a pipe. helper/wrappedstreams returns incorrect file descriptors on Windows, causing StdinPiped to always return false on that platform and thus causing one of the odd behaviors discussed in Finally, this includes some wrappers around the ability to look up the number of columns in the terminal in preparation for use elsewhere. These wrappers deal with the fact that our unit tests typically won't populate meta.Streams.	5 years ago
Pam Selle	e6d02aec16	Merge pull request #27482 from hashicorp/pselle/state_mv ... Make errors in state mv more accurate	5 years ago
Pam Selle	b25d0251ca	Add name to untaint missing warning	5 years ago
Pam Selle	67853d8fa8	Show resource name in taint -allow-missing warning ... Show the resource name in the warning when allow-missing is used and no resource matches	5 years ago
Pam Selle	d34e1d926a	Merge pull request #27484 from hashicorp/pselle/revision ... Remove revision from version command	5 years ago
Alisdair McDiarmid	ddac282553	cli: Fix double check of remote workspace version ... After verifying the remote backend workspace version is compatible with the local Terraform version, we need to record that this check was successful. Otherwise the fallback error handling path will run a strict version check, even if the versions are compatible, which will cause an unexpected failure.	5 years ago
James Bardin	3bc7d77230	update MockProvider usage	5 years ago
Pam Selle	83e6703bf7	Remove revision from version command ... The revision field is only populated on dev builds so this means most releases of Terraform have an empty "terraform_revision" field in the JSON output. Since we recommend developers use go tooling to `go build` this tool when developing, the revision is not useful data and so it is removed.	5 years ago
Pam Selle	9371b60d71	More verbose error for whole resource move failure ... When running state mv with a resource source, but the destination fails, provide a hint that the source is a resource (not an instance) in case the user means to address it this way	5 years ago
Pam Selle	52c77ba33e	Print addresses in state mv errors ... Using the addrTo after it has failed its check means <invalid>/no address will be printed. Change this throughout, but particularly add a test for the origin issue for this.	5 years ago
Pam Selle	0d87c66211	Merge pull request #27463 from hashicorp/pselle/get-plugins ... Remove get-plugins flag	5 years ago
Pam Selle	801f8aa0b7	Merge pull request #27461 from hashicorp/pselle/verify-plugins ... Remove verify-plugins flag	5 years ago
Pam Selle	462caaf538	Merge pull request #27464 from hashicorp/pselle/init-lock ... Remove state lock flags from init	5 years ago
Jacob Martin	b49655724d	command: Fix terraform show not outputting child_modules properly in certain circumstances (#27352) ... * Add test for module nesting without resources. * Add test * Fix showing resources when a module has no resources, only submodules.	5 years ago
Pam Selle	bbcf6ae20b	Remove state lock flags from init	5 years ago
Pam Selle	5ad6100ff3	Remove get-plugins ... Remove the no-op get-plugins flag	5 years ago
Pam Selle	da5a28e6ae	Remove verify-plugins flag ... This flag does not do anything, and so this removes the mention in the CLI docs and the parsing of the flag variable	5 years ago
Kristin Laemmert	8bab3dd374	command/state list: list resources in nested and expanded modules (#27268) ... * command/state list: list resources in nested and expaneded modules A few distinct bugs fixed in here: There was a bug in the logic checking if a given module was the child of the targetAddr, now fixed. That resolved the basic issue where resources in nested submodules were not listed. The logic around allowMissing needed some tweaking to allow for empty modules, as long as those modules had submodules with resources. state list is the only command using allowMissing with false so this felt safe to do. Finally I extended the logic so list would included expanded modules, which is to say giving module.foo would result in resources from module.foo[1], module.foo[0], etc. * update state list docs to show that module filtering includes any nested modules	5 years ago
Alisdair McDiarmid	e7db580e67	Merge pull request #27265 from hashicorp/alisdair/validate-json-tests ... command: Add tests for terraform validate -json	5 years ago
Kristin Laemmert	8a4891383c	console: normalize module path before building context (#27263) ... Expressions such as "path.root" were returning the cwd (or modulePath), instead of the usual _relative_ path. This commit normalizes the path before building the context.	5 years ago