22059 Commits (4e12671d8d2d43f8dee65c769540b08790c82076)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Atkins	4e12671d8d	command/format: show planned changes in rendered plan ... This codepath is going to be significantly changed before release to make it support structural diff of the new data types, but this lets us lean on the old renderer to produce partial output in the mean time while we continue to work on getting things working end-to-end after the considerable refactoring that's been going on.	8 years ago
Martin Atkins	c7e558c153	core: Re-implement EvalWriteDiff to work with new plan types	8 years ago
Martin Atkins	099b673b98	helper/plugin: don't panic in PlanResourceChange PlannedState	8 years ago
Martin Atkins	b9e95639f6	core: Tolerate the prior state being nil in EvalDiff ... This happens legitimately in situations where we'll be creating an object for this resource instance for the first time.	8 years ago
Martin Atkins	d13bfc8b3f	core: Update EvalCountFixZeroOneBoundaryGlobal for new state types	8 years ago
Martin Atkins	c0b0c871d9	terraform: Return validation diagnostics with source info where possible	8 years ago
Martin Atkins	9350c26c8d	plugin/convert: Convert cty.PathError to diagnostics with attribute path	8 years ago
Martin Atkins	1dc0af7dcb	plugin: TRACE log for each GRPC-remoted plugin call	8 years ago
Martin Atkins	90787f508a	plugin: Fix deadlock in getSchema where mutex is never unlocked ... On the second call here this would fail to release the lock.	8 years ago
Martin Atkins	6291c20358	plugin: Register v5 plugins only if present ... Previously we would construct both provisioner and the provider objects if either callback was set, but this is incorrect because a plugin should actually set only one of these at a time, depending on what kind of plugin it is.	8 years ago
Martin Atkins	2e758a26a1	backend/local: Bail immediately if terraform.Context can't be created	8 years ago
Martin Atkins	cc3c3863fb	vendor: upgrade go-cty to latest ... This includes the new PathSet type, which we'll use to represent the "requires replacement" set of attribute paths coming back from providers during planning.	8 years ago
Martin Atkins	71865be05c	vendor: update to latest github.com/zclconf/go-cty ... This includes a bugfix to the cty/msgpack package to ensure correct decoding of unknown and null values. This also includes updates to cty's dependencies.	8 years ago
Martin Atkins	23c17cdc7b	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
Martin Atkins	ecca5f291e	vendor: switch to Go modules ... govendor's lack of understanding of transitive versions was making it hell to figure out some dependency hell between etcd, grpc, and protobuf. After fighting with it for a few hours, I decided to give Go 1.11rc2 a try since previous experiments had been promising on the 1.11 tree in master. The dependencies all worked out first time when managed using the Go Modules code, and so we'll run with this now to continue to make progress though we may wish to back out of this nearer to release and return to govendor for a while until other projects have caught up. However, since this commit includes a vendor directory produced using Go Modules it doesn't actually _require_ Go 1.11 to build, and instead requires it only to make further changes to the selected versions in the vendor dir. Go 1.10's vendoring support will still find the modules in their expected locations within the vendor dir.	8 years ago
Martin Atkins	0827d4b230	govendor fetch github.com/google.golang.org/grpc/...@v1.14.0	8 years ago
James Bardin	8b2eb7100b	replace provider and provisioner types in tests ... The field assignments and methods are incorrect still, but the type definitions and returns are now updated.	8 years ago
Martin Atkins	a210439347	configschema: Handle nested blocks containing dynamic-typed attributes ... We need to make the collection itself be a tuple or object rather than list or map in this case, since otherwise all of the elements of the collection are constrained to be of the same type and that isn't the intent of a provider indicating that it accepts any type.	8 years ago
Martin Atkins	84a7f43627	plans/objchange: AssertObjectSuperset function ... This function's goal is to ensure that the "final" plan value produced by a provider during the apply step is always consistent with the known parts of the planned value produced during the plan step. Any error produced here indicates a bug in the provider.	8 years ago
Martin Atkins	aef4faedf6	plans/objchange: logic for merging prior state with config ... This produces a "proposed new state", which already has prior computed values propagated into it (since that behavior is standard for all resource types) but could be customized further by the provider to make the "_planned_ new state". In the process of implementing this it became clear that our configschema DecoderSpec behavior is incorrect, since it's producing list values for NestingList and map values for NestingMap. While that seems like it should be right, we should actually be using tuple and object types respectively to allow each block to have a different runtime type in situations where an attribute is given the type cty.DynamicPseudoType. That's not fixed here, and so without a further fix list and map blocks will panic here. The DecoderSpec implementation will be fixed in a subsequent commit.	8 years ago
Martin Atkins	886c271711	plans: Record private data bytes as part of resource change ... This allows a provider to retain arbitrary extra data in the plan and make use of it during apply. The contents are not used by Terraform and never shown to the user.	8 years ago
Martin Atkins	fb8e390d76	states: object Private data is []byte, not cty.Value ... We're going to allow the provider to encode whatever it wants in here, so a provider can use whatever is most convenient for its implementation language and to avoid some of the bugs we saw with the prior model where the forced round-trip through JSON and back into interface{} would cause some loss of fidelity, leading to bugs.	8 years ago
James Bardin	5a0f0adc53	ResourceProvisioner to provisioners.Interface ... Replacing the core types, without touching tests yet.	8 years ago
James Bardin	5aa081c44b	update Refresh ... Use the new ReadResource provider method	8 years ago
James Bardin	b44566b5f1	first step in core provider type replacement ... Chaange ResourceProvider to providers.Interface starting from the context, and fix all type errors. This only replaced some of method calls directly applicable to the providers themselves. The resource methods will follow.	8 years ago
Martin Atkins	9fc038fb4e	govendor fetch github.com/golang/protobuf/...	8 years ago
Martin Atkins	bbcc96ff1a	govendor fetch google.golang.org/grpc/...	8 years ago
Martin Atkins	0210cc7f06	govendor fetch github.com/coreos/etcd/...	8 years ago
Martin Atkins	08344a4159	govendor fetch github.com/hashicorp/hcl2/... ... This is a general catchup of some developments in the HCL2 codebase, but in particular includes: - Recording expression and evalcontext as part of diagnostics, so that variable value information can be included alongside diagnostic snippets. - hcldec supports decoding blocks into tuple and object values as well as list and map values, which then allows cty.DynamicPseudoType nested attributes to work properly.	8 years ago
Martin Atkins	aa20c4085a	govendor fetch golang.org/x/sys/unix/... ... This new version defines some symbols that are required by the grpc library.	8 years ago
James Bardin	7d7c77ad13	Merge pull request #18686 from hashicorp/jbardin/plugins ... plugin mocks	8 years ago
Martin Atkins	e39842332c	providers: Resolver and Factory types ... These new types are adaptations of terraform.ProviderResolver and terraform.ResourceProviderFactory respectively. In a later commit we will update users of the old types to use these new types, possibly in a "gradual repair" sort of fashion by initially using type aliases, though that won't 100% solve the problem because the types themselves have changed in this move to return providers.Interface instead of terraform.ResourceProvider.	8 years ago
James Bardin	e2b7c6b920	add new provider and provisioner mocks ... MockProvider and MockProvisioner implement the new plugin interfaces, and are built following the patterns used by the legacy MockResourceProvider and MockResourceProvisioner	8 years ago
James Bardin	37864624d3	add Close method to the terraform provider ... Close is now part of the plugin interfaces, so needs to be implemented by the terraform provider.	8 years ago
James Bardin	afca7f98dd	add Close methods to the plugin interfaces ... Close was previously an optional interface, because it's only applicable on the client side but the types were shared accross all packages. Since all plugins will now implement Close, it no longer needs to be optional.	8 years ago
James Bardin	ebfd8d869a	Merge pull request #18685 from hashicorp/jbardin/plugins ... move conversion functions into separate package	8 years ago
James Bardin	a65f696bbb	move conversion functions into separate package ... Managing which function need to be shared between the terraform plugin and the helper plugin without creating cycles was becoming difficult. Move all functions related to converting between terraform and proto type into plugin/convert.	8 years ago
James Bardin	91863e3a60	schema version changed type	8 years ago
James Bardin	0544f82447	Merge pull request #18678 from hashicorp/jbardin/grpc-plugins ... new plugin shims	8 years ago
James Bardin	eb321a1174	update go-plugin with proto negotiation	8 years ago
Martin Atkins	ade3b4575e	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	7ed152bbd8	states: Port stringer implementation from terraform.State ... Our existing core tests make extensive use of the string representation of a state for comparison purposes, because they were written before we began making use of helper packages like "cmp". To avoid the need to rewrite all of those tests and potentially break them, we will instead port that particular rendering as closely as possible but mark it with a comment sternly warning not to use it for anything new. We don't want to use this moving forward for a number of reasons, but most notably: - printing out whole before and after state representations makes it hard to find a subtle difference in outcome when a test fails, while "cmp" can provide us with a real diff. - this string serialization is constrained by the capabilities of Terraform prior to our new state models, and so it does not comprehensively represent all possibilities in the new world. - it will probably behave oddly/poorly when given states containing features that arrived after it was written, even though I made a best effort here to make it do something reasonable in situations I thought about.	8 years ago
Martin Atkins	1ce3392f63	states: separate types for encoded and decoded state objects ... The types here were originally written to allow us to defer decoding of object values until schemas are available, but it turns out that this was forcing us to defer decoding longer than necessary and potentially decode the same value multiple times. To avoid this, we create pairs of types to represent the encoded and decoded versions and methods for moving between them. These types are identical to one another apart from how the dynamic values are represented.	8 years ago
Martin Atkins	44a4e2efdb	plans: separate types for encoded and decoded changes ... The types here were originally written to allow us to defer decoding of object values until schemas are available, but it turns out that this was forcing us to defer decoding longer than necessary and potentially decode the same value multiple times. To avoid this, we create pairs of types to represent the encoded and decoded versions and methods for moving between them. These types are identical to one another apart from how the dynamic values are represented.	8 years ago
Martin Atkins	6a39759145	statemgr: Helper funcs RefreshAndRead and WriteAndPersist ... In practice these pairs of functions are often used together when working with a "full" statemgr, so these helper wrappers allow us to do that more conveniently. This also introduces a new interface statemgr.Storage, which represents a state manager that has all of the storage capabilities but does not necessarily support locking. In practice callers will usually just use statemgr.Full, but these more-specific interfaces allow us to reflect in APIs which subset of the statemgr functionality each function depends on.	8 years ago
James Bardin	de11eed345	serve the new version 5 grpc plugins ... Use the new go-plugin version negotiation to server th appropriate plugin type when the client requests protocol version 5.	8 years ago
James Bardin	37ab3798cc	update tests to match new test func signature	8 years ago
James Bardin	19fdd6430f	add grpc shims to helper/plugin ... Add shim functions to automatically wrap plugins in the new GRPC implementations.	8 years ago
Kristin Laemmert	d6b05285d1	Merge pull request #18625 from hashicorp/mildwonkey/pitr ... Terraform Providers in the Registry	8 years ago
Kristin Laemmert	831fb5c1f9	registry/response: rename Collection to ProviderVersionCollection for clarity	8 years ago