9 Commits (4147fa779c26bdea044e8d77bd13989beacc81c8)

Author	SHA1	Message	Date
Martin Atkins	5861dbf3fc	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
James Bardin	1ad97f6be8	use an EvalOpFilter for module variables ... Remove the Input flag threaded through the input graph creation process to prevent interpolation failures on module variables. Use an EvalOpFilter instead to inset the correct EvalNode during walkInput. Remove the EvalTryInterpolate type, and use the same ContinueOnErr flag as the output node for consistency and to try and keep the number possible eval node types down.	9 years ago
James Bardin	97bb7cb65c	Don't allow interpolation failure to stop Input ... Allow module variables to fail interpolation during input. This is OK since they will be verified again during Plan. Because Input happens before Refresh, module variable interpolation can fail when referencing values that aren't yet in the state, but are expected after Refresh.	9 years ago
Mitchell Hashimoto	89f7e3b79f	terraform: add module vars after providers to see references ... Fixes #10711 The `ModuleVariablesTransformer` only adds module variables in use. This was missing module variables used by providers since we ran the provider too late. This moves the transformer and adds a test for this.	10 years ago
Mitchell Hashimoto	a5df3973a4	terraform: module variables should be pruned if nothing depends on them	10 years ago
Mitchell Hashimoto	b7954a42fe	terraform: remove pruning of module vars if they ref non-existing nodes ... Fixes a shadow graph error found during usage. The new apply graph was only adding module variables that referenced data that existed _in the graph_. This isn't a valid optimization since the data it is referencing may be in the state with no diff, and therefore available but not in the graph. This just removes that optimization logic, which causes no failing tests. It also adds a test that exposes the bug if we had the pruning logic.	10 years ago
Mitchell Hashimoto	9ac4ee4b52	terraform: transform module variables does parent first	10 years ago
Mitchell Hashimoto	924f7a49e0	terraform: module variable transform must do children later (tested)	10 years ago
Mitchell Hashimoto	993c29f34a	terraform: move ModuleVariableTransformer to its own file	10 years ago