22379 Commits (4147fa779c26bdea044e8d77bd13989beacc81c8)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Atkins	4147fa779c	command: WIP input variable handling	8 years ago
Martin Atkins	d2a9f6c4fd	command: Fix some tests for the "apply" command	8 years ago
Martin Atkins	6245ec369a	backend/local: Increase log verbosity for backend context construction ... There are several steps here and a number of them can include reaching out to remote servers or executing local processes, so it's helpful to have some trace logs to better narrow down causes of errors and hangs during this step.	8 years ago
Martin Atkins	d170507a17	command: Update backend-unchanged fixture for new expectations ... Our serialization of the backend configuration has changed slightly for Terraform 0.12 due to reimplementing it in terms of the HCL2 types, so the base case that should be unchanged during the test needs to be changed.	8 years ago
Martin Atkins	c6804959be	command/format: be resilient to incomplete schema when formatting state ... In all real cases the schemas should be populated here, but we don't want to panic in UI rendering code if there's a bug here. This can also be tripped up by tests with incomplete mocks. It's unfortunate that this can therefore mask some problems in tests, but tests can protect against it by asserting on specific output text rather than just assuming that a zero exit status is a pass.	8 years ago
Martin Atkins	cbe24929cb	backend/local: reinstate additional steps in plan file processing ... In earlier refactoring we skipped implementing prior state safety checks, propagating the target addresses from plan, and verifying that all of the providers are exactly the same from the plan being created. This change reinstates those checks, including a new error message for the "stale plan" situation.	8 years ago
Kristin Laemmert	f351019d8b	Merge pull request #18949 from hashicorp/mildwonkey/f-state-format-cmd ... mildwonkey/f-state-format-cmd	8 years ago
Kristin Laemmert	9529e7fc36	command/format: revert indentation change for consistency's sake	8 years ago
Kristin Laemmert	c86aea98c3	command/format: fix indentation ... also run go mod tidy	8 years ago
Martin Atkins	93d6eebaf2	command: Show snippet of invalid resource addresses in import ... If we fail to parse the resource address given to "terraform import" then it's helpful to produce a "source code" snippet of what the user provided so they might see more precisely which part of the address was invalid.	8 years ago
Martin Atkins	097d098245	command: Fix TestUntaint	8 years ago
Martin Atkins	02f547d1a0	command: Fix all of the "taint" command tests ... Most of this is just updates to allow for the fact that we now always save the provider address as part of resource state, whereas before it was only saved conditionally. This also updates TestTaint_module for the intentional change that it now expects a child module to be specified using normal resource address syntax, rather than as a separate -module option.	8 years ago
Martin Atkins	896cfb8979	command: Fix TestUntaint_module ... The untaint command now uses normal resource address syntax to specify the module path, rather than passing it in as a separate argument.	8 years ago
Martin Atkins	2c30e3039f	command: Fix various "untaint" command tests ... Resource instance state now always includes the provider address fo each resource, so our expected state output strings needed to be adjusted.	8 years ago
Martin Atkins	2d84ebe37b	command: Actually include the error when backend config decoding fails	8 years ago
Martin Atkins	35bd7ce938	backend/local: Stub out remaining planfile todos with errors ... This is just to make sure they show up later when we are working on the tests, so we can be sure not to forget to address them.	8 years ago
Martin Atkins	9cbfe78913	backend/local: Populate changes into a context built from planfile	8 years ago
Kristin Laemmert	b1460b9661	command/show: config files are assumed to be in cwd	8 years ago
Kristin Laemmert	827c5f6c59	fix go module related merge conflict	8 years ago
Kristin Laemmert	c178058f10	cli: format/state_test.go ... Added a very simple test with state and schema. TODO: if tests are added we should test using golden files (and example state files, instead of strings). This seemed unnecessary with the simple test cases.	8 years ago
Kristin Laemmert	7f951d5f75	cli: format/state refactor to use blockBodyDiffPrinter ... Use functions from format/diff to print values	8 years ago
Kristin Laemmert	10e58dfabb	cli: format/state refactor for new state format ... format/state now requires provider schemas to properly format output state. command/show has been modified to pass a context to format.State.	8 years ago
Martin Atkins	764a7d61c8	command: Populate backend configuration in plan files ... In previous work we didn't quite connect these dots. The connection here is sub-awesome since the existing interfaces here had some unfortunate assumptions that we'd like to move away from (like the idea of a "nil backend" implying the local backend) but we're accepting this for now to avoid another big round of refactoring. The main implication of this is that we will now always include a backend configuration in the plan, though it might just be a placeholder config for the local backend in the remaining cases where that's still implicitly set. Later we will change this so that there is no implicit local backend at all (terraform init is always required, _it_ will deal with setting implicitly setting the local backend when appropriate), which will allow us to rework this to be more straightforward and less "spooky".	8 years ago
Martin Atkins	4c988cea62	command: Do CLI init of backend loaded from plan ... If we don't do this, we can't produce any output when applying a saved plan file. Here we also introduce a check to the local backend's ReportResult function so that it won't panic if CLI init is skipped, although that will no longer happen in the apply-from-file case due to the change described in the previous paragraph.	8 years ago
Martin Atkins	1cd5ec22ed	backend/local: Require caller to set PlanOutBackend with PlanOutPath ... We can't generate a valid plan file without a backend configuration to write into it, but it's the responsibility of the caller (the command package) to manage the backend configuration mechanism, so we require it to tell us what to write here. This feels a little strange because the backend in principle knows its own config, but in practice the backend only knows the _processed_ version of the config, not the raw configuration value that was used to configure it.	8 years ago
Martin Atkins	cc888feaad	go mod tidy	8 years ago
Martin Atkins	36fbc8e23a	build: Specify in .go-version that we build with Go 1.11.1	8 years ago
Kristin Laemmert	f1b88a6cbf	Merge pull request #19025 from hashicorp/mildwonkey/backend-local-tests ... mildwonkey/backend-local-tests	8 years ago
Kristin Laemmert	45739246c8	backend/local tests tests tests ... converted the existing testPlanState() from terraform.State to states.State to fix various plan tests. reverted the "bandaid" in plans/planfile/tfplan.go - at this moment the backend tests do not include backend configuration, and so the planfile package can write the plan file but not read it back in. That will be revisted in a separate track of work.	8 years ago
Kristin Laemmert	66b55c4089	backend/local: more tests passing ... I have no confidence in the change to plans/planfile/tfplan.go. The tests were passing an empty backend config, which planfile was able to write to a file but not read from the same file. This change let me move past that and it did not break any tests in the planfile package, but I am concerned that it introduces undesired behavior.	8 years ago
Kristin Laemmert	041a213d6a	backend/local: updated DiffFn adn ReadResourceFn for new models	8 years ago
Kristin Laemmert	4a9278e11a	backend/local refresh tests refactor	8 years ago
Kristin Laemmert	ebc579769d	backend/local: test fixes ... for TestLocal_applyBackendFail, config is relative to the tests' wd	8 years ago
Kristin Laemmert	559324f4a8	revert to explicitly declare schema for TestLocal_applyEmptyDirDestroy	8 years ago
Kristin Laemmert	fd5642b32c	backend/local tests	8 years ago
James Bardin	bce2918fb7	remove unneeded legacy test ... The legacy test wasn't really testing anything useful, just the plan behavior with no diff in a module returned a module with no diff. There's no reason to convert this to the new plans, since there's no legacy behavior to match.	8 years ago
James Bardin	c22165f3a2	return proper PlanResourceChange in mock	8 years ago
James Bardin	058d55fc2d	Merge pull request #19019 from hashicorp/jbardin/plan-resource-change ... a plan with no diff should return proposed state	8 years ago
James Bardin	5564afdab4	update provisioners for multiple processes ... The "internal" provisioners are still run in a separate process, and need to be updated to restart on each walk.	8 years ago
James Bardin	131f1c3e4e	missing diagnostics in pugin protocol ... Some call diagnostics were being missed	8 years ago
James Bardin	359075f2ef	initialize empty diff in apply ... While the schema Diff fucntion returns a nil diff when creating an empty (except for id) resource, the Apply function expects the diff to be initialized and ampty.	8 years ago
James Bardin	506f561c7b	a plan with no diff should return proposed state ... PlanResourceChange isn't returning the diff, but rather it is returning the destired state. If the propsed state results in a nil diff, then, the propsed state is what should be returned. Make sure Meta fields are not nil, as the schema package expects those to be initialised.	8 years ago
James Bardin	7406978d62	Merge pull request #18992 from hashicorp/jbardin/plugin-nil-checks ... check responses for nil values	8 years ago
James Bardin	2209d6cdd9	Merge pull request #18982 from hashicorp/jbardin/plugin-processes ... plugin processes	8 years ago
James Bardin	901d1d3a13	update to start a new process for each plugin ... Modify the plugin factories to create a new plugin process for each individual plugin.	8 years ago
James Bardin	124aec6dff	check responses for nil values ... While providers shouldn't return nil values, we need to protect against them. Always assign valid null cty values when the response contains a nil.	8 years ago
Martin Atkins	25de176a39	repl: Fix tests ... The test suite was not updated to deal with the new assumptions of the HCL2-based expression evaluator, which requires configuration to exist as well as state. Therefore we add a simple configuration fixture to have it validate expressions against. This also includes updates to expect the different error messages that the new evaluator produces.	8 years ago
Martin Atkins	8bd9bff7fa	repl: Make full logging optional in tests ... Logs will be hidden unless verbose mode is enabled on the test run.	8 years ago
Martin Atkins	697448bbb0	core: Reinstate state-based tracking of data resource dependencies ... This was inadvertently lost in the consoliation of EvalReadDataDiff and EvalReadDataApply into a single EvalReadData.	8 years ago
Martin Atkins	6a35d801f7	core: Fix TestContext2Plan_dataResourceBecomesComputed ... Data resources get processed during refresh, so it doesn't make sense to have a data resource test that doesn't run the refresh walk.	8 years ago