1022 Commits (4147fa779c26bdea044e8d77bd13989beacc81c8)

Author	SHA1	Message	Date
Martin Atkins	4147fa779c	command: WIP input variable handling	8 years ago
Martin Atkins	d2a9f6c4fd	command: Fix some tests for the "apply" command	8 years ago
Martin Atkins	d170507a17	command: Update backend-unchanged fixture for new expectations ... Our serialization of the backend configuration has changed slightly for Terraform 0.12 due to reimplementing it in terms of the HCL2 types, so the base case that should be unchanged during the test needs to be changed.	8 years ago
Martin Atkins	c6804959be	command/format: be resilient to incomplete schema when formatting state ... In all real cases the schemas should be populated here, but we don't want to panic in UI rendering code if there's a bug here. This can also be tripped up by tests with incomplete mocks. It's unfortunate that this can therefore mask some problems in tests, but tests can protect against it by asserting on specific output text rather than just assuming that a zero exit status is a pass.	8 years ago
Kristin Laemmert	f351019d8b	Merge pull request #18949 from hashicorp/mildwonkey/f-state-format-cmd ... mildwonkey/f-state-format-cmd	8 years ago
Kristin Laemmert	9529e7fc36	command/format: revert indentation change for consistency's sake	8 years ago
Kristin Laemmert	c86aea98c3	command/format: fix indentation ... also run go mod tidy	8 years ago
Martin Atkins	93d6eebaf2	command: Show snippet of invalid resource addresses in import ... If we fail to parse the resource address given to "terraform import" then it's helpful to produce a "source code" snippet of what the user provided so they might see more precisely which part of the address was invalid.	8 years ago
Martin Atkins	097d098245	command: Fix TestUntaint	8 years ago
Martin Atkins	02f547d1a0	command: Fix all of the "taint" command tests ... Most of this is just updates to allow for the fact that we now always save the provider address as part of resource state, whereas before it was only saved conditionally. This also updates TestTaint_module for the intentional change that it now expects a child module to be specified using normal resource address syntax, rather than as a separate -module option.	8 years ago
Martin Atkins	896cfb8979	command: Fix TestUntaint_module ... The untaint command now uses normal resource address syntax to specify the module path, rather than passing it in as a separate argument.	8 years ago
Martin Atkins	2c30e3039f	command: Fix various "untaint" command tests ... Resource instance state now always includes the provider address fo each resource, so our expected state output strings needed to be adjusted.	8 years ago
Martin Atkins	2d84ebe37b	command: Actually include the error when backend config decoding fails	8 years ago
Kristin Laemmert	b1460b9661	command/show: config files are assumed to be in cwd	8 years ago
Kristin Laemmert	c178058f10	cli: format/state_test.go ... Added a very simple test with state and schema. TODO: if tests are added we should test using golden files (and example state files, instead of strings). This seemed unnecessary with the simple test cases.	8 years ago
Kristin Laemmert	7f951d5f75	cli: format/state refactor to use blockBodyDiffPrinter ... Use functions from format/diff to print values	8 years ago
Kristin Laemmert	10e58dfabb	cli: format/state refactor for new state format ... format/state now requires provider schemas to properly format output state. command/show has been modified to pass a context to format.State.	8 years ago
Martin Atkins	764a7d61c8	command: Populate backend configuration in plan files ... In previous work we didn't quite connect these dots. The connection here is sub-awesome since the existing interfaces here had some unfortunate assumptions that we'd like to move away from (like the idea of a "nil backend" implying the local backend) but we're accepting this for now to avoid another big round of refactoring. The main implication of this is that we will now always include a backend configuration in the plan, though it might just be a placeholder config for the local backend in the remaining cases where that's still implicitly set. Later we will change this so that there is no implicit local backend at all (terraform init is always required, _it_ will deal with setting implicitly setting the local backend when appropriate), which will allow us to rework this to be more straightforward and less "spooky".	8 years ago
Martin Atkins	4c988cea62	command: Do CLI init of backend loaded from plan ... If we don't do this, we can't produce any output when applying a saved plan file. Here we also introduce a check to the local backend's ReportResult function so that it won't panic if CLI init is skipped, although that will no longer happen in the apply-from-file case due to the change described in the previous paragraph.	8 years ago
James Bardin	5564afdab4	update provisioners for multiple processes ... The "internal" provisioners are still run in a separate process, and need to be updated to restart on each walk.	8 years ago
James Bardin	2209d6cdd9	Merge pull request #18982 from hashicorp/jbardin/plugin-processes ... plugin processes	8 years ago
James Bardin	901d1d3a13	update to start a new process for each plugin ... Modify the plugin factories to create a new plugin process for each individual plugin.	8 years ago
Martin Atkins	09a33ed11b	command: Un-stub tests that were previously hanging on the inmem backend ... The underlying bug has now been fixed, in b3b62429a7 .	8 years ago
Martin Atkins	e84597e430	command/format: Remove tests for plan.go ... plan.go as a whole will be removed before too long, so there's no point in us updating all of these tests to use the new plan types.	8 years ago
Martin Atkins	e9ca9f1854	command/format: print correctly nested blocks with labels	8 years ago
Martin Atkins	b438db8e16	command: Allow tests to run to completion without panics or hangs ... There are still 160 test failures as of this commit, but at least the test program can run to completion and list out all the failures.	8 years ago
Martin Atkins	2597ef9da2	command: Fix TestApply for new mock provider interface ... It must now provide a basic implementation of plan and apply for its mock provider, which in this case can just pass through the proposed value generated by core because there are no computed attributes in this schema.	8 years ago
Martin Atkins	654acb7ddd	command: Fix TestApply_destroyTargeted for new provider and state types	8 years ago
Martin Atkins	46b0286b30	command: Fix TestApply_destroy for new provider and state types	8 years ago
Martin Atkins	a1e9a0b28d	command: Update plugins_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	dcb21b8847	command: Update refresh_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	7b73c16675	command: Update plan_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	ee64da4d12	command: Update import_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	af69f65ea9	command: Update apply_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	af3ce831b4	command: Use new provider and provisioner types in test helpers ... This moves our build errors from the test helpers out into the tests themselves. We'll update the tests in subsequent commits.	8 years ago
Martin Atkins	a1962ea156	core: Handle forced-create_before_destroy during the plan walk ... Previously we used a single plan action "Replace" to represent both the destroy-before-create and the create-before-destroy variants of replacing. However, this forces the apply graph builder to jump through a lot of hoops to figure out which nodes need it forced on and rebuild parts of the graph to represent that. If we instead decide between these two cases at plan time, the actual determination of it is more straightforward because each resource is represented by only one node in the plan graph, and then we can ensure we put the right nodes in the graph during DiffTransformer and thus avoid the logic for dealing with deposed instances being spread across various different transformers and node types. As a nice side-effect, this also allows us to show the difference between destroy-then-create and create-then-destroy in the rendered diff in the CLI, although this change doesn't fully implement that yet.	8 years ago
Martin Atkins	07126364ba	command: UiHook to report when it gets incorrect values ... For PreApply hook purposes we only actually use the Delete, Create, and Update actions, because other actions are handled in different ways than a direct call to ApplyResourceChange. However, if there's a bug in core that causes it to pass a different action, it's better for us to mark it as being explicitly unknown in the UI rather than simply defaulting to "Modifying...", which can thus obscure the problem and make for a confusing result.	8 years ago
Martin Atkins	3a3f71707b	command/format: Render unified diff for list and tuple value changes	8 years ago
Martin Atkins	68433696e8	command/format: Further refinement on the heuristic JSON-based diff ... We'll now show an "update" symbol prior to the argument to this synthetic jsonencode(...) call, for consistency with how we show nested values in other cases and to attach a verb to any "# forces replacement". We'll also show a special form in the case where the value seems to differ only in whitespace, so users can understand what's going on in that hopefully-rare situation, particularly if those whitespace-only changes end up forcing us to replace a remote object.	8 years ago
Martin Atkins	74f2642236	command/format: JSON value formatting heuristic not for primitive values ... Since our own syntax for primitive values is similar to that of JSON, and since we permit automatic conversions from number and bool to string, we must do this special JSON value diff formatting only if the value is a JSON array or object to avoid confusing results.	8 years ago
Martin Atkins	cb7e1d696e	command/format: Don't include commas after elements in map diffs ... Although commas are allowed in this context, it's not idiomatic to use them.	8 years ago
Martin Atkins	e86a26fd98	command/format: show deep diffs for old/new JSON strings ... Because so far we've not supported dynamically-typed complex data structures, several providers have used strings containing JSON to stand in for these. In order to get a readable diff in those cases, we'll recognize situations where old and new are both JSON and present a diff of the effective value of the JSON, using a faux call to the jsonencode(...) function to indicate when we've done so. This is a bit of a "cute" heuristic, but is important at least for now until we can migrate away from that practice of passing large JSON strings to providers and use dynamically-typed attributes instead.	8 years ago
Martin Atkins	fa083099c7	command/format: correct alignment for multi-line values in map diff	8 years ago
Martin Atkins	bd1192649e	command/format: Nice rendering for changes to map values	8 years ago
Martin Atkins	88a8b6064d	command/format: Show resource diff with header "comment" ... This extra comment line gives us a place to show the full resource address (since the block header line only includes type and name) and also allows us to explain in long form the meaning of the change icon on the following line.	8 years ago
Martin Atkins	86e8885bd1	command: initial structural diff rendering ... This is a light adaptation of our earlier prototype of structural diff rendering, as a starting point for what we'll actually ship. This is not consistent with the latest mocks, so will need some additional work before it is ready, but integrating this allows us to at least see the plan contents while fixing up remaining issues elsewhere.	8 years ago
Martin Atkins	f68642d923	core: Properly handle no-op changes in plan ... Previously we just left these out of the plan altogether, but in the new plan types we intentionally include change information for every resource instance, even if no changes are actually planned, to allow alternative plan file viewers to show what isn't changing as well as what is.	8 years ago
Martin Atkins	4e12671d8d	command/format: show planned changes in rendered plan ... This codepath is going to be significantly changed before release to make it support structural diff of the new data types, but this lets us lean on the old renderer to produce partial output in the mean time while we continue to work on getting things working end-to-end after the considerable refactoring that's been going on.	8 years ago
Martin Atkins	23c17cdc7b	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
Martin Atkins	ade3b4575e	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago