11 Commits (3c8a4e6e05afefb7639bf30efa852cf59f14ade6)

Author	SHA1	Message	Date
Alisdair McDiarmid	a43b035a51	core: Reduce string allocations for addrs Equal ... Generating strings and comparing them to implement Equal is a quick and easy solution. Unfortunately when this code is in the hot path, it becomes very expensive, so this commit changes some of those instances to compare the values directly. Combined with using addr.Equal instead of checking for string equality, this makes Terraform dramatically faster for some operations, such as generating large JSON plans.	5 years ago
James Bardin	e6bac359ed	Missing ConfigResource checks in TargetContains ... Adding some missing checks for ConfigResource, and check all combinations of Resource types for consistency.	6 years ago
James Bardin	bf91bff2c8	TargetContains improvements ... Simplify Module.TargetContains Handle the case of a keyed instance address in ModuleInstance.TargetContains.	6 years ago
Pam Selle	7407fee9c2	Make modules targetable	6 years ago
James Bardin	6ae9013c3f	add addrs.Module.Equal ... Mirror the addrs.ModuleInstance.Equal method	6 years ago
James Bardin	b1df763541	remove UnkeyedInstanceShim from ref transformer ... Since references are always within the scope of a single module, and we can connect all module instance outputs for proper ordering, the existing transformer works directly with only module paths as opposed to module instances. TODO: TransformApplyReferences for more precise module instance targeting?	6 years ago
Pam Selle	c249943360	Module Expansion: Part 2 (#24154) ... * WIP: dynamic expand * WIP: add variable and local support * WIP: outputs * WIP: Add referencer * String representation, fixing tests it impacts * Fixes TestContext2Apply_outputOrphanModule * Fix TestContext2Apply_plannedDestroyInterpolatedCount * Update DestroyOutputTransformer and associated types to reflect PlannableOutputs * Remove comment about locals * Remove module count enablement * Removes allowing count for modules, and reverts the test, while adding a Skip()'d test that works when you re-enable the config * update TargetDownstream signature to match master * remove unnecessary method Co-authored-by: James Bardin <j.bardin@gmail.com>	6 years ago
Martin Atkins	c97dd145b9	addrs: Module.Call method ... This is a helper for splitting a non-root module path into a callee and call pair, similar to the method of the same name on ModuleInstance.	8 years ago
Martin Atkins	02b25e7057	addrs: flesh out functionality ready to replace terraform.ResourceAddress ... This "kitchen sink" commit is mainly focused on supporting "targets" as a new sub-category of addresses, for use-case like the -target CLI option, but also includes some other functionality to get closer to replacing terraform.ResourceAddress and fill out some missing parts for representing various other address types that are currently represented as strings in the "terraform" package.	8 years ago
Martin Atkins	cd51864d84	configs: Start using the new "addrs" package types for modules ... We initially just mimicked our old practice of using []string for module paths here, but the addrs package now gives us a pair of types that better capture the two different kinds of module addresses we are dealing with: static addresses (nodes in the configuration tree) and dynamic/instance addresses (which can represent the situation where multiple instances are created from a single module call). This distinction still remains rather artificial since we don't yet have support for count or for_each on module calls, but this is intended to lay the foundations for that to be added later, and in the mean time just gives us some handy helper functions for parsing and formatting these address types.	8 years ago
Martin Atkins	b9d84f2944	addrs: new package for representing addresses ... This package is intended to contain all the functionality for parsing, representing, and formatting addresses of objects within Terraform. It will eventually subsume the responsibilities of both the InterpolatedVariable and ResourceAddress types in the "terraform" package, but for the moment is just a set of types for representing these things, lacking any way to parse or format them. The remaining functionality will follow in subsequent commits.	8 years ago