28201 Commits (3c8a4e6e05afefb7639bf30efa852cf59f14ade6)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Atkins	3c8a4e6e05	command+backend/local: -refresh-only and drift detection ... This is a light revamp of our plan output to make use of Terraform core's new ability to report both the previous run state and the refreshed state, allowing us to explicitly report changes made outside of Terraform. Because whether a plan has "changes" or not is no longer such a straightforward matter, this now merges views.Operation.Plan with views.Operation.PlanNoChanges to produce a single function that knows how to report all of the various permutations. This was also an opportunity to fill some holes in our previous logic which caused it to produce some confusing messages, including a new tailored message for when "terraform destroy" detects that nothing needs to be destroyed. This also allows users to request the refresh-only planning mode using a new -refresh-only command line option. In that case, Terraform _only_ performs drift detection, and so applying a refresh-only plan only involves writing a new state snapshot, without changing any real infrastructure objects.	5 years ago
Martin Atkins	ce69c3903f	command/views: Show refresh-detected changes as part of a plan ... We've always had a mechanism to synchronize the Terraform state with remote objects before creating a plan, but we previously kept the result of that to ourselves, and so it would sometimes lead to Terraform generating a planned action to undo some upstream drift, but Terraform would give no context as to why that action was planned even though the relevant part of the configuration hadn't changed. Now we'll detect any differences between the previous run state and the refreshed state and, if any managed resources now look different, show an additional note about it as extra context for the planned changes that follow. This appears as an optional extra block of information before the normal plan output. It'll appear the same way in all of the contexts where we render plans, including "terraform show" for saved plans.	5 years ago
Martin Atkins	745aebeda1	core: "Did you mean" hints for unsupported resource types ... When we detect that a module is trying to declare a resource type that doesn't exist in its corresponding provider, we have enough information to give some hints as to what might be wrong. We give preference to the possibility of mixing up a managed resource type with a data resource type, but if not that then we'll use our usual levenshtein-distance-based similar name suggestion function. We currently don't typically test exact error message text, so and this is just a cosmetic change to the message output, so there are now new tests or test modifications here.	5 years ago
CJ Horton	dc71cd4495	Merge pull request #28684 from hashicorp/radditude/org-read-error ... backend/remote: clearer error when we fail to read the organization	5 years ago
CJ Horton	8161bc3ab9	backend/remote: clearer error when org read fails ... When we fail to read the organization entitlements, it's not always because the organization doesn't exist; in practice, it's usually due to a misspelled organization name, forgetting to specify the correct hostname, or an invalid API token. Surfacing more information within the error message will help new users debug these issues more effectively.	5 years ago
Martin Atkins	70fed23be5	lang/funcs: File hashing functions stream data from disk ... Previously our file hashing functions were backed by the same "read file into memory" function we use for situations like "file" and "templatefile", meaning that they'd read the entire file into memory first and then calculate the hash from that buffer. All of the hash implementations we use here can calculate hashes from a sequence of smaller buffer writes though, so there's no actual need for us to create a file-sized temporary buffer here. This, then, is a small refactoring of our underlying function into two parts, where one is responsible for deciding the actual filename to load opening it, and the other is responsible for buffering the file into memory. Our hashing functions can then use only the first function and skip the second. This then allows us to use io.Copy to stream from the file into the hashing function in smaller chunks, possibly of a size chosen by the hash function if it happens to implement io.ReaderFrom. The new implementation is functionally equivalent to the old but should use less temporary memory if the user passes a large file to one of the hashing functions.	5 years ago
Martin Atkins	42e0985839	command: use -lock=false consistently in -help output ... Previously the docs for this were rather confusing because they showed an option to turn _on_ state locking, even though it's on by default. Instead, we'll now show -lock=false in all cases and document it as _disabling_ the default locking. While working on this I also noticed that the equivalent docs on the website were differently inconsistent. I've not made them fully consistent here but at least moreso than they were before.	5 years ago
Martin Atkins	ed121321c6	website: Revamp the "terraform state mv" page ... My original motivation here was to add the previously-missing -dry-run option to the list of options However, while in the area I noticed that this command hasn't had a documentation refresh for a while and so I took the opportunity to update it to match with our current writing style and terminology used in other parts of the documentation, and so I've rewritten prose elsewhere on the page to hopefully give the same information in a way that fits in better with concepts discussed elsewhere in the documentation, and also to try to add some additional context to connect this information with what we've described in other places. This rewrite also drops the example of moving from one "state file" to another, because that's a legacy usage pattern that isn't supported when using remote backends, and we recommend most folks to use remote backends so it's strange to show an example that therefore won't work for most people. Rather than adding additional qualifiers to that example I chose to just remove it altogether, because we've generally been working to de-emphasize these legacy local backend command line options elsewhere in the documentation.	5 years ago
Martin Atkins	ea089d06f1	website: Revamp the "terraform state rm" page ... My original motivation here was to add the previously-missing -dry-run option to the list of options However, while in the area I noticed that this command hasn't had a documentation refresh for a while and so I took the opportunity to update it to match with our current writing style and terminology used in other parts of the documentation, and so I've rewritten prose elsewhere on the page to hopefully give the same information in a way that fits in better with concepts discussed elsewhere in the documentation, and also to try to add some additional context to connect this information with what we've described in other places.	5 years ago
Martin Atkins	0aa0e00fdc	website: Backend docs link to new .gitignore anchor ... The Git book seems to be using a different anchor format now, and so this link was previously effectively linking to the page as a whole rather than to the specific section we're trying to refer to.	5 years ago
Martin Atkins	874f1abb2b	cli+website: -ignore-remote-version docs and other cleanup ... We previously had only very short descriptions of what -ignore-remote-version does due to having the documentation for it inline on many different command pages and -help output. Instead, we'll now centralize the documentation about this argument on the remote backend page, and link to it or refer to it from all other locations. This then allows us to spend more words on discussing what Terraform normally does _without_ this option and warning about the consequences of using it. This continues earlier precedent for some local-backend-specific options which we also don't recommend for typical use. While this does make these options a little more "buried" than before, that feels justified given that they are all "exceptional use only" sort of options where users ought to learn about various caveats before using them. While there I also took this opportunity to fix some earlier omissions with the local-backend-specific options and a few other minor consistency tweaks.	5 years ago
Roger Berlind	b6885923d0	website: Add link to Modules in Package Sub-directories (#27980) ... * Add link to Modules in Package Sub-directories Add link to "Modules in Package Sub-directories" section at top of page * Fix broken links * Update aws link, fixes missing anchor linkcheck Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>	5 years ago
Alisdair McDiarmid	4a93399c60	Merge pull request #28665 from hashicorp/alisdair/communicator-bastion-port-type ... communicator/ssh: Fix crash with SSH bastion port	5 years ago
Alisdair McDiarmid	fa676bde7c	core: Use number for port in connection schema ... This commit makes two changes to the provisioner connection block code: - Change the `port` argument type from string to number, which is technically more correct and consistent with `bastion_port`; - Use `uint16` as the struct member type for both ports instead of `int`, which gets us free range validation from the gocty package. Includes a test of the validation message when the port number is an invalid integer.	5 years ago
Martin Atkins	b402fd9d3a	command/views: Remove command-specific runningInAutomation ... We now have RunningInAutomation has a general concern in views.View, so we no longer need to specify it for each command-specific constructor separately. For this initial change I focused only on changing the exported interface of the views package and let the command-specific views go on having their own unexported fields containing a copy of the flag because it made this change less invasive and I wasn't feeling sure yet about whether we ought to have code within command-specific views directly access the internals of views.View. However, maybe we'll simplify this further in a later commit if we conclude that these copies of the flag are burdensome. The general version of this gets set directly inside the main package, which might at some future point allow us to make the command package itself unaware of this "running in automation" idea and thus reinforce that it's intended as a presentation-only thing rather than as a behavioral thing, but we'll save more invasive refactoring for another day.	5 years ago
Martin Atkins	bf396b5f1b	command/views: main View type aware if it's running in automation ... This "running in automation" idea is a best effort thing where we try to avoid printing out specific suggestions of commands to run in the main workflow when the user is running Terraform inside a wrapper script or other automation, because they probably don't want to bypass that automation. This just makes that information available to the main views.View type, so we can then make use of it in the implementation of more specialized view types that embed views.View. However, nothing is using it as of this commit. We'll use it in later commits.	5 years ago
Martin Atkins	6f68065326	website: Explicit example of for_each chaining between resources ... This pattern follows as a natural consequence of how for_each is defined, but I've noticed from community forum Q&A that newcomers often don't immediately notice the connection between what for_each expects as input and what a for_each resource produces as a result, so my aim here is to show a short example of that in the hope of helping folks see the link here and get ideas on how to employ the technique in other situations.	5 years ago
Martin Atkins	b38f3301d1	command/views: Remove baseState argument from plan-rendering views ... In practice the current implementation isn't actually using this, and if we need access to states in future we can access them in either the plan.PriorState or plan.PrevRunState fields, depending on which stage we want a state snapshot of.	5 years ago
Martin Atkins	0ee76b92b8	core: Update working state for resource instances in refresh-only mode ... Previously in refresh-only mode we were skipping making any updates to the working state at all. That's not correct, though: if the state upgrade or refresh steps detected changes then we need to at least commit _those_ to the working state, because those can then be detected by downstream objects like output values.	5 years ago
Martin Atkins	0f936b9d80	plans/planfile: Read state snapshots as part of reading a plan ... Our model for plans/planfile has unfortunately grown inconsistent with changes to our modeling of plans.Plan. Originally we considered the plan "header" and the planned changes as an entirely separate artifact from the prior state, but we later realized that carrying the prior state around with the plan is important to ensuring we always have enough context to faithfully render a plan to the user, and so we added the prior state as a field of plans.Plan. More recently we've also added the "previous run state" to plans.Plan for similar reasons. Unfortunately as a result of that modeling drift our ReadPlan method was silently producing an incomplete plans.Plan object, causing use-cases like "terraform show" to produce slightly different results due to the plan object not round-tripping completely. As a short-term tactical fix, here we add state snapshot reading into the ReadPlan function. This is not an ideal solution because it means that in the case of applying a plan, where we really do need access to the state _file_, we'll end up reading the prior state file twice. However, the goal here is only to heal the modelling quirk with as little change as possible, because we're not currently at a point where we'd be willing to risk regressions from a larger refactoring.	5 years ago
Alisdair McDiarmid	0cbe4d8efb	communicator/ssh: Fix crash with SSH bastion port ... The connection block schema defines the bastion_port argument as a number, but we were incorrectly trying to convert it from a string. This commit fixes that by attempting to convert the cty.Number to the int result type, returning the error on failure. An alternative approach would be to change the bastion_port argument in the schema to be a string, matching the port argument. I'm less sure about the secondary effects of that change, though.	5 years ago
Rachel Sharp	87c9e78666	Merge pull request #28604 from hashicorp/res-lifecycle-tutorial ... Add link to lifecycle tutorial	5 years ago
Alisdair McDiarmid	fb53259907	Merge pull request #28644 from hashicorp/alisdair/length-lookup-marks-fixes ... Improve marks support for `length` and `lookup`	5 years ago
Alisdair McDiarmid	dbe5272931	functions: Improve marks support for lookup ... Several changes to lookup to improve how we handle marked values: - If the entire collection is marked, preserve the marks on any result (whether successful or fallback) - If a returned value from the collection is marked, preserve the marks from only that value, combined with any overall collection marks - Retain marks on the fallback value when it is returned, combined with any overall collection marks - Include marks on the key in the result, as otherwise the result it ends up selecting could imply what the sensitive value was - Retain collection marks when returning an unknown value for a not wholly-known collection See also https://github.com/zclconf/go-cty/pull/98	5 years ago
James Bardin	3252df4b91	Merge pull request #28640 from hashicorp/jbardin/configload-diags ... Don't try to build the config if there were errors loading	5 years ago
James Bardin	ced676d50d	fixed configloader doesn't add unnecessary diags	5 years ago
Alisdair McDiarmid	e0c6b3fcda	functions: Improve marks support for length ... Similar to cty's implementation, we only need to preserve marks from the value itself, not any nested values it may contain. This means that taking the length of an umarked list with marked elements results in an unmarked number.	5 years ago
James Bardin	655f18c393	don't build a config if it didn't load properly	5 years ago
Martin Atkins	8d4d333efe	core: If we refresh during orphan processing, use the result for planning ... If we don't do this then we can create a situation where refresh detects that an object already doesn't exist but we plan to destroy it anyway, rather than returning "no changes" as expected.	5 years ago
James Bardin	ecd030eb26	Merge pull request #28624 from hashicorp/jbardin/schema-value-marks ... null check in ValueMarks	5 years ago
James Bardin	d76a8fcf6c	null check in ValueMarks	5 years ago
Alisdair McDiarmid	91cdde1d67	Merge pull request #28608 from hashicorp/alisdair/json-plan-replace-paths ... jsonplan: Add replace_paths	5 years ago
Martin Atkins	3443621227	core: Track both previous run state and refresh state during planning ... The "previous run state" is our record of what the previous run of Terraform considered to be its outcome, but in order to do anything useful with that we must ensure that the data inside conforms to the current resource type schemas, which might be different than the schemas that were current during the previous run if the relevant provider has since been upgraded. For that reason then, we'll start off with the previous run state set exactly equal to what was saved in the prior snapshot (modulo any changes that happened during a state file format upgrade) but then during our planning operation we'll overwrite individual resource instance objects with the result of upgrading, so that in a situation where we successfully run plan to completion the previous run state should always have a compatible schema with the "prior state" (the result of refreshing) for managed resources, and thus the caller can meaningfully compare the two in order to detect and describe any out-of-band changes that occurred since the previous run.	5 years ago
Martin Atkins	7c6e78bcb0	plans: Track both the previous run and prior states in the plan ... Until now we've not really cared much about the state snapshot produced by the previous Terraform operation, except to use it as a jumping-off point for our refresh step. However, we'd like to be able to report to an end-user whenever Terraform detects a change that occurred outside of Terraform, because that's often helpful context for understanding why a plan contains changes that don't seem to have corresponding changes in the configuration. As part of reporting that we'll need to keep track of the state as it was before we did any refreshing work, so we can then compare that against the state after refreshing. To retain enough data to achieve that, the existing Plan field State is now two fields: PrevRunState and PriorState. This also includes a very shallow change in the core package to make it populate something somewhat-reasonable into this field so that integration tests can function reasonably. However, this shallow implementation isn't really sufficient for real-world use of PrevRunState because we'll actually need to update PrevRunState as part of planning in order to incorporate the results of any provider-specific state upgrades to make the PrevRunState objects compatible with the current provider schema, or else our diffs won't be valid. This deeper awareness of PrevRunState in Terraform Core will follow in a subsequent commit, prior to anything else making use of Plan.PrevRunState.	5 years ago
Kristin Laemmert	5f30efe857	command tests: plan and init (#28616) ... * command/init: add test for reconfigure * command/plan: adding tests * command/apply: tests * command: show and refresh tests	5 years ago
James Bardin	1e3a60c7ac	Merge pull request #28606 from hashicorp/jbardin/providers-in-modules ... Validate passing default providers through modules	5 years ago
Alisdair McDiarmid	0ab7d901d9	Merge pull request #28607 from hashicorp/alisdair/cty-1.8.3 ... Upgrade cty to 1.8.3	5 years ago
Alisdair McDiarmid	b0f44fc293	go get github.com/zclconf/go-cty@v1.8.3	5 years ago
Alisdair McDiarmid	a5b7394f9a	command/jsonplan: Add replace_paths ... The set of paths which caused a resource update to require replacement has been stored in the plan since 0.15.0 (#28201). This commit adds a simple JSON representation of these paths, allowing consumers of this format to determine exactly which paths caused the resource to be replaced. This representation is intentionally more loosely encoded than the JSON state serialization of paths used for sensitive attributes. Instead of a path step being represented by an object with type and value, we use a more-JavaScripty heterogenous array of numbers and strings. Any practical consumer of this format will likely traverse an object tree using the index operator, which should work more easily with this format. It also allows easy prefix comparison for consumers which are tracking paths. While updating the documentation to include this new field, I noticed that some others were missing, so added them too.	5 years ago
James Bardin	168296b507	validate that modules name providers passed to mod ... Passing a provider into a module requires that it be named within the module. This would previously pass validation, however core would fail to resolve the provider resulting in an unclear "provider not found" error.	5 years ago
Rachel Sharp	c302fa507f	Add link to lifecycle tutorial	5 years ago
Alisdair McDiarmid	53fab10b26	Merge pull request #28598 from hashicorp/alisdair/fix-diagnostic-snippet-crash ... cli: Fix diagnostic snippet crash	5 years ago
Kristin Laemmert	3679de0630	command/format: fix repetitive "unchanged attribute hidden" message (#28589) ... writeNestedAttrDiff and writeAttrDiff were both printing the "unchanged attribute" message. This removes one of the redundant prints. Fixing this led me (in a very roundabout way) to realize that NestedType attributes were printing a sum total of unchanged attributes, including those in entirely unchanged elements, while *not* printing the total of unchanged elements. I added the necessary logic to count and print the number of unchanged elements for maps and lists.	5 years ago
Chris Arcand	5813620412	Merge pull request #28594 from hashicorp/go-tfe-update ... Update go-tfe client to v0.14.0	5 years ago
Alisdair McDiarmid	25f99857cf	cli: Fix crash with invalid JSON diagnostics ... If a JSON diagnostic value has a highlight end offset which is before the highlight start offset, this would previously panic. This commit adds a normalization step to prevent the crash.	5 years ago
Alisdair McDiarmid	3a9b369b43	views/json: Fix diag crash with invalid highlight ... Some diagnostic sources (I'm looking at you, HCL) fail to set the end of the subject range. This is a bug in those code paths, but we can ensure that we generate valid JSON diagnostics by checking for it here. By doing so before the range normalization, we ensure that we generate a unit width highlight whenever possible, so that at least something useful is displayed.	5 years ago
Alisdair McDiarmid	e9c9092c40	Fix missing trailing newline	5 years ago
Chris Arcand	2756f5ed08	Update Terraform Cloud/Enterprise client to v0.14.0	5 years ago
Martin Atkins	c63c06d3c4	core: -replace to emit only one warning for incomplete address ... If the user gives an index-less address for a resource that expects instance keys then previously we would've emitted one error per declared instance of the resource, which is overwhelming and not especially helpful. Instead, we'll deal with that check prior to expanding resources into resource instances, and thus we can report a single error which talks about all of the instances at once. This does unfortunately come at the expense of splitting the logic for dealing with the "force replace" addresses into two places, which will likely make later maintenance harder. In an attempt to mitigate that, I've included a comment in each place that mentions the other place, which hopefully future maintainers will keep up-to-date if that situation changes.	5 years ago
Martin Atkins	1d3e34e35e	command: New -replace=... planning option ... This allows a similar effect to pre-tainting an object but does the action within the context of a normal plan and apply, avoiding the need for an intermediate state where the old object still exists but is marked as tainted. The core functionality for this was already present, so this commit is just the UI-level changes to make that option available for use and to explain how it contributed to the resulting plan in Terraform's output.	5 years ago