23036 Commits (383bc98f5ca15fc43f07dcbf567dd7cd1ffe2e33)

 

All Branches   

Search

Author	SHA1	Message	Date
Tom Harvey	383bc98f5c	backend/azurerm: Support for authenticating using the Azure CLI (#19465) ... * Upgrading to 2.0.0 of github.com/hashicorp/go-azure-helpers * Support for authenticating using Azure CLI * backend/azurerm: support for authenticating using the Azure CLI	7 years ago
Sander van Harmelen	a475b766de	Update CHANGELOG.md	7 years ago
James Bardin	8ab5698e2a	Merge pull request #19587 from hashicorp/jbardin/safe-appends ... don't modify argument slices	7 years ago
Sander van Harmelen	ecc93c9889	Merge pull request #19589 from hashicorp/svh/f-service-discovery ... core: enhance service discovery	7 years ago
Sander van Harmelen	a5a2156584	core: enhance service discovery ... This PR improves the error handling so we can provide better feedback about any service discovery errors that occured. Additionally it adds logic to test for specific versions when discovering a service using `service.vN`. This will enable more informational errors which can indicate any version incompatibilities.	7 years ago
Chris Griggs	8ed484ee1a	Merge pull request #19594 from cgriggs01/cgriggs01-community ... [Website] adding six new community providers	7 years ago
cgriggs01	41897bb437	six new community providers	7 years ago
Radek Simko	c77fe806f5	Merge pull request #19590 from hashicorp/t-cmd-format ... command/format: Add tests for ResourceChange renderer	7 years ago
Radek Simko	49e7026bdd	command/format: Add tests for ResourceChange renderer	7 years ago
James Bardin	f408df9da3	update CHANGELOG.md	7 years ago
James Bardin	3d6ec09a83	Merge pull request #19552 from olindata/bugfix/setting-sets-in-list ... helper/schema: Fix setting a set in a list caused error	7 years ago
James Bardin	b5de50c0a2	don't modify argument slices ... There were a couple spots where argument slices weren't being copied before `append` was called, which could possibly modify the caller's slice data.	7 years ago
Martin Atkins	b1ed146931	core: Attach schemas to nodes created by ResourceCountTransformer ... Previously we were only doing this in the case where count wasn't set at all.	7 years ago
Martin Atkins	f9fef56167	helper/resource: print full diagnostics for operation errors in tests ... This causes the output to include additional helpful context such as the values of variables referenced in the config, etc. The output is in the same format as normal Terraform CLI error output, though we don't retain a source code cache in this codepath so it will not include a source code snippet.	7 years ago
Martin Atkins	53926ea581	plugin: Fix incorrect trace log message in provider Close ... Was incorrectly printing out "PlanResourceChange" instead of "Close".	7 years ago
Martin Atkins	f93f7e5b5c	configs/configupgrade: Remove redundant list brackets ... In early versions of Terraform where the interpolation language didn't have any real list support, list brackets around a single string was the signal to split the string on a special uuid separator to produce a list just in time for processing, giving expressions like this: foo = ["${test_instance.foo.*.id}"] Logically this is weird because it looks like it should produce a list of lists of strings. When we added real list support in Terraform 0.7 we retained support for this behavior by trimming off extra levels of list during evaluation, and inadvertently continued relying on this notation for correct type checking. During the Terraform 0.10 line we fixed the type checker bugs (a few remaining issues notwithstanding) so that it was finally possible to use the more intuitive form: foo = "${test_instance.foo.*.id}" ...but we continued trimming off extra levels of list for backward compatibility. Terraform 0.12 finally removes that compatibility shim, causing redundant list brackets to be interpreted as a list of lists. This upgrade rule attempts to identify situations that are relying on the old compatibility behavior and trim off the redundant extra brackets. It's not possible to do this fully-generally using only static analysis, but we can gather enough information through or partial type inference mechanism here to deal with the most common situations automatically and produce a TF-UPGRADE-TODO comment for more complex scenarios where the user intent isn't decidable with only static analysis. In particular, this handles by far the most common situation of wrapping list brackets around a splat expression like the first example above. After this and the other upgrade rules are applied, the first example above will become: foo = test_instance.foo.*.id	7 years ago
Martin Atkins	d9603d5bc5	configs/configupgrade: Do type inference with input variables ... By collecting information about the input variables during analysis, we can return approximate type information for any references to those variables in expressions. Since Terraform 0.11 allowed maps of maps and lists of lists in certain circumstances even though this was documented as forbidden, we conservatively return collection types whose element types are unknown here, which allows us to do shallow inference on them but will cause us to get an incomplete result if any operations are performed on elements of the list or map value.	7 years ago
Martin Atkins	a2d9634dbf	configs/configupgrade: Expression type inference ... Although we can't do fully-precise type inference with access only to a single module's configuration, we can do some approximate inference using some clues within the module along with our resource type schemas. This depends on HCL's ability to pass through type information even if the input values are unknown, mapping our partial input type information into partial output type information by evaluating the same expressions. This will allow us to do some upgrades that require dynamic analysis to fully decide, by giving us three outcomes: needed, not needed, or unknown. If it's unknown then that'll be our prompt to emit a warning for the user to make a decision.	7 years ago
Martin Atkins	e63a1dfb96	lang: EvalExpr only convert if wantType is not dynamic ... This actually seems to be a bug in the underlying cty Convert function since converting to cty.DynamicPseudoType should always just return the input verbatim, but it seems like it's actually converting unknown values of any type to be cty.DynamicVal, losing the type information. We should eventually fix this in cty too, but having this extra check in the Terraform layer is harmless and allows us to make progress without context-switching.	7 years ago
Martin Atkins	bf25e12792	vendor: upgrade github.com/hashicorp/hcl2 ... This includes a change to improve the precision of types returned from splat expressions when a source value is unknown.	7 years ago
--global	32d0c6faf9	release: clean up after v0.12.0-alpha4	7 years ago
--global	2c36829d32	v0.12.0-alpha4	7 years ago
Martin Atkins	55469cd416	helper/resource: Get schemas from Terraform context ... Previously the test harness was preloading schemas from the providers before running any test steps. Since terraform.NewContext already deals with loading provider schemas, we can instead just use the schemas it loaded for our shimming needs, avoiding the need to reimplement the schema lookup behavior and thus the need to create a throwaway provider instance with which to do it.	7 years ago
Martin Atkins	a4991c5780	helper/resource: Create a separate provider instance each call ... Previously we were running the factory function only once when constructing the provider resolver, which means that all contexts created from that resolver share the same provider instance. Instead now we will call the given factory function once for each instantiation, ensuring that each caller ends up with a separate object as would be the case in real-world use.	7 years ago
Sander van Harmelen	70689f5aa1	Merge pull request #19555 from hashicorp/svh/f-entitlements ... backend/remote: use entitlements to select backends	7 years ago
Martin Atkins	e8f9fad0e3	states/statemgr: use -mod=vendor to run the state locking helper ... This ensures that we test using the same source as we're using everywhere else, and more tactically also ensures that when running in Travis-CI we won't try to download all of the dependencies of Terraform during this test. In the long run we will look for a more global solution to this, rather than adding this to all of our embedded "go" command calls directly, but this is intended as a low-risk solution to get the build working again in the mean time.	7 years ago
--global	cd2dd4715d	release: clean up after v0.12.0-alpha3	7 years ago
--global	7200ed2b61	v0.12.0-alpha3	7 years ago
James Bardin	9831b56f2e	Merge pull request #19560 from hashicorp/jbardin/go-plugin ... go plugin update	7 years ago
James Bardin	98870fadb1	Merge pull request #19544 from hashicorp/jbardin/import-tests ... Fix provider import tests	7 years ago
James Bardin	1d4c8403a2	enable Auto mTLS in go-plugin	7 years ago
James Bardin	1178c799b6	update vendor from go.mod	7 years ago
James Bardin	bf71b89a78	update go-plugin to our provisional alpha branch	7 years ago
Martin Atkins	9336b54dc0	vendor: Fix dependency on github.com/kardianos/osext ... In 98c8ac0862 I merged a change to the vendored code for this module but didn't spot that it didn't also update the dependency metadata to match. Here we just catch up the metadata to match the vendored version, with no change to the vendored code itself.	7 years ago
Chris Griggs	40a54cbb7f	Merge pull request #19562 from cgriggs01/cgriggs01-skytap ... [Website] Skytap provider links	7 years ago
cgriggs01	808c76fa9b	Add skytap links	7 years ago
James Bardin	ac63d2995f	Merge pull request #19559 from hashicorp/jbardin/resource-test-shim ... don't add numeric indexes to resources with a count of 0	7 years ago
Brian Flad	ef0f66a7d4	Update CHANGELOG for #19548	7 years ago
Brian Flad	a3b327dbac	Merge pull request #19548 from hashicorp/b-helper-schema-NewComputed-propagation ... helper/schema: Always propagate NewComputed for previously zero value primitive type attributes	7 years ago
James Bardin	7d296f752c	don't add numeric indexes to resources with a count of 0	7 years ago
Martin Atkins	8112f589c1	configs/configupgrade: Pass through connection and provisioner blocks ... This is a temporary implementation of these rules just so that these can be passed through verbatim (rather than generating an error) while we do testing of other features. A subsequent commit will finish these with their own custom rulesets.	7 years ago
Martin Atkins	028b5ba34e	configs/configupgrade: Upgrade depends_on in resources and outputs	7 years ago
Martin Atkins	ef017345f1	configs/configupgrade: Upgrade the resource "lifecycle" nested block ... The main tricky thing here is ignore_changes, which contains strings that are better given as naked traversals in 0.12. We also handle here mapping the old special case ["*"] value to the new "all" keyword.	7 years ago
Martin Atkins	4b52148262	configs/configupgrade: Upgrade provider addresses ... Both resource blocks and module blocks contain references to providers that are expressed as short-form provider addresses ("aws.foo" rather than "provider.aws.foo"). These rules call for those to be unwrapped as naked identifiers during upgrade, rather than appearing as quoted strings. This also introduces some further rules for other simpler meta-arguments that are required for the test fixtures for this feature.	7 years ago
Martin Atkins	ea3b8b364c	configs/configupgrade: Initial passthrough mapping for module blocks ... Some further rules are required here to deal with the meta-arguments we accept inside these blocks, but this is good enough to pass through most module blocks using the standard attribute-expression-based mapping.	7 years ago
Martin Atkins	4b5d31d35d	configs/configupgrade: Rules-based upgrade for "locals" block ... Previously we were handling this one as a special case, effectively duplicating most of the logic from upgradeBlockBody. By doing some prior analysis of the block we can produce a "rules" that just passes through all of the attributes as-is, allowing us to reuse upgradeBlockBody. This is a little weird for the locals block since everything in it is user-selected names, but this facility will also be useful in a future commit for dealing with module blocks, which contain a mixture of user-chosen and reserved argument names.	7 years ago
Sander van Harmelen	9062d887b8	backend/remote: use entitlements to select backends ... Use the entitlements to a) determine if the organization exists, and b) as a means to select which backend to use (the local backend with remote state, or the remote backend).	7 years ago
Sander van Harmelen	03ac6ec774	go-mod: update the `go-tfe` dependency	7 years ago
Farid Neshat	44a45b7332	helper/schema: Fix setting a set in a list ... The added test in this commit, without the fix, will make d.Set return the following error: `Invalid address to set: []string{"ports", "0", "set"}` This was due to the fact that setSet in feild_writer_map tried to convert a slice into a set by creating a temp set schema and calling writeField on that with the address(`[]string{"ports", "0", "set"}"` in this case). However the temp schema was only for the set and not the whole schema as seen in the address so, it should have been `[]string{"set"}"` so it would align with the schema. This commits adds another variable there(tempAddr) which will only contain the last entry of the address that would be the set key, which would match the created schema This commit potentially fixes the problem described in #16331	7 years ago
Brian Flad	1e81a3e7fa	helper/schema: Always propagate NewComputed for previously zero value primative type attributes ... When the following conditions were met: * Schema attribute with a primative type (e.g. Type: TypeString) and Computed: true * Old state of attribute set to zero value for type (e.g. "") * Old state ID of resource set to non-empty (e.g. existing resource) Attempting to use CustomizeDiff with SetNewComputed() would result in the difference previously being discarded. This update ensures that previous zero values or resource existence does not influence the propagation of the computed update. Previously: ``` --- FAIL: TestSetNewComputed (0.00s) --- FAIL: TestSetNewComputed/NewComputed_should_always_propagate (0.00s) resource_diff_test.go:684: Expected (*terraform.InstanceDiff)(0xc00051cea0)({ mu: (sync.Mutex) { state: (int32) 0, sema: (uint32) 0 }, Attributes: (map[string]*terraform.ResourceAttrDiff) (len=1) { (string) (len=3) "foo": (*terraform.ResourceAttrDiff)(0xc0003dcec0)({ Old: (string) "", New: (string) "", NewComputed: (bool) true, NewRemoved: (bool) false, NewExtra: (interface {}) <nil>, RequiresNew: (bool) false, Sensitive: (bool) false, Type: (terraform.DiffAttrType) 0 }) }, Destroy: (bool) false, DestroyDeposed: (bool) false, DestroyTainted: (bool) false, Meta: (map[string]interface {}) <nil> }) , got (*terraform.InstanceDiff)(0xc00051ce80)({ mu: (sync.Mutex) { state: (int32) 0, sema: (uint32) 0 }, Attributes: (map[string]*terraform.ResourceAttrDiff) { }, Destroy: (bool) false, DestroyDeposed: (bool) false, DestroyTainted: (bool) false, Meta: (map[string]interface {}) <nil> }) --- FAIL: TestSchemaMap_Diff (0.01s) --- FAIL: TestSchemaMap_Diff/79-NewComputed_should_always_propagate_with_CustomizeDiff (0.00s) schema_test.go:3289: expected: *terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff{"foo":*terraform.ResourceAttrDiff{Old:"", New:"", NewComputed:true, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, Meta:map[string]interface {}(nil)} got: <nil> FAIL FAIL github.com/hashicorp/terraform/helper/schema 0.825s ```	7 years ago