terraform

Commit Graph

Author	SHA1	Message	Date
Sarah French	085c53c3f2	docs: Add godoc comments to tests in command package for the init command	1 month ago
Sarah French	827f693e32	test: Update `TestInit_fromModule_dstInSrc` to reflect current behaviour when -from-module references the location of the current directory (#38059 ) * test: Update `TestInit_fromModule_dstInSrc` to use modern `t.Chdir` approach, add context through comments * test: Add context about how `TestInit_fromModule_dstInSrc` has been refactored since it was first created Originally the test's args were []string{".", "foo"} (https://github.com/hashicorp/terraform/pull/547), where the second arg is the directory TF should use as the root directory. Then the test was changed to use []string{"-from-module=.", "foo"} when the -from-module flag was added in `8a7a0a7459`. Finally, the second arg was removed in https://github.com/hashicorp/terraform/pull/27664, and replaced with the use of os.Chdir in this test. * test: Update `TestInit_fromModule_dstInSrc` to define the new behavior of -from-module in this scenario; the current directory is copied once, but not recursively. If you run this test from commit `84f5b863ef` with a debugger we can see that foo is never copied into the current directory foo (./foo/foo is never made). Now, after refactoring ./foo/foo IS made, but it's not copied recursively like in the original issue. * docs: Add comment about emergent behavior when using -chdir with -from-module in this scenario	1 month ago
Radek Simko	1186262c8c	backend/http: Refresh state earlier (align with other backends) (#38033 ) * correct changelog entry for #38027 * backend/http: Refresh state before returning StateMgr This aligns the http backend with the implementation of StateMgr in other remote backends, which in turn enables easier testing of higher level logic that relies on certain backend behaviours. * backend/http: Refactor TestHTTPBackend to allow custom method implementations * add regression test for PR 38027	1 month ago
Mark Hall	7029dfac86	Fix nil pointer dereference in backend state migration (#38028 ) * fix: handle all StateMgr errors during backend migration Fixes a nil pointer dereference panic that occurs during backend migration when StateMgr returns an error other than ErrDefaultWorkspaceNotSupported. The bug occurred because the code only checked for the specific ErrDefaultWorkspaceNotSupported error. When any other error occurred (such as permission errors like storage.objects.get access denied), destinationState remained nil, but the code continued and attempted to call destinationState.RefreshState(), causing a panic. This fix adds an else clause to catch and return all other errors from StateMgr, preventing the nil pointer dereference and providing users with a clear error message instead of a crash. Fixes #24100 * Add changelog entry for backend migration nil pointer fix 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>	1 month ago
Michael Yocca	810f497ecd	fix(cloud): cloud backend rendering query warning diags (#38040 )	1 month ago
Jared Baker	0b9a20c7c4	Merge pull request #37940 from vietcgi/fix/s3-backend-fips-env-var-parsing fix: parse boolean env vars in S3 backend correctly	2 months ago
Jared Baker	dc0384e578	chore: switch changelog to `UPGRADE NOTES` kind This is consistent with the `kind` used for previous breaking changes to S3 backend behavior.	2 months ago
Jared Baker	4f53303c12	Merge branch 'main' into fix/s3-backend-fips-env-var-parsing	2 months ago
dependabot[bot]	59b84c820e	build(deps): bump the github-actions-breaking group with 4 updates (#38035 ) Bumps the github-actions-breaking group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/cache](https://github.com/actions/cache), [actions/download-artifact](https://github.com/actions/download-artifact) and [dessant/lock-threads](https://github.com/dessant/lock-threads). Updates `actions/upload-artifact` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](`330a01c490...b7c566a772`) Updates `actions/cache` from 4.3.0 to 5.0.1 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](`0057852bfa...9255dc7a25`) Updates `actions/download-artifact` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](`018cc2cf5b...37930b1c2a`) Updates `dessant/lock-threads` from 5.0.1 to 6.0.0 - [Release notes](https://github.com/dessant/lock-threads/releases) - [Changelog](https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md) - [Commits](`1bf7ec2505...7266a7ce5c`) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-breaking - dependency-name: actions/cache dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-breaking - dependency-name: actions/download-artifact dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-breaking - dependency-name: dessant/lock-threads dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-breaking ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 months ago
Andy Hay	e3263bece0	cleanup: remove stale FIXME in terraform provider (#38031 ) * cleanup: remove stale FIXME in terraform provider Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> * chore: add changelog entry Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> * chore: fix changelog entry format Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> * chore: remove changelog entry (not user facing) Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com> --------- Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com>	2 months ago
dependabot[bot]	16032e16e6	build(deps): bump actions/checkout (#38036 ) Bumps the github-actions-backward-compatible group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 6.0.0 to 6.0.1 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](`1af3b93b68...8e8c483db8`) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions-backward-compatible ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 months ago
Sarah French	193867f060	test: Add E2E test coverage for inspecting a plan file using the `terraform show` command (#38020 )	2 months ago
Tommy O'Keefe	13cccebef0	Merge pull request #38019 from hashicorp/tommy/contribution-guide-ai-updates docs: add link for new AI Usage section to CONTRIBUTING.md TOC	2 months ago
tommyokeefe	14181ad0c6	docs: add link for new AI Usage section to CONTRIBUTING.md TOC	2 months ago
Tommy O'Keefe	e27f9467c8	ocs: update CONTRIBUTING.md to include guidance for AI usage	2 months ago
tommyokeefe	ee446e8920	docs: update CONTRIBUTING.md to include guidance for AI usage	2 months ago
Sarah French	fd7f25120b	PSS: Allow pluggable state store configuration to be read from a plan file (#37957 ) * feat: Allow reading state store configuration from a planfile and using it to prepare a Local backend that uses the state store * test: Assert that we can get and use state store configuration from a plan file * test: Add integration test showing that an apply command can use a plan file to configure and use a state store * test: Add E2E test showing pluggable state storage being used with the full init-plan-apply workflow * feat: A plan file will report the state storage provider among its required providers, if PSS is in use. See the code comment added in this commit. This addition does not impact an apply command as the missing provider will be detected before this code is executed. However I'm making this change so that the method is still accurate is being able to return a complete list of providers needed by the plan. * fix: Include error messages when there is a problem parsing provider or state store config when getting a backend from a planfile * feat: Add trace logs to BackendForLocalPlan indicating when the provider is launched and the state store is configured * chore: Small grammar change in error diagnostic * refactor: Remove suggestions when the plan's state store doesn't match the implementations in the provider * test: Add test coverage of what happens when the contents of a plan file using PSS doesn't match the resources available in the project	2 months ago
Kevin Vu	c36c81431a	fix: validate replace_triggered_by attribute references (#38010 ) * fix: use schema-based validation for replace_triggered_by Fixes #36740 * fix: use change.ProviderAddr for schema lookup	2 months ago
Sarah French	f88d09544e	PSS: Add tests showing `provider` commands being used with PSS (#37959 ) * test: Add E2E test for using pluggable state storage with the `providers` command Note: I've excluded the `terraform providers locks` and `terraform providers mirror` commands as they don't interact with backends. * test: Add integration test for using pluggable state storage with the `providers` command * refactor: Change ioutil.ReadDir to os.ReadDir * test: Add integration test for using pluggable state storage with the `providers schema` command * feat: Allow state store schema's to be included when schemas are marshalled into JSON output * test: Assert that state stores are present in provider schemas returned from `providers schema`. * test: Update existing tests to accommodate state stores being in provider schema output * test: Update E2E test for `providers` commands to be better scoped to testing use of a state store to access and use state when generating output. This complements TestProvidersSchema that tests that state stores in a provider are reflected in the JSON representations of the schemas that the command returns. * chore: Replace `io/ioutil` with `io` in `providers schema` tests	2 months ago
Sarah French	578766bdc0	PSS: Add tests showing `output` and `show` commands being used with PSS (#37894 ) * test: Add E2E test demonstrating `output` command used with PSS * test: Add E2E test demonstrating `show` command used with PSS * docs: Fix code comment * test: Add integration test for using pluggable state storage with the `output` command * test: Add integration test for using pluggable state storage with the `show` command	2 months ago
Sarah French	940fbfb7ed	test: Add more test coverage of `validate` command's interaction with `backend` blocks (#37977 ) * test: Show how the validate command doesn't detect when an unknown backend type is in the config. * test: Minor fixes to error messages when test fails * test: Add some TODOs in code comments These tests are here to define existing behaviour, not define desired behaviour. I wanted to make that clear!	2 months ago
Sarah French	33d54b9a7c	test: Update module used for testing `init`'s `-from-module` feature, so that the test can be run on darwin_arm64 platforms. (#38015 )	2 months ago
hc-github-team-tf-core	e4ffb51022	Cleanup after 1.15.0-alpha20251203 release (#38002 )	2 months ago
Radek Simko	213d133d86	command/meta: Enable migration from PSS to a backend (#37949 ) * command/meta: Enable migration from PSS to a backend * Address PR feedback * Update internal/command/meta_backend.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * meta_backend: Rename stateStore_c_S to stateStore_to_backend --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	2 months ago
Nick Fagerlund	b2aad914f1	stacks: Make path.module and path.root relative, to match documentation (#37982 ) * stacks: Make path.module and path.root relative, to match documentation Previously, we were just handing off the absolute path produced by the sourcebundle struct. But that's no good, because the value doesn't stay consistent between plan and apply when running under tfc-agent. (It uses working directories named after the unique job ID.) It also doesn't match the documentation, which describes these as relative paths. This was preventing people from uploading module-provided files to create aws lambda functions, for example. This commit addresses that by converting the source-bundle provided module path to a relative path (relative to Terraform's working directory). In tfc-agent for stacks runs, that ends up being the directory directly above the sourcebundle directory, and all the paths below that are consistent between plan and apply. * I think this is how the changelog thing works?	2 months ago
Sarah French	f591872699	PSS: Allow pluggable state store configuration to be stored in a plan file (#37956 ) * refactor: Rename Meta's backendState field to backendConfigState This helps with navigating ambiguity around the word backend. The new name should indicate that the value represents a `backend` block, not a more general interpretation of what a backend is. * fix: Only set backendConfigState to synthetic object if it's nil due to a lack of data. Don't change it if pluggable state storage is in use. * feat: Enable recording a state store's details in an Operation, and using that data when creating a plan file. * fix: Include provider config when writing a plan file using pluggable state storage * fix: Having `backendConfigState` be nil may be valid, but it definitely isn't valid for `stateStoreConfigState` to be nil When backendConfigState is nil it means that an implied local backend is in use, i.e. there is no backend block in the config. * test: Add integration test showing that a plan command creates a plan file with the expected state_store configuration data * refactor: Apply suggestion from @radeksimko Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * fix: Allow panics to occur if an unexpected implementation of `backend.Backend` is encountered when managing a state store * docs: Add code comment explaining the current situation with passing backend config state to downstream logic. In future this should be simplified, either via refactoring or changes affecting the implied local backend --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	2 months ago
Daniel Schmidt	2eb22c8435	backport fix to 1.14	2 months ago
Daniel Schmidt	c71e0d736c	add changelog entry	2 months ago
Matej Risek	768b7bd0bc	Add local values walk to walk_dynamic This helps us catch diagnostics in locals that only happen during evaluation Co-authored-by: Mutahhir Hayat <mutahhir.hayat@hashicorp.com> Co-authored-by: Matej Risek <matej.risek@hashicorp.com>	2 months ago
Daniel Schmidt	889d605664	backport this change to 1.14	2 months ago
Daniel Schmidt	37e0194a23	changelog entry	2 months ago
Daniel Schmidt	871e836fc7	failing resource instance apply should keep prior state	2 months ago
stephybun	c9d024062a	Generate Resource Config: set state in proto req (#37895 ) * marshal state and set in the proto req for generate resource config * changelog * set state in the proto req for generate resource config in plugin6 * add GRPC tests for GenerateResourceConfig * remove changelog entry since this fix is backported to 1.14	2 months ago
James Pogran	2c075b9f8e	Add component registry source resolution support to Terraform Stacks (#37888 ) * Add component registry source resolution support to Terraform Stacks This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries. The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs. * chore: bump go-slug to v0.18.1 * fix: add case for component final source type * chore: rm space * chore: sync module deps * chore: update testdata with separate bundle * fix: manifest file json obj with trailing comma * Add changelog entry to 1.14 --------- Co-authored-by: Michael Yocca <michael.yocca@hashicorp.com>	2 months ago
Sarah French	a83b7402c2	PSS: Add tests showing `state` subcommands being used with PSS (#37891 ) * test: Add E2E tests for `state list` and `state show` commands * test: Update `mockPluggableStateStorageProvider` to log a warning during tests where the values in `MockStates` aren't compatible with the `ReadStateBytesFn` default function. Make existing test set an appropriate value in `MockStates`. * test: Update `mockPluggableStateStorageProvider` helper to include a resource schema * test: Add command-level test for `state list` showing integration with pluggable state storage code. * test: Add command-level test for `state show` showing integration with pluggable state storage code. * test: Add command-level test for `state pull` showing integration with pluggable state storage code. * test: Add command-level test for `state identities` showing integration with pluggable state storage code. * test: Add command-level test for `state rm` showing integration with pluggable state storage code. * test: Add command-level test for `state mv` showing integration with pluggable state storage code. * test: Add command-level test for `state push` showing integration with pluggable state storage code. * test: Add command-level test for `state replace-provider` showing integration with pluggable state storage code. * test: Change shared test fixture to not be named after a specific command under test. This test fixure is reused across tests that need the config to define a state store but otherwise rely on the mock provider to set up the test scenario. * test: Update test to use shared test fixture * test: Remove redundant test fixture The internal/command/testdata/state-commands-state-store and internal/command/testdata/state-store-unchanged test fixtures are the same. * fix: Re-add logic for setting chunk size in the context of E2E tests using grpcwrap package This was removed, incorrectly, in https://github.com/hashicorp/terraform/pull/37899 * refactor: Let panic happen if there's incompatibility between mock returned from `mockPluggableStateStorageProvider` and the `MockStates` that's been set in the mock * test: Refactor to contain paths in reused variable, remove unnecessary .gitkeep * test: Remove unneeded test code	3 months ago
Sarah French	3eea12a1d8	test: Add test coverage for what validate command checks in resource blocks versus backend blocks. (#37972 ) * test: Fix typo in test name * test: Show how the validate command validates resource blocks using their schema. * test: Show how the validate command doesn't use backends' schemas when validating backend blocks.	3 months ago
Sarah French	0941763d05	test: Add a test that shows a custom workspace being baked-into a planfile (#37917 )	3 months ago
Vasist10	fe70f0a7db	fix: prevent zero-byte remote state writes (#37947 )	3 months ago
Kristin Laemmert	869058f995	chore: add default events to the MockProvider's InvokeAction response (#37961 )	3 months ago
hc-github-team-tf-core	b775ab5209	Prepare before 1.15.0-alpha20251203 release	3 months ago
dependabot[bot]	e8631898c9	build(deps): bump actions/checkout in the github-actions-breaking group (#37951 )	3 months ago
Radek Simko	cd7fe4da84	github/build: Avoid double checkout to prevent errors on upgrade (#37941 )	3 months ago
dependabot[bot]	f1bb0334d3	build(deps): bump the github-actions-backward-compatible group with 2 updates (#37952 ) Bumps the github-actions-backward-compatible group with 2 updates: [actions/setup-go](https://github.com/actions/setup-go) and [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action). Updates `actions/setup-go` from 6.0.0 to 6.1.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](`4469467582...4dc6199c7b`) Updates `docker/setup-qemu-action` from 3.6.0 to 3.7.0 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](`29109295f8...c7c5346462`) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions-backward-compatible - dependency-name: docker/setup-qemu-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions-backward-compatible ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 months ago
Sarah French	9fb91c2229	PSS: Refactor Plan struct to reference `Backend` and `StateStore` via pointers, update calling code (#37946 ) * refactor: Update Plan struct's Backend field to be a pointer * fix: Add some refactorings or protections against nil pointers when accessing the Backend field on a Plan struct * refactor: Update Plan struct's StateStore field to be a pointer, update a nil check in calling code.	3 months ago
Sarah French	64015ca6d2	refactor: let panic arise directly if the provider doesn't implement providers.StateStoreChunkSizeSetter (#37942 )	3 months ago
Sarah French	cf047be4e4	PSS: Use interfaces to configure state stores (#37899 ) * refactor: Move chunk size limit constants to new `chunks` package * refactor: Make `NewPluggable` return a `Pluggable` concrete type, instead of an instance of the `backend.Backend` interface. * refactor: Configure state stores through the backend.Backend interface, instead of directly using methods related to RPCs. This requires changing where we call `SetStateStoreChunkSize`. * docs: Add godocs comment to `StateStoreChunkSizeSetter` interface To summarize, we don't really need the `SetStateStoreChunkSize` method, and instead methods like `(GRPCProvider).ConfigureStateStore` in the `plugin6` package can directly inspect the negotiation process that passes through that code and pull out the chunk size. However that means that that code would also need to implement validation. And that's just `(GRPCProvider).ConfigureStateStore`; what about all the test mocks that are used in different types of test? They would all need to be implemented similarly to GRPCProvider to be good, useful mocks, and then a lot of things that fulfil the provider.Interface interface are coupled to each other. Instead, it's easier to have validation in the `grpcClient` struct's methods in the `remote` package, as that code is common to all scenarios. That code needs a method to 'reach into' the provider.Interface value, so we use the `SetStateStoreChunkSize` method. * chore: Make it clearer that the v6 GRPCProvider implements `SetStateStoreChunkSize` * fix: Remove unnecessary assignment of chunk size I'm surprised that removing this doesn't break E2E tests of PSS that use grpcwrap, but I think there's `plugin6` code that runs in that situation, so maybe chunking is handled elsewhere. * chore: Add panic to try detect unexpected cases when setting chunk size. * feat: Add `providers.StateStoreChunkSizeSetter` implementation to provider-simple-v6 * docs: Update code comments for NewPluggable describing its intended use	3 months ago
Kevin Vu	b62d97ac88	fix: parse boolean env vars in S3 backend correctly Fixes #37601	3 months ago
James Bardin	6ed7151b2c	Merge pull request #37923 from hashicorp/jbardin/nesting-group-schema-fixes fix handling of NestingGroup in the configschema package	3 months ago
Kevin Vu	87b3390189	fix: Make init backend messages JSON-compatible (#37920 ) * fix: Make all init backend messages JSON-compatible Fixes #37911 by converting all backend configuration messages to use the View abstraction, which properly formats output as JSON when the -json flag is used. Previously, certain messages were output directly using the legacy Ui abstraction, bypassing JSON formatting. Changes: - Added 11 new message codes to init.go MessageRegistry with both human and JSON formatted values - Replaced 11 direct m.Ui.Output() calls in meta_backend.go with View abstraction calls - Fixed output in backend_C_r_s(), backend_C_r_S_changed(), backend_c_r_S(), and stateStore_c_S() functions All init tests pass successfully. * docs: Add changelog entry for init JSON backend messages fix * cleanup: Remove unused backend output constants The following constants were moved to init.go as message registry entries and are no longer used in meta_backend.go: - outputBackendMigrateChange - outputBackendMigrateLocal - outputStateStoreMigrateLocal - outputBackendReconfigure - successBackendUnset - successBackendSet	3 months ago
Daniel Schmidt	65a23ed352	action: also set edges to expandable nodes on apply	3 months ago

1 2 3 4 5 ...

34907 Commits (sarah/init-cmd-testing-comments) All Branches Search

34907 Commits (sarah/init-cmd-testing-comments)

All Branches