terraform

Commit Graph

Author	SHA1	Message	Date
Paddy Carver	cec20a41eb	Try updating context tests to cross module boundaries.	6 years ago
Paddy Carver	cf3f03bde6	Fill in provider_meta where it was missing in schema.	6 years ago
Paddy Carver	39b8223262	Add integration tests for provider meta. Add provider meta tests to the builtin test provider.	6 years ago
Paddy Carver	7d14463660	Update in response to review. So thanks to review, we have a few changes all rolled up in one here, to account for a design change. First, the codebase has marched on while we wrote this, meaning we need to refer to providers as addrs.Provider, not as strings. This is for the best, but is a lot of replacing through the codebase. Second, some methods were missing from the provider-side GRPC implementations, so we added those. Third, it turns out that attaching the meta configs to resources in transform_provider wouldn't actually work, because resources aren't guaranteed to be in the same module as the provider config powering them. So we need to attach them in transform_attach_config_resource, not in transform_provider, so they'll be on the right side of the module boundary. Unfortunately, this means we're going to have to stop passing around the provider's provider_meta specifically, and are going to have to pass the entire block, because we don't have the provider data we need when we attach the config to filter out just what we need. We now separate them out in the Eval methods. This, unfortunately, also causes us issues, because we don't have that info already when we call EvalValidate, which means we're either going to need to pipe new info through to it, or we're not going to be able to validate the schema pre-plan-time. There's still a recommendation for an end-to-end test to do, but I'm hopeful.	6 years ago
Paddy Carver	087ed3ec2f	Implement provider meta schema everywher on the client. We returned the ProviderMeta schema from the client on every protocol request, but missed it on ReadResource for some reason. This rectifies that.	6 years ago
Paddy Carver	93ab2881b7	Whitespace fixes.	6 years ago
Paddy Carver	475055299f	Update our test cases to use submodules. Add a submodule to our test configs so we can check that this actually works across module boundaries the way it's intended to. These test configs don't actually do anything yet, our test code needs to be updated to actually check for them, and I'm not sure how to do that just yet, but I'll figure that out.	6 years ago
Paddy Carver	1b83916e96	Fix our transform to compile again. The addrs.AbsProviderConfig.Type changed from a string to an addrs.Provider, so we need to pull the Type out of that. Note that this returns something like "google", not "registry.terraform.io/providers/hashicorp/google" or whatever, which is probably what we want, so we don't get confused if two providers with the same name have module attribution turned on. I left a BUG comment to track that, as I'm not sure what's actually involved in that change.	6 years ago
Paddy Carver	d0c268a800	Fix to use the new addrs.Provider struct. Our tests broke because they need to use the addrs.Provider struct now instead of the string. This updates all our tests to use the new struct.	6 years ago
Paddy	890b006cc8	Delete terraform.tfstate Not sure why this got included.	6 years ago
Paddy Carver	300b054f12	OK but run the tests this time. Fix some panics because I didn't run _all_ the tess, like a dolt.	6 years ago
Paddy Carver	6348dbbcc0	Fix import errors. Introduced some import errors while rebasing. Now they're fixed.	6 years ago
Paddy Carver	f461614ebc	Add documentation for provider_meta.	6 years ago
Paddy Carver	e50b65bd20	Finish tests, fix some error subjects.	6 years ago
Paddy Carver	b657bbdead	Flesh out tests a bit.	6 years ago
Paddy Carver	f5b029f290	Add support for data sources with ProviderMeta. Make sure that ProviderMeta gets sent to providers for RPC calls for data sources.	6 years ago
Paddy Carver	3026036e26	Add test that ProviderMeta is set on Destroy. Test to make sure that destroy ApplyResourceChange requests get the ProviderMeta field set during RPC.	6 years ago
Paddy Carver	8da2511b29	Add support for refresh to ProviderMeta. Make sure to pass ProviderMeta when doing refresh RPC calls.	6 years ago
Paddy Carver	8676b59ee2	Set ProviderMeta during PlanResourceChange. Set the ProviderMeta value when planning resource changes, and add a test to ensure that it's getting set properly.	6 years ago
Paddy Carver	d1febfb1f3	Start supporting ProviderMeta on all RPC calls. We want ProviderMeta information to be available to the provider during all the RPC calls, so extend the protocol to account for that, and fill out all the needed methods.	6 years ago
Paddy Carver	d5b0c9cf09	First provider_meta test written. Figure out how to test provider_meta, and write our first test, a basic check that the value will be delivered as part of the ApplyResourceChange request when set. Still a lot of test cases that need testing.	6 years ago
Paddy Carver	1ac54492d0	Pass provider meta on destroy. We weren't passing provider meta information on destroy, now we attach it to nodes for resource destruction, which should let it get sent along as necessary.	6 years ago
Paddy Carver	f3a950de5b	Make ProviderMeta available in the SDK.	6 years ago
Paddy Carver	5dbd9699f2	Various bug fixes. Actually initialize the ProviderMetas map for the Module when calling configs.NewModules so we don't panic. Check the NodeValidatableResource implements GraphNodeAttachProviderMetaConfigs. When calling terraform.loadProviderSchemas, actually set the ProviderMeta block. Add ProviderMeta to state. For some reason? I don't know why. Fix the ProviderTransformer to use the ProviderConfig.Type instead of String() output for the provider when looking up the ProviderMeta to use.	6 years ago
Paddy Carver	94eaf46732	Better apply-time errors. Now if a provider doesn't support provider_meta and somehow we miss that at validation time, the user will get an error with more details and pointing to the specific provider_meta declaration that is a problem.	6 years ago
Paddy Carver	8cd9e34892	Support for validating provider_meta block. Add the ProviderMeta field to the EvalValidateResource type so we can check that the HCL for the resource's provider's provider_meta block is valid. Add a code note about why we're doing this in the resource block instead of somewhere that makes more sense.	6 years ago
Paddy Carver	546b58befc	First implementation of module attribution. A pass at implementing module attribution ("provider_meta blocks in the terraform block", whatever, it's for module attribution). The general idea is that we're adding a new ProviderMeta struct to our configs package, which is then added to Files, Modules, and parsed as part of the terraform block. The configs.Config type then makes that available to the terraform.ProviderTransformer type, which is already scoped by module. It picks out the ProviderMeta for the provider we need in its Transform method, and checks to see if the node it's working on implements the terraform.GraphNodeAttachProviderMetaConfigs interface, which is a new interface we're adding. It has only one method: AttachProviderMetaConfigs, which is passed a configs.ProviderMeta. We implement this on the terraform.NodeAbstractResource type, storing the passed configs.ProviderMeta in a new property on that struct. That struct is eventually made available to the terraform.NodeApplyableResourceInstance type, and its method evalTreeManagedResources, which creates an EvalApply type. The EvalApply type gets a ProviderMeta type, which is set to the *configs.ProviderMeta obtained from the terraform.NodeAbstractResource available to it. This means that EvalApply now has the raw config values the user entered for the provider_meta block, but we also need a schema; providers can define their own schema for the provider_meta block, and we need that schema to know how to translate what is in the config into a cty.Value, which is what we eventually want here. Fortunately, EvalApply already has access to the provider's schema; we can augment the GetSchema RPC call to pass back the ProviderMeta schema (added to helper/schema.Provider) in addition to resource, data source, and provider schemas. This makes it available, eventually, to EvalApply. Now that EvalApply has both the config values and the schema, we can parse them into a cty.Value. Finally, we augment the ApplyResourceChange RPC call with a ProviderMeta field, which can be populated by EvalApply with the parsed cty.Value, which successfully makes the config values available to the provider. This still needs tests written for it to ensure it works, but no current tests are broken on it and it compiles, which is reassuring.	6 years ago
Martin Atkins	9333b19bd7	Update CHANGELOG.md	6 years ago
Martin Atkins	ff4ea042c2	config: Allow module authors to specify validation rules for variables The existing "type" argument allows specifying a type constraint that allows for some basic validation, but often there are more constraints on a variable value than just its type. This new feature (requiring an experiment opt-in for now, while we refine it) allows specifying arbitrary validation rules for any variable which can then cause custom error messages to be returned when a caller provides an inappropriate value. variable "example" { validation { condition = var.example != "nope" error_message = "Example value must not be \"nope\"." } } The core parts of this are designed to do as little new work as possible when no validations are specified, and thus the main new checking codepath here can therefore only run when the experiment is enabled in order to permit having validations.	6 years ago
Martin Atkins	02576988c1	lang: "try" and "can" functions These are intended to make it easier to work with arbitrary data structures whose shape might not be known statically, such as the result of jsondecode(...) or yamldecode(...) of data from a separate system. For example, in an object value which has attributes that may or may not be set we can concisely provide a fallback value to use when the attribute isn't set: try(local.example.foo, "fallback-foo") Using a "try to evaluate" model rather than explicit testing fits better with the usual programming model of the Terraform language where values are normally automatically converted to the necessary type where possible: the given expression is subject to all of the same normal type conversions, which avoids inadvertently creating a more restrictive evaluation model as might happen if this were handled using checks like a hypothetical isobject(...) function, etc.	6 years ago
Martin Atkins	5771db6696	addrs: Fix infinite recursion in AbsInputVariableInstance.String	6 years ago
Martin Atkins	b62e9a7227	vendor: go get github.com/hashicorp/hcl/v2@v2.3.0 This brings in the new HCL extension functions "try", "can", and "convert", along with the underlying HCL and cty infrastructure that allow them to work.	6 years ago
James Bardin	7500fa7a39	Merge pull request #23822 from hashicorp/jbardin/destroy-resource-deps NodeDestroyResource needs to be referencable	6 years ago
James Bardin	4aa8a1cece	Add GraphNodeNoProvider to skip adding a providers While the NodeDestroyResource type should not be a GraphNodeProviderConsumer, we're going to avoid uncovering more hidden behavior by explicitly skipping provider creation and connections in the provider transformers. This should be removed when more in-depth testing can be done during a major release cycle.	6 years ago
James Bardin	a6cdfad590	NodeDestroyResource needs to be referencable The change in #23696 removed the NodeAbstractResource methods from the NodeDestroyResource type, in order to prevent other resource behaviors, like requesting a provider. While this node type is not directly referenced, it was implicitly ordered against the module cleanup by virtue of being a resource node. Since there's no good entry point to test this ordering at the moment,	6 years ago
Martin Atkins	2aac8cf812	internal/getproviders: Distinguished packed vs. unpacked local packages Our local filesystem mirror mechanism will allow provider packages to be given either in packed form as an archive directly downloaded to disk or in an unpacked form where the archive is extracted. Distinguishing these two cases in the concrete Location types will allow callers to reliably select the mode chosen by the selected installation source and handle it appropriately, rather than resorting to out-of-band heuristics like checking whether the object is a directory or a file.	6 years ago
Martin Atkins	92a58ec438	internal/getproviders: Stub out the two mirror sources In a future commit, these implementations of Source will allow finding and retrieving provider packages via local mirrors, both in the local filesystem and over the network using an HTTP-based protocol.	6 years ago
Martin Atkins	773e38b49c	internal/getproviders: Stub of MultiSource This is an API stub for a component that will be added in a future commit to support considering a number of different installation sources for each provider. These will eventually be configurable in the CLI configuration, allowing users to e.g. mirror certain providers within their own infrastructure while still being able to go upstream for those that aren't mirrored, or permit locally-mirrored providers only, etc.	6 years ago
Martin Atkins	d695956061	internal/getproviders: MemoizeSource for local caching of source responses Some sources make network requests that are likely to be slow, so this wrapper type can cache previous responses for its lifetime in order to speed up repeated requests for the same information.	6 years ago
Martin Atkins	a77bc59c44	internal/getproviders: Package URL should always be absolute Registries backed by static files are likely to use relative paths to their archives for simplicity's sake, but we'll normalize them to be absolute before returning because the caller wouldn't otherwise know what to resolve the URLs relative to.	6 years ago
Martin Atkins	c8f7223adb	internal/getproviders: Source interface for generalization We intend to support installation both directly from origin registries and from mirrors in the local filesystem or over the network. This Source interface will serve as our abstraction over those three options, allowing calling code to treat them all the same.	6 years ago
Martin Atkins	c76260e957	internal/getproviders: Query a provider registry Our existing provider installer was originally built to work with releases.hashicorp.com and later retrofitted to talk to the official Terraform Registry. It also assumes a flat namespace of providers. We're starting a new one here, copying and adapting code from the old one as necessary, so that we can build out this new API while retaining all of the existing functionality and then cut over to this new implementation in a later step. Here we're creating a foundational component for the new installer, which is a mechanism to query for the available versions and download locations of a particular provider. Subsequent commits in this package will introduce other Source implementations for installing from network and filesystem mirrors.	6 years ago
Martin Atkins	eda57670ce	go get github.com/apparentlymart/go-versions@master	6 years ago
Kristin Laemmert	18dd1bb4d6	Mildwonkey/tfconfig upgrade (#23670 ) * deps: bump terraform-config-inspect library * configs: parse `version` in new required_providers block With the latest version of `terraform-config-inspect`, the required_providers attribute can now be a string or an object with attributes "source" and "version". This change allows parsing the version constraint from the new object while ignoring any given source attribute.	6 years ago
Pam Selle	94ab6d00ae	Merge pull request #23815 from pselle/docs/module-depth (docs) Update docs to reflect current behavior for module-depth	6 years ago
tf-release-bot	9df05b4813	Cleanup after v0.12.19 release	6 years ago
tf-release-bot	58dcac4b79	v0.12.19	6 years ago
Martin Atkins	472d958b10	Update CHANGELOG.md	6 years ago
Pam Selle	cd6c93774a	Update docs to reflect current behavior	6 years ago
kmoe	58ef73814e	Merge pull request #23563 from hashicorp/kmoe/automtls Allow disabling plugin AutoMTLS with TF_DISABLE_AUTOMTLS env var	6 years ago

1 2 3 4 5 ...

25236 Commits (paddy_module_attribution_tmp) All Branches Search

25236 Commits (paddy_module_attribution_tmp)

All Branches