35341 Commits (mildwonkey/import-in-module)

 

All Branches   

Search

Author	SHA1	Message	Date
Kristin Laemmert	de3cfdad5f	we don't have module instances during validate, so nested import validation needs to wait	7 hours ago
Kristin Laemmert	a8010ba8d0	typo	8 hours ago
Kristin Laemmert	e085a3c180	use the correct context when evaluating imports	8 hours ago
Kristin Laemmert	9d74c3014f	changelog	8 hours ago
Kristin Laemmert	2ec7f3996f	figure out a deferrel related test and maybe found a bug?	8 hours ago
Kristin Laemmert	58c07f7392	copyrightfix	8 hours ago
Kristin Laemmert	044a9ad3a7	feat(import): support import blocks inside child modules	8 hours ago
Sarah French	2c125d7952	Make `validation -json` command produce JSON output when argument parsing raises an error ... * refactor: Put existing test into subtest * fix: Make `validation -json` command produce JSON output when argument parsing raises an error	1 day ago
Sarah French	7e3f57b40b	test: Update test helper `newMockProviderSourceUsingTestHttpServer` to be able to serve multiple providers and multiple provider versions (#38415) ... * test: Update test helper `newMockProviderSourceUsingTestHttpServer` to be able to serve multiple providers and multiple provider versions.	1 day ago
Daniel Banck	d6278dff8c	Add changelog	2 days ago
Daniel Banck	7c828ce3c0	Add test case for validate JSON diags	2 days ago
Daniel Banck	50ac6cf0e3	Fix `validate` not returning JSON for early diagnostics ... Errors during initializing the config loader and collecting variable values were printed as human readable message even if `-json` was specified. This PR fixes this behavior and turns both errors into JSON.	2 days ago
Daniel Banck	67cfc2a556	Add changelogs	2 days ago
Daniel Banck	108514e337	Ignore key expiration errors on stacks plugin installation	2 days ago
Sarah French	694ed4a33d	Add machine-readable JSON output to the `workspace list` command (#38397) ... * feat: Add `-json` flag to the `workspace list` command * feat: Implement JSON view for `workspace list`, connect to -json flag, add tests defining new command output * Add change file * Address reviewer feedback	2 days ago
Daniel Banck	97265cf46e	Add changelog	5 days ago
Daniel Banck	7554bda28e	Fix `fmt` for `.tfquery.hcl` files ... Formatting support for these files was still gated behind an experimental flag. This PR removes the flag and enables query file formatting by default.	5 days ago
Sarah French	b4c5234c98	chore: Remove unused `DefaultWorkspaceCreatedMessage` and `defaultWorkspaceCreatedInfo` (#38394) ... These should have been removed as part of https://github.com/hashicorp/terraform/pull/38281	5 days ago
Sarah French	c975e0cd78	Refactor `workspace list` human output to use a views-like architecture, so adding JSON output is possible without breaking changes (#38392) ... * test: Add a test that asserts human output from workspace commands with colour enabled or disabled * refactor: Update `workspace list` to use cli.Ui in a Views-like way for human output. Update how output is returned by the command to use a single List method. * refactor: Make `workspace list` command parse its arguments using the `arguments` package * refactor: Replace use of `ModulePath` with ` c.WorkingDir.RootModuleDir()` to separate concerns * test: Update tests that feature the `workspace list` command to include a WorkingDir value. This is necessary after the changes in b32b60f6a7854c8f891ef2d78fd02536093ad590 * feat: Detect unexpected arguments and flags using the arguments package. * refactor: Remove duplicate call to c.View.Configure, add code comments explaining code. * fix: Make sure argument parsing errors are handled as soon as the view is usable. * test: Update TestWorkspace_extraArgError to account for new validation via the arguments package * fix: Update outdated copyright headers * test: Update test name * refactor: Reintroduce the old behaviour when unexpected positional arguments were present by using a specific ParseWorkspaceList method	6 days ago
Sarah French	a28750d8d1	PSS: Remove handling of state migrations including PSS from the `init` command (#38388) ... * feat: Any state migration situations involving PSS are now resolved through init -reconfigure or the new state migrate command. Also, remove methods and structs that aren't used anymore: stateStore_to_backend, backend_to_stateStore, stateStore_changed, removeLocalState, errStateStoreClearSaved * test: Fix test log contents to reference correct test name * fix: Make sure that errStateStoreInitDiag suggests `init` when the store is uninitialised, and suggest `state migrate` + `init -reconfigure` when a migration is needed * fix: Make errBackendToStateStoreInitDiag suggest the correct commands for a state migration. * fix: Standardise on "run <command>" over "use <command>" in error messages * test: Update tests about handling changes in a state store's configuration. We need to re-implement these tests in the context of testing a new `state migrate` command * test: Remove test about handling provider updates in the context of PSS. We need to re-implement this test in the context of testing a new `state migrate` command with an `-upgrade` flag. We also need to implement behaviour in `init` that blocks upgrading the PSS provider. * test: Update test where `init` detects a `state_store` block is removed. * test: Update test where `init` detects a migration from state_store to backend * test: Update test where `init` detects a migration from backend to state_store * test: Update test where `init` detects a migration from the cloud backend to state_store * test: Update E2E test error message assertions to match recent changes	6 days ago
Sarah French	c05eaaf20d	PSS: Refactor how we handle unmanaged providers, add support for using dev_override (#38269) ... * feat: Enable use of developer override providers when using PSS * feat: Store how a provider was supplied to Terraform in the backend state file. This allows triggering a prompt for state migration if there's a change between using a managed provider versus an unmanaged/override provider. * test: Update all PSS-related backend state files in test fixtures to include new, necessary provider_supply_mode data. * fix: Avoid duplicate dev_override warnings * refactor: Change how we determine how a provider is supplied to Terraform. By using supply mode data we prevent multiple parts of the code checking if a given provider is reattached/builtin/etc... * test: Add separate tests showing a built-in or dev override provider being used for the main workflow using PSS * test: Add E2E tests that characterise current behaviour when how a provider is supplied is changed partway through different workflows * fix: Tolerate missing default workspace when using PSS and init handles minor changes in state store configuration. * feat: `init`-related code will prompt a user to migrate state if Terraform detects a swap between managed and unmanaged providers being used for PSS. Internally, what happens is the different version data (null versus a value being present) impacts the hash of the state store. This then triggers logic where TF checks if a migration is needed or if the new hash value should be silently updated in the backend state file. We always prompt for migration. * refactor: Add `NotManagedByTerraform` method to `ProviderSupplyMode` * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	1 week ago
Kristin Laemmert	002476034a	feat(cli): add -json flag for state show (#38341) ... adds json output for state show. The output is modeled after Validate's json output, which includes any diagnostics as part of the json response (instead of returning non-json errors) once the view is configured.	1 week ago
James Bardin	a9d41d0683	Merge pull request #38378 from hashicorp/jbardin/provider-consumers ... refactoring GraphNodeProviderConsumer	1 week ago
James Bardin	ee47cd3761	refactor GraphNodeProviderConsumer ... The overlapping Provider and Provider methods were both confusing and made extending functionality more difficult than it needed to be. Instead of slightly different methods returning similar things, we can return a single ProviderRef struct, which contains all the provider resolution information from a single method.	1 week ago
Daniel Banck	cd5eb226cc	Bump github.com/go-jose/go-jose/v4 to v4.1.4	1 week ago
Sarah French	2c5e03f229	Bump go-getter to v1.8.6, bump Go version, address breaking changes introduced by dependency bump. (#38374) ... * chore: go get github.com/hashicorp/go-getter@v1.8.6 & make syncdeps. Replace deprecated methods. The interceptor methods used in the rpcapi package needed to be replaced with the new stats-handlers. These were removed around v1.36.0 of the go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency * chore: Update .go-version * tests: Address breaking change in cloud.google.com/go/storage dependency that affects returned errors See 0dd7d3d62e for more information.	1 week ago
James Bardin	6aecbc1770	ConfigTransformer mode filter is unused	2 weeks ago
dependabot[bot]	ee69dce41b	build(deps): bump the github-actions-backward-compatible group with 2 updates (#38329) ... Bumps the github-actions-backward-compatible group with 2 updates: [actions/setup-go](https://github.com/actions/setup-go) and [actions/cache](https://github.com/actions/cache). Updates `actions/setup-go` from 6.3.0 to 6.4.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](4b73464bb3...4a3601121d) Updates `actions/cache` from 5.0.3 to 5.0.4 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](cdf6c1fa76...668228422a) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions-backward-compatible - dependency-name: actions/cache dependency-version: 5.0.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions-backward-compatible ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 weeks ago
Sarah French	9b970d5454	chore: go get go.opentelemetry.io/otel/sdk@v1.43.0 & make syncdeps (#38366)	2 weeks ago
Sarah French	6f6fef17a3	Bump github.com/aws/aws-sdk-go-v2 related packages to address reported vulnerability (#38362) ... * chore: go get github.com/aws/aws-sdk-go-v2/service/s3@v1.97.3 * chore: make syncdeps	2 weeks ago
Daniel Schmidt	5ca099c884	stacks: close providers when getting the provider schema	2 weeks ago
Sarah French	ae14dc3ea8	refactor: Stop workspace new, show, and select commands using `ModulePath` method to determine the working directory (#38358) ... * test: Add test defining how workspace subcommands react to unexpected arguments. * refactor: Update `workspace new` and `select` commands to access the config path using `c.WorkingDir.RootModuleDir()` * refactor: Update `workspace delete` command to access the config path using `c.WorkingDir.RootModuleDir()` This results in test failures because the delete command's implementation doesn't indirectly invoke the (Meta).fixupMissingWorkingDir method. Other workspace subcommands do invoke the fixup method via calling (Meta).Workspace, which causes (Meta).DataDir to be invoked, which invokes the fixup. * tests: Update all workspace tests to include a `WorkingDir` value in the `Meta`. Prior to this change some commands would fixup this missing data, and depending on whether the meta was reused or not that would impact testing other commands. Commands that tested only the delete command would fail due to a missing workspace due to this.	2 weeks ago
Kristin Laemmert	e3d2b7de8b	fix(import): include provider local in generated resource cfg when set in import ... By the time we get to the config generation during terraform plan, terraform didn't have access to the import config to see if a provider had been specified by localname. This is working fine for providers with aliases, and terraform was identifying the correct AbsProvider, but it was still missing from the generated configuration. I've addressed this by adding a struct which carries both the evaluated import target (cty.Value) and the decoded import config, so that generateHCLResourceDef can now use the ProviderConfigRef (if set). I have also added a test to context_plan_import_test that verifies localname is honored.	3 weeks ago
Samsondeen	ca02fd9c2a	Add aliases for false positive CVE (#38332)	3 weeks ago
dependabot[bot]	8b9fe1a7f6	Bump github.com/antchfx/xpath from 1.1.10 to 1.3.6 ... Bumps [github.com/antchfx/xpath](https://github.com/antchfx/xpath) from 1.1.10 to 1.3.6. - [Release notes](https://github.com/antchfx/xpath/releases) - [Commits](https://github.com/antchfx/xpath/compare/v1.1.10...v1.3.6) --- updated-dependencies: - dependency-name: github.com/antchfx/xpath dependency-version: 1.3.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	3 weeks ago
Brandon Croft	b4ddd25f6e	Bump terraform-svchost to 0.2.1 (#38236)	3 weeks ago
James Bardin	86b92092d0	Merge pull request #38305 from hashicorp/jbardin/computed-blocks ... Introduce handling of optional and computed blocks	3 weeks ago
Daniel Banck	6843a8dcd7	Use variables from planfile during a local run from plan ... During apply all variables required to load configuration should be available from the planfile. We shouldn't run our regular checks for variable values.	3 weeks ago
Daniel Banck	f29046037f	Add regression test for apply with vars ... Running an apply from a plan should not raise diagnostics for missing variables. All non-ephemeral variables are already available in the planfile.	3 weeks ago
Kristin Laemmert	abf692ccd5	actions: move condition evaluation into configs package ... We have several requirements for action conditions which can all be checked while loading configuration. This PR moves action condition validation into the configs package (without removing any now-duplicated checks from the terraform package). The (now) duplicated checks will be removed as the actions work continues. I've also added tests to the config package, and removed tests that are now failing because we catch the error much earlier.	3 weeks ago
James Bardin	259c468fb1	Merge pull request #38318 from hashicorp/jbardin/bastion-host-key ... fix for bastion host key checking in ssh provisioner connections	3 weeks ago
James Bardin	06052bd3d7	validate computed block schemas in core ... We haven't enforced internal validate in core due to legacy providers, but we can make sure computed blocks are handled consistently from here on out.	3 weeks ago
James Bardin	d0e3f0070d	require stricter validation for computed blocks ... try to prevent sloppy block handling up front by ensuring computed values can only contain computed values.	3 weeks ago
James Bardin	702a6978cd	CHANGELOG	3 weeks ago
Daniel Banck	6853d72303	command: test `state pull` with const variables	3 weeks ago
Daniel Banck	b08bd10508	Fix existing `state pull` tests ... The tests now check for a specific resource in the output.	3 weeks ago
Daniel Banck	4a7a724cd0	command: test `validate` with const variables	3 weeks ago
Daniel Banck	254ddfa276	command: test `graph` with const variables	3 weeks ago
Daniel Banck	e81ffa2a02	command: test `providers` with const variables	3 weeks ago
Daniel Banck	57f4867fe1	command: test `providers lock` with const variables	3 weeks ago