Merge pull request #5355 from jtopjian/openstack-domain-env-vars

provider/openstack: Add Support for Domain environment variables

builtin/providers/openstack/provider.go

@@ -47,14 +47,14 @@ func Provider() terraform.ResourceProvider {
 				DefaultFunc: envDefaultFuncAllowMissing("OS_AUTH_TOKEN"),
 			},
 			"domain_id": &schema.Schema{
-				Type:     schema.TypeString,
+				Type:        schema.TypeString,
-				Optional: true,
+				Optional:    true,
-				Default:  "",
+				DefaultFunc: envDefaultFuncAllowMissing("OS_DOMAIN_ID"),
 			},
 			"domain_name": &schema.Schema{
-				Type:     schema.TypeString,
+				Type:        schema.TypeString,
-				Optional: true,
+				Optional:    true,
-				Default:  "",
+				DefaultFunc: envDefaultFuncAllowMissing("OS_DOMAIN_NAME"),
 			},
 			"insecure": &schema.Schema{
 				Type:     schema.TypeBool,

website/source/docs/providers/openstack/index.html.markdown

@@ -48,9 +48,11 @@ The following arguments are supported:
 
 * `api_key` - (Optional; Required if not using `password`)
 
-* `domain_id` - (Optional)
+* `domain_id` - (Optional) If omitted, the `OS_DOMAIN_ID` environment
+    variable is used.
 
-* `domain_name` - (Optional)
+* `domain_name` - (Optional) If omitted, the `OS_DOMAIN_NAME`
+    environment variable is used.
 
 * `tenant_id` - (Optional)