don't explicitly specify defaults in argument parsing

pull/38186/head
Daniel Schmidt 2 days ago
parent 9f3c282096
commit b9f6f14003
No known key found for this signature in database
GPG Key ID: 377C3A4D62FBBBE2

@ -51,9 +51,7 @@ type StateMv struct {
// representing the best effort interpretation of the arguments.
func ParseStateMv(args []string) (*StateMv, tfdiags.Diagnostics) {
var diags tfdiags.Diagnostics
mv := &StateMv{
StateLock: true,
}
mv := &StateMv{}
cmdFlags := defaultFlagSet("state mv")
cmdFlags.BoolVar(&mv.DryRun, "dry-run", false, "dry run")

@ -18,31 +18,22 @@ func TestParseStateMv_valid(t *testing.T) {
"addresses only": {
[]string{"test_instance.foo", "test_instance.bar"},
&StateMv{
DryRun: false,
BackupPath: "-",
BackupOutPath: "-",
StateLock: true,
StateLockTimeout: 0,
StatePath: "",
StateOutPath: "",
IgnoreRemoteVersion: false,
SourceAddr: "test_instance.foo",
DestAddr: "test_instance.bar",
BackupPath: "-",
BackupOutPath: "-",
StateLock: true,
SourceAddr: "test_instance.foo",
DestAddr: "test_instance.bar",
},
},
"dry run": {
[]string{"-dry-run", "test_instance.foo", "test_instance.bar"},
&StateMv{
DryRun: true,
BackupPath: "-",
BackupOutPath: "-",
StateLock: true,
StateLockTimeout: 0,
StatePath: "",
StateOutPath: "",
IgnoreRemoteVersion: false,
SourceAddr: "test_instance.foo",
DestAddr: "test_instance.bar",
DryRun: true,
BackupPath: "-",
BackupOutPath: "-",
StateLock: true,
SourceAddr: "test_instance.foo",
DestAddr: "test_instance.bar",
},
},
"all options": {

Loading…
Cancel
Save